Re: [VOTE] Release Eclipse Plugin 1.2.0 (RC2)

2006-11-07 Thread Sachin Patel
Continue vote on..http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-plugin-1.2.0-v200611070107-deployable-RC4.zipAdditional copyrights were updated and a fix allowing server ping thread to have modifiable parameters needed to be added.On Nov 6, 2006, at 10:16 AM, Sachin Patel wrote:Ok.  Fair enough.  Please revote on..http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-plugin-1.2.0-v200611060915-deployable-RC2.zipVote will concluded in 72 hours on Nov 9, 10:00 AM EST.My +1.On Nov 6, 2006, at 9:49 AM, Kevan Miller wrote:On Nov 6, 2006, at 9:29 AM, Sachin Patel wrote: +1: Sachin Patel+0: None-1: None Sachin,Sorry, but you don't have the required number of PMC votes (IIUC correctly you need 3). Plus, it's not clear that all of your source headers have been updated...--kevan  -sachin  -sachin 

Re: [VOTE] Release Eclipse Plugin 1.2.0 (RC2)

2006-11-06 Thread Kevan Miller


On Nov 6, 2006, at 12:15 PM, Sachin Patel wrote:


Actually since you have it up, can you go ahead and fix it?


Done.

--kevan


Re: [VOTE] Release Eclipse Plugin 1.2.0 (RC2)

2006-11-06 Thread Sachin Patel
thx.  Issues resolved in...http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-plugin-1.2.0-v200611061236-deployable-RC3.zipPlease continue vote.On Nov 6, 2006, at 12:18 PM, Paul McMahan wrote:+1 once the Bouncy Castle and source header issues Kevan identifiedare resolved.PaulOn 11/6/06, Kevan Miller <[EMAIL PROTECTED]> wrote: On Nov 6, 2006, at 10:16 AM, Sachin Patel wrote:Ok.  Fair enough.  Please revote on..http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-plugin-1.2.0-v200611060915-deployable-RC2.zipVote will concluded in 72 hours on Nov 9, 10:00 AM EST.Sachin,G 1.1.1 added Bouncy Castle to the LICENSE and NOTICE files. Since you areincluding geronimo-util, they should be added to the your notice and licensefiles, also. I don't know of a way to automatically aggregate this LICENSEand NOTICE information, but it would sure be nice...Minor, but it looks like NOTICE has a mix of DOS and UNIX line endings.I tried out rat (release audit tool) from http://code.google.com/p/arat/Seems pretty useful. I'll point it at Geronimo 1.2, sometime this week.It identified that the following source files were missing appropriateheaders. Are .classpath, .project, and .option files really meant to beunder svn control? There were 3 obvious source files that are missingheaders...==.classpath(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model/.classpath)==.project(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model/.project)==.classpath(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model.edit/.classpath)==.project(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model.edit/.project)==.classpath(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model/.classpath)==.project(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model/.project)==.classpath(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model.edit/.classpath)==.project(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model.edit/.project)==.project(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.runtime.common/.project)==.project(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.runtime.v1/.project)==.project(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.runtime.v11/.project)==.classpath(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/.classpath)==.options(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/.options)==.project(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/.project)==.classpath(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/.classpath)==.options(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/.options)==.project(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/.project)==.classpath(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.core/.classpath)==.options(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.core/.options)==.project(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.core/.project)==.classpath(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.ui/.classpath)==.options(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.ui/.options)==.project(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.ui/.project)==.classpath(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.core/.classpath)==.options(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.core/.options)==.project(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.core/.project)==.classpath(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/.classpath)==.options(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/.options)==.project(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/.project)==Activator.java(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/Activator.java)==Messages.java(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/internal/Messages.java)==SecurityPage.java(/Users/kevan/geroni

Re: [VOTE] Release Eclipse Plugin 1.2.0 (RC2)

2006-11-06 Thread Paul McMahan

+1 once the Bouncy Castle and source header issues Kevan identified
are resolved.

Paul

On 11/6/06, Kevan Miller <[EMAIL PROTECTED]> wrote:



On Nov 6, 2006, at 10:16 AM, Sachin Patel wrote:
Ok.  Fair enough.  Please revote on..

http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-plugin-1.2.0-v200611060915-deployable-RC2.zip

Vote will concluded in 72 hours on Nov 9, 10:00 AM EST.


Sachin,
G 1.1.1 added Bouncy Castle to the LICENSE and NOTICE files. Since you are
including geronimo-util, they should be added to the your notice and license
files, also. I don't know of a way to automatically aggregate this LICENSE
and NOTICE information, but it would sure be nice...

Minor, but it looks like NOTICE has a mix of DOS and UNIX line endings.

I tried out rat (release audit tool) from http://code.google.com/p/arat/
Seems pretty useful. I'll point it at Geronimo 1.2, sometime this week.

It identified that the following source files were missing appropriate
headers. Are .classpath, .project, and .option files really meant to be
under svn control? There were 3 obvious source files that are missing
headers...

==.classpath
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model/.classpath)
==.project
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model/.project)
==.classpath
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model.edit/.classpath)
==.project
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model.edit/.project)
==.classpath
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model/.classpath)
==.project
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model/.project)
==.classpath
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model.edit/.classpath)
==.project
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model.edit/.project)
==.project
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.runtime.common/.project)
==.project
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.runtime.v1/.project)
==.project
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.runtime.v11/.project)
==.classpath
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/.classpath)
==.options
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/.options)
==.project
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/.project)
==.classpath
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/.classpath)
==.options
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/.options)
==.project
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/.project)
==.classpath
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.core/.classpath)
==.options
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.core/.options)
==.project
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.core/.project)
==.classpath
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.ui/.classpath)
==.options
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.ui/.options)
==.project
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.ui/.project)
==.classpath
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.core/.classpath)
==.options
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.core/.options)
==.project
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.core/.project)
==.classpath
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/.classpath)
==.options
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/.options)
==.project
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/.project)
==Activator.java
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/Activator.java)
==Messages.java
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/internal/Messages.java)
==SecurityPage.java
(/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/pages/

Re: [VOTE] Release Eclipse Plugin 1.2.0

2006-11-06 Thread Jacek Laskowski

On 11/6/06, Kevan Miller <[EMAIL PROTECTED]> wrote:

Are all of the source headers updated?


They should all be updated. I'll be looking at them later to verify
it. (currently with access to gmail only)

Jacek

--
Jacek Laskowski
http://www.jaceklaskowski.pl


Re: [VOTE] Release Eclipse Plugin 1.2.0 (RC2)

2006-11-06 Thread Sachin Patel
Actually since you have it up, can you go ahead and fix it?On Nov 6, 2006, at 12:02 PM, Kevan Miller wrote:On Nov 6, 2006, at 10:16 AM, Sachin Patel wrote:Ok.  Fair enough.  Please revote on..http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-plugin-1.2.0-v200611060915-deployable-RC2.zipVote will concluded in 72 hours on Nov 9, 10:00 AM EST.Sachin,G 1.1.1 added Bouncy Castle to the LICENSE and NOTICE files. Since you are including geronimo-util, they should be added to the your notice and license files, also. I don't know of a way to automatically aggregate this LICENSE and NOTICE information, but it would sure be nice...Minor, but it looks like NOTICE has a mix of DOS and UNIX line endings.I tried out rat (release audit tool) from http://code.google.com/p/arat/ Seems pretty useful. I'll point it at Geronimo 1.2, sometime this week.It identified that the following source files were missing appropriate headers. Are .classpath, .project, and .option files really meant to be under svn control? There were 3 obvious source files that are missing headers...==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model/.classpath)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model.edit/.classpath)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model.edit/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model/.classpath)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model.edit/.classpath)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model.edit/.project)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.runtime.common/.project)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.runtime.v1/.project)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.runtime.v11/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/.classpath)==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/.options)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/.classpath)==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/.options)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.core/.classpath)==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.core/.options)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.core/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.ui/.classpath)==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.ui/.options)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.ui/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.core/.classpath)==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.core/.options)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.core/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/.classpath)==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/.options)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/.project)==Activator.java (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/Activator.java)==Messages.java (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/internal/Messages.java)==SecurityPage.java (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/pages/SecurityPage.java)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/pl

Re: [VOTE] Release Eclipse Plugin 1.2.0 (RC2)

2006-11-06 Thread Sachin Patel
Yes the .option and .classpath files need to be under source control.  The maven eclipse plugin does not correctly generate these for eclipse bundles.  The .options file could be autogenerated with a plugin, but have not done this yet.I'll fix the LICENSE and NOTICE files for Bouncy Castle.On Nov 6, 2006, at 12:02 PM, Kevan Miller wrote:On Nov 6, 2006, at 10:16 AM, Sachin Patel wrote:Ok.  Fair enough.  Please revote on..http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-plugin-1.2.0-v200611060915-deployable-RC2.zipVote will concluded in 72 hours on Nov 9, 10:00 AM EST.Sachin,G 1.1.1 added Bouncy Castle to the LICENSE and NOTICE files. Since you are including geronimo-util, they should be added to the your notice and license files, also. I don't know of a way to automatically aggregate this LICENSE and NOTICE information, but it would sure be nice...Minor, but it looks like NOTICE has a mix of DOS and UNIX line endings.I tried out rat (release audit tool) from http://code.google.com/p/arat/ Seems pretty useful. I'll point it at Geronimo 1.2, sometime this week.It identified that the following source files were missing appropriate headers. Are .classpath, .project, and .option files really meant to be under svn control? There were 3 obvious source files that are missing headers...==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model/.classpath)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model.edit/.classpath)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model.edit/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model/.classpath)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model.edit/.classpath)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model.edit/.project)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.runtime.common/.project)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.runtime.v1/.project)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.runtime.v11/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/.classpath)==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/.options)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/.classpath)==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/.options)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.core/.classpath)==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.core/.options)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.core/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.ui/.classpath)==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.ui/.options)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.ui/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.core/.classpath)==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.core/.options)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.core/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/.classpath)==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/.options)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/.project)==Activator.java (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/Activator.java)==Messages.java (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/internal/Messages.java)==Sec

Re: [VOTE] Release Eclipse Plugin 1.2.0 (RC2)

2006-11-06 Thread Kevan Miller
On Nov 6, 2006, at 10:16 AM, Sachin Patel wrote:Ok.  Fair enough.  Please revote on..http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-plugin-1.2.0-v200611060915-deployable-RC2.zipVote will concluded in 72 hours on Nov 9, 10:00 AM EST.Sachin,G 1.1.1 added Bouncy Castle to the LICENSE and NOTICE files. Since you are including geronimo-util, they should be added to the your notice and license files, also. I don't know of a way to automatically aggregate this LICENSE and NOTICE information, but it would sure be nice...Minor, but it looks like NOTICE has a mix of DOS and UNIX line endings.I tried out rat (release audit tool) from http://code.google.com/p/arat/ Seems pretty useful. I'll point it at Geronimo 1.2, sometime this week.It identified that the following source files were missing appropriate headers. Are .classpath, .project, and .option files really meant to be under svn control? There were 3 obvious source files that are missing headers...==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model/.classpath)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model.edit/.classpath)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model.edit/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model/.classpath)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model.edit/.classpath)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model.edit/.project)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.runtime.common/.project)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.runtime.v1/.project)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.runtime.v11/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/.classpath)==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/.options)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/.classpath)==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/.options)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.core/.classpath)==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.core/.options)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.core/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.ui/.classpath)==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.ui/.options)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.ui/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.core/.classpath)==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.core/.options)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.core/.project)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/.classpath)==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/.options)==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/.project)==Activator.java (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/Activator.java)==Messages.java (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/internal/Messages.java)==SecurityPage.java (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/pages/SecurityPage.java)==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.v11.deployment.model/.classpath)==.project (/Users/kevan/geronimo/devtools/eclips

Re: [VOTE] Release Eclipse Plugin 1.2.0

2006-11-06 Thread Matt Hogstrom
Sachin,My apologies on not voting.  I was confused about the source headers as well and thought a new vote would be forthcoming. What is the current status on the original vote.  Are you re-spinning and starting a new vote?  If so I'll commit to having my response within the 72-hours.  Apologies for any confusion.On Oct 31, 2006, at 11:32 AM, Sachin Patel wrote:The Eclipse Plugin v1.2.0 is ready for release.  The plugin has been updated and re-written to move away from the WTP Generic Server Framework, and no longer relies on the Generic Server implementation in WTP.  Other bug fixes and feature updates are indicated in the release notes.http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-plugin-1.2.0-v20061037-deployable.ziphttp://people.apache.org/~sppatel/PLUGIN_RELEASE-NOTES-1.2.0.txtThe driver requires the 1.5.1 release of WTP and is available for download here...http://download.eclipse.org/webtools/downloads/drops/R1.5/R-1.5.1-200609230508/Note: Unfortunately, we will no longer be able to maintain equal versions between the server and the plugin, as the plugins where incremented from either 1.0.0 or 1.0.1 to 1.1.0 due to the fact that the changes where not "minor".  The feature version was then bumped from 1.1.0 to 1.2.0 to indicate the "non-maintenance" release and thus no longer matches the server version.[+1] Release[0] No opinion[-1] Do not releaseI'll plan on concluding the vote on Monday, November 6th at 9 AM EDT-sachin  Matt Hogstrom[EMAIL PROTECTED] 

Re: [VOTE] Release Eclipse Plugin 1.2.0

2006-11-06 Thread Kevan Miller

Are all of the source headers updated?

--kevan


Re: [VOTE] Release Eclipse Plugin 1.2.0

2006-11-06 Thread Sachin Patel
+1 after fixing copyrightsOn Oct 31, 2006, at 11:32 AM, Sachin Patel wrote:The Eclipse Plugin v1.2.0 is ready for release.  The plugin has been updated and re-written to move away from the WTP Generic Server Framework, and no longer relies on the Generic Server implementation in WTP.  Other bug fixes and feature updates are indicated in the release notes.http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-plugin-1.2.0-v20061037-deployable.ziphttp://people.apache.org/~sppatel/PLUGIN_RELEASE-NOTES-1.2.0.txtThe driver requires the 1.5.1 release of WTP and is available for download here...http://download.eclipse.org/webtools/downloads/drops/R1.5/R-1.5.1-200609230508/Note: Unfortunately, we will no longer be able to maintain equal versions between the server and the plugin, as the plugins where incremented from either 1.0.0 or 1.0.1 to 1.1.0 due to the fact that the changes where not "minor".  The feature version was then bumped from 1.1.0 to 1.2.0 to indicate the "non-maintenance" release and thus no longer matches the server version.[+1] Release[0] No opinion[-1] Do not releaseI'll plan on concluding the vote on Monday, November 6th at 9 AM EDT-sachin  -sachin 

Re: [VOTE] Release Eclipse Plugin 1.2.0

2006-11-03 Thread Jason Dillon
I have used the Copyright plugin before... its mostly usable... best  
results if you override the defaults for each type with the exact  
text you want.


Wish it was easier to enable the profile for each module, but you  
gotta do that by hand.


--jason


On Nov 3, 2006, at 1:31 PM, Jacek Laskowski wrote:


On 11/3/06, Jason Dillon <[EMAIL PROTECTED]> wrote:

IDEA's Copyright plugin is handy to process files with or with out a
copyright notice.


Ah I see - http://www.intellij.org/twiki/bin/view/Main/ 
CopyrightPlugin.

I've got the open source license of IDEA recently so it's time to give
it a shot. Thanks! I hope I won't get burned out very quickly trying
all these tools and end up with nothing ;-)

Jacek

--
Jacek Laskowski
http://www.jaceklaskowski.pl




Re: [VOTE] Release Eclipse Plugin 1.2.0

2006-11-03 Thread Hernan Cunico

Hi Sachin,
I'm stuck with a deployment descriptor editor issue. I think you mentioned it's been reported already. 
Once I got it failing I am no longer able to edit geronimo-web.xml for instance. I deleted the file, recreated it, did some other stuffs but still I can not get that file opened again with the editor. Text based editors work fine.


Any pointers?

Cheers!
Hernan

Sachin Patel wrote:
The Eclipse Plugin v1.2.0 is ready for release.  The plugin has been 
updated and re-written to move away from the WTP Generic Server 
Framework, and no longer relies on the Generic Server implementation in 
WTP.  Other bug fixes and feature updates are indicated in the release 
notes.


http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-plugin-1.2.0-v20061037-deployable.zip

http://people.apache.org/~sppatel/PLUGIN_RELEASE-NOTES-1.2.0.txt

The driver requires the 1.5.1 release of WTP and is available for 
download here...


http://download.eclipse.org/webtools/downloads/drops/R1.5/R-1.5.1-200609230508/

Note: Unfortunately, we will no longer be able to maintain equal 
versions between the server and the plugin, as the plugins where 
incremented from either 1.0.0 or 1.0.1 to 1.1.0 due to the fact that the 
changes where not "minor".  The feature version was then bumped from 
1.1.0 to 1.2.0 to indicate the "non-maintenance" release and thus no 
longer matches the server version.


[+1] Release
[0] No opinion
[-1] Do not release

I'll plan on concluding the vote on Monday, November 6th at 9 AM EDT

-sachin




Re: [VOTE] Release Eclipse Plugin 1.2.0

2006-11-03 Thread Jacek Laskowski

On 11/3/06, Jason Dillon <[EMAIL PROTECTED]> wrote:

IDEA's Copyright plugin is handy to process files with or with out a
copyright notice.


Ah I see - http://www.intellij.org/twiki/bin/view/Main/CopyrightPlugin.
I've got the open source license of IDEA recently so it's time to give
it a shot. Thanks! I hope I won't get burned out very quickly trying
all these tools and end up with nothing ;-)

Jacek

--
Jacek Laskowski
http://www.jaceklaskowski.pl


Re: [VOTE] Release Eclipse Plugin 1.2.0

2006-11-03 Thread Jason Dillon
IDEA's Copyright plugin is handy to process files with or with out a  
copyright notice.


There also used to be some other more general tool to manage  
headers... but I forget what it was called.


--jason


On Nov 3, 2006, at 1:01 PM, Jacek Laskowski wrote:


On 11/3/06, Jacek Laskowski <[EMAIL PROTECTED]> wrote:

On 11/3/06, Sachin Patel <[EMAIL PROTECTED]> wrote:
> Yes I assume it needs to change.  Jacek can you run your perl  
script against

> trunk of devtools as well?

Sure. Doing now...


Whoops - 350 files to process and only 30 met the script's criteria.
The rest don't have license at all (!) It seems I need another script.

Jacek

--
Jacek Laskowski
http://www.jaceklaskowski.pl




Re: [VOTE] Release Eclipse Plugin 1.2.0

2006-11-03 Thread Jacek Laskowski

On 11/3/06, Jacek Laskowski <[EMAIL PROTECTED]> wrote:

On 11/3/06, Sachin Patel <[EMAIL PROTECTED]> wrote:
> Yes I assume it needs to change.  Jacek can you run your perl script against
> trunk of devtools as well?

Sure. Doing now...


Whoops - 350 files to process and only 30 met the script's criteria.
The rest don't have license at all (!) It seems I need another script.

Jacek

--
Jacek Laskowski
http://www.jaceklaskowski.pl


Re: [VOTE] Release Eclipse Plugin 1.2.0

2006-11-03 Thread Jacek Laskowski

On 11/3/06, Sachin Patel <[EMAIL PROTECTED]> wrote:

Yes I assume it needs to change.  Jacek can you run your perl script against
trunk of devtools as well?


Sure. Doing now...

Jacek

--
Jacek Laskowski
http://www.jaceklaskowski.pl


Re: [VOTE] Release Eclipse Plugin 1.2.0

2006-11-03 Thread Sachin Patel
Yes I assume it needs to change.  Jacek can you run your perl script against trunk of devtools as well?On Nov 3, 2006, at 1:12 PM, Paul McMahan wrote:Kevan brought http://www.apache.org/legal/src-headers.html to ourattention the other day in context of geronimo 1.2.  Does the eclipseplugin release need to be updated as well?PaulOn 10/31/06, Sachin Patel <[EMAIL PROTECTED]> wrote: The Eclipse Plugin v1.2.0 is ready for release.  The plugin has been updatedand re-written to move away from the WTP Generic Server Framework, and nolonger relies on the Generic Server implementation in WTP.  Other bug fixesand feature updates are indicated in the release notes.http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-plugin-1.2.0-v20061037-deployable.ziphttp://people.apache.org/~sppatel/PLUGIN_RELEASE-NOTES-1.2.0.txtThe driver requires the 1.5.1 release of WTP and is available for downloadhere...http://download.eclipse.org/webtools/downloads/drops/R1.5/R-1.5.1-200609230508/Note: Unfortunately, we will no longer be able to maintain equal versionsbetween the server and the plugin, as the plugins where incremented fromeither 1.0.0 or 1.0.1 to 1.1.0 due to the fact that the changes where not"minor".  The feature version was then bumped from 1.1.0 to 1.2.0 toindicate the "non-maintenance" release and thus no longer matches the serverversion.[+1] Release[0] No opinion[-1] Do not releaseI'll plan on concluding the vote on Monday, November 6th at 9 AM EDT-sachin  -sachin 

Re: [VOTE] Release Eclipse Plugin 1.2.0

2006-11-03 Thread Paul McMahan

Kevan brought http://www.apache.org/legal/src-headers.html to our
attention the other day in context of geronimo 1.2.  Does the eclipse
plugin release need to be updated as well?

Paul

On 10/31/06, Sachin Patel <[EMAIL PROTECTED]> wrote:

The Eclipse Plugin v1.2.0 is ready for release.  The plugin has been updated
and re-written to move away from the WTP Generic Server Framework, and no
longer relies on the Generic Server implementation in WTP.  Other bug fixes
and feature updates are indicated in the release notes.

http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-plugin-1.2.0-v20061037-deployable.zip

http://people.apache.org/~sppatel/PLUGIN_RELEASE-NOTES-1.2.0.txt

The driver requires the 1.5.1 release of WTP and is available for download
here...

http://download.eclipse.org/webtools/downloads/drops/R1.5/R-1.5.1-200609230508/

Note: Unfortunately, we will no longer be able to maintain equal versions
between the server and the plugin, as the plugins where incremented from
either 1.0.0 or 1.0.1 to 1.1.0 due to the fact that the changes where not
"minor".  The feature version was then bumped from 1.1.0 to 1.2.0 to
indicate the "non-maintenance" release and thus no longer matches the server
version.

[+1] Release
[0] No opinion
[-1] Do not release

I'll plan on concluding the vote on Monday, November 6th at 9 AM EDT

-sachin