Re: jspc-maven-plugin
Joe Bohn wrote: > Yes, I think we said almost the same thing. I was proposing to use > Tomcat (Jasper) for the jsp compilation for both Tomcat and Jetty even > though the Jetty runtime will most likely be using Glassfish. If you > can configure it such that we use Jasper for Tomcat and can optionally > use Glassfish for Jetty that would be great. Yup...I think that's doable. Jeff > > Joe
Re: jspc-maven-plugin
Jeff Genender wrote: (I think we may have just said the same thing, but I am clarifying). Yes, I think we said almost the same thing. I was proposing to use Tomcat (Jasper) for the jsp compilation for both Tomcat and Jetty even though the Jetty runtime will most likely be using Glassfish. If you can configure it such that we use Jasper for Tomcat and can optionally use Glassfish for Jetty that would be great. Joe
Re: jspc-maven-plugin
I noticed the same thing last week. I too started to remove the references on my local build without any adverse effects. Obviously, I didn't get back to this or check the changes in ... but I think it's safe to remove them. Joe Paul McMahan wrote: In several of the poms that invoke jspc-maven-plugin I see: tomcat jasper-runtime provided I have a vague recollection about needing this dependency for a previous version of the jspc plugin. Or maybe that was something else and I'm getting mixed up. Now we're using version 1.4.6 of the plugin and if I remove the dependency then the build still seems to work correctly (but I don't totally trust my build env right now :-) Does anyone know for sure why its there and if it's still necessary? Best wishes, Paul
Re: jspc-maven-plugin
[EMAIL PROTECTED] wrote: > No it is not a relic. We needed this for jspc at one point... Might be > included now by the plugin automatically. > Yup...the plugin handles it now. Jeff
Re: jspc-maven-plugin
Joe Bohn wrote: > While Tomcat is creating a new version of Jasper it looks like Jetty is > using Glassfish. I guess we can use Jasper to compile the JSPs even if > Glassfish is used to in the runtime. We could also look into using > Jasper for both Tomcat and Jetty but since Jetty is already using > Glassfish I was assuming that we would do the same. I am not keen on using Glassfish to compile for Tomcat. I suspect inconsistencies *may* show. Since Jetty is using Glassfish components, it works for them, but for Tomcat, it may not fare so well (different compile against a different runtime). I will use the Glassfish as a declaration (i.e. for use with Jetty), but I would prefer we flag and use Tomcat for Tomcat for the reasons just stated. So lets give it a shot, but use Tomcat in the end ;-) (I think we may have just said the same thing, but I am clarifying). Jeff > > Joe > > > Jeff Genender wrote: >> >> Paul McMahan wrote: >> >>> Geronimo 2.0 will be using jetty and tomcat v6 which implement the new >>> JSP spec. I think that means that for Geronimo 2.0 we'll need a new >>> version of the jspc maven plugin that references the tomcat v6 >>> artifacts instead of v5.5.15. Otherwise I think the plugin would not >>> be able to compile JSP 2.1. Does that sound right? >> >> >> Your wish is my command ;-) I can make the plugin build for both (2.0 >> and 2.1) based on either JVM used, or a profile. >> >> I need to know if we will use the Glassfish jars or if Tomcat is >> coughing one up. >> >> Jeff >> >> >>> Best wishes, >>> Paul >>> >>> >>> On 11/21/06, Jeff Genender <[EMAIL PROTECTED]> wrote: >>> 1.4.6 was a major overhaul. I believe the runtime is only needed during the compile stage. So I think you can ditch it. Although you will find out real quick if it's still needed ;-) Jeff >> >>
Re: jspc-maven-plugin
When was this added to the jspc-m-p? Is it safe to remove these deps from our poms now? --jason On Nov 20, 2006, at 8:10 PM, Jeff Genender wrote: [EMAIL PROTECTED] wrote: No it is not a relic. We needed this for jspc at one point... Might be included now by the plugin automatically. Yup...the plugin handles it now. Jeff
Re: jspc-maven-plugin
No it is not a relic. We needed this for jspc at one point... Might be included now by the plugin automatically. --jason -Original Message- From: "Prasad Kashyap" <[EMAIL PROTECTED]> Date: Mon, 20 Nov 2006 21:06:04 To:dev@geronimo.apache.org Subject: Re: jspc-maven-plugin I guess this is a relic that we have preserved from our maven 1 days. We just need to ensure we don't have any hiccups during server runtime too after we have removed this. Cheers Prasad On 11/20/06, Paul McMahan <[EMAIL PROTECTED]> wrote: > In several of the poms that invoke jspc-maven-plugin I see: > > > > tomcat > jasper-runtime > provided > > > I have a vague recollection about needing this dependency for a > previous version of the jspc plugin. Or maybe that was something else > and I'm getting mixed up. Now we're using version 1.4.6 of the plugin > and if I remove the dependency then the build still seems to work > correctly (but I don't totally trust my build env right now :-) Does > anyone know for sure why its there and if it's still necessary? > > Best wishes, > Paul >
Re: jspc-maven-plugin
Paul McMahan wrote: > Geronimo 2.0 will be using jetty and tomcat v6 which implement the new > JSP spec. I think that means that for Geronimo 2.0 we'll need a new > version of the jspc maven plugin that references the tomcat v6 > artifacts instead of v5.5.15. Otherwise I think the plugin would not > be able to compile JSP 2.1. Does that sound right? Your wish is my command ;-) I can make the plugin build for both (2.0 and 2.1) based on either JVM used, or a profile. I need to know if we will use the Glassfish jars or if Tomcat is coughing one up. Jeff > > Best wishes, > Paul > > > On 11/21/06, Jeff Genender <[EMAIL PROTECTED]> wrote: >> 1.4.6 was a major overhaul. I believe the runtime is only needed during >> the compile stage. So I think you can ditch it. Although you will find >> out real quick if it's still needed ;-) >> >> Jeff
Re: jspc-maven-plugin
I guess this is a relic that we have preserved from our maven 1 days. We just need to ensure we don't have any hiccups during server runtime too after we have removed this. Cheers Prasad On 11/20/06, Paul McMahan <[EMAIL PROTECTED]> wrote: In several of the poms that invoke jspc-maven-plugin I see: tomcat jasper-runtime provided I have a vague recollection about needing this dependency for a previous version of the jspc plugin. Or maybe that was something else and I'm getting mixed up. Now we're using version 1.4.6 of the plugin and if I remove the dependency then the build still seems to work correctly (but I don't totally trust my build env right now :-) Does anyone know for sure why its there and if it's still necessary? Best wishes, Paul
Re: jspc-maven-plugin
While Tomcat is creating a new version of Jasper it looks like Jetty is using Glassfish. I guess we can use Jasper to compile the JSPs even if Glassfish is used to in the runtime. We could also look into using Jasper for both Tomcat and Jetty but since Jetty is already using Glassfish I was assuming that we would do the same. Joe Jeff Genender wrote: Paul McMahan wrote: Geronimo 2.0 will be using jetty and tomcat v6 which implement the new JSP spec. I think that means that for Geronimo 2.0 we'll need a new version of the jspc maven plugin that references the tomcat v6 artifacts instead of v5.5.15. Otherwise I think the plugin would not be able to compile JSP 2.1. Does that sound right? Your wish is my command ;-) I can make the plugin build for both (2.0 and 2.1) based on either JVM used, or a profile. I need to know if we will use the Glassfish jars or if Tomcat is coughing one up. Jeff Best wishes, Paul On 11/21/06, Jeff Genender <[EMAIL PROTECTED]> wrote: 1.4.6 was a major overhaul. I believe the runtime is only needed during the compile stage. So I think you can ditch it. Although you will find out real quick if it's still needed ;-) Jeff
Re: jspc-maven-plugin
Excellent, thanks! BTW, no rush. Starting tomorrow morning I'll be glued in the captain's chair of my minivan for holiday travel until next week. By the time I get back I will probably have forgotten what JSP stands for :-) Best wishes, Paul On 11/21/06, Jeff Genender <[EMAIL PROTECTED]> wrote: Ok...let me try to whip together a 1.4.7-SNAPSHOT of the next week that allows you to choose your jasper poison. Jeff Paul McMahan wrote: > On 11/21/06, Jeff Genender <[EMAIL PROTECTED]> wrote: >> I don't see a runtime...is one needed? >> >> Jeff > > Looks like the runtime stuff got rolled into tomcat6/jasper/6.0.2-alpha.
Re: jspc-maven-plugin
I'd start commenting out items that look like they should be removed / updated. Now is the time rather than before we put out a release :) On Nov 20, 2006, at 3:52 PM, Paul McMahan wrote: In several of the poms that invoke jspc-maven-plugin I see: tomcat jasper-runtime provided I have a vague recollection about needing this dependency for a previous version of the jspc plugin. Or maybe that was something else and I'm getting mixed up. Now we're using version 1.4.6 of the plugin and if I remove the dependency then the build still seems to work correctly (but I don't totally trust my build env right now :-) Does anyone know for sure why its there and if it's still necessary? Best wishes, Paul Matt Hogstrom [EMAIL PROTECTED] When the clouds are full they pour the rain out on the earth; and whether a tree falls to the north, or it falls to the south, wherever the tree falls, there is lies.
Re: jspc-maven-plugin
1.4.6 was a major overhaul. I believe the runtime is only needed during the compile stage. So I think you can ditch it. Although you will find out real quick if it's still needed ;-) Jeff Jason Dillon wrote: > When was this added to the jspc-m-p? Is it safe to remove these deps > from our poms now? > > --jason > > > On Nov 20, 2006, at 8:10 PM, Jeff Genender wrote: > >> >> [EMAIL PROTECTED] wrote: >>> No it is not a relic. We needed this for jspc at one point... Might >>> be included now by the plugin automatically. >>> >> >> Yup...the plugin handles it now. >> >> Jeff >>
Re: jspc-maven-plugin
Ok...let me try to whip together a 1.4.7-SNAPSHOT of the next week that allows you to choose your jasper poison. Jeff Paul McMahan wrote: > On 11/21/06, Jeff Genender <[EMAIL PROTECTED]> wrote: >> I don't see a runtime...is one needed? >> >> Jeff > > Looks like the runtime stuff got rolled into tomcat6/jasper/6.0.2-alpha.
Re: jspc-maven-plugin
On 11/21/06, Jeff Genender <[EMAIL PROTECTED]> wrote: I don't see a runtime...is one needed? Jeff Looks like the runtime stuff got rolled into tomcat6/jasper/6.0.2-alpha.
Re: jspc-maven-plugin
On 11/21/06, Jeff Genender <[EMAIL PROTECTED]> wrote: Paul McMahan wrote: > Geronimo 2.0 will be using jetty and tomcat v6 which implement the new > JSP spec. I think that means that for Geronimo 2.0 we'll need a new > version of the jspc maven plugin that references the tomcat v6 > artifacts instead of v5.5.15. Otherwise I think the plugin would not > be able to compile JSP 2.1. Does that sound right? Your wish is my command ;-) I can make the plugin build for both (2.0 and 2.1) based on either JVM used, or a profile. I need to know if we will use the Glassfish jars or if Tomcat is coughing one up. Ahh, nice genie ;-) I believe Tomcat will have everything we need. I built the stuff from: https://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_2 and stashed a copy here: http://people.apache.org/~pmcmahan/maven2/ Can you take a peek there and see if it has what the plugin needs? I'm using that repo as a staging area until the tomcat guys publish the v6 jars. When they publish them some of the groupId/artifactIds will probably change, specifically I think they'll use "tomcat" for the groupId instead of "tomcat6". But I couldn't do that -- long story. Best wishes, Paul
Re: jspc-maven-plugin
I don't see a runtime...is one needed? Jeff Paul McMahan wrote: > Ahh, nice genie ;-) I believe Tomcat will have everything we need. > > I built the stuff from: > https://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_2 > and stashed a copy here: > http://people.apache.org/~pmcmahan/maven2/ > > Can you take a peek there and see if it has what the plugin needs? > I'm using that repo as a staging area until the tomcat guys publish > the v6 jars. When they publish them some of the groupId/artifactIds > will probably change, specifically I think they'll use "tomcat" for > the groupId instead of "tomcat6". But I couldn't do that -- long > story. > > Best wishes, > Paul
Re: jspc-maven-plugin
I guess if the build still works with out them... then its not needed anymore. --jason On Nov 20, 2006, at 1:44 PM, Matt Hogstrom wrote: I'd start commenting out items that look like they should be removed / updated. Now is the time rather than before we put out a release :) On Nov 20, 2006, at 3:52 PM, Paul McMahan wrote: In several of the poms that invoke jspc-maven-plugin I see: tomcat jasper-runtime provided I have a vague recollection about needing this dependency for a previous version of the jspc plugin. Or maybe that was something else and I'm getting mixed up. Now we're using version 1.4.6 of the plugin and if I remove the dependency then the build still seems to work correctly (but I don't totally trust my build env right now :-) Does anyone know for sure why its there and if it's still necessary? Best wishes, Paul Matt Hogstrom [EMAIL PROTECTED] When the clouds are full they pour the rain out on the earth; and whether a tree falls to the north, or it falls to the south, wherever the tree falls, there is lies.
