[jira] [Commented] (GIRAPH-1141) Kill the job if no progress is being made

2017-03-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GIRAPH-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951657#comment-15951657
 ] 

ASF GitHub Bot commented on GIRAPH-1141:


Github user majakabiljo commented on a diff in the pull request:

https://github.com/apache/giraph/pull/33#discussion_r109251665
  
--- Diff: 
giraph-core/src/main/java/org/apache/giraph/job/CombinedWorkerProgress.java ---
@@ -204,4 +215,19 @@ public String toString() {
 }
 return sb.toString();
   }
+
+  /**
+   * Check if this instance made progress from another instance
+   *
+   * @param lastProgress Instance to compare with
+   * @return True iff progress was made
+   */
+  public boolean madeProgressFrom(CombinedWorkerProgress lastProgress) {
--- End diff --

That's why I separated getProgressString from toString, to only contain 
actual progress. For different supersteps we are looking at different numbers 
so this seemed the easiest to compare instead of having all the if-s.


> Kill the job if no progress is being made
> -
>
> Key: GIRAPH-1141
> URL: https://issues.apache.org/jira/browse/GIRAPH-1141
> Project: Giraph
>  Issue Type: New Feature
>Reporter: Maja Kabiljo
>Assignee: Maja Kabiljo
>Priority: Minor
>
> Sometimes jobs can get stuck for various reasons, it's better to have an 
> option to kill them then to keep them running holding resources.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GIRAPH-1141) Kill the job if no progress is being made

2017-03-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GIRAPH-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951648#comment-15951648
 ] 

ASF GitHub Bot commented on GIRAPH-1141:


Github user dlogothetis commented on a diff in the pull request:

https://github.com/apache/giraph/pull/33#discussion_r109250592
  
--- Diff: 
giraph-core/src/main/java/org/apache/giraph/job/CombinedWorkerProgress.java ---
@@ -204,4 +215,19 @@ public String toString() {
 }
 return sb.toString();
   }
+
+  /**
+   * Check if this instance made progress from another instance
+   *
+   * @param lastProgress Instance to compare with
+   * @return True iff progress was made
+   */
+  public boolean madeProgressFrom(CombinedWorkerProgress lastProgress) {
--- End diff --

Why not use the underlying raw numbers instead of the string? For instance, 
small changes in memory may not really mean progress.


> Kill the job if no progress is being made
> -
>
> Key: GIRAPH-1141
> URL: https://issues.apache.org/jira/browse/GIRAPH-1141
> Project: Giraph
>  Issue Type: New Feature
>Reporter: Maja Kabiljo
>Assignee: Maja Kabiljo
>Priority: Minor
>
> Sometimes jobs can get stuck for various reasons, it's better to have an 
> option to kill them then to keep them running holding resources.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GIRAPH-1140) Cleanup temp files in hdfs after job is done

2017-03-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GIRAPH-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951611#comment-15951611
 ] 

ASF GitHub Bot commented on GIRAPH-1140:


Github user majakabiljo closed the pull request at:

https://github.com/apache/giraph/pull/32


> Cleanup temp files in hdfs after job is done
> 
>
> Key: GIRAPH-1140
> URL: https://issues.apache.org/jira/browse/GIRAPH-1140
> Project: Giraph
>  Issue Type: Bug
>Reporter: Maja Kabiljo
>Assignee: Maja Kabiljo
>
> Currently we are not cleaning up temp files we create in hdfs, fix it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GIRAPH-1141) Kill the job if no progress is being made

2017-03-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GIRAPH-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951612#comment-15951612
 ] 

ASF GitHub Bot commented on GIRAPH-1141:


GitHub user majakabiljo opened a pull request:

https://github.com/apache/giraph/pull/33

GIRAPH-1141: Kill the job if no progress is being made

Summary: Sometimes jobs can get stuck for various reasons, it's better to 
have an option to kill them then to keep them running holding resources.

Test Plan: Ran a large job with shorter limit and verified it gets killed. 
Also ran normal successful job. mvn verify

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/majakabiljo/giraph progress

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/giraph/pull/33.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #33


commit 7b571bbbefade67b3b77273e6b291318399d810e
Author: Maja Kabiljo 
Date:   2017-03-31T20:40:48Z

GIRAPH-1141: Kill the job if no progress is being made

Summary: Sometimes jobs can get stuck for various reasons, it's better to 
have an option to kill them then to keep them running holding resources.

Test Plan: Ran a large job with shorter limit and verified it gets killed. 
Also ran normal successful job. mvn verify




> Kill the job if no progress is being made
> -
>
> Key: GIRAPH-1141
> URL: https://issues.apache.org/jira/browse/GIRAPH-1141
> Project: Giraph
>  Issue Type: New Feature
>Reporter: Maja Kabiljo
>Assignee: Maja Kabiljo
>Priority: Minor
>
> Sometimes jobs can get stuck for various reasons, it's better to have an 
> option to kill them then to keep them running holding resources.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GIRAPH-1141) Kill the job if no progress is being made

2017-03-31 Thread Maja Kabiljo (JIRA) 
Maja Kabiljo created GIRAPH-1141:


 Summary: Kill the job if no progress is being made
 Key: GIRAPH-1141
 URL: https://issues.apache.org/jira/browse/GIRAPH-1141
 Project: Giraph
  Issue Type: New Feature
Reporter: Maja Kabiljo
Assignee: Maja Kabiljo
Priority: Minor


Sometimes jobs can get stuck for various reasons, it's better to have an option 
to kill them then to keep them running holding resources.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [ACTION REQUIRED] Missing Board Report

2017-03-31 Thread Mark Thomas 
Thanks for the update.

Mark

bcc: board@a.o

On 30/03/17 23:37, Avery Ching wrote:
> Hi Mark,
> 
> Sorry we are late on the board report.  We hope to submit it in the new
> few weeks.  I was on vacation and also am currently asking a few other
> PMC members for any updates.  Again, my apologies, we will definitely
> provide our report in time for our next meeting.
> 
> Avery
> 
> On Thu, Mar 30, 2017 at 11:09 AM, Mark Thomas  > wrote:
> 
> Note private@giraph and board@ on bcc
> 
> Giraph community,
> 
> Your board report was due in February and was not submitted. Neither was
> a report submitted in March.
> 
> What is more concerning is that there has been no response to the
> multiple messages sent to the Giraph PMC regarding the missing reports.
> The board is becoming concerned about the lack of response.
> 
> A report from Giraph is expected for the next meeting. While the PMC
> chair normally takes the lead in producing this report, it
> is expected that the PMC will provide one if the chair is unable to.
> 
> If you need any help or advice putting the report together please feel
> free to reach out to me or any other board member and ask.
> 
> Mark
> on behalf of the ASF Board
> 
>