[jira] [Commented] (GIRAPH-1141) Kill the job if no progress is being made

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GIRAPH-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15955369#comment-15955369
 ] 

ASF GitHub Bot commented on GIRAPH-1141:


Github user asfgit closed the pull request at:

https://github.com/apache/giraph/pull/33


> Kill the job if no progress is being made
> -
>
> Key: GIRAPH-1141
> URL: https://issues.apache.org/jira/browse/GIRAPH-1141
> Project: Giraph
>  Issue Type: New Feature
>Reporter: Maja Kabiljo
>Assignee: Maja Kabiljo
>Priority: Minor
>
> Sometimes jobs can get stuck for various reasons, it's better to have an 
> option to kill them then to keep them running holding resources.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GIRAPH-1141) Kill the job if no progress is being made

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GIRAPH-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953731#comment-15953731
 ] 

ASF GitHub Bot commented on GIRAPH-1141:


Github user dlogothetis commented on the issue:

https://github.com/apache/giraph/pull/33
  
i missed this detail. looks ok to me.


> Kill the job if no progress is being made
> -
>
> Key: GIRAPH-1141
> URL: https://issues.apache.org/jira/browse/GIRAPH-1141
> Project: Giraph
>  Issue Type: New Feature
>Reporter: Maja Kabiljo
>Assignee: Maja Kabiljo
>Priority: Minor
>
> Sometimes jobs can get stuck for various reasons, it's better to have an 
> option to kill them then to keep them running holding resources.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GIRAPH-1141) Kill the job if no progress is being made

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GIRAPH-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951657#comment-15951657
 ] 

ASF GitHub Bot commented on GIRAPH-1141:


Github user majakabiljo commented on a diff in the pull request:

https://github.com/apache/giraph/pull/33#discussion_r109251665
  
--- Diff: 
giraph-core/src/main/java/org/apache/giraph/job/CombinedWorkerProgress.java ---
@@ -204,4 +215,19 @@ public String toString() {
 }
 return sb.toString();
   }
+
+  /**
+   * Check if this instance made progress from another instance
+   *
+   * @param lastProgress Instance to compare with
+   * @return True iff progress was made
+   */
+  public boolean madeProgressFrom(CombinedWorkerProgress lastProgress) {
--- End diff --

That's why I separated getProgressString from toString, to only contain 
actual progress. For different supersteps we are looking at different numbers 
so this seemed the easiest to compare instead of having all the if-s.


> Kill the job if no progress is being made
> -
>
> Key: GIRAPH-1141
> URL: https://issues.apache.org/jira/browse/GIRAPH-1141
> Project: Giraph
>  Issue Type: New Feature
>Reporter: Maja Kabiljo
>Assignee: Maja Kabiljo
>Priority: Minor
>
> Sometimes jobs can get stuck for various reasons, it's better to have an 
> option to kill them then to keep them running holding resources.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GIRAPH-1141) Kill the job if no progress is being made

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GIRAPH-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951648#comment-15951648
 ] 

ASF GitHub Bot commented on GIRAPH-1141:


Github user dlogothetis commented on a diff in the pull request:

https://github.com/apache/giraph/pull/33#discussion_r109250592
  
--- Diff: 
giraph-core/src/main/java/org/apache/giraph/job/CombinedWorkerProgress.java ---
@@ -204,4 +215,19 @@ public String toString() {
 }
 return sb.toString();
   }
+
+  /**
+   * Check if this instance made progress from another instance
+   *
+   * @param lastProgress Instance to compare with
+   * @return True iff progress was made
+   */
+  public boolean madeProgressFrom(CombinedWorkerProgress lastProgress) {
--- End diff --

Why not use the underlying raw numbers instead of the string? For instance, 
small changes in memory may not really mean progress.


> Kill the job if no progress is being made
> -
>
> Key: GIRAPH-1141
> URL: https://issues.apache.org/jira/browse/GIRAPH-1141
> Project: Giraph
>  Issue Type: New Feature
>Reporter: Maja Kabiljo
>Assignee: Maja Kabiljo
>Priority: Minor
>
> Sometimes jobs can get stuck for various reasons, it's better to have an 
> option to kill them then to keep them running holding resources.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GIRAPH-1141) Kill the job if no progress is being made

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GIRAPH-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951612#comment-15951612
 ] 

ASF GitHub Bot commented on GIRAPH-1141:


GitHub user majakabiljo opened a pull request:

https://github.com/apache/giraph/pull/33

GIRAPH-1141: Kill the job if no progress is being made

Summary: Sometimes jobs can get stuck for various reasons, it's better to 
have an option to kill them then to keep them running holding resources.

Test Plan: Ran a large job with shorter limit and verified it gets killed. 
Also ran normal successful job. mvn verify

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/majakabiljo/giraph progress

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/giraph/pull/33.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #33


commit 7b571bbbefade67b3b77273e6b291318399d810e
Author: Maja Kabiljo 
Date:   2017-03-31T20:40:48Z

GIRAPH-1141: Kill the job if no progress is being made

Summary: Sometimes jobs can get stuck for various reasons, it's better to 
have an option to kill them then to keep them running holding resources.

Test Plan: Ran a large job with shorter limit and verified it gets killed. 
Also ran normal successful job. mvn verify




> Kill the job if no progress is being made
> -
>
> Key: GIRAPH-1141
> URL: https://issues.apache.org/jira/browse/GIRAPH-1141
> Project: Giraph
>  Issue Type: New Feature
>Reporter: Maja Kabiljo
>Assignee: Maja Kabiljo
>Priority: Minor
>
> Sometimes jobs can get stuck for various reasons, it's better to have an 
> option to kill them then to keep them running holding resources.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)