[GitHub] [incubator-gobblin] htran1 commented on a change in pull request #2688: [GOBBLIN-827] Add more events
htran1 commented on a change in pull request #2688: [GOBBLIN-827] Add more
events
URL: https://github.com/apache/incubator-gobblin/pull/2688#discussion_r305069336
##
File path:
gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/event/EntityMissingEventBuilder.java
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.metrics.event;
+
+import java.util.Map;
+
+import org.apache.commons.lang.StringUtils;
+
+import lombok.Getter;
+
+import org.apache.gobblin.metrics.GobblinTrackingEvent;
+
+
+/**
+ * An event reporting missing any kind of entity, e.g. WorkUnit, Record, kafka
topic
+ */
+public class EntityMissingEventBuilder extends GobblinEventBuilder {
Review comment:
Builder is a confusing name here since the object is directly used to host
the values and not just for building the event. There is a `fromEvent`. Instead
of `build`, maybe `toEvent` makes more sense. This can be considered in a
future refactoring.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Work logged] (GOBBLIN-827) Add more events
[
https://issues.apache.org/jira/browse/GOBBLIN-827?focusedWorklogId=279245&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279245
]
ASF GitHub Bot logged work on GOBBLIN-827:
--
Author: ASF GitHub Bot
Created on: 18/Jul/19 19:00
Start Date: 18/Jul/19 19:00
Worklog Time Spent: 10m
Work Description: htran1 commented on pull request #2688: [GOBBLIN-827]
Add more events
URL: https://github.com/apache/incubator-gobblin/pull/2688#discussion_r305069336
##
File path:
gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/event/EntityMissingEventBuilder.java
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.metrics.event;
+
+import java.util.Map;
+
+import org.apache.commons.lang.StringUtils;
+
+import lombok.Getter;
+
+import org.apache.gobblin.metrics.GobblinTrackingEvent;
+
+
+/**
+ * An event reporting missing any kind of entity, e.g. WorkUnit, Record, kafka
topic
+ */
+public class EntityMissingEventBuilder extends GobblinEventBuilder {
Review comment:
Builder is a confusing name here since the object is directly used to host
the values and not just for building the event. There is a `fromEvent`. Instead
of `build`, maybe `toEvent` makes more sense. This can be considered in a
future refactoring.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 279245)
Time Spent: 50m (was: 40m)
> Add more events
> ---
>
> Key: GOBBLIN-827
> URL: https://issues.apache.org/jira/browse/GOBBLIN-827
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zhixiong Chen
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Add the following events
> - `JobStateEventBuilder` to report gobblin job state or MR job state
> - `EntityMissingEventBuilder` to report a missing instance of a certain entity
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [incubator-gobblin] asfgit closed pull request #2688: [GOBBLIN-827] Add more events
asfgit closed pull request #2688: [GOBBLIN-827] Add more events URL: https://github.com/apache/incubator-gobblin/pull/2688 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (GOBBLIN-827) Add more events
[ https://issues.apache.org/jira/browse/GOBBLIN-827?focusedWorklogId=279248&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279248 ] ASF GitHub Bot logged work on GOBBLIN-827: -- Author: ASF GitHub Bot Created on: 18/Jul/19 19:02 Start Date: 18/Jul/19 19:02 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2688: [GOBBLIN-827] Add more events URL: https://github.com/apache/incubator-gobblin/pull/2688 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 279248) Time Spent: 1h (was: 50m) > Add more events > --- > > Key: GOBBLIN-827 > URL: https://issues.apache.org/jira/browse/GOBBLIN-827 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zhixiong Chen >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Add the following events > - `JobStateEventBuilder` to report gobblin job state or MR job state > - `EntityMissingEventBuilder` to report a missing instance of a certain entity -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (GOBBLIN-827) Add more events
[ https://issues.apache.org/jira/browse/GOBBLIN-827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hung Tran resolved GOBBLIN-827. --- Resolution: Fixed Fix Version/s: 0.15.0 Issue resolved by pull request #2688 [https://github.com/apache/incubator-gobblin/pull/2688] > Add more events > --- > > Key: GOBBLIN-827 > URL: https://issues.apache.org/jira/browse/GOBBLIN-827 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zhixiong Chen >Priority: Major > Fix For: 0.15.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Add the following events > - `JobStateEventBuilder` to report gobblin job state or MR job state > - `EntityMissingEventBuilder` to report a missing instance of a certain entity -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (GOBBLIN-831) Fix NPE in KafkaWorkUnitPacker when there is no WorkUnit created
Zhixiong Chen created GOBBLIN-831: - Summary: Fix NPE in KafkaWorkUnitPacker when there is no WorkUnit created Key: GOBBLIN-831 URL: https://issues.apache.org/jira/browse/GOBBLIN-831 Project: Apache Gobblin Issue Type: Task Reporter: Zhixiong Chen Assignee: Zhixiong Chen -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [incubator-gobblin] jhsenjaliya commented on issue #2689: [GOBBLIN-828] Make dynamic config override job config
jhsenjaliya commented on issue #2689: [GOBBLIN-828] Make dynamic config override job config URL: https://github.com/apache/incubator-gobblin/pull/2689#issuecomment-512954255 +1, make sense to do this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (GOBBLIN-828) Make dynamic config override job config
[ https://issues.apache.org/jira/browse/GOBBLIN-828?focusedWorklogId=279270&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279270 ] ASF GitHub Bot logged work on GOBBLIN-828: -- Author: ASF GitHub Bot Created on: 18/Jul/19 19:27 Start Date: 18/Jul/19 19:27 Worklog Time Spent: 10m Work Description: jhsenjaliya commented on issue #2689: [GOBBLIN-828] Make dynamic config override job config URL: https://github.com/apache/incubator-gobblin/pull/2689#issuecomment-512954255 +1, make sense to do this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 279270) Time Spent: 20m (was: 10m) > Make dynamic config override job config > --- > > Key: GOBBLIN-828 > URL: https://issues.apache.org/jira/browse/GOBBLIN-828 > Project: Apache Gobblin > Issue Type: Bug >Reporter: Jack Moseley >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [incubator-gobblin] jhsenjaliya commented on issue #2685: [GOBBLIN-822] Upgrade log4j to log4j2 for LogRouting use-case
jhsenjaliya commented on issue #2685: [GOBBLIN-822] Upgrade log4j to log4j2 for LogRouting use-case URL: https://github.com/apache/incubator-gobblin/pull/2685#issuecomment-512962792 cant find any specific error in the build, so please review this and i will kick of another build later. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (GOBBLIN-822) upgrade log4j to log4j2
[ https://issues.apache.org/jira/browse/GOBBLIN-822?focusedWorklogId=279283&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279283 ] ASF GitHub Bot logged work on GOBBLIN-822: -- Author: ASF GitHub Bot Created on: 18/Jul/19 19:53 Start Date: 18/Jul/19 19:53 Worklog Time Spent: 10m Work Description: jhsenjaliya commented on issue #2685: [GOBBLIN-822] Upgrade log4j to log4j2 for LogRouting use-case URL: https://github.com/apache/incubator-gobblin/pull/2685#issuecomment-512962792 cant find any specific error in the build, so please review this and i will kick of another build later. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 279283) Time Spent: 10m Remaining Estimate: 0h > upgrade log4j to log4j2 > --- > > Key: GOBBLIN-822 > URL: https://issues.apache.org/jira/browse/GOBBLIN-822 > Project: Apache Gobblin > Issue Type: Sub-task >Affects Versions: 0.14.0 >Reporter: Jay Sen >Priority: Major > Fix For: 0.15.0 > > Time Spent: 10m > Remaining Estimate: 0h > > log4j2 has routing appender that would be super useful and probably only way > to achieve " job specific log files" functionality without meddling around > fileHandler in log4j. > Also log4j2 has lot of new functionalities and performance benefits -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [incubator-gobblin] jhsenjaliya edited a comment on issue #2685: [GOBBLIN-822] Upgrade log4j to log4j2 for LogRouting use-case
jhsenjaliya edited a comment on issue #2685: [GOBBLIN-822] Upgrade log4j to log4j2 for LogRouting use-case URL: https://github.com/apache/incubator-gobblin/pull/2685#issuecomment-512962792 cant find any specific error in the build, so please review this and i will kick off another build later. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (GOBBLIN-822) upgrade log4j to log4j2
[ https://issues.apache.org/jira/browse/GOBBLIN-822?focusedWorklogId=279290&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279290 ] ASF GitHub Bot logged work on GOBBLIN-822: -- Author: ASF GitHub Bot Created on: 18/Jul/19 19:53 Start Date: 18/Jul/19 19:53 Worklog Time Spent: 10m Work Description: jhsenjaliya commented on issue #2685: [GOBBLIN-822] Upgrade log4j to log4j2 for LogRouting use-case URL: https://github.com/apache/incubator-gobblin/pull/2685#issuecomment-512962792 cant find any specific error in the build, so please review this and i will kick off another build later. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 279290) Time Spent: 20m (was: 10m) > upgrade log4j to log4j2 > --- > > Key: GOBBLIN-822 > URL: https://issues.apache.org/jira/browse/GOBBLIN-822 > Project: Apache Gobblin > Issue Type: Sub-task >Affects Versions: 0.14.0 >Reporter: Jay Sen >Priority: Major > Fix For: 0.15.0 > > Time Spent: 20m > Remaining Estimate: 0h > > log4j2 has routing appender that would be super useful and probably only way > to achieve " job specific log files" functionality without meddling around > fileHandler in log4j. > Also log4j2 has lot of new functionalities and performance benefits -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [incubator-gobblin] asfgit closed pull request #2689: [GOBBLIN-828] Make dynamic config override job config
asfgit closed pull request #2689: [GOBBLIN-828] Make dynamic config override job config URL: https://github.com/apache/incubator-gobblin/pull/2689 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (GOBBLIN-828) Make dynamic config override job config
[ https://issues.apache.org/jira/browse/GOBBLIN-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hung Tran resolved GOBBLIN-828. --- Resolution: Fixed Fix Version/s: 0.15.0 Issue resolved by pull request #2689 [https://github.com/apache/incubator-gobblin/pull/2689] > Make dynamic config override job config > --- > > Key: GOBBLIN-828 > URL: https://issues.apache.org/jira/browse/GOBBLIN-828 > Project: Apache Gobblin > Issue Type: Bug >Reporter: Jack Moseley >Priority: Major > Fix For: 0.15.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (GOBBLIN-828) Make dynamic config override job config
[ https://issues.apache.org/jira/browse/GOBBLIN-828?focusedWorklogId=279366&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279366 ] ASF GitHub Bot logged work on GOBBLIN-828: -- Author: ASF GitHub Bot Created on: 18/Jul/19 21:55 Start Date: 18/Jul/19 21:55 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2689: [GOBBLIN-828] Make dynamic config override job config URL: https://github.com/apache/incubator-gobblin/pull/2689 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 279366) Time Spent: 0.5h (was: 20m) > Make dynamic config override job config > --- > > Key: GOBBLIN-828 > URL: https://issues.apache.org/jira/browse/GOBBLIN-828 > Project: Apache Gobblin > Issue Type: Bug >Reporter: Jack Moseley >Priority: Major > Fix For: 0.15.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
