[GitHub] [incubator-gobblin] Will-Lo commented on a change in pull request #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs

[GitBox]

Will-Lo commented on a change in pull request #2788: [GOBBLIN-939] Integrate 
usage of env variables in gobblin scripts and configs
URL: https://github.com/apache/incubator-gobblin/pull/2788#discussion_r341287822
 
 

 ##
 File path: bin/gobblin-env.sh
 ##
 @@ -17,4 +17,6 @@
 # limitations under the License.
 #
 
-# Set Gobblin specific environment variables here.
+# export environment variables here to be used in gobblin.sh scripts and 
gobblin platform configs.
+export GOBBLIN_WORK_DIR=$GOBBLIN_HOME/gobblin-work-dir
+export GOBBLIN_JOB_CONFIG_DIR=$GOBBLIN_HOME/gobblin-job-config-dir
 
 Review comment:
   I think to keep it more consistent with our old naming conventions we should 
do
`GOBBLIN_WORK_DIR=$GOBBLIN_HOME/work`
   `GOBBLIN_JOB_CONFIG_DIR=$GOBBLIN_HOME/jobs`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] Will-Lo commented on a change in pull request #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs

[GitBox]

Will-Lo commented on a change in pull request #2788: [GOBBLIN-939] Integrate 
usage of env variables in gobblin scripts and configs
URL: https://github.com/apache/incubator-gobblin/pull/2788#discussion_r341290769
 
 

 ##
 File path: bin/gobblin.sh
 ##
 @@ -283,18 +291,18 @@ elif [[ -f ${GOBBLIN_CONF}/log4j.properties ]]; then
 LOG4J_OPTS="-Dlog4j.configuration=$LOG4J_FILE_PATH"
 fi
 
+#Create required directories
 if [[ ! -d "$GOBBLIN_LOGS" ]]; then
 mkdir -p $GOBBLIN_LOGS
 fi
 
-GC_OPTS=''
-if [[ ${ENABLE_GC_LOGS} -eq 1 ]]; then
-GC_OPTS+="-XX:+UseConcMarkSweepGC -XX:+UseParNewGC -XX:+UseCompressedOops "
-GC_OPTS+="-XX:+PrintGCDetails -XX:+PrintGCDateStamps 
-XX:+PrintTenuringDistribution "
-GC_OPTS+="-XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=$GOBBLIN_LOGS/ "
-GC_OPTS+="-Xloggc:$GOBBLIN_LOGS/gobblin-$GOBBLIN_MODE-gc.log "
+if [[ ! -d "$GOBBLIN_WORK_DIR" ]]; then
+mkdir -p $GOBBLIN_WORK_DIR
 fi
 
+if [[ ! -d "$GOBBLIN_JOB_CONFIG_DIR" ]]; then
+mkdir -p $GOBBLIN_JOB_CONFIG_DIR
+fi
 
 
 Review comment:
   If these are initiated using `gobblin-env.sh`, and called in `gobblin.sh` 
and never overwritten before the directories are created, would it be possible 
to modify the env variables?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services