[jira] [Work logged] (GOBBLIN-1002) Set state id when deserializing state from Gobblin state store
[ https://issues.apache.org/jira/browse/GOBBLIN-1002?focusedWorklogId=357529&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-357529 ] ASF GitHub Bot logged work on GOBBLIN-1002: --- Author: ASF GitHub Bot Created on: 10/Dec/19 23:56 Start Date: 10/Dec/19 23:56 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2847: GOBBLIN-1002: Set state id when deserializing state from Gobblin stat… URL: https://github.com/apache/incubator-gobblin/pull/2847 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 357529) Time Spent: 50m (was: 40m) > Set state id when deserializing state from Gobblin state store > -- > > Key: GOBBLIN-1002 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1002 > Project: Apache Gobblin > Issue Type: Improvement > Components: gobblin-core >Affects Versions: 0.15.0 >Reporter: Sudarshan Vasudevan >Assignee: Abhishek Tiwari >Priority: Major > Fix For: 0.15.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Current behavior returns the deserialized state without setting the state id > member field. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1002) Set state id when deserializing state from Gobblin state store
[ https://issues.apache.org/jira/browse/GOBBLIN-1002?focusedWorklogId=357510&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-357510 ] ASF GitHub Bot logged work on GOBBLIN-1002: --- Author: ASF GitHub Bot Created on: 10/Dec/19 23:25 Start Date: 10/Dec/19 23:25 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2847: GOBBLIN-1002: Set state id when deserializing state from Gobblin stat… URL: https://github.com/apache/incubator-gobblin/pull/2847#issuecomment-564304442 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2847?src=pr&el=h1) Report > Merging [#2847](https://codecov.io/gh/apache/incubator-gobblin/pull/2847?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/0469447f0732bf61a39d38af45e8c84715f87853?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `28.57%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2847?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#2847 +/- ## + Coverage 45.62% 45.62% +<.01% Complexity 8988 8988 Files 1904 1904 Lines 7134971355 +6 Branches 7876 7876 + Hits 3255132554 +3 - Misses3579535799 +4 + Partials 3003 3002 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2847?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../org/apache/gobblin/metastore/MysqlStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsU3RhdGVTdG9yZS5qYXZh) | `8.19% <0%> (-0.07%)` | `2 <0> (ø)` | | | [.../gobblin/runtime/CheckpointableWatermarkState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQ2hlY2twb2ludGFibGVXYXRlcm1hcmtTdGF0ZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ava/org/apache/gobblin/metastore/ZkStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taGVsaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL1prU3RhdGVTdG9yZS5qYXZh) | `63.06% <100%> (+0.33%)` | `23 <0> (ø)` | :arrow_down: | | [...ava/org/apache/gobblin/metastore/FsStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0ZzU3RhdGVTdG9yZS5qYXZh) | `36.05% <50%> (+0.19%)` | `14 <0> (ø)` | :arrow_down: | | [...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=) | `63.33% <0%> (-1.12%)` | `15% <0%> (-1%)` | | | [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `65.27% <0%> (+0.46%)` | `28% <0%> (ø)` | :arrow_down: | | [.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh) | `79.68% <0%> (+1.56%)` | `16% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2847?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2847?src=pr&el=footer). Last update [0469447...595c7a8](https://codecov.io/gh/apache/incubator-gobblin/pull/2847?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Servi
[jira] [Work logged] (GOBBLIN-1002) Set state id when deserializing state from Gobblin state store
[ https://issues.apache.org/jira/browse/GOBBLIN-1002?focusedWorklogId=357506&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-357506 ] ASF GitHub Bot logged work on GOBBLIN-1002: --- Author: ASF GitHub Bot Created on: 10/Dec/19 23:19 Start Date: 10/Dec/19 23:19 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2847: GOBBLIN-1002: Set state id when deserializing state from Gobblin stat… URL: https://github.com/apache/incubator-gobblin/pull/2847#issuecomment-564304442 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2847?src=pr&el=h1) Report > Merging [#2847](https://codecov.io/gh/apache/incubator-gobblin/pull/2847?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/0469447f0732bf61a39d38af45e8c84715f87853?src=pr&el=desc) will **decrease** coverage by `41.47%`. > The diff coverage is `14.28%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2847?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #2847 +/- ## - Coverage 45.62% 4.14% -41.48% + Complexity 8988 747 -8241 Files 19041904 Lines 71349 71355+6 Branches 78767876 - Hits 325512961-29590 - Misses35795 68075+32280 + Partials 3003 319 -2684 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2847?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../org/apache/gobblin/metastore/MysqlStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsU3RhdGVTdG9yZS5qYXZh) | `0% <0%> (-8.27%)` | `0 <0> (-2)` | | | [.../gobblin/runtime/CheckpointableWatermarkState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQ2hlY2twb2ludGFibGVXYXRlcm1hcmtTdGF0ZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ava/org/apache/gobblin/metastore/FsStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0ZzU3RhdGVTdG9yZS5qYXZh) | `0% <0%> (-35.87%)` | `0 <0> (-14)` | | | [...ava/org/apache/gobblin/metastore/ZkStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taGVsaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL1prU3RhdGVTdG9yZS5qYXZh) | `63.06% <100%> (+0.33%)` | `23 <0> (ø)` | :arrow_down: | | [...n/converter/AvroStringFieldDecryptorConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY3J5cHRvLXByb3ZpZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9BdnJvU3RyaW5nRmllbGREZWNyeXB0b3JDb252ZXJ0ZXIuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (-2%)` | | | [...he/gobblin/cluster/TaskRunnerSuiteThreadModel.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvVGFza1J1bm5lclN1aXRlVGhyZWFkTW9kZWwuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (-5%)` | | | [...n/mapreduce/avro/AvroKeyCompactorOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL2F2cm8vQXZyb0tleUNvbXBhY3Rvck91dHB1dEZvcm1hdC5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (-3%)` | | | [...apache/gobblin/fork/CopyNotSupportedException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZm9yay9Db3B5Tm90U3VwcG9ydGVkRXhjZXB0aW9uLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (-1%)` | | | [.../gobblin/kafka/writer/KafkaWriterCommonConfig.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2847/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL3dyaXRlci9LYWZrYVdyaXRlckNvbW1vbkNvbmZpZy5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (-7%)` | | | [...ker/task/TaskLevelPolicyCheckerBuilderFactory.java](https://codecov.io/gh/
[jira] [Work logged] (GOBBLIN-1002) Set state id when deserializing state from Gobblin state store
[ https://issues.apache.org/jira/browse/GOBBLIN-1002?focusedWorklogId=357479&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-357479 ] ASF GitHub Bot logged work on GOBBLIN-1002: --- Author: ASF GitHub Bot Created on: 10/Dec/19 22:32 Start Date: 10/Dec/19 22:32 Worklog Time Spent: 10m Work Description: sv2000 commented on issue #2847: GOBBLIN-1002: Set state id when deserializing state from Gobblin stat… URL: https://github.com/apache/incubator-gobblin/pull/2847#issuecomment-564290025 @htran1 please review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 357479) Time Spent: 20m (was: 10m) > Set state id when deserializing state from Gobblin state store > -- > > Key: GOBBLIN-1002 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1002 > Project: Apache Gobblin > Issue Type: Improvement > Components: gobblin-core >Affects Versions: 0.15.0 >Reporter: Sudarshan Vasudevan >Assignee: Abhishek Tiwari >Priority: Major > Fix For: 0.15.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Current behavior returns the deserialized state without setting the state id > member field. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1002) Set state id when deserializing state from Gobblin state store
[
https://issues.apache.org/jira/browse/GOBBLIN-1002?focusedWorklogId=357473&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-357473
]
ASF GitHub Bot logged work on GOBBLIN-1002:
---
Author: ASF GitHub Bot
Created on: 10/Dec/19 22:27
Start Date: 10/Dec/19 22:27
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2847: GOBBLIN-1002:
Set state id when deserializing state from Gobblin stat…
URL: https://github.com/apache/incubator-gobblin/pull/2847
…e store
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1002
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
Current behavior returns the deserialized state without setting the state id
member field.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Enhanced unit tests for all state store implementations to validate the
returned state id.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 357473)
Remaining Estimate: 0h
Time Spent: 10m
> Set state id when deserializing state from Gobblin state store
> --
>
> Key: GOBBLIN-1002
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1002
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
>Affects Versions: 0.15.0
>Reporter: Sudarshan Vasudevan
>Assignee: Abhishek Tiwari
>Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Current behavior returns the deserialized state without setting the state id
> member field.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
