[jira] [Work logged] (GOBBLIN-895) Gobblin Standalone Script does not run properly
[ https://issues.apache.org/jira/browse/GOBBLIN-895?focusedWorklogId=348428=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348428 ] ASF GitHub Bot logged work on GOBBLIN-895: -- Author: ASF GitHub Bot Created on: 23/Nov/19 00:21 Start Date: 23/Nov/19 00:21 Worklog Time Spent: 10m Work Description: jhsenjaliya commented on pull request #2751: [GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide is accurate URL: https://github.com/apache/incubator-gobblin/pull/2751#discussion_r349842446 ## File path: bin/gobblin.sh ## @@ -238,6 +238,11 @@ if [[ "$GOBBLIN_MODE_TYPE" == "$CLI" ]]; then fi fi +CHECK_ENV_VARS=false +if [ $ACTION == "start" ] || [ $ACTION == "restart" ]; then Review comment: @Will-Lo , this line has syntax error as per bash 4.0, can u pls take a look. since `CHECK_ENV_VARS` check happens only in start function anyway, do you want to remove this conditional set and set it by default to TRUE always. Also if you set the variable at line 34, it can be overridable by `gobblin-env.sh`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 348428) Time Spent: 2h 10m (was: 2h) > Gobblin Standalone Script does not run properly > --- > > Key: GOBBLIN-895 > URL: https://issues.apache.org/jira/browse/GOBBLIN-895 > Project: Apache Gobblin > Issue Type: Bug >Affects Versions: 0.15.0 >Reporter: William Lo >Priority: Major > Fix For: 0.15.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Gobblin.sh's changes do not support Gobblin standalone properly as specified > in the getting started docs. This is due to a regression in the > configurations of the app and the logger. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-895) Gobblin Standalone Script does not run properly
[ https://issues.apache.org/jira/browse/GOBBLIN-895?focusedWorklogId=348426=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348426 ] ASF GitHub Bot logged work on GOBBLIN-895: -- Author: ASF GitHub Bot Created on: 23/Nov/19 00:17 Start Date: 23/Nov/19 00:17 Worklog Time Spent: 10m Work Description: jhsenjaliya commented on pull request #2751: [GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide is accurate URL: https://github.com/apache/incubator-gobblin/pull/2751#discussion_r349841904 ## File path: bin/gobblin.sh ## @@ -238,6 +238,11 @@ if [[ "$GOBBLIN_MODE_TYPE" == "$CLI" ]]; then fi fi +CHECK_ENV_VARS=false +if [ $ACTION == "start" ] || [ $ACTION == "restart" ]; then Review comment: btw, there is a syntax error here as per bash 4, did you encounter this ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 348426) Time Spent: 2h (was: 1h 50m) > Gobblin Standalone Script does not run properly > --- > > Key: GOBBLIN-895 > URL: https://issues.apache.org/jira/browse/GOBBLIN-895 > Project: Apache Gobblin > Issue Type: Bug >Affects Versions: 0.15.0 >Reporter: William Lo >Priority: Major > Fix For: 0.15.0 > > Time Spent: 2h > Remaining Estimate: 0h > > Gobblin.sh's changes do not support Gobblin standalone properly as specified > in the getting started docs. This is due to a regression in the > configurations of the app and the logger. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-895) Gobblin Standalone Script does not run properly
[ https://issues.apache.org/jira/browse/GOBBLIN-895?focusedWorklogId=337032=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337032 ] ASF GitHub Bot logged work on GOBBLIN-895: -- Author: ASF GitHub Bot Created on: 31/Oct/19 20:37 Start Date: 31/Oct/19 20:37 Worklog Time Spent: 10m Work Description: jhsenjaliya commented on issue #2751: [GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide is accurate URL: https://github.com/apache/incubator-gobblin/pull/2751#issuecomment-548558371 Sure, let me updates the docs accordingly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 337032) Time Spent: 1h 50m (was: 1h 40m) > Gobblin Standalone Script does not run properly > --- > > Key: GOBBLIN-895 > URL: https://issues.apache.org/jira/browse/GOBBLIN-895 > Project: Apache Gobblin > Issue Type: Bug >Affects Versions: 0.15.0 >Reporter: William Lo >Priority: Major > Fix For: 0.15.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Gobblin.sh's changes do not support Gobblin standalone properly as specified > in the getting started docs. This is due to a regression in the > configurations of the app and the logger. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-895) Gobblin Standalone Script does not run properly
[ https://issues.apache.org/jira/browse/GOBBLIN-895?focusedWorklogId=336947=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-336947 ] ASF GitHub Bot logged work on GOBBLIN-895: -- Author: ASF GitHub Bot Created on: 31/Oct/19 17:41 Start Date: 31/Oct/19 17:41 Worklog Time Spent: 10m Work Description: jhsenjaliya commented on issue #2751: [GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide is accurate URL: https://github.com/apache/incubator-gobblin/pull/2751#issuecomment-548489825 not it looks much better with #2788, pls check it out. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 336947) Time Spent: 1.5h (was: 1h 20m) > Gobblin Standalone Script does not run properly > --- > > Key: GOBBLIN-895 > URL: https://issues.apache.org/jira/browse/GOBBLIN-895 > Project: Apache Gobblin > Issue Type: Bug >Affects Versions: 0.15.0 >Reporter: William Lo >Priority: Major > Fix For: 0.15.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > Gobblin.sh's changes do not support Gobblin standalone properly as specified > in the getting started docs. This is due to a regression in the > configurations of the app and the logger. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-895) Gobblin Standalone Script does not run properly
[ https://issues.apache.org/jira/browse/GOBBLIN-895?focusedWorklogId=336949=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-336949 ] ASF GitHub Bot logged work on GOBBLIN-895: -- Author: ASF GitHub Bot Created on: 31/Oct/19 17:45 Start Date: 31/Oct/19 17:45 Worklog Time Spent: 10m Work Description: Will-Lo commented on issue #2751: [GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide is accurate URL: https://github.com/apache/incubator-gobblin/pull/2751#issuecomment-548491660 @jhsenjaliya sure we can go with that, I think the main thing is that the documentation should be updated to reflect the change in workflows that we introduce. I think following an approach with #2788 is good, we just need to test it to ensure we don't introduce regressions This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 336949) Time Spent: 1h 40m (was: 1.5h) > Gobblin Standalone Script does not run properly > --- > > Key: GOBBLIN-895 > URL: https://issues.apache.org/jira/browse/GOBBLIN-895 > Project: Apache Gobblin > Issue Type: Bug >Affects Versions: 0.15.0 >Reporter: William Lo >Priority: Major > Fix For: 0.15.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Gobblin.sh's changes do not support Gobblin standalone properly as specified > in the getting started docs. This is due to a regression in the > configurations of the app and the logger. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-895) Gobblin Standalone Script does not run properly
[ https://issues.apache.org/jira/browse/GOBBLIN-895?focusedWorklogId=336925=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-336925 ] ASF GitHub Bot logged work on GOBBLIN-895: -- Author: ASF GitHub Bot Created on: 31/Oct/19 16:53 Start Date: 31/Oct/19 16:53 Worklog Time Spent: 10m Work Description: jhsenjaliya commented on issue #2751: [GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide is accurate URL: https://github.com/apache/incubator-gobblin/pull/2751#issuecomment-548469068 @Will-Lo , I am trying to see how can we make this consistent, I think with addition of GOBBLIN_WORK_DIR and GOBBLIN_JOB_CONFIG_DIR envrionment varialble support with ability to override from command line would perfectly work. what do you think? I will make the changes accordingly. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 336925) Time Spent: 1h 20m (was: 1h 10m) > Gobblin Standalone Script does not run properly > --- > > Key: GOBBLIN-895 > URL: https://issues.apache.org/jira/browse/GOBBLIN-895 > Project: Apache Gobblin > Issue Type: Bug >Affects Versions: 0.15.0 >Reporter: William Lo >Priority: Major > Fix For: 0.15.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Gobblin.sh's changes do not support Gobblin standalone properly as specified > in the getting started docs. This is due to a regression in the > configurations of the app and the logger. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-895) Gobblin Standalone Script does not run properly
[ https://issues.apache.org/jira/browse/GOBBLIN-895?focusedWorklogId=332131=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-332131 ] ASF GitHub Bot logged work on GOBBLIN-895: -- Author: ASF GitHub Bot Created on: 22/Oct/19 18:17 Start Date: 22/Oct/19 18:17 Worklog Time Spent: 10m Work Description: jhsenjaliya commented on pull request #2751: [GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide is accurate URL: https://github.com/apache/incubator-gobblin/pull/2751#discussion_r337675202 ## File path: bin/gobblin.sh ## @@ -238,6 +238,11 @@ if [[ "$GOBBLIN_MODE_TYPE" == "$CLI" ]]; then fi fi +CHECK_ENV_VARS=false +if [ $ACTION == "start" ] || [ $ACTION == "restart" ]; then Review comment: actually, only start and restart goes through the function that does this check. Also the setting of ENV variables should be optional. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 332131) Time Spent: 1h (was: 50m) > Gobblin Standalone Script does not run properly > --- > > Key: GOBBLIN-895 > URL: https://issues.apache.org/jira/browse/GOBBLIN-895 > Project: Apache Gobblin > Issue Type: Bug >Affects Versions: 0.15.0 >Reporter: William Lo >Priority: Major > Fix For: 0.15.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Gobblin.sh's changes do not support Gobblin standalone properly as specified > in the getting started docs. This is due to a regression in the > configurations of the app and the logger. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-895) Gobblin Standalone Script does not run properly
[
https://issues.apache.org/jira/browse/GOBBLIN-895?focusedWorklogId=332133=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-332133
]
ASF GitHub Bot logged work on GOBBLIN-895:
--
Author: ASF GitHub Bot
Created on: 22/Oct/19 18:20
Start Date: 22/Oct/19 18:20
Worklog Time Spent: 10m
Work Description: jhsenjaliya commented on pull request #2751:
[GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide
is accurate
URL: https://github.com/apache/incubator-gobblin/pull/2751#discussion_r337676404
##
File path: bin/gobblin.sh
##
@@ -417,7 +427,15 @@ function start() {
CLASS_N_ARGS=''
if [[ "$GOBBLIN_MODE" = "$STANDALONE_MODE" ]]; then
CLASS_N_ARGS="$STANDALONE_CLASS $GOBBLIN_CONF/application.conf"
+ADDITIONAL_ARGS="-Dgobblin.logs.dir=${GOBBLIN_LOGS}"
+
+if [ -z "$GOBBLIN_WORK_DIR" ] && [ "$CHECK_ENV_VARS" == true
]; then
Review comment:
I originally removed the ENV variables deliberately to make one way of
controlling everything. but i can see ENV variable can be additional way of
configuring too. but should not be the only way. may be we can merge it or make
it overridable by user config for GOBBLIN_JOB_CONFIG_DIR and GOBBLIN_WORK_DIR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 332133)
Time Spent: 1h 10m (was: 1h)
> Gobblin Standalone Script does not run properly
> ---
>
> Key: GOBBLIN-895
> URL: https://issues.apache.org/jira/browse/GOBBLIN-895
> Project: Apache Gobblin
> Issue Type: Bug
>Affects Versions: 0.15.0
>Reporter: William Lo
>Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Gobblin.sh's changes do not support Gobblin standalone properly as specified
> in the getting started docs. This is due to a regression in the
> configurations of the app and the logger.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-895) Gobblin Standalone Script does not run properly
[ https://issues.apache.org/jira/browse/GOBBLIN-895?focusedWorklogId=326695=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-326695 ] ASF GitHub Bot logged work on GOBBLIN-895: -- Author: ASF GitHub Bot Created on: 11/Oct/19 03:55 Start Date: 11/Oct/19 03:55 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2751: [GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide is accurate URL: https://github.com/apache/incubator-gobblin/pull/2751 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 326695) Time Spent: 50m (was: 40m) > Gobblin Standalone Script does not run properly > --- > > Key: GOBBLIN-895 > URL: https://issues.apache.org/jira/browse/GOBBLIN-895 > Project: Apache Gobblin > Issue Type: Bug >Affects Versions: 0.15.0 >Reporter: William Lo >Priority: Major > Fix For: 0.15.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Gobblin.sh's changes do not support Gobblin standalone properly as specified > in the getting started docs. This is due to a regression in the > configurations of the app and the logger. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-895) Gobblin Standalone Script does not run properly
[ https://issues.apache.org/jira/browse/GOBBLIN-895?focusedWorklogId=323093=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323093 ] ASF GitHub Bot logged work on GOBBLIN-895: -- Author: ASF GitHub Bot Created on: 04/Oct/19 00:43 Start Date: 04/Oct/19 00:43 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2751: [GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide is accurate URL: https://github.com/apache/incubator-gobblin/pull/2751#issuecomment-538179188 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2751?src=pr=h1) Report > Merging [#2751](https://codecov.io/gh/apache/incubator-gobblin/pull/2751?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/5b8af8cf6e932e8031ef060c79260a4a8f47974c?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2751?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#2751 +/- ## + Coverage 45.27% 45.28% +<.01% - Complexity 8828 8832 +4 Files 1889 1889 Lines 7063470634 Branches 7757 7757 + Hits 3197931984 +5 + Misses3570135700 -1 + Partials 2954 2950 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2751?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2751/diff?src=pr=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `62.85% <0%> (+1.42%)` | `4% <0%> (ø)` | :arrow_down: | | [...ava/org/apache/gobblin/fsm/FiniteStateMachine.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2751/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZzbS9GaW5pdGVTdGF0ZU1hY2hpbmUuamF2YQ==) | `76.51% <0%> (+3.03%)` | `21% <0%> (+3%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2751?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2751?src=pr=footer). Last update [5b8af8c...7fe66c2](https://codecov.io/gh/apache/incubator-gobblin/pull/2751?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 323093) Time Spent: 40m (was: 0.5h) > Gobblin Standalone Script does not run properly > --- > > Key: GOBBLIN-895 > URL: https://issues.apache.org/jira/browse/GOBBLIN-895 > Project: Apache Gobblin > Issue Type: Bug >Affects Versions: 0.15.0 >Reporter: William Lo >Priority: Major > Fix For: 0.15.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Gobblin.sh's changes do not support Gobblin standalone properly as specified > in the getting started docs. This is due to a regression in the > configurations of the app and the logger. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-895) Gobblin Standalone Script does not run properly
[ https://issues.apache.org/jira/browse/GOBBLIN-895?focusedWorklogId=323092=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323092 ] ASF GitHub Bot logged work on GOBBLIN-895: -- Author: ASF GitHub Bot Created on: 04/Oct/19 00:42 Start Date: 04/Oct/19 00:42 Worklog Time Spent: 10m Work Description: Will-Lo commented on issue #2751: [GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide is accurate URL: https://github.com/apache/incubator-gobblin/pull/2751#issuecomment-538182727 @sv2000 Could you take a look? Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 323092) Time Spent: 0.5h (was: 20m) > Gobblin Standalone Script does not run properly > --- > > Key: GOBBLIN-895 > URL: https://issues.apache.org/jira/browse/GOBBLIN-895 > Project: Apache Gobblin > Issue Type: Bug >Affects Versions: 0.15.0 >Reporter: William Lo >Priority: Major > Fix For: 0.15.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Gobblin.sh's changes do not support Gobblin standalone properly as specified > in the getting started docs. This is due to a regression in the > configurations of the app and the logger. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-895) Gobblin Standalone Script does not run properly
[ https://issues.apache.org/jira/browse/GOBBLIN-895?focusedWorklogId=323087=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323087 ] ASF GitHub Bot logged work on GOBBLIN-895: -- Author: ASF GitHub Bot Created on: 04/Oct/19 00:24 Start Date: 04/Oct/19 00:24 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2751: [GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide is accurate URL: https://github.com/apache/incubator-gobblin/pull/2751#issuecomment-538179188 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2751?src=pr=h1) Report > Merging [#2751](https://codecov.io/gh/apache/incubator-gobblin/pull/2751?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/5b8af8cf6e932e8031ef060c79260a4a8f47974c?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2751?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#2751 +/- ## + Coverage 45.27% 45.28% +<.01% - Complexity 8828 8831 +3 Files 1889 1889 Lines 7063470634 Branches 7757 7757 + Hits 3197931985 +6 + Misses3570135698 -3 + Partials 2954 2951 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2751?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2751/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `64.81% <0%> (+0.92%)` | `28% <0%> (ø)` | :arrow_down: | | [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2751/diff?src=pr=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `62.85% <0%> (+1.42%)` | `4% <0%> (ø)` | :arrow_down: | | [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2751/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `100% <0%> (+14.28%)` | `4% <0%> (+1%)` | :arrow_up: | | [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2751/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `60% <0%> (+20%)` | `3% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2751?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2751?src=pr=footer). Last update [5b8af8c...7fe66c2](https://codecov.io/gh/apache/incubator-gobblin/pull/2751?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 323087) Time Spent: 20m (was: 10m) > Gobblin Standalone Script does not run properly > --- > > Key: GOBBLIN-895 > URL: https://issues.apache.org/jira/browse/GOBBLIN-895 > Project: Apache Gobblin > Issue Type: Bug >Affects Versions: 0.15.0 >Reporter: William Lo >Priority: Major > Fix For: 0.15.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Gobblin.sh's changes do not support Gobblin standalone properly as specified > in the getting started docs. This is due to a regression in the > configurations of the app and the logger.
[jira] [Work logged] (GOBBLIN-895) Gobblin Standalone Script does not run properly
[
https://issues.apache.org/jira/browse/GOBBLIN-895?focusedWorklogId=323076=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323076
]
ASF GitHub Bot logged work on GOBBLIN-895:
--
Author: ASF GitHub Bot
Created on: 03/Oct/19 23:47
Start Date: 03/Oct/19 23:47
Worklog Time Spent: 10m
Work Description: Will-Lo commented on pull request #2751: [GOBBLIN-895]
Fixes Gobblin Standalone configs and scripts so that user guide is accurate
URL: https://github.com/apache/incubator-gobblin/pull/2751
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
[#2578] Introduced inconsistencies with our user guide and the startup
scripts for gobblin standalone. I modified the configs and logging output so
that the user guide is now accurate again and updated the docs. Also fixed some
spelling typos.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 323076)
Remaining Estimate: 0h
Time Spent: 10m
> Gobblin Standalone Script does not run properly
> ---
>
> Key: GOBBLIN-895
> URL: https://issues.apache.org/jira/browse/GOBBLIN-895
> Project: Apache Gobblin
> Issue Type: Bug
>Affects Versions: 0.15.0
>Reporter: William Lo
>Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Gobblin.sh's changes do not support Gobblin standalone properly as specified
> in the getting started docs. This is due to a regression in the
> configurations of the app and the logger.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
