[jira] [Work logged] (GOBBLIN-940) Synchronization between workunit persistency and Helix job launching

2019-11-05 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-940?focusedWorklogId=339078=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339078
 ]

ASF GitHub Bot logged work on GOBBLIN-940:
--

Author: ASF GitHub Bot
Created on: 06/Nov/19 00:08
Start Date: 06/Nov/19 00:08
Worklog Time Spent: 10m 
  Work Description: asfgit commented on pull request #2789: 
[GOBBLIN-940]Add synchronization on workunit persistency before Helix job 
launching
URL: https://github.com/apache/incubator-gobblin/pull/2789
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 339078)
Time Spent: 1h  (was: 50m)

> Synchronization between workunit persistency and Helix job launching
> 
>
> Key: GOBBLIN-940
> URL: https://issues.apache.org/jira/browse/GOBBLIN-940
> Project: Apache Gobblin
>  Issue Type: Improvement
>Reporter: Lei Sun
>Priority: Major
>  Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (GOBBLIN-940) Synchronization between workunit persistency and Helix job launching

2019-11-05 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-940?focusedWorklogId=338905=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-338905
 ]

ASF GitHub Bot logged work on GOBBLIN-940:
--

Author: ASF GitHub Bot
Created on: 05/Nov/19 18:07
Start Date: 05/Nov/19 18:07
Worklog Time Spent: 10m 
  Work Description: codecov-io commented on issue #2789: [GOBBLIN-940]Add 
synchronization on workunit persistency before Helix job launching
URL: 
https://github.com/apache/incubator-gobblin/pull/2789#issuecomment-548527186
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2789?src=pr=h1)
 Report
   > Merging 
[#2789](https://codecov.io/gh/apache/incubator-gobblin/pull/2789?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/9ee4dcaf66257b6e2926cf1470b16b912cd343ff?src=pr=desc)
 will **increase** coverage by `40.22%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/graphs/tree.svg?width=650=4MgURJ0bGc=150=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2789?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#2789   +/-   ##
   =
   + Coverage  4.15%   44.38%   +40.22% 
   - Complexity  746 8694 +7948 
   =
 Files  1894 1894   
 Lines 7087770918   +41 
 Branches   7793 7800+7 
   =
   + Hits   294631475+28529 
   + Misses6761736519-31098 
   - Partials314 2924 +2610
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2789?src=pr=tree) 
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...n/java/org/apache/gobblin/util/ParallelRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvUGFyYWxsZWxSdW5uZXIuamF2YQ==)
 | `63.96% <100%> (+63.96%)` | `15 <1> (+15)` | :arrow_up: |
   | 
[...pache/gobblin/cluster/GobblinHelixJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXIuamF2YQ==)
 | `82% <100%> (+82%)` | `27 <0> (+27)` | :arrow_up: |
   | 
[...re/filesystem/FsDatasetStateStoreEntryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWV0YXN0b3JlL2ZpbGVzeXN0ZW0vRnNEYXRhc2V0U3RhdGVTdG9yZUVudHJ5TWFuYWdlci5qYXZh)
 | `0% <0%> (-100%)` | `0% <0%> (-3%)` | |
   | 
[...askStateCollectorServiceHiveRegHandlerFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlQ29sbGVjdG9yU2VydmljZUhpdmVSZWdIYW5kbGVyRmFjdG9yeS5qYXZh)
 | `0% <0%> (-100%)` | `0% <0%> (-2%)` | |
   | 
[...gobblin/runtime/mapreduce/GobblinOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0dvYmJsaW5PdXRwdXRGb3JtYXQuamF2YQ==)
 | `0% <0%> (-100%)` | `0% <0%> (-2%)` | |
   | 
[...in/runtime/mapreduce/CustomizedProgresserBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0N1c3RvbWl6ZWRQcm9ncmVzc2VyQmFzZS5qYXZh)
 | `0% <0%> (-83.34%)` | `0% <0%> (-1%)` | |
   | 
[...rg/apache/gobblin/runtime/ZkDatasetStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/diff?src=pr=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taGVsaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9aa0RhdGFzZXRTdGF0ZVN0b3JlLmphdmE=)
 | `0% <0%> (-80.77%)` | `0% <0%> (-7%)` | |
   | 
[...lin/runtime/locks/LegacyJobLockFactoryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvTGVnYWN5Sm9iTG9ja0ZhY3RvcnlNYW5hZ2VyLmphdmE=)
 | `0% <0%> (-78.58%)` | `0% <0%> (-2%)` | |
   | 
[...e/HiveRegTaskStateCollectorServiceHandlerImpl.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvSGl2ZVJlZ1Rhc2tTdGF0ZUNvbGxlY3RvclNlcnZpY2VIYW5kbGVySW1wbC5qYXZh)
 | `0% <0%> (-75%)` | `0% <0%> (-3%)` | |
   |

[jira] [Work logged] (GOBBLIN-940) Synchronization between workunit persistency and Helix job launching

2019-11-01 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-940?focusedWorklogId=337462=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337462
 ]

ASF GitHub Bot logged work on GOBBLIN-940:
--

Author: ASF GitHub Bot
Created on: 01/Nov/19 18:32
Start Date: 01/Nov/19 18:32
Worklog Time Spent: 10m 
  Work Description: htran1 commented on pull request #2789: 
[GOBBLIN-940]Add synchronization on workunit persistency before Helix job 
launching
URL: https://github.com/apache/incubator-gobblin/pull/2789#discussion_r341686549
 
 

 ##
 File path: 
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobLauncher.java
 ##
 @@ -295,23 +295,34 @@ protected void executeCancellation() {
 SerializationUtils.serializeState(this.fs, jobStateFilePath, 
this.jobContext.getJobState());
   }
 
-  LOGGER.debug("GobblinHelixJobLauncher.createJob: jobStateFilePath {}, 
jobState {} jobProperties {}",
+  // Block on all persistency of workunits finished
+  // It is necessary when underlying storage being and Helix activate 
task-execution before the workunit being persisted.
 
 Review comment:
   `storage being and`? Seems like something is missing here in this comment.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 337462)
Time Spent: 40m  (was: 0.5h)

> Synchronization between workunit persistency and Helix job launching
> 
>
> Key: GOBBLIN-940
> URL: https://issues.apache.org/jira/browse/GOBBLIN-940
> Project: Apache Gobblin
>  Issue Type: Improvement
>Reporter: Lei Sun
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (GOBBLIN-940) Synchronization between workunit persistency and Helix job launching

2019-10-31 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-940?focusedWorklogId=337004=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337004
 ]

ASF GitHub Bot logged work on GOBBLIN-940:
--

Author: ASF GitHub Bot
Created on: 31/Oct/19 19:13
Start Date: 31/Oct/19 19:13
Worklog Time Spent: 10m 
  Work Description: codecov-io commented on issue #2789: [GOBBLIN-940]Add 
synchronization on workunit persistency before Helix job launching
URL: 
https://github.com/apache/incubator-gobblin/pull/2789#issuecomment-548527186
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2789?src=pr=h1)
 Report
   > Merging 
[#2789](https://codecov.io/gh/apache/incubator-gobblin/pull/2789?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/9ee4dcaf66257b6e2926cf1470b16b912cd343ff?src=pr=desc)
 will **increase** coverage by `41.19%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/graphs/tree.svg?width=650=4MgURJ0bGc=150=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2789?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#2789   +/-   ##
   =
   + Coverage  4.15%   45.35%   +41.19% 
   - Complexity  746 8867 +8121 
   =
 Files  1894 1894   
 Lines 7087770879+2 
 Branches   7793 7793   
   =
   + Hits   294632145+29199 
   + Misses6761735772-31845 
   - Partials314 2962 +2648
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2789?src=pr=tree) 
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...pache/gobblin/cluster/GobblinHelixJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXIuamF2YQ==)
 | `82% <100%> (+82%)` | `27 <0> (+27)` | :arrow_up: |
   | 
[...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=)
 | `63.33% <0%> (-1.12%)` | `15% <0%> (-1%)` | |
   | 
[...gobblin/service/monitoring/JobStatusRetriever.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9Kb2JTdGF0dXNSZXRyaWV2ZXIuamF2YQ==)
 | `0% <0%> (ø)` | `2% <0%> (+2%)` | :arrow_up: |
   | 
[...ata/management/copy/hive/HivePartitionFileSet.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9IaXZlUGFydGl0aW9uRmlsZVNldC5qYXZh)
 | `0.95% <0%> (+0.95%)` | `1% <0%> (+1%)` | :arrow_up: |
   | 
[...ain/java/org/apache/gobblin/runtime/TaskState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlLmphdmE=)
 | `81.97% <0%> (+1.16%)` | `32% <0%> (ø)` | :arrow_down: |
   | 
[...pache/gobblin/runtime/GobblinMultiTaskAttempt.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvR29iYmxpbk11bHRpVGFza0F0dGVtcHQuamF2YQ==)
 | `56.3% <0%> (+1.35%)` | `27% <0%> (+2%)` | :arrow_up: |
   | 
[...ava/org/apache/gobblin/runtime/MultiConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvTXVsdGlDb252ZXJ0ZXIuamF2YQ==)
 | `83.6% <0%> (+1.63%)` | `9% <0%> (+1%)` | :arrow_up: |
   | 
[...rg/apache/gobblin/runtime/FsDatasetStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvRnNEYXRhc2V0U3RhdGVTdG9yZS5qYXZh)
 | `73.8% <0%> (+1.78%)` | `35% <0%> (+1%)` | :arrow_up: |
   | 
[...a/org/apache/gobblin/cluster/SingleTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2789/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlVGFza1J1bm5lci5qYXZh)
 | `1.85% <0%> (+1.85%)` | `1% <0%> (+1%)` | :arrow_up: |
   |

[jira] [Work logged] (GOBBLIN-940) Synchronization between workunit persistency and Helix job launching

2019-10-31 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-940?focusedWorklogId=336987=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-336987
 ]

ASF GitHub Bot logged work on GOBBLIN-940:
--

Author: ASF GitHub Bot
Created on: 31/Oct/19 18:27
Start Date: 31/Oct/19 18:27
Worklog Time Spent: 10m 
  Work Description: autumnust commented on issue #2789: [GOBBLIN-940]Add 
synchronization on workunit persistency before Helix job launching
URL: 
https://github.com/apache/incubator-gobblin/pull/2789#issuecomment-548508801
 
 
   @htran1  Can you take a look ? thanks
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 336987)
Time Spent: 20m  (was: 10m)

> Synchronization between workunit persistency and Helix job launching
> 
>
> Key: GOBBLIN-940
> URL: https://issues.apache.org/jira/browse/GOBBLIN-940
> Project: Apache Gobblin
>  Issue Type: Improvement
>Reporter: Lei Sun
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (GOBBLIN-940) Synchronization between workunit persistency and Helix job launching

2019-10-31 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-940?focusedWorklogId=336986=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-336986
 ]

ASF GitHub Bot logged work on GOBBLIN-940:
--

Author: ASF GitHub Bot
Created on: 31/Oct/19 18:26
Start Date: 31/Oct/19 18:26
Worklog Time Spent: 10m 
  Work Description: autumnust commented on pull request #2789: 
[GOBBLIN-940]Add synchronization on workunit persistency before Helix job 
launching
URL: https://github.com/apache/incubator-gobblin/pull/2789
 
 
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [x] https://issues.apache.org/jira/browse/GOBBLIN-940
   
   
   ### Description
   - [x] Did some minor refactoring and unit test fixing, the major part is 
just adding `waitForTasks ` before Helix job being returned and submitted. This 
is causing problem when HDFS being very slow / parallel runner hitting CPU 
bounded on working on workunit persistency that Helix task is activated before 
WU is showing up.
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
   1. Subject is separated from body by a blank line
   2. Subject is limited to 50 characters
   3. Subject does not end with a period
   4. Subject uses the imperative mood ("add", not "adding")
   5. Body wraps at 72 characters
   6. Body explains "what" and "why", not "how"
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 336986)
Remaining Estimate: 0h
Time Spent: 10m

> Synchronization between workunit persistency and Helix job launching
> 
>
> Key: GOBBLIN-940
> URL: https://issues.apache.org/jira/browse/GOBBLIN-940
> Project: Apache Gobblin
>  Issue Type: Improvement
>Reporter: Lei Sun
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)