Re: Add datastore for Elasticsearch. Outreachy Week 5 Report
Hi, Thank you for your feedback. Yes, I did not check that XSD validation was working. I will fix it and also add a test for it. I will add comments for the connection parameters. Yes, it seems you are right that Docker container has no authentication parameters, because I did not set them up. I will look into it too. Regards, Maria On Thu, 7 Jan 2021 at 05:15, John Mora wrote: > Hi, > > Thanks for your hard work. > > Some comments: > > The XSD validation is not working: > > org.apache.gora.util.GoraException: java.lang.RuntimeException: > org.xml.sax.SAXParseException; schema_reference.4: Failed to read schema > document 'file:/tmp/gora/gora-elasticsearch/gora-elasticsearch.xsd', > because 1) could not find the document; 2)... > > The XSD file should be located in the main source code instead of the > tests, you can also add a test for the XSD validation. > > > https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/test/resources/gora-elasticsearch.xsd > > Please add some comments with information about the connection parameters > > > https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/main/java/org/apache/gora/elasticsearch/utils/ElasticsearchParameters.java#L29 > > I think the security is not set up in the Docker container and the > parameters gora.datastore.elasticsearch.username and > gora.datastore.elasticsearch.password are simply ignored by the > Elasticsearch server. Is that right? > > > https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/test/java/org/apache/gora/elasticsearch/GoraElasticsearchTestDriver.java > > Cheers, > John > > El sáb, 2 ene 2021 a las 4:52, Maria Podorvanova (< > podorvanova.ma...@gmail.com>) escribió: > >> Hi, >> >> Report #5 >> Period: December 27 - January 2 >> Activities: >> - Added a property for choosing the authentication method [1] >> - Implemented testing with Elasticsearch container [2] >> >>1. Researched testing side >>2. Added test dependencies >>3. Added GoraElasticsearchTestDriver with Elasticsearch container >>4. Added javadoc descriptions to GoraElasticsearchTestDriver class >>5. Fixed two existing tests in accordance to Elasticsearch container >> >> - Implement some methods for schema management [3] >> >>1. schemaExists >>2. createSchema >>3. deleteSchema >>4. flush >> >> >> Here are links to the commits: >> [1] >> https://github.com/apache/gora/commit/457f57a2391856e6d6a5d67c2668c6f28348d40d >> >> [2] >> https://github.com/apache/gora/commit/3d0784721fc8bf158522a6b5dc6e309aae27a2de >> >> [3] >> https://github.com/apache/gora/commit/57da5033ac26a2b31046c83bdfe8729b1aeb6889 >> >> >> Regards, >> Maria >> >
Re: Outreachy 2020-2021 - Neo4j - Weekly reports.
Hi Thanks for your report. Some comments: You are creating a UNIQUE index instead of the NODE KEY you mentioned on your design document. why? https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L141 Also, can you write the CREATE CONSTRAINT query with Cypher-DSL? Please add javadoc documentation and comments on these classes: https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jConstants.java https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jParameters.java Please add a test for the XSD Validation https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/resources/gora-neo4j.xsd Cheers, John El dom, 3 ene 2021 a las 23:12, gabriela ortiz () escribió: > Hi > > I wanted to inform the tasks I worked on this week: Dec 26 - Dec 31 > > * Develop the Datastore methods: getSchemaName, createSchema, deleteSchema, > schemaExists > * Enable tests in Neo4jStoreTest : testCreateSchema , testSchemaExists > * Enhance the implementation of the connection to the backend. > * Write a blog about my project. > > You can find my code in my branch: > > https://github.com/mgov88/gora/tree/GORA-663 > > Best Regards, > Gaby > > El mié, 30 de dic. de 2020 a la(s) 13:28, John Mora (jhnmora...@gmail.com) > escribió: > >> Hi >> >> Thanks for your report. >> >> The Utils package is specific for each datastore; it is not mandatory. >> You can move some code there to improve the readability of the core classes >> of the datastore but it is up to you. >> >> I could not find your last changes in your branch in github, please make >> sure to push the commits, so I can review the code. >> >> Cheers, >> John >> >> >> El mar, 29 dic 2020 a las 1:03, gabriela ortiz () >> escribió: >> >>> Hi >>> >>> I wanted to inform the tasks I worked on this week: Dec 19 - Dec 25 >>> >>> * I developed a GoraTestDriver for Neo4j using GenericContainer from >>> the Test Containers library >>> * I developed the initialize method from Neo4jStore to establish >>> connection to the backend (Neo4j) >>> * I developed a XSD validation file for the XML mapping >>> >>> I have a question, I realized that some Datastores have 'utils' packages >>> in the code, are they obligatory? What kind of code should go in them? >>> >>> Best Regards, >>> Gaby >>> >>> >>> >>> El lun, 21 de dic. de 2020 a la(s) 15:45, gabriela ortiz ( >>> arqgabyor...@gmail.com) escribió: >>> Hi John El sáb, 19 de dic. de 2020 a la(s) 17:13, John Mora ( jhnmora...@gmail.com) escribió: > Hi Gaby > > Thanks for your report and your hard work! > > I left some comments on your design document please give them a look. > > Thanks you for your comments, > Some comments about your code: > > IMHO, the attributes unique, exists and index should be optional > (default: false) [0]. > I agree I will change that > The KeyClassCanonicalName and PersistentClassCanonicalName should be > read from the datastore not hard coded [1] > I put that hard coded because I had an error because the Datastore methods are not yet implemented, but I will change that. > I think this class [2] should be deleted, there are proper tests for > this in the DataStoreTestBase class. If you are using this for your own > experiments please do not push it to github. > > yes, I am using this class to temporary test my code, you are right I will remove it from github. Thanks you for your feedback. Regards, Gaby > [0] > https://github.com/mgov88/gora/blob/867d06e1fcf29e90b0431b9a42b82810c5409dda/gora-neo4j/src/test/resources/gora-neo4j-mapping.xml > [1] > https://github.com/mgov88/gora/blob/867d06e1fcf29e90b0431b9a42b82810c5409dda/gora-neo4j/src/main/java/org/apache/gora/neo4j/mapping/Neo4jMappingBuilder.java#L44 > [2] > https://github.com/mgov88/gora/blob/867d06e1fcf29e90b0431b9a42b82810c5409dda/gora-neo4j/src/main/java/org/apache/gora/neo4j/experimental/experiment.java > > Cheers > John > > El vie, 18 dic 2020 a las 23:06, gabriela ortiz (< > arqgabyor...@gmail.com>) escribió: > >> Hi >> >> I wanted to inform the tasks I worked on this week: Dec 12 - Dec 18 >> >> * I wrote a blog about the struggles learning CQL of Neo4j : >> https://gabycoder88.wordpress.com/2020/12/18/discovering-cypher-everybody-struggles/ >> * I created the suggested design document (link below ) with details >> about the Neo4j datastore. >> * I finished creating the structure of the datastore project. >> * I developed and tested the parsing of XML mappings for the >> datastore from gora-neo4j-mapping.xml >> * I developed and tested the read of connection properties from >>
Re: Add datastore for Elasticsearch. Outreachy Week 5 Report
Hi, Thanks for your hard work. Some comments: The XSD validation is not working: org.apache.gora.util.GoraException: java.lang.RuntimeException: org.xml.sax.SAXParseException; schema_reference.4: Failed to read schema document 'file:/tmp/gora/gora-elasticsearch/gora-elasticsearch.xsd', because 1) could not find the document; 2)... The XSD file should be located in the main source code instead of the tests, you can also add a test for the XSD validation. https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/test/resources/gora-elasticsearch.xsd Please add some comments with information about the connection parameters https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/main/java/org/apache/gora/elasticsearch/utils/ElasticsearchParameters.java#L29 I think the security is not set up in the Docker container and the parameters gora.datastore.elasticsearch.username and gora.datastore.elasticsearch.password are simply ignored by the Elasticsearch server. Is that right? https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/test/java/org/apache/gora/elasticsearch/GoraElasticsearchTestDriver.java Cheers, John El sáb, 2 ene 2021 a las 4:52, Maria Podorvanova (< podorvanova.ma...@gmail.com>) escribió: > Hi, > > Report #5 > Period: December 27 - January 2 > Activities: > - Added a property for choosing the authentication method [1] > - Implemented testing with Elasticsearch container [2] > >1. Researched testing side >2. Added test dependencies >3. Added GoraElasticsearchTestDriver with Elasticsearch container >4. Added javadoc descriptions to GoraElasticsearchTestDriver class >5. Fixed two existing tests in accordance to Elasticsearch container > > - Implement some methods for schema management [3] > >1. schemaExists >2. createSchema >3. deleteSchema >4. flush > > > Here are links to the commits: > [1] > https://github.com/apache/gora/commit/457f57a2391856e6d6a5d67c2668c6f28348d40d > > [2] > https://github.com/apache/gora/commit/3d0784721fc8bf158522a6b5dc6e309aae27a2de > > [3] > https://github.com/apache/gora/commit/57da5033ac26a2b31046c83bdfe8729b1aeb6889 > > > Regards, > Maria >
