[jira] [Commented] (GRIFFIN-237) [Jobs] Implement service method getting JobInstanceBean by JobInstanceBean id
[
https://issues.apache.org/jira/browse/GRIFFIN-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793898#comment-16793898
]
R JHS B commented on GRIFFIN-237:
-
The PR is approved and ready to be merged
> [Jobs] Implement service method getting JobInstanceBean by JobInstanceBean id
> -
>
> Key: GRIFFIN-237
> URL: https://issues.apache.org/jira/browse/GRIFFIN-237
> Project: Griffin (Incubating)
> Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Getting particular entity by id is very natural part of any API.Together with
> GRIFFIN-229 it would allow to wait for job
> completion, unlocking lots of potential use cases.
>
> h2. Server
> Provide a RESTful GET method to _/api/v1//jobs/instances/\{jobInstanceId}_
> returning JobInstanceBean for specified jobInstanceBean id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [EXTERNAL] Graduated from the Incubator but Releases remain in Incubator Dist SVN
Hi Dave, I have removed *Airflow *from incubator repo. Regards, Kaxil On Fri, Mar 15, 2019 at 2:26 AM takako shimamoto wrote: > Hi Dave, > > I have removed predictionio from incubator repo. > Thanks! > > On Fri, Mar 15, 2019 at 3:15 AM Gelinas, Derek > wrote: > > > > Dave, > > > > I have removed the releases. Thank you! > > > > Derek > > > > On 3/14/19, 2:01 PM, "Dave Fisher" wrote: > > > > Hi - > > > > You still have releases in the Incubator’s area of SVN - > https://dist.apache.org/repos/dist/release/incubator/ < > https://dist.apache.org/repos/dist/release/incubator/> > > > > Please plan to move or remove these soon. > > > > Thank you! > > > > Regards, > > Dave > > > -- *Kaxil Naik* *Big Data Consultant *@ *Data Reply UK* *Certified *Google Cloud Data Engineer | *Certified* Apache Spark & Neo4j Developer *LinkedIn*: https://www.linkedin.com/in/kaxil
[jira] [Work logged] (GRIFFIN-237) [Jobs] Implement service method getting JobInstanceBean by JobInstanceBean id
[
https://issues.apache.org/jira/browse/GRIFFIN-237?focusedWorklogId=213720&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213720
]
ASF GitHub Bot logged work on GRIFFIN-237:
--
Author: ASF GitHub Bot
Created on: 15/Mar/19 11:55
Start Date: 15/Mar/19 11:55
Worklog Time Spent: 10m
Work Description: jhsb25 commented on issue #486: GRIFFIN-237 Implement
service method get JobInstanceBean by id
URL: https://github.com/apache/griffin/pull/486#issuecomment-473258276
> Could you fix the conflicts?
>
> Thanks,
> William
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 213720)
Time Spent: 1.5h (was: 1h 20m)
> [Jobs] Implement service method getting JobInstanceBean by JobInstanceBean id
> -
>
> Key: GRIFFIN-237
> URL: https://issues.apache.org/jira/browse/GRIFFIN-237
> Project: Griffin (Incubating)
> Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Getting particular entity by id is very natural part of any API.Together with
> GRIFFIN-229 it would allow to wait for job
> completion, unlocking lots of potential use cases.
>
> h2. Server
> Provide a RESTful GET method to _/api/v1//jobs/instances/\{jobInstanceId}_
> returning JobInstanceBean for specified jobInstanceBean id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-237) [Jobs] Implement service method getting JobInstanceBean by JobInstanceBean id
[
https://issues.apache.org/jira/browse/GRIFFIN-237?focusedWorklogId=213726&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213726
]
ASF GitHub Bot logged work on GRIFFIN-237:
--
Author: ASF GitHub Bot
Created on: 15/Mar/19 12:01
Start Date: 15/Mar/19 12:01
Worklog Time Spent: 10m
Work Description: jhsb25 commented on issue #486: GRIFFIN-237 Implement
service method get JobInstanceBean by id
URL: https://github.com/apache/griffin/pull/486#issuecomment-473258276
> Could you fix the conflicts?
>
> Thanks,
> William
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 213726)
Time Spent: 2h (was: 1h 50m)
> [Jobs] Implement service method getting JobInstanceBean by JobInstanceBean id
> -
>
> Key: GRIFFIN-237
> URL: https://issues.apache.org/jira/browse/GRIFFIN-237
> Project: Griffin (Incubating)
> Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Getting particular entity by id is very natural part of any API.Together with
> GRIFFIN-229 it would allow to wait for job
> completion, unlocking lots of potential use cases.
>
> h2. Server
> Provide a RESTful GET method to _/api/v1//jobs/instances/\{jobInstanceId}_
> returning JobInstanceBean for specified jobInstanceBean id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [griffin] jhsb25 removed a comment on issue #486: GRIFFIN-237 Implement service method get JobInstanceBean by id
jhsb25 removed a comment on issue #486: GRIFFIN-237 Implement service method get JobInstanceBean by id URL: https://github.com/apache/griffin/pull/486#issuecomment-473258276 > Could you fix the conflicts? > > Thanks, > William This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (GRIFFIN-237) [Jobs] Implement service method getting JobInstanceBean by JobInstanceBean id
[
https://issues.apache.org/jira/browse/GRIFFIN-237?focusedWorklogId=213721&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213721
]
ASF GitHub Bot logged work on GRIFFIN-237:
--
Author: ASF GitHub Bot
Created on: 15/Mar/19 11:55
Start Date: 15/Mar/19 11:55
Worklog Time Spent: 10m
Work Description: jhsb25 commented on pull request #486: GRIFFIN-237
Implement service method get JobInstanceBean by id
URL: https://github.com/apache/griffin/pull/486
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 213721)
Time Spent: 1h 40m (was: 1.5h)
> [Jobs] Implement service method getting JobInstanceBean by JobInstanceBean id
> -
>
> Key: GRIFFIN-237
> URL: https://issues.apache.org/jira/browse/GRIFFIN-237
> Project: Griffin (Incubating)
> Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Getting particular entity by id is very natural part of any API.Together with
> GRIFFIN-229 it would allow to wait for job
> completion, unlocking lots of potential use cases.
>
> h2. Server
> Provide a RESTful GET method to _/api/v1//jobs/instances/\{jobInstanceId}_
> returning JobInstanceBean for specified jobInstanceBean id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-237) [Jobs] Implement service method getting JobInstanceBean by JobInstanceBean id
[
https://issues.apache.org/jira/browse/GRIFFIN-237?focusedWorklogId=213719&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213719
]
ASF GitHub Bot logged work on GRIFFIN-237:
--
Author: ASF GitHub Bot
Created on: 15/Mar/19 11:55
Start Date: 15/Mar/19 11:55
Worklog Time Spent: 10m
Work Description: jhsb25 commented on pull request #486: GRIFFIN-237
Implement service method get JobInstanceBean by id
URL: https://github.com/apache/griffin/pull/486#discussion_r265951043
##
File path:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java
##
@@ -288,6 +288,11 @@ public void deleteJob(String name) throws
SchedulerException {
return updateState(instances);
}
+@Override
+public JobInstanceBean findInstance(Long id) {
+return instanceRepo.findByInstanceId(id);
+}
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 213719)
Time Spent: 1h 20m (was: 1h 10m)
> [Jobs] Implement service method getting JobInstanceBean by JobInstanceBean id
> -
>
> Key: GRIFFIN-237
> URL: https://issues.apache.org/jira/browse/GRIFFIN-237
> Project: Griffin (Incubating)
> Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Getting particular entity by id is very natural part of any API.Together with
> GRIFFIN-229 it would allow to wait for job
> completion, unlocking lots of potential use cases.
>
> h2. Server
> Provide a RESTful GET method to _/api/v1//jobs/instances/\{jobInstanceId}_
> returning JobInstanceBean for specified jobInstanceBean id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [griffin] jhsb25 opened a new pull request #486: GRIFFIN-237 Implement service method get JobInstanceBean by id
jhsb25 opened a new pull request #486: GRIFFIN-237 Implement service method get JobInstanceBean by id URL: https://github.com/apache/griffin/pull/486 Implement service method getting JobInstanceBean by JobInstanceBean id This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (GRIFFIN-237) [Jobs] Implement service method getting JobInstanceBean by JobInstanceBean id
[
https://issues.apache.org/jira/browse/GRIFFIN-237?focusedWorklogId=213722&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213722
]
ASF GitHub Bot logged work on GRIFFIN-237:
--
Author: ASF GitHub Bot
Created on: 15/Mar/19 11:55
Start Date: 15/Mar/19 11:55
Worklog Time Spent: 10m
Work Description: jhsb25 commented on pull request #486: GRIFFIN-237
Implement service method get JobInstanceBean by id
URL: https://github.com/apache/griffin/pull/486
Implement service method getting JobInstanceBean by JobInstanceBean id
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 213722)
Time Spent: 1h 50m (was: 1h 40m)
> [Jobs] Implement service method getting JobInstanceBean by JobInstanceBean id
> -
>
> Key: GRIFFIN-237
> URL: https://issues.apache.org/jira/browse/GRIFFIN-237
> Project: Griffin (Incubating)
> Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Getting particular entity by id is very natural part of any API.Together with
> GRIFFIN-229 it would allow to wait for job
> completion, unlocking lots of potential use cases.
>
> h2. Server
> Provide a RESTful GET method to _/api/v1//jobs/instances/\{jobInstanceId}_
> returning JobInstanceBean for specified jobInstanceBean id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [griffin] jhsb25 commented on issue #486: GRIFFIN-237 Implement service method get JobInstanceBean by id
jhsb25 commented on issue #486: GRIFFIN-237 Implement service method get JobInstanceBean by id URL: https://github.com/apache/griffin/pull/486#issuecomment-473258276 > Could you fix the conflicts? > > Thanks, > William This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [griffin] jhsb25 closed pull request #486: GRIFFIN-237 Implement service method get JobInstanceBean by id
jhsb25 closed pull request #486: GRIFFIN-237 Implement service method get JobInstanceBean by id URL: https://github.com/apache/griffin/pull/486 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [griffin] jhsb25 commented on a change in pull request #486: GRIFFIN-237 Implement service method get JobInstanceBean by id
jhsb25 commented on a change in pull request #486: GRIFFIN-237 Implement
service method get JobInstanceBean by id
URL: https://github.com/apache/griffin/pull/486#discussion_r265951043
##
File path:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java
##
@@ -288,6 +288,11 @@ public void deleteJob(String name) throws
SchedulerException {
return updateState(instances);
}
+@Override
+public JobInstanceBean findInstance(Long id) {
+return instanceRepo.findByInstanceId(id);
+}
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Work logged] (GRIFFIN-237) [Jobs] Implement service method getting JobInstanceBean by JobInstanceBean id
[
https://issues.apache.org/jira/browse/GRIFFIN-237?focusedWorklogId=213684&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213684
]
ASF GitHub Bot logged work on GRIFFIN-237:
--
Author: ASF GitHub Bot
Created on: 15/Mar/19 10:44
Start Date: 15/Mar/19 10:44
Worklog Time Spent: 10m
Work Description: jhsb25 commented on pull request #486: GRIFFIN-237
Implement service method get JobInstanceBean by id
URL: https://github.com/apache/griffin/pull/486#discussion_r265930025
##
File path:
service/src/main/java/org/apache/griffin/core/job/repo/JobInstanceRepo.java
##
@@ -34,6 +34,9 @@ Licensed to the Apache Software Foundation (ASF) under one
JobInstanceBean findByPredicateName(String name);
+@Query("select s from JobInstanceBean s where s.id = ?1")
Review comment:
yes
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 213684)
Time Spent: 1h 10m (was: 1h)
> [Jobs] Implement service method getting JobInstanceBean by JobInstanceBean id
> -
>
> Key: GRIFFIN-237
> URL: https://issues.apache.org/jira/browse/GRIFFIN-237
> Project: Griffin (Incubating)
> Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Getting particular entity by id is very natural part of any API.Together with
> GRIFFIN-229 it would allow to wait for job
> completion, unlocking lots of potential use cases.
>
> h2. Server
> Provide a RESTful GET method to _/api/v1//jobs/instances/\{jobInstanceId}_
> returning JobInstanceBean for specified jobInstanceBean id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [griffin] jhsb25 commented on a change in pull request #486: GRIFFIN-237 Implement service method get JobInstanceBean by id
jhsb25 commented on a change in pull request #486: GRIFFIN-237 Implement
service method get JobInstanceBean by id
URL: https://github.com/apache/griffin/pull/486#discussion_r265930025
##
File path:
service/src/main/java/org/apache/griffin/core/job/repo/JobInstanceRepo.java
##
@@ -34,6 +34,9 @@ Licensed to the Apache Software Foundation (ASF) under one
JobInstanceBean findByPredicateName(String name);
+@Query("select s from JobInstanceBean s where s.id = ?1")
Review comment:
yes
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Work logged] (GRIFFIN-237) [Jobs] Implement service method getting JobInstanceBean by JobInstanceBean id
[
https://issues.apache.org/jira/browse/GRIFFIN-237?focusedWorklogId=213633&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213633
]
ASF GitHub Bot logged work on GRIFFIN-237:
--
Author: ASF GitHub Bot
Created on: 15/Mar/19 08:46
Start Date: 15/Mar/19 08:46
Worklog Time Spent: 10m
Work Description: dershovGD commented on pull request #486: GRIFFIN-237
Implement service method get JobInstanceBean by id
URL: https://github.com/apache/griffin/pull/486#discussion_r265890642
##
File path:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java
##
@@ -288,6 +288,11 @@ public void deleteJob(String name) throws
SchedulerException {
return updateState(instances);
}
+@Override
+public JobInstanceBean findInstance(Long id) {
+return instanceRepo.findByInstanceId(id);
+}
Review comment:
I think, it will return null or an exception without any information, what
exactly happens.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 213633)
Time Spent: 1h (was: 50m)
> [Jobs] Implement service method getting JobInstanceBean by JobInstanceBean id
> -
>
> Key: GRIFFIN-237
> URL: https://issues.apache.org/jira/browse/GRIFFIN-237
> Project: Griffin (Incubating)
> Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Getting particular entity by id is very natural part of any API.Together with
> GRIFFIN-229 it would allow to wait for job
> completion, unlocking lots of potential use cases.
>
> h2. Server
> Provide a RESTful GET method to _/api/v1//jobs/instances/\{jobInstanceId}_
> returning JobInstanceBean for specified jobInstanceBean id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [griffin] dershovGD commented on a change in pull request #486: GRIFFIN-237 Implement service method get JobInstanceBean by id
dershovGD commented on a change in pull request #486: GRIFFIN-237 Implement
service method get JobInstanceBean by id
URL: https://github.com/apache/griffin/pull/486#discussion_r265890642
##
File path:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java
##
@@ -288,6 +288,11 @@ public void deleteJob(String name) throws
SchedulerException {
return updateState(instances);
}
+@Override
+public JobInstanceBean findInstance(Long id) {
+return instanceRepo.findByInstanceId(id);
+}
Review comment:
I think, it will return null or an exception without any information, what
exactly happens.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
Re: Documentation for merge process
The process is simple and self-descriptive, as follows, (py27) ➜ griffin git:(master) ./merge_pr.py git rev-parse --abbrev-ref HEAD git config --get remote.apache-github.url git config --get remote.apache-git.url Which pull request would you like to merge? (e.g. 34): 484 I've re-written the title as follows to match the standard format: Original: GRIFFIN-232 - add support pluggable predicates Modified: [GRIFFIN-232] add support pluggable predicates Would you like to use the modified title? (y/n): y Using modified title: [GRIFFIN-232] add support pluggable predicates === Pull Request #484 === title [GRIFFIN-232] add support pluggable predicates source aborgatin/feature/GRIFFIN-232 target master url https://api.github.com/repos/apache/griffin/pulls/484 Proceed with merging pull request #484? (y/n): y git fetch apache-github pull/484/head:PR_TOOL_MERGE_PR_484 remote: Enumerating objects: 72, done. remote: Counting objects: 100% (72/72), done. remote: Compressing objects: 100% (38/38), done. remote: Total 92 (delta 38), reused 58 (delta 26), pack-reused 20 Unpacking objects: 100% (92/92), done. >From https://github.com/apache/griffin * [new ref] refs/pull/484/head -> PR_TOOL_MERGE_PR_484 * [new ref] refs/pull/484/head -> apache-github/pr/484/head git fetch apache-git master:PR_TOOL_MERGE_PR_484_MASTER >From https://gitbox.apache.org/repos/asf/griffin * [new branch]master -> PR_TOOL_MERGE_PR_484_MASTER git checkout PR_TOOL_MERGE_PR_484_MASTER Switched to branch 'PR_TOOL_MERGE_PR_484_MASTER' ['git', 'merge', 'PR_TOOL_MERGE_PR_484', '--squash'] Automatic merge went well; stopped before committing as requested ['git', 'log', 'HEAD..PR_TOOL_MERGE_PR_484', '--pretty=format:%an <%ae>'] Enter primary author in the format of "name " [Borgatin Alexandr < aborga...@griddynamics.com>]: ['git', 'log', 'HEAD..PR_TOOL_MERGE_PR_484', '--pretty=format:%h [%an] %s'] ['git', 'commit', '--author="Borgatin Alexandr "', '-m', u'[GRIFFIN-232] add support pluggable predicates', '-m', u'Classifier "exec" added to spring-boot-maven-plugin for possibility use service as a library. This will allow to create custom predicates without recompiling Griffin-service module. \r\n\r\nThe approach to deserialisation in SparkSubmit changed for possibility to use all fields of SegmentPredicate in custom predicates.', '-m', 'Author: Borgatin Alexandr < aborga...@griddynamics.com>', '-m', u'Closes #484 from aborgatin/feature/GRIFFIN-232.'] Merge complete (local ref PR_TOOL_MERGE_PR_484_MASTER). Push to apache-git? (y/n): y git push apache-git PR_TOOL_MERGE_PR_484_MASTER:master Enumerating objects: 60, done. Counting objects: 100% (60/60), done. Delta compression using up to 8 threads Compressing objects: 100% (27/27), done. Writing objects: 100% (35/35), 7.21 KiB | 1.80 MiB/s, done. Total 35 (delta 14), reused 0 (delta 0) remote: To git@github:apache/griffin.git remote:a021b61..11a3011 11a301190ac087e72880d01251a24251e5a0c8bb -> master remote: Syncing refs/heads/master... remote: Sending notification emails to: ['"comm...@griffin.apache.org" < comm...@griffin.apache.org>'] To https://gitbox.apache.org/repos/asf/griffin.git a021b61a..11a30119 PR_TOOL_MERGE_PR_484_MASTER -> master git rev-parse PR_TOOL_MERGE_PR_484_MASTER Restoring head pointer to master git checkout master Switched to branch 'master' git branch Deleting local branch PR_TOOL_MERGE_PR_484 git branch -D PR_TOOL_MERGE_PR_484 Deleting local branch PR_TOOL_MERGE_PR_484_MASTER git branch -D PR_TOOL_MERGE_PR_484_MASTER Pull request #484 merged! Merge hash: 11a30119 Would you like to pick 11a30119 into another branch? (y/n): n Would you like to update an associated JIRA? (y/n): y Enter a Griffin JIRA number id [GRIFFIN-232]: === JIRA GRIFFIN-232 === summary Implement pluggable Predicators in PredicatorFactory assignee NOT ASSIGNED!!! status Open url https://issues.apache.org/jira/browse/GRIFFIN-232 Enter comma-separated fix version(s) [0.5.0]: Successfully resolved GRIFFIN-232 with fixVersions=[u'0.5.0']! (py27) ➜ griffin git:(master) git pull origin master >From https://github.com/apache/griffin * branch master -> FETCH_HEAD a021b61a..11a30119 master -> origin/master Updating a021b61a..11a30119 Fast-forward griffin-doc/measure/predicates.md | 100 ++ service/pom.xml | 17 - service/src/main/java/org/apache/griffin/core/exception/GriffinExceptionMessage.java | 4 +++ service/src/main/java/org/apache/griffin/core/job/SparkSubmitJob.java | 12 +++-- service/src/main/java/org/apache/griffin/core/job/factory/PredicatorFactory.java | 38 +--- service/src/main/java/org/apache/griffin/core/util/MeasureUtil.java | 27 +--- service/src/test/java/org/apache/griffin/core/job/SparkSubmitJobTest.java | 34 - service/
[jira] [Work logged] (GRIFFIN-237) [Jobs] Implement service method getting JobInstanceBean by JobInstanceBean id
[
https://issues.apache.org/jira/browse/GRIFFIN-237?focusedWorklogId=213631&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213631
]
ASF GitHub Bot logged work on GRIFFIN-237:
--
Author: ASF GitHub Bot
Created on: 15/Mar/19 08:38
Start Date: 15/Mar/19 08:38
Worklog Time Spent: 10m
Work Description: guoyuepeng commented on issue #486: GRIFFIN-237
Implement service method get JobInstanceBean by id
URL: https://github.com/apache/griffin/pull/486#issuecomment-473202341
Could you fix the conflicts?
Thanks,
William
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 213631)
Time Spent: 50m (was: 40m)
> [Jobs] Implement service method getting JobInstanceBean by JobInstanceBean id
> -
>
> Key: GRIFFIN-237
> URL: https://issues.apache.org/jira/browse/GRIFFIN-237
> Project: Griffin (Incubating)
> Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Getting particular entity by id is very natural part of any API.Together with
> GRIFFIN-229 it would allow to wait for job
> completion, unlocking lots of potential use cases.
>
> h2. Server
> Provide a RESTful GET method to _/api/v1//jobs/instances/\{jobInstanceId}_
> returning JobInstanceBean for specified jobInstanceBean id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [griffin] guoyuepeng commented on issue #486: GRIFFIN-237 Implement service method get JobInstanceBean by id
guoyuepeng commented on issue #486: GRIFFIN-237 Implement service method get JobInstanceBean by id URL: https://github.com/apache/griffin/pull/486#issuecomment-473202341 Could you fix the conflicts? Thanks, William This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (GRIFFIN-232) Implement pluggable Predicators in PredicatorFactory
[
https://issues.apache.org/jira/browse/GRIFFIN-232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
William Guo resolved GRIFFIN-232.
-
Resolution: Fixed
Fix Version/s: 0.5.0
Issue resolved by pull request 484
[https://github.com/apache/griffin/pull/484]
> Implement pluggable Predicators in PredicatorFactory
>
>
> Key: GRIFFIN-232
> URL: https://issues.apache.org/jira/browse/GRIFFIN-232
> Project: Griffin (Incubating)
> Issue Type: Improvement
>Reporter: Aleksandr Borgatin
>Priority: Minor
> Fix For: 0.5.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> I propose add second type of predicate after "file.exist" - "custom". JSON
> example for creation "custom" predicate
> {code:java}
> {
> "type": "custom",
> "config": {
>"class":
> "org.apache.griffin.core.job.FileExistPredicator",
>"root.path": "/path/to/",
>"path": "file.ext,file2.txt"
> }
> }
> {code}
> Proposed contract for implementations is based on FileExistPredicator:
> * class must implement interface *org.apache.griffin.core.job.Predicator*
> * class must have constructor with argument of type
> *org.apache.griffin.core.job.entity.SegmentPredicate*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-232) Implement pluggable Predicators in PredicatorFactory
[
https://issues.apache.org/jira/browse/GRIFFIN-232?focusedWorklogId=213630&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213630
]
ASF GitHub Bot logged work on GRIFFIN-232:
--
Author: ASF GitHub Bot
Created on: 15/Mar/19 08:12
Start Date: 15/Mar/19 08:12
Worklog Time Spent: 10m
Work Description: asfgit commented on pull request #484: GRIFFIN-232 -
add support pluggable predicates
URL: https://github.com/apache/griffin/pull/484
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 213630)
Time Spent: 2h 20m (was: 2h 10m)
> Implement pluggable Predicators in PredicatorFactory
>
>
> Key: GRIFFIN-232
> URL: https://issues.apache.org/jira/browse/GRIFFIN-232
> Project: Griffin (Incubating)
> Issue Type: Improvement
>Reporter: Aleksandr Borgatin
>Priority: Minor
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> I propose add second type of predicate after "file.exist" - "custom". JSON
> example for creation "custom" predicate
> {code:java}
> {
> "type": "custom",
> "config": {
>"class":
> "org.apache.griffin.core.job.FileExistPredicator",
>"root.path": "/path/to/",
>"path": "file.ext,file2.txt"
> }
> }
> {code}
> Proposed contract for implementations is based on FileExistPredicator:
> * class must implement interface *org.apache.griffin.core.job.Predicator*
> * class must have constructor with argument of type
> *org.apache.griffin.core.job.entity.SegmentPredicate*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (GRIFFIN-239) Refresh griffin deployment guide
[ https://issues.apache.org/jira/browse/GRIFFIN-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eugene resolved GRIFFIN-239. Resolution: Fixed > Refresh griffin deployment guide > > > Key: GRIFFIN-239 > URL: https://issues.apache.org/jira/browse/GRIFFIN-239 > Project: Griffin (Incubating) > Issue Type: Task >Affects Versions: 0.4.0 >Reporter: Eugene >Assignee: Eugene >Priority: Minor > Fix For: 0.5.0 > > > deployment guide is not clear and completed, we need to refresh it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [griffin] asfgit closed pull request #484: GRIFFIN-232 - add support pluggable predicates
asfgit closed pull request #484: GRIFFIN-232 - add support pluggable predicates URL: https://github.com/apache/griffin/pull/484 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (GRIFFIN-239) Refresh griffin deployment guide
[ https://issues.apache.org/jira/browse/GRIFFIN-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793431#comment-16793431 ] Eugene commented on GRIFFIN-239: let me close this task , as PR-488([https://github.com/apache/griffin/pull/488)] has been merged > Refresh griffin deployment guide > > > Key: GRIFFIN-239 > URL: https://issues.apache.org/jira/browse/GRIFFIN-239 > Project: Griffin (Incubating) > Issue Type: Task >Affects Versions: 0.4.0 >Reporter: Eugene >Assignee: Eugene >Priority: Minor > Fix For: 0.5.0 > > > deployment guide is not clear and completed, we need to refresh it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Documentation for merge process
hi Nick, PMC can merge PR after two PMC approved. I will try to grant your the permission for merging, please have a check. Thanks, William On Thu, Mar 14, 2019 at 12:03 PM Nick Sokolov wrote: > Hi! > > Question to committers: is there any documentation for 1) approval process > (how many approvals PR should get to be merged), and 2) what is the process > to merge a PR? > > There is a bunch of PRs that I think is ready to merge, I'd like to follow > right process for them. Specifically: > >- https://github.com/apache/griffin/pull/486 >- https://github.com/apache/griffin/pull/485 >- https://github.com/apache/griffin/pull/484 > > Thanks in advance >
[jira] [Work logged] (GRIFFIN-232) Implement pluggable Predicators in PredicatorFactory
[
https://issues.apache.org/jira/browse/GRIFFIN-232?focusedWorklogId=213625&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213625
]
ASF GitHub Bot logged work on GRIFFIN-232:
--
Author: ASF GitHub Bot
Created on: 15/Mar/19 07:56
Start Date: 15/Mar/19 07:56
Worklog Time Spent: 10m
Work Description: guoyuepeng commented on issue #484: GRIFFIN-232 - add
support pluggable predicates
URL: https://github.com/apache/griffin/pull/484#issuecomment-473191965
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 213625)
Time Spent: 2h 10m (was: 2h)
> Implement pluggable Predicators in PredicatorFactory
>
>
> Key: GRIFFIN-232
> URL: https://issues.apache.org/jira/browse/GRIFFIN-232
> Project: Griffin (Incubating)
> Issue Type: Improvement
>Reporter: Aleksandr Borgatin
>Priority: Minor
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> I propose add second type of predicate after "file.exist" - "custom". JSON
> example for creation "custom" predicate
> {code:java}
> {
> "type": "custom",
> "config": {
>"class":
> "org.apache.griffin.core.job.FileExistPredicator",
>"root.path": "/path/to/",
>"path": "file.ext,file2.txt"
> }
> }
> {code}
> Proposed contract for implementations is based on FileExistPredicator:
> * class must implement interface *org.apache.griffin.core.job.Predicator*
> * class must have constructor with argument of type
> *org.apache.griffin.core.job.entity.SegmentPredicate*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [griffin] guoyuepeng commented on issue #484: GRIFFIN-232 - add support pluggable predicates
guoyuepeng commented on issue #484: GRIFFIN-232 - add support pluggable predicates URL: https://github.com/apache/griffin/pull/484#issuecomment-473191965 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
