[jira] [Resolved] (HBASE-27023) Add protobuf to NOTICE file
[ https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27023. --- Fix Version/s: 3.0.0-alpha-3 2.4.13 2.5.1 Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.4+. Thanks [~psomogyi] and [~haxiaolin] for reviewing! > Add protobuf to NOTICE file > --- > > Key: HBASE-27023 > URL: https://issues.apache.org/jira/browse/HBASE-27023 > Project: HBase > Issue Type: Task >Reporter: Peter Somogyi >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3, 2.4.13, 2.5.1 > > > The spotless formatting removed the protobuf credit from the > AbstractByteRange. It is currently not included in the NOTICE file. > https://github.com/apache/hbase/commit/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443#diff-f5806f14849a23b9265b022f3f330b80d08bcc10fcf69d8ee2e1b0d5af266d52 -- This message was sent by Atlassian Jira (v8.20.7#820007)
Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation
Oh, I think we should include HBASE-27023, it fixes the license issue after we apply the spotless formatter where it will add the license header automatically. And also, it seems that the generated RELEASENOTE.md will introduce some lines ending with whitespace, then it will cause pre commit build failure. I think we should run a spotless:apply before committing the files in the release scripts, and maybe we should also add spotless:check in the mvn verify stage so it will also fail the mvn install command, which will let developers pay more attention on it. Let me open an issue to land these changes. 张铎(Duo Zhang) 于2022年6月2日周四 11:14写道： > OK, got it. Thanks for the clarification~ > > Andrew Purtell 于2022年6月2日周四 11:12写道： > >> I don’t think a flaky test is cause to fail the release. So these all >> have a fix version of 2.5.1. I mentioned them so people could be aware of >> these known issue when evaluating their own findings. Hope that helps. >> >> > On Jun 1, 2022, at 8:11 PM, 张铎 wrote: >> > >> > On flakyness, if it is a big problem on promoting the RC, I think we >> can >> > ignore the test first(instead of removing it). >> > >> > Can open a follow on issue to make it stable. >> > >> > Thanks. >> > >> > Andrew Purtell 于2022年6月1日周三 23:25写道： >> > >> >> Makes sense and if nobody has a concern we can do that. >> >> >> >> Also you wanted to support the change to the RSGroup API and put back >> the >> >> unit test (and fix it to not flake), correct, which seems fine to me >> too. >> >> >> >>> On Tue, May 31, 2022 at 10:54 PM 张铎(Duo Zhang) > > >> >>> wrote: >> >>> >> >>> The ReplicationLoadSink change is done in HBASE-26490, this is the >> commit >> >>> >> >>> >> >>> >> >> >> https://github.com/apache/hbase/commit/b5b286d793f00ec8b9ed02f51fd9324e46f29c86 >> >>> >> >>> The constructor is marked as IA.Private so I do not think we need to >> >>> restore it back. >> >>> >> >>> Thanks. >> >>> >> >>> Andrew Purtell 于2022年6月1日周三 13:08写道： >> >>> >> This is not a VOTE. >> >> HBase 2.5.0RC0 is ready for testing, other evaluation, and >> >> consideration >> >>> of >> compatibility concerns. >> >> The release notes need to be rebased on the latest 2.4.x release, >> >> 2.4.12. >> Fix >> versions on relvant JIRAs must be cleaned up first. This is in >> >> progress. >> >>> I >> also plan to try our new audit tool for matching git history and fix >> versions. >> >> There are known flaky unit tests and minor issues. You can find them >> by >> searching for the '2.5.1' fix version, or this URL: >> >> https://s.apache.org/hbase-v2.5.1 >> >> The compatibility report, based on 2.4.12, can be found here: >> >> >> >> >> >>> >> >> >> https://dist.apache.org/repos/dist/dev/hbase/2.5.0RC0/api_compare_2.4.12_to_2.5.0RC0.html >> >> An initial response to some of the findings can be found on >> >> HBASE-27081, >> along >> with additional discussion. Further discussion is probably necessary. >> >> The tag to be evaluated is 2.5.0RC0: >> >> https://github.com/apache/hbase/tree/2.5.0RC0 >> >> This tag currently points to git reference 2da2dd917 . >> >> The release files, including signatures, digests, as well as >> CHANGES.md >> and RELEASENOTES.md included in this RC can be found at: >> >> https://dist.apache.org/repos/dist/dev/hbase/2.5.0RC0/ >> >> Maven artifacts are available in a staging repository at: >> >> >> >>> >> https://repository.apache.org/content/repositories/orgapachehbase-1486/ >> >> Artifacts were signed with the 0xD5365CCD key which can be found in: >> >> https://downloads.apache.org/hbase/KEYS >> >> The second release candidate, 2.5.0RC1, will be made available for >> evaluation >> after discussion and any necessary changes and fixes have settled. >> >> Best, >> >> Your 2.5 Release Manager >> >> >>> >> >> >> >> >> >> -- >> >> Best regards, >> >> Andrew >> >> >> >> Unrest, ignorance distilled, nihilistic imbeciles - >> >>It's what we’ve earned >> >> Welcome, apocalypse, what’s taken you so long? >> >> Bring us the fitting end that we’ve been counting on >> >> - A23, Welcome, Apocalypse >> >> >> >
[jira] [Created] (HBASE-27083) Run spotless:apply in release scripts when we want to commit something
Duo Zhang created HBASE-27083: - Summary: Run spotless:apply in release scripts when we want to commit something Key: HBASE-27083 URL: https://issues.apache.org/jira/browse/HBASE-27083 Project: HBase Issue Type: Sub-task Components: scripts Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (HBASE-27084) Add spotless:check in mvn verify stage
Duo Zhang created HBASE-27084: - Summary: Add spotless:check in mvn verify stage Key: HBASE-27084 URL: https://issues.apache.org/jira/browse/HBASE-27084 Project: HBase Issue Type: Improvement Components: build, pom Reporter: Duo Zhang Assignee: Duo Zhang So mvn install will fail if we violate the format rules, which will make developer pay more attention on fixing the format issue. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (HBASE-27037) Display the region server state on the Web UI
[ https://issues.apache.org/jira/browse/HBASE-27037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27037. --- Fix Version/s: 2.5.0 3.0.0-alpha-3 Hadoop Flags: Reviewed Resolution: Fixed Pushed to master and branch-2. Thanks [~tomscut] for contributing! > Display the region server state on the Web UI > - > > Key: HBASE-27037 > URL: https://issues.apache.org/jira/browse/HBASE-27037 > Project: HBase > Issue Type: Wish >Reporter: Tao Li >Assignee: Tao Li >Priority: Major > Fix For: 2.5.0, 3.0.0-alpha-3 > > Attachments: image-2022-05-18-14-39-44-208.png > > > Display the region server state on the Web UI. > !image-2022-05-18-14-39-44-208.png|width=729,height=126! -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (HBASE-27039) Some methods of MasterRegion should be annotated for testing only
[ https://issues.apache.org/jira/browse/HBASE-27039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27039. --- Fix Version/s: 2.6.0 3.0.0-alpha-3 2.4.13 2.5.1 Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.4+. Thanks [~heliangjun] for contributing! > Some methods of MasterRegion should be annotated for testing only > - > > Key: HBASE-27039 > URL: https://issues.apache.org/jira/browse/HBASE-27039 > Project: HBase > Issue Type: Test > Components: master >Reporter: LiangJun He >Assignee: LiangJun He >Priority: Minor > Fix For: 2.6.0, 3.0.0-alpha-3, 2.4.13, 2.5.1 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation
I just noticed the release notes issue on the branch last evening. Let’s add the spotless application to the release note generation step in create-release at least or it will keep happening. The RM does not get a chance to intervene. The script uses the RM credentials to commit immediately after generating the files. > On Jun 2, 2022, at 5:31 AM, 张铎 wrote: > > Oh, I think we should include HBASE-27023, it fixes the license issue after > we apply the spotless formatter where it will add the license header > automatically. > > And also, it seems that the generated RELEASENOTE.md will introduce some > lines ending with whitespace, then it will cause pre commit build failure. > > I think we should run a spotless:apply before committing the files in the > release scripts, and maybe we should also add spotless:check in the mvn > verify stage so it will also fail the mvn install command, which will let > developers pay more attention on it. > > Let me open an issue to land these changes. > > 张铎(Duo Zhang) 于2022年6月2日周四 11:14写道： > >> OK, got it. Thanks for the clarification~ >> >> Andrew Purtell 于2022年6月2日周四 11:12写道： >> >>> I don’t think a flaky test is cause to fail the release. So these all >>> have a fix version of 2.5.1. I mentioned them so people could be aware of >>> these known issue when evaluating their own findings. Hope that helps. >>> > On Jun 1, 2022, at 8:11 PM, 张铎 wrote: > > On flakyness, if it is a big problem on promoting the RC, I think we >>> can ignore the test first(instead of removing it). Can open a follow on issue to make it stable. Thanks. Andrew Purtell 于2022年6月1日周三 23:25写道： > Makes sense and if nobody has a concern we can do that. > > Also you wanted to support the change to the RSGroup API and put back >>> the > unit test (and fix it to not flake), correct, which seems fine to me >>> too. > >> On Tue, May 31, 2022 at 10:54 PM 张铎(Duo Zhang) >>> >> wrote: >> >> The ReplicationLoadSink change is done in HBASE-26490, this is the >>> commit >> >> >> > >>> https://github.com/apache/hbase/commit/b5b286d793f00ec8b9ed02f51fd9324e46f29c86 >> >> The constructor is marked as IA.Private so I do not think we need to >> restore it back. >> >> Thanks. >> >> Andrew Purtell 于2022年6月1日周三 13:08写道： >> >>> This is not a VOTE. >>> >>> HBase 2.5.0RC0 is ready for testing, other evaluation, and > consideration >> of >>> compatibility concerns. >>> >>> The release notes need to be rebased on the latest 2.4.x release, > 2.4.12. >>> Fix >>> versions on relvant JIRAs must be cleaned up first. This is in > progress. >> I >>> also plan to try our new audit tool for matching git history and fix >>> versions. >>> >>> There are known flaky unit tests and minor issues. You can find them >>> by >>> searching for the '2.5.1' fix version, or this URL: >>> >>> https://s.apache.org/hbase-v2.5.1 >>> >>> The compatibility report, based on 2.4.12, can be found here: >>> >>> >>> >>> >> > >>> https://dist.apache.org/repos/dist/dev/hbase/2.5.0RC0/api_compare_2.4.12_to_2.5.0RC0.html >>> >>> An initial response to some of the findings can be found on > HBASE-27081, >>> along >>> with additional discussion. Further discussion is probably necessary. >>> >>> The tag to be evaluated is 2.5.0RC0: >>> >>> https://github.com/apache/hbase/tree/2.5.0RC0 >>> >>> This tag currently points to git reference 2da2dd917 . >>> >>> The release files, including signatures, digests, as well as >>> CHANGES.md >>> and RELEASENOTES.md included in this RC can be found at: >>> >>> https://dist.apache.org/repos/dist/dev/hbase/2.5.0RC0/ >>> >>> Maven artifacts are available in a staging repository at: >>> >>> >> >>> https://repository.apache.org/content/repositories/orgapachehbase-1486/ >>> >>> Artifacts were signed with the 0xD5365CCD key which can be found in: >>> >>> https://downloads.apache.org/hbase/KEYS >>> >>> The second release candidate, 2.5.0RC1, will be made available for >>> evaluation >>> after discussion and any necessary changes and fixes have settled. >>> >>> Best, >>> >>> Your 2.5 Release Manager >>> >> > > > -- > Best regards, > Andrew > > Unrest, ignorance distilled, nihilistic imbeciles - > It's what we’ve earned > Welcome, apocalypse, what’s taken you so long? > Bring us the fitting end that we’ve been counting on > - A23, Welcome, Apocalypse > >>> >>
[jira] [Resolved] (HBASE-26962) Add mob info in web UI
[ https://issues.apache.org/jira/browse/HBASE-26962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26962. --- Fix Version/s: 2.6.0 3.0.0-alpha-3 Hadoop Flags: Reviewed Resolution: Fixed Pushed to master and branch-2. Thanks [~liangxs] for contributing! > Add mob info in web UI > -- > > Key: HBASE-26962 > URL: https://issues.apache.org/jira/browse/HBASE-26962 > Project: HBase > Issue Type: Improvement > Components: UI >Reporter: Xuesen Liang >Assignee: Xuesen Liang >Priority: Minor > Fix For: 2.6.0, 3.0.0-alpha-3 > > > Add mob store info in web UI. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (HBASE-27085) Create REPLICATION_SINK_TRACKER table to persist sentinel rows coming from source cluster.
Rushabh Shah created HBASE-27085: Summary: Create REPLICATION_SINK_TRACKER table to persist sentinel rows coming from source cluster. Key: HBASE-27085 URL: https://issues.apache.org/jira/browse/HBASE-27085 Project: HBase Issue Type: Sub-task Reporter: Rushabh Shah Assignee: Rushabh Shah This work is to create sink tracker table to persist tracker rows coming from replication source cluster. Create ReplicationMarkerChore to create replication marker rows periodically. -- This message was sent by Atlassian Jira (v8.20.7#820007)
Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation
Oh, wait a minute. IIRC we have a consensus to use the jira page as release note instead of committing a file to the repo? The problem is that, sometimes we just missed something in CHANGES.md or RELEASENOTES.md, no actually code change, but since we have committed these files to our git repo, we have to sink the RC and generate a new one. IIRC for making the two alpha releases for 3.0.0, I have already started to link the jira page instead of CHANGES.md and RELEASENOTES.md. Maybe we could just remove these steps from the create release scripts? But maybe for branch-2.4 we still need to use these steps... Thanks. Andrew Purtell 于2022年6月2日周四 22:56写道： > I just noticed the release notes issue on the branch last evening. Let’s > add the spotless application to the release note generation step in > create-release at least or it will keep happening. The RM does not get a > chance to intervene. The script uses the RM credentials to commit > immediately after generating the files. > > > On Jun 2, 2022, at 5:31 AM, 张铎 wrote: > > > > Oh, I think we should include HBASE-27023, it fixes the license issue > after > > we apply the spotless formatter where it will add the license header > > automatically. > > > > And also, it seems that the generated RELEASENOTE.md will introduce some > > lines ending with whitespace, then it will cause pre commit build > failure. > > > > I think we should run a spotless:apply before committing the files in the > > release scripts, and maybe we should also add spotless:check in the mvn > > verify stage so it will also fail the mvn install command, which will let > > developers pay more attention on it. > > > > Let me open an issue to land these changes. > > > > 张铎(Duo Zhang) 于2022年6月2日周四 11:14写道： > > > >> OK, got it. Thanks for the clarification~ > >> > >> Andrew Purtell 于2022年6月2日周四 11:12写道： > >> > >>> I don’t think a flaky test is cause to fail the release. So these all > >>> have a fix version of 2.5.1. I mentioned them so people could be aware > of > >>> these known issue when evaluating their own findings. Hope that helps. > >>> > > On Jun 1, 2022, at 8:11 PM, 张铎 wrote: > > > > On flakyness, if it is a big problem on promoting the RC, I think we > >>> can > ignore the test first(instead of removing it). > > Can open a follow on issue to make it stable. > > Thanks. > > Andrew Purtell 于2022年6月1日周三 23:25写道： > > > Makes sense and if nobody has a concern we can do that. > > > > Also you wanted to support the change to the RSGroup API and put back > >>> the > > unit test (and fix it to not flake), correct, which seems fine to me > >>> too. > > > >> On Tue, May 31, 2022 at 10:54 PM 张铎(Duo Zhang) < > palomino...@gmail.com > > >> wrote: > >> > >> The ReplicationLoadSink change is done in HBASE-26490, this is the > >>> commit > >> > >> > >> > > > >>> > https://github.com/apache/hbase/commit/b5b286d793f00ec8b9ed02f51fd9324e46f29c86 > >> > >> The constructor is marked as IA.Private so I do not think we need to > >> restore it back. > >> > >> Thanks. > >> > >> Andrew Purtell 于2022年6月1日周三 13:08写道： > >> > >>> This is not a VOTE. > >>> > >>> HBase 2.5.0RC0 is ready for testing, other evaluation, and > > consideration > >> of > >>> compatibility concerns. > >>> > >>> The release notes need to be rebased on the latest 2.4.x release, > > 2.4.12. > >>> Fix > >>> versions on relvant JIRAs must be cleaned up first. This is in > > progress. > >> I > >>> also plan to try our new audit tool for matching git history and > fix > >>> versions. > >>> > >>> There are known flaky unit tests and minor issues. You can find > them > >>> by > >>> searching for the '2.5.1' fix version, or this URL: > >>> > >>> https://s.apache.org/hbase-v2.5.1 > >>> > >>> The compatibility report, based on 2.4.12, can be found here: > >>> > >>> > >>> > >>> > >> > > > >>> > https://dist.apache.org/repos/dist/dev/hbase/2.5.0RC0/api_compare_2.4.12_to_2.5.0RC0.html > >>> > >>> An initial response to some of the findings can be found on > > HBASE-27081, > >>> along > >>> with additional discussion. Further discussion is probably > necessary. > >>> > >>> The tag to be evaluated is 2.5.0RC0: > >>> > >>> https://github.com/apache/hbase/tree/2.5.0RC0 > >>> > >>> This tag currently points to git reference 2da2dd917 . > >>> > >>> The release files, including signatures, digests, as well as > >>> CHANGES.md > >>> and RELEASENOTES.md included in this RC can be found at: > >>> > >>> https://dist.apache.org/repos/dist/dev/hbase/2.5.0RC0/ > >>> > >>> Maven artifacts are available in a staging repository at: > >>> > >>> > >> > >>> > https://repository.apache.org/content/repositories/orgapachehbase-1486/ > >>
Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation
I see, that would be totally fine with me if we just do the link instead of generating the files every time. On Thu, Jun 2, 2022 at 9:31 AM 张铎(Duo Zhang) wrote: > Oh, wait a minute. IIRC we have a consensus to use the jira page as release > note instead of committing a file to the repo? The problem is that, > sometimes we just missed something in CHANGES.md or RELEASENOTES.md, no > actually code change, but since we have committed these files to our git > repo, we have to sink the RC and generate a new one. > > IIRC for making the two alpha releases for 3.0.0, I have already started to > link the jira page instead of CHANGES.md and RELEASENOTES.md. Maybe we > could just remove these steps from the create release scripts? But maybe > for branch-2.4 we still need to use these steps... > > Thanks. > > Andrew Purtell 于2022年6月2日周四 22:56写道： > > > I just noticed the release notes issue on the branch last evening. Let’s > > add the spotless application to the release note generation step in > > create-release at least or it will keep happening. The RM does not get a > > chance to intervene. The script uses the RM credentials to commit > > immediately after generating the files. > > > > > On Jun 2, 2022, at 5:31 AM, 张铎 wrote: > > > > > > Oh, I think we should include HBASE-27023, it fixes the license issue > > after > > > we apply the spotless formatter where it will add the license header > > > automatically. > > > > > > And also, it seems that the generated RELEASENOTE.md will introduce > some > > > lines ending with whitespace, then it will cause pre commit build > > failure. > > > > > > I think we should run a spotless:apply before committing the files in > the > > > release scripts, and maybe we should also add spotless:check in the mvn > > > verify stage so it will also fail the mvn install command, which will > let > > > developers pay more attention on it. > > > > > > Let me open an issue to land these changes. > > > > > > 张铎(Duo Zhang) 于2022年6月2日周四 11:14写道： > > > > > >> OK, got it. Thanks for the clarification~ > > >> > > >> Andrew Purtell 于2022年6月2日周四 11:12写道： > > >> > > >>> I don’t think a flaky test is cause to fail the release. So these all > > >>> have a fix version of 2.5.1. I mentioned them so people could be > aware > > of > > >>> these known issue when evaluating their own findings. Hope that > helps. > > >>> > > > On Jun 1, 2022, at 8:11 PM, 张铎 wrote: > > > > > > On flakyness, if it is a big problem on promoting the RC, I think > we > > >>> can > > ignore the test first(instead of removing it). > > > > Can open a follow on issue to make it stable. > > > > Thanks. > > > > Andrew Purtell 于2022年6月1日周三 23:25写道： > > > > > Makes sense and if nobody has a concern we can do that. > > > > > > Also you wanted to support the change to the RSGroup API and put > back > > >>> the > > > unit test (and fix it to not flake), correct, which seems fine to > me > > >>> too. > > > > > >> On Tue, May 31, 2022 at 10:54 PM 张铎(Duo Zhang) < > > palomino...@gmail.com > > > > >> wrote: > > >> > > >> The ReplicationLoadSink change is done in HBASE-26490, this is the > > >>> commit > > >> > > >> > > >> > > > > > >>> > > > https://github.com/apache/hbase/commit/b5b286d793f00ec8b9ed02f51fd9324e46f29c86 > > >> > > >> The constructor is marked as IA.Private so I do not think we need > to > > >> restore it back. > > >> > > >> Thanks. > > >> > > >> Andrew Purtell 于2022年6月1日周三 13:08写道： > > >> > > >>> This is not a VOTE. > > >>> > > >>> HBase 2.5.0RC0 is ready for testing, other evaluation, and > > > consideration > > >> of > > >>> compatibility concerns. > > >>> > > >>> The release notes need to be rebased on the latest 2.4.x release, > > > 2.4.12. > > >>> Fix > > >>> versions on relvant JIRAs must be cleaned up first. This is in > > > progress. > > >> I > > >>> also plan to try our new audit tool for matching git history and > > fix > > >>> versions. > > >>> > > >>> There are known flaky unit tests and minor issues. You can find > > them > > >>> by > > >>> searching for the '2.5.1' fix version, or this URL: > > >>> > > >>> https://s.apache.org/hbase-v2.5.1 > > >>> > > >>> The compatibility report, based on 2.4.12, can be found here: > > >>> > > >>> > > >>> > > >>> > > >> > > > > > >>> > > > https://dist.apache.org/repos/dist/dev/hbase/2.5.0RC0/api_compare_2.4.12_to_2.5.0RC0.html > > >>> > > >>> An initial response to some of the findings can be found on > > > HBASE-27081, > > >>> along > > >>> with additional discussion. Further discussion is probably > > necessary. > > >>> > > >>> The tag to be evaluated is 2.5.0RC0: > > >>> > > >>> https://github.com/apache/hbase/tree/2.5.0RC0 > > >>> > > >>> This tag currently points to git r
Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation
Even for branch-2.4, we can start placing links into the file, at the top, leaving the output of the prior process in place below. I think it is fine to make this change everywhere. Curious what others think. On Thu, Jun 2, 2022 at 10:54 AM Andrew Purtell wrote: > I see, that would be totally fine with me if we just do the link instead > of generating the files every time. > > On Thu, Jun 2, 2022 at 9:31 AM 张铎(Duo Zhang) > wrote: > >> Oh, wait a minute. IIRC we have a consensus to use the jira page as >> release >> note instead of committing a file to the repo? The problem is that, >> sometimes we just missed something in CHANGES.md or RELEASENOTES.md, no >> actually code change, but since we have committed these files to our git >> repo, we have to sink the RC and generate a new one. >> >> IIRC for making the two alpha releases for 3.0.0, I have already started >> to >> link the jira page instead of CHANGES.md and RELEASENOTES.md. Maybe we >> could just remove these steps from the create release scripts? But maybe >> for branch-2.4 we still need to use these steps... >> >> Thanks. >> >> Andrew Purtell 于2022年6月2日周四 22:56写道： >> >> > I just noticed the release notes issue on the branch last evening. Let’s >> > add the spotless application to the release note generation step in >> > create-release at least or it will keep happening. The RM does not get a >> > chance to intervene. The script uses the RM credentials to commit >> > immediately after generating the files. >> > >> > > On Jun 2, 2022, at 5:31 AM, 张铎 wrote: >> > > >> > > Oh, I think we should include HBASE-27023, it fixes the license issue >> > after >> > > we apply the spotless formatter where it will add the license header >> > > automatically. >> > > >> > > And also, it seems that the generated RELEASENOTE.md will introduce >> some >> > > lines ending with whitespace, then it will cause pre commit build >> > failure. >> > > >> > > I think we should run a spotless:apply before committing the files in >> the >> > > release scripts, and maybe we should also add spotless:check in the >> mvn >> > > verify stage so it will also fail the mvn install command, which will >> let >> > > developers pay more attention on it. >> > > >> > > Let me open an issue to land these changes. >> > > >> > > 张铎(Duo Zhang) 于2022年6月2日周四 11:14写道： >> > > >> > >> OK, got it. Thanks for the clarification~ >> > >> >> > >> Andrew Purtell 于2022年6月2日周四 11:12写道： >> > >> >> > >>> I don’t think a flaky test is cause to fail the release. So these >> all >> > >>> have a fix version of 2.5.1. I mentioned them so people could be >> aware >> > of >> > >>> these known issue when evaluating their own findings. Hope that >> helps. >> > >>> >> > > On Jun 1, 2022, at 8:11 PM, 张铎 wrote: >> > > >> > > On flakyness, if it is a big problem on promoting the RC, I >> think we >> > >>> can >> > ignore the test first(instead of removing it). >> > >> > Can open a follow on issue to make it stable. >> > >> > Thanks. >> > >> > Andrew Purtell 于2022年6月1日周三 23:25写道： >> > >> > > Makes sense and if nobody has a concern we can do that. >> > > >> > > Also you wanted to support the change to the RSGroup API and put >> back >> > >>> the >> > > unit test (and fix it to not flake), correct, which seems fine to >> me >> > >>> too. >> > > >> > >> On Tue, May 31, 2022 at 10:54 PM 张铎(Duo Zhang) < >> > palomino...@gmail.com >> > >> > >> wrote: >> > >> >> > >> The ReplicationLoadSink change is done in HBASE-26490, this is >> the >> > >>> commit >> > >> >> > >> >> > >> >> > > >> > >>> >> > >> https://github.com/apache/hbase/commit/b5b286d793f00ec8b9ed02f51fd9324e46f29c86 >> > >> >> > >> The constructor is marked as IA.Private so I do not think we >> need to >> > >> restore it back. >> > >> >> > >> Thanks. >> > >> >> > >> Andrew Purtell 于2022年6月1日周三 13:08写道： >> > >> >> > >>> This is not a VOTE. >> > >>> >> > >>> HBase 2.5.0RC0 is ready for testing, other evaluation, and >> > > consideration >> > >> of >> > >>> compatibility concerns. >> > >>> >> > >>> The release notes need to be rebased on the latest 2.4.x >> release, >> > > 2.4.12. >> > >>> Fix >> > >>> versions on relvant JIRAs must be cleaned up first. This is in >> > > progress. >> > >> I >> > >>> also plan to try our new audit tool for matching git history and >> > fix >> > >>> versions. >> > >>> >> > >>> There are known flaky unit tests and minor issues. You can find >> > them >> > >>> by >> > >>> searching for the '2.5.1' fix version, or this URL: >> > >>> >> > >>> https://s.apache.org/hbase-v2.5.1 >> > >>> >> > >>> The compatibility report, based on 2.4.12, can be found here: >> > >>> >> > >>> >> > >>> >> > >>> >> > >> >> > > >> > >>> >> > >> https://dist.apache.org/repos/dist/dev/hbase/2.5.0RC0/api_comp
Re: [DISCUSS] First release candidate for 2.5.0 (RC0) is available for evaluation
+1 to make the change everywhere. Sometimes, there is a need to update the release field after jira is released (in theory, it should not happen). Thanks Huaxiang On Thu, Jun 2, 2022 at 10:56 AM Andrew Purtell wrote: > Even for branch-2.4, we can start placing links into the file, at the top, > leaving the output of the prior process in place below. I think it is fine > to make this change everywhere. Curious what others think. > > On Thu, Jun 2, 2022 at 10:54 AM Andrew Purtell > wrote: > > > I see, that would be totally fine with me if we just do the link instead > > of generating the files every time. > > > > On Thu, Jun 2, 2022 at 9:31 AM 张铎(Duo Zhang) > > wrote: > > > >> Oh, wait a minute. IIRC we have a consensus to use the jira page as > >> release > >> note instead of committing a file to the repo? The problem is that, > >> sometimes we just missed something in CHANGES.md or RELEASENOTES.md, no > >> actually code change, but since we have committed these files to our git > >> repo, we have to sink the RC and generate a new one. > >> > >> IIRC for making the two alpha releases for 3.0.0, I have already started > >> to > >> link the jira page instead of CHANGES.md and RELEASENOTES.md. Maybe we > >> could just remove these steps from the create release scripts? But maybe > >> for branch-2.4 we still need to use these steps... > >> > >> Thanks. > >> > >> Andrew Purtell 于2022年6月2日周四 22:56写道： > >> > >> > I just noticed the release notes issue on the branch last evening. > Let’s > >> > add the spotless application to the release note generation step in > >> > create-release at least or it will keep happening. The RM does not > get a > >> > chance to intervene. The script uses the RM credentials to commit > >> > immediately after generating the files. > >> > > >> > > On Jun 2, 2022, at 5:31 AM, 张铎 wrote: > >> > > > >> > > Oh, I think we should include HBASE-27023, it fixes the license > issue > >> > after > >> > > we apply the spotless formatter where it will add the license header > >> > > automatically. > >> > > > >> > > And also, it seems that the generated RELEASENOTE.md will introduce > >> some > >> > > lines ending with whitespace, then it will cause pre commit build > >> > failure. > >> > > > >> > > I think we should run a spotless:apply before committing the files > in > >> the > >> > > release scripts, and maybe we should also add spotless:check in the > >> mvn > >> > > verify stage so it will also fail the mvn install command, which > will > >> let > >> > > developers pay more attention on it. > >> > > > >> > > Let me open an issue to land these changes. > >> > > > >> > > 张铎(Duo Zhang) 于2022年6月2日周四 11:14写道： > >> > > > >> > >> OK, got it. Thanks for the clarification~ > >> > >> > >> > >> Andrew Purtell 于2022年6月2日周四 11:12写道： > >> > >> > >> > >>> I don’t think a flaky test is cause to fail the release. So these > >> all > >> > >>> have a fix version of 2.5.1. I mentioned them so people could be > >> aware > >> > of > >> > >>> these known issue when evaluating their own findings. Hope that > >> helps. > >> > >>> > >> > > On Jun 1, 2022, at 8:11 PM, 张铎 wrote: > >> > > > >> > > On flakyness, if it is a big problem on promoting the RC, I > >> think we > >> > >>> can > >> > ignore the test first(instead of removing it). > >> > > >> > Can open a follow on issue to make it stable. > >> > > >> > Thanks. > >> > > >> > Andrew Purtell 于2022年6月1日周三 23:25写道： > >> > > >> > > Makes sense and if nobody has a concern we can do that. > >> > > > >> > > Also you wanted to support the change to the RSGroup API and put > >> back > >> > >>> the > >> > > unit test (and fix it to not flake), correct, which seems fine > to > >> me > >> > >>> too. > >> > > > >> > >> On Tue, May 31, 2022 at 10:54 PM 张铎(Duo Zhang) < > >> > palomino...@gmail.com > >> > > >> > >> wrote: > >> > >> > >> > >> The ReplicationLoadSink change is done in HBASE-26490, this is > >> the > >> > >>> commit > >> > >> > >> > >> > >> > >> > >> > > > >> > >>> > >> > > >> > https://github.com/apache/hbase/commit/b5b286d793f00ec8b9ed02f51fd9324e46f29c86 > >> > >> > >> > >> The constructor is marked as IA.Private so I do not think we > >> need to > >> > >> restore it back. > >> > >> > >> > >> Thanks. > >> > >> > >> > >> Andrew Purtell 于2022年6月1日周三 13:08写道： > >> > >> > >> > >>> This is not a VOTE. > >> > >>> > >> > >>> HBase 2.5.0RC0 is ready for testing, other evaluation, and > >> > > consideration > >> > >> of > >> > >>> compatibility concerns. > >> > >>> > >> > >>> The release notes need to be rebased on the latest 2.4.x > >> release, > >> > > 2.4.12. > >> > >>> Fix > >> > >>> versions on relvant JIRAs must be cleaned up first. This is in > >> > > progress. > >> > >> I > >> > >>> also plan to try our new audit tool for matching git history > and > >> > fi
[jira] [Reopened] (HBASE-26962) Add mob info in web UI
[ https://issues.apache.org/jira/browse/HBASE-26962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun reopened HBASE-26962: -- The commit caused branch-2 build failure. Can you fix the build error and resubmit a patch? Thanks. > Add mob info in web UI > -- > > Key: HBASE-26962 > URL: https://issues.apache.org/jira/browse/HBASE-26962 > Project: HBase > Issue Type: Improvement > Components: UI >Reporter: Xuesen Liang >Assignee: Xuesen Liang >Priority: Minor > Fix For: 2.6.0, 3.0.0-alpha-3 > > > Add mob store info in web UI. -- This message was sent by Atlassian Jira (v8.20.7#820007)
Become a contributor
Hello, I’m a new developer on the HBase team at HubSpot and would like to be added as a contributor. My Jira username is hgromer. Thank you! Hernan
Re: Become a contributor
I've added your user id to the contributor group. Let me know if you have any questions. On Thu, Jun 2, 2022 at 2:23 PM Hernan Gelaf-Romer wrote: > Hello, > > I’m a new developer on the HBase team at HubSpot and would like to be > added as a contributor. My Jira username is hgromer. > > Thank you! > > Hernan > >
[jira] [Resolved] (HBASE-26985) SecureBulkLoadManager will set wrong permission if umask too strict
[ https://issues.apache.org/jira/browse/HBASE-26985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-26985. -- Fix Version/s: 2.6.0 3.0.0-alpha-3 2.4.13 2.5.1 Hadoop Flags: Reviewed Assignee: Zhang Dongsheng Resolution: Fixed > SecureBulkLoadManager will set wrong permission if umask too strict > --- > > Key: HBASE-26985 > URL: https://issues.apache.org/jira/browse/HBASE-26985 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 2.4.11 >Reporter: Zhang Dongsheng >Assignee: Zhang Dongsheng >Priority: Major > Fix For: 2.6.0, 3.0.0-alpha-3, 2.4.13, 2.5.1 > > Attachments: HBASE-26985.patch > > > SecureBulkLoadManager will create baseStagingDir if not exist. start method > use > fs.mkdirs(baseStagingDir, PERM_HIDDEN); to create directory with permission > -rwx–x–x.BUT if umask is too strict such as 077 ,this directory will create > with 0700 so it too strict for GROUP and OTHER user to own execute permission -- This message was sent by Atlassian Jira (v8.20.7#820007)
