Re: [VOTE] HBase 2.4.14 release candidate (RC1) is available

2022-08-28 Thread Huaxiang Sun
With five (5) binding +1 votes, and two (2) nonbinding +1 vote, and no 0 or
-1 votes, this vote passes.


Thanks all for the vote.


Huaxiang

On Sat, Aug 27, 2022 at 9:55 AM Jan Hentschel
 wrote:

> +1 (binding)
>
> * Signature: ok
> * Checksum : ok
> * Rat check (1.8.0_202-ea): ok
>  - mvn clean apache-rat:check
> * Built from source (1.8.0_202-ea): ok
>  - mvn clean install  -DskipTests
> * Unit tests pass (1.8.0_202-ea): ok
>  - mvn package -P runSmallTests
> -Dsurefire.rerunFailingTestsCount=3
>
> From: Huaxiang Sun 
> Date: Wednesday, August 24, 2022 at 5:59 PM
> To: hbase-dev 
> Subject: [VOTE] HBase 2.4.14 release candidate (RC1) is available
> [CAUTION] The sender of this email is from outside our organization.
> Please DO NOT CLICK any links, download attachments or respond unless you
> recognize the sender and know the content is safe. Please contact IT
> immediately in case you find it suspicious.
>
> Please vote on this Apache hbase release candidate,
>
> hbase-2.4.14RC1
>
>
> The VOTE will remain open for at least 72 hours.
>
>
> [ ] +1 Release this package as Apache hbase 2.4.14
>
> [ ] -1 Do not release this package because ...
>
>
> The tag to be voted on is 2.4.14RC1:
>
>
>
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Ftree%2F2.4.14RC1data=05%7C01%7Cjan.hentschel%40ultratendency.com%7Cc0f1c6604c2441bf698208da85e9a4b3%7C8b2d44831cfd4f70b345dec07bd4f22f%7C0%7C0%7C637969535780563549%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=WXQ9FpS7wTYbTM%2B4qzjw7IFLTAjH51gMX%2BTDerymYFM%3Dreserved=0
>
>
> This tag currently points to git reference
>
>
>   2e7d75a89271a7479b2f668c4db7a241be3f
>
>
> The release files, including signatures, digests, as well as CHANGES.md
>
> and RELEASENOTES.md included in this RC can be found at:
>
>
>
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fhbase%2F2.4.14RC1%2Fdata=05%7C01%7Cjan.hentschel%40ultratendency.com%7Cc0f1c6604c2441bf698208da85e9a4b3%7C8b2d44831cfd4f70b345dec07bd4f22f%7C0%7C0%7C637969535780563549%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=2LagAeb%2FCv0U2yktrTPFM5yNQOdaTJBHAoreUkvY7Uw%3Dreserved=0
>
>
> Maven artifacts are available in a staging repository at:
>
>
>
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapachehbase-1495%2Fdata=05%7C01%7Cjan.hentschel%40ultratendency.com%7Cc0f1c6604c2441bf698208da85e9a4b3%7C8b2d44831cfd4f70b345dec07bd4f22f%7C0%7C0%7C637969535780563549%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=gVKb99TUkHulfnYNIMgnIdllOV9t41%2Ffb5gyaQhQ%2F2U%3Dreserved=0
>
>
> Artifacts were signed with the 0x117C835E key which can be found in:
>
>
>
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdownloads.apache.org%2Fhbase%2FKEYSdata=05%7C01%7Cjan.hentschel%40ultratendency.com%7Cc0f1c6604c2441bf698208da85e9a4b3%7C8b2d44831cfd4f70b345dec07bd4f22f%7C0%7C0%7C637969535780563549%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=HGrGgxPH6vlnHgVPJKIF7kP1eemT2f6aJ1UVaWp84%2Fk%3Dreserved=0
>
>
> To learn more about Apache hbase, please see
>
>
>
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fhbase.apache.org%2Fdata=05%7C01%7Cjan.hentschel%40ultratendency.com%7Cc0f1c6604c2441bf698208da85e9a4b3%7C8b2d44831cfd4f70b345dec07bd4f22f%7C0%7C0%7C637969535780563549%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=R1nky03mcwjy%2FgYVOSl716Kch3PXYtJmhYARLIuAJz4%3Dreserved=0
>
>
> Thanks,
>
> Your HBase Release Manager
>


Re: [VOTE] Release candidate for HBase 2.5.0 (RC1) is available

2022-08-28 Thread Duo Zhang
And on the shell exit hang problem, we have made some progress in
https://github.com/apache/hbase/pull/4737

The thread pool in ConnectionImplementation is not daemon so it will
block the shutdown process, until the core thread timed out itself(the
default timeout is 60 seconds). And we do not close the
ConnectionImplementation instance when exiting the shell.

But adding the shutdown call in the exit function in shell.rb can fix
the problem when typing 'exit', but can not fix the problem when
typing 'quit', and grep the shell code base, I can not find a quit or
similar method, so I'm not sure how do we deal with the 'quit'
command...

Thanks.

张铎(Duo Zhang)  于2022年8月28日周日 22:34写道:
>
> The region visualizer problem has been fixed by
> https://github.com/apache/hbase/pull/4736.
>
> Viraj Jasani  于2022年8月28日周日 03:43写道:
> >
> > Seems this one might be rarely overriden, nothing problematic to have this
> > change I think. Changing my vote to +1.
> >
> >
> > On Fri, Aug 26, 2022 at 12:52 PM Viraj Jasani  wrote:
> >
> > > +0
> > >
> > > * Signature: ok
> > > * Checksum : ok
> > > * Rat check (1.8.0_341): ok
> > >  - mvn clean apache-rat:check
> > > * Built from source (1.8.0_341): ok
> > >  - mvn clean install  -DskipTests
> > > * Unit tests pass (1.8.0_341): failed (TestUsersOperationsWithSecureHadoop
> > > has known failure locally)
> > >  - mvn package -P runSmallTests  -Dsurefire.rerunFailingTestsCount=3
> > > * A bit of high load testing locally looks good
> > >
> > > The compat report has few high sev problems reported but not all need to
> > > be taken care of given that majority are affecting deprecated/private 
> > > APIs.
> > > However, there seems one high sev problem that we might want to consider
> > > fixing:
> > >
> > >
> > > org/apache/hadoop/hbase/io/encoding/DataBlockEncoding.createEncoder:(Ljava/lang/String;)Lorg/apache/hadoop/hbase/io/encoding/DataBlockEncoder
> > > Access level has been changed from protected to package-private.
> > >
> > > This was done as part of the recent error-prone findings. Either we can
> > > bring back protected access or, we already have public getter
> > > *getEncoder()*, hence I think perhaps we can make *createEncoder(String
> > > fullyQualifiedClassName)* as IA.Private. Either way is fine.
> > >
> > > Functional testing seems good, thanks Nick.
> > >
> > >
> > > On Wed, Aug 24, 2022 at 2:53 AM Nick Dimiduk  wrote:
> > >
> > >> Please vote on this Apache hbase release candidate,
> > >> hbase-2.5.0RC1
> > >>
> > >> The VOTE will remain open for at least 72 hours.
> > >>
> > >> [ ] +1 Release this package as Apache hbase 2.5.0
> > >> [ ] -1 Do not release this package because ...
> > >>
> > >> The tag to be voted on is 2.5.0RC1:
> > >>
> > >>   https://github.com/apache/hbase/tree/2.5.0RC1
> > >>
> > >> This tag currently points to git reference
> > >>
> > >>   2ecd8bd6d615ca49bfb329b3c0c126c80846d4ab
> > >>
> > >> The release files, including signatures, digests, as well as CHANGES.md
> > >> and RELEASENOTES.md included in this RC can be found at:
> > >>
> > >>   https://dist.apache.org/repos/dist/dev/hbase/2.5.0RC1/
> > >>
> > >> Maven artifacts are available in a staging repository at:
> > >>
> > >>   https://repository.apache.org/content/repositories/orgapachehbase-1494/
> > >>
> > >> Artifacts were signed with the 0x18567F39 key which can be found in:
> > >>
> > >>   https://downloads.apache.org/hbase/KEYS
> > >>
> > >> To learn more about Apache hbase, please see
> > >>
> > >>   http://hbase.apache.org/
> > >>
> > >> Thanks,
> > >> Your HBase Release Manager
> > >>
> > >


[jira] [Created] (HBASE-27341) when “hbase.regionserver.logroll.period” is set to a negative number, Log cannot run normally

2022-08-28 Thread Jingxuan Fu (Jira)
Jingxuan Fu created HBASE-27341:
---

 Summary: when “hbase.regionserver.logroll.period” is set to a 
negative number, Log cannot run normally
 Key: HBASE-27341
 URL: https://issues.apache.org/jira/browse/HBASE-27341
 Project: HBase
  Issue Type: Bug
Reporter: Jingxuan Fu
Assignee: Jingxuan Fu


In hbase- default.xml

    hbase.regionserver.logroll.period
    360
    Period at which we will roll the commit log regardless
    of how many edits it has.
  

Taking hbase.regionserver.logroll.period set to -1 in hbase-site.xml as an 
example, it is normal to start hbase.

However, {*}there are a large number of repeated wal rolling operation records 
in the log file{*}.

 
{code:java}
2022-08-06 15:39:37,172 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
wal.AbstractFSWAL: Rolled WAL 
/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577156
 with entries=0, filesize=83 B; new WAL 
/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577167
2022-08-06 15:39:37,172 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
wal.AbstractFSWAL: Archiving 
file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577156
 to 
file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.1659771577156
2022-08-06 15:39:37,177 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
wal.AbstractFSWAL: Rolled WAL 
/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577160.meta
 with entries=0, filesize=83 B; new WAL 
/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577172.meta
2022-08-06 15:39:37,177 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
wal.AbstractFSWAL: Archiving 
file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577160.meta
 to 
file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577160.meta
2022-08-06 15:39:37,182 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
wal.AbstractFSWAL: Rolled WAL 
/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577167
 with entries=0, filesize=83 B; new WAL 
/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577177
2022-08-06 15:39:37,182 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
wal.AbstractFSWAL: Archiving 
file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577167
 to 
file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.1659771577167
2022-08-06 15:39:37,188 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
wal.AbstractFSWAL: Rolled WAL 
/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577172.meta
 with entries=0, filesize=83 B; new WAL 
/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577182.meta
2022-08-06 15:39:37,188 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
wal.AbstractFSWAL: Archiving 
file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577172.meta
 to 
file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577172.meta
2022-08-06 15:39:37,196 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
wal.AbstractFSWAL: Rolled WAL 
/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577177
 with entries=0, filesize=83 B; new WAL 
/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577188
2022-08-06 15:39:37,197 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
wal.AbstractFSWAL: Archiving 
file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577177
 to 
file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.1659771577177
2022-08-06 15:39:37,201 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
wal.AbstractFSWAL: Rolled WAL 
/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577182.meta
 with entries=0, filesize=83 B; new WAL 
/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577197.meta
2022-08-06 15:39:37,201 INFO  

Re: [VOTE] Release candidate for HBase 2.5.0 (RC1) is available

2022-08-28 Thread Duo Zhang
The region visualizer problem has been fixed by
https://github.com/apache/hbase/pull/4736.

Viraj Jasani  于2022年8月28日周日 03:43写道:
>
> Seems this one might be rarely overriden, nothing problematic to have this
> change I think. Changing my vote to +1.
>
>
> On Fri, Aug 26, 2022 at 12:52 PM Viraj Jasani  wrote:
>
> > +0
> >
> > * Signature: ok
> > * Checksum : ok
> > * Rat check (1.8.0_341): ok
> >  - mvn clean apache-rat:check
> > * Built from source (1.8.0_341): ok
> >  - mvn clean install  -DskipTests
> > * Unit tests pass (1.8.0_341): failed (TestUsersOperationsWithSecureHadoop
> > has known failure locally)
> >  - mvn package -P runSmallTests  -Dsurefire.rerunFailingTestsCount=3
> > * A bit of high load testing locally looks good
> >
> > The compat report has few high sev problems reported but not all need to
> > be taken care of given that majority are affecting deprecated/private APIs.
> > However, there seems one high sev problem that we might want to consider
> > fixing:
> >
> >
> > org/apache/hadoop/hbase/io/encoding/DataBlockEncoding.createEncoder:(Ljava/lang/String;)Lorg/apache/hadoop/hbase/io/encoding/DataBlockEncoder
> > Access level has been changed from protected to package-private.
> >
> > This was done as part of the recent error-prone findings. Either we can
> > bring back protected access or, we already have public getter
> > *getEncoder()*, hence I think perhaps we can make *createEncoder(String
> > fullyQualifiedClassName)* as IA.Private. Either way is fine.
> >
> > Functional testing seems good, thanks Nick.
> >
> >
> > On Wed, Aug 24, 2022 at 2:53 AM Nick Dimiduk  wrote:
> >
> >> Please vote on this Apache hbase release candidate,
> >> hbase-2.5.0RC1
> >>
> >> The VOTE will remain open for at least 72 hours.
> >>
> >> [ ] +1 Release this package as Apache hbase 2.5.0
> >> [ ] -1 Do not release this package because ...
> >>
> >> The tag to be voted on is 2.5.0RC1:
> >>
> >>   https://github.com/apache/hbase/tree/2.5.0RC1
> >>
> >> This tag currently points to git reference
> >>
> >>   2ecd8bd6d615ca49bfb329b3c0c126c80846d4ab
> >>
> >> The release files, including signatures, digests, as well as CHANGES.md
> >> and RELEASENOTES.md included in this RC can be found at:
> >>
> >>   https://dist.apache.org/repos/dist/dev/hbase/2.5.0RC1/
> >>
> >> Maven artifacts are available in a staging repository at:
> >>
> >>   https://repository.apache.org/content/repositories/orgapachehbase-1494/
> >>
> >> Artifacts were signed with the 0x18567F39 key which can be found in:
> >>
> >>   https://downloads.apache.org/hbase/KEYS
> >>
> >> To learn more about Apache hbase, please see
> >>
> >>   http://hbase.apache.org/
> >>
> >> Thanks,
> >> Your HBase Release Manager
> >>
> >