And on the shell exit hang problem, we have made some progress in https://github.com/apache/hbase/pull/4737
The thread pool in ConnectionImplementation is not daemon so it will block the shutdown process, until the core thread timed out itself(the default timeout is 60 seconds). And we do not close the ConnectionImplementation instance when exiting the shell. But adding the shutdown call in the exit function in shell.rb can fix the problem when typing 'exit', but can not fix the problem when typing 'quit', and grep the shell code base, I can not find a quit or similar method, so I'm not sure how do we deal with the 'quit' command... Thanks. 张铎(Duo Zhang) <palomino...@gmail.com> 于2022年8月28日周日 22:34写道： > > The region visualizer problem has been fixed by > https://github.com/apache/hbase/pull/4736. > > Viraj Jasani <vjas...@apache.org> 于2022年8月28日周日 03:43写道： > > > > Seems this one might be rarely overriden, nothing problematic to have this > > change I think. Changing my vote to +1. > > > > > > On Fri, Aug 26, 2022 at 12:52 PM Viraj Jasani <vjas...@apache.org> wrote: > > > > > +0 > > > > > > * Signature: ok > > > * Checksum : ok > > > * Rat check (1.8.0_341): ok > > > - mvn clean apache-rat:check > > > * Built from source (1.8.0_341): ok > > > - mvn clean install -DskipTests > > > * Unit tests pass (1.8.0_341): failed (TestUsersOperationsWithSecureHadoop > > > has known failure locally) > > > - mvn package -P runSmallTests -Dsurefire.rerunFailingTestsCount=3 > > > * A bit of high load testing locally looks good > > > > > > The compat report has few high sev problems reported but not all need to > > > be taken care of given that majority are affecting deprecated/private > > > APIs. > > > However, there seems one high sev problem that we might want to consider > > > fixing: > > > > > > > > > org/apache/hadoop/hbase/io/encoding/DataBlockEncoding.createEncoder:(Ljava/lang/String;)Lorg/apache/hadoop/hbase/io/encoding/DataBlockEncoder > > > Access level has been changed from protected to package-private. > > > > > > This was done as part of the recent error-prone findings. Either we can > > > bring back protected access or, we already have public getter > > > *getEncoder()*, hence I think perhaps we can make *createEncoder(String > > > fullyQualifiedClassName)* as IA.Private. Either way is fine. > > > > > > Functional testing seems good, thanks Nick. > > > > > > > > > On Wed, Aug 24, 2022 at 2:53 AM Nick Dimiduk <ndimi...@apache.org> wrote: > > > > > >> Please vote on this Apache hbase release candidate, > > >> hbase-2.5.0RC1 > > >> > > >> The VOTE will remain open for at least 72 hours. > > >> > > >> [ ] +1 Release this package as Apache hbase 2.5.0 > > >> [ ] -1 Do not release this package because ... > > >> > > >> The tag to be voted on is 2.5.0RC1: > > >> > > >> https://github.com/apache/hbase/tree/2.5.0RC1 > > >> > > >> This tag currently points to git reference > > >> > > >> 2ecd8bd6d615ca49bfb329b3c0c126c80846d4ab > > >> > > >> The release files, including signatures, digests, as well as CHANGES.md > > >> and RELEASENOTES.md included in this RC can be found at: > > >> > > >> https://dist.apache.org/repos/dist/dev/hbase/2.5.0RC1/ > > >> > > >> Maven artifacts are available in a staging repository at: > > >> > > >> https://repository.apache.org/content/repositories/orgapachehbase-1494/ > > >> > > >> Artifacts were signed with the 0x18567F39 key which can be found in: > > >> > > >> https://downloads.apache.org/hbase/KEYS > > >> > > >> To learn more about Apache hbase, please see > > >> > > >> http://hbase.apache.org/ > > >> > > >> Thanks, > > >> Your HBase Release Manager > > >> > > >
