[jira] [Updated] (HIVE-2702) listPartitionsByFilter only supports non-string partitions

2012-03-02 Thread Aniket Mokashi (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aniket Mokashi updated HIVE-2702:
-

Attachment: HIVE-2702.1.patch

 listPartitionsByFilter only supports non-string partitions
 --

 Key: HIVE-2702
 URL: https://issues.apache.org/jira/browse/HIVE-2702
 Project: Hive
  Issue Type: Bug
Affects Versions: 0.8.1
Reporter: Aniket Mokashi
 Attachments: HIVE-2702.1.patch


 listPartitionsByFilter supports only non-string partitions. This is because 
 its explicitly specified in generateJDOFilterOverPartitions in 
 ExpressionTree.java. 
 //Can only support partitions whose types are string
   if( ! table.getPartitionKeys().get(partitionColumnIndex).
   
 getType().equals(org.apache.hadoop.hive.serde.Constants.STRING_TYPE_NAME) ) {
 throw new MetaException
 (Filtering is supported only on partition keys of type string);
   }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HIVE-2702) listPartitionsByFilter only supports non-string partitions

2012-03-02 Thread Aniket Mokashi (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aniket Mokashi updated HIVE-2702:
-

Status: Patch Available  (was: Open)

 listPartitionsByFilter only supports non-string partitions
 --

 Key: HIVE-2702
 URL: https://issues.apache.org/jira/browse/HIVE-2702
 Project: Hive
  Issue Type: Bug
Affects Versions: 0.8.1
Reporter: Aniket Mokashi
 Attachments: HIVE-2702.1.patch


 listPartitionsByFilter supports only non-string partitions. This is because 
 its explicitly specified in generateJDOFilterOverPartitions in 
 ExpressionTree.java. 
 //Can only support partitions whose types are string
   if( ! table.getPartitionKeys().get(partitionColumnIndex).
   
 getType().equals(org.apache.hadoop.hive.serde.Constants.STRING_TYPE_NAME) ) {
 throw new MetaException
 (Filtering is supported only on partition keys of type string);
   }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




Changing defaults for dynamic partitioning and enforced bucketing?

2012-03-02 Thread Owen O'Malley
All,
  Would it make sense to change the default configuration to set
hive.enforce.bucketing and hive.exec.dynamic.partition to true? I find
that I usually change them and I wonder what other peoples' experience
with them is.

Thoughts?
  Owen


Re: Changing defaults for dynamic partitioning and enforced bucketing?

2012-03-02 Thread Namit Jain
I agree with changing the hive.exec.dynamic.partitions.


I am not sure about enforcing hive.enforcing.bucketing. It can have a
additional
cost, which may or may not be needed. If we change this, we should trust
the metastore
completelely and also change hive.optimize.bucketmapjoin and
hive.optimize.bucketmapjoin.sortedmerge to true.

This may break some legacy applications, but it may completely make sense
for new setups.


Thanks,
-namit






On 3/2/12 8:45 AM, Owen O'Malley omal...@apache.org wrote:

All,
  Would it make sense to change the default configuration to set
hive.enforce.bucketing and hive.exec.dynamic.partition to true? I find
that I usually change them and I wonder what other peoples' experience
with them is.

Thoughts?
  Owen



[jira] [Commented] (HIVE-2833) Fix test failures caused by HIVE-2716

2012-03-02 Thread Namit Jain (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221129#comment-13221129
 ] 

Namit Jain commented on HIVE-2833:
--

Enis/Ashutosh, we can try coming up with the testcase.
But, in the meanwhile, can I upload a patch which reverts this ?
This will unblock us (facebook branch).

 Fix test failures caused by HIVE-2716
 -

 Key: HIVE-2833
 URL: https://issues.apache.org/jira/browse/HIVE-2833
 Project: Hive
  Issue Type: Bug
  Components: Metastore
Reporter: Carl Steinbach
Assignee: Enis Soztutar



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (HIVE-2835) Change default configuration for hive.exec.dynamic.partition

2012-03-02 Thread Owen O'Malley (Created) (JIRA)
Change default configuration for hive.exec.dynamic.partition


 Key: HIVE-2835
 URL: https://issues.apache.org/jira/browse/HIVE-2835
 Project: Hive
  Issue Type: Improvement
Reporter: Owen O'Malley
Assignee: Owen O'Malley


I think we should enable dynamic partitions by default.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HIVE-2833) Fix test failures caused by HIVE-2716

2012-03-02 Thread Kevin Wilfong (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221164#comment-13221164
 ] 

Kevin Wilfong commented on HIVE-2833:
-

The issue is that updateConnectionURL is now being called after the ObjectStore 
is initially constructed.  We use a Metastore Connection URL Hook to generate 
the URL to be used by JDO.  Since, this was being called after the ObjectStore 
was constructed, it was initially trying to connect to a default URL which was 
incorrect.

I'll upload a patch once I come up with a test case.

 Fix test failures caused by HIVE-2716
 -

 Key: HIVE-2833
 URL: https://issues.apache.org/jira/browse/HIVE-2833
 Project: Hive
  Issue Type: Bug
  Components: Metastore
Reporter: Carl Steinbach
Assignee: Enis Soztutar



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Assigned] (HIVE-2833) Fix test failures caused by HIVE-2716

2012-03-02 Thread Kevin Wilfong (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Wilfong reassigned HIVE-2833:
---

Assignee: Kevin Wilfong  (was: Enis Soztutar)

 Fix test failures caused by HIVE-2716
 -

 Key: HIVE-2833
 URL: https://issues.apache.org/jira/browse/HIVE-2833
 Project: Hive
  Issue Type: Bug
  Components: Metastore
Reporter: Carl Steinbach
Assignee: Kevin Wilfong



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




Re: HCatalog-Hive StorageHandler compatibility

2012-03-02 Thread Francis Liu
Hi,

I'm hoping one of the committers can comment on this. This'll help
Hive-Hcatalog interoperability.

-Francis

On 2/28/12 4:32 PM, Francis Liu tof...@apache.org wrote:

Hi,

Hcatalog 0.4 which contains HCATALOG-237 will be built against Hive 0.8.1.
In light of that, there are some HiveStorageHandler interface changes we'd
like checked into that branch (HIVE-2773, HIVE-2768). HIVE-2773
deprecates a
method and thus we have made it backward compatible. This enables us, as a
first step to get HBaseHCatStorageHandler and HBaseStorageHandler to work
on
both platforms.  I'm hoping the community would be fine in getting these
patches in the 0.8.1 branch?

-Francis






[jira] [Updated] (HIVE-2748) Upgrade Hbase and ZK dependcies

2012-03-02 Thread Giridharan Kesavan (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Giridharan Kesavan updated HIVE-2748:
-

Attachment: HIVE-2748.D1431.2.patch

updating the patch so that it can apply cleanly on trunk

 Upgrade Hbase and ZK dependcies
 ---

 Key: HIVE-2748
 URL: https://issues.apache.org/jira/browse/HIVE-2748
 Project: Hive
  Issue Type: Task
Affects Versions: 0.7.0, 0.7.1, 0.8.0, 0.8.1, 0.9.0
Reporter: Ashutosh Chauhan
Assignee: Ashutosh Chauhan
 Attachments: HIVE-2748.D1431.1.patch, HIVE-2748.D1431.2.patch


 Both softwares have moved forward with significant improvements. Lets bump 
 compile time dependency to keep up

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HIVE-2831) TestContribCliDriver.dboutput and TestCliDriver.input45 fail on 0.23

2012-03-02 Thread Phabricator (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-2831:
--

Attachment: HIVE-2831.D2049.1.patch

cwsteinbach requested code review of HIVE-2831 [jira] Mask FsShell output in 
QTestUtil.
Reviewers: JIRA, edwardcapriolo

  HIVE-2831. Mask FsShell output in QTestUtil

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D2049

AFFECTED FILES
  ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java


 TestContribCliDriver.dboutput and TestCliDriver.input45 fail on 0.23
 

 Key: HIVE-2831
 URL: https://issues.apache.org/jira/browse/HIVE-2831
 Project: Hive
  Issue Type: Bug
  Components: Tests
Reporter: Carl Steinbach
Assignee: Carl Steinbach
 Attachments: HIVE-2831.1.patch.txt, HIVE-2831.D2049.1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




Re: HCatalog-Hive StorageHandler compatibility

2012-03-02 Thread Edward Capriolo
Of the handlers that exist
Cassandra outside of tree
Hypertable outside of tree
Mongo github outside of tree

From the way I look at it is if you change the handler interface your
patch should fix the only in hive tree hbase handler. As long as the
tests keep passing I d not see it as an issue. The Hbase handler
changes quite often anyway.

Edward

On Fri, Mar 2, 2012 at 3:42 PM, Francis Liu tof...@apache.org wrote:
 Hi,

 I'm hoping one of the committers can comment on this. This'll help
 Hive-Hcatalog interoperability.

 -Francis

 On 2/28/12 4:32 PM, Francis Liu tof...@apache.org wrote:

Hi,

Hcatalog 0.4 which contains HCATALOG-237 will be built against Hive 0.8.1.
In light of that, there are some HiveStorageHandler interface changes we'd
like checked into that branch (HIVE-2773, HIVE-2768). HIVE-2773
deprecates a
method and thus we have made it backward compatible. This enables us, as a
first step to get HBaseHCatStorageHandler and HBaseStorageHandler to work
on
both platforms.  I'm hoping the community would be fine in getting these
patches in the 0.8.1 branch?

-Francis






[jira] [Updated] (HIVE-2831) TestContribCliDriver.dboutput and TestCliDriver.input45 fail on 0.23

2012-03-02 Thread Carl Steinbach (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Steinbach updated HIVE-2831:
-

Attachment: HIVE-2831.D2049.1.patch

 TestContribCliDriver.dboutput and TestCliDriver.input45 fail on 0.23
 

 Key: HIVE-2831
 URL: https://issues.apache.org/jira/browse/HIVE-2831
 Project: Hive
  Issue Type: Bug
  Components: Tests
Reporter: Carl Steinbach
Assignee: Carl Steinbach
 Attachments: HIVE-2831.1.patch.txt, HIVE-2831.D2049.1.patch, 
 HIVE-2831.D2049.1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HIVE-2716) Move retry logic in HiveMetaStore to a separe class

2012-03-02 Thread Phabricator (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-2716:
--

Attachment: HIVE-2716.D2055.1.patch

kevinwilfong requested code review of HIVE-2716 [jira] Move retry logic in 
HiveMetaStore to a separe class.
Reviewers: JIRA

  This fixes the issue where the implementation of RawStore was being 
initialized in the metastore before the JDOConnectionURLHook was being called.  
I moved some code around so that the RawStore implementation is initialized in 
the RetryRawStore initialization after the hook is called.  In addition, the 
URL now needs to be updated in the thread local configuration instead of the 
non-thread local one, as by the time the hook is now being called, the thread 
local configuration has already been initialized based on the other.

  In HIVE-1219, method retrying for raw store operation are introduced to 
handle jdo operations more robustly. However, the abstraction for the RawStore 
operations can be moved to a separate class implementing RawStore, which should 
clean up the code base for HiveMetaStore.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D2055

AFFECTED FILES
  
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
  
metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreConnectionUrlHook.java
  
metastore/src/test/org/apache/hadoop/hive/metastore/DummyJdoConnectionUrlHook.java
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
  metastore/src/java/org/apache/hadoop/hive/metastore/RetryingRawStore.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/4407/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.


 Move retry logic in HiveMetaStore to a separe class
 ---

 Key: HIVE-2716
 URL: https://issues.apache.org/jira/browse/HIVE-2716
 Project: Hive
  Issue Type: Sub-task
  Components: Metastore
Affects Versions: 0.9.0
Reporter: Enis Soztutar
Assignee: Enis Soztutar
 Fix For: 0.9.0

 Attachments: HIVE-2716.D1227.1.patch, HIVE-2716.D1227.2.patch, 
 HIVE-2716.D1227.3.patch, HIVE-2716.D1227.4.patch, HIVE-2716.D2055.1.patch, 
 HIVE-2716.patch


 In HIVE-1219, method retrying for raw store operation are introduced to 
 handle jdo operations more robustly. However, the abstraction for the 
 RawStore operations can be moved to a separate class implementing RawStore, 
 which should clean up the code base for HiveMetaStore. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HIVE-2716) Move retry logic in HiveMetaStore to a separe class

2012-03-02 Thread Kevin Wilfong (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221324#comment-13221324
 ] 

Kevin Wilfong commented on HIVE-2716:
-

Ignore the Phabricator comment and patch for D2055, that was intended for 
another JIRA.

 Move retry logic in HiveMetaStore to a separe class
 ---

 Key: HIVE-2716
 URL: https://issues.apache.org/jira/browse/HIVE-2716
 Project: Hive
  Issue Type: Sub-task
  Components: Metastore
Affects Versions: 0.9.0
Reporter: Enis Soztutar
Assignee: Enis Soztutar
 Fix For: 0.9.0

 Attachments: HIVE-2716.D1227.1.patch, HIVE-2716.D1227.2.patch, 
 HIVE-2716.D1227.3.patch, HIVE-2716.D1227.4.patch, HIVE-2716.D2055.1.patch, 
 HIVE-2716.patch


 In HIVE-1219, method retrying for raw store operation are introduced to 
 handle jdo operations more robustly. However, the abstraction for the 
 RawStore operations can be moved to a separate class implementing RawStore, 
 which should clean up the code base for HiveMetaStore. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HIVE-2833) Fix test failures caused by HIVE-2716

2012-03-02 Thread Kevin Wilfong (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Wilfong updated HIVE-2833:


Attachment: HIVE-2716.D2055.1.patch

 Fix test failures caused by HIVE-2716
 -

 Key: HIVE-2833
 URL: https://issues.apache.org/jira/browse/HIVE-2833
 Project: Hive
  Issue Type: Bug
  Components: Metastore
Reporter: Carl Steinbach
Assignee: Kevin Wilfong
 Attachments: HIVE-2716.D2055.1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HIVE-2833) Fix test failures caused by HIVE-2716

2012-03-02 Thread Kevin Wilfong (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221326#comment-13221326
 ] 

Kevin Wilfong commented on HIVE-2833:
-

kevinwilfong requested code review of HIVE-2716 [jira] Move retry logic in 
HiveMetaStore to a separe class.
Reviewers: JIRA

This fixes the issue where the implementation of RawStore was being initialized 
in the metastore before the JDOConnectionURLHook was being called. I moved some 
code around so that the RawStore implementation is initialized in the 
RetryRawStore initialization after the hook is called. In addition, the URL now 
needs to be updated in the thread local configuration instead of the non-thread 
local one, as by the time the hook is now being called, the thread local 
configuration has already been initialized based on the other.

In HIVE-1219, method retrying for raw store operation are introduced to handle 
jdo operations more robustly. However, the abstraction for the RawStore 
operations can be moved to a separate class implementing RawStore, which should 
clean up the code base for HiveMetaStore.

TEST PLAN
EMPTY

REVISION DETAIL
https://reviews.facebook.net/D2055

AFFECTED FILES
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreConnectionUrlHook.java
metastore/src/test/org/apache/hadoop/hive/metastore/DummyJdoConnectionUrlHook.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
metastore/src/java/org/apache/hadoop/hive/metastore/RetryingRawStore.java

MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/4407/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

 Fix test failures caused by HIVE-2716
 -

 Key: HIVE-2833
 URL: https://issues.apache.org/jira/browse/HIVE-2833
 Project: Hive
  Issue Type: Bug
  Components: Metastore
Reporter: Carl Steinbach
Assignee: Kevin Wilfong
 Attachments: HIVE-2716.D2055.1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HIVE-2833) Fix test failures caused by HIVE-2716

2012-03-02 Thread Kevin Wilfong (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Wilfong updated HIVE-2833:


Status: Patch Available  (was: Open)

 Fix test failures caused by HIVE-2716
 -

 Key: HIVE-2833
 URL: https://issues.apache.org/jira/browse/HIVE-2833
 Project: Hive
  Issue Type: Bug
  Components: Metastore
Reporter: Carl Steinbach
Assignee: Kevin Wilfong
 Attachments: HIVE-2716.D2055.1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HIVE-2833) Fix test failures caused by HIVE-2716

2012-03-02 Thread Phabricator (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221331#comment-13221331
 ] 

Phabricator commented on HIVE-2833:
---

enis has commented on the revision HIVE-2833 [jira] Fix test failures caused 
by HIVE-2716.

INLINE COMMENTS
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java:1019 
What is class1 is used for? I noticed that you did not change it but just moved 
the method. Shall we remove that parameter.
  
metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreConnectionUrlHook.java:49
 Changing this to DummyJdoConnectionUrlHook.class.getName() will be better for 
refactoring / finding references.
  
metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreConnectionUrlHook.java:53
 same here
  
metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreConnectionUrlHook.java:32
 There is a separate test for the metastorehook in
  contrib/src/test/queries/clientnegative/url_hook.q and
   
contrib/src/java/org/apache/hadoop/hive/contrib/metastore/hooks/TestURLHook.java,
 which tests the meta store hook connection retry mechanism. Shall we also 
migrate that test here, wdyt?
  Please see that patch at https://reviews.facebook.net/D1953
  
metastore/src/test/org/apache/hadoop/hive/metastore/DummyJdoConnectionUrlHook.java:33
 Can you remove this, it is not used.

REVISION DETAIL
  https://reviews.facebook.net/D2055


 Fix test failures caused by HIVE-2716
 -

 Key: HIVE-2833
 URL: https://issues.apache.org/jira/browse/HIVE-2833
 Project: Hive
  Issue Type: Bug
  Components: Metastore
Reporter: Carl Steinbach
Assignee: Kevin Wilfong
 Attachments: HIVE-2716.D2055.1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HIVE-2834) Diff masking it too aggressive in index_bitmap*.q and index_compact*.q tests

2012-03-02 Thread Phabricator (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-2834:
--

Attachment: HIVE-2834.D2061.1.patch

cwsteinbach requested code review of HIVE-2834 [jira] Diff masking it too 
aggressive in index_bitmap*.q and index_compact*.q tests.
Reviewers: JIRA

  HIVE-2834. Diff masking it too aggressive in index_bitmap*.q and 
index_compact*.q tests

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D2061

AFFECTED FILES
  build-common.xml
  data/conf/hive-site.xml
  
metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java
  ql/src/test/queries/clientpositive/index_bitmap.q
  ql/src/test/queries/clientpositive/index_bitmap1.q
  ql/src/test/queries/clientpositive/index_bitmap2.q
  ql/src/test/queries/clientpositive/index_bitmap3.q
  ql/src/test/queries/clientpositive/index_bitmap_auto.q
  ql/src/test/queries/clientpositive/index_bitmap_rc.q
  ql/src/test/queries/clientpositive/index_compact.q
  ql/src/test/queries/clientpositive/index_compact_1.q
  ql/src/test/queries/clientpositive/index_compact_2.q
  ql/src/test/queries/clientpositive/index_compact_3.q
  ql/src/test/queries/clientpositive/virtual_column.q
  ql/src/test/results/clientpositive/index_bitmap.q.out
  ql/src/test/results/clientpositive/index_bitmap1.q.out
  ql/src/test/results/clientpositive/index_bitmap2.q.out
  ql/src/test/results/clientpositive/index_bitmap3.q.out
  ql/src/test/results/clientpositive/index_bitmap_auto.q.out
  ql/src/test/results/clientpositive/index_bitmap_rc.q.out
  ql/src/test/results/clientpositive/index_compact.q.out
  ql/src/test/results/clientpositive/index_compact_1.q.out
  ql/src/test/results/clientpositive/index_compact_2.q.out
  ql/src/test/results/clientpositive/index_compact_3.q.out
  ql/src/test/results/clientpositive/virtual_column.q.out

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/4413/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.


 Diff masking it too aggressive in index_bitmap*.q and index_compact*.q tests
 

 Key: HIVE-2834
 URL: https://issues.apache.org/jira/browse/HIVE-2834
 Project: Hive
  Issue Type: Bug
  Components: Tests
Reporter: Carl Steinbach
Assignee: Carl Steinbach
 Attachments: HIVE-2834.D2061.1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HIVE-2833) Fix test failures caused by HIVE-2716

2012-03-02 Thread Namit Jain (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221435#comment-13221435
 ] 

Namit Jain commented on HIVE-2833:
--

Looks good to me, but I will wait from Ashutosh/Enis before I commit this.
Please let us know if you see any problems with this.

 Fix test failures caused by HIVE-2716
 -

 Key: HIVE-2833
 URL: https://issues.apache.org/jira/browse/HIVE-2833
 Project: Hive
  Issue Type: Bug
  Components: Metastore
Reporter: Carl Steinbach
Assignee: Kevin Wilfong
 Attachments: HIVE-2716.D2055.1.patch, HIVE-2833.D2055.2.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (HIVE-2836) CREATE TABLE LIKE does not copy table type

2012-03-02 Thread Kevin Wilfong (Created) (JIRA)
CREATE TABLE LIKE does not copy table type
--

 Key: HIVE-2836
 URL: https://issues.apache.org/jira/browse/HIVE-2836
 Project: Hive
  Issue Type: Bug
Reporter: Kevin Wilfong
Assignee: Kevin Wilfong


CREATE TABLE t LIKE t2

If t2 is external t will still be managed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HIVE-2833) Fix test failures caused by HIVE-2716

2012-03-02 Thread Ashutosh Chauhan (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221438#comment-13221438
 ] 

Ashutosh Chauhan commented on HIVE-2833:


@Kevin,
Thanks a bunch for digging into it and for the fix.

@Namit,
I will take a look at it over the weekend and will post comments if I have any.

 Fix test failures caused by HIVE-2716
 -

 Key: HIVE-2833
 URL: https://issues.apache.org/jira/browse/HIVE-2833
 Project: Hive
  Issue Type: Bug
  Components: Metastore
Reporter: Carl Steinbach
Assignee: Kevin Wilfong
 Attachments: HIVE-2716.D2055.1.patch, HIVE-2833.D2055.2.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (HIVE-2837) insert into external tables should not be allowed

2012-03-02 Thread Namit Jain (Created) (JIRA)
insert into external tables should not be allowed
-

 Key: HIVE-2837
 URL: https://issues.apache.org/jira/browse/HIVE-2837
 Project: Hive
  Issue Type: Bug
Reporter: Namit Jain
Assignee: Namit Jain


This is a very risky thing to allow. 
Since, the external tables can point to any user location, which can 
potentially corrupt some other tables.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HIVE-2837) insert into external tables should not be allowed

2012-03-02 Thread Edward Capriolo (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221491#comment-13221491
 ] 

Edward Capriolo commented on HIVE-2837:
---

maybe add a read only keyword or table property?

 insert into external tables should not be allowed
 -

 Key: HIVE-2837
 URL: https://issues.apache.org/jira/browse/HIVE-2837
 Project: Hive
  Issue Type: Bug
Reporter: Namit Jain
Assignee: Namit Jain

 This is a very risky thing to allow. 
 Since, the external tables can point to any user location, which can 
 potentially corrupt some other tables.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira