[jira] [Created] (HIVE-10748) Replace StringBuffer with StringBuilder where possible

2015-05-19 Thread Alexander Pivovarov (JIRA)
Alexander Pivovarov created HIVE-10748:
--

 Summary: Replace StringBuffer with StringBuilder where possible
 Key: HIVE-10748
 URL: https://issues.apache.org/jira/browse/HIVE-10748
 Project: Hive
  Issue Type: Improvement
Reporter: Alexander Pivovarov
Assignee: Alexander Pivovarov
Priority: Minor


I found 40 places in Hive where new StringBuffer( is used.

Where possible, it is recommended that StringBuilder be used in preference to 
StringBuffer as it will be faster under most implementations

https://docs.oracle.com/javase/7/docs/api/java/lang/StringBuilder.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-10749) Implement Insert statement for parquet

2015-05-19 Thread Ferdinand Xu (JIRA)
Ferdinand Xu created HIVE-10749:
---

 Summary: Implement Insert statement for parquet
 Key: HIVE-10749
 URL: https://issues.apache.org/jira/browse/HIVE-10749
 Project: Hive
  Issue Type: Sub-task
Reporter: Ferdinand Xu
Assignee: Ferdinand Xu


We need to implement insert statement for parquet format like ORC.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Build failed in Jenkins: HIVE-TRUNK-JAVA8 #71

2015-05-19 Thread hiveqa
See 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/HIVE-TRUNK-JAVA8/71/

--
Started by timer
Building in workspace 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/HIVE-TRUNK-JAVA8/ws/
  git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
  git config remote.origin.url 
  https://git-wip-us.apache.org/repos/asf/hive.git # timeout=10
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/hive.git
  git --version # timeout=10
  git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/hive.git 
  +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
ERROR: Error fetching remote repo 'origin'
Archiving artifacts
Recording test results


[jira] [Created] (HIVE-10766) LLAP: Exception reported while trying to kill a task

2015-05-19 Thread Siddharth Seth (JIRA)
Siddharth Seth created HIVE-10766:
-

 Summary: LLAP: Exception reported while trying to kill a task
 Key: HIVE-10766
 URL: https://issues.apache.org/jira/browse/HIVE-10766
 Project: Hive
  Issue Type: Sub-task
Reporter: Siddharth Seth
Assignee: Prasanth Jayachandran


{code}
2015-05-19 22:23:01,759 
[TezTaskRunner_attempt_143209221_0002_1_02_00_0(container_1_0002_01_13_sseth_2015051913_595b6e19-4404-4d6d-8d3c-84521b26d5f2:2_Reducer
 3_0_0)] ERROR org.apache.hadoop.hive.ql.exec.tez.TezProcessor: 
java.lang.InterruptedException
  at 
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.reportInterruptAfterWait(AbstractQueuedSynchronizer.java:2017)
  at 
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2052)
  at 
org.apache.tez.runtime.InputReadyTracker$InputReadyMonitor.awaitCondition(InputReadyTracker.java:120)
  at 
org.apache.tez.runtime.InputReadyTracker.waitForAllInputsReady(InputReadyTracker.java:90)
  at 
org.apache.tez.runtime.api.impl.TezProcessorContextImpl.waitForAllInputsReady(TezProcessorContextImpl.java:116)
  at 
org.apache.hadoop.hive.ql.exec.tez.ReduceRecordProcessor.init(ReduceRecordProcessor.java:124)
  at 
org.apache.hadoop.hive.ql.exec.tez.TezProcessor.initializeAndRunProcessor(TezProcessor.java:147)
  at org.apache.hadoop.hive.ql.exec.tez.TezProcessor.run(TezProcessor.java:137)
  at 
org.apache.tez.runtime.LogicalIOProcessorRuntimeTask.run(LogicalIOProcessorRuntimeTask.java:346)
  at 
org.apache.tez.runtime.task.TaskRunner2Callable$1.run(TaskRunner2Callable.java:71)
  at 
org.apache.tez.runtime.task.TaskRunner2Callable$1.run(TaskRunner2Callable.java:60)
  at java.security.AccessController.doPrivileged(Native Method)
  at javax.security.auth.Subject.doAs(Subject.java:415)
  at 
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1657)
  at 
org.apache.tez.runtime.task.TaskRunner2Callable.callInternal(TaskRunner2Callable.java:60)
  at 
org.apache.tez.runtime.task.TaskRunner2Callable.callInternal(TaskRunner2Callable.java:35)
  at org.apache.tez.common.CallableWithNdc.call(CallableWithNdc.java:36)
  at java.util.concurrent.FutureTask.run(FutureTask.java:262)
  at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
  at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
  at java.lang.Thread.run(Thread.java:745)
{code}

Couple of other bits.
The abort boolean flag in the ReduceRecordProcessor has thread visibility 
issues. Making it volatile should be sufficient.

What's the expected behaviour from the Hive Processor when it's killed ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 34143: Fix stats annotation

2015-05-19 Thread Ashutosh Chauhan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34143/#review84434
---



ql/src/test/results/clientpositive/spark/union7.q.out
https://reviews.apache.org/r/34143/#comment135695

You can use --SORT_QUERY_RESULT directive to assure fixed ordering.



ql/src/test/results/clientpositive/tez/auto_sortmerge_join_12.q.out
https://reviews.apache.org/r/34143/#comment135746

Seems like cloning bug? Says Map 5, but its really Map 3.



ql/src/test/results/clientpositive/tez/hybridgrace_hashjoin_2.q.out
https://reviews.apache.org/r/34143/#comment135747

GBy followed by gby has double the # of rows. Expected it to go lower.


- Ashutosh Chauhan


On May 14, 2015, 4:50 p.m., pengcheng xiong wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/34143/
 ---
 
 (Updated May 14, 2015, 4:50 p.m.)
 
 
 Review request for hive, Ashutosh Chauhan and John Pullokkaran.
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 This is a umbrella patch for a bunch of issues: HIVE-8769 Physical optimizer 
 : Incorrect CE results in a shuffle join instead of a Map join (PK/FK pattern 
 not detected) HIVE-9392 JoinStatsRule miscalculates join cardinality as 
 incorrect NDV is used due to column names having duplicated fqColumnName 
 HIVE-10107 Union All : Vertex missing stats resulting in OOM and in-efficient 
 plans
 
 
 Diffs
 -
 
   hbase-handler/src/test/results/positive/external_table_ppd.q.out 6d48edb 
   hbase-handler/src/test/results/positive/hbase_custom_key2.q.out c9b5a84 
   hbase-handler/src/test/results/positive/hbase_custom_key3.q.out 76848e0 
   hbase-handler/src/test/results/positive/hbase_ppd_key_range.q.out 6174bfb 
   hbase-handler/src/test/results/positive/hbase_pushdown.q.out 8a979bf 
   hbase-handler/src/test/results/positive/hbase_queries.q.out 7863f69 
   hbase-handler/src/test/results/positive/hbase_timestamp.q.out 3aae7d0 
   hbase-handler/src/test/results/positive/ppd_key_ranges.q.out 5936735 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 
 0de7488 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
  44269f0 
   ql/src/java/org/apache/hadoop/hive/ql/plan/AbstractOperatorDesc.java 
 0a83440 
   ql/src/java/org/apache/hadoop/hive/ql/plan/ColStatistics.java c420190 
   ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java f66279f 
   ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 508d880 
   ql/src/test/results/clientpositive/annotate_stats_filter.q.out e8cd06d 
   ql/src/test/results/clientpositive/annotate_stats_limit.q.out 5f8b6f8 
   ql/src/test/results/clientpositive/annotate_stats_part.q.out 241192b 
   ql/src/test/results/clientpositive/annotate_stats_select.q.out 753ab4e 
   ql/src/test/results/clientpositive/annotate_stats_table.q.out 9bf82ac 
   ql/src/test/results/clientpositive/auto_join30.q.out b068493 
   ql/src/test/results/clientpositive/auto_join31.q.out 1e19dd0 
   ql/src/test/results/clientpositive/auto_join32.q.out bfc8be8 
   ql/src/test/results/clientpositive/auto_join_stats.q.out 9100762 
   ql/src/test/results/clientpositive/auto_join_stats2.q.out ed09875 
   ql/src/test/results/clientpositive/auto_join_without_localtask.q.out 
 ce4ad8a 
   ql/src/test/results/clientpositive/auto_sortmerge_join_1.q.out 383defd 
   ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out e9fb705 
   ql/src/test/results/clientpositive/auto_sortmerge_join_14.q.out 43504d8 
   ql/src/test/results/clientpositive/auto_sortmerge_join_15.q.out afd5518 
   ql/src/test/results/clientpositive/auto_sortmerge_join_2.q.out c089419 
   ql/src/test/results/clientpositive/auto_sortmerge_join_3.q.out 6e443fa 
   ql/src/test/results/clientpositive/auto_sortmerge_join_4.q.out feaea04 
   ql/src/test/results/clientpositive/auto_sortmerge_join_5.q.out f64ecf0 
   ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out f039dda 
   ql/src/test/results/clientpositive/auto_sortmerge_join_7.q.out e89f548 
   ql/src/test/results/clientpositive/auto_sortmerge_join_8.q.out 44c037f 
   ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 65aa3ef 
   ql/src/test/results/clientpositive/binarysortable_1.q.out c4ba7e0 
   ql/src/test/results/clientpositive/bucket_map_join_1.q.out d778203 
   ql/src/test/results/clientpositive/bucket_map_join_2.q.out aef77aa 
   ql/src/test/results/clientpositive/bucketmapjoin1.q.out 72f2a07 
   ql/src/test/results/clientpositive/bucketsortoptimize_insert_2.q.out 
 eec099c 
   ql/src/test/results/clientpositive/bucketsortoptimize_insert_4.q.out 
 1a644a9 
   ql/src/test/results/clientpositive/bucketsortoptimize_insert_5.q.out 
 e4f90e4 
   

[jira] [Created] (HIVE-10767) LLAP: Improve the way task finishable information is processed

2015-05-19 Thread Siddharth Seth (JIRA)
Siddharth Seth created HIVE-10767:
-

 Summary: LLAP: Improve the way task finishable information is 
processed
 Key: HIVE-10767
 URL: https://issues.apache.org/jira/browse/HIVE-10767
 Project: Hive
  Issue Type: Sub-task
Reporter: Siddharth Seth
Assignee: Siddharth Seth






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-10761) Create codahale-based metrics system for Hive

2015-05-19 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-10761:


 Summary: Create codahale-based metrics system for Hive
 Key: HIVE-10761
 URL: https://issues.apache.org/jira/browse/HIVE-10761
 Project: Hive
  Issue Type: New Feature
Reporter: Szehon Ho


There is a current Hive metrics system that hooks up to a JMX reporting, but 
all its measurements, models are custom.

This is to make another metrics system that will be based on Codahale (ie 
yammer, dropwizard), which has the following advantage:

* Well-defined metric model for frequently-needed metrics (ie JVM metrics)
* Well-defined measurements for all metrics (ie max, mean, stddev, mean_rate, 
etc), 
* Built-in reporting frameworks like JMX, Console, Log, JSON webserver

It is used for many projects, including several Apache projects like Oozie.  
Overall, monitoring tools should find it easier to understand these common 
metric, measurement, reporting models.

As part of this change, Hive's JVMPauseMonitor (that was using Hadoop's private 
one) is now hooked into the new metric framework to give pause time counts.

The existing metric subsystem will be kept and can be enabled if backward 
compatibility is desired.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Review Request 34443: HIVE-10723 better logging/etc. for stuck metastore

2015-05-19 Thread Sergey Shelukhin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34443/
---

Review request for hive, Alexander Pivovarov, Sushanth Sowmyan, and Thejas Nair.


Repository: hive-git


Description
---

see jira


Diffs
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java eff4d30 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
e796048 
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java fd61333 
  
metastore/src/java/org/apache/hadoop/hive/metastore/TServerSocketKeepAlive.java 
9ac18dc 
  
metastore/src/java/org/apache/hadoop/hive/metastore/TSetIpAddressProcessor.java 
4a56bfa 
  metastore/src/java/org/apache/hadoop/hive/metastore/TUGIBasedProcessor.java 
ec8d608 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DefaultFetchFormatter.java 37852ef 
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 20d0304 

Diff: https://reviews.apache.org/r/34443/diff/


Testing
---


Thanks,

Sergey Shelukhin



Re: Review Request 34447: HIVE-10761 : Create codahale-based metrics system for Hive

2015-05-19 Thread Szehon Ho

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34447/
---

(Updated May 19, 2015, 11:58 p.m.)


Review request for hive.


Bugs: HIVE-10761
https://issues.apache.org/jira/browse/HIVE-10761


Repository: hive-git


Description
---

See JIRA for the motivation.  Summary: There is an existing metric system that 
uses some custom model and hooked up to JMX reporting, codahale-based metrics 
system will be desirable for standard model and reporting.

This adds a codahale-based metrics system to HiveServer2 and HiveMetastore.  
Metrics implementation is now internally pluggable, and the existing Metrics 
system can be re-enabled by configuration if desired for backward-compatibility.

Following metrics are supported by Metrics system:
1.  JVMPauseMonitor (used to call Hadoop's internal implementation, now forked 
off to integrate with Metrics system)
2.  HMS API calls
3.  Standard JVM metrics (only for new implementation, as its free with 
codahale).

The following metrics reporting are supported by new system (configuration 
exposed)
1.  JMX
2.  CONSOLE
3.  JSON_FILE (periodic file of metrics that gets overwritten).

A goal is to add a webserver that exposes the JSON metrics, but this will defer 
to a later implementation.


Diffs
-

  common/pom.xml a615c1e 
  common/src/java/org/apache/hadoop/hive/common/JvmPauseMonitor.java 
PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java 01c9d1d 
  common/src/java/org/apache/hadoop/hive/common/metrics/MetricsLegacy.java 
PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/metrics/common/Metrics.java 
PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/common/MetricsFactory.java
 PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics.java 
PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/MetricsReporting.java
 PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java eff4d30 
  common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java 
e85d3f8 
  common/src/test/org/apache/hadoop/hive/common/metrics/TestMetricsLegacy.java 
PRE-CREATION 
  
common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestMetrics.java 
PRE-CREATION 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
e796048 
  pom.xml 920f7a5 
  service/src/java/org/apache/hive/service/server/HiveServer2.java 58e8e49 
  shims/0.20S/src/main/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java 
6d8166c 
  shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java 
d349068 
  shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java 
5a6bc44 

Diff: https://reviews.apache.org/r/34447/diff/


Testing
---

New unit test added.  Manually tested.


Thanks,

Szehon Ho



[jira] [Created] (HIVE-10762) LLAP: Kill any fragments running in a daemon when a query completes

2015-05-19 Thread Siddharth Seth (JIRA)
Siddharth Seth created HIVE-10762:
-

 Summary: LLAP: Kill any fragments running in a daemon when a query 
completes
 Key: HIVE-10762
 URL: https://issues.apache.org/jira/browse/HIVE-10762
 Project: Hive
  Issue Type: Sub-task
Reporter: Siddharth Seth
Assignee: Siddharth Seth
 Fix For: llap


A query may complete due to failure or being KILLED. Fragments running in 
daemons should be killed in these scenarios.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-10763) LLAP: Provide current attempt start time for wait queue ordering

2015-05-19 Thread Prasanth Jayachandran (JIRA)
Prasanth Jayachandran created HIVE-10763:


 Summary: LLAP: Provide current attempt start time for wait queue 
ordering
 Key: HIVE-10763
 URL: https://issues.apache.org/jira/browse/HIVE-10763
 Project: Hive
  Issue Type: Sub-task
Affects Versions: llap
Reporter: Prasanth Jayachandran
Assignee: Siddharth Seth


Wait queue uses first attempt start time for ordering. Since different AMs can 
submit requests to llap daemon, if AMs are not clocks are not synchronization 
then this might lead undesired ordering of requests in wait queue. It will be 
good to have current attempt start time so that the difference between first 
attempt start time and current attempt start time can be used for ordering.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] hive pull request: HIVE-10550 Dynamic RDD caching optimization for...

2015-05-19 Thread ChengXiangLi
Github user ChengXiangLi closed the pull request at:

https://github.com/apache/hive/pull/36


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Review Request 34143: Fix stats annotation

2015-05-19 Thread Ashutosh Chauhan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34143/#review84416
---



ql/src/java/org/apache/hadoop/hive/ql/plan/AbstractOperatorDesc.java
https://reviews.apache.org/r/34143/#comment135652

In Utilities.runtimeSerializationKryo::initialValue() can you add 
removeField() for Statistics. That will make sure we are not serializing Stats 
object before sending them to task nodes.



ql/src/test/results/clientpositive/spark/union24.q.out
https://reviews.apache.org/r/34143/#comment135682

File Sink has more 3 times more rows than Select. I was expecting it to be 
same as select.



ql/src/test/results/clientpositive/spark/union25.q.out
https://reviews.apache.org/r/34143/#comment135683

Group by should result in reduction of # of rows. No of rows instead 
doubled.



ql/src/test/results/clientpositive/spark/union25.q.out
https://reviews.apache.org/r/34143/#comment135684

Select operator after select operator. Should be same (or less). Instead 
doubled.



ql/src/test/results/clientpositive/spark/union26.q.out
https://reviews.apache.org/r/34143/#comment135685

join followed by gby. Gby should have lesser # of rows. Instead it 
increased to 5 times.



ql/src/test/results/clientpositive/spark/union27.q.out
https://reviews.apache.org/r/34143/#comment135686

Reduce sink after select. twice # of rows. expected to remain constant.



ql/src/test/results/clientpositive/spark/union30.q.out
https://reviews.apache.org/r/34143/#comment135688

cascade of select operator. With each one increasing # of rows, looks wrong.


- Ashutosh Chauhan


On May 14, 2015, 4:50 p.m., pengcheng xiong wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/34143/
 ---
 
 (Updated May 14, 2015, 4:50 p.m.)
 
 
 Review request for hive, Ashutosh Chauhan and John Pullokkaran.
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 This is a umbrella patch for a bunch of issues: HIVE-8769 Physical optimizer 
 : Incorrect CE results in a shuffle join instead of a Map join (PK/FK pattern 
 not detected) HIVE-9392 JoinStatsRule miscalculates join cardinality as 
 incorrect NDV is used due to column names having duplicated fqColumnName 
 HIVE-10107 Union All : Vertex missing stats resulting in OOM and in-efficient 
 plans
 
 
 Diffs
 -
 
   hbase-handler/src/test/results/positive/external_table_ppd.q.out 6d48edb 
   hbase-handler/src/test/results/positive/hbase_custom_key2.q.out c9b5a84 
   hbase-handler/src/test/results/positive/hbase_custom_key3.q.out 76848e0 
   hbase-handler/src/test/results/positive/hbase_ppd_key_range.q.out 6174bfb 
   hbase-handler/src/test/results/positive/hbase_pushdown.q.out 8a979bf 
   hbase-handler/src/test/results/positive/hbase_queries.q.out 7863f69 
   hbase-handler/src/test/results/positive/hbase_timestamp.q.out 3aae7d0 
   hbase-handler/src/test/results/positive/ppd_key_ranges.q.out 5936735 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 
 0de7488 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
  44269f0 
   ql/src/java/org/apache/hadoop/hive/ql/plan/AbstractOperatorDesc.java 
 0a83440 
   ql/src/java/org/apache/hadoop/hive/ql/plan/ColStatistics.java c420190 
   ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java f66279f 
   ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 508d880 
   ql/src/test/results/clientpositive/annotate_stats_filter.q.out e8cd06d 
   ql/src/test/results/clientpositive/annotate_stats_limit.q.out 5f8b6f8 
   ql/src/test/results/clientpositive/annotate_stats_part.q.out 241192b 
   ql/src/test/results/clientpositive/annotate_stats_select.q.out 753ab4e 
   ql/src/test/results/clientpositive/annotate_stats_table.q.out 9bf82ac 
   ql/src/test/results/clientpositive/auto_join30.q.out b068493 
   ql/src/test/results/clientpositive/auto_join31.q.out 1e19dd0 
   ql/src/test/results/clientpositive/auto_join32.q.out bfc8be8 
   ql/src/test/results/clientpositive/auto_join_stats.q.out 9100762 
   ql/src/test/results/clientpositive/auto_join_stats2.q.out ed09875 
   ql/src/test/results/clientpositive/auto_join_without_localtask.q.out 
 ce4ad8a 
   ql/src/test/results/clientpositive/auto_sortmerge_join_1.q.out 383defd 
   ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out e9fb705 
   ql/src/test/results/clientpositive/auto_sortmerge_join_14.q.out 43504d8 
   ql/src/test/results/clientpositive/auto_sortmerge_join_15.q.out afd5518 
   ql/src/test/results/clientpositive/auto_sortmerge_join_2.q.out c089419 
   ql/src/test/results/clientpositive/auto_sortmerge_join_3.q.out 6e443fa 
   ql/src/test/results/clientpositive/auto_sortmerge_join_4.q.out 

Review Request 34447: HIVE-10761 : Create codahale-based metrics system for Hive

2015-05-19 Thread Szehon Ho

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34447/
---

Review request for hive.


Repository: hive-git


Description
---

See JIRA for the motivation.  Summary: There is an existing metric system that 
uses some custom model and hooked up to JMX reporting, codahale-based metrics 
system will be desirable for standard model and reporting.

This adds a codahale-based metrics system to HiveServer2 and HiveMetastore.  
Metrics implementation is now internally pluggable, and the existing Metrics 
system can be re-enabled by configuration if desired for backward-compatibility.

Following metrics are supported by Metrics system:
1.  JVMPauseMonitor (used to call Hadoop's internal implementation, now forked 
off to integrate with Metrics system)
2.  HMS API calls
3.  Standard JVM metrics (only for new implementation, as its free with 
codahale).

The following metrics reporting are supported by new system (configuration 
exposed)
1.  JMX
2.  CONSOLE
3.  JSON_FILE (periodic file of metrics that gets overwritten).

A goal is to add a webserver that exposes the JSON metrics, but this will defer 
to a later implementation.


Diffs
-

  common/pom.xml a615c1e 
  common/src/java/org/apache/hadoop/hive/common/JvmPauseMonitor.java 
PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java 01c9d1d 
  common/src/java/org/apache/hadoop/hive/common/metrics/MetricsLegacy.java 
PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/metrics/common/Metrics.java 
PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/common/MetricsFactory.java
 PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics.java 
PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/MetricsReporting.java
 PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java eff4d30 
  common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java 
e85d3f8 
  common/src/test/org/apache/hadoop/hive/common/metrics/TestMetricsLegacy.java 
PRE-CREATION 
  
common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestMetrics.java 
PRE-CREATION 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
e796048 
  pom.xml 920f7a5 
  service/src/java/org/apache/hive/service/server/HiveServer2.java 58e8e49 
  shims/0.20S/src/main/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java 
6d8166c 
  shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java 
d349068 
  shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java 
5a6bc44 

Diff: https://reviews.apache.org/r/34447/diff/


Testing
---

New unit test added.  Manually tested.


Thanks,

Szehon Ho



[jira] [Created] (HIVE-10764) LLAP: Wait queue scheduler goes into tight loop

2015-05-19 Thread Prasanth Jayachandran (JIRA)
Prasanth Jayachandran created HIVE-10764:


 Summary: LLAP: Wait queue scheduler goes into tight loop
 Key: HIVE-10764
 URL: https://issues.apache.org/jira/browse/HIVE-10764
 Project: Hive
  Issue Type: Sub-task
Affects Versions: llap
Reporter: Prasanth Jayachandran
Assignee: Prasanth Jayachandran


{code}
if (!task.canFinish() || numSlotsAvailable.get() == 0) {
{code}

this condition makes it to run into tight loop if no slots available and if the 
task is finishable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-10765) LLAP: NPE when calling abort on the TezProcessor

2015-05-19 Thread Siddharth Seth (JIRA)
Siddharth Seth created HIVE-10765:
-

 Summary: LLAP: NPE when calling abort on the TezProcessor
 Key: HIVE-10765
 URL: https://issues.apache.org/jira/browse/HIVE-10765
 Project: Hive
  Issue Type: Sub-task
Reporter: Siddharth Seth


{code}
2015-05-19 19:48:42,827 [Wait-Queue-Scheduler-0(null)] ERROR 
org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService: Wait queue 
scheduler worker exited with failure!
java.lang.NullPointerException
  at 
org.apache.hadoop.hive.ql.exec.tez.TezProcessor.abort(TezProcessor.java:177)
  at 
org.apache.tez.runtime.LogicalIOProcessorRuntimeTask.abortTask(LogicalIOProcessorRuntimeTask.java:698)
  at 
org.apache.tez.runtime.task.TaskRunner2Callable.interruptTask(TaskRunner2Callable.java:118)
  at 
org.apache.tez.runtime.task.TezTaskRunner2.killTask(TezTaskRunner2.java:261)
  at 
org.apache.hadoop.hive.llap.daemon.impl.TaskRunnerCallable.killTask(TaskRunnerCallable.java:240)
  at 
org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService.trySchedule(TaskExecutorService.java:262)
  at 
org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService.access$700(TaskExecutorService.java:64)
  at 
org.apache.hadoop.hive.llap.daemon.impl.TaskExecutorService$WaitQueueWorker.run(TaskExecutorService.java:162)
  at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
  at java.util.concurrent.FutureTask.run(FutureTask.java:262)
  at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
  at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
  at java.lang.Thread.run(Thread.java:745)
{code}

rrProc should be volatile. There likely need to be some checks around it to 
ensure it's setup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Review Request 34455: HIVE-10550 Dynamic RDD caching optimization for HoS.[Spark Branch]

2015-05-19 Thread chengxiang li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34455/
---

Review request for hive, Chao Sun, Jimmy Xiang, and Xuefu Zhang.


Bugs: HIVE-10550
https://issues.apache.org/jira/browse/HIVE-10550


Repository: hive-git


Description
---

see jira description


Diffs
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 43c53fc 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/CacheTran.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/LocalHiveSparkClient.java 
19d3fee 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/MapInput.java 26cfebd 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/MapTran.java 2170243 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/ReduceTran.java e60dfac 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java 
8b15099 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/ShuffleTran.java a774395 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlan.java ee5c78a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java 
3f240f5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkUtilities.java e6c845c 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/LocalSparkJobStatus.java
 5d62596 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java
 8e56263 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkRddCachingResolver.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSkewJoinProcFactory.java
 5990d17 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SplitSparkWorkResolver.java
 fb20080 
  ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java 19aae70 
  ql/src/java/org/apache/hadoop/hive/ql/plan/SparkWork.java bb5dd79 
  spark-client/src/main/java/org/apache/hive/spark/client/JobContext.java 
af6332e 
  spark-client/src/main/java/org/apache/hive/spark/client/JobContextImpl.java 
beed8a3 
  spark-client/src/main/java/org/apache/hive/spark/client/MonitorCallback.java 
e1e899e 
  spark-client/src/main/java/org/apache/hive/spark/client/RemoteDriver.java 
b77c9e8 
  spark-client/src/test/java/org/apache/hive/spark/client/TestSparkClient.java 
d33ad7e 

Diff: https://reviews.apache.org/r/34455/diff/


Testing
---


Thanks,

chengxiang li



[jira] [Created] (HIVE-10750) Fix flaky testCliDriver_encryption_insert_partition_static test

2015-05-19 Thread Swarnim Kulkarni (JIRA)
Swarnim Kulkarni created HIVE-10750:
---

 Summary: Fix flaky 
testCliDriver_encryption_insert_partition_static test
 Key: HIVE-10750
 URL: https://issues.apache.org/jira/browse/HIVE-10750
 Project: Hive
  Issue Type: Bug
  Components: Testing Infrastructure
Reporter: Swarnim Kulkarni
Assignee: Swarnim Kulkarni


Seems like the test 
TestEncryptedHDFSCliDriver.testCliDriver_encryption_insert_partition_static is 
flaky. We should look into what is causing the flakiness and look into it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-10751) Hive View Specification Needs Update

2015-05-19 Thread Tim Gattone (JIRA)
Tim Gattone created HIVE-10751:
--

 Summary: Hive View Specification Needs Update
 Key: HIVE-10751
 URL: https://issues.apache.org/jira/browse/HIVE-10751
 Project: Hive
  Issue Type: Task
  Components: Documentation
Affects Versions: 0.13.1, 0.13.0, 0.12.0, 0.11.0, 0.10.0
Reporter: Tim Gattone
Priority: Trivial


On this page: 
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-Create/Drop/AlterView
 
There is no mention in the spec of the optional [db_name] to qualify the View 
with, but it is mentioned with CREATE TABLE.
 
Isn’t this an oversight?  My understanding is that we can qualify the CREATE 
VIEW statement with the database such as CREATE VIEW jrnl.sbb_base_v
 
The reason I ask is another vendor is questioning this syntax.
 
CREATE VIEW [IF NOT EXISTS] view_name [(column_name [COMMENT column_comment], 
...) ]
  [COMMENT view_comment]
  [TBLPROPERTIES (property_name = property_value, ...)]
  AS SELECT ...;

=

Email response from Hortonworks:

Subject: Hive - Question
 
Good morning Tim, 
 
I have received this email thread from Doug. I have looked into it below are my 
findings. 
 
Yes. We can qualify the CREATE VIEW statement with the database. 
 
hive create view db1.vw3 as select * from default.x1;
OK
Time taken: 0.084 seconds
hive
 
This could be a possible documentation issue or improvement, which can be 
addressed by raising an Apache JIRA. This documentation is maintained by apache 
and HWX contributes to it. Anyone can register and raise Apache JIRA.  
 
Please let me know if you have any questions or concerns.   
 
Thank you,
Sai




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 34183: HIVE-10665 Continue to make udaf_percentile_approx_23.q test more stable

2015-05-19 Thread Swarnim Kulkarni

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34183/#review84311
---

Ship it!


Ship It!

- Swarnim Kulkarni


On May 14, 2015, 12:43 a.m., Alexander Pivovarov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/34183/
 ---
 
 (Updated May 14, 2015, 12:43 a.m.)
 
 
 Review request for hive and Jason Dere.
 
 
 Bugs: HIVE-10665
 https://issues.apache.org/jira/browse/HIVE-10665
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 HIVE-10665 Continue to make udaf_percentile_approx_23.q test more stable
 
 
 Diffs
 -
 
   ql/src/test/queries/clientpositive/udaf_percentile_approx_23.q 
 b345b37251ff2ab440f0505b172c5f6481d8521f 
   ql/src/test/results/clientpositive/udaf_percentile_approx_23.q.out 
 022a884834cb3077b63b98386adbcd879df39fe7 
 
 Diff: https://reviews.apache.org/r/34183/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Alexander Pivovarov
 




[jira] [Created] (HIVE-10755) Rework on HIVE-5193 to enhance the column oriented table acess

2015-05-19 Thread Aihua Xu (JIRA)
Aihua Xu created HIVE-10755:
---

 Summary: Rework on HIVE-5193 to enhance the column oriented table 
acess
 Key: HIVE-10755
 URL: https://issues.apache.org/jira/browse/HIVE-10755
 Project: Hive
  Issue Type: Sub-task
  Components: HCatalog
Affects Versions: 1.2.0
Reporter: Aihua Xu






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-10754) After reverting HIVE-5193, make pig+hCatalog join working

2015-05-19 Thread Aihua Xu (JIRA)
Aihua Xu created HIVE-10754:
---

 Summary: After reverting HIVE-5193, make pig+hCatalog join working 
 Key: HIVE-10754
 URL: https://issues.apache.org/jira/browse/HIVE-10754
 Project: Hive
  Issue Type: Sub-task
  Components: HCatalog
Affects Versions: 1.2.0
Reporter: Aihua Xu
Assignee: Aihua Xu






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 34385: Better null handling by Vectorizer

2015-05-19 Thread Swarnim Kulkarni

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34385/#review84330
---

Ship it!


Ship It!

- Swarnim Kulkarni


On May 19, 2015, 1:01 a.m., Ashutosh Chauhan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/34385/
 ---
 
 (Updated May 19, 2015, 1:01 a.m.)
 
 
 Review request for hive and Gopal V.
 
 
 Bugs: HIVE-10745
 https://issues.apache.org/jira/browse/HIVE-10745
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 Better null handling by Vectorizer
 
 
 Diffs
 -
 
   ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorFactory.java 
 f08321c 
   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 
 48f34a9 
 
 Diff: https://reviews.apache.org/r/34385/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Ashutosh Chauhan
 




Re: Review Request 34385: Better null handling by Vectorizer

2015-05-19 Thread Ashutosh Chauhan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34385/#review84408
---



ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
https://reviews.apache.org/r/34385/#comment135639

This is exactly what has been done. See previous change. Sometimes RB can 
be confusing, in such cases I read patch text file.



ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
https://reviews.apache.org/r/34385/#comment135641

Ok, will update the exception message.


- Ashutosh Chauhan


On May 19, 2015, 9:14 p.m., Ashutosh Chauhan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/34385/
 ---
 
 (Updated May 19, 2015, 9:14 p.m.)
 
 
 Review request for hive and Gopal V.
 
 
 Bugs: HIVE-10745
 https://issues.apache.org/jira/browse/HIVE-10745
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 Better null handling by Vectorizer
 
 
 Diffs
 -
 
   ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorFactory.java 
 f08321c 
   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 
 48f34a9 
 
 Diff: https://reviews.apache.org/r/34385/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Ashutosh Chauhan
 




Re: Review Request 34385: Better null handling by Vectorizer

2015-05-19 Thread Ashutosh Chauhan


 On May 19, 2015, 10 p.m., Hari Sankar Sivarama Subramaniyan wrote:
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java,
   line 1610
  https://reviews.apache.org/r/34385/diff/2/?file=964375#file964375line1610
 
  I see that these jiras have been committed and better to remove these 
  comments.

These comments were part of those commits. They are there because currently 
vectorization is off for them, but in future it can be enabled once the 
underlying problems (as noted  there) are resolved. This patch is not fixing 
those problems, so it makes sense to leave them there.


- Ashutosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34385/#review84391
---


On May 19, 2015, 9:14 p.m., Ashutosh Chauhan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/34385/
 ---
 
 (Updated May 19, 2015, 9:14 p.m.)
 
 
 Review request for hive and Gopal V.
 
 
 Bugs: HIVE-10745
 https://issues.apache.org/jira/browse/HIVE-10745
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 Better null handling by Vectorizer
 
 
 Diffs
 -
 
   ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorFactory.java 
 f08321c 
   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 
 48f34a9 
 
 Diff: https://reviews.apache.org/r/34385/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Ashutosh Chauhan
 




[jira] [Created] (HIVE-10760) Templeton: HCatalog Get Column for Non-existent column returns Server Error (500) rather than Not Found(404)

2015-05-19 Thread Lekha Thota (JIRA)
Lekha Thota created HIVE-10760:
--

 Summary: Templeton: HCatalog Get Column for Non-existent column 
returns Server Error (500) rather than Not Found(404)
 Key: HIVE-10760
 URL: https://issues.apache.org/jira/browse/HIVE-10760
 Project: Hive
  Issue Type: Bug
  Components: HCatalog, Hive, WebHCat
Reporter: Lekha Thota
Assignee: Lekha Thota
Priority: Minor


Apache Jira for HIVE-578



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 34385: Better null handling by Vectorizer

2015-05-19 Thread Ashutosh Chauhan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34385/
---

(Updated May 19, 2015, 9:14 p.m.)


Review request for hive and Gopal V.


Bugs: HIVE-10745
https://issues.apache.org/jira/browse/HIVE-10745


Repository: hive-git


Description
---

Better null handling by Vectorizer


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorFactory.java 
f08321c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 
48f34a9 

Diff: https://reviews.apache.org/r/34385/diff/


Testing
---


Thanks,

Ashutosh Chauhan



Re: Review Request 34385: Better null handling by Vectorizer

2015-05-19 Thread Hari Sankar Sivarama Subramaniyan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34385/#review84410
---

Ship it!


Ship It!

- Hari Sankar Sivarama Subramaniyan


On May 19, 2015, 10:43 p.m., Ashutosh Chauhan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/34385/
 ---
 
 (Updated May 19, 2015, 10:43 p.m.)
 
 
 Review request for hive and Gopal V.
 
 
 Bugs: HIVE-10745
 https://issues.apache.org/jira/browse/HIVE-10745
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 Better null handling by Vectorizer
 
 
 Diffs
 -
 
   ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorFactory.java 
 f08321c 
   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 
 48f34a9 
 
 Diff: https://reviews.apache.org/r/34385/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Ashutosh Chauhan
 




[jira] [Created] (HIVE-10756) LLAP: Misc changes to daemon scheduling

2015-05-19 Thread Siddharth Seth (JIRA)
Siddharth Seth created HIVE-10756:
-

 Summary: LLAP: Misc changes to daemon scheduling
 Key: HIVE-10756
 URL: https://issues.apache.org/jira/browse/HIVE-10756
 Project: Hive
  Issue Type: Sub-task
Reporter: Siddharth Seth
Assignee: Siddharth Seth
 Fix For: llap
 Attachments: HIVE-10756.1.txt

Running the completion callback in a separate thread to avoid potentially 
unnecessary preemptions.
Sending out a kill to the AM only if the task was actually killed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-10757) Explain query plan should have operation name EXPLAIN

2015-05-19 Thread Jimmy Xiang (JIRA)
Jimmy Xiang created HIVE-10757:
--

 Summary: Explain query plan should have operation name EXPLAIN
 Key: HIVE-10757
 URL: https://issues.apache.org/jira/browse/HIVE-10757
 Project: Hive
  Issue Type: Bug
Reporter: Jimmy Xiang
Assignee: Jimmy Xiang
Priority: Trivial


In the plan of an Explain query, the operation name is not set to EXPLAIN. 
Instead, it is set to the operation name of the query itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-10758) LLAP: Modify running / wait queues on on fragment finishable state changes

2015-05-19 Thread Siddharth Seth (JIRA)
Siddharth Seth created HIVE-10758:
-

 Summary: LLAP: Modify running / wait queues on on fragment 
finishable state changes 
 Key: HIVE-10758
 URL: https://issues.apache.org/jira/browse/HIVE-10758
 Project: Hive
  Issue Type: Sub-task
Reporter: Siddharth Seth
Assignee: Siddharth Seth
 Fix For: llap






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-10759) LLAP: Add aging to wait queue tasks

2015-05-19 Thread Prasanth Jayachandran (JIRA)
Prasanth Jayachandran created HIVE-10759:


 Summary: LLAP: Add aging to wait queue tasks
 Key: HIVE-10759
 URL: https://issues.apache.org/jira/browse/HIVE-10759
 Project: Hive
  Issue Type: Sub-task
Affects Versions: llap
Reporter: Prasanth Jayachandran
Assignee: Prasanth Jayachandran


Wait queue priority does not increase the priority (aging) of pre-empted tasks 
making them starve in concurrent tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 34385: Better null handling by Vectorizer

2015-05-19 Thread Hari Sankar Sivarama Subramaniyan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34385/#review84391
---



ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
https://reviews.apache.org/r/34385/#comment135616

I see that these jiras have been committed and better to remove these 
comments.



ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
https://reviews.apache.org/r/34385/#comment135622

This is dead code, but I think removing this idea alltogether will disable 
vectorization when there is a cast of a constant to boolean because the 
VectorExpression returned from this function will be null. I think a better 
alternative would be to make this code live by putting this inside if (child 
instanceof ExprNodeConstantDesc) to enable vectorization when the child has 
already a NULL object. What do you think ?



ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
https://reviews.apache.org/r/34385/#comment135625

Can we have a brief explanation as to why we cannot vectorize Custom UDF in 
the exception message, will help debugging better since there are 2 similar 
messages not too far apart.


Apart from the minor comments above, the changes look good to me.

Thanks
Hari

- Hari Sankar Sivarama Subramaniyan


On May 19, 2015, 9:14 p.m., Ashutosh Chauhan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/34385/
 ---
 
 (Updated May 19, 2015, 9:14 p.m.)
 
 
 Review request for hive and Gopal V.
 
 
 Bugs: HIVE-10745
 https://issues.apache.org/jira/browse/HIVE-10745
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 Better null handling by Vectorizer
 
 
 Diffs
 -
 
   ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorFactory.java 
 f08321c 
   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 
 48f34a9 
 
 Diff: https://reviews.apache.org/r/34385/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Ashutosh Chauhan
 




Re: Review Request 34385: Better null handling by Vectorizer

2015-05-19 Thread Ashutosh Chauhan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34385/
---

(Updated May 19, 2015, 10:43 p.m.)


Review request for hive and Gopal V.


Changes
---

With updated exception message.


Bugs: HIVE-10745
https://issues.apache.org/jira/browse/HIVE-10745


Repository: hive-git


Description
---

Better null handling by Vectorizer


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorFactory.java 
f08321c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 
48f34a9 

Diff: https://reviews.apache.org/r/34385/diff/


Testing
---


Thanks,

Ashutosh Chauhan



[jira] [Created] (HIVE-10752) Revert HIVE-5193

2015-05-19 Thread Aihua Xu (JIRA)
Aihua Xu created HIVE-10752:
---

 Summary: Revert HIVE-5193
 Key: HIVE-10752
 URL: https://issues.apache.org/jira/browse/HIVE-10752
 Project: Hive
  Issue Type: Sub-task
  Components: HCatalog
Affects Versions: 1.2.0
Reporter: Aihua Xu
Assignee: Aihua Xu


Revert HIVE-5193 since it causes pig+hcatalog not working.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-10753) hs2 jdbc url - wrong connection string cause OOM error on beeline/jdbc/odbc client, misleading message

2015-05-19 Thread Hari Sankar Sivarama Subramaniyan (JIRA)
Hari Sankar Sivarama Subramaniyan created HIVE-10753:


 Summary: hs2 jdbc url - wrong connection string cause OOM error on 
beeline/jdbc/odbc client, misleading message
 Key: HIVE-10753
 URL: https://issues.apache.org/jira/browse/HIVE-10753
 Project: Hive
  Issue Type: Bug
  Components: Beeline, JDBC
Reporter: Hari Sankar Sivarama Subramaniyan
Assignee: Hari Sankar Sivarama Subramaniyan


{noformat}
beeline -u 'jdbc:hive2://localhost:10001/default?httpPath=/;transportMode=http' 
-n hdiuser
scan complete in 15ms
Connecting to jdbc:hive2://localhost:10001/default?httpPath=/;transportMode=http

Java heap space
Beeline version 0.14.0.2.2.4.1-1 by Apache Hive
0: jdbc:hive2://localhost:10001/default (closed) ^Chdiuser@headnode0:~$ 

But it works if I use the deprecated param - 

hdiuser@headnode0:~$ beeline -u 
'jdbc:hive2://localhost:10001/default?hive.server2.transport.mode=http;httpPath=/'
 -n hdiuser
scan complete in 12ms
Connecting to 
jdbc:hive2://localhost:10001/default?hive.server2.transport.mode=http;httpPath=/
15/04/28 23:16:46 [main]: WARN jdbc.Utils: * JDBC param deprecation *
15/04/28 23:16:46 [main]: WARN jdbc.Utils: The use of 
hive.server2.transport.mode is deprecated.
15/04/28 23:16:46 [main]: WARN jdbc.Utils: Please use transportMode like so: 
jdbc:hive2://host:port/dbName;transportMode=transport_mode_value
Connected to: Apache Hive (version 0.14.0.2.2.4.1-1)
Driver: Hive JDBC (version 0.14.0.2.2.4.1-1)
Transaction isolation: TRANSACTION_REPEATABLE_READ
Beeline version 0.14.0.2.2.4.1-1 by Apache Hive
0: jdbc:hive2://localhost:10001/default show tables;
+--+--+
| tab_name |
+--+--+
| hivesampletable  |
+--+--+
1 row selected (18.181 seconds)
0: jdbc:hive2://localhost:10001/default ^Chdiuser@headnode0:~$ ^C
{noformat}

The reason for the above message is :
The url is wrong. Correct one:
{code}
beeline -u 'jdbc:hive2://localhost:10001/default;httpPath=/;transportMode=http' 
-n hdiuser
{code}
Note the ; instead of ?. The deprecation msg prints the format as well: 
{code}
Please use transportMode like so: 
jdbc:hive2://host:port/dbName;transportMode=transport_mode_value
{code}





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)