[jira] [Created] (HIVE-19384) Vectorization: IfExprTimestampColumnScalarBase doesn't handle the arg1ColVector.noNulls case correctly

2018-05-01 Thread Matt McCline (JIRA) 
Matt McCline created HIVE-19384:
---

 Summary: Vectorization: IfExprTimestampColumnScalarBase doesn't 
handle the arg1ColVector.noNulls case correctly
 Key: HIVE-19384
 URL: https://issues.apache.org/jira/browse/HIVE-19384
 Project: Hive
  Issue Type: Bug
  Components: Hive
Reporter: Matt McCline
Assignee: Matt McCline


It is missing boilerplate code from HIVE-18622: "Vectorization: IF Statements, 
Comparisons, and more do not handle NULLs correctly" fix.
{noformat}
// Carefully handle NULLs...

outputColVector.noNulls = false;{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HIVE-19383) Add ArrayList$SubList kryo serializer

2018-05-01 Thread Ashutosh Chauhan (JIRA) 
Ashutosh Chauhan created HIVE-19383:
---

 Summary: Add ArrayList$SubList kryo serializer
 Key: HIVE-19383
 URL: https://issues.apache.org/jira/browse/HIVE-19383
 Project: Hive
  Issue Type: Bug
  Components: Query Planning
Reporter: Deepesh Khandelwal
Assignee: Ashutosh Chauhan


Otherwise failure is encountered while trying to deserialize such a plan.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HIVE-19382) Lock acquisition before generating valid transaction list for some operations

2018-05-01 Thread Jesus Camacho Rodriguez (JIRA) 
Jesus Camacho Rodriguez created HIVE-19382:
--

 Summary: Lock acquisition before generating valid transaction list 
for some operations
 Key: HIVE-19382
 URL: https://issues.apache.org/jira/browse/HIVE-19382
 Project: Hive
  Issue Type: Bug
Reporter: Jesus Camacho Rodriguez
Assignee: Jesus Camacho Rodriguez


To ensure correctness, in particular for operations that require exclusive 
({{INSERT OVERWRITE}}) and semishared ({{UPDATE}}/{{DELETE}}) locks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HIVE-19381) Function replication in cloud fail when download resource from AWS

2018-05-01 Thread Daniel Dai (JIRA) 
Daniel Dai created HIVE-19381:
-

 Summary: Function replication in cloud fail when download resource 
from AWS
 Key: HIVE-19381
 URL: https://issues.apache.org/jira/browse/HIVE-19381
 Project: Hive
  Issue Type: Bug
  Components: repl
Reporter: Daniel Dai
Assignee: Daniel Dai
 Fix For: 3.0.0, 3.1.0


Another case replication shall use the config in with clause.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66645: HIVE-19211: New streaming ingest API and support for dynamic partitioning

2018-05-01 Thread Eugene Koifman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66645/#review202231
---


Ship it!




Ship It!

- Eugene Koifman


On May 1, 2018, 2:53 p.m., Prasanth_J wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66645/
> ---
> 
> (Updated May 1, 2018, 2:53 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Eugene Koifman.
> 
> 
> Bugs: HIVE-19211
> https://issues.apache.org/jira/browse/HIVE-19211
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-19211: New streaming ingest API and support for dynamic partitioning
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 5a13726 
>   
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java
>  90dbdac 
>   itests/hive-unit/pom.xml 3ae7f2f 
>   
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java
>  8ee033d 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveClientCache.java 
> PRE-CREATION 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreUtils.java 
> a66c135 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRecordUpdater.java 09f8802 
>   ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 76569d5 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java f6608eb 
>   serde/src/java/org/apache/hadoop/hive/serde2/JsonSerDe.java PRE-CREATION 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
>  8c159e9 
>   streaming/pom.xml b58ec01 
>   streaming/src/java/org/apache/hive/streaming/AbstractRecordWriter.java 
> 25998ae 
>   streaming/src/java/org/apache/hive/streaming/ConnectionError.java 668bffb 
>   streaming/src/java/org/apache/hive/streaming/ConnectionInfo.java 
> PRE-CREATION 
>   streaming/src/java/org/apache/hive/streaming/DelimitedInputWriter.java 
> 898b3f9 
>   streaming/src/java/org/apache/hive/streaming/HeartBeatFailure.java b1f9520 
>   streaming/src/java/org/apache/hive/streaming/HiveEndPoint.java b04e137 
>   streaming/src/java/org/apache/hive/streaming/HiveStreamingConnection.java 
> PRE-CREATION 
>   streaming/src/java/org/apache/hive/streaming/ImpersonationFailed.java 
> 23e17e7 
>   streaming/src/java/org/apache/hive/streaming/InvalidColumn.java 0011b14 
>   streaming/src/java/org/apache/hive/streaming/InvalidPartition.java f1f9804 
>   streaming/src/java/org/apache/hive/streaming/InvalidTable.java ef1c91d 
>   streaming/src/java/org/apache/hive/streaming/InvalidTransactionState.java 
> PRE-CREATION 
>   streaming/src/java/org/apache/hive/streaming/InvalidTrasactionState.java 
> 762f5f8 
>   streaming/src/java/org/apache/hive/streaming/PartitionCreationFailed.java 
> 5f9aca6 
>   streaming/src/java/org/apache/hive/streaming/PartitionHandler.java 
> PRE-CREATION 
>   streaming/src/java/org/apache/hive/streaming/PartitionInfo.java 
> PRE-CREATION 
>   streaming/src/java/org/apache/hive/streaming/QueryFailedException.java 
> ccd3ae0 
>   streaming/src/java/org/apache/hive/streaming/RecordWriter.java dc6d70e 
>   streaming/src/java/org/apache/hive/streaming/SerializationError.java 
> a57ba00 
>   streaming/src/java/org/apache/hive/streaming/StreamingConnection.java 
> 2f760ea 
>   streaming/src/java/org/apache/hive/streaming/StreamingException.java 
> a7f84c1 
>   streaming/src/java/org/apache/hive/streaming/StreamingIOFailure.java 
> 0dfbfa7 
>   
> streaming/src/java/org/apache/hive/streaming/StrictDelimitedInputWriter.java 
> PRE-CREATION 
>   streaming/src/java/org/apache/hive/streaming/StrictJsonWriter.java 0077913 
>   streaming/src/java/org/apache/hive/streaming/StrictRegexWriter.java c0b7324 
>   streaming/src/java/org/apache/hive/streaming/TransactionBatch.java 2b05771 
>   
> streaming/src/java/org/apache/hive/streaming/TransactionBatchUnAvailable.java 
> a8c8cd4 
>   streaming/src/java/org/apache/hive/streaming/TransactionError.java a331b20 
>   streaming/src/test/org/apache/hive/streaming/TestDelimitedInputWriter.java 
> f0843a1 
>   streaming/src/test/org/apache/hive/streaming/TestStreaming.java 0ec3048 
>   
> streaming/src/test/org/apache/hive/streaming/TestStreamingDynamicPartitioning.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66645/diff/12/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Prasanth_J
> 
>

Re: Review Request 66645: HIVE-19211: New streaming ingest API and support for dynamic partitioning

2018-05-01 Thread j . prasanth . j 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66645/
---

(Updated May 1, 2018, 9:53 p.m.)


Review request for hive, Ashutosh Chauhan and Eugene Koifman.


Changes
---

Added abort under lock.


Bugs: HIVE-19211
https://issues.apache.org/jira/browse/HIVE-19211


Repository: hive-git


Description
---

HIVE-19211: New streaming ingest API and support for dynamic partitioning


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 5a13726 
  
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java
 90dbdac 
  itests/hive-unit/pom.xml 3ae7f2f 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java
 8ee033d 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveClientCache.java 
PRE-CREATION 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreUtils.java 
a66c135 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRecordUpdater.java 09f8802 
  ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 76569d5 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java f6608eb 
  serde/src/java/org/apache/hadoop/hive/serde2/JsonSerDe.java PRE-CREATION 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
 8c159e9 
  streaming/pom.xml b58ec01 
  streaming/src/java/org/apache/hive/streaming/AbstractRecordWriter.java 
25998ae 
  streaming/src/java/org/apache/hive/streaming/ConnectionError.java 668bffb 
  streaming/src/java/org/apache/hive/streaming/ConnectionInfo.java PRE-CREATION 
  streaming/src/java/org/apache/hive/streaming/DelimitedInputWriter.java 
898b3f9 
  streaming/src/java/org/apache/hive/streaming/HeartBeatFailure.java b1f9520 
  streaming/src/java/org/apache/hive/streaming/HiveEndPoint.java b04e137 
  streaming/src/java/org/apache/hive/streaming/HiveStreamingConnection.java 
PRE-CREATION 
  streaming/src/java/org/apache/hive/streaming/ImpersonationFailed.java 23e17e7 
  streaming/src/java/org/apache/hive/streaming/InvalidColumn.java 0011b14 
  streaming/src/java/org/apache/hive/streaming/InvalidPartition.java f1f9804 
  streaming/src/java/org/apache/hive/streaming/InvalidTable.java ef1c91d 
  streaming/src/java/org/apache/hive/streaming/InvalidTransactionState.java 
PRE-CREATION 
  streaming/src/java/org/apache/hive/streaming/InvalidTrasactionState.java 
762f5f8 
  streaming/src/java/org/apache/hive/streaming/PartitionCreationFailed.java 
5f9aca6 
  streaming/src/java/org/apache/hive/streaming/PartitionHandler.java 
PRE-CREATION 
  streaming/src/java/org/apache/hive/streaming/PartitionInfo.java PRE-CREATION 
  streaming/src/java/org/apache/hive/streaming/QueryFailedException.java 
ccd3ae0 
  streaming/src/java/org/apache/hive/streaming/RecordWriter.java dc6d70e 
  streaming/src/java/org/apache/hive/streaming/SerializationError.java a57ba00 
  streaming/src/java/org/apache/hive/streaming/StreamingConnection.java 2f760ea 
  streaming/src/java/org/apache/hive/streaming/StreamingException.java a7f84c1 
  streaming/src/java/org/apache/hive/streaming/StreamingIOFailure.java 0dfbfa7 
  streaming/src/java/org/apache/hive/streaming/StrictDelimitedInputWriter.java 
PRE-CREATION 
  streaming/src/java/org/apache/hive/streaming/StrictJsonWriter.java 0077913 
  streaming/src/java/org/apache/hive/streaming/StrictRegexWriter.java c0b7324 
  streaming/src/java/org/apache/hive/streaming/TransactionBatch.java 2b05771 
  streaming/src/java/org/apache/hive/streaming/TransactionBatchUnAvailable.java 
a8c8cd4 
  streaming/src/java/org/apache/hive/streaming/TransactionError.java a331b20 
  streaming/src/test/org/apache/hive/streaming/TestDelimitedInputWriter.java 
f0843a1 
  streaming/src/test/org/apache/hive/streaming/TestStreaming.java 0ec3048 
  
streaming/src/test/org/apache/hive/streaming/TestStreamingDynamicPartitioning.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/66645/diff/12/

Changes: https://reviews.apache.org/r/66645/diff/11-12/


Testing
---


Thanks,

Prasanth_J

Re: Review Request 66805: HIVE-19311 : Partition and bucketing support for “load data” statement

2018-05-01 Thread Deepak Jaiswal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66805/
---

(Updated May 1, 2018, 9:10 p.m.)


Review request for hive, Ashutosh Chauhan, Eugene Koifman, Jesús Camacho 
Rodríguez, Prasanth_J, and Vineet Garg.


Changes
---

accidentally, uploaded wrong patch. Please ignore version 8.


Bugs: HIVE-19311
https://issues.apache.org/jira/browse/HIVE-19311


Repository: hive-git


Description
---

Currently, "load data" statement is very limited. It errors out if any of the 
information is missing such as partitioning info if table is partitioned or 
appropriate names when table is bucketed.
It should be able to launch an insert job to load the data instead.


Diffs (updated)
-

  data/files/load_data_job/bucketing.txt PRE-CREATION 
  data/files/load_data_job/load_data_1_partition.txt PRE-CREATION 
  data/files/load_data_job/partitions/load_data_1_partition.txt PRE-CREATION 
  data/files/load_data_job/partitions/load_data_2_partitions.txt PRE-CREATION 
  data/files/load_data_job/partitions/subdir/load_data_1_partition.txt 
PRE-CREATION 
  data/files/load_data_job/partitions/subdir/load_data_2_partitions.txt 
PRE-CREATION 
  itests/src/test/resources/testconfiguration.properties 2ca7b5f63b 
  ql/src/java/org/apache/hadoop/hive/ql/Context.java 0fedf0e76e 
  ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 94dd63641d 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java abd678bb54 
  ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 
c07991d434 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java fad0e5c24a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java 
2f3b07f4af 
  ql/src/test/org/apache/hadoop/hive/ql/TestTxnLoadData.java ec8c1507ec 
  ql/src/test/queries/clientnegative/load_part_nospec.q 81517991b2 
  ql/src/test/queries/clientnegative/nopart_load.q 966982fd5c 
  ql/src/test/queries/clientpositive/load_data_using_job.q PRE-CREATION 
  ql/src/test/results/clientnegative/load_part_nospec.q.out bebaf92311 
  ql/src/test/results/clientnegative/nopart_load.q.out 881514640c 
  ql/src/test/results/clientpositive/llap/load_data_using_job.q.out 
PRE-CREATION 


Diff: https://reviews.apache.org/r/66805/diff/9/

Changes: https://reviews.apache.org/r/66805/diff/8-9/


Testing
---

Added a unit test.


Thanks,

Deepak Jaiswal

Re: Review Request 66805: HIVE-19311 : Partition and bucketing support for “load data” statement

2018-05-01 Thread j . prasanth . j 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66805/#review202219
---


Ship it!




Ship It!

- Prasanth_J


On May 1, 2018, 9:06 p.m., Deepak Jaiswal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66805/
> ---
> 
> (Updated May 1, 2018, 9:06 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Eugene Koifman, Jesús Camacho 
> Rodríguez, Prasanth_J, and Vineet Garg.
> 
> 
> Bugs: HIVE-19311
> https://issues.apache.org/jira/browse/HIVE-19311
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Currently, "load data" statement is very limited. It errors out if any of the 
> information is missing such as partitioning info if table is partitioned or 
> appropriate names when table is bucketed.
> It should be able to launch an insert job to load the data instead.
> 
> 
> Diffs
> -
> 
>   data/files/load_data_job/bucketing.txt PRE-CREATION 
>   data/files/load_data_job/load_data_1_partition.txt PRE-CREATION 
>   data/files/load_data_job/partitions/load_data_1_partition.txt PRE-CREATION 
>   data/files/load_data_job/partitions/load_data_2_partitions.txt PRE-CREATION 
>   data/files/load_data_job/partitions/subdir/load_data_1_partition.txt 
> PRE-CREATION 
>   data/files/load_data_job/partitions/subdir/load_data_2_partitions.txt 
> PRE-CREATION 
>   itests/src/test/resources/testconfiguration.properties 2ca7b5f63b 
>   ql/src/java/org/apache/hadoop/hive/ql/Context.java 0fedf0e76e 
>   ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 94dd63641d 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java abd678bb54 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 
> c07991d434 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> fad0e5c24a 
>   
> ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java 
> 2f3b07f4af 
>   ql/src/test/org/apache/hadoop/hive/ql/TestTxnLoadData.java ec8c1507ec 
>   ql/src/test/queries/clientnegative/load_part_nospec.q 81517991b2 
>   ql/src/test/queries/clientnegative/nopart_load.q 966982fd5c 
>   ql/src/test/queries/clientpositive/load_data_using_job.q PRE-CREATION 
>   ql/src/test/results/clientnegative/load_part_nospec.q.out bebaf92311 
>   ql/src/test/results/clientnegative/nopart_load.q.out 881514640c 
>   ql/src/test/results/clientpositive/llap/load_data_using_job.q.out 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66805/diff/8/
> 
> 
> Testing
> ---
> 
> Added a unit test.
> 
> 
> Thanks,
> 
> Deepak Jaiswal
> 
>

Re: Review Request 66805: HIVE-19311 : Partition and bucketing support for “load data” statement

2018-05-01 Thread Deepak Jaiswal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66805/
---

(Updated May 1, 2018, 9:06 p.m.)


Review request for hive, Ashutosh Chauhan, Eugene Koifman, Jesús Camacho 
Rodríguez, Prasanth_J, and Vineet Garg.


Changes
---

Implemented the new review comment.


Bugs: HIVE-19311
https://issues.apache.org/jira/browse/HIVE-19311


Repository: hive-git


Description
---

Currently, "load data" statement is very limited. It errors out if any of the 
information is missing such as partitioning info if table is partitioned or 
appropriate names when table is bucketed.
It should be able to launch an insert job to load the data instead.


Diffs (updated)
-

  data/files/load_data_job/bucketing.txt PRE-CREATION 
  data/files/load_data_job/load_data_1_partition.txt PRE-CREATION 
  data/files/load_data_job/partitions/load_data_1_partition.txt PRE-CREATION 
  data/files/load_data_job/partitions/load_data_2_partitions.txt PRE-CREATION 
  data/files/load_data_job/partitions/subdir/load_data_1_partition.txt 
PRE-CREATION 
  data/files/load_data_job/partitions/subdir/load_data_2_partitions.txt 
PRE-CREATION 
  itests/src/test/resources/testconfiguration.properties 2ca7b5f63b 
  ql/src/java/org/apache/hadoop/hive/ql/Context.java 0fedf0e76e 
  ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 94dd63641d 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java abd678bb54 
  ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 
c07991d434 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java fad0e5c24a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java 
2f3b07f4af 
  ql/src/test/org/apache/hadoop/hive/ql/TestTxnLoadData.java ec8c1507ec 
  ql/src/test/queries/clientnegative/load_part_nospec.q 81517991b2 
  ql/src/test/queries/clientnegative/nopart_load.q 966982fd5c 
  ql/src/test/queries/clientpositive/load_data_using_job.q PRE-CREATION 
  ql/src/test/results/clientnegative/load_part_nospec.q.out bebaf92311 
  ql/src/test/results/clientnegative/nopart_load.q.out 881514640c 
  ql/src/test/results/clientpositive/llap/load_data_using_job.q.out 
PRE-CREATION 


Diff: https://reviews.apache.org/r/66805/diff/8/

Changes: https://reviews.apache.org/r/66805/diff/7-8/


Testing
---

Added a unit test.


Thanks,

Deepak Jaiswal

Re: Review Request 66645: HIVE-19211: New streaming ingest API and support for dynamic partitioning

2018-05-01 Thread j . prasanth . j 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66645/
---

(Updated May 1, 2018, 9:01 p.m.)


Review request for hive, Ashutosh Chauhan and Eugene Koifman.


Changes
---

Addressed review comments.


Bugs: HIVE-19211
https://issues.apache.org/jira/browse/HIVE-19211


Repository: hive-git


Description
---

HIVE-19211: New streaming ingest API and support for dynamic partitioning


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 5a13726 
  
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java
 90dbdac 
  itests/hive-unit/pom.xml 3ae7f2f 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java
 8ee033d 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveClientCache.java 
PRE-CREATION 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreUtils.java 
a66c135 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRecordUpdater.java 09f8802 
  ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 76569d5 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java f6608eb 
  serde/src/java/org/apache/hadoop/hive/serde2/JsonSerDe.java PRE-CREATION 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
 8c159e9 
  streaming/pom.xml b58ec01 
  streaming/src/java/org/apache/hive/streaming/AbstractRecordWriter.java 
25998ae 
  streaming/src/java/org/apache/hive/streaming/ConnectionError.java 668bffb 
  streaming/src/java/org/apache/hive/streaming/ConnectionInfo.java PRE-CREATION 
  streaming/src/java/org/apache/hive/streaming/DelimitedInputWriter.java 
898b3f9 
  streaming/src/java/org/apache/hive/streaming/HeartBeatFailure.java b1f9520 
  streaming/src/java/org/apache/hive/streaming/HiveEndPoint.java b04e137 
  streaming/src/java/org/apache/hive/streaming/HiveStreamingConnection.java 
PRE-CREATION 
  streaming/src/java/org/apache/hive/streaming/ImpersonationFailed.java 23e17e7 
  streaming/src/java/org/apache/hive/streaming/InvalidColumn.java 0011b14 
  streaming/src/java/org/apache/hive/streaming/InvalidPartition.java f1f9804 
  streaming/src/java/org/apache/hive/streaming/InvalidTable.java ef1c91d 
  streaming/src/java/org/apache/hive/streaming/InvalidTransactionState.java 
PRE-CREATION 
  streaming/src/java/org/apache/hive/streaming/InvalidTrasactionState.java 
762f5f8 
  streaming/src/java/org/apache/hive/streaming/PartitionCreationFailed.java 
5f9aca6 
  streaming/src/java/org/apache/hive/streaming/PartitionHandler.java 
PRE-CREATION 
  streaming/src/java/org/apache/hive/streaming/PartitionInfo.java PRE-CREATION 
  streaming/src/java/org/apache/hive/streaming/QueryFailedException.java 
ccd3ae0 
  streaming/src/java/org/apache/hive/streaming/RecordWriter.java dc6d70e 
  streaming/src/java/org/apache/hive/streaming/SerializationError.java a57ba00 
  streaming/src/java/org/apache/hive/streaming/StreamingConnection.java 2f760ea 
  streaming/src/java/org/apache/hive/streaming/StreamingException.java a7f84c1 
  streaming/src/java/org/apache/hive/streaming/StreamingIOFailure.java 0dfbfa7 
  streaming/src/java/org/apache/hive/streaming/StrictDelimitedInputWriter.java 
PRE-CREATION 
  streaming/src/java/org/apache/hive/streaming/StrictJsonWriter.java 0077913 
  streaming/src/java/org/apache/hive/streaming/StrictRegexWriter.java c0b7324 
  streaming/src/java/org/apache/hive/streaming/TransactionBatch.java 2b05771 
  streaming/src/java/org/apache/hive/streaming/TransactionBatchUnAvailable.java 
a8c8cd4 
  streaming/src/java/org/apache/hive/streaming/TransactionError.java a331b20 
  streaming/src/test/org/apache/hive/streaming/TestDelimitedInputWriter.java 
f0843a1 
  streaming/src/test/org/apache/hive/streaming/TestStreaming.java 0ec3048 
  
streaming/src/test/org/apache/hive/streaming/TestStreamingDynamicPartitioning.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/66645/diff/11/

Changes: https://reviews.apache.org/r/66645/diff/10-11/


Testing
---


Thanks,

Prasanth_J

Review Request 66890: HIVE-19371: Add table ownerType to HMS thrift API

2018-05-01 Thread Sergio Pena via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66890/
---

Review request for hive, Alexander Kolbasov, Sahil Takiar, and Vihang 
Karajgaonkar.


Bugs: HIVE-19371
https://issues.apache.org/jira/browse/HIVE-19371


Repository: hive-git


Description
---

This is a subtask part of 'HIVE-18762 Support ALTER TABLE SET OWNER command' 
which adds a new ownerType field on the Table object of the Thrift API of HMS.

The only file updated (before generting the thrift code) is:
- hive_metastore.thrift

The new field is added as 'optional' at the end of the 'struct Table' in order 
to be backward compatible with older clients of HMS.
The ownerType filed will be set to a USER as the default value as current 
tables created are using the owner name as the user.


Diffs
-

  standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 
47877034746a1cf81cc6731bedb8a6da9cee5b6d 
  standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 
629889389e29dcbf9802c348f3b73f6c65695f6f 
  standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 
c6fadf8a24a32bb208ae6819f159b9b4d5301a2b 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java
 8dfec980d9e14ad01fda27ad97e2e6a91846f782 
  standalone-metastore/src/gen/thrift/gen-php/metastore/Types.php 
9f6cc0e871754afc4fcdbdfb0907d78a0298634c 
  standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 
69579e2f593d35c4d52ae7c81d5186d0ae3d379a 
  standalone-metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 
d7ebaaf914997371201a123f3fc28fac63464ce3 
  standalone-metastore/src/main/thrift/hive_metastore.thrift 
ccc3c93bcec88b96e524eeb6d47b7c77ccf49d34 


Diff: https://reviews.apache.org/r/66890/diff/1/


Testing
---

Waiting for Hive QA.


Thanks,

Sergio Pena

Re: Review Request 66805: HIVE-19311 : Partition and bucketing support for “load data” statement

2018-05-01 Thread j . prasanth . j 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66805/#review202211
---




ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
Lines 1255 (patched)


Instead of doing instanceof check here, you would get the same behaviour if 
you Override getAllOutputs() methods in LoadSemanticAnalyzer right?


- Prasanth_J


On May 1, 2018, 7:56 p.m., Deepak Jaiswal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66805/
> ---
> 
> (Updated May 1, 2018, 7:56 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Eugene Koifman, Jesús Camacho 
> Rodríguez, Prasanth_J, and Vineet Garg.
> 
> 
> Bugs: HIVE-19311
> https://issues.apache.org/jira/browse/HIVE-19311
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Currently, "load data" statement is very limited. It errors out if any of the 
> information is missing such as partitioning info if table is partitioned or 
> appropriate names when table is bucketed.
> It should be able to launch an insert job to load the data instead.
> 
> 
> Diffs
> -
> 
>   data/files/load_data_job/bucketing.txt PRE-CREATION 
>   data/files/load_data_job/load_data_1_partition.txt PRE-CREATION 
>   data/files/load_data_job/partitions/load_data_1_partition.txt PRE-CREATION 
>   data/files/load_data_job/partitions/load_data_2_partitions.txt PRE-CREATION 
>   data/files/load_data_job/partitions/subdir/load_data_1_partition.txt 
> PRE-CREATION 
>   data/files/load_data_job/partitions/subdir/load_data_2_partitions.txt 
> PRE-CREATION 
>   itests/src/test/resources/testconfiguration.properties 2ca7b5f63b 
>   ql/src/java/org/apache/hadoop/hive/ql/Context.java 0fedf0e76e 
>   ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 94dd63641d 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java abd678bb54 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 
> c07991d434 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> fad0e5c24a 
>   
> ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java 
> 2f3b07f4af 
>   ql/src/test/org/apache/hadoop/hive/ql/TestTxnLoadData.java ec8c1507ec 
>   ql/src/test/queries/clientnegative/load_part_nospec.q 81517991b2 
>   ql/src/test/queries/clientnegative/nopart_load.q 966982fd5c 
>   ql/src/test/queries/clientpositive/load_data_using_job.q PRE-CREATION 
>   ql/src/test/results/clientnegative/load_part_nospec.q.out bebaf92311 
>   ql/src/test/results/clientnegative/nopart_load.q.out 881514640c 
>   ql/src/test/results/clientpositive/llap/load_data_using_job.q.out 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66805/diff/7/
> 
> 
> Testing
> ---
> 
> Added a unit test.
> 
> 
> Thanks,
> 
> Deepak Jaiswal
> 
>

[jira] [Created] (HIVE-19380) Hive Lock Error Too Verbose

2018-05-01 Thread BELUGA BEHR (JIRA) 
BELUGA BEHR created HIVE-19380:
--

 Summary: Hive Lock Error Too Verbose
 Key: HIVE-19380
 URL: https://issues.apache.org/jira/browse/HIVE-19380
 Project: Hive
  Issue Type: Improvement
  Components: HiveServer2, Locking
Affects Versions: 3.0.0, 2.4.0
Reporter: BELUGA BEHR


When a query fails to gain a lock to a table, the following error message 
appears in beeline.  The error message does not need a stack trace and it would 
be helpful to know how long it waiting before it gave up.  It should also state 
exactly which lock it was unable to obtain.

{code:java}
ERROR : FAILED: Error in acquiring locks: Locks on the underlying objects 
cannot be acquired. retry after some time
org.apache.hadoop.hive.ql.lockmgr.LockException: Locks on the underlying 
objects cannot be acquired. retry after some time
at 
org.apache.hadoop.hive.ql.lockmgr.DummyTxnManager.acquireLocks(DummyTxnManager.java:171)
at 
org.apache.hadoop.hive.ql.Driver.acquireLocksAndOpenTxn(Driver.java:1205)
at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1489)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1285)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1280)
at 
org.apache.hive.service.cli.operation.SQLOperation.runQuery(SQLOperation.java:236)
at 
org.apache.hive.service.cli.operation.SQLOperation.access$300(SQLOperation.java:89)
at 
org.apache.hive.service.cli.operation.SQLOperation$3$1.run(SQLOperation.java:301)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:415)
at 
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1920)
at 
org.apache.hive.service.cli.operation.SQLOperation$3.run(SQLOperation.java:314)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
 {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66805: HIVE-19311 : Partition and bucketing support for “load data” statement

2018-05-01 Thread Deepak Jaiswal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66805/
---

(Updated May 1, 2018, 7:56 p.m.)


Review request for hive, Ashutosh Chauhan, Eugene Koifman, Jesús Camacho 
Rodríguez, Prasanth_J, and Vineet Garg.


Changes
---

Implemented Prasanth's review comments.


Bugs: HIVE-19311
https://issues.apache.org/jira/browse/HIVE-19311


Repository: hive-git


Description
---

Currently, "load data" statement is very limited. It errors out if any of the 
information is missing such as partitioning info if table is partitioned or 
appropriate names when table is bucketed.
It should be able to launch an insert job to load the data instead.


Diffs (updated)
-

  data/files/load_data_job/bucketing.txt PRE-CREATION 
  data/files/load_data_job/load_data_1_partition.txt PRE-CREATION 
  data/files/load_data_job/partitions/load_data_1_partition.txt PRE-CREATION 
  data/files/load_data_job/partitions/load_data_2_partitions.txt PRE-CREATION 
  data/files/load_data_job/partitions/subdir/load_data_1_partition.txt 
PRE-CREATION 
  data/files/load_data_job/partitions/subdir/load_data_2_partitions.txt 
PRE-CREATION 
  itests/src/test/resources/testconfiguration.properties 2ca7b5f63b 
  ql/src/java/org/apache/hadoop/hive/ql/Context.java 0fedf0e76e 
  ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 94dd63641d 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java abd678bb54 
  ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 
c07991d434 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java fad0e5c24a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java 
2f3b07f4af 
  ql/src/test/org/apache/hadoop/hive/ql/TestTxnLoadData.java ec8c1507ec 
  ql/src/test/queries/clientnegative/load_part_nospec.q 81517991b2 
  ql/src/test/queries/clientnegative/nopart_load.q 966982fd5c 
  ql/src/test/queries/clientpositive/load_data_using_job.q PRE-CREATION 
  ql/src/test/results/clientnegative/load_part_nospec.q.out bebaf92311 
  ql/src/test/results/clientnegative/nopart_load.q.out 881514640c 
  ql/src/test/results/clientpositive/llap/load_data_using_job.q.out 
PRE-CREATION 


Diff: https://reviews.apache.org/r/66805/diff/7/

Changes: https://reviews.apache.org/r/66805/diff/6-7/


Testing
---

Added a unit test.


Thanks,

Deepak Jaiswal

[jira] [Created] (HIVE-19379) Docs Are Incorrect for "hive.lock.sleep.between.retries"

2018-05-01 Thread BELUGA BEHR (JIRA) 
BELUGA BEHR created HIVE-19379:
--

 Summary: Docs Are Incorrect for "hive.lock.sleep.between.retries"
 Key: HIVE-19379
 URL: https://issues.apache.org/jira/browse/HIVE-19379
 Project: Hive
  Issue Type: Improvement
  Components: Documentation
Affects Versions: 3.0.0, 2.4.0
Reporter: BELUGA BEHR


https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-Locking

{quote}
Default Value: 60
Added In: Hive 0.7.0 with HIVE-1293
The sleep time (in seconds) between various retries.
{quote}

Actually, it's the _sleep time_ (don't specify a unit) and the default value is 
_60s_.  If no unit is specified, it would be 60 milliseconds.

{code:java|title=ZooKeeperHiveLockManager.java}
  public void refresh() {
HiveConf conf = ctx.getConf();
sleepTime = conf.getTimeVar(
HiveConf.ConfVars.HIVE_LOCK_SLEEP_BETWEEN_RETRIES, 
TimeUnit.MILLISECONDS);
numRetriesForLock = conf.getIntVar(HiveConf.ConfVars.HIVE_LOCK_NUMRETRIES);
numRetriesForUnLock = 
conf.getIntVar(HiveConf.ConfVars.HIVE_UNLOCK_NUMRETRIES);
  }
 {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HIVE-19378) "hive.lock.numretries" Is Misleading

2018-05-01 Thread BELUGA BEHR (JIRA) 
BELUGA BEHR created HIVE-19378:
--

 Summary: "hive.lock.numretries" Is Misleading
 Key: HIVE-19378
 URL: https://issues.apache.org/jira/browse/HIVE-19378
 Project: Hive
  Issue Type: Improvement
  Components: HiveServer2
Affects Versions: 3.0.0, 2.4.0
Reporter: BELUGA BEHR


Configuration 'hive.lock.numretries' is confusing.  It's not actually a 'retry' 
count, it's the total number of attempt to try:

 

{code:java|title=ZooKeeperHiveLockManager.java}
do {
  lastException = null;
  tryNum++;
  try {
if (tryNum > 1) {
  Thread.sleep(sleepTime);
  prepareRetry();
}
ret = lockPrimitive(key, mode, keepAlive, parentCreated, 
conflictingLocks);
...
} while (tryNum < numRetriesForLock);
{code}

So, from this code you can see that on the first loop, {{tryNum}} is set to 1, 
in which case, if the configuration num*retries* is set to 1, there will be one 
attempt total.  With a *retry* value of 1, I would assume one initial attempt 
and one additional retry.  Please change to:

{code}
while (tryNum <= numRetriesForLock);
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 66887: HIVE-19336 Disable SMB/Bucketmap join for external tables

2018-05-01 Thread Jason Dere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66887/
---

Review request for hive and Deepak Jaiswal.


Bugs: HIVE-19336
https://issues.apache.org/jira/browse/HIVE-19336


Repository: hive-git


Description
---

Disable SMB/Bucketmap join for external tables by default


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java 
7121bceb22 
  ql/src/test/queries/clientpositive/bucket_map_join_tez2.q 1361e32c1a 
  ql/src/test/queries/clientpositive/tez_smb_1.q ecfb0dcf79 
  ql/src/test/results/clientpositive/llap/bucket_map_join_tez2.q.out fa90ccd556 
  ql/src/test/results/clientpositive/llap/tez_smb_1.q.out faa948627e 


Diff: https://reviews.apache.org/r/66887/diff/1/


Testing
---

qfile tests


Thanks,

Jason Dere

Re: Review Request 66645: HIVE-19211: New streaming ingest API and support for dynamic partitioning

2018-05-01 Thread j . prasanth . j 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66645/#review202207
---




streaming/src/java/org/apache/hive/streaming/HiveStreamingConnection.java
Line 490 (original), 414 (patched)


Won't be required with volatile change.



streaming/src/java/org/apache/hive/streaming/HiveStreamingConnection.java
Lines 442 (patched)


This class was primarily added so that min and max of range can be 
atomically changed. But you had brought up a good point that maxTxn does not 
change which doesn't warrant this class. I will fix it by changing minTxn a 
volatile variable.



streaming/src/test/org/apache/hive/streaming/TestStreaming.java
Lines 589 (patched)


HIVE-19366



itests/hive-unit/pom.xml
Lines 79 (patched)


Parametrized test to support old vs new api.



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRecordUpdater.java
Lines 471 (patched)


HIVE-19206 added automatic memory management which will flush open files 
periodically without actually committing or closing it. Will add more comments 
regd. the same.


- Prasanth_J


On April 30, 2018, 11:10 p.m., Prasanth_J wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66645/
> ---
> 
> (Updated April 30, 2018, 11:10 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Eugene Koifman.
> 
> 
> Bugs: HIVE-19211
> https://issues.apache.org/jira/browse/HIVE-19211
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-19211: New streaming ingest API and support for dynamic partitioning
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6e35653 
>   
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java
>  90dbdac 
>   itests/hive-unit/pom.xml 3ae7f2f 
>   
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java
>  8ee033d 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveClientCache.java 
> PRE-CREATION 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreUtils.java 
> a66c135 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRecordUpdater.java 09f8802 
>   ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 76569d5 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4661881 
>   serde/src/java/org/apache/hadoop/hive/serde2/JsonSerDe.java PRE-CREATION 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
>  8c159e9 
>   streaming/pom.xml b58ec01 
>   streaming/src/java/org/apache/hive/streaming/AbstractRecordWriter.java 
> 25998ae 
>   streaming/src/java/org/apache/hive/streaming/ConnectionError.java 668bffb 
>   streaming/src/java/org/apache/hive/streaming/ConnectionInfo.java 
> PRE-CREATION 
>   streaming/src/java/org/apache/hive/streaming/DelimitedInputWriter.java 
> 898b3f9 
>   streaming/src/java/org/apache/hive/streaming/HeartBeatFailure.java b1f9520 
>   streaming/src/java/org/apache/hive/streaming/HiveEndPoint.java b04e137 
>   streaming/src/java/org/apache/hive/streaming/HiveStreamingConnection.java 
> PRE-CREATION 
>   streaming/src/java/org/apache/hive/streaming/ImpersonationFailed.java 
> 23e17e7 
>   streaming/src/java/org/apache/hive/streaming/InvalidColumn.java 0011b14 
>   streaming/src/java/org/apache/hive/streaming/InvalidPartition.java f1f9804 
>   streaming/src/java/org/apache/hive/streaming/InvalidTable.java ef1c91d 
>   streaming/src/java/org/apache/hive/streaming/InvalidTransactionState.java 
> PRE-CREATION 
>   streaming/src/java/org/apache/hive/streaming/InvalidTrasactionState.java 
> 762f5f8 
>   streaming/src/java/org/apache/hive/streaming/PartitionCreationFailed.java 
> 5f9aca6 
>   streaming/src/java/org/apache/hive/streaming/PartitionHandler.java 
> PRE-CREATION 
>   streaming/src/java/org/apache/hive/streaming/PartitionInfo.java 
> PRE-CREATION 
>   streaming/src/java/org/apache/hive/streaming/QueryFailedException.java 
> ccd3ae0 
>   streaming/src/java/org/apache/hive/streaming/RecordWriter.java dc6d70e 
>   streaming/src/java/org/apache/hive/streaming/SerializationError.java 
> a57ba00 
>   streaming/src/java/org/apache/hive/streaming/StreamingConnection.java 
> 2f760ea 
>   streaming/src/java/org/apache/hive/streaming/StreamingException.java 
> a7f84c1 
>   streaming/src/java/org/apache/hive/streaming/StreamingIOFailure.java 
> 0dfbfa7 
>   
> streaming/src/java/org/apache/hive/streaming/StrictDelimitedInputWriter.j

Re: Review Request 66645: HIVE-19211: New streaming ingest API and support for dynamic partitioning

2018-05-01 Thread Eugene Koifman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66645/#review202201
---




streaming/src/java/org/apache/hive/streaming/HiveStreamingConnection.java
Line 490 (original), 414 (patched)


should these be final?



streaming/src/java/org/apache/hive/streaming/HiveStreamingConnection.java
Lines 442 (patched)


what does this achieve?
you said that this API doesn't support concurrency and 
begin/commit/close/ect have be sequntial.  That means that minTxnId of the 
batch can only change linearly.  So what does atomicReference buy you over 
'volotile' for example?

commitImpl, is not atomic - it calls msClient.commitTxn() and then adjusts 
minTxn.  But a hreartbeat between these 2 will end up heartbeating a committed 
txn...

It seems that maxTxn never changes, and the only thing that needs to be 
updated in the HeartbeatRunnable is the minTxn which needs to be volatile.  

Is there something else that this is trying to solve?



streaming/src/test/org/apache/hive/streaming/TestStreaming.java
Lines 589 (patched)


followup jira?



hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java
Line 442 (original), 442 (patched)


is there a follow up jira for this?



itests/hive-unit/pom.xml
Lines 79 (patched)


what change requires this?



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRecordUpdater.java
Lines 471 (patched)


if you have only 1 txn in a batch, why call flush at all?  (this flush() is 
called when commit() is called) . Won't closign the file do the right thing?


- Eugene Koifman


On April 30, 2018, 4:10 p.m., Prasanth_J wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66645/
> ---
> 
> (Updated April 30, 2018, 4:10 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Eugene Koifman.
> 
> 
> Bugs: HIVE-19211
> https://issues.apache.org/jira/browse/HIVE-19211
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-19211: New streaming ingest API and support for dynamic partitioning
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6e35653 
>   
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java
>  90dbdac 
>   itests/hive-unit/pom.xml 3ae7f2f 
>   
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java
>  8ee033d 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveClientCache.java 
> PRE-CREATION 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreUtils.java 
> a66c135 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRecordUpdater.java 09f8802 
>   ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 76569d5 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4661881 
>   serde/src/java/org/apache/hadoop/hive/serde2/JsonSerDe.java PRE-CREATION 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
>  8c159e9 
>   streaming/pom.xml b58ec01 
>   streaming/src/java/org/apache/hive/streaming/AbstractRecordWriter.java 
> 25998ae 
>   streaming/src/java/org/apache/hive/streaming/ConnectionError.java 668bffb 
>   streaming/src/java/org/apache/hive/streaming/ConnectionInfo.java 
> PRE-CREATION 
>   streaming/src/java/org/apache/hive/streaming/DelimitedInputWriter.java 
> 898b3f9 
>   streaming/src/java/org/apache/hive/streaming/HeartBeatFailure.java b1f9520 
>   streaming/src/java/org/apache/hive/streaming/HiveEndPoint.java b04e137 
>   streaming/src/java/org/apache/hive/streaming/HiveStreamingConnection.java 
> PRE-CREATION 
>   streaming/src/java/org/apache/hive/streaming/ImpersonationFailed.java 
> 23e17e7 
>   streaming/src/java/org/apache/hive/streaming/InvalidColumn.java 0011b14 
>   streaming/src/java/org/apache/hive/streaming/InvalidPartition.java f1f9804 
>   streaming/src/java/org/apache/hive/streaming/InvalidTable.java ef1c91d 
>   streaming/src/java/org/apache/hive/streaming/InvalidTransactionState.java 
> PRE-CREATION 
>   streaming/src/java/org/apache/hive/streaming/InvalidTrasactionState.java 
> 762f5f8 
>   streaming/src/java/org/apache/hive/streaming/PartitionCreationFailed.java 
> 5f9aca6 
>   streaming/src/java/org/apache/hive/streaming/PartitionHandler.java 
> PRE-CREATION 
>   streaming/src/java/org/apache/hive/streaming/PartitionInfo.java 
> PRE-CREATION 
>

Re: Review Request 66805: HIVE-19311 : Partition and bucketing support for “load data” statement

2018-05-01 Thread Deepak Jaiswal 


> On May 1, 2018, 6:23 a.m., Prasanth_J wrote:
> >

Thanks for the review. Working on the review comments.


> On May 1, 2018, 6:23 a.m., Prasanth_J wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java
> > Lines 241 (patched)
> > 
> >
> > Is useSuper required here? I can see why you are doing this. But can 
> > you make this decision based on where tempTable is set in the ctx or not? 
> > If tempTable is set in the ctx then it is rewritten load statement. 
> > Alternatively you could use a separate boolean in ctx to say if load query 
> > is rewritten or not based on which you can construct the if condition.

Makes sense. Will do the changes, thanks.


> On May 1, 2018, 6:23 a.m., Prasanth_J wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java
> > Lines 483 (patched)
> > 
> >
> > Why is this required? Isn't load data "insert" operation type?

Cleanup issue. Will remove it. Thanks for catching it.


> On May 1, 2018, 6:23 a.m., Prasanth_J wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
> > Lines 1254 (patched)
> > 
> >
> > could you add a comment to say why does load require a shallow copy?

Sure.


> On May 1, 2018, 6:23 a.m., Prasanth_J wrote:
> > ql/src/test/queries/clientpositive/load_data_using_job.q
> > Lines 72 (patched)
> > 
> >
> > Could you also add a case for multi-column bucketing?
> > I think Eric also asked the same question, does this handle multi-level 
> > subdirs? IIRC load only recurses to 1 or 2 levels.

I can add multi column bucketing.
Eric was talking about multi column partitioning which creates multi-level 
subdirs. Currently load fails if it sees a subdirs. It is now handled in latest 
patch.


- Deepak


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66805/#review202190
---


On May 1, 2018, 4:50 a.m., Deepak Jaiswal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66805/
> ---
> 
> (Updated May 1, 2018, 4:50 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Eugene Koifman, Jesús Camacho 
> Rodríguez, Prasanth_J, and Vineet Garg.
> 
> 
> Bugs: HIVE-19311
> https://issues.apache.org/jira/browse/HIVE-19311
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Currently, "load data" statement is very limited. It errors out if any of the 
> information is missing such as partitioning info if table is partitioned or 
> appropriate names when table is bucketed.
> It should be able to launch an insert job to load the data instead.
> 
> 
> Diffs
> -
> 
>   data/files/load_data_job/bucketing.txt PRE-CREATION 
>   data/files/load_data_job/load_data_1_partition.txt PRE-CREATION 
>   data/files/load_data_job/partitions/load_data_1_partition.txt PRE-CREATION 
>   data/files/load_data_job/partitions/load_data_2_partitions.txt PRE-CREATION 
>   data/files/load_data_job/partitions/subdir/load_data_1_partition.txt 
> PRE-CREATION 
>   data/files/load_data_job/partitions/subdir/load_data_2_partitions.txt 
> PRE-CREATION 
>   itests/src/test/resources/testconfiguration.properties 2ca7b5f63b 
>   ql/src/java/org/apache/hadoop/hive/ql/Context.java 0fedf0e76e 
>   ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 94dd63641d 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java abd678bb54 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 
> c07991d434 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> fad0e5c24a 
>   
> ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java 
> 2f3b07f4af 
>   ql/src/test/org/apache/hadoop/hive/ql/TestTxnLoadData.java ec8c1507ec 
>   ql/src/test/queries/clientnegative/load_part_nospec.q 81517991b2 
>   ql/src/test/queries/clientnegative/nopart_load.q 966982fd5c 
>   ql/src/test/queries/clientpositive/load_data_using_job.q PRE-CREATION 
>   ql/src/test/results/clientnegative/load_part_nospec.q.out bebaf92311 
>   ql/src/test/results/clientnegative/nopart_load.q.out 881514640c 
>   ql/src/test/results/clientpositive/llap/load_data_using_job.q.out 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66805/diff/6/
> 
> 
> Testing
> ---
> 
> Added a unit test.
> 
> 
> Thanks,
> 
> Deepak Jaiswal
> 
>

[jira] [Created] (HIVE-19377) TestTxnExIm - did not produce a TEST-*.xml file (likely timed out) (batchId=286)

2018-05-01 Thread Eugene Koifman (JIRA) 
Eugene Koifman created HIVE-19377:
-

 Summary: TestTxnExIm - did not produce a TEST-*.xml file (likely 
timed out) (batchId=286)
 Key: HIVE-19377
 URL: https://issues.apache.org/jira/browse/HIVE-19377
 Project: Hive
  Issue Type: Sub-task
Reporter: Eugene Koifman


{{TestTxnExIm - did not produce a TEST-*.xml file (likely timed out) 
(batchId=286)}}

appears routinely in runs.  

{{mvn test -Dtest=TestExIm}} fails locally with 
{noformat}
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test (default-test) on 
project hive-exec: There are test failures.
[ERROR] 
[ERROR] Please refer to 
/Users/ekoifman/IdeaProjects/hive/ql/target/surefire-reports for the individual 
test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, 
[date].dumpstream and [date]-jvmRun[N].dumpstream.
[ERROR] ExecutionException The forked VM terminated without properly saying 
goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd /Users/ekoifman/IdeaProjects/hive/ql && 
/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/bin/java 
-Xmx2048m -jar 
/Users/ekoifman/IdeaProjects/hive/ql/target/surefire/surefirebooter4071469472847953044.jar
 /Users/ekoifman/IdeaProjects/hive/ql/target/surefire 
2018-05-01T10-56-27_610-jvmRun1 surefire8633599521000249236tmp 
surefire_02958205604336140780tmp
[ERROR] Error occurred in starting fork, check output in log
[ERROR] Process Exit Code: 1
[ERROR] Crashed tests:
[ERROR] org.apache.hadoop.hive.ql.TestTxnExIm
[ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: 
ExecutionException The forked VM terminated without properly saying goodbye. VM 
crash or System.exit called?
[ERROR] Command was /bin/sh -c cd /Users/ekoifman/IdeaProjects/hive/ql && 
/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/bin/java 
-Xmx2048m -jar 
/Users/ekoifman/IdeaProjects/hive/ql/target/surefire/surefirebooter4071469472847953044.jar
 /Users/ekoifman/IdeaProjects/hive/ql/target/surefire 
2018-05-01T10-56-27_610-jvmRun1 surefire8633599521000249236tmp 
surefire_02958205604336140780tmp
[ERROR] Error occurred in starting fork, check output in log
[ERROR] Process Exit Code: 1
[ERROR] Crashed tests:
[ERROR] org.apache.hadoop.hive.ql.TestTxnExIm
[ERROR] at 
org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:494)
[ERROR] at 
org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:441)
[ERROR] at 
org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:293)
[ERROR] at 
org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
[ERROR] at 
org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1149)
[ERROR] at 
org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:978)
[ERROR] at 
org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:854)
[ERROR] at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
[ERROR] at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
[ERROR] at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
[ERROR] at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
[ERROR] at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
[ERROR] at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
[ERROR] at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
[ERROR] at 
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
[ERROR] at 
org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)
[ERROR] at 
org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
[ERROR] at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
[ERROR] at org.apache.maven.cli.MavenCli.execute(MavenCli.java:955)
[ERROR] at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:290)
[ERROR] at org.apache.maven.cli.MavenCli.main(MavenCli.java:194)
[ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[ERROR] at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[ERROR] at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[ERROR] at java.lang.reflect.Method.invoke(Method.java:498)
[ERROR] at 
org.codehaus.ple

[jira] [Created] (HIVE-19376) Statistics: switch to 10bit HLL by default for Hive

2018-05-01 Thread Gopal V (JIRA) 
Gopal V created HIVE-19376:
--

 Summary: Statistics: switch to 10bit HLL by default for Hive
 Key: HIVE-19376
 URL: https://issues.apache.org/jira/browse/HIVE-19376
 Project: Hive
  Issue Type: Sub-task
  Components: Statistics
Reporter: Gopal V


This reduces the memory usage for the metastore cache and the size of 
bit-vectors in the DB by 16x.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HIVE-19375) "'transactional'='false' is no longer a valid property and will be ignored:

2018-05-01 Thread Eugene Koifman (JIRA) 
Eugene Koifman created HIVE-19375:
-

 Summary: "'transactional'='false' is no longer a valid property 
and will be ignored: 
 Key: HIVE-19375
 URL: https://issues.apache.org/jira/browse/HIVE-19375
 Project: Hive
  Issue Type: Bug
  Components: Transactions
Reporter: Eugene Koifman
Assignee: Eugene Koifman


from {{TransactionalValidationListener.handleCreateTableTransactionalProp()}}

{noformat}
if ("false".equalsIgnoreCase(transactional)) {
  // just drop transactional=false.  For backward compatibility in case 
someone has scripts
  // with transactional=false
  LOG.info("'transactional'='false' is no longer a valid property and will 
be ignored: " +
Warehouse.getQualifiedName(newTable));
  return;
}
{noformat}

this msg is misleading since with metastore.create.as.acid=true, setting 
transactional=false is valid to make a flat table



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HIVE-19374) Parse and process ALTER TABLE SET OWNER command syntax

2018-05-01 Thread JIRA 
Sergio Peña created HIVE-19374:
--

 Summary: Parse and process ALTER TABLE SET OWNER command syntax
 Key: HIVE-19374
 URL: https://issues.apache.org/jira/browse/HIVE-19374
 Project: Hive
  Issue Type: Sub-task
  Components: Hive
Reporter: Sergio Peña


Subtask that parses the new alter table set owner syntax and implements code to 
call HMS to change the owner of a table to a user or a role.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HIVE-19373) Add alter table set owner notifications to DbNotificationListener

2018-05-01 Thread JIRA 
Sergio Peña created HIVE-19373:
--

 Summary: Add alter table set owner notifications to 
DbNotificationListener
 Key: HIVE-19373
 URL: https://issues.apache.org/jira/browse/HIVE-19373
 Project: Hive
  Issue Type: Sub-task
  Components: Hive, Metastore
Reporter: Sergio Peña


Subtask to add alter table set owner notifications to DbNotificationListener.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HIVE-19372) Add table ownerType to JDO and SQL schema scripts

2018-05-01 Thread JIRA 
Sergio Peña created HIVE-19372:
--

 Summary: Add table ownerType to JDO and SQL schema scripts
 Key: HIVE-19372
 URL: https://issues.apache.org/jira/browse/HIVE-19372
 Project: Hive
  Issue Type: Sub-task
  Components: Hive, Metastore
Reporter: Sergio Peña


Subtasks to add the ownerType field to the JDO and SQL schema scripts on the 
Hive metastore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HIVE-19371) Add table ownerType to HMS thrift API

2018-05-01 Thread JIRA 
Sergio Peña created HIVE-19371:
--

 Summary: Add table ownerType to HMS thrift API
 Key: HIVE-19371
 URL: https://issues.apache.org/jira/browse/HIVE-19371
 Project: Hive
  Issue Type: Sub-task
  Components: Hive, Metastore
Affects Versions: 3.0.0
Reporter: Sergio Peña


Subtasks that adds the ownerType field to the Table object of the HMS Thrift 
API.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

2018-05-01 Thread Sahil Takiar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66290/#review202193
---


Fix it, then Ship it!




One minor comment, otherwise LGTM.


jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java
Lines 713 (patched)


Should we modify beeline so if it gets a value of `-1` it says something 
like "Unknown number of rows affected", or just don't print anything at all. 
Right now it would print "No rows affected..." if an overflow happens, which 
would be odd.


- Sahil Takiar


On April 27, 2018, 11:05 p.m., Bharathkrishna Guruvayoor Murali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66290/
> ---
> 
> (Updated April 27, 2018, 11:05 p.m.)
> 
> 
> Review request for hive, Sahil Takiar and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-14388
> https://issues.apache.org/jira/browse/HIVE-14388
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Currently, when you run insert command on beeline, it returns a message 
> saying "No rows affected .."
> A better and more intuitive msg would be "xxx rows inserted (26.068 seconds)"
> 
> Added the numRows parameter as part of QueryState.
> Adding the numRows to the response as well to display in beeline.
> 
> Getting the count in FileSinkOperator and setting it in statsMap, when it 
> operates only on table specific rows for the particular operation. (so that 
> we can get only the insert to table count and avoid counting non-table 
> specific file-sink operations happening during query execution).
> 
> 
> Diffs
> -
> 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 
> 06542cee02e5dc4696f2621bb45cc4f24c67dfda 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java 
> 41ad002abf3d2a6969ef0d1d48f7db22e096bb47 
>   ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java 
> cf9c2273159c0d779ea90ad029613678fb0967a6 
>   ql/src/java/org/apache/hadoop/hive/ql/QueryState.java 
> 706c9ffa48b9c3b4a6fdaae78bab1d39c3d0efda 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 
> c084fa054cb771bfdb033d244935713e3c7eb874 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java 
> fcdc9967f12a454a9d3f31031e2261f264479118 
>   service-rpc/if/TCLIService.thrift 30f8af7f3e6e0598b410498782900ac27971aef0 
>   service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 
> 4321ad6d3c966d30f7a69552f91804cf2f1ba6c4 
>   service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 
> b2b62c71492b844f4439367364c5c81aa62f3908 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java
>  15e8220eb3eb12b72c7b64029410dced33bc0d72 
>   service-rpc/src/gen/thrift/gen-php/Types.php 
> abb7c1ff3a2c8b72dc97689758266b675880e32b 
>   service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py 
> 0f8fd0745be0f4ed9e96b7bbe0f092d03649bcdf 
>   service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 
> 60183dae9e9927bd09a9676e49eeb4aea2401737 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 
> c9914ba9bf8653cbcbca7d6612e98a64058c0fcc 
>   service/src/java/org/apache/hive/service/cli/OperationStatus.java 
> 52cc3ae4f26b990b3e4edb52d9de85b3cc25f269 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 
> 3706c72abc77ac8bd77947cc1c5d084ddf965e9f 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
> c64c99120ad21ee98af81ec6659a2722e3e1d1c7 
> 
> 
> Diff: https://reviews.apache.org/r/66290/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bharathkrishna Guruvayoor Murali
> 
>

ApacheCon North America 2018 schedule is now live.

2018-05-01 Thread Rich Bowen 

Dear Apache Enthusiast,

We are pleased to announce our schedule for ApacheCon North America 
2018. ApacheCon will be held September 23-27 at the Montreal Marriott 
Chateau Champlain in Montreal, Canada.


Registration is open! The early bird rate of $575 lasts until July 21, 
at which time it goes up to $800. And the room block at the Marriott 
($225 CAD per night, including wifi) closes on August 24th.


We will be featuring more than 100 sessions on Apache projects. The 
schedule is now online at https://apachecon.com/acna18/


The schedule includes full tracks of content from Cloudstack[1], 
Tomcat[2], and our GeoSpatial community[3].


We will have 4 keynote speakers, two of whom are Apache members, and two 
from the wider community.


On Tuesday, Apache member and former board member Cliff Schmidt will be 
speaking about how Amplio uses technology to educate and improve the 
quality of life of people living in very difficult parts of the 
world[4]. And Apache Fineract VP Myrle Krantz will speak about how Open 
Source banking is helping the global fight against poverty[5].


Then, on Wednesday, we’ll hear from Bridget Kromhout, Principal Cloud 
Developer Advocate from Microsoft, about the really hard problem in 
software - the people[6]. And Euan McLeod, ‎VP VIPER at ‎Comcast will 
show us the many ways that Apache software delivers your favorite shows 
to your living room[7].


ApacheCon will also feature old favorites like the Lightning Talks, the 
Hackathon (running the duration of the event), PGP key signing, and lots 
of hallway-track time to get to know your project community better.


Follow us on Twitter, @ApacheCon, and join the disc...@apachecon.com 
mailing list (send email to discuss-subscr...@apachecon.com) to stay up 
to date with developments. And if your company wants to sponsor this 
event, get in touch at h...@apachecon.com for opportunities that are 
still available.


See you in Montreal!

Rich Bowen
VP Conferences, The Apache Software Foundation
h...@apachecon.com
@ApacheCon

[1] http://cloudstackcollab.org/
[2] http://tomcat.apache.org/conference.html
[3] http://apachecon.dukecon.org/acna/2018/#/schedule?search=geospatial
[4] 
http://apachecon.dukecon.org/acna/2018/#/scheduledEvent/df977fd305a31b903
[5] 
http://apachecon.dukecon.org/acna/2018/#/scheduledEvent/22c6c30412a3828d6
[6] 
http://apachecon.dukecon.org/acna/2018/#/scheduledEvent/fbbb2384fa91ebc6b
[7] 
http://apachecon.dukecon.org/acna/2018/#/scheduledEvent/88d50c3613852c2de