Re: Review Request 68917: HIVE-20651: JdbcStorageHandler password should be encrypted

[Daniel Dai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68917/
---

(Updated Oct. 5, 2018, 5:24 a.m.)


Review request for hive and Sankar Hariappan.


Repository: hive-git


Description
---

See HIVE-20651


Diffs (updated)
-

  itests/src/test/resources/testconfiguration.properties fdd8ecc 
  jdbc-handler/pom.xml f90892f 
  jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/JdbcInputFormat.java 
caa823f 
  
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/conf/JdbcStorageConfigManager.java
 55fc0ea 
  
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/GenericJdbcDatabaseAccessor.java
 b2ad9a6 
  
jdbc-handler/src/test/java/org/apache/hive/storage/jdbc/TestJdbcInputFormat.java
 e904774 
  pom.xml 5008923 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 74fb1ba 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapper.java 99b33a3 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMapRecordHandler.java 
7cd853f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/MapRecordProcessor.java 
ac43917 
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java a86656c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 82c3ca9 
  ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 250a085 
  ql/src/java/org/apache/hadoop/hive/ql/plan/TableDesc.java b73faa5 


Diff: https://reviews.apache.org/r/68917/diff/2/

Changes: https://reviews.apache.org/r/68917/diff/1-2/


Testing
---


Thanks,

Daniel Dai

Error running checkstyle:checkstyle goal

[Ashutosh Bapat]

Hi,
I am trying to run "mvn checkstyle:checkstyle" to catch checkstyle errors
before submitting a patch. But while running that command I get an error
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:2.17:checkstyle
(default-cli) on project hive-standalone-metastore-common: An error has
occurred in Checkstyle report generation. Failed during checkstyle
execution: Unable to find configuration file at location:
/work/bug110208/cr/standalone-metastore/metastore-common/checkstyle//checkstyle.xml:
Could not find resource
'/work/bug110208/cr/standalone-metastore/metastore-common/checkstyle//checkstyle.xml'.

Looks like we are missing checkstyle.xml file in the given location. Looks
like we need to fix that.

I also wonder, how does jenkins is able to run checkstyle.

--
Best Wishes,
Ashutosh Bapat

Re: Review Request 68834: HIVE-20556

[Eugene Koifman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68834/#review209243
---


Ship it!




Ship It!

- Eugene Koifman


On Sept. 24, 2018, 8:04 p.m., Jaume Marhuenda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68834/
> ---
> 
> (Updated Sept. 24, 2018, 8:04 p.m.)
> 
> 
> Review request for hive, Daniel Dai and Eugene Koifman.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Expose an API to retrieve the TBL_ID from TBLS in the metastore tables
> 
> 
> Diffs
> -
> 
>   data/files/exported_table/_metadata 81fbf63a54 
>   
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestAuthorizationPreEventListener.java
>  05c00094d6 
>   
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestMetastoreAuthorizationProvider.java
>  767321332c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java f72e08c14f 
>   ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java ca4d36f30d 
>   
> ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreChecker.java 
> ff411f62d5 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java
>  78ac909f72 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php
>  22deffe1d3 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py
>  38fac465d7 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb
>  0192c6da31 
>   standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 
> 85a5c601e0 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
>  ba82a9327c 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
>  64945060f7 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MTable.java
>  deeb97133d 
>   standalone-metastore/metastore-server/src/main/resources/package.jdo 
> 2a5f016b1f 
>   
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
>  4937d9d861 
>   
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStorePartitionSpecs.java
>  df83171648 
>   
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
>  bf302ed491 
> 
> 
> Diff: https://reviews.apache.org/r/68834/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jaume Marhuenda
> 
>

[jira] [Created] (HIVE-20691) Fix org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[cttl]

[Jesus Camacho Rodriguez (JIRA)]

Jesus Camacho Rodriguez created HIVE-20691:
--

 Summary: Fix 
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[cttl]
 Key: HIVE-20691
 URL: https://issues.apache.org/jira/browse/HIVE-20691
 Project: Hive
  Issue Type: Bug
Reporter: Jesus Camacho Rodriguez
Assignee: Jesus Camacho Rodriguez


Blocking all ptest runs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68897: Allow merge statement to have column schema

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68897/
---

(Updated Oct. 4, 2018, 3:26 p.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-20590
https://issues.apache.org/jira/browse/HIVE-20590


Repository: hive-git


Description
---

Allow merge statement to have column schema.

Also removed some unused code, and made the rewritten query more consistent 
(upper case SQL keywords everywhere)


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 78bc87c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java e81ed50 
  ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java 
e8823e1 
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCardinalityViolation.java
 b688447 
  ql/src/test/queries/clientnegative/merge_column_mismatch.q PRE-CREATION 
  ql/src/test/queries/clientpositive/sqlmerge_stats.q c480eb6 
  ql/src/test/results/clientnegative/merge_column_mismatch.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/llap/sqlmerge_stats.q.out 02aa87a 


Diff: https://reviews.apache.org/r/68897/diff/3/

Changes: https://reviews.apache.org/r/68897/diff/2-3/


Testing
---

Tested on local cluster using the new syntax. Also modified a q file to use the 
new syntax.


Thanks,

Miklos Gergely

[GitHub] hive pull request #444: HIVE-20685 XmlOutputFormat does not escape all requi...

[kochunstvo]

GitHub user kochunstvo opened a pull request:

https://github.com/apache/hive/pull/444

HIVE-20685 XmlOutputFormat does not escape all required symbols in case of 
attribte/text

 Change escaping to apache's StringEscapingUtil which works as written at 
https://www.w3.org/TR/2008/REC-xml-20081126/#syntax

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kochunstvo/hive HIVE-20685

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/hive/pull/444.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #444


commit 0cdb857ce669f182f8530a7105b81ac34fda8ace
Author: Dmitrii_Khekk 
Date:   2018-10-04T12:20:41Z

HIVE-20685 Change escaping to apache's StringEscapingUtil which works as 
written at https://www.w3.org/TR/2008/REC-xml-20081126/#syntax




---

[jira] [Created] (HIVE-20690) Order by in sequential subqueries with swapped columns in select gives wrong key type

[Sergey Kuznetsov (JIRA)]

Sergey Kuznetsov created HIVE-20690:
---

 Summary: Order by in sequential subqueries with swapped columns in 
select gives wrong key type
 Key: HIVE-20690
 URL: https://issues.apache.org/jira/browse/HIVE-20690
 Project: Hive
  Issue Type: Bug
 Environment: Hive 1.2, 2.3
Reporter: Sergey Kuznetsov


There is a strange bug with order by in sequential subqueries described this 
[SO 
question|[https://stackoverflow.com/questions/52639572/hive-1-2-sql-returns-unexpected-special-character].|https://stackoverflow.com/questions/52639572/hive-1-2-sql-returns-unexpected-special-character]:]If
 you run the following query:
{code:java}
SELECT t6.amt amt2,t6.color color
FROM(
 SELECT t5.color color, t5.c1 amt
 FROM(
  SELECT t1.c1 c1, t1.c2 AS color 
  from(
   SELECT  7716 AS c1, "Red" AS c2 UNION 
   SELECT  6203 AS c1, "Blue" AS c2
  ) t1
 ) t5
order by color) t6
ORDER BY color
{code}
you will get
{noformat}
amt color
4   �
3   �{noformat}
I tried to turn off query optimization, stats gathering and rpc but the result 
remains the same. In formatted query plan, Reducer 3, Reduce Output Operator I 
noticed
{noformat}
key expressions::"_col1 (type: int)"{noformat}
whereas It supposed to be of type string. For some reason swapping two columns 
changes the key type from string to int. It's not critical but worth knowing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Incorrect Release Notes for Hive-2.3.3

[Oleksiy S]

Current release notes for Hive-2.3.3 are: RNs


Release Notes - Hive - Version 2.3.3

** Bug
* [HIVE-16939] - metastore error: 'export: -Dproc_metastore : not a
valid identifier'
* [HIVE-18767] - Some alterPartitions invocations throw
'NumberFormatException: null'
* [HIVE-18788] - Clean up inputs in JDBC PreparedStatement
* [HIVE-18815] - Remove unused feature in HPL/SQL
* [HIVE-18879] - Disallow embedded element in UDFXPathUtil needs to
work if xercesImpl.jar in classpath
* [HIVE-18885] - DbNotificationListener has a deadlock between Java and
DB locks (2.x line)
* [HIVE-20304] - When hive.optimize.skewjoin and hive.auto.convert.join
are both set to true, and the execution engine is mr, same stage may launch
twice due to the wrong generated plan
* [HIVE-20441] - NPE in ExprNodeGenericFuncDesc  when
hive.allow.udf.load.on.demand is set to true

** Improvement
* [HIVE-19900] - HiveCLI HoS Performs Invalid Impersonation If User
Name Truncated
* [HIVE-20284] - In strict mode, if constant propagation is enable, the
partition filter may be folded before partition pruner lead to error "No
partition predicate for Alias"


See table for short summary.
Issue Comment
HIVE-18767 Issue is not in Hive-2.3.3
HIVE-20304 Issue is unresolved in Apache Hive JIRA
HIVE-20441 Issue is unresolved in Apache Hive JIRA
HIVE-19900 Resolved: Workaround. No commit to see
HIVE-20284 Issue is unresolved in Apache Hive JIRA

Please remove incorrect JIRAs from RNs.

-- 
Oleksiy

[jira] [Created] (HIVE-20689) Simplifying using predicates should consider not equals in case its a predicate

[Zoltan Haindrich (JIRA)]

Zoltan Haindrich created HIVE-20689:
---

 Summary: Simplifying using predicates should consider not equals 
in case its a predicate
 Key: HIVE-20689
 URL: https://issues.apache.org/jira/browse/HIVE-20689
 Project: Hive
  Issue Type: Bug
Reporter: Zoltan Haindrich
Assignee: Zoltan Haindrich


Right now simplifyUsingPredicates bails out for [all <> 
comparisions|https://github.com/apache/calcite/blob/c39bfaa02a06ac91575076a6e74f29863923f5eb/core/src/main/java/org/apache/calcite/rex/RexSimplify.java#L1050];
 however if it's already an explicit predicate (or its negated one); then it 
could be demoted to:
{code}
x IS NOT NULL or null
{code}
which could be further simplified in most cases..




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)