[jira] [Created] (HIVE-20870) Metastore cache is accessed for transaction table also

2018-11-05 Thread mahesh kumar behera (JIRA)
mahesh kumar behera created HIVE-20870:
--

 Summary: Metastore cache is accessed for transaction table also
 Key: HIVE-20870
 URL: https://issues.apache.org/jira/browse/HIVE-20870
 Project: Hive
  Issue Type: Bug
  Components: Hive
Affects Versions: 4.0.0
Reporter: mahesh kumar behera
Assignee: mahesh kumar behera
 Fix For: 4.0.0


The check for transactional table is used to get the stats for transactional 
table directly from the raw store. But because of missing return statement , 
its trying to access the cache.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [ANNOUNCE] New PMC Member : Zoltan

2018-11-05 Thread Lefty Leverenz
Congratulations!

-- Lefty


On Thu, Nov 1, 2018 at 12:45 AM Sankar Hariappan 
wrote:

> Congrats Zoltan!
>
> Best regards
> Sankar
>
>
>
>
>
>
>
> On 31/10/18, 11:12 PM, "Vihang Karajgaonkar" 
> wrote:
>
> >Congrats Zoltan!
> >
> >On Wed, Oct 31, 2018 at 1:10 AM, Peter Vary 
> >wrote:
> >
> >> Congratulations Zoltan!
> >> Well deserved!
> >>
> >> > On Oct 31, 2018, at 06:16, Prasanth Jayachandran <
> >> pjayachand...@hortonworks.com> wrote:
> >> >
> >> > Congratulations!
> >> >
> >> >> On Oct 30, 2018, at 10:15 PM, Deepak Jaiswal <
> djais...@hortonworks.com>
> >> wrote:
> >> >>
> >> >> Congratulations Zoltan!
> >> >>
> >> >> On 10/30/18, 10:08 PM, "Ashutosh Chauhan" 
> >> wrote:
> >> >>
> >> >>Hello Hive community,
> >> >>
> >> >>   I'm pleased to announce that Zoltan Haindrich has accepted the
> Apache
> >> >>   Hive PMC's invitation, and is our newest PMC member. Many thanks to
> >> >>   Zoltan for all of his hard work.
> >> >>
> >> >>   Please join me in congratulating Zoltan!
> >> >>
> >> >>   Thanks,
> >> >>   Ashutosh
> >> >>
> >> >>
> >> >
> >>
> >>
>


Re: Review Request 69258: HIVE-20744

2018-11-05 Thread Jesús Camacho Rodríguez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69258/
---

(Updated Nov. 6, 2018, 5:28 a.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-20744
https://issues.apache.org/jira/browse/HIVE-20744


Repository: hive-git


Description
---

HIVE-20744 (improve)


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java 
9aa30129b65507beab40ae57151b8f6cbef8db92 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinConstraintsRule.java
 534a5c9531e74893a4ffb68d76195f1cd3a26690 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java
 576ed34bf30d1ec7788455055385a325d9367455 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSelectivity.java
 575902d78de2a7f95585c23a3c2fc03b9ce89478 
  ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query17.q.out 
d1005788d5861bc9315f64d14a5fbb25050bd646 
  ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query24.q.out 
0801f344729c995a9ce68cd868c930154744d4c3 
  ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query25.q.out 
a39931a22ccfdbf6606cc38fd18aa767e0457b4c 
  ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query64.q.out 
60c4325f41d5dcf196df2a73f95cc735c343383e 
  ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query72.q.out 
5e6950fb3e16c5be1cea94c660500e9d5d0c413d 
  ql/src/test/results/clientpositive/perf/tez/constraints/query17.q.out 
e796101e4527f3ad418e28b7f93b3134ad4f8fc7 
  ql/src/test/results/clientpositive/perf/tez/constraints/query24.q.out 
fb77386d6ef9f72b4fff4148b824b37779383398 
  ql/src/test/results/clientpositive/perf/tez/constraints/query25.q.out 
a353c6a12869bdb720fdf27b1d0f55064e218950 
  ql/src/test/results/clientpositive/perf/tez/constraints/query64.q.out 
aebd6b4137d3106dde757d41c0e449e73f8b3c11 
  ql/src/test/results/clientpositive/perf/tez/constraints/query72.q.out 
f27fbc9273303cdb30a7d86fb2c9508a736cd033 


Diff: https://reviews.apache.org/r/69258/diff/2/

Changes: https://reviews.apache.org/r/69258/diff/1-2/


Testing
---


Thanks,

Jesús Camacho Rodríguez



Review Request 69258: HIVE-20744

2018-11-05 Thread Jesús Camacho Rodríguez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69258/
---

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-20744
https://issues.apache.org/jira/browse/HIVE-20744


Repository: hive-git


Description
---

HIVE-20744 (improve)


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java 
9aa30129b65507beab40ae57151b8f6cbef8db92 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinConstraintsRule.java
 534a5c9531e74893a4ffb68d76195f1cd3a26690 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java
 576ed34bf30d1ec7788455055385a325d9367455 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSelectivity.java
 575902d78de2a7f95585c23a3c2fc03b9ce89478 


Diff: https://reviews.apache.org/r/69258/diff/1/


Testing
---


Thanks,

Jesús Camacho Rodríguez



Re: Review Request 69107: HIVE-20512

2018-11-05 Thread Bharathkrishna Guruvayoor Murali via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69107/
---

(Updated Nov. 6, 2018, 5:08 a.m.)


Review request for hive, Antal Sinkovits, Sahil Takiar, and Vihang Karajgaonkar.


Changes
---

Adding shutDown and awaitTermination. Addressed the review comment.


Repository: hive-git


Description
---

Improve record and memory usage logging in SparkRecordHandler


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMapRecordHandler.java 
88dd12c05ade417aca4cdaece4448d31d4e1d65f 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMergeFileRecordHandler.java
 8880bb604e088755dcfb0bcb39689702fab0cb77 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java 
cb5bd7ada2d5ad4f1f654cf80ddaf4504be5d035 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkReduceRecordHandler.java 
20e7ea0f4e8d4ff79dddeaab0406fc7350d22bd7 


Diff: https://reviews.apache.org/r/69107/diff/5/

Changes: https://reviews.apache.org/r/69107/diff/4-5/


Testing
---


Thanks,

Bharathkrishna Guruvayoor Murali



Review Request 69257: HIVE-20842 Fix logic introduced in HIVE-20660 to estimate statistics for group by

2018-11-05 Thread Vineet Garg

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69257/
---

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-20842
https://issues.apache.org/jira/browse/HIVE-20842


Repository: hive-git


Description
---

See jIRA


Diffs
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
 32fba6c8ff 
  ql/src/test/results/clientpositive/annotate_stats_groupby.q.out fe30d3197c 
  ql/src/test/results/clientpositive/cbo_rp_annotate_stats_groupby.q.out 
91369679aa 
  ql/src/test/results/clientpositive/llap/bucket_groupby.q.out 4e6885d9a2 
  ql/src/test/results/clientpositive/llap/bucket_map_join_tez2.q.out 8fe30f0cc5 
  ql/src/test/results/clientpositive/llap/check_constraint.q.out 72736807cc 
  ql/src/test/results/clientpositive/llap/constraints_optimization.q.out 
96caa4d6dd 
  ql/src/test/results/clientpositive/llap/correlationoptimizer1.q.out 
efa2dd818a 
  ql/src/test/results/clientpositive/llap/correlationoptimizer6.q.out 
93a3017696 
  ql/src/test/results/clientpositive/llap/dynpart_sort_opt_vectorization.q.out 
bd3c7769a4 
  ql/src/test/results/clientpositive/llap/dynpart_sort_optimization2.q.out 
30074abaf2 
  ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out 
dca0ebdab8 
  ql/src/test/results/clientpositive/llap/except_distinct.q.out c155a73c96 
  ql/src/test/results/clientpositive/llap/explainanalyze_2.q.out 9332e719d9 
  ql/src/test/results/clientpositive/llap/explainuser_1.q.out a87890f89e 
  ql/src/test/results/clientpositive/llap/explainuser_2.q.out 51465324d2 
  ql/src/test/results/clientpositive/llap/explainuser_4.q.out bf20c3d8dc 
  ql/src/test/results/clientpositive/llap/intersect_all.q.out dbb77d1abc 
  ql/src/test/results/clientpositive/llap/intersect_distinct.q.out 604c7bbd63 
  ql/src/test/results/clientpositive/llap/intersect_merge.q.out b19fd2c4ec 
  ql/src/test/results/clientpositive/llap/limit_pushdown.q.out a84a7b3db3 
  ql/src/test/results/clientpositive/llap/limit_pushdown3.q.out 8d5848bcd3 
  ql/src/test/results/clientpositive/llap/mrr.q.out a8aceea293 
  ql/src/test/results/clientpositive/llap/offset_limit_ppd_optimizer.q.out 
133d8af9e9 
  ql/src/test/results/clientpositive/llap/parallel.q.out 692bb8ca74 
  ql/src/test/results/clientpositive/llap/parallel_colstats.q.out 91a450accf 
  ql/src/test/results/clientpositive/llap/ptf.q.out b719f73566 
  ql/src/test/results/clientpositive/llap/reduce_deduplicate_distinct.q.out 
8d04800040 
  ql/src/test/results/clientpositive/llap/reduce_deduplicate_extended.q.out 
54dc0f7b8f 
  ql/src/test/results/clientpositive/llap/selectDistinctStar.q.out 17601acc2d 
  ql/src/test/results/clientpositive/llap/sharedworkext.q.out ca2b4d6750 
  ql/src/test/results/clientpositive/llap/sqlmerge_stats.q.out cd178cff4c 
  ql/src/test/results/clientpositive/llap/subquery_in.q.out 3222e2f616 
  ql/src/test/results/clientpositive/llap/subquery_in_having.q.out 3839696882 
  ql/src/test/results/clientpositive/llap/subquery_multi.q.out 7b00d69754 
  ql/src/test/results/clientpositive/llap/subquery_notin.q.out 37e7562818 
  ql/src/test/results/clientpositive/llap/subquery_scalar.q.out c72e4b2097 
  ql/src/test/results/clientpositive/llap/subquery_select.q.out 6870ad1873 
  ql/src/test/results/clientpositive/llap/subquery_views.q.out 4c723dce6b 
  ql/src/test/results/clientpositive/llap/tez_join_hash.q.out 2ac8400576 
  ql/src/test/results/clientpositive/llap/tez_union2.q.out ef0d4bd71a 
  ql/src/test/results/clientpositive/llap/tez_union_multiinsert.q.out 
05d259b0d9 
  ql/src/test/results/clientpositive/llap/unionDistinct_1.q.out b1eec43b72 
  ql/src/test/results/clientpositive/llap/unionDistinct_3.q.out 5337820ab0 
  ql/src/test/results/clientpositive/llap/vector_adaptor_usage_mode.q.out 
52b17cf36b 
  ql/src/test/results/clientpositive/llap/vector_char_2.q.out 1ba0ab6920 
  ql/src/test/results/clientpositive/llap/vector_distinct_2.q.out e72e398e4b 
  ql/src/test/results/clientpositive/llap/vector_groupby_3.q.out 3ea544e4b8 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets2.q.out 
7bee405977 
  ql/src/test/results/clientpositive/llap/vector_groupby_reduce.q.out 
3696cad941 
  ql/src/test/results/clientpositive/llap/vector_outer_reference_windowed.q.out 
fcde000739 
  ql/src/test/results/clientpositive/llap/vector_windowing.q.out 8e8c445af7 
  ql/src/test/results/clientpositive/llap/vector_windowing_gby2.q.out 
5943548a6c 
  ql/src/test/results/clientpositive/llap/vectorization_limit.q.out 3dc640a300 
  ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out 
f929706757 
  ql/src/test/results/clientpositive/llap/vectorized_ptf.q.out 56e81aa819 
  ql/src/test/results/clientpositive/llap/windowing.q.out ffd21abb4c 
  ql/src/test/results/clientpositive/perf/tez/constraints/query11.q.out 
658ae2

[jira] [Created] (HIVE-20869) Fix test results file

2018-11-05 Thread slim bouguerra (JIRA)
slim bouguerra created HIVE-20869:
-

 Summary: Fix test results file
 Key: HIVE-20869
 URL: https://issues.apache.org/jira/browse/HIVE-20869
 Project: Hive
  Issue Type: Sub-task
  Components: kafka integration
Reporter: slim bouguerra
Assignee: slim bouguerra


seems like between the time test run and HIVE-20486 was merged new hive 
property was added 
{code}
discover.partitions true
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

2018-11-05 Thread Vineet Garg


> On Nov. 1, 2018, 8:33 p.m., Jesús Camacho Rodríguez wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java
> > Lines 774 (patched)
> > 
> >
> > Cardinality and NDV may change. This just checks whether column 
> > origin/lineage can be backtrack to single input. We should use 
> > RelMdColumnOrigins or RelMdExpressionLineage instead of writing this new 
> > class.

The reason I decided not to use RelMdColumnOrigins or RelMdExpressionLineage is 
because both of them operate on single column/rex node. To get to column origin 
for a set of columns/RexRefs we will need to call them repeatadely. I feel this 
is big overkill and therefore wrote another class to take on set of columns.

I agree about the name being misleading. I'll rename the class to better 
communicate its purpose.


> On Nov. 1, 2018, 8:33 p.m., Jesús Camacho Rodríguez wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java
> > Lines 346 (patched)
> > 
> >
> > This should never be empty?

It could be empty if 'CardinalityChange' couldn't backtrack. However if can 
never be null.


> On Nov. 1, 2018, 8:33 p.m., Jesús Camacho Rodríguez wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java
> > Lines 359 (patched)
> > 
> >
> > This logic does not seem correct. What happens when a Project permutes 
> > input references and the GBy columns would not be in same order as the key? 
> > For instance consider GBy key is (0,1,2) which maps into columns (2,0,4) in 
> > TS. Key is (0,4). You would remove column 1 from GBy, but you should remove 
> > column 0. Using ColumnOrigins or ExpressionLineage providers to get the 
> > mapping would solve the issue.

The whole for loop actually takes care of this case. CardinalityChange returns 
you backtracked (if it could) columns (2,0,4) in this case. Then we loop over 
this backtracked columns and remove the corresponding column from the GBy key 
(based on the position) if not part of key. For instance in this case first 
column in backtracked columns (i.e. 2) is not part of key therefore 
corresponding column (i.e. 0) will be removed from GBy key.


- Vineet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69202/#review210258
---


On Nov. 5, 2018, 10:57 p.m., Vineet Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69202/
> ---
> 
> (Updated Nov. 5, 2018, 10:57 p.m.)
> 
> 
> Review request for hive and Jesús Camacho Rodríguez.
> 
> 
> Bugs: HIVE-20804
> https://issues.apache.org/jira/browse/HIVE-20804
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> See Jira
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java 
> 9aa30129b6 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java
>  b7c31bdfca 
>   ql/src/test/queries/clientpositive/constraints_optimization.q 70ab8509c5 
>   ql/src/test/results/clientpositive/llap/constraints_optimization.q.out 
> 96caa4d6dd 
> 
> 
> Diff: https://reviews.apache.org/r/69202/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>



Re: Review Request 69107: HIVE-20512

2018-11-05 Thread Sahil Takiar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69107/#review210338
---




ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java
Lines 135 (patched)


Should call `Thread.currentThread().interrupt();` after this - see 
https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ExecutorService.html


- Sahil Takiar


On Oct. 31, 2018, 11:15 p.m., Bharathkrishna Guruvayoor Murali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69107/
> ---
> 
> (Updated Oct. 31, 2018, 11:15 p.m.)
> 
> 
> Review request for hive, Antal Sinkovits, Sahil Takiar, and Vihang 
> Karajgaonkar.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Improve record and memory usage logging in SparkRecordHandler
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMapRecordHandler.java 
> 88dd12c05ade417aca4cdaece4448d31d4e1d65f 
>   
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMergeFileRecordHandler.java
>  8880bb604e088755dcfb0bcb39689702fab0cb77 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java 
> cb5bd7ada2d5ad4f1f654cf80ddaf4504be5d035 
>   
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkReduceRecordHandler.java
>  20e7ea0f4e8d4ff79dddeaab0406fc7350d22bd7 
> 
> 
> Diff: https://reviews.apache.org/r/69107/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bharathkrishna Guruvayoor Murali
> 
>



Re: Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

2018-11-05 Thread Vineet Garg

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69202/
---

(Updated Nov. 5, 2018, 10:57 p.m.)


Review request for hive and Jesús Camacho Rodríguez.


Changes
---

Addressed review comments


Bugs: HIVE-20804
https://issues.apache.org/jira/browse/HIVE-20804


Repository: hive-git


Description
---

See Jira


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java 
9aa30129b6 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java
 b7c31bdfca 
  ql/src/test/queries/clientpositive/constraints_optimization.q 70ab8509c5 
  ql/src/test/results/clientpositive/llap/constraints_optimization.q.out 
96caa4d6dd 


Diff: https://reviews.apache.org/r/69202/diff/2/

Changes: https://reviews.apache.org/r/69202/diff/1-2/


Testing
---


Thanks,

Vineet Garg



[RESULT][VOTE] Apache Hive 2.3.4 Release Candidate 0

2018-11-05 Thread Daniel Dai
With three +1’s (Alan, Thejas, Daniel) and no -1’s the vote passes.

I will wrap up the release and send announcement once done.
 



Re: [VOTE] Apache Hive 2.3.4 Release Candidate 0

2018-11-05 Thread Thejas Nair
+1 Verified signatures, build src tar

On Wed, Oct 31, 2018 at 2:45 PM Daniel Dai  wrote:
>
> Apache Hive 2.3.4 Release Candidate 0 is available here:
>
> http://people.apache.org/~daijy/apache-hive-2.3.4-rc-0/
>
> Maven artifacts are available here:
>
> https://repository.apache.org/content/repositories/orgapachehive-1093
>
> Source tag for RCN is at:
>
> https://github.com/apache/hive/tree/release-2.3.4-rc0
>
> Voting will conclude in 72 hours.
>
> Hive PMC Members: Please test and vote.
>
> Thanks.
>
>


[jira] [Created] (HIVE-20868) SMB Join fails intermittently when TezDummyOperator has child op in getFinalOp in MapRecordProcessor

2018-11-05 Thread Deepak Jaiswal (JIRA)
Deepak Jaiswal created HIVE-20868:
-

 Summary: SMB Join fails intermittently when TezDummyOperator has 
child op in getFinalOp in MapRecordProcessor
 Key: HIVE-20868
 URL: https://issues.apache.org/jira/browse/HIVE-20868
 Project: Hive
  Issue Type: Bug
Reporter: Deepak Jaiswal
Assignee: Deepak Jaiswal






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 69254: HIVE-20818: Views created with a WHERE subquery will regard views referenced in the subquery as direct input

2018-11-05 Thread Peter Vary via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69254/#review210334
---



Just one question.
Thanks,
Peter


ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
Lines 3321 (patched)


Is the problem only affects CBO, or RBO as well?
What happens when CBO is off?



ql/src/test/org/apache/hadoop/hive/ql/plan/TestViewEntity.java
Lines 198 (patched)


Please remove extra spaces..


- Peter Vary


On nov. 5, 2018, 3:14 du, Karen Coppage wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69254/
> ---
> 
> (Updated nov. 5, 2018, 3:14 du)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-20818
> https://issues.apache.org/jira/browse/HIVE-20818
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> If Hive is configured with an authorization hook like Sentry, and a view is 
> created with a WHERE clause referencing a different view' user has no access 
> to, user cannot access the view as view' is considered direct input.
> WHERE IN and WHERE EXISTS cause the same issue.
> Cascading views created with no WHERE clauses (i.e. with simple SELECTs and 
> FROM clauses) work fine.
> 
> See Jira for example
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java ab63ce2bc3 
>   ql/src/test/org/apache/hadoop/hive/ql/plan/TestViewEntity.java 6ad38b8467 
> 
> 
> Diff: https://reviews.apache.org/r/69254/diff/1/
> 
> 
> Testing
> ---
> 
> Added unit test
> 
> 
> Thanks,
> 
> Karen Coppage
> 
>



Review Request 69256: HIVE-20822

2018-11-05 Thread Jesús Camacho Rodríguez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69256/
---

Review request for hive and Daniel Dai.


Bugs: HIVE-20822
https://issues.apache.org/jira/browse/HIVE-20822


Repository: hive-git


Description
---

HIVE-20822


Diffs
-

  itests/src/test/resources/testconfiguration.properties 
da2091ac5d2b6b70e232bce3d489188ac40f43d5 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveBetween.java
 ffc705f381d35f689276f9de1663e0a8197c98df 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/jdbc/HiveJdbcConverter.java
 382060243e6d253e7ca88d50b067f75ddf340ede 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/HiveJdbcImplementor.java
 531e769b10dcda0169ff8b79d7eac53dc940dc71 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/JDBCProjectPushDownRule.java
 5c03f87361e67ef18165c3c55903648c9408b214 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
ab63ce2bc34cc5fc2f44d65c9371b2a59593c9a2 
  ql/src/test/queries/clientpositive/external_jdbc_table_perf.q PRE-CREATION 
  ql/src/test/results/clientpositive/llap/external_jdbc_table.q.out 
1bb41dd42746864612c68219489a3a056922cbe8 
  ql/src/test/results/clientpositive/llap/external_jdbc_table2.q.out 
9bfee47b89ed165b23571e459eaeece1dad7d012 
  ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out 
PRE-CREATION 


Diff: https://reviews.apache.org/r/69256/diff/1/


Testing
---


Thanks,

Jesús Camacho Rodríguez



[jira] [Created] (HIVE-20867) Rewrite INTERSECT into LEFT SEMI JOIN instead of UNION + Group by

2018-11-05 Thread Vineet Garg (JIRA)
Vineet Garg created HIVE-20867:
--

 Summary: Rewrite INTERSECT into LEFT SEMI JOIN instead of UNION + 
Group by
 Key: HIVE-20867
 URL: https://issues.apache.org/jira/browse/HIVE-20867
 Project: Hive
  Issue Type: Improvement
  Components: Query Planning
Affects Versions: 4.0.0
Reporter: Vineet Garg
Assignee: Vineet Garg






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 69254: HIVE-20818: Views created with a WHERE subquery will regard views referenced in the subquery as direct input

2018-11-05 Thread Karen Coppage via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69254/
---

Review request for hive.


Bugs: HIVE-20818
https://issues.apache.org/jira/browse/HIVE-20818


Repository: hive-git


Description
---

If Hive is configured with an authorization hook like Sentry, and a view is 
created with a WHERE clause referencing a different view' user has no access 
to, user cannot access the view as view' is considered direct input.
WHERE IN and WHERE EXISTS cause the same issue.
Cascading views created with no WHERE clauses (i.e. with simple SELECTs and 
FROM clauses) work fine.

See Jira for example


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java ab63ce2bc3 
  ql/src/test/org/apache/hadoop/hive/ql/plan/TestViewEntity.java 6ad38b8467 


Diff: https://reviews.apache.org/r/69254/diff/1/


Testing
---

Added unit test


Thanks,

Karen Coppage



Importing into eclipse

2018-11-05 Thread mark pasterkamp
Dear all,

Sorry if this is not the right communication channel for this type of question 
but I am a bit stuck.
I am trying to import Apache Hive into eclipse using the Apache Hive developers 
FAQ:
https://cwiki.apache.org/confluence/display/Hive/HiveDeveloperFAQ

In my eclipse workspace, I cloned the github repository.
I removed the .m2/repository/org/apache/hive folder.
I executed the described maven command: "mvn clean package eclipse:clean 
eclipse:eclipse -Pitests -DskipTests -DdownloadSources -DdownloadJavadocs".
Then I tried to import the project into the workspace first as an existing 
maven project from the root folder and when that did not work I tried it as an 
existing project which also did not work.

Running maven install to try and resolve the issues in eclipse fails because of 
failing tests in the hive query language project. Upon further inspection it 
seems to fail because hadoop_home and hadoop.home.dir are unset at 
org.apache.hadoop.util.Shell.checkHadoopHome.
However, hadoop_home is set in my path (version 3.1.1).

Again, I'm sorry if this is not the right place for these types of questions. I 
am a bit new to hive (and hadoop in general) but I would greatly appreciate it 
if someone can recognize what I did wrong and what I can do to resolve it.


With kind regards,

Mark