[jira] [Created] (HIVE-22740) Test failing tests with return path
Miklos Gergely created HIVE-22740: - Summary: Test failing tests with return path Key: HIVE-22740 URL: https://issues.apache.org/jira/browse/HIVE-22740 Project: Hive Issue Type: Bug Reporter: Miklos Gergely -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 71761: HIVE-22489
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71761/#review219317 --- Ship it! Ship It! - Jesús Camacho Rodríguez On Jan. 14, 2020, 8:39 p.m., Krisztian Kasa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71761/ > --- > > (Updated Jan. 14, 2020, 8:39 p.m.) > > > Review request for hive, Jesús Camacho Rodríguez and Zoltan Haindrich. > > > Bugs: HIVE-22489 > https://issues.apache.org/jira/browse/HIVE-22489 > > > Repository: hive-git > > > Description > --- > > Reduce Sink operator orders nulls first > === > 1. Set the default null sort order by hive config when creating Reduce Sink > Desc. > 2. Hash join uses > `org.apache.hadoop.hive.serde2.binarysortable.fast.BinarySortableSerializeWrite` > or `BinarySortableDeserializeRead` for selializing keys. For bigtable keys > always ascending and nulls first ordering was hardcoded. This patch changes > this behaviour to use the `Operator.getConf().TableDesc.getProperties()` (in > this case `MapJoinOperator`) to setup ordering in > `BinarySortableSerializeWrite` > 3. Use null ordering set in ReduceRecordSource at Reduce phase when comparing > keys in `CommonMergeJoinOperator` (This is the null ordering of the children > Reduce Sink operators) > > > Diffs > - > > accumulo-handler/src/test/results/positive/accumulo_queries.q.out > 7c552621f2 > contrib/src/test/results/clientpositive/udaf_example_group_concat.q.out > 6846720d95 > hbase-handler/src/test/results/positive/hbase_queries.q.out a32ef81a7b > > itests/hive-blobstore/src/test/results/clientpositive/write_final_output_blobstore.q.out > e997fa65cf > kudu-handler/src/test/results/positive/kudu_complex_queries.q.out > 73fc3e514f > ql/src/java/org/apache/hadoop/hive/ql/exec/CommonMergeJoinOperator.java > 3974627a24 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordSource.java > 72446afeda > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinCommonOperator.java > 2380d936f2 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyMultiKeyOperator.java > f587517b08 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerMultiKeyOperator.java > cdee3fd957 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiMultiKeyOperator.java > e5d9fdae19 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterMultiKeyOperator.java > 29c531bd51 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastLongHashMap.java > a4cda921a5 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastLongHashMultiSet.java > 43f093d906 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastLongHashSet.java > 8dce5b82d3 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastLongHashTable.java > a35401d9b2 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastStringCommon.java > 1b108a8c14 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastStringHashMap.java > 446feb2526 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastStringHashMultiSet.java > c28ef9be2b > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastStringHashSet.java > 17bd5fda93 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastTableContainer.java > 4ab8902a3f > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/optimized/VectorMapJoinOptimizedCreateHashTable.java > 21c355cb42 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/optimized/VectorMapJoinOptimizedLongCommon.java > de1ee15c3b > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/optimized/VectorMapJoinOptimizedLongHashMap.java > 42573f0898 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/optimized/VectorMapJoinOptimizedLongHashMultiSet.java > 829a03737d > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/optimized/VectorMapJoinOptimizedLongHashSet.java > 18e1435019 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/optimized/VectorMapJoinOptimizedStringCommon.java > da0e8365b1 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/optimized/VectorMapJoinOptimizedStringHashMap.java > 6c4d8a81d1 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/optimized/VectorMapJoinOptimizedStringHashMultiSet.java >
Re: Review Request 72013: HIVE-22735
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72013/#review219318 --- Ship it! Ship It! - Jesús Camacho Rodríguez On Jan. 16, 2020, 4:13 p.m., Krisztian Kasa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72013/ > --- > > (Updated Jan. 16, 2020, 4:13 p.m.) > > > Review request for hive and Jesús Camacho Rodríguez. > > > Bugs: HIVE-22735 > https://issues.apache.org/jira/browse/HIVE-22735 > > > Repository: hive-git > > > Description > --- > > TopNKey operator deduplication > == > When creating a TopNKeyDesc ignore `ExprNodeConstantDesc` type columns > > > Diffs > - > > ql/src/java/org/apache/hadoop/hive/ql/plan/TopNKeyDesc.java a9e2a527df > ql/src/test/results/clientpositive/llap/topnkey_grouping_sets.q.out > b1ec8d8847 > > ql/src/test/results/clientpositive/llap/topnkey_grouping_sets_functions.q.out > 0ec6e6de43 > ql/src/test/results/clientpositive/llap/topnkey_grouping_sets_order.q.out > d3ff1a6256 > > > Diff: https://reviews.apache.org/r/72013/diff/1/ > > > Testing > --- > > mvn test -Dtest.output.overwrite -DskipSparkTests > -Dtest=TestMiniLlapLocalCliDriver > -Dqfile=topnkey.q,topnkey_dedup.q,topnkey_grouping_sets_functions.q,topnkey_grouping_sets_order.q,topnkey_order_null.q,vector_topnkey.q > -pl itests/qtest -Pitests > > > Thanks, > > Krisztian Kasa > >
[jira] [Created] (HIVE-22739) Schematool should check if upgradeFrom version is identical to current DB schema version
Alice Fan created HIVE-22739: Summary: Schematool should check if upgradeFrom version is identical to current DB schema version Key: HIVE-22739 URL: https://issues.apache.org/jira/browse/HIVE-22739 Project: Hive Issue Type: Bug Components: Standalone Metastore Affects Versions: 4.0.0 Reporter: Alice Fan Assignee: Alice Fan Schematool should check if upgradeFrom version is identical to current DB schema version. https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/schematool/SchemaToolTaskUpgrade.java#L41 We should check if the user input fromVersion is identical to current DB version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HIVE-22738) CVE-2019-0205
Laurent Goujon created HIVE-22738: - Summary: CVE-2019-0205 Key: HIVE-22738 URL: https://issues.apache.org/jira/browse/HIVE-22738 Project: Hive Issue Type: Bug Components: Thrift API Reporter: Laurent Goujon Attachments: image-2020-01-16-10-25-33-064.png, image-2020-01-16-10-27-11-933.png There's has been a CVE issued for a Thrift vulnerability which might impact Hive. The CVE is [CVE-2019-0205|https://nvd.nist.gov/vuln/detail/CVE-2019-0205], impacts both clients and servers, and might cause a denial of service through an infinite loop. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 71984: HIVE-22666
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71984/ --- (Updated Jan. 16, 2020, 5:57 p.m.) Review request for hive and Jesús Camacho Rodríguez. Bugs: HIVE-22666 https://issues.apache.org/jira/browse/HIVE-22666 Repository: hive-git Description --- implement supporting partitioning in TopNKeyOperator enable push down of partitioned TopNKeyOperator Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/exec/TopNKeyOperator.java b7c1250220 ql/src/java/org/apache/hadoop/hive/ql/optimizer/topnkey/TopNKeyProcessor.java ce6efa4919 ql/src/java/org/apache/hadoop/hive/ql/optimizer/topnkey/TopNKeyPushdownProcessor.java 348fbb5faf ql/src/java/org/apache/hadoop/hive/ql/plan/TopNKeyDesc.java a9e2a527df ql/src/test/org/apache/hadoop/hive/ql/exec/TestTopNKeyFilter.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/optimizer/topnkey/TestCommonKeyPrefix.java 51d2382278 ql/src/test/queries/clientpositive/subquery_in.q a5b3ce7951 ql/src/test/queries/clientpositive/subquery_notin.q f8636453c2 ql/src/test/queries/clientpositive/topnkey_windowing.q PRE-CREATION ql/src/test/queries/clientpositive/topnkey_windowing_order.q PRE-CREATION ql/src/test/queries/clientpositive/vector_windowing_streaming.q e1011f9949 ql/src/test/queries/clientpositive/windowing_filter.q 2483c18416 ql/src/test/results/clientpositive/llap/subquery_in.q.out 24b16598e2 ql/src/test/results/clientpositive/llap/subquery_notin.q.out 6751eda7d3 ql/src/test/results/clientpositive/llap/topnkey_grouping_sets_functions.q.out 0ec6e6de43 ql/src/test/results/clientpositive/llap/topnkey_grouping_sets_order.q.out d3ff1a6256 ql/src/test/results/clientpositive/llap/topnkey_windowing.q.out PRE-CREATION ql/src/test/results/clientpositive/llap/topnkey_windowing_order.q.out PRE-CREATION ql/src/test/results/clientpositive/perf/tez/constraints/mv_query44.q.out 786bbe12c8 ql/src/test/results/clientpositive/perf/tez/constraints/query44.q.out eace7a0685 ql/src/test/results/clientpositive/perf/tez/constraints/query67.q.out 9ed7306c46 ql/src/test/results/clientpositive/perf/tez/constraints/query70.q.out 40dfaa2f13 ql/src/test/results/clientpositive/perf/tez/query44.q.out a0defab8b3 ql/src/test/results/clientpositive/perf/tez/query67.q.out 54d76e9c1a ql/src/test/results/clientpositive/perf/tez/query70.q.out 23f9166a4f ql/src/test/results/clientpositive/topnkey_windowing.q.out PRE-CREATION ql/src/test/results/clientpositive/topnkey_windowing_order.q.out PRE-CREATION Diff: https://reviews.apache.org/r/71984/diff/3/ Changes: https://reviews.apache.org/r/71984/diff/2-3/ Testing --- New q test were added topnkey_windowing.q,topnkey_windowing_order.q New UT: TestTopNKeyFilter.java existing: windowing_filter.q,topnkey.q,topnkey_grouping_sets.q,topnkey_grouping_sets_functions.q,topnkey_grouping_sets_order.q existing UT: TestCommonKeyPrefix Thanks, Krisztian Kasa
Review Request 72013: HIVE-22735
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72013/ --- Review request for hive and Jesús Camacho Rodríguez. Bugs: HIVE-22735 https://issues.apache.org/jira/browse/HIVE-22735 Repository: hive-git Description --- TopNKey operator deduplication == When creating a TopNKeyDesc ignore `ExprNodeConstantDesc` type columns Diffs - ql/src/java/org/apache/hadoop/hive/ql/plan/TopNKeyDesc.java a9e2a527df ql/src/test/results/clientpositive/llap/topnkey_grouping_sets.q.out b1ec8d8847 ql/src/test/results/clientpositive/llap/topnkey_grouping_sets_functions.q.out 0ec6e6de43 ql/src/test/results/clientpositive/llap/topnkey_grouping_sets_order.q.out d3ff1a6256 Diff: https://reviews.apache.org/r/72013/diff/1/ Testing --- mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=topnkey.q,topnkey_dedup.q,topnkey_grouping_sets_functions.q,topnkey_grouping_sets_order.q,topnkey_order_null.q,vector_topnkey.q -pl itests/qtest -Pitests Thanks, Krisztian Kasa
[jira] [Created] (HIVE-22737) Concurrency: FunctionRegistry::getFunctionInfo is static object locked
Gopal Vijayaraghavan created HIVE-22737:
---
Summary: Concurrency: FunctionRegistry::getFunctionInfo is static
object locked
Key: HIVE-22737
URL: https://issues.apache.org/jira/browse/HIVE-22737
Project: Hive
Issue Type: Bug
Components: Logical Optimizer, UDF
Reporter: Gopal Vijayaraghavan
Attachments: FunctionRegistry-lock.png
The lock is inside a HS2-wide static object
https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java#L191
{code}
// registry for system functions
private static final Registry system = new Registry(true);
{code}
And this is the lock itself
https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java#L332
{code}
public FunctionInfo getFunctionInfo(String functionName) throws
SemanticException {
lock.lock();
{code}
!FunctionRegistry-lock.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HIVE-22736) Support replication across multiple encryption zones
Aasha Medhi created HIVE-22736: -- Summary: Support replication across multiple encryption zones Key: HIVE-22736 URL: https://issues.apache.org/jira/browse/HIVE-22736 Project: Hive Issue Type: Bug Reporter: Aasha Medhi Assignee: Aasha Medhi -- This message was sent by Atlassian Jira (v8.3.4#803005)
