Re: Review Request 21886: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21886/#review44095 --- Ship it! Thanks, Looks good to me! - Zhuoluo Yang On May 28, 2014, 5:45 a.m., Navis Ryu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21886/ > --- > > (Updated May 28, 2014, 5:45 a.m.) > > > Review request for hive. > > > Bugs: HIVE-4561 > https://issues.apache.org/jira/browse/HIVE-4561 > > > Repository: hive-git > > > Description > --- > > if all column values larger than 0.0 DOUBLE_LOW_VALUE always will be 0.0 > or if all column values less than 0.0, DOUBLE_HIGH_VALUE will always be > > hive (default)> create table src_test (price double); > hive (default)> load data local inpath './test.txt' into table src_test; > hive (default)> select * from src_test; > OK > 1.0 > 2.0 > 3.0 > Time taken: 0.313 seconds, Fetched: 3 row(s) > hive (default)> analyze table src_test compute statistics for columns price; > > mysql> select * from TAB_COL_STATS \G; > CS_ID: 16 >DB_NAME: default > TABLE_NAME: src_test >COLUMN_NAME: price >COLUMN_TYPE: double > TBL_ID: 2586 > LONG_LOW_VALUE: 0 >LONG_HIGH_VALUE: 0 > DOUBLE_LOW_VALUE: 0. # Wrong Result ! Expected is 1. > DOUBLE_HIGH_VALUE: 3. > BIG_DECIMAL_LOW_VALUE: NULL > BIG_DECIMAL_HIGH_VALUE: NULL > NUM_NULLS: 0 > NUM_DISTINCTS: 1 >AVG_COL_LEN: 0. >MAX_COL_LEN: 0 > NUM_TRUES: 0 > NUM_FALSES: 0 > LAST_ANALYZED: 1368596151 > 2 rows in set (0.00 sec) > > > Diffs > - > > metastore/if/hive_metastore.thrift eef1b80 > metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 43869c2 > metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 9e440bb > > metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DecimalColumnStatsData.java > 5661252 > > metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DoubleColumnStatsData.java > d3f3f68 > > metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/LongColumnStatsData.java > 2cf4380 > metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py c4b583b > metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 79b7a1a > > metastore/src/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java > dc0e266 > > metastore/src/model/org/apache/hadoop/hive/metastore/model/MPartitionColumnStatistics.java > f61cdf0 > > metastore/src/model/org/apache/hadoop/hive/metastore/model/MTableColumnStatistics.java > 85f6427 > ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java 3dc02f0 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java ee4d56c > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java > 3b063eb > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/NumDistinctValueEstimator.java > 24159b8 > ql/src/test/queries/clientpositive/metadata_only_queries.q b549a56 > ql/src/test/results/clientpositive/compute_stats_empty_table.q.out 50d6c8d > ql/src/test/results/clientpositive/compute_stats_long.q.out 2f5cbdd > ql/src/test/results/clientpositive/metadata_only_queries.q.out 531ea41 > ql/src/test/results/clientpositive/metadata_only_queries_with_filters.q.out > c8e2c0c > > Diff: https://reviews.apache.org/r/21886/diff/ > > > Testing > --- > > > Thanks, > > Navis Ryu > >
Re: Review Request: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11172/ --- (Updated June 5, 2013, 2:06 p.m.) Review request for hive, Carl Steinbach, Carl Steinbach, Ashutosh Chauhan, Shreepadma Venugopalan, and fangkun cao. Changes --- Like GenericUDAFMax/GenericUDAFMin, it returns null for high/low value. Description --- An initialization error. Make double and long initialize correctly. Would you review that and assign the issue to me? This addresses bug HIVE-4561. https://issues.apache.org/jira/browse/HIVE-4561 Diffs (updated) - http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java 1489292 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/compute_stats_empty_table.q.out 1489292 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/compute_stats_long.q.out 1489292 Diff: https://reviews.apache.org/r/11172/diff/ Testing --- ant test -Dtestcase=TestCliDriver -Dqfile=compute_stats_long.q ant test -Dtestcase=TestCliDriver -Dqfile=compute_stats_double.q done. Thanks, Zhuoluo Yang
Re: Review Request: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11172/ --- (Updated June 4, 2013, 1:41 p.m.) Review request for hive, Carl Steinbach, Carl Steinbach, Ashutosh Chauhan, Shreepadma Venugopalan, and fangkun cao. Changes --- Sorry for my ignorance of the empty table. I think a UT fix is a quite simple way, shall we make the min/max value zero if the table is empty? Description --- An initialization error. Make double and long initialize correctly. Would you review that and assign the issue to me? This addresses bug HIVE-4561. https://issues.apache.org/jira/browse/HIVE-4561 Diffs (updated) - http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java 1489292 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/compute_stats_empty_table.q.out 1489292 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/compute_stats_long.q.out 1489292 Diff: https://reviews.apache.org/r/11172/diff/ Testing --- ant test -Dtestcase=TestCliDriver -Dqfile=compute_stats_long.q ant test -Dtestcase=TestCliDriver -Dqfile=compute_stats_double.q done. Thanks, Zhuoluo Yang
Review Request: CTAS with literal NULL creates VOID type
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11622/ --- Review request for hive. Description --- The checks after result schema is generated. if CTAS and contains void, it raise an exception and ask user to cast the type. This addresses bug HIVE-2615. https://issues.apache.org/jira/browse/HIVE-2615 Diffs - http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 1489292 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1489292 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/ctas_creates_void.q PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/ctas_creates_void.q.out PRE-CREATION Diff: https://reviews.apache.org/r/11622/diff/ Testing --- ant test -Dtestcase=TestNegativeCliDriver -Dqfile=ctas_creates_void.q Thanks, Zhuoluo Yang
Re: Review Request: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11172/ --- (Updated June 3, 2013, 4:46 a.m.) Review request for hive, Carl Steinbach, Carl Steinbach, Ashutosh Chauhan, and fangkun cao. Description --- An initialization error. Make double and long initialize correctly. Would you review that and assign the issue to me? This addresses bug HIVE-4561. https://issues.apache.org/jira/browse/HIVE-4561 Diffs - http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java 1488823 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/compute_stats_long.q.out 1488823 Diff: https://reviews.apache.org/r/11172/diff/ Testing --- ant test -Dtestcase=TestCliDriver -Dqfile=compute_stats_long.q ant test -Dtestcase=TestCliDriver -Dqfile=compute_stats_double.q done. Thanks, Zhuoluo Yang
Re: Review Request: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11172/ --- (Updated June 3, 2013, 3:04 a.m.) Review request for hive, Carl Steinbach, Carl Steinbach, and fangkun cao. Changes --- update "Testing Done". Description --- An initialization error. Make double and long initialize correctly. Would you review that and assign the issue to me? This addresses bug HIVE-4561. https://issues.apache.org/jira/browse/HIVE-4561 Diffs - http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java 1488823 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/compute_stats_long.q.out 1488823 Diff: https://reviews.apache.org/r/11172/diff/ Testing (updated) --- ant test -Dtestcase=TestCliDriver -Dqfile=compute_stats_long.q ant test -Dtestcase=TestCliDriver -Dqfile=compute_stats_double.q done. Thanks, Zhuoluo Yang
Re: Review Request: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11172/ --- (Updated June 3, 2013, 2:48 a.m.) Review request for hive, Carl Steinbach, Carl Steinbach, and fangkun cao. Changes --- Update a new patch with some comments and a UT revision. Description --- An initialization error. Make double and long initialize correctly. Would you review that and assign the issue to me? This addresses bug HIVE-4561. https://issues.apache.org/jira/browse/HIVE-4561 Diffs (updated) - http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java 1488823 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/compute_stats_long.q.out 1488823 Diff: https://reviews.apache.org/r/11172/diff/ Testing --- Thanks, Zhuoluo Yang
Re: Review Request: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11172/ --- (Updated May 15, 2013, 7:11 a.m.) Review request for hive, Carl Steinbach, Carl Steinbach, and fangkun cao. Changes --- change bugs number. Description --- An initialization error. Make double and long initialize correctly. Would you review that and assign the issue to me? This addresses bug HIVE-4561. https://issues.apache.org/jira/browse/HIVE-4561 Diffs - http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java 1482697 Diff: https://reviews.apache.org/r/11172/diff/ Testing --- Thanks, Zhuoluo Yang
Review Request: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11172/ --- Review request for hive, Carl Steinbach, Carl Steinbach, and fangkun cao. Description --- An initialization error. Make double and long initialize correctly. Would you review that and assign the issue to me? Diffs - http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java 1482697 Diff: https://reviews.apache.org/r/11172/diff/ Testing --- Thanks, Zhuoluo Yang
Re: Review Request: Add 'show version' command to Hive CLI
> On Jan. 17, 2013, 1:55 a.m., Brock Noland wrote: > > Hi, Looks good! A few more comments below. "Sorry for ignorance of git > > and shamelessly cloning the code" - no worries :) if you didn't copy this > > I'd wonder why not! > > > > Also, FYI I am not a Hive committer. Thank you very much for your comments no matter whether you are a commiter or not. > On Jan. 17, 2013, 1:55 a.m., Brock Noland wrote: > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java, > > line 474 > > <https://reviews.apache.org/r/8958/diff/2/?file=248840#file248840line474> > > > > What is the purpose of this cast? Also, this will be closed in the > > finally, block, no? > > I think the cast is to remind (make sure) that we calls the correct method. And this kind of close are involved by HIVE-1884 to avoid potential risk of resource leaks in Hive, I think... - Zhuoluo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8958/#review15438 --- On Jan. 18, 2013, 6:28 a.m., Zhuoluo Yang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8958/ > --- > > (Updated Jan. 18, 2013, 6:28 a.m.) > > > Review request for hive, Carl Steinbach and Brock Noland. > > > Description > --- > > We add a simple ddl grammar, called "show version". > The version info is generated automatically while compiling. > > > This addresses bug HIVE-1151. > https://issues.apache.org/jira/browse/HIVE-1151 > > > Diffs > - > > http://svn.apache.org/repos/asf/hive/trunk/bin/ext/version.sh PRE-CREATION > http://svn.apache.org/repos/asf/hive/trunk/bin/hive 1435001 > http://svn.apache.org/repos/asf/hive/trunk/build.xml 1435001 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/HiveVersionAnnotation.java > PRE-CREATION > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java > 1435001 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 1435001 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g > 1435001 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java > 1435001 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java > 1435001 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ShowVersionDesc.java > PRE-CREATION > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/util/HiveVersionInfo.java > PRE-CREATION > http://svn.apache.org/repos/asf/hive/trunk/ql/src/saveVersion.sh > PRE-CREATION > > Diff: https://reviews.apache.org/r/8958/diff/ > > > Testing > --- > > zhuoluo@zhuoluo-Latitude-E6420:~$ hive --version > Hive 0.11.0-SNAPSHOT > Subversion git://github.com/apache/hive.git on branch trunk -r > 34c95e9e6ab2110653af20e6d34a8fe02b04198d > Compiled by zhuoluo on Wed Jan 16 12:26:12 CST 2013 > zhuoluo@zhuoluo-Latitude-E6420:~$ hive > Hive history > file=/tmp/zhuoluo/hive_job_log_zhuoluo_201301161232_1201027344.txt > hive> show version; > OK > 0.11.0-SNAPSHOT from 34c95e9e6ab2110653af20e6d34a8fe02b04198d by zhuoluo on > Wed Jan 16 12:26:12 CST 2013 > git://github.com/apache/hive.git on branch trunk > Time taken: 0.522 seconds, Fetched: 2 row(s) > hive> > > > Thanks, > > Zhuoluo Yang > >
Re: Review Request: Add 'show version' command to Hive CLI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8958/ --- (Updated Jan. 18, 2013, 6:28 a.m.) Review request for hive, Carl Steinbach and Brock Noland. Changes --- Another patch as Brock's comments. Description --- We add a simple ddl grammar, called "show version". The version info is generated automatically while compiling. This addresses bug HIVE-1151. https://issues.apache.org/jira/browse/HIVE-1151 Diffs (updated) - http://svn.apache.org/repos/asf/hive/trunk/bin/ext/version.sh PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/bin/hive 1435001 http://svn.apache.org/repos/asf/hive/trunk/build.xml 1435001 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/HiveVersionAnnotation.java PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1435001 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1435001 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1435001 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 1435001 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 1435001 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ShowVersionDesc.java PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/util/HiveVersionInfo.java PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/saveVersion.sh PRE-CREATION Diff: https://reviews.apache.org/r/8958/diff/ Testing --- zhuoluo@zhuoluo-Latitude-E6420:~$ hive --version Hive 0.11.0-SNAPSHOT Subversion git://github.com/apache/hive.git on branch trunk -r 34c95e9e6ab2110653af20e6d34a8fe02b04198d Compiled by zhuoluo on Wed Jan 16 12:26:12 CST 2013 zhuoluo@zhuoluo-Latitude-E6420:~$ hive Hive history file=/tmp/zhuoluo/hive_job_log_zhuoluo_201301161232_1201027344.txt hive> show version; OK 0.11.0-SNAPSHOT from 34c95e9e6ab2110653af20e6d34a8fe02b04198d by zhuoluo on Wed Jan 16 12:26:12 CST 2013 git://github.com/apache/hive.git on branch trunk Time taken: 0.522 seconds, Fetched: 2 row(s) hive> Thanks, Zhuoluo Yang
Re: Review Request: Add 'show version' command to Hive CLI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8958/ --- (Updated Jan. 16, 2013, 4:50 a.m.) Review request for hive, Carl Steinbach and Brock Noland. Changes --- Testing done by git repo Description --- We add a simple ddl grammar, called "show version". The version info is generated automatically while compiling. This addresses bug HIVE-1151. https://issues.apache.org/jira/browse/HIVE-1151 Diffs - http://svn.apache.org/repos/asf/hive/trunk/bin/ext/version.sh PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/bin/hive 1433285 http://svn.apache.org/repos/asf/hive/trunk/build.xml 1433285 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/HiveVersionAnnotation.java PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1433285 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1433285 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1433285 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 1433285 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 1433285 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ShowVersionDesc.java PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/util/HiveVersionInfo.java PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/saveVersion.sh PRE-CREATION Diff: https://reviews.apache.org/r/8958/diff/ Testing (updated) --- zhuoluo@zhuoluo-Latitude-E6420:~$ hive --version Hive 0.11.0-SNAPSHOT Subversion git://github.com/apache/hive.git on branch trunk -r 34c95e9e6ab2110653af20e6d34a8fe02b04198d Compiled by zhuoluo on Wed Jan 16 12:26:12 CST 2013 zhuoluo@zhuoluo-Latitude-E6420:~$ hive Hive history file=/tmp/zhuoluo/hive_job_log_zhuoluo_201301161232_1201027344.txt hive> show version; OK 0.11.0-SNAPSHOT from 34c95e9e6ab2110653af20e6d34a8fe02b04198d by zhuoluo on Wed Jan 16 12:26:12 CST 2013 git://github.com/apache/hive.git on branch trunk Time taken: 0.522 seconds, Fetched: 2 row(s) hive> Thanks, Zhuoluo Yang
Re: Review Request: Add 'show version' command to Hive CLI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8958/ --- (Updated Jan. 16, 2013, 4:44 a.m.) Review request for hive, Carl Steinbach and Brock Noland. Changes --- Thanks Brock. 1. Remove the code of eating the stack trace, so the Exception stack trace can be stringified by DDLTask.execute() 2. Sorry for ignorance of git and shamelessly cloning the code, modity saveVersion.sh to get git hostname. 3. Add a "hive --version" command. Description --- We add a simple ddl grammar, called "show version". The version info is generated automatically while compiling. This addresses bug HIVE-1151. https://issues.apache.org/jira/browse/HIVE-1151 Diffs (updated) - http://svn.apache.org/repos/asf/hive/trunk/bin/ext/version.sh PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/bin/hive 1433285 http://svn.apache.org/repos/asf/hive/trunk/build.xml 1433285 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/HiveVersionAnnotation.java PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1433285 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1433285 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1433285 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 1433285 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 1433285 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ShowVersionDesc.java PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/util/HiveVersionInfo.java PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/saveVersion.sh PRE-CREATION Diff: https://reviews.apache.org/r/8958/diff/ Testing --- $hive Hive history file=/tmp/zhuoluo/hive_job_log_zhuoluo_201301152113_1633688174.txt hive> show version; OK 0.11.0-SNAPSHOT from 1432865 by zhuoluo on Tue Jan 15 20:58:42 CST 2013 http://svn.apache.org/repos/asf/hive/trunk Time taken: 0.279 seconds, Fetched: 2 row(s) hive> Thanks, Zhuoluo Yang
Review Request: Add 'show version' command to Hive CLI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8958/ --- Review request for hive and Carl Steinbach. Description --- We add a simple ddl grammar, called "show version". The version info is generated automatically while compiling. This addresses bug HIVE-1151. https://issues.apache.org/jira/browse/HIVE-1151 Diffs - http://svn.apache.org/repos/asf/hive/trunk/build.xml 1433285 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/HiveVersionAnnotation.java PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1433285 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1433285 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1433285 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 1433285 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 1433285 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ShowVersionDesc.java PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/util/HiveVersionInfo.java PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/saveVersion.sh PRE-CREATION Diff: https://reviews.apache.org/r/8958/diff/ Testing --- $hive Hive history file=/tmp/zhuoluo/hive_job_log_zhuoluo_201301152113_1633688174.txt hive> show version; OK 0.11.0-SNAPSHOT from 1432865 by zhuoluo on Tue Jan 15 20:58:42 CST 2013 http://svn.apache.org/repos/asf/hive/trunk Time taken: 0.279 seconds, Fetched: 2 row(s) hive> Thanks, Zhuoluo Yang
Re: Review Request: HIVE-305: Port Hadoop streaming's counters/status reporters to Hive Transforms
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8936/ --- (Updated Jan. 12, 2013, 2:53 p.m.) Review request for hive, Carl Steinbach and Guo Hongjie. Changes --- remove branch label Description --- This is my friend Guo's patch. He asked me to help him to create a review request? @Carl, would you please review that for him? Thanks. This addresses bug HIVE-305. https://issues.apache.org/jira/browse/HIVE-305 Diffs - http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1431196 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 1431196 Diff: https://reviews.apache.org/r/8936/diff/ Testing --- Thanks, Zhuoluo Yang
Review Request: HIVE-305: Port Hadoop streaming's counters/status reporters to Hive Transforms
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8936/ --- Review request for hive, Carl Steinbach and Guo Hongjie. Description --- This is my friend Guo's patch. He asked me to help him to create a review request? @Carl, would you please review that for him? Thanks. This addresses bug HIVE-305. https://issues.apache.org/jira/browse/HIVE-305 Diffs - http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1431196 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 1431196 Diff: https://reviews.apache.org/r/8936/diff/ Testing --- Thanks, Zhuoluo Yang
Re: Review Request: HIVE-2227 Remove ProgressCounter enum in Operator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/931/ --- (Updated 2011-06-17 02:49:48.793536) Review request for hive and Yongqiang He. Changes --- update bugs number Summary --- After HIVE-1701, it is of no use to keep a heavy counterNameToEnum hashmap. We can use string directly, for the enum is only a hack for hadoop 0.17. The string will be human readable in the jobdetails.jsp instead of C1, C2, ... C1000. This addresses bug HIVE-2227. https://issues.apache.org/jira/browse/HIVE-2227 Diffs - http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1136381 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java 1136381 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 1136381 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 1136381 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 1136381 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java 1136381 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1136381 Diff: https://reviews.apache.org/r/931/diff Testing --- Thanks, Zhuoluo
Review Request: HIVE-2227 Remove ProgressCounter enum in Operator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/931/ --- Review request for hive and Yongqiang He. Summary --- After HIVE-1701, it is of no use to keep a heavy counterNameToEnum hashmap. We can use string directly, for the enum is only a hack for hadoop 0.17. The string will be human readable in the jobdetails.jsp instead of C1, C2, ... C1000. This addresses bug 2227. https://issues.apache.org/jira/browse/2227 Diffs - http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1136381 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java 1136381 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 1136381 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 1136381 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 1136381 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java 1136381 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1136381 Diff: https://reviews.apache.org/r/931/diff Testing --- Thanks, Zhuoluo
