[jira] [Commented] (HIVE-2838) cleanup readentity/writeentity
[ https://issues.apache.org/jira/browse/HIVE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13548093#comment-13548093 ] Hudson commented on HIVE-2838: -- Integrated in Hive-trunk-hadoop2 #54 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/54/]) HIVE-2838. cleanup readentity/writeentity. (namit via kevinwilfong) (Revision 1298699) Result = ABORTED kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1298699 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/ReadEntity.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java cleanup readentity/writeentity -- Key: HIVE-2838 URL: https://issues.apache.org/jira/browse/HIVE-2838 Project: Hive Issue Type: Bug Reporter: Namit Jain Assignee: Namit Jain Fix For: 0.9.0 Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2838.D2193.1.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2838.D2193.2.patch Ideally, there should be one common entity instead of readentity/writeentity. Unfortunately, that would be a backward incompatible change since users os hive might have written there own hooks, where they are using readentity/writeentity. We should atleast create a common class, and then we can deprecate read/write entity later, for a new release. For now, I propose to make a backward compatible change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2838) cleanup readentity/writeentity
[ https://issues.apache.org/jira/browse/HIVE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266277#comment-13266277 ] Phabricator commented on HIVE-2838: --- njain has abandoned the revision HIVE-2838 [jira] cleanup readentity/writeentity. REVISION DETAIL https://reviews.facebook.net/D2193 cleanup readentity/writeentity -- Key: HIVE-2838 URL: https://issues.apache.org/jira/browse/HIVE-2838 Project: Hive Issue Type: Bug Reporter: Namit Jain Assignee: Namit Jain Fix For: 0.9.0 Attachments: HIVE-2838.D2193.1.patch, HIVE-2838.D2193.2.patch Ideally, there should be one common entity instead of readentity/writeentity. Unfortunately, that would be a backward incompatible change since users os hive might have written there own hooks, where they are using readentity/writeentity. We should atleast create a common class, and then we can deprecate read/write entity later, for a new release. For now, I propose to make a backward compatible change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2838) cleanup readentity/writeentity
[ https://issues.apache.org/jira/browse/HIVE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226007#comment-13226007 ] Hudson commented on HIVE-2838: -- Integrated in Hive-trunk-h0.21 #1300 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1300/]) HIVE-2838. cleanup readentity/writeentity. (namit via kevinwilfong) (Revision 1298699) Result = FAILURE kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1298699 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/ReadEntity.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java cleanup readentity/writeentity -- Key: HIVE-2838 URL: https://issues.apache.org/jira/browse/HIVE-2838 Project: Hive Issue Type: Bug Reporter: Namit Jain Assignee: Namit Jain Fix For: 0.9.0 Attachments: HIVE-2838.D2193.1.patch, HIVE-2838.D2193.2.patch Ideally, there should be one common entity instead of readentity/writeentity. Unfortunately, that would be a backward incompatible change since users os hive might have written there own hooks, where they are using readentity/writeentity. We should atleast create a common class, and then we can deprecate read/write entity later, for a new release. For now, I propose to make a backward compatible change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2838) cleanup readentity/writeentity
[ https://issues.apache.org/jira/browse/HIVE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225441#comment-13225441 ] Phabricator commented on HIVE-2838: --- kevinwilfong has requested changes to the revision HIVE-2838 [jira] cleanup readentity/writeentity. The code looks good. Noticed a few relics left over from WriteEntity in the comments in Entity. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:30-31 Could you fix this comment. ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:37 This one too. ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:70 Could you split this into two. ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:133 Could you change written to to accessed or something like that. ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:152 here too. ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:180 here too. REVISION DETAIL https://reviews.facebook.net/D2193 BRANCH svn cleanup readentity/writeentity -- Key: HIVE-2838 URL: https://issues.apache.org/jira/browse/HIVE-2838 Project: Hive Issue Type: Bug Reporter: Namit Jain Assignee: Namit Jain Attachments: HIVE-2838.D2193.1.patch Ideally, there should be one common entity instead of readentity/writeentity. Unfortunately, that would be a backward incompatible change since users os hive might have written there own hooks, where they are using readentity/writeentity. We should atleast create a common class, and then we can deprecate read/write entity later, for a new release. For now, I propose to make a backward compatible change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2838) cleanup readentity/writeentity
[ https://issues.apache.org/jira/browse/HIVE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225622#comment-13225622 ] Phabricator commented on HIVE-2838: --- kevinwilfong has accepted the revision HIVE-2838 [jira] cleanup readentity/writeentity. +1 Will commit after tests pass. REVISION DETAIL https://reviews.facebook.net/D2193 BRANCH svn cleanup readentity/writeentity -- Key: HIVE-2838 URL: https://issues.apache.org/jira/browse/HIVE-2838 Project: Hive Issue Type: Bug Reporter: Namit Jain Assignee: Namit Jain Attachments: HIVE-2838.D2193.1.patch, HIVE-2838.D2193.2.patch Ideally, there should be one common entity instead of readentity/writeentity. Unfortunately, that would be a backward incompatible change since users os hive might have written there own hooks, where they are using readentity/writeentity. We should atleast create a common class, and then we can deprecate read/write entity later, for a new release. For now, I propose to make a backward compatible change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2838) cleanup readentity/writeentity
[ https://issues.apache.org/jira/browse/HIVE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13222760#comment-13222760 ] Ashutosh Chauhan commented on HIVE-2838: @Namit, Can you briefly explain why there should be one common entity instead of read/write entity? cleanup readentity/writeentity -- Key: HIVE-2838 URL: https://issues.apache.org/jira/browse/HIVE-2838 Project: Hive Issue Type: Bug Reporter: Namit Jain Assignee: Namit Jain Ideally, there should be one common entity instead of readentity/writeentity. Unfortunately, that would be a backward incompatible change since users os hive might have written there own hooks, where they are using readentity/writeentity. We should atleast create a common class, and then we can deprecate read/write entity later, for a new release. For now, I propose to make a backward compatible change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
