[jira] [Commented] (HIVE-6017) Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive
[ https://issues.apache.org/jira/browse/HIVE-6017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861701#comment-13861701 ] Eric Hanson commented on HIVE-6017: --- I don't think this needs end-user documentation. This is an internal performance enhancement. The user-visible type system won't change. Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive --- Key: HIVE-6017 URL: https://issues.apache.org/jira/browse/HIVE-6017 Project: Hive Issue Type: Sub-task Affects Versions: 0.13.0 Reporter: Eric Hanson Assignee: Eric Hanson Fix For: 0.13.0 Attachments: HIVE-6017.01.patch, HIVE-6017.02.patch, HIVE-6017.03.patch, HIVE-6017.04.patch Contribute the Decimal128 high-performance decimal package developed by Microsoft to Hive. This was originally written for Microsoft PolyBase by Hideaki Kimura. This code is about 8X more efficient than Java BigDecimal for typical operations. It uses a finite (128 bit) precision and can handle up to decimal(38, X). It is also mutable so you can change the contents of an existing object. This helps reduce the cost of new() and garbage collection. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-6017) Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive
[ https://issues.apache.org/jira/browse/HIVE-6017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862044#comment-13862044 ] Lefty Leverenz commented on HIVE-6017: -- Okay, thanks Eric. Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive --- Key: HIVE-6017 URL: https://issues.apache.org/jira/browse/HIVE-6017 Project: Hive Issue Type: Sub-task Affects Versions: 0.13.0 Reporter: Eric Hanson Assignee: Eric Hanson Fix For: 0.13.0 Attachments: HIVE-6017.01.patch, HIVE-6017.02.patch, HIVE-6017.03.patch, HIVE-6017.04.patch Contribute the Decimal128 high-performance decimal package developed by Microsoft to Hive. This was originally written for Microsoft PolyBase by Hideaki Kimura. This code is about 8X more efficient than Java BigDecimal for typical operations. It uses a finite (128 bit) precision and can handle up to decimal(38, X). It is also mutable so you can change the contents of an existing object. This helps reduce the cost of new() and garbage collection. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-6017) Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive
[ https://issues.apache.org/jira/browse/HIVE-6017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860859#comment-13860859 ] Eric Hanson commented on HIVE-6017: --- I checked up on this. Microsoft has signed the Apache Corporate Contributor License Agreement (CCLA) and the people who wrote the code signed the Apache ICLA. These agreements plus the copyright notice in the code cover the situation. Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive --- Key: HIVE-6017 URL: https://issues.apache.org/jira/browse/HIVE-6017 Project: Hive Issue Type: Sub-task Affects Versions: 0.13.0 Reporter: Eric Hanson Assignee: Eric Hanson Attachments: HIVE-6017.01.patch, HIVE-6017.02.patch, HIVE-6017.03.patch, HIVE-6017.04.patch Contribute the Decimal128 high-performance decimal package developed by Microsoft to Hive. This was originally written for Microsoft PolyBase by Hideaki Kimura. This code is about 8X more efficient than Java BigDecimal for typical operations. It uses a finite (128 bit) precision and can handle up to decimal(38, X). It is also mutable so you can change the contents of an existing object. This helps reduce the cost of new() and garbage collection. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-6017) Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive
[ https://issues.apache.org/jira/browse/HIVE-6017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861085#comment-13861085 ] Lefty Leverenz commented on HIVE-6017: -- What documentation does this need -- just add DECIMAL128 to the list of types with a brief explanation? * [Numeric Types|https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Types#LanguageManualTypes-NumericTypes] * [Decimals|https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Types#LanguageManualTypes-Decimals] * [Floating Point Types|https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=27838462#LanguageManualTypes-FloatingPointTypes] Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive --- Key: HIVE-6017 URL: https://issues.apache.org/jira/browse/HIVE-6017 Project: Hive Issue Type: Sub-task Affects Versions: 0.13.0 Reporter: Eric Hanson Assignee: Eric Hanson Fix For: 0.13.0 Attachments: HIVE-6017.01.patch, HIVE-6017.02.patch, HIVE-6017.03.patch, HIVE-6017.04.patch Contribute the Decimal128 high-performance decimal package developed by Microsoft to Hive. This was originally written for Microsoft PolyBase by Hideaki Kimura. This code is about 8X more efficient than Java BigDecimal for typical operations. It uses a finite (128 bit) precision and can handle up to decimal(38, X). It is also mutable so you can change the contents of an existing object. This helps reduce the cost of new() and garbage collection. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-6017) Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive
[ https://issues.apache.org/jira/browse/HIVE-6017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859172#comment-13859172 ] Jitendra Nath Pandey commented on HIVE-6017: The code looks good to me. +1 It seems the copywrite needs to be mentioned in the NOTICE file as well, although I am not an expert on these rules. Please also refer to http://www.apache.org/licenses/ to comply with the guidelines when submitting code with employer copywrite or third-party code. Does it require a Software Grant Agreement (SGA) with PMC? Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive --- Key: HIVE-6017 URL: https://issues.apache.org/jira/browse/HIVE-6017 Project: Hive Issue Type: Sub-task Affects Versions: 0.13.0 Reporter: Eric Hanson Assignee: Eric Hanson Attachments: HIVE-6017.01.patch, HIVE-6017.02.patch, HIVE-6017.03.patch, HIVE-6017.04.patch Contribute the Decimal128 high-performance decimal package developed by Microsoft to Hive. This was originally written for Microsoft PolyBase by Hideaki Kimura. This code is about 8X more efficient than Java BigDecimal for typical operations. It uses a finite (128 bit) precision and can handle up to decimal(38, X). It is also mutable so you can change the contents of an existing object. This helps reduce the cost of new() and garbage collection. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-6017) Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive
[ https://issues.apache.org/jira/browse/HIVE-6017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849901#comment-13849901 ] Eric Hanson commented on HIVE-6017: --- Code review available at https://reviews.apache.org/r/16307/ Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive --- Key: HIVE-6017 URL: https://issues.apache.org/jira/browse/HIVE-6017 Project: Hive Issue Type: Sub-task Affects Versions: 0.13.0 Reporter: Eric Hanson Assignee: Eric Hanson Attachments: HIVE-6017.01.patch Contribute the Decimal128 high-performance decimal package developed by Microsoft to Hive. This was originally written for Microsoft PolyBase by Hideaki Kimura. This code is about 8X more efficient than Java BigDecimal for typical operations. It uses a finite (128 bit) precision and can handle up to decimal(38, X). It is also mutable so you can change the contents of an existing object. This helps reduce the cost of new() and garbage collection. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HIVE-6017) Contribute Decimal128 high-performance decimal(p, s) package from Microsoft to Hive
[
https://issues.apache.org/jira/browse/HIVE-6017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13850047#comment-13850047
]
Hive QA commented on HIVE-6017:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12619021/HIVE-6017.04.patch
{color:green}SUCCESS:{color} +1 4840 tests passed
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/662/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/662/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12619021
Contribute Decimal128 high-performance decimal(p, s) package from Microsoft
to Hive
---
Key: HIVE-6017
URL: https://issues.apache.org/jira/browse/HIVE-6017
Project: Hive
Issue Type: Sub-task
Affects Versions: 0.13.0
Reporter: Eric Hanson
Assignee: Eric Hanson
Attachments: HIVE-6017.01.patch, HIVE-6017.02.patch,
HIVE-6017.03.patch, HIVE-6017.04.patch
Contribute the Decimal128 high-performance decimal package developed by
Microsoft to Hive. This was originally written for Microsoft PolyBase by
Hideaki Kimura.
This code is about 8X more efficient than Java BigDecimal for typical
operations. It uses a finite (128 bit) precision and can handle up to
decimal(38, X). It is also mutable so you can change the contents of an
existing object. This helps reduce the cost of new() and garbage collection.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
