[jira] [Commented] (HIVE-9004) Reset doesn't work for the default empty value entry
[
https://issues.apache.org/jira/browse/HIVE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253857#comment-14253857
]
Thejas M Nair commented on HIVE-9004:
-
Yes, I agree this is not very intrusive behavior change, not many users are
likely to see issues because of this. I think documenting it should be OK.
However, some comments regarding the patch -
1. I think we should include a unit test for this.
2. I don't think the change would work. The properties object returned is a
copy, it won't update the HiveConf -
In HiveConf.java -
{code}
public Properties getAllProperties() {
return getProperties(this);
}
private static Properties getProperties(Configuration conf) {
IteratorMap.EntryString, String iter = conf.iterator();
Properties p = new Properties();
while (iter.hasNext()) {
Map.EntryString, String e = iter.next();
p.setProperty(e.getKey(), e.getValue());
}
return p;
}
{code}
Reset doesn't work for the default empty value entry
Key: HIVE-9004
URL: https://issues.apache.org/jira/browse/HIVE-9004
Project: Hive
Issue Type: Bug
Components: Configuration
Reporter: Cheng Hao
Assignee: Cheng Hao
Fix For: spark-branch, 0.15.0, 0.14.1
Attachments: HIVE-9004.patch
To illustrate that:
In hive cli:
hive set hive.table.parameters.default;
hive.table.parameters.default is undefined
hive set hive.table.parameters.default=key1=value1;
hive reset;
hive set hive.table.parameters.default;
hive.table.parameters.default=key1=value1
I think we expect the last output as hive.table.parameters.default is
undefined
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-9004) Reset doesn't work for the default empty value entry
[ https://issues.apache.org/jira/browse/HIVE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253888#comment-14253888 ] Szehon Ho commented on HIVE-9004: - Ah, thanks for catching that. Reset doesn't work for the default empty value entry Key: HIVE-9004 URL: https://issues.apache.org/jira/browse/HIVE-9004 Project: Hive Issue Type: Bug Components: Configuration Reporter: Cheng Hao Assignee: Cheng Hao Fix For: spark-branch, 0.15.0, 0.14.1 Attachments: HIVE-9004.patch To illustrate that: In hive cli: hive set hive.table.parameters.default; hive.table.parameters.default is undefined hive set hive.table.parameters.default=key1=value1; hive reset; hive set hive.table.parameters.default; hive.table.parameters.default=key1=value1 I think we expect the last output as hive.table.parameters.default is undefined -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9004) Reset doesn't work for the default empty value entry
[ https://issues.apache.org/jira/browse/HIVE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253974#comment-14253974 ] Brock Noland commented on HIVE-9004: bq. Yes, I agree this is not very intrusive behavior change, not many users are likely to see issues because of this. I think documenting it should be OK. +1 Reset doesn't work for the default empty value entry Key: HIVE-9004 URL: https://issues.apache.org/jira/browse/HIVE-9004 Project: Hive Issue Type: Bug Components: Configuration Reporter: Cheng Hao Assignee: Cheng Hao Fix For: spark-branch, 0.15.0, 0.14.1 Attachments: HIVE-9004.patch To illustrate that: In hive cli: hive set hive.table.parameters.default; hive.table.parameters.default is undefined hive set hive.table.parameters.default=key1=value1; hive reset; hive set hive.table.parameters.default; hive.table.parameters.default=key1=value1 I think we expect the last output as hive.table.parameters.default is undefined -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9004) Reset doesn't work for the default empty value entry
[
https://issues.apache.org/jira/browse/HIVE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14251401#comment-14251401
]
Hive QA commented on HIVE-9004:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12687952/HIVE-9004.patch
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 6714 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_optimize_nullscan
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2123/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2123/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2123/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12687952 - PreCommit-HIVE-TRUNK-Build
Reset doesn't work for the default empty value entry
Key: HIVE-9004
URL: https://issues.apache.org/jira/browse/HIVE-9004
Project: Hive
Issue Type: Bug
Components: Configuration
Reporter: Cheng Hao
Assignee: Cheng Hao
Fix For: spark-branch, 0.15.0, 0.14.1
Attachments: HIVE-9004.patch
To illustrate that:
In hive cli:
hive set hive.table.parameters.default;
hive.table.parameters.default is undefined
hive set hive.table.parameters.default=key1=value1;
hive reset;
hive set hive.table.parameters.default;
hive.table.parameters.default=key1=value1
I think we expect the last output as hive.table.parameters.default is
undefined
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-9004) Reset doesn't work for the default empty value entry
[ https://issues.apache.org/jira/browse/HIVE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14252047#comment-14252047 ] Szehon Ho commented on HIVE-9004: - Thanks. Looks good to me, +1 Reset doesn't work for the default empty value entry Key: HIVE-9004 URL: https://issues.apache.org/jira/browse/HIVE-9004 Project: Hive Issue Type: Bug Components: Configuration Reporter: Cheng Hao Assignee: Cheng Hao Fix For: spark-branch, 0.15.0, 0.14.1 Attachments: HIVE-9004.patch To illustrate that: In hive cli: hive set hive.table.parameters.default; hive.table.parameters.default is undefined hive set hive.table.parameters.default=key1=value1; hive reset; hive set hive.table.parameters.default; hive.table.parameters.default=key1=value1 I think we expect the last output as hive.table.parameters.default is undefined -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9004) Reset doesn't work for the default empty value entry
[ https://issues.apache.org/jira/browse/HIVE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14251138#comment-14251138 ] Cheng Hao commented on HIVE-9004: - Thank you [~szehon], updated. Reset doesn't work for the default empty value entry Key: HIVE-9004 URL: https://issues.apache.org/jira/browse/HIVE-9004 Project: Hive Issue Type: Bug Components: Configuration Reporter: Cheng Hao Assignee: Cheng Hao Fix For: spark-branch, 0.15.0, 0.14.1 Attachments: HIVE-9004.patch To illustrate that: In hive cli: hive set hive.table.parameters.default; hive.table.parameters.default is undefined hive set hive.table.parameters.default=key1=value1; hive reset; hive set hive.table.parameters.default; hive.table.parameters.default=key1=value1 I think we expect the last output as hive.table.parameters.default is undefined -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9004) Reset doesn't work for the default empty value entry
[ https://issues.apache.org/jira/browse/HIVE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231670#comment-14231670 ] Cheng Hao commented on HIVE-9004: - [~namit] sorry, I am not sure the review process, can you review this for me please? Reset doesn't work for the default empty value entry Key: HIVE-9004 URL: https://issues.apache.org/jira/browse/HIVE-9004 Project: Hive Issue Type: Bug Components: Configuration Reporter: Cheng Hao Assignee: Cheng Hao Fix For: spark-branch, 0.15.0, 0.14.1 Attachments: reset.patch To illustrate that: In hive cli: hive set hive.table.parameters.default; hive.table.parameters.default is undefined hive set hive.table.parameters.default=key1=value1; hive reset; hive set hive.table.parameters.default; hive.table.parameters.default=key1=value1 I think we expect the last output as hive.table.parameters.default is undefined -- This message was sent by Atlassian JIRA (v6.3.4#6332)
