Re: Review Request 71243: HIVE-21875: Implement drop partition related methods on temporary tables.

2019-09-16 Thread Laszlo Pinter via Review Board 


> On Sept. 16, 2019, 11:24 a.m., Gergely Hankó wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java
> > Lines 948-952 (patched)
> > 
> >
> > This can be simplified to:
> > `return tableParameters != null && 
> > "true".equals(tableParameters.get(EXTERNAL_PARAM));`
> > 
> > It is more compact and also spares a query on the map.

Did the change. Thanks for the review.


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71243/#review217753
---


On Sept. 16, 2019, 12:39 p.m., Laszlo Pinter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71243/
> ---
> 
> (Updated Sept. 16, 2019, 12:39 p.m.)
> 
> 
> Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-21875: Implement drop partition related methods on temporary tables.
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java
>  a2c84b4620fb1eb90069e294204f604565ffed9b 
>   
> ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientDropPartitionsTempTable.java
>  PRE-CREATION 
>   
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestDropPartitions.java
>  91c9edac95e9f9688dd2b806aeeb0823af02574f 
> 
> 
> Diff: https://reviews.apache.org/r/71243/diff/2/
> 
> 
> Testing
> ---
> 
> Unit testing is done via 
> TestSessionHiveMetastoreClientDropPartitionsTempTable.java
> 
> 
> Thanks,
> 
> Laszlo Pinter
> 
>

Re: Review Request 71243: HIVE-21875: Implement drop partition related methods on temporary tables.

2019-09-16 Thread Laszlo Pinter via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71243/
---

(Updated Sept. 16, 2019, 12:39 p.m.)


Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita.


Repository: hive-git


Description (updated)
---

HIVE-21875: Implement drop partition related methods on temporary tables.


Diffs (updated)
-

  
ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java 
a2c84b4620fb1eb90069e294204f604565ffed9b 
  
ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientDropPartitionsTempTable.java
 PRE-CREATION 
  
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestDropPartitions.java
 91c9edac95e9f9688dd2b806aeeb0823af02574f 


Diff: https://reviews.apache.org/r/71243/diff/2/

Changes: https://reviews.apache.org/r/71243/diff/1-2/


Testing
---

Unit testing is done via 
TestSessionHiveMetastoreClientDropPartitionsTempTable.java


Thanks,

Laszlo Pinter

Re: Review Request 71243: HIVE-21875: Implement drop partition related methods on temporary tables.

2019-09-16 Thread Gergely Hankó via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71243/#review217753
---




ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java
Lines 948-952 (patched)


This can be simplified to:
`return tableParameters != null && 
"true".equals(tableParameters.get(EXTERNAL_PARAM));`

It is more compact and also spares a query on the map.


- Gergely Hankó


On aug. 7, 2019, 8:35 de, Laszlo Pinter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71243/
> ---
> 
> (Updated aug. 7, 2019, 8:35 de)
> 
> 
> Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-21875: Implement drop partition related methods on temporary tables.
> 
> This is one of the subtasks for HIVE-21765, to support partitions on 
> temporary tables.
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java
>  a2c84b4620fb1eb90069e294204f604565ffed9b 
>   
> ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientDropPartitionsTempTable.java
>  PRE-CREATION 
>   
> service/src/java/org/apache/hive/service/cli/thrift/ThreadPoolExecutorWithOomHook.java
>  129413681045d790ae20bf4d8060f04162224565 
>   
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestDropPartitions.java
>  91c9edac95e9f9688dd2b806aeeb0823af02574f 
> 
> 
> Diff: https://reviews.apache.org/r/71243/diff/1/
> 
> 
> Testing
> ---
> 
> Unit testing is done via 
> TestSessionHiveMetastoreClientDropPartitionsTempTable.java
> 
> 
> Thanks,
> 
> Laszlo Pinter
> 
>

Re: Review Request 71243: HIVE-21875: Implement drop partition related methods on temporary tables.

2019-09-16 Thread Peter Vary via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71243/#review217752
---



Fix it and ship it


ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java
Lines 1524-1529 (patched)


Please move these check after the assertTempTablePartitioned



ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientDropPartitionsTempTable.java
Lines 139-144 (patched)


Please ensure that for Temp table we are working in the same way than for 
normal tables



service/src/java/org/apache/hive/service/cli/thrift/ThreadPoolExecutorWithOomHook.java
Line 57 (original)


Please check this change


- Peter Vary


On aug. 7, 2019, 8:35 de, Laszlo Pinter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71243/
> ---
> 
> (Updated aug. 7, 2019, 8:35 de)
> 
> 
> Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-21875: Implement drop partition related methods on temporary tables.
> 
> This is one of the subtasks for HIVE-21765, to support partitions on 
> temporary tables.
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java
>  a2c84b4620fb1eb90069e294204f604565ffed9b 
>   
> ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientDropPartitionsTempTable.java
>  PRE-CREATION 
>   
> service/src/java/org/apache/hive/service/cli/thrift/ThreadPoolExecutorWithOomHook.java
>  129413681045d790ae20bf4d8060f04162224565 
>   
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestDropPartitions.java
>  91c9edac95e9f9688dd2b806aeeb0823af02574f 
> 
> 
> Diff: https://reviews.apache.org/r/71243/diff/1/
> 
> 
> Testing
> ---
> 
> Unit testing is done via 
> TestSessionHiveMetastoreClientDropPartitionsTempTable.java
> 
> 
> Thanks,
> 
> Laszlo Pinter
> 
>