Review Request 37620: Hive Parser to Support multi col in clause (x, y..) in ((..), ..., ())

2015-08-19 Thread pengcheng xiong 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37620/
---

Review request for hive and John Pullokkaran.


Repository: hive-git


Description
---

Current hive only support single column in clause, e.g., 
{code}select * from src where  col0 in (v1,v2,v3);{code}
We want it to support 
{code}select * from src where (col0,col1+3) in 
((col0+v1,v2),(v3,v4-col1));{code}


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 64af7d1 
  ql/src/test/queries/clientpositive/multi_column_in.q PRE-CREATION 
  ql/src/test/results/clientpositive/multi_column_in.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/37620/diff/


Testing
---


Thanks,

pengcheng xiong

Re: Review Request 37620: Hive Parser to Support multi col in clause (x, y..) in ((..), ..., ())

2015-08-21 Thread pengcheng xiong 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37620/
---

(Updated Aug. 21, 2015, 10:07 p.m.)


Review request for hive and John Pullokkaran.


Repository: hive-git


Description
---

Current hive only support single column in clause, e.g., 
{code}select * from src where  col0 in (v1,v2,v3);{code}
We want it to support 
{code}select * from src where (col0,col1+3) in 
((col0+v1,v2),(v3,v4-col1));{code}


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 64af7d1 
  
ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsNegative.java
 61b5892 
  
ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsPositive.java
 4c84e91 
  ql/src/test/queries/clientpositive/char_udf1.q 8848609 
  ql/src/test/queries/clientpositive/multi_column_in.q PRE-CREATION 
  ql/src/test/queries/clientpositive/varchar_udf1.q 395fb12 
  ql/src/test/results/clientpositive/char_udf1.q.java1.7.out ced0132 
  ql/src/test/results/clientpositive/multi_column_in.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/varchar_udf1.q.java1.7.out 96ba06e 

Diff: https://reviews.apache.org/r/37620/diff/


Testing
---


Thanks,

pengcheng xiong

Re: Review Request 37620: Hive Parser to Support multi col in clause (x, y..) in ((..), ..., ())

2015-08-24 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37620/#review96264
---



ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (line 475)


How about (x,y) in (select a,b from t)


- John Pullokkaran


On Aug. 21, 2015, 10:07 p.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37620/
> ---
> 
> (Updated Aug. 21, 2015, 10:07 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Current hive only support single column in clause, e.g., 
> {code}select * from src where  col0 in (v1,v2,v3);{code}
> We want it to support 
> {code}select * from src where (col0,col1+3) in 
> ((col0+v1,v2),(v3,v4-col1));{code}
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 64af7d1 
>   
> ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsNegative.java
>  61b5892 
>   
> ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsPositive.java
>  4c84e91 
>   ql/src/test/queries/clientpositive/char_udf1.q 8848609 
>   ql/src/test/queries/clientpositive/multi_column_in.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/varchar_udf1.q 395fb12 
>   ql/src/test/results/clientpositive/char_udf1.q.java1.7.out ced0132 
>   ql/src/test/results/clientpositive/multi_column_in.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/varchar_udf1.q.java1.7.out 96ba06e 
> 
> Diff: https://reviews.apache.org/r/37620/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>

Re: Review Request 37620: Hive Parser to Support multi col in clause (x, y..) in ((..), ..., ())

2015-08-31 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37620/#review97121
---



ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (line 434)


Nit pick


- John Pullokkaran


On Aug. 21, 2015, 10:07 p.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37620/
> ---
> 
> (Updated Aug. 21, 2015, 10:07 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Current hive only support single column in clause, e.g., 
> {code}select * from src where  col0 in (v1,v2,v3);{code}
> We want it to support 
> {code}select * from src where (col0,col1+3) in 
> ((col0+v1,v2),(v3,v4-col1));{code}
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 64af7d1 
>   
> ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsNegative.java
>  61b5892 
>   
> ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsPositive.java
>  4c84e91 
>   ql/src/test/queries/clientpositive/char_udf1.q 8848609 
>   ql/src/test/queries/clientpositive/multi_column_in.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/varchar_udf1.q 395fb12 
>   ql/src/test/results/clientpositive/char_udf1.q.java1.7.out ced0132 
>   ql/src/test/results/clientpositive/multi_column_in.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/varchar_udf1.q.java1.7.out 96ba06e 
> 
> Diff: https://reviews.apache.org/r/37620/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>

Re: Review Request 37620: Hive Parser to Support multi col in clause (x, y..) in ((..), ..., ())

2015-08-31 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37620/#review97123
---



ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (line 481)


We need to be backwards compatible.



ql/src/test/queries/clientpositive/multi_column_in.q (line 28)


Add a test that has expressions on two columns


- John Pullokkaran


On Aug. 21, 2015, 10:07 p.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37620/
> ---
> 
> (Updated Aug. 21, 2015, 10:07 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Current hive only support single column in clause, e.g., 
> {code}select * from src where  col0 in (v1,v2,v3);{code}
> We want it to support 
> {code}select * from src where (col0,col1+3) in 
> ((col0+v1,v2),(v3,v4-col1));{code}
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 64af7d1 
>   
> ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsNegative.java
>  61b5892 
>   
> ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsPositive.java
>  4c84e91 
>   ql/src/test/queries/clientpositive/char_udf1.q 8848609 
>   ql/src/test/queries/clientpositive/multi_column_in.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/varchar_udf1.q 395fb12 
>   ql/src/test/results/clientpositive/char_udf1.q.java1.7.out ced0132 
>   ql/src/test/results/clientpositive/multi_column_in.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/varchar_udf1.q.java1.7.out 96ba06e 
> 
> Diff: https://reviews.apache.org/r/37620/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>

Re: Review Request 37620: Hive Parser to Support multi col in clause (x, y..) in ((..), ..., ())

2015-08-31 Thread pengcheng xiong 


> On Aug. 25, 2015, 1:17 a.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g, line 475
> > 
> >
> > How about (x,y) in (select a,b from t)

We are going to support this in the next phase.


- pengcheng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37620/#review96264
---


On Aug. 21, 2015, 10:07 p.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37620/
> ---
> 
> (Updated Aug. 21, 2015, 10:07 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Current hive only support single column in clause, e.g., 
> {code}select * from src where  col0 in (v1,v2,v3);{code}
> We want it to support 
> {code}select * from src where (col0,col1+3) in 
> ((col0+v1,v2),(v3,v4-col1));{code}
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 64af7d1 
>   
> ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsNegative.java
>  61b5892 
>   
> ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsPositive.java
>  4c84e91 
>   ql/src/test/queries/clientpositive/char_udf1.q 8848609 
>   ql/src/test/queries/clientpositive/multi_column_in.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/varchar_udf1.q 395fb12 
>   ql/src/test/results/clientpositive/char_udf1.q.java1.7.out ced0132 
>   ql/src/test/results/clientpositive/multi_column_in.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/varchar_udf1.q.java1.7.out 96ba06e 
> 
> Diff: https://reviews.apache.org/r/37620/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>

Re: Review Request 37620: Hive Parser to Support multi col in clause (x, y..) in ((..), ..., ())

2015-08-31 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37620/#review97207
---



ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (line 475)


phase 4? :)


- Sergey Shelukhin


On Aug. 21, 2015, 10:07 p.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37620/
> ---
> 
> (Updated Aug. 21, 2015, 10:07 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Current hive only support single column in clause, e.g., 
> {code}select * from src where  col0 in (v1,v2,v3);{code}
> We want it to support 
> {code}select * from src where (col0,col1+3) in 
> ((col0+v1,v2),(v3,v4-col1));{code}
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 64af7d1 
>   
> ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsNegative.java
>  61b5892 
>   
> ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsPositive.java
>  4c84e91 
>   ql/src/test/queries/clientpositive/char_udf1.q 8848609 
>   ql/src/test/queries/clientpositive/multi_column_in.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/varchar_udf1.q 395fb12 
>   ql/src/test/results/clientpositive/char_udf1.q.java1.7.out ced0132 
>   ql/src/test/results/clientpositive/multi_column_in.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/varchar_udf1.q.java1.7.out 96ba06e 
> 
> Diff: https://reviews.apache.org/r/37620/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>

Re: Review Request 37620: Hive Parser to Support multi col in clause (x, y..) in ((..), ..., ())

2015-08-31 Thread pengcheng xiong 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37620/
---

(Updated Sept. 1, 2015, midnight)


Review request for hive and John Pullokkaran.


Changes
---

Address all of John's comments.


Repository: hive-git


Description
---

Current hive only support single column in clause, e.g., 
{code}select * from src where  col0 in (v1,v2,v3);{code}
We want it to support 
{code}select * from src where (col0,col1+3) in 
((col0+v1,v2),(v3,v4-col1));{code}


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 64af7d1 
  
ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsNegative.java
 61b5892 
  
ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsPositive.java
 4c84e91 
  ql/src/test/queries/clientpositive/char_udf1.q 8848609 
  ql/src/test/queries/clientpositive/keyword_2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/multi_column_in.q PRE-CREATION 
  ql/src/test/queries/clientpositive/varchar_udf1.q 395fb12 
  ql/src/test/results/clientpositive/char_udf1.q.java1.7.out ced0132 
  ql/src/test/results/clientpositive/keyword_2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/multi_column_in.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/varchar_udf1.q.java1.7.out 96ba06e 

Diff: https://reviews.apache.org/r/37620/diff/


Testing
---


Thanks,

pengcheng xiong

Re: Review Request 37620: Hive Parser to Support multi col in clause (x, y..) in ((..), ..., ())

2015-08-31 Thread pengcheng xiong 


> On Aug. 31, 2015, 11:56 p.m., Sergey Shelukhin wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g, line 475
> > 
> >
> > phase 4? :)

Well, seriously :) , in this phase, we only support clause (x,y..) in 
((..),..., ()) and in the next phase, we will support clause (x,y..) in (select 
x,y from ...). Any comments/suggestions are welcome. :)


- pengcheng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37620/#review97207
---


On Sept. 1, 2015, midnight, pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37620/
> ---
> 
> (Updated Sept. 1, 2015, midnight)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Current hive only support single column in clause, e.g., 
> {code}select * from src where  col0 in (v1,v2,v3);{code}
> We want it to support 
> {code}select * from src where (col0,col1+3) in 
> ((col0+v1,v2),(v3,v4-col1));{code}
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 64af7d1 
>   
> ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsNegative.java
>  61b5892 
>   
> ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsPositive.java
>  4c84e91 
>   ql/src/test/queries/clientpositive/char_udf1.q 8848609 
>   ql/src/test/queries/clientpositive/keyword_2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/multi_column_in.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/varchar_udf1.q 395fb12 
>   ql/src/test/results/clientpositive/char_udf1.q.java1.7.out ced0132 
>   ql/src/test/results/clientpositive/keyword_2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/multi_column_in.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/varchar_udf1.q.java1.7.out 96ba06e 
> 
> Diff: https://reviews.apache.org/r/37620/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>

Re: Review Request 37620: Hive Parser to Support multi col in clause (x, y..) in ((..), ..., ())

2015-09-03 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37620/#review97667
---

Ship it!


Ship It!

- John Pullokkaran


On Sept. 1, 2015, midnight, pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37620/
> ---
> 
> (Updated Sept. 1, 2015, midnight)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Current hive only support single column in clause, e.g., 
> {code}select * from src where  col0 in (v1,v2,v3);{code}
> We want it to support 
> {code}select * from src where (col0,col1+3) in 
> ((col0+v1,v2),(v3,v4-col1));{code}
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 64af7d1 
>   
> ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsNegative.java
>  61b5892 
>   
> ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsPositive.java
>  4c84e91 
>   ql/src/test/queries/clientpositive/char_udf1.q 8848609 
>   ql/src/test/queries/clientpositive/keyword_2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/multi_column_in.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/varchar_udf1.q 395fb12 
>   ql/src/test/results/clientpositive/char_udf1.q.java1.7.out ced0132 
>   ql/src/test/results/clientpositive/keyword_2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/multi_column_in.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/varchar_udf1.q.java1.7.out 96ba06e 
> 
> Diff: https://reviews.apache.org/r/37620/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>