subject:"Review Request 41928\: HIVE\-12777\: Add capability to restore session"

Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-05 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java 
90a9a4e6bbefdb4679bc76e21661ba4658a1df3c 
  ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseDriver.java PRE-CREATION 

Diff: https://reviews.apache.org/r/41928/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-05 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 5, 2016, 8:42 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  service/src/java/org/apache/hive/service/cli/CLIService.java 
adc98098437b2d0429dd2af40d8eaae323fbf3f0 
  service/src/java/org/apache/hive/service/cli/SessionHandle.java 
52e0ad4834d8b44d5038bb5c1a851eb702cd38ca 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
50c912ee606bce73f447fba69ce0f57d8c7fc6c9 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
637cdca3bcea9d320f397de032fd78d59ce6afef 

Diff: https://reviews.apache.org/r/41928/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-05 Thread Amareshwari Sriramadasu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/#review113017
---



service/src/java/org/apache/hive/service/cli/CLIService.java (line 48)


Avoid of the move of import statements



service/src/java/org/apache/hive/service/cli/CLIService.java (line 206)


Comment does not make sense. Please add proper javadoc


Please add unit tests

- Amareshwari Sriramadasu


On Jan. 5, 2016, 3:12 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41928/
> ---
> 
> (Updated Jan. 5, 2016, 3:12 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-12777
> https://issues.apache.org/jira/browse/HIVE-12777
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Extensions using Hive session handles should be able to restore the hive 
> session from the handle. 
> 
> Apache Lens depends on a fork of hive and that fork has such a capability. 
> 
> Relevant commit: 
> https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be
> 
> 
> Diffs
> -
> 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 
> adc98098437b2d0429dd2af40d8eaae323fbf3f0 
>   service/src/java/org/apache/hive/service/cli/SessionHandle.java 
> 52e0ad4834d8b44d5038bb5c1a851eb702cd38ca 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
> 50c912ee606bce73f447fba69ce0f57d8c7fc6c9 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
> 637cdca3bcea9d320f397de032fd78d59ce6afef 
> 
> Diff: https://reviews.apache.org/r/41928/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-05 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 6, 2016, 12:09 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  service/if/TCLIService.thrift baf583fb3ecd4a0ab248540ffb5db57100028968 
  service/src/gen/thrift/gen-cpp/TCLIService.h 
2ea80c76e4e8618c5535f8270f20c70c8b35f765 
  service/src/gen/thrift/gen-cpp/TCLIService.cpp 
7e2c028dc5e038e40d4dfb5e06a80789b4eabe3b 
  service/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp 
988bb4c11ddb717f585e0ba2fb4773ec5fff77e6 
  service/src/gen/thrift/gen-cpp/TCLIService_types.h 
b078c99db2f436e1ac32514b8f873c150952900b 
  service/src/gen/thrift/gen-cpp/TCLIService_types.cpp 
b85237994f8019bd58aa1c8fdbef3aabce9940e2 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCLIService.java
 ded848f2b81bf698a819732a2e9ea4bc67fd2a26 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TExecuteStatementReq.java
 30cf243f541304a2ac05c775c912d542520ebe05 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTablesReq.java
 4f2273214ab43b1116008183ff42a520769c6710 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRestoreSessionReq.java
 PRE-CREATION 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRestoreSessionResp.java
 PRE-CREATION 
  service/src/gen/thrift/gen-php/TCLIService.php 
eba62f12de0899280b9961dd82330bb149d40758 
  service/src/gen/thrift/gen-py/TCLIService/TCLIService-remote 
56f5c5dc36d44627a2cd571c2bc1fcd1a79e62f2 
  service/src/gen/thrift/gen-py/TCLIService/TCLIService.py 
ad2d71d720376c76632d9e3a147f227b3ff67c17 
  service/src/gen/thrift/gen-py/TCLIService/ttypes.py 
ef5f5f568ffec92c093bdd0904c154f8ee67606e 
  service/src/gen/thrift/gen-rb/t_c_l_i_service.rb 
7d7f7a78a17cab50b18fa77805022bf4ca0197d9 
  service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 
f004ec40afd29ab4ed452f65f306cb1af5ff5207 
  service/src/java/org/apache/hive/service/cli/CLIService.java 
adc98098437b2d0429dd2af40d8eaae323fbf3f0 
  service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 
3155c238ff688bfea16b0aaeea950599bb659b5b 
  service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 
9cad5be198c063115a8e90c67b1c2fd910ca8bc6 
  service/src/java/org/apache/hive/service/cli/ICLIService.java 
c9cc1f4da56f1cd10f6348ea2b9e17e203b87664 
  service/src/java/org/apache/hive/service/cli/SessionHandle.java 
52e0ad4834d8b44d5038bb5c1a851eb702cd38ca 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
50c912ee606bce73f447fba69ce0f57d8c7fc6c9 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
637cdca3bcea9d320f397de032fd78d59ce6afef 
  
service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
 529eaa45d29d22e0e80ea2c08a27b84f2909eda3 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
8434965e87366e86d27685c5ca70ee904446bae9 
  
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 
1af45398b895cd7616c5627d318422e14b81e734 
  service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 
e78181a15993d99f1cab5a061c08bb21823d2171 

Diff: https://reviews.apache.org/r/41928/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-05 Thread Amareshwari Sriramadasu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/#review113021
---


Can you include code only with thrift changes and no generated code? Will be 
eacy for review. For patch on jira, include generated code as well.

- Amareshwari Sriramadasu


On Jan. 6, 2016, 6:39 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41928/
> ---
> 
> (Updated Jan. 6, 2016, 6:39 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-12777
> https://issues.apache.org/jira/browse/HIVE-12777
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Extensions using Hive session handles should be able to restore the hive 
> session from the handle. 
> 
> Apache Lens depends on a fork of hive and that fork has such a capability. 
> 
> Relevant commit: 
> https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be
> 
> 
> Diffs
> -
> 
>   service/if/TCLIService.thrift baf583fb3ecd4a0ab248540ffb5db57100028968 
>   service/src/gen/thrift/gen-cpp/TCLIService.h 
> 2ea80c76e4e8618c5535f8270f20c70c8b35f765 
>   service/src/gen/thrift/gen-cpp/TCLIService.cpp 
> 7e2c028dc5e038e40d4dfb5e06a80789b4eabe3b 
>   service/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp 
> 988bb4c11ddb717f585e0ba2fb4773ec5fff77e6 
>   service/src/gen/thrift/gen-cpp/TCLIService_types.h 
> b078c99db2f436e1ac32514b8f873c150952900b 
>   service/src/gen/thrift/gen-cpp/TCLIService_types.cpp 
> b85237994f8019bd58aa1c8fdbef3aabce9940e2 
>   
> service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCLIService.java
>  ded848f2b81bf698a819732a2e9ea4bc67fd2a26 
>   
> service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TExecuteStatementReq.java
>  30cf243f541304a2ac05c775c912d542520ebe05 
>   
> service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTablesReq.java
>  4f2273214ab43b1116008183ff42a520769c6710 
>   
> service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRestoreSessionReq.java
>  PRE-CREATION 
>   
> service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRestoreSessionResp.java
>  PRE-CREATION 
>   service/src/gen/thrift/gen-php/TCLIService.php 
> eba62f12de0899280b9961dd82330bb149d40758 
>   service/src/gen/thrift/gen-py/TCLIService/TCLIService-remote 
> 56f5c5dc36d44627a2cd571c2bc1fcd1a79e62f2 
>   service/src/gen/thrift/gen-py/TCLIService/TCLIService.py 
> ad2d71d720376c76632d9e3a147f227b3ff67c17 
>   service/src/gen/thrift/gen-py/TCLIService/ttypes.py 
> ef5f5f568ffec92c093bdd0904c154f8ee67606e 
>   service/src/gen/thrift/gen-rb/t_c_l_i_service.rb 
> 7d7f7a78a17cab50b18fa77805022bf4ca0197d9 
>   service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 
> f004ec40afd29ab4ed452f65f306cb1af5ff5207 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 
> adc98098437b2d0429dd2af40d8eaae323fbf3f0 
>   service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 
> 3155c238ff688bfea16b0aaeea950599bb659b5b 
>   service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 
> 9cad5be198c063115a8e90c67b1c2fd910ca8bc6 
>   service/src/java/org/apache/hive/service/cli/ICLIService.java 
> c9cc1f4da56f1cd10f6348ea2b9e17e203b87664 
>   service/src/java/org/apache/hive/service/cli/SessionHandle.java 
> 52e0ad4834d8b44d5038bb5c1a851eb702cd38ca 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
> 50c912ee606bce73f447fba69ce0f57d8c7fc6c9 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
> 637cdca3bcea9d320f397de032fd78d59ce6afef 
>   
> service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
>  529eaa45d29d22e0e80ea2c08a27b84f2909eda3 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
> 8434965e87366e86d27685c5ca70ee904446bae9 
>   
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java
>  1af45398b895cd7616c5627d318422e14b81e734 
>   service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 
> e78181a15993d99f1cab5a061c08bb21823d2171 
> 
> Diff: https://reviews.apache.org/r/41928/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-05 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 6, 2016, 12:21 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  service/if/TCLIService.thrift baf583fb3ecd4a0ab248540ffb5db57100028968 
  service/src/gen/thrift/gen-cpp/TCLIService.h 
2ea80c76e4e8618c5535f8270f20c70c8b35f765 
  service/src/gen/thrift/gen-cpp/TCLIService.cpp 
7e2c028dc5e038e40d4dfb5e06a80789b4eabe3b 
  service/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp 
988bb4c11ddb717f585e0ba2fb4773ec5fff77e6 
  service/src/gen/thrift/gen-cpp/TCLIService_types.h 
b078c99db2f436e1ac32514b8f873c150952900b 
  service/src/gen/thrift/gen-cpp/TCLIService_types.cpp 
b85237994f8019bd58aa1c8fdbef3aabce9940e2 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCLIService.java
 ded848f2b81bf698a819732a2e9ea4bc67fd2a26 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TExecuteStatementReq.java
 30cf243f541304a2ac05c775c912d542520ebe05 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTablesReq.java
 4f2273214ab43b1116008183ff42a520769c6710 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRestoreSessionReq.java
 PRE-CREATION 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRestoreSessionResp.java
 PRE-CREATION 
  service/src/gen/thrift/gen-php/TCLIService.php 
eba62f12de0899280b9961dd82330bb149d40758 
  service/src/gen/thrift/gen-py/TCLIService/TCLIService-remote 
56f5c5dc36d44627a2cd571c2bc1fcd1a79e62f2 
  service/src/gen/thrift/gen-py/TCLIService/TCLIService.py 
ad2d71d720376c76632d9e3a147f227b3ff67c17 
  service/src/gen/thrift/gen-py/TCLIService/ttypes.py 
ef5f5f568ffec92c093bdd0904c154f8ee67606e 
  service/src/gen/thrift/gen-rb/t_c_l_i_service.rb 
7d7f7a78a17cab50b18fa77805022bf4ca0197d9 
  service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 
f004ec40afd29ab4ed452f65f306cb1af5ff5207 
  service/src/java/org/apache/hive/service/cli/CLIService.java 
adc98098437b2d0429dd2af40d8eaae323fbf3f0 
  service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 
3155c238ff688bfea16b0aaeea950599bb659b5b 
  service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 
9cad5be198c063115a8e90c67b1c2fd910ca8bc6 
  service/src/java/org/apache/hive/service/cli/ICLIService.java 
c9cc1f4da56f1cd10f6348ea2b9e17e203b87664 
  service/src/java/org/apache/hive/service/cli/SessionHandle.java 
52e0ad4834d8b44d5038bb5c1a851eb702cd38ca 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
50c912ee606bce73f447fba69ce0f57d8c7fc6c9 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
637cdca3bcea9d320f397de032fd78d59ce6afef 
  
service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
 529eaa45d29d22e0e80ea2c08a27b84f2909eda3 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
8434965e87366e86d27685c5ca70ee904446bae9 
  
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 
1af45398b895cd7616c5627d318422e14b81e734 
  service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 
e78181a15993d99f1cab5a061c08bb21823d2171 

Diff: https://reviews.apache.org/r/41928/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-05 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 6, 2016, 12:26 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  service/if/TCLIService.thrift baf583fb3ecd4a0ab248540ffb5db57100028968 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRestoreSessionReq.java
 PRE-CREATION 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRestoreSessionResp.java
 PRE-CREATION 
  service/src/java/org/apache/hive/service/cli/CLIService.java 
adc98098437b2d0429dd2af40d8eaae323fbf3f0 
  service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 
3155c238ff688bfea16b0aaeea950599bb659b5b 
  service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 
9cad5be198c063115a8e90c67b1c2fd910ca8bc6 
  service/src/java/org/apache/hive/service/cli/ICLIService.java 
c9cc1f4da56f1cd10f6348ea2b9e17e203b87664 
  service/src/java/org/apache/hive/service/cli/SessionHandle.java 
52e0ad4834d8b44d5038bb5c1a851eb702cd38ca 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
50c912ee606bce73f447fba69ce0f57d8c7fc6c9 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
637cdca3bcea9d320f397de032fd78d59ce6afef 
  
service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
 529eaa45d29d22e0e80ea2c08a27b84f2909eda3 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
8434965e87366e86d27685c5ca70ee904446bae9 
  
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 
1af45398b895cd7616c5627d318422e14b81e734 
  service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 
e78181a15993d99f1cab5a061c08bb21823d2171 

Diff: https://reviews.apache.org/r/41928/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-05 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 6, 2016, 12:29 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  service/if/TCLIService.thrift baf583fb3ecd4a0ab248540ffb5db57100028968 
  service/src/java/org/apache/hive/service/cli/CLIService.java 
adc98098437b2d0429dd2af40d8eaae323fbf3f0 
  service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 
3155c238ff688bfea16b0aaeea950599bb659b5b 
  service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 
9cad5be198c063115a8e90c67b1c2fd910ca8bc6 
  service/src/java/org/apache/hive/service/cli/ICLIService.java 
c9cc1f4da56f1cd10f6348ea2b9e17e203b87664 
  service/src/java/org/apache/hive/service/cli/SessionHandle.java 
52e0ad4834d8b44d5038bb5c1a851eb702cd38ca 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
50c912ee606bce73f447fba69ce0f57d8c7fc6c9 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
637cdca3bcea9d320f397de032fd78d59ce6afef 
  
service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
 529eaa45d29d22e0e80ea2c08a27b84f2909eda3 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
8434965e87366e86d27685c5ca70ee904446bae9 
  
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 
1af45398b895cd7616c5627d318422e14b81e734 
  service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 
e78181a15993d99f1cab5a061c08bb21823d2171 

Diff: https://reviews.apache.org/r/41928/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-06 Thread Amareshwari Sriramadasu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/#review113180
---



service/src/java/org/apache/hive/service/cli/session/SessionManager.java (line 
297)


Dont we need changes here?



service/src/test/org/apache/hive/service/cli/CLIServiceTest.java (line 91)


Restoring a closed session? I dont think this should be allowed.

The test should wrt service restart and restore session.


- Amareshwari Sriramadasu


On Jan. 6, 2016, 6:59 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41928/
> ---
> 
> (Updated Jan. 6, 2016, 6:59 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-12777
> https://issues.apache.org/jira/browse/HIVE-12777
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Extensions using Hive session handles should be able to restore the hive 
> session from the handle. 
> 
> Apache Lens depends on a fork of hive and that fork has such a capability. 
> 
> Relevant commit: 
> https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be
> 
> 
> Diffs
> -
> 
>   service/if/TCLIService.thrift baf583fb3ecd4a0ab248540ffb5db57100028968 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 
> adc98098437b2d0429dd2af40d8eaae323fbf3f0 
>   service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 
> 3155c238ff688bfea16b0aaeea950599bb659b5b 
>   service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 
> 9cad5be198c063115a8e90c67b1c2fd910ca8bc6 
>   service/src/java/org/apache/hive/service/cli/ICLIService.java 
> c9cc1f4da56f1cd10f6348ea2b9e17e203b87664 
>   service/src/java/org/apache/hive/service/cli/SessionHandle.java 
> 52e0ad4834d8b44d5038bb5c1a851eb702cd38ca 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
> 50c912ee606bce73f447fba69ce0f57d8c7fc6c9 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
> 637cdca3bcea9d320f397de032fd78d59ce6afef 
>   
> service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
>  529eaa45d29d22e0e80ea2c08a27b84f2909eda3 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
> 8434965e87366e86d27685c5ca70ee904446bae9 
>   
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java
>  1af45398b895cd7616c5627d318422e14b81e734 
>   service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 
> e78181a15993d99f1cab5a061c08bb21823d2171 
> 
> Diff: https://reviews.apache.org/r/41928/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-07 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 8, 2016, 12:22 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  
itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java
 de66d9efb1cace9d32174e3020920d5e4002dc85 
  service/if/TCLIService.thrift baf583fb3ecd4a0ab248540ffb5db57100028968 
  service/src/java/org/apache/hive/service/cli/CLIService.java 
adc98098437b2d0429dd2af40d8eaae323fbf3f0 
  service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 
3155c238ff688bfea16b0aaeea950599bb659b5b 
  service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 
9cad5be198c063115a8e90c67b1c2fd910ca8bc6 
  service/src/java/org/apache/hive/service/cli/ICLIService.java 
c9cc1f4da56f1cd10f6348ea2b9e17e203b87664 
  service/src/java/org/apache/hive/service/cli/SessionHandle.java 
52e0ad4834d8b44d5038bb5c1a851eb702cd38ca 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
50c912ee606bce73f447fba69ce0f57d8c7fc6c9 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
637cdca3bcea9d320f397de032fd78d59ce6afef 
  
service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
 529eaa45d29d22e0e80ea2c08a27b84f2909eda3 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
8434965e87366e86d27685c5ca70ee904446bae9 
  
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 
1af45398b895cd7616c5627d318422e14b81e734 
  service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 
e78181a15993d99f1cab5a061c08bb21823d2171 

Diff: https://reviews.apache.org/r/41928/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-07 Thread Rajat Khandelwal



> On Jan. 7, 2016, 10:17 a.m., Amareshwari Sriramadasu wrote:
> > service/src/test/org/apache/hive/service/cli/CLIServiceTest.java, line 91
> > 
> >
> > Restoring a closed session? I dont think this should be allowed.
> > 
> > The test should wrt service restart and restore session.
> 
> Rajat Khandelwal wrote:
> This test class is abstract, the functionality can't be tested here. Can 
> you suggest another class where I can add such a test?

Added an abstract `restart` method in the abstract test class. The restore test 
uses that. Hope that is enough.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/#review113180
---


On Jan. 8, 2016, 12:22 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41928/
> ---
> 
> (Updated Jan. 8, 2016, 12:22 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-12777
> https://issues.apache.org/jira/browse/HIVE-12777
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Extensions using Hive session handles should be able to restore the hive 
> session from the handle. 
> 
> Apache Lens depends on a fork of hive and that fork has such a capability. 
> 
> Relevant commit: 
> https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be
> 
> 
> Diffs
> -
> 
>   
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java
>  de66d9efb1cace9d32174e3020920d5e4002dc85 
>   service/if/TCLIService.thrift baf583fb3ecd4a0ab248540ffb5db57100028968 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 
> adc98098437b2d0429dd2af40d8eaae323fbf3f0 
>   service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 
> 3155c238ff688bfea16b0aaeea950599bb659b5b 
>   service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 
> 9cad5be198c063115a8e90c67b1c2fd910ca8bc6 
>   service/src/java/org/apache/hive/service/cli/ICLIService.java 
> c9cc1f4da56f1cd10f6348ea2b9e17e203b87664 
>   service/src/java/org/apache/hive/service/cli/SessionHandle.java 
> 52e0ad4834d8b44d5038bb5c1a851eb702cd38ca 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
> 50c912ee606bce73f447fba69ce0f57d8c7fc6c9 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
> 637cdca3bcea9d320f397de032fd78d59ce6afef 
>   
> service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
>  529eaa45d29d22e0e80ea2c08a27b84f2909eda3 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
> 8434965e87366e86d27685c5ca70ee904446bae9 
>   
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java
>  1af45398b895cd7616c5627d318422e14b81e734 
>   service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 
> e78181a15993d99f1cab5a061c08bb21823d2171 
> 
> Diff: https://reviews.apache.org/r/41928/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-10 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 11, 2016, 1:12 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  
itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java
 de66d9efb1cace9d32174e3020920d5e4002dc85 
  service/if/TCLIService.thrift baf583fb3ecd4a0ab248540ffb5db57100028968 
  service/src/gen/thrift/gen-cpp/TCLIService.h 
2ea80c76e4e8618c5535f8270f20c70c8b35f765 
  service/src/gen/thrift/gen-cpp/TCLIService.cpp 
7e2c028dc5e038e40d4dfb5e06a80789b4eabe3b 
  service/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp 
988bb4c11ddb717f585e0ba2fb4773ec5fff77e6 
  service/src/gen/thrift/gen-cpp/TCLIService_types.h 
b078c99db2f436e1ac32514b8f873c150952900b 
  service/src/gen/thrift/gen-cpp/TCLIService_types.cpp 
b85237994f8019bd58aa1c8fdbef3aabce9940e2 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCLIService.java
 ded848f2b81bf698a819732a2e9ea4bc67fd2a26 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TExecuteStatementReq.java
 30cf243f541304a2ac05c775c912d542520ebe05 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTablesReq.java
 4f2273214ab43b1116008183ff42a520769c6710 
  service/src/gen/thrift/gen-php/TCLIService.php 
eba62f12de0899280b9961dd82330bb149d40758 
  service/src/gen/thrift/gen-py/TCLIService/TCLIService-remote 
56f5c5dc36d44627a2cd571c2bc1fcd1a79e62f2 
  service/src/gen/thrift/gen-py/TCLIService/TCLIService.py 
ad2d71d720376c76632d9e3a147f227b3ff67c17 
  service/src/gen/thrift/gen-py/TCLIService/ttypes.py 
ef5f5f568ffec92c093bdd0904c154f8ee67606e 
  service/src/gen/thrift/gen-rb/t_c_l_i_service.rb 
7d7f7a78a17cab50b18fa77805022bf4ca0197d9 
  service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 
f004ec40afd29ab4ed452f65f306cb1af5ff5207 
  service/src/java/org/apache/hive/service/cli/CLIService.java 
adc98098437b2d0429dd2af40d8eaae323fbf3f0 
  service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 
3155c238ff688bfea16b0aaeea950599bb659b5b 
  service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 
9cad5be198c063115a8e90c67b1c2fd910ca8bc6 
  service/src/java/org/apache/hive/service/cli/ICLIService.java 
c9cc1f4da56f1cd10f6348ea2b9e17e203b87664 
  service/src/java/org/apache/hive/service/cli/SessionHandle.java 
52e0ad4834d8b44d5038bb5c1a851eb702cd38ca 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
50c912ee606bce73f447fba69ce0f57d8c7fc6c9 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
637cdca3bcea9d320f397de032fd78d59ce6afef 
  
service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
 529eaa45d29d22e0e80ea2c08a27b84f2909eda3 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
8434965e87366e86d27685c5ca70ee904446bae9 
  
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 
1af45398b895cd7616c5627d318422e14b81e734 
  service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 
e78181a15993d99f1cab5a061c08bb21823d2171 

Diff: https://reviews.apache.org/r/41928/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-11 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 11, 2016, 3:52 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  
itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java
 de66d9efb1cace9d32174e3020920d5e4002dc85 
  service/if/TCLIService.thrift baf583fb3ecd4a0ab248540ffb5db57100028968 
  service/src/gen/thrift/gen-cpp/TCLIService.h 
2ea80c76e4e8618c5535f8270f20c70c8b35f765 
  service/src/gen/thrift/gen-cpp/TCLIService.cpp 
7e2c028dc5e038e40d4dfb5e06a80789b4eabe3b 
  service/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp 
988bb4c11ddb717f585e0ba2fb4773ec5fff77e6 
  service/src/gen/thrift/gen-cpp/TCLIService_types.h 
b078c99db2f436e1ac32514b8f873c150952900b 
  service/src/gen/thrift/gen-cpp/TCLIService_types.cpp 
b85237994f8019bd58aa1c8fdbef3aabce9940e2 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCLIService.java
 ded848f2b81bf698a819732a2e9ea4bc67fd2a26 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TExecuteStatementReq.java
 30cf243f541304a2ac05c775c912d542520ebe05 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTablesReq.java
 4f2273214ab43b1116008183ff42a520769c6710 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRestoreSessionReq.java
 PRE-CREATION 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRestoreSessionResp.java
 PRE-CREATION 
  service/src/gen/thrift/gen-php/TCLIService.php 
eba62f12de0899280b9961dd82330bb149d40758 
  service/src/gen/thrift/gen-py/TCLIService/TCLIService-remote 
56f5c5dc36d44627a2cd571c2bc1fcd1a79e62f2 
  service/src/gen/thrift/gen-py/TCLIService/TCLIService.py 
ad2d71d720376c76632d9e3a147f227b3ff67c17 
  service/src/gen/thrift/gen-py/TCLIService/ttypes.py 
ef5f5f568ffec92c093bdd0904c154f8ee67606e 
  service/src/gen/thrift/gen-rb/t_c_l_i_service.rb 
7d7f7a78a17cab50b18fa77805022bf4ca0197d9 
  service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 
f004ec40afd29ab4ed452f65f306cb1af5ff5207 
  service/src/java/org/apache/hive/service/cli/CLIService.java 
adc98098437b2d0429dd2af40d8eaae323fbf3f0 
  service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 
3155c238ff688bfea16b0aaeea950599bb659b5b 
  service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 
9cad5be198c063115a8e90c67b1c2fd910ca8bc6 
  service/src/java/org/apache/hive/service/cli/ICLIService.java 
c9cc1f4da56f1cd10f6348ea2b9e17e203b87664 
  service/src/java/org/apache/hive/service/cli/SessionHandle.java 
52e0ad4834d8b44d5038bb5c1a851eb702cd38ca 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
50c912ee606bce73f447fba69ce0f57d8c7fc6c9 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
637cdca3bcea9d320f397de032fd78d59ce6afef 
  
service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
 529eaa45d29d22e0e80ea2c08a27b84f2909eda3 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
8434965e87366e86d27685c5ca70ee904446bae9 
  
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 
1af45398b895cd7616c5627d318422e14b81e734 
  service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 
e78181a15993d99f1cab5a061c08bb21823d2171 

Diff: https://reviews.apache.org/r/41928/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-11 Thread Amareshwari Sriramadasu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/#review113730
---



service/src/test/org/apache/hive/service/cli/CLIServiceTest.java (line 94)


Can you do some operations on restored session?


- Amareshwari Sriramadasu


On Jan. 11, 2016, 10:22 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41928/
> ---
> 
> (Updated Jan. 11, 2016, 10:22 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-12777
> https://issues.apache.org/jira/browse/HIVE-12777
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Extensions using Hive session handles should be able to restore the hive 
> session from the handle. 
> 
> Apache Lens depends on a fork of hive and that fork has such a capability. 
> 
> Relevant commit: 
> https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be
> 
> 
> Diffs
> -
> 
>   
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java
>  de66d9efb1cace9d32174e3020920d5e4002dc85 
>   service/if/TCLIService.thrift baf583fb3ecd4a0ab248540ffb5db57100028968 
>   service/src/gen/thrift/gen-cpp/TCLIService.h 
> 2ea80c76e4e8618c5535f8270f20c70c8b35f765 
>   service/src/gen/thrift/gen-cpp/TCLIService.cpp 
> 7e2c028dc5e038e40d4dfb5e06a80789b4eabe3b 
>   service/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp 
> 988bb4c11ddb717f585e0ba2fb4773ec5fff77e6 
>   service/src/gen/thrift/gen-cpp/TCLIService_types.h 
> b078c99db2f436e1ac32514b8f873c150952900b 
>   service/src/gen/thrift/gen-cpp/TCLIService_types.cpp 
> b85237994f8019bd58aa1c8fdbef3aabce9940e2 
>   
> service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCLIService.java
>  ded848f2b81bf698a819732a2e9ea4bc67fd2a26 
>   
> service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TExecuteStatementReq.java
>  30cf243f541304a2ac05c775c912d542520ebe05 
>   
> service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTablesReq.java
>  4f2273214ab43b1116008183ff42a520769c6710 
>   
> service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRestoreSessionReq.java
>  PRE-CREATION 
>   
> service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRestoreSessionResp.java
>  PRE-CREATION 
>   service/src/gen/thrift/gen-php/TCLIService.php 
> eba62f12de0899280b9961dd82330bb149d40758 
>   service/src/gen/thrift/gen-py/TCLIService/TCLIService-remote 
> 56f5c5dc36d44627a2cd571c2bc1fcd1a79e62f2 
>   service/src/gen/thrift/gen-py/TCLIService/TCLIService.py 
> ad2d71d720376c76632d9e3a147f227b3ff67c17 
>   service/src/gen/thrift/gen-py/TCLIService/ttypes.py 
> ef5f5f568ffec92c093bdd0904c154f8ee67606e 
>   service/src/gen/thrift/gen-rb/t_c_l_i_service.rb 
> 7d7f7a78a17cab50b18fa77805022bf4ca0197d9 
>   service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 
> f004ec40afd29ab4ed452f65f306cb1af5ff5207 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 
> adc98098437b2d0429dd2af40d8eaae323fbf3f0 
>   service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 
> 3155c238ff688bfea16b0aaeea950599bb659b5b 
>   service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 
> 9cad5be198c063115a8e90c67b1c2fd910ca8bc6 
>   service/src/java/org/apache/hive/service/cli/ICLIService.java 
> c9cc1f4da56f1cd10f6348ea2b9e17e203b87664 
>   service/src/java/org/apache/hive/service/cli/SessionHandle.java 
> 52e0ad4834d8b44d5038bb5c1a851eb702cd38ca 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
> 50c912ee606bce73f447fba69ce0f57d8c7fc6c9 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
> 637cdca3bcea9d320f397de032fd78d59ce6afef 
>   
> service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
>  529eaa45d29d22e0e80ea2c08a27b84f2909eda3 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
> 8434965e87366e86d27685c5ca70ee904446bae9 
>   
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java
>  1af45398b895cd7616c5627d318422e14b81e734 
>   service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 
> e78181a15993d99f1cab5a061c08bb21823d2171 
> 
> Diff: https://reviews.apache.org/r/41928/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-11 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 11, 2016, 5:24 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  
itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java
 de66d9efb1cace9d32174e3020920d5e4002dc85 
  service/if/TCLIService.thrift baf583fb3ecd4a0ab248540ffb5db57100028968 
  service/src/gen/thrift/gen-cpp/TCLIService.h 
2ea80c76e4e8618c5535f8270f20c70c8b35f765 
  service/src/gen/thrift/gen-cpp/TCLIService.cpp 
7e2c028dc5e038e40d4dfb5e06a80789b4eabe3b 
  service/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp 
988bb4c11ddb717f585e0ba2fb4773ec5fff77e6 
  service/src/gen/thrift/gen-cpp/TCLIService_types.h 
b078c99db2f436e1ac32514b8f873c150952900b 
  service/src/gen/thrift/gen-cpp/TCLIService_types.cpp 
b85237994f8019bd58aa1c8fdbef3aabce9940e2 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCLIService.java
 ded848f2b81bf698a819732a2e9ea4bc67fd2a26 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TExecuteStatementReq.java
 30cf243f541304a2ac05c775c912d542520ebe05 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTablesReq.java
 4f2273214ab43b1116008183ff42a520769c6710 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRestoreSessionReq.java
 PRE-CREATION 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRestoreSessionResp.java
 PRE-CREATION 
  service/src/gen/thrift/gen-php/TCLIService.php 
eba62f12de0899280b9961dd82330bb149d40758 
  service/src/gen/thrift/gen-py/TCLIService/TCLIService-remote 
56f5c5dc36d44627a2cd571c2bc1fcd1a79e62f2 
  service/src/gen/thrift/gen-py/TCLIService/TCLIService.py 
ad2d71d720376c76632d9e3a147f227b3ff67c17 
  service/src/gen/thrift/gen-py/TCLIService/ttypes.py 
ef5f5f568ffec92c093bdd0904c154f8ee67606e 
  service/src/gen/thrift/gen-rb/t_c_l_i_service.rb 
7d7f7a78a17cab50b18fa77805022bf4ca0197d9 
  service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 
f004ec40afd29ab4ed452f65f306cb1af5ff5207 
  service/src/java/org/apache/hive/service/cli/CLIService.java 
adc98098437b2d0429dd2af40d8eaae323fbf3f0 
  service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 
3155c238ff688bfea16b0aaeea950599bb659b5b 
  service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 
9cad5be198c063115a8e90c67b1c2fd910ca8bc6 
  service/src/java/org/apache/hive/service/cli/ICLIService.java 
c9cc1f4da56f1cd10f6348ea2b9e17e203b87664 
  service/src/java/org/apache/hive/service/cli/SessionHandle.java 
52e0ad4834d8b44d5038bb5c1a851eb702cd38ca 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
50c912ee606bce73f447fba69ce0f57d8c7fc6c9 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
637cdca3bcea9d320f397de032fd78d59ce6afef 
  
service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
 529eaa45d29d22e0e80ea2c08a27b84f2909eda3 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
8434965e87366e86d27685c5ca70ee904446bae9 
  
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 
1af45398b895cd7616c5627d318422e14b81e734 
  service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 
e78181a15993d99f1cab5a061c08bb21823d2171 

Diff: https://reviews.apache.org/r/41928/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-12 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 12, 2016, 3:25 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  
itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java
 de66d9efb1cace9d32174e3020920d5e4002dc85 
  service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc 
  service-rpc/src/gen/thrift/gen-cpp/TCLIService.h 
3407564de27c56cf8f0ee057eee4fcfb8f6ca81e 
  service-rpc/src/gen/thrift/gen-cpp/TCLIService.cpp 
fc82b884d9d0cae47a43f8a734689af0cf6771ef 
  service-rpc/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp 
66ed6a7c7e51b212e9d6e190fb4376f06abb4098 
  service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 
53642939829ec137db6b5ded46c6c3edef3b9e69 
  service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 
e62e8b720e967dac6bbd4f53328a85256a07e022 
  
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIService.java
 c684f895127e4a1efed53fa0e6dda5221a935c28 
  
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementReq.java
 2eb4d091f0d500d5c03b7e803a81400726deaf67 
  
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetTablesReq.java
 1aa3f946727b6d4b5bf39af40acd5d3b3119949c 
  service-rpc/src/gen/thrift/gen-php/TCLIService.php 
eba62f12de0899280b9961dd82330bb149d40758 
  service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService-remote 
56f5c5dc36d44627a2cd571c2bc1fcd1a79e62f2 
  service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService.py 
ad2d71d720376c76632d9e3a147f227b3ff67c17 
  service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py 
ef5f5f568ffec92c093bdd0904c154f8ee67606e 
  service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service.rb 
7d7f7a78a17cab50b18fa77805022bf4ca0197d9 
  service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 
f004ec40afd29ab4ed452f65f306cb1af5ff5207 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRestoreSessionReq.java
 PRE-CREATION 
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRestoreSessionResp.java
 PRE-CREATION 
  service/src/java/org/apache/hive/service/cli/CLIService.java 
0d5ae1e491bdcf98a12f5eef7b35f23c7b9dfc00 
  service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 
3155c238ff688bfea16b0aaeea950599bb659b5b 
  service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 
9cad5be198c063115a8e90c67b1c2fd910ca8bc6 
  service/src/java/org/apache/hive/service/cli/ICLIService.java 
0a54bdda8067330ea358683054aa987a6c22317f 
  service/src/java/org/apache/hive/service/cli/SessionHandle.java 
4e4f0211de09408168c8da669626fb49f3db364c 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
3c5700bd114f6b792df10df23e57dad9b9e689f6 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
de18f1d93502704e7a8fbb8d31d93bd770c4d232 
  
service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
 a81c600236e6e0f53a484806e559303279244616 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
78b4b3177213bc60331c1b71fb08470841e9a7a3 
  
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 
5f01165d0dfd131a2599b90a8e1c4d4970650b7a 
  service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 
e78181a15993d99f1cab5a061c08bb21823d2171 

Diff: https://reviews.apache.org/r/41928/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-13 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 13, 2016, 4:57 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  
itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java
 de66d9efb1cace9d32174e3020920d5e4002dc85 
  service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc 
  service-rpc/src/gen/thrift/gen-cpp/TCLIService.h 
3407564de27c56cf8f0ee057eee4fcfb8f6ca81e 
  service-rpc/src/gen/thrift/gen-cpp/TCLIService.cpp 
fc82b884d9d0cae47a43f8a734689af0cf6771ef 
  service-rpc/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp 
66ed6a7c7e51b212e9d6e190fb4376f06abb4098 
  service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 
53642939829ec137db6b5ded46c6c3edef3b9e69 
  service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 
e62e8b720e967dac6bbd4f53328a85256a07e022 
  
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIService.java
 c684f895127e4a1efed53fa0e6dda5221a935c28 
  
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementReq.java
 2eb4d091f0d500d5c03b7e803a81400726deaf67 
  
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetTablesReq.java
 1aa3f946727b6d4b5bf39af40acd5d3b3119949c 
  
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TRestoreSessionReq.java
 PRE-CREATION 
  
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TRestoreSessionResp.java
 PRE-CREATION 
  service-rpc/src/gen/thrift/gen-php/TCLIService.php 
eba62f12de0899280b9961dd82330bb149d40758 
  service-rpc/src/gen/thrift/gen-php/Types.php 
76805df4910a31636dccbd119abe91dfbb1568a1 
  service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService-remote 
56f5c5dc36d44627a2cd571c2bc1fcd1a79e62f2 
  service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService.py 
ad2d71d720376c76632d9e3a147f227b3ff67c17 
  service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py 
ef5f5f568ffec92c093bdd0904c154f8ee67606e 
  service-rpc/src/gen/thrift/gen-py/__init__.py PRE-CREATION 
  service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service.rb 
7d7f7a78a17cab50b18fa77805022bf4ca0197d9 
  service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 
f004ec40afd29ab4ed452f65f306cb1af5ff5207 
  service/src/gen/thrift/gen-cpp/ThriftHive.h PRE-CREATION 
  service/src/gen/thrift/gen-cpp/ThriftHive.cpp PRE-CREATION 
  service/src/gen/thrift/gen-cpp/ThriftHive_server.skeleton.cpp PRE-CREATION 
  service/src/gen/thrift/gen-cpp/hive_service_constants.h PRE-CREATION 
  service/src/gen/thrift/gen-cpp/hive_service_constants.cpp PRE-CREATION 
  service/src/gen/thrift/gen-cpp/hive_service_types.h PRE-CREATION 
  service/src/gen/thrift/gen-cpp/hive_service_types.cpp PRE-CREATION 
  
service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveClusterStatus.java
 PRE-CREATION 
  
service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveServerException.java
 PRE-CREATION 
  
service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/JobTrackerState.java
 PRE-CREATION 
  
service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/ThriftHive.java
 PRE-CREATION 
  service/src/gen/thrift/gen-php/ThriftHive.php PRE-CREATION 
  service/src/gen/thrift/gen-php/Types.php PRE-CREATION 
  service/src/gen/thrift/gen-py/__init__.py PRE-CREATION 
  service/src/gen/thrift/gen-py/hive_service/ThriftHive-remote PRE-CREATION 
  service/src/gen/thrift/gen-py/hive_service/ThriftHive.py PRE-CREATION 
  service/src/gen/thrift/gen-py/hive_service/__init__.py PRE-CREATION 
  service/src/gen/thrift/gen-py/hive_service/constants.py PRE-CREATION 
  service/src/gen/thrift/gen-py/hive_service/ttypes.py PRE-CREATION 
  service/src/gen/thrift/gen-rb/hive_service_constants.rb PRE-CREATION 
  service/src/gen/thrift/gen-rb/hive_service_types.rb PRE-CREATION 
  service/src/gen/thrift/gen-rb/thrift_hive.rb PRE-CREATION 
  service/src/java/org/apache/hive/service/cli/CLIService.java 
0d5ae1e491bdcf98a12f5eef7b35f23c7b9dfc00 
  service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 
3155c238ff688bfea16b0aaeea950599bb659b5b 
  service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 
9cad5be198c063115a8e90c67b1c2fd910ca8bc6 
  service/src/java/org/apache/hive/service/cli/ICLIService.java 
0a54bdda8067330ea358683054aa987a6c22317f 
  service/src/j

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-13 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 14, 2016, 12:29 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  
itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java
 de66d9efb1cace9d32174e3020920d5e4002dc85 
  service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc 
  service-rpc/src/gen/thrift/gen-cpp/TCLIService.h 
3407564de27c56cf8f0ee057eee4fcfb8f6ca81e 
  service-rpc/src/gen/thrift/gen-cpp/TCLIService.cpp 
fc82b884d9d0cae47a43f8a734689af0cf6771ef 
  service-rpc/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp 
66ed6a7c7e51b212e9d6e190fb4376f06abb4098 
  service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 
53642939829ec137db6b5ded46c6c3edef3b9e69 
  service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 
e62e8b720e967dac6bbd4f53328a85256a07e022 
  
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIService.java
 c684f895127e4a1efed53fa0e6dda5221a935c28 
  
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementReq.java
 2eb4d091f0d500d5c03b7e803a81400726deaf67 
  
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetTablesReq.java
 1aa3f946727b6d4b5bf39af40acd5d3b3119949c 
  
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TRestoreSessionReq.java
 PRE-CREATION 
  
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TRestoreSessionResp.java
 PRE-CREATION 
  service-rpc/src/gen/thrift/gen-php/TCLIService.php 
eba62f12de0899280b9961dd82330bb149d40758 
  service-rpc/src/gen/thrift/gen-php/Types.php 
76805df4910a31636dccbd119abe91dfbb1568a1 
  service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService-remote 
56f5c5dc36d44627a2cd571c2bc1fcd1a79e62f2 
  service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService.py 
ad2d71d720376c76632d9e3a147f227b3ff67c17 
  service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py 
ef5f5f568ffec92c093bdd0904c154f8ee67606e 
  service-rpc/src/gen/thrift/gen-py/__init__.py PRE-CREATION 
  service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service.rb 
7d7f7a78a17cab50b18fa77805022bf4ca0197d9 
  service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 
f004ec40afd29ab4ed452f65f306cb1af5ff5207 
  service/src/gen/thrift/gen-cpp/ThriftHive.h PRE-CREATION 
  service/src/gen/thrift/gen-cpp/ThriftHive.cpp PRE-CREATION 
  service/src/gen/thrift/gen-cpp/ThriftHive_server.skeleton.cpp PRE-CREATION 
  service/src/gen/thrift/gen-cpp/hive_service_constants.h PRE-CREATION 
  service/src/gen/thrift/gen-cpp/hive_service_constants.cpp PRE-CREATION 
  service/src/gen/thrift/gen-cpp/hive_service_types.h PRE-CREATION 
  service/src/gen/thrift/gen-cpp/hive_service_types.cpp PRE-CREATION 
  
service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveClusterStatus.java
 PRE-CREATION 
  
service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveServerException.java
 PRE-CREATION 
  
service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/JobTrackerState.java
 PRE-CREATION 
  
service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/ThriftHive.java
 PRE-CREATION 
  service/src/gen/thrift/gen-php/ThriftHive.php PRE-CREATION 
  service/src/gen/thrift/gen-php/Types.php PRE-CREATION 
  service/src/gen/thrift/gen-py/__init__.py PRE-CREATION 
  service/src/gen/thrift/gen-py/hive_service/ThriftHive-remote PRE-CREATION 
  service/src/gen/thrift/gen-py/hive_service/ThriftHive.py PRE-CREATION 
  service/src/gen/thrift/gen-py/hive_service/__init__.py PRE-CREATION 
  service/src/gen/thrift/gen-py/hive_service/constants.py PRE-CREATION 
  service/src/gen/thrift/gen-py/hive_service/ttypes.py PRE-CREATION 
  service/src/gen/thrift/gen-rb/hive_service_constants.rb PRE-CREATION 
  service/src/gen/thrift/gen-rb/hive_service_types.rb PRE-CREATION 
  service/src/gen/thrift/gen-rb/thrift_hive.rb PRE-CREATION 
  service/src/java/org/apache/hive/service/cli/CLIService.java 
0d5ae1e491bdcf98a12f5eef7b35f23c7b9dfc00 
  service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 
3155c238ff688bfea16b0aaeea950599bb659b5b 
  service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 
9cad5be198c063115a8e90c67b1c2fd910ca8bc6 
  service/src/java/org/apache/hive/service/cli/ICLIService.java 
0a54bdda8067330ea358683054aa987a6c22317f 
  service/src/

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-18 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 18, 2016, 2:55 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc 
  service-rpc/src/gen/thrift/gen-py/__init__.py PRE-CREATION 
  service/src/gen/thrift/gen-cpp/ThriftHive.h PRE-CREATION 
  service/src/gen/thrift/gen-cpp/ThriftHive.cpp PRE-CREATION 
  service/src/gen/thrift/gen-cpp/ThriftHive_server.skeleton.cpp PRE-CREATION 
  service/src/gen/thrift/gen-cpp/hive_service_constants.h PRE-CREATION 
  service/src/gen/thrift/gen-cpp/hive_service_constants.cpp PRE-CREATION 
  service/src/gen/thrift/gen-cpp/hive_service_types.h PRE-CREATION 
  service/src/gen/thrift/gen-cpp/hive_service_types.cpp PRE-CREATION 
  
service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveClusterStatus.java
 PRE-CREATION 
  
service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveServerException.java
 PRE-CREATION 
  
service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/JobTrackerState.java
 PRE-CREATION 
  
service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/ThriftHive.java
 PRE-CREATION 
  service/src/gen/thrift/gen-php/ThriftHive.php PRE-CREATION 
  service/src/gen/thrift/gen-php/Types.php PRE-CREATION 
  service/src/gen/thrift/gen-py/__init__.py PRE-CREATION 
  service/src/gen/thrift/gen-py/hive_service/ThriftHive-remote PRE-CREATION 
  service/src/gen/thrift/gen-py/hive_service/ThriftHive.py PRE-CREATION 
  service/src/gen/thrift/gen-py/hive_service/__init__.py PRE-CREATION 
  service/src/gen/thrift/gen-py/hive_service/constants.py PRE-CREATION 
  service/src/gen/thrift/gen-py/hive_service/ttypes.py PRE-CREATION 
  service/src/gen/thrift/gen-rb/hive_service_constants.rb PRE-CREATION 
  service/src/gen/thrift/gen-rb/hive_service_types.rb PRE-CREATION 
  service/src/gen/thrift/gen-rb/thrift_hive.rb PRE-CREATION 
  service/src/java/org/apache/hive/service/cli/CLIService.java 
0d5ae1e491bdcf98a12f5eef7b35f23c7b9dfc00 
  service/src/java/org/apache/hive/service/cli/SessionHandle.java 
4e4f0211de09408168c8da669626fb49f3db364c 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
3c5700bd114f6b792df10df23e57dad9b9e689f6 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
de18f1d93502704e7a8fbb8d31d93bd770c4d232 
  
service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
 a81c600236e6e0f53a484806e559303279244616 
  
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 
5f01165d0dfd131a2599b90a8e1c4d4970650b7a 
  service/src/test/org/apache/hive/service/cli/CLIServiceRestoreTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/41928/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-18 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 18, 2016, 3:13 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  service/src/java/org/apache/hive/service/cli/CLIService.java 
0d5ae1e491bdcf98a12f5eef7b35f23c7b9dfc00 
  service/src/java/org/apache/hive/service/cli/SessionHandle.java 
4e4f0211de09408168c8da669626fb49f3db364c 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
3c5700bd114f6b792df10df23e57dad9b9e689f6 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
de18f1d93502704e7a8fbb8d31d93bd770c4d232 
  service/src/test/org/apache/hive/service/cli/CLIServiceRestoreTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/41928/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-18 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 18, 2016, 4:07 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  service/src/java/org/apache/hive/service/cli/CLIService.java 
0d5ae1e491bdcf98a12f5eef7b35f23c7b9dfc00 
  service/src/java/org/apache/hive/service/cli/SessionHandle.java 
4e4f0211de09408168c8da669626fb49f3db364c 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
3c5700bd114f6b792df10df23e57dad9b9e689f6 
  
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
 c56d97afc969ea57810e9b3222b20e086e847d67 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
de18f1d93502704e7a8fbb8d31d93bd770c4d232 
  service/src/test/org/apache/hive/service/cli/CLIServiceRestoreTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/41928/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-21 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 21, 2016, 7:09 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  service/src/java/org/apache/hive/service/cli/CLIService.java 
0d5ae1e491bdcf98a12f5eef7b35f23c7b9dfc00 
  service/src/java/org/apache/hive/service/cli/SessionHandle.java 
4e4f0211de09408168c8da669626fb49f3db364c 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
3c5700bd114f6b792df10df23e57dad9b9e689f6 
  
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
 c56d97afc969ea57810e9b3222b20e086e847d67 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
de18f1d93502704e7a8fbb8d31d93bd770c4d232 
  service/src/test/org/apache/hive/service/cli/CLIServiceRestoreTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/41928/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-27 Thread Amareshwari Sriramadasu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/#review116580
---




service/src/java/org/apache/hive/service/cli/CLIService.java (line 207)


Shall we remove the return from the method, which is not adding any?



service/src/java/org/apache/hive/service/cli/session/SessionManager.java (line 
311)


Why is the ipAddress variable changed?



service/src/test/org/apache/hive/service/cli/CLIServiceRestoreTest.java (line 
36)


Do a stop() after the test?


- Amareshwari Sriramadasu


On Jan. 21, 2016, 1:39 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41928/
> ---
> 
> (Updated Jan. 21, 2016, 1:39 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-12777
> https://issues.apache.org/jira/browse/HIVE-12777
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Extensions using Hive session handles should be able to restore the hive 
> session from the handle. 
> 
> Apache Lens depends on a fork of hive and that fork has such a capability. 
> 
> Relevant commit: 
> https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be
> 
> 
> Diffs
> -
> 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 
> 0d5ae1e491bdcf98a12f5eef7b35f23c7b9dfc00 
>   service/src/java/org/apache/hive/service/cli/SessionHandle.java 
> 4e4f0211de09408168c8da669626fb49f3db364c 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
> 3c5700bd114f6b792df10df23e57dad9b9e689f6 
>   
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
>  c56d97afc969ea57810e9b3222b20e086e847d67 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
> de18f1d93502704e7a8fbb8d31d93bd770c4d232 
>   service/src/test/org/apache/hive/service/cli/CLIServiceRestoreTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41928/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-27 Thread Rajat Khandelwal



> On Jan. 27, 2016, 5:50 p.m., Amareshwari Sriramadasu wrote:
> > service/src/java/org/apache/hive/service/cli/CLIService.java, line 207
> > 
> >
> > Shall we remove the return from the method, which is not adding any?

yeah we can remove. right now it's getting used in test cases to compare return 
value with the value passed.


> On Jan. 27, 2016, 5:50 p.m., Amareshwari Sriramadasu wrote:
> > service/src/java/org/apache/hive/service/cli/session/SessionManager.java, 
> > line 311
> > 
> >
> > Why is the ipAddress variable changed?

Seems a mistake. Added back.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/#review116580
---


On Jan. 21, 2016, 7:09 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41928/
> ---
> 
> (Updated Jan. 21, 2016, 7:09 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-12777
> https://issues.apache.org/jira/browse/HIVE-12777
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Extensions using Hive session handles should be able to restore the hive 
> session from the handle. 
> 
> Apache Lens depends on a fork of hive and that fork has such a capability. 
> 
> Relevant commit: 
> https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be
> 
> 
> Diffs
> -
> 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 
> 0d5ae1e491bdcf98a12f5eef7b35f23c7b9dfc00 
>   service/src/java/org/apache/hive/service/cli/SessionHandle.java 
> 4e4f0211de09408168c8da669626fb49f3db364c 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
> 3c5700bd114f6b792df10df23e57dad9b9e689f6 
>   
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
>  c56d97afc969ea57810e9b3222b20e086e847d67 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
> de18f1d93502704e7a8fbb8d31d93bd770c4d232 
>   service/src/test/org/apache/hive/service/cli/CLIServiceRestoreTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41928/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-27 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 27, 2016, 8:55 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  common/pom.xml 8141f75df6b649c0d9f66fd7c6efa2989e42938a 
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
2c25cae570b33dd03e33be3df45a964cc0a7f071 
  common/src/java/org/apache/hadoop/hive/conf/Validator.java 
04a305dbf15376c116ae660cdb8a42bc948ae6e3 
  data/files/windowing_distinct.txt PRE-CREATION 
  errata.txt 6ac1d41aa1476553a77d0c5a58f4a4c7c3d891f7 
  
hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatAuthUtil.java
 6dce9c4b1d1218ce1f8b4ebffee0eaacb31d25cd 
  
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DynamicPartitionFileRecordWriterContainer.java
 320ace4352c1212bab093d38635c4d70005bd473 
  
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java
 bc56d77c00bd5ac908c913948ad93f89c60d57ab 
  
hcatalog/core/src/test/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/TestHCatAuthUtil.java
 830dcb8119c255127f64a128a1d7b66f041bfb3e 
  
hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMultiOutputFormat.java
 8148faa8741952b0f92c33eaaa5ca908dfa47365 
  
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java
 ff2598f9a8e4d3e83292e5b85bf137aaea53a24d 
  
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java
 339e9ef8a5517ee17e84ab63ea168a01c415db73 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/hbase/TestHBaseSchemaTool.java
 24bebb821ebff6707620f363cac9ee5ce47eff50 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreIntegration.java
 c62190421cb979790d8c1df5c952292c39fd2ab3 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestMetastoreAuthorizationProvider.java
 4529ce396e209d7a8e7648b2213bcab12cb28e50 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java
 da367ca363ab11cb371236beab71cc2d6c43525b 
  itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 
09905ea1fe98ea5aaf12b902081a41b53ed9ad4e 
  itests/src/test/resources/testconfiguration.properties 
a2ccfe0e86512021c70e79e04242c16325435e0f 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 
fa16020361e05059e4d81dbb0c52e3ade1c9cdc6 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstanceSet.java
 388b5f3ab8154943ae8a6a5d387b6e3766480585 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java
 ef9de320c5c112bef6c5293e8caea980ade38eb1 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java
 740f3734d179d206b6f73407e0bea702f7464113 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapYarnRegistryImpl.java
 fc2ebf2347845325da2042dda05cfe6c1d2f983c 
  
llap-server/src/gen/protobuf/gen-java/org/apache/hadoop/hive/llap/daemon/rpc/LlapDaemonProtocolProtos.java
 d2180e55e8008b22d74efe6d155a16271e357f72 
  llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java 
ab4df5dbd9eac092b8691bcdfdf4aacbfbf80ce8 
  
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheMemoryManager.java
 992da8e78599174becf53063d310821369fca2a9 
  
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java
 84910d74269f61e010a0ce1061d2d3591d93e745 
  llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 
d6e1a6e68630f73ee5cf3acd6dc2acb5b01202a2 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/HistoryLogger.java 
3c9ad2427c2d9f5ca3c6dcea892bc29b7e8ac891 
  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/KilledTaskHandler.java 
7cb433bfd9c10ec678fbd022fb634aa9ee0643ea 
  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/QueryFailedHandler.java 
4e62a68f763c3c43324b2034885d260b8b214c9c 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/AMReporter.java 
f6711d80acf847f1babd6ef522b332a21a7ada61 
  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java
 0d85671381e00510959cb5e4ba5fd9f2220fbdf6 
  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/FunctionLocalizer.java
 PRE-CREATION 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 
ddedfbfb45841

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-27 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 28, 2016, 12:48 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  service/src/java/org/apache/hive/service/cli/CLIService.java 
0d5ae1e491bdcf98a12f5eef7b35f23c7b9dfc00 
  service/src/java/org/apache/hive/service/cli/SessionHandle.java 
4e4f0211de09408168c8da669626fb49f3db364c 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
3c5700bd114f6b792df10df23e57dad9b9e689f6 
  
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
 c56d97afc969ea57810e9b3222b20e086e847d67 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
de18f1d93502704e7a8fbb8d31d93bd770c4d232 
  service/src/test/org/apache/hive/service/cli/CLIServiceRestoreTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/41928/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-28 Thread Amareshwari Sriramadasu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/#review116920
---




service/src/java/org/apache/hive/service/cli/CLIService.java (line 207)


Can you rename method to createSessionWithHandle as suggested?



service/src/java/org/apache/hive/service/cli/session/SessionManager.java (line 
283)


Can we make it package private?



service/src/java/org/apache/hive/service/cli/session/SessionManager.java (line 
356)


Is this method required? Can CLIService directly call createSession ?


- Amareshwari Sriramadasu


On Jan. 28, 2016, 7:18 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41928/
> ---
> 
> (Updated Jan. 28, 2016, 7:18 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-12777
> https://issues.apache.org/jira/browse/HIVE-12777
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Extensions using Hive session handles should be able to restore the hive 
> session from the handle. 
> 
> Apache Lens depends on a fork of hive and that fork has such a capability. 
> 
> Relevant commit: 
> https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be
> 
> 
> Diffs
> -
> 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 
> 0d5ae1e491bdcf98a12f5eef7b35f23c7b9dfc00 
>   service/src/java/org/apache/hive/service/cli/SessionHandle.java 
> 4e4f0211de09408168c8da669626fb49f3db364c 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
> 3c5700bd114f6b792df10df23e57dad9b9e689f6 
>   
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
>  c56d97afc969ea57810e9b3222b20e086e847d67 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
> de18f1d93502704e7a8fbb8d31d93bd770c4d232 
>   service/src/test/org/apache/hive/service/cli/CLIServiceRestoreTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41928/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-28 Thread Rajat Khandelwal



> On Jan. 29, 2016, 12:44 p.m., Amareshwari Sriramadasu wrote:
> > service/src/java/org/apache/hive/service/cli/session/SessionManager.java, 
> > line 283
> > 
> >
> > Can we make it package private?

No, if this is to be used directly by cli service, it needs to be public.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/#review116920
---


On Jan. 28, 2016, 12:48 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41928/
> ---
> 
> (Updated Jan. 28, 2016, 12:48 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-12777
> https://issues.apache.org/jira/browse/HIVE-12777
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Extensions using Hive session handles should be able to restore the hive 
> session from the handle. 
> 
> Apache Lens depends on a fork of hive and that fork has such a capability. 
> 
> Relevant commit: 
> https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be
> 
> 
> Diffs
> -
> 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 
> 0d5ae1e491bdcf98a12f5eef7b35f23c7b9dfc00 
>   service/src/java/org/apache/hive/service/cli/SessionHandle.java 
> 4e4f0211de09408168c8da669626fb49f3db364c 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
> 3c5700bd114f6b792df10df23e57dad9b9e689f6 
>   
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
>  c56d97afc969ea57810e9b3222b20e086e847d67 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
> de18f1d93502704e7a8fbb8d31d93bd770c4d232 
>   service/src/test/org/apache/hive/service/cli/CLIServiceRestoreTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41928/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-28 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 29, 2016, 12:53 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  service/src/java/org/apache/hive/service/cli/CLIService.java 
0d5ae1e491bdcf98a12f5eef7b35f23c7b9dfc00 
  service/src/java/org/apache/hive/service/cli/SessionHandle.java 
4e4f0211de09408168c8da669626fb49f3db364c 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
3c5700bd114f6b792df10df23e57dad9b9e689f6 
  
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
 c56d97afc969ea57810e9b3222b20e086e847d67 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
de18f1d93502704e7a8fbb8d31d93bd770c4d232 
  service/src/test/org/apache/hive/service/cli/CLIServiceRestoreTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/41928/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-28 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/
---

(Updated Jan. 29, 2016, 12:54 p.m.)


Review request for hive.


Bugs: HIVE-12777
https://issues.apache.org/jira/browse/HIVE-12777


Repository: hive-git


Description
---

Extensions using Hive session handles should be able to restore the hive 
session from the handle. 

Apache Lens depends on a fork of hive and that fork has such a capability. 

Relevant commit: 
https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be


Diffs (updated)
-

  service/src/java/org/apache/hive/service/cli/CLIService.java 
0d5ae1e491bdcf98a12f5eef7b35f23c7b9dfc00 
  service/src/java/org/apache/hive/service/cli/SessionHandle.java 
4e4f0211de09408168c8da669626fb49f3db364c 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
3c5700bd114f6b792df10df23e57dad9b9e689f6 
  
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
 c56d97afc969ea57810e9b3222b20e086e847d67 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
de18f1d93502704e7a8fbb8d31d93bd770c4d232 
  service/src/test/org/apache/hive/service/cli/CLIServiceRestoreTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/41928/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 41928: HIVE-12777: Add capability to restore session

2016-01-29 Thread Amareshwari Sriramadasu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/#review116943
---


Ship it!




Ship It!

- Amareshwari Sriramadasu


On Jan. 29, 2016, 7:24 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41928/
> ---
> 
> (Updated Jan. 29, 2016, 7:24 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-12777
> https://issues.apache.org/jira/browse/HIVE-12777
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Extensions using Hive session handles should be able to restore the hive 
> session from the handle. 
> 
> Apache Lens depends on a fork of hive and that fork has such a capability. 
> 
> Relevant commit: 
> https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be
> 
> 
> Diffs
> -
> 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 
> 0d5ae1e491bdcf98a12f5eef7b35f23c7b9dfc00 
>   service/src/java/org/apache/hive/service/cli/SessionHandle.java 
> 4e4f0211de09408168c8da669626fb49f3db364c 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
> 3c5700bd114f6b792df10df23e57dad9b9e689f6 
>   
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
>  c56d97afc969ea57810e9b3222b20e086e847d67 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
> de18f1d93502704e7a8fbb8d31d93bd770c4d232 
>   service/src/test/org/apache/hive/service/cli/CLIServiceRestoreTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41928/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

Re: Review Request 41928: HIVE-12777: Add capability to restore session

31 matches

Site Navigation

Mail list logo

Footer information