Review Request 55605: HIVE-15166 - Provide beeline option to set the jline history max size

[Eric Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55605/
---

Review request for hive and Aihua Xu.


Bugs: HIVE-15166
https://issues.apache.org/jira/browse/HIVE-15166


Repository: hive-git


Description
---

Currently Beeline does not provide an option to limit the max size for beeline 
history file, in the case that each query is very big, it will flood the 
history file and slow down beeline on start up and shutdown.


Diffs
-

  beeline/src/java/org/apache/hive/beeline/BeeLine.java 65818dd 
  beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 9f330e3 
  beeline/src/main/resources/BeeLine.properties 141f0c6 
  beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java d73d374 

Diff: https://reviews.apache.org/r/55605/diff/


Testing
---

Manual testing + a simple test case.


Thanks,

Eric Lin

Re: Review Request 55605: HIVE-15166 - Provide beeline option to set the jline history max size

[Aihua Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55605/#review161865
---


Ship it!




Ship It!

- Aihua Xu


On Jan. 17, 2017, 7:22 a.m., Eric Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55605/
> ---
> 
> (Updated Jan. 17, 2017, 7:22 a.m.)
> 
> 
> Review request for hive and Aihua Xu.
> 
> 
> Bugs: HIVE-15166
> https://issues.apache.org/jira/browse/HIVE-15166
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Currently Beeline does not provide an option to limit the max size for 
> beeline history file, in the case that each query is very big, it will flood 
> the history file and slow down beeline on start up and shutdown.
> 
> 
> Diffs
> -
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 65818dd 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 9f330e3 
>   beeline/src/main/resources/BeeLine.properties 141f0c6 
>   beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java d73d374 
> 
> Diff: https://reviews.apache.org/r/55605/diff/
> 
> 
> Testing
> ---
> 
> Manual testing + a simple test case.
> 
> 
> Thanks,
> 
> Eric Lin
> 
>

Re: Review Request 55605: HIVE-15166 - Provide beeline option to set the jline history max size

[Aihua Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55605/#review161864
---




beeline/src/java/org/apache/hive/beeline/BeeLine.java (line 1185)


FileHistory implementation will load 500 (default) lines during this 
constructor (it's the limitation of FileHistory) and then will resize to the 
specified size.

Potentially there is a problem to see OOM, but I guess that's the best we 
can do right now to limit the output. The user in general wouldn't edit the 
history file.


- Aihua Xu


On Jan. 17, 2017, 7:22 a.m., Eric Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55605/
> ---
> 
> (Updated Jan. 17, 2017, 7:22 a.m.)
> 
> 
> Review request for hive and Aihua Xu.
> 
> 
> Bugs: HIVE-15166
> https://issues.apache.org/jira/browse/HIVE-15166
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Currently Beeline does not provide an option to limit the max size for 
> beeline history file, in the case that each query is very big, it will flood 
> the history file and slow down beeline on start up and shutdown.
> 
> 
> Diffs
> -
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 65818dd 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 9f330e3 
>   beeline/src/main/resources/BeeLine.properties 141f0c6 
>   beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java d73d374 
> 
> Diff: https://reviews.apache.org/r/55605/diff/
> 
> 
> Testing
> ---
> 
> Manual testing + a simple test case.
> 
> 
> Thanks,
> 
> Eric Lin
> 
>

Re: Review Request 55605: HIVE-15166 - Provide beeline option to set the jline history max size

[Eric Lin]

> On Jan. 17, 2017, 2:13 p.m., Aihua Xu wrote:
> > beeline/src/java/org/apache/hive/beeline/BeeLine.java, line 1185
> > 
> >
> > FileHistory implementation will load 500 (default) lines during this 
> > constructor (it's the limitation of FileHistory) and then will resize to 
> > the specified size.
> > 
> > Potentially there is a problem to see OOM, but I guess that's the best 
> > we can do right now to limit the output. The user in general wouldn't edit 
> > the history file.

Yes you are right, Aihua. At least for now we have an option to control the 
history row size.


- Eric


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55605/#review161864
---


On Jan. 17, 2017, 7:22 a.m., Eric Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55605/
> ---
> 
> (Updated Jan. 17, 2017, 7:22 a.m.)
> 
> 
> Review request for hive and Aihua Xu.
> 
> 
> Bugs: HIVE-15166
> https://issues.apache.org/jira/browse/HIVE-15166
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Currently Beeline does not provide an option to limit the max size for 
> beeline history file, in the case that each query is very big, it will flood 
> the history file and slow down beeline on start up and shutdown.
> 
> 
> Diffs
> -
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 65818dd 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 9f330e3 
>   beeline/src/main/resources/BeeLine.properties 141f0c6 
>   beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java d73d374 
> 
> Diff: https://reviews.apache.org/r/55605/diff/
> 
> 
> Testing
> ---
> 
> Manual testing + a simple test case.
> 
> 
> Thanks,
> 
> Eric Lin
> 
>

Re: Review Request 55605: HIVE-15166 - Provide beeline option to set the jline history max size

[Eric Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55605/
---

(Updated Jan. 19, 2017, 1:45 a.m.)


Review request for hive and Aihua Xu.


Changes
---

Have to move setMaxSize into shutdown hook as the options were not ready at the 
previous code location. Tested manually and confirmed working.


Bugs: HIVE-15166
https://issues.apache.org/jira/browse/HIVE-15166


Repository: hive-git


Description
---

Currently Beeline does not provide an option to limit the max size for beeline 
history file, in the case that each query is very big, it will flood the 
history file and slow down beeline on start up and shutdown.


Diffs (updated)
-

  beeline/src/java/org/apache/hive/beeline/BeeLine.java 65818dd 
  beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 9f330e3 
  beeline/src/main/resources/BeeLine.properties 141f0c6 
  beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java d73d374 

Diff: https://reviews.apache.org/r/55605/diff/


Testing
---

Manual testing + a simple test case.


Thanks,

Eric Lin

Re: Review Request 55605: HIVE-15166 - Provide beeline option to set the jline history max size

[Eric Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55605/
---

(Updated March 8, 2017, 10:27 a.m.)


Review request for hive and Aihua Xu.


Changes
---

Updated patch based on latest hive master branch


Bugs: HIVE-15166
https://issues.apache.org/jira/browse/HIVE-15166


Repository: hive-git


Description
---

Currently Beeline does not provide an option to limit the max size for beeline 
history file, in the case that each query is very big, it will flood the 
history file and slow down beeline on start up and shutdown.


Diffs (updated)
-

  beeline/src/java/org/apache/hive/beeline/BeeLine.java 3c8fccc 
  beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 9f330e3 
  beeline/src/main/resources/BeeLine.properties af86284 
  beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java d73d374 


Diff: https://reviews.apache.org/r/55605/diff/3/

Changes: https://reviews.apache.org/r/55605/diff/2-3/


Testing
---

Manual testing + a simple test case.


Thanks,

Eric Lin