Re: Review Request 66288: HIVE-18885 : DbNotificationListener has a deadlock between Java and DB locks (2.x line)

2018-03-27 Thread Peter Vary via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66288/#review200043
---


Ship it!




Ship It!

- Peter Vary


On March 26, 2018, 10:14 p.m., Vihang Karajgaonkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66288/
> ---
> 
> (Updated March 26, 2018, 10:14 p.m.)
> 
> 
> Review request for hive and Alexander Kolbasov.
> 
> 
> Bugs: HIVE-18885
> https://issues.apache.org/jira/browse/HIVE-18885
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-18885 : DbNotificationListener has a deadlock between Java and DB locks 
> (2.x line)
> 
> 
> Diffs
> -
> 
>   
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
>  41347c22df21a678241edeb766264e6d19c7885a 
> 
> 
> Diff: https://reviews.apache.org/r/66288/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vihang Karajgaonkar
> 
>

Re: Review Request 66288: HIVE-18885 : DbNotificationListener has a deadlock between Java and DB locks (2.x line)

2018-03-26 Thread Alexander Kolbasov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66288/#review27
---


Ship it!




Ship It!

- Alexander Kolbasov


On March 26, 2018, 10:14 p.m., Vihang Karajgaonkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66288/
> ---
> 
> (Updated March 26, 2018, 10:14 p.m.)
> 
> 
> Review request for hive and Alexander Kolbasov.
> 
> 
> Bugs: HIVE-18885
> https://issues.apache.org/jira/browse/HIVE-18885
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-18885 : DbNotificationListener has a deadlock between Java and DB locks 
> (2.x line)
> 
> 
> Diffs
> -
> 
>   
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
>  41347c22df21a678241edeb766264e6d19c7885a 
> 
> 
> Diff: https://reviews.apache.org/r/66288/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vihang Karajgaonkar
> 
>

Re: Review Request 66288: HIVE-18885 : DbNotificationListener has a deadlock between Java and DB locks (2.x line)

2018-03-26 Thread Vihang Karajgaonkar via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66288/
---

(Updated March 26, 2018, 10:14 p.m.)


Review request for hive and Alexander Kolbasov.


Changes
---

added Alexander's suggestions.


Bugs: HIVE-18885
https://issues.apache.org/jira/browse/HIVE-18885


Repository: hive-git


Description
---

HIVE-18885 : DbNotificationListener has a deadlock between Java and DB locks 
(2.x line)


Diffs (updated)
-

  
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
 41347c22df21a678241edeb766264e6d19c7885a 


Diff: https://reviews.apache.org/r/66288/diff/2/

Changes: https://reviews.apache.org/r/66288/diff/1-2/


Testing
---


Thanks,

Vihang Karajgaonkar

Re: Review Request 66288: HIVE-18885 : DbNotificationListener has a deadlock between Java and DB locks (2.x line)

2018-03-26 Thread Alexander Kolbasov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66288/#review14
---



The fix itself is fine, just some comments about comments.


hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
Line 71 (original), 71 (patched)


Nit: The first Javadoc sentence should not include links.



hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
Line 73 (original), 73 (patched)


Nit: Please use  for paragraph separation.



hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
Line 75 (original), 75 (patched)


s/puts//



hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
Line 76 (original), 76 (patched)


Can you add a description of how this event ID is generated. This is a very 
important piece of functionality.



hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
Lines 82 (patched)


Nit: use 



hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
Lines 87 (patched)


It is important to note that this is R/W lock and it is obtained using 
SELECT FOR UPDATE for the single row.



hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
Lines 89 (patched)


s/is can/is likely to/


- Alexander Kolbasov


On March 26, 2018, 7:42 p.m., Vihang Karajgaonkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66288/
> ---
> 
> (Updated March 26, 2018, 7:42 p.m.)
> 
> 
> Review request for hive and Alexander Kolbasov.
> 
> 
> Bugs: HIVE-18885
> https://issues.apache.org/jira/browse/HIVE-18885
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-18885 : DbNotificationListener has a deadlock between Java and DB locks 
> (2.x line)
> 
> 
> Diffs
> -
> 
>   
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
>  41347c22df21a678241edeb766264e6d19c7885a 
> 
> 
> Diff: https://reviews.apache.org/r/66288/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vihang Karajgaonkar
> 
>

Review Request 66288: HIVE-18885 : DbNotificationListener has a deadlock between Java and DB locks (2.x line)

2018-03-26 Thread Vihang Karajgaonkar via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66288/
---

Review request for hive and Alexander Kolbasov.


Repository: hive-git


Description
---

HIVE-18885 : DbNotificationListener has a deadlock between Java and DB locks 
(2.x line)


Diffs
-

  
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
 41347c22df21a678241edeb766264e6d19c7885a 


Diff: https://reviews.apache.org/r/66288/diff/1/


Testing
---


Thanks,

Vihang Karajgaonkar