Re: Review Request 69143: CachedStore: Add more UT coverage (outside of .q files)

2018-11-01 Thread Daniel Dai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69143/#review210272
---


Ship it!




Ship It!

- Daniel Dai


On Nov. 2, 2018, 12:46 a.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69143/
> ---
> 
> (Updated Nov. 2, 2018, 12:46 a.m.)
> 
> 
> Review request for hive, Daniel Dai and Thejas Nair.
> 
> 
> Bugs: HIVE-20613
> https://issues.apache.org/jira/browse/HIVE-20613
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-20613
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CacheUtils.java
>  944c81313a 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
>  70490f09e7 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/SharedCache.java
>  c24e7160ac 
>   
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java
>  bb20d9f42a 
>   standalone-metastore/metastore-server/src/test/resources/log4j2.properties 
> 365687e1c9 
> 
> 
> Diff: https://reviews.apache.org/r/69143/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

Re: Review Request 69143: CachedStore: Add more UT coverage (outside of .q files)

2018-11-01 Thread Vaibhav Gumashta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69143/
---

(Updated Nov. 2, 2018, 12:46 a.m.)


Review request for hive, Daniel Dai and Thejas Nair.


Bugs: HIVE-20613
https://issues.apache.org/jira/browse/HIVE-20613


Repository: hive-git


Description
---

https://issues.apache.org/jira/browse/HIVE-20613


Diffs (updated)
-

  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CacheUtils.java
 944c81313a 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
 70490f09e7 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/SharedCache.java
 c24e7160ac 
  
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java
 bb20d9f42a 
  standalone-metastore/metastore-server/src/test/resources/log4j2.properties 
365687e1c9 


Diff: https://reviews.apache.org/r/69143/diff/2/

Changes: https://reviews.apache.org/r/69143/diff/1-2/


Testing
---


Thanks,

Vaibhav Gumashta

Re: Review Request 69143: CachedStore: Add more UT coverage (outside of .q files)

2018-10-24 Thread Daniel Dai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69143/#review210011
---




standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
Lines 94 (patched)


Can you add a comment what's the difference between isCachePrewarmed?



standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
Lines 227 (patched)


Log full stack



standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
Lines 491 (patched)


Can you log the full stack trace (maybe using 
org.apache.hadoop.util.StringUtils.stringifyException)? There's another 
instance below.



standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
Lines 522 (patched)


Make maxTries a constant (and reuse it below).



standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
Lines 544 (patched)


maxTries should be constant.


- Daniel Dai


On Oct. 24, 2018, 5:04 p.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69143/
> ---
> 
> (Updated Oct. 24, 2018, 5:04 p.m.)
> 
> 
> Review request for hive, Daniel Dai and Thejas Nair.
> 
> 
> Bugs: HIVE-20613
> https://issues.apache.org/jira/browse/HIVE-20613
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-20613
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CacheUtils.java
>  944c81313a 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
>  70490f09e7 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/SharedCache.java
>  c24e7160ac 
>   
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java
>  bb20d9f42a 
>   standalone-metastore/metastore-server/src/test/resources/log4j2.properties 
> 365687e1c9 
> 
> 
> Diff: https://reviews.apache.org/r/69143/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

Review Request 69143: CachedStore: Add more UT coverage (outside of .q files)

2018-10-24 Thread Vaibhav Gumashta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69143/
---

Review request for hive, Daniel Dai and Thejas Nair.


Bugs: HIVE-20613
https://issues.apache.org/jira/browse/HIVE-20613


Repository: hive-git


Description
---

https://issues.apache.org/jira/browse/HIVE-20613


Diffs
-

  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CacheUtils.java
 944c81313a 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
 70490f09e7 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/SharedCache.java
 c24e7160ac 
  
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java
 bb20d9f42a 
  standalone-metastore/metastore-server/src/test/resources/log4j2.properties 
365687e1c9 


Diff: https://reviews.apache.org/r/69143/diff/1/


Testing
---


Thanks,

Vaibhav Gumashta