Re: Review requests for HIVE-22841 and HIVE-22539
Thanks Zoltan for the review. No worries things fall through the cracks all the time. I rebased the patches to make sure they still apply to master. Kevin Risden On Mon, Mar 16, 2020 at 6:35 AM Zoltan Haindrich wrote: > Hey Kevin! > > Unfortunately there are times when I stop checking for tickets which are > waiting for reviews... > I think we all might be a little bit busy with all kind of stuff nowadays. > > Thank you for taking the time and writing this email to draw attention to > that your patches are awaiting reviews. > > cheers, > Zoltan > > > On 3/10/20 10:02 PM, Kevin Risden wrote: > > I think I followed all the contribution guidelines so far and neither of > > these jiras have been reviewed so far. I can update the patches again > > against master (its been a month waiting since last patches on both), but > > would like to get a review before I sink more time into them. > > > > https://issues.apache.org/jira/browse/HIVE-22841 > > https://issues.apache.org/jira/browse/HIVE-22539 > > > > Kevin Risden > > >
Re: Review requests for HIVE-22841 and HIVE-22539
Hey Kevin! Unfortunately there are times when I stop checking for tickets which are waiting for reviews... I think we all might be a little bit busy with all kind of stuff nowadays. Thank you for taking the time and writing this email to draw attention to that your patches are awaiting reviews. cheers, Zoltan On 3/10/20 10:02 PM, Kevin Risden wrote: I think I followed all the contribution guidelines so far and neither of these jiras have been reviewed so far. I can update the patches again against master (its been a month waiting since last patches on both), but would like to get a review before I sink more time into them. https://issues.apache.org/jira/browse/HIVE-22841 https://issues.apache.org/jira/browse/HIVE-22539 Kevin Risden
Review requests for HIVE-22841 and HIVE-22539
I think I followed all the contribution guidelines so far and neither of these jiras have been reviewed so far. I can update the patches again against master (its been a month waiting since last patches on both), but would like to get a review before I sink more time into them. https://issues.apache.org/jira/browse/HIVE-22841 https://issues.apache.org/jira/browse/HIVE-22539 Kevin Risden
Re: Review requests & JIRA process
Thanks Sergey, unfortunately it's often not easy to figure that out but I'll try. So, anyone willing to do reviews on these: These are the issues in need of reviews: * <https://issues.apache.org/jira/browse/HIVE-7622> (huge but I'd appreciate an answer fast to avoid having to rebase it often) * <https://issues.apache.org/jira/browse/HIVE-7543> (relatively large) * <https://issues.apache.org/jira/browse/HIVE-6123> (tiny) * <https://issues.apache.org/jira/browse/HIVE-7107> (small) About HIVE-7622: I realize that these huge patches are annoying but I hope that they aren't required that often. The alternative are hundreds of small issues/patches like <https://issues.apache.org/jira/browse/HIVE-7760> etc. Not sure what you'd prefer. Cheers, Lars On Thu, Aug 7, 2014 at 11:49 PM, Sergey Shelukhin wrote: > I think the process that works best for getting patches reviewed is adding > specific people to RB/JIRA and asking, usually the people who are active in > a related area of code. And nagging them until they either review or refuse > to review :) > > > On Thu, Aug 7, 2014 at 4:31 AM, Lars Francke > wrote: > > > Hey, > > > > just wanted to bump this in case anyone has any opinions as well as what > > the procedure is for patches that don't get a review for a longer period > of > > time. I'd like to avoid a lot of unnecessary work on my end :) > > > > Cheers, > > Lars > > > > > > On Wed, Aug 6, 2014 at 1:15 AM, Lars Francke > > wrote: > > > > > Hi everyone, > > > > > > I have a couple of review requests that I'd love for someone to look > at. > > > I'll list them below. I have however two more questions. > > > > > > Two of my issues are clean ups of existing code (HIVE-7622 & > HIVE-7543). > > I > > > realize that they don't bring immediate benefit and I had planned to > fix > > > some more of the issues Checkstyle, my IDE and SonarQube[1] complain > > about. > > > Is this okay for you guys or would you rather I stop this? I ask > because > > > they take a significant amount of time not only for myself but also > for a > > > reviewer and they go stale fast. I think it helps to have a clean > > codebase > > > for what it's worth. > > > > > > The second question is about the JIRA process: What's the best way to > get > > > someone to review patches? I currently always create a review, attach > the > > > patch to the Issue and set it to PATCH AVAILABLE. The documentation is > > not > > > quite clear about the process[2]. > > > > > > These are the issues in need of reviews: > > > > > > * <https://issues.apache.org/jira/browse/HIVE-7622> (huge but I'd > > > appreciate an answer fast to avoid having to rebase it often) > > > * <https://issues.apache.org/jira/browse/HIVE-7543> > > > * <https://issues.apache.org/jira/browse/HIVE-6123> > > > * <https://issues.apache.org/jira/browse/HIVE-7107> > > > > > > Thanks! > > > > > > Cheers, > > > Lars > > > > > > [1] <http://www.sonarqube.org/> I have a publicly accessible server > set > > > up with Hive analyzed, happy to send the link to anyone interested > > > http://i.imgur.com/e3KjR26.png > > > > > > [2] < > > > > > > https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-MakingChanges > > > > > > > > > > > -- > CONFIDENTIALITY NOTICE > NOTICE: This message is intended for the use of the individual or entity to > which it is addressed and may contain information that is confidential, > privileged and exempt from disclosure under applicable law. If the reader > of this message is not the intended recipient, you are hereby notified that > any printing, copying, dissemination, distribution, disclosure or > forwarding of this communication is strictly prohibited. If you have > received this communication in error, please contact the sender immediately > and delete it from your system. Thank You. >
Re: Review requests & JIRA process
I think the process that works best for getting patches reviewed is adding specific people to RB/JIRA and asking, usually the people who are active in a related area of code. And nagging them until they either review or refuse to review :) On Thu, Aug 7, 2014 at 4:31 AM, Lars Francke wrote: > Hey, > > just wanted to bump this in case anyone has any opinions as well as what > the procedure is for patches that don't get a review for a longer period of > time. I'd like to avoid a lot of unnecessary work on my end :) > > Cheers, > Lars > > > On Wed, Aug 6, 2014 at 1:15 AM, Lars Francke > wrote: > > > Hi everyone, > > > > I have a couple of review requests that I'd love for someone to look at. > > I'll list them below. I have however two more questions. > > > > Two of my issues are clean ups of existing code (HIVE-7622 & HIVE-7543). > I > > realize that they don't bring immediate benefit and I had planned to fix > > some more of the issues Checkstyle, my IDE and SonarQube[1] complain > about. > > Is this okay for you guys or would you rather I stop this? I ask because > > they take a significant amount of time not only for myself but also for a > > reviewer and they go stale fast. I think it helps to have a clean > codebase > > for what it's worth. > > > > The second question is about the JIRA process: What's the best way to get > > someone to review patches? I currently always create a review, attach the > > patch to the Issue and set it to PATCH AVAILABLE. The documentation is > not > > quite clear about the process[2]. > > > > These are the issues in need of reviews: > > > > * <https://issues.apache.org/jira/browse/HIVE-7622> (huge but I'd > > appreciate an answer fast to avoid having to rebase it often) > > * <https://issues.apache.org/jira/browse/HIVE-7543> > > * <https://issues.apache.org/jira/browse/HIVE-6123> > > * <https://issues.apache.org/jira/browse/HIVE-7107> > > > > Thanks! > > > > Cheers, > > Lars > > > > [1] <http://www.sonarqube.org/> I have a publicly accessible server set > > up with Hive analyzed, happy to send the link to anyone interested > > http://i.imgur.com/e3KjR26.png > > > > [2] < > > > https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-MakingChanges > > > > > > -- CONFIDENTIALITY NOTICE NOTICE: This message is intended for the use of the individual or entity to which it is addressed and may contain information that is confidential, privileged and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, you are hereby notified that any printing, copying, dissemination, distribution, disclosure or forwarding of this communication is strictly prohibited. If you have received this communication in error, please contact the sender immediately and delete it from your system. Thank You.
Re: Review requests & JIRA process
Hey, just wanted to bump this in case anyone has any opinions as well as what the procedure is for patches that don't get a review for a longer period of time. I'd like to avoid a lot of unnecessary work on my end :) Cheers, Lars On Wed, Aug 6, 2014 at 1:15 AM, Lars Francke wrote: > Hi everyone, > > I have a couple of review requests that I'd love for someone to look at. > I'll list them below. I have however two more questions. > > Two of my issues are clean ups of existing code (HIVE-7622 & HIVE-7543). I > realize that they don't bring immediate benefit and I had planned to fix > some more of the issues Checkstyle, my IDE and SonarQube[1] complain about. > Is this okay for you guys or would you rather I stop this? I ask because > they take a significant amount of time not only for myself but also for a > reviewer and they go stale fast. I think it helps to have a clean codebase > for what it's worth. > > The second question is about the JIRA process: What's the best way to get > someone to review patches? I currently always create a review, attach the > patch to the Issue and set it to PATCH AVAILABLE. The documentation is not > quite clear about the process[2]. > > These are the issues in need of reviews: > > * <https://issues.apache.org/jira/browse/HIVE-7622> (huge but I'd > appreciate an answer fast to avoid having to rebase it often) > * <https://issues.apache.org/jira/browse/HIVE-7543> > * <https://issues.apache.org/jira/browse/HIVE-6123> > * <https://issues.apache.org/jira/browse/HIVE-7107> > > Thanks! > > Cheers, > Lars > > [1] <http://www.sonarqube.org/> I have a publicly accessible server set > up with Hive analyzed, happy to send the link to anyone interested > http://i.imgur.com/e3KjR26.png > > [2] < > https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-MakingChanges > > >
Review requests & JIRA process
Hi everyone, I have a couple of review requests that I'd love for someone to look at. I'll list them below. I have however two more questions. Two of my issues are clean ups of existing code (HIVE-7622 & HIVE-7543). I realize that they don't bring immediate benefit and I had planned to fix some more of the issues Checkstyle, my IDE and SonarQube[1] complain about. Is this okay for you guys or would you rather I stop this? I ask because they take a significant amount of time not only for myself but also for a reviewer and they go stale fast. I think it helps to have a clean codebase for what it's worth. The second question is about the JIRA process: What's the best way to get someone to review patches? I currently always create a review, attach the patch to the Issue and set it to PATCH AVAILABLE. The documentation is not quite clear about the process[2]. These are the issues in need of reviews: * <https://issues.apache.org/jira/browse/HIVE-7622> (huge but I'd appreciate an answer fast to avoid having to rebase it often) * <https://issues.apache.org/jira/browse/HIVE-7543> * <https://issues.apache.org/jira/browse/HIVE-6123> * <https://issues.apache.org/jira/browse/HIVE-7107> Thanks! Cheers, Lars [1] <http://www.sonarqube.org/> I have a publicly accessible server set up with Hive analyzed, happy to send the link to anyone interested http://i.imgur.com/e3KjR26.png [2] < https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-MakingChanges >
Re: Review Requests
Would someone have a chance to take a quick look at these review requests[1][2]. [1] https://reviews.apache.org/r/9275/ [2] https://reviews.apache.org/r/9276/ Thanks, On Tue, Feb 5, 2013 at 10:00 AM, kulkarni.swar...@gmail.com < kulkarni.swar...@gmail.com> wrote: > Thanks Mark. Appreciate that. I'll take a look. > > > On Mon, Feb 4, 2013 at 10:23 PM, Mark Grover > wrote: > >> Swarnim, >> I left some comments on reviewboard. >> >> On Mon, Feb 4, 2013 at 8:00 AM, kulkarni.swar...@gmail.com < >> kulkarni.swar...@gmail.com> wrote: >> >> > Hello, >> > >> > I opened up two reviews for small issues, HIVE-3553[1] and >> HIVE-3725[2]. If >> > you guys get a chance to review and provide feedback on it, I will >> really >> > appreciate. >> > >> > Thanks, >> > >> > [1] https://reviews.apache.org/r/9275/ >> > [2] https://reviews.apache.org/r/9276/ >> > >> > -- >> > Swarnim >> > >> > > > > -- > Swarnim > -- Swarnim
Re: Review Requests
Thanks Mark. Appreciate that. I'll take a look. On Mon, Feb 4, 2013 at 10:23 PM, Mark Grover wrote: > Swarnim, > I left some comments on reviewboard. > > On Mon, Feb 4, 2013 at 8:00 AM, kulkarni.swar...@gmail.com < > kulkarni.swar...@gmail.com> wrote: > > > Hello, > > > > I opened up two reviews for small issues, HIVE-3553[1] and HIVE-3725[2]. > If > > you guys get a chance to review and provide feedback on it, I will really > > appreciate. > > > > Thanks, > > > > [1] https://reviews.apache.org/r/9275/ > > [2] https://reviews.apache.org/r/9276/ > > > > -- > > Swarnim > > > -- Swarnim
Re: Review Requests
Swarnim, I left some comments on reviewboard. On Mon, Feb 4, 2013 at 8:00 AM, kulkarni.swar...@gmail.com < kulkarni.swar...@gmail.com> wrote: > Hello, > > I opened up two reviews for small issues, HIVE-3553[1] and HIVE-3725[2]. If > you guys get a chance to review and provide feedback on it, I will really > appreciate. > > Thanks, > > [1] https://reviews.apache.org/r/9275/ > [2] https://reviews.apache.org/r/9276/ > > -- > Swarnim >
Review Requests
Hello, I opened up two reviews for small issues, HIVE-3553[1] and HIVE-3725[2]. If you guys get a chance to review and provide feedback on it, I will really appreciate. Thanks, [1] https://reviews.apache.org/r/9275/ [2] https://reviews.apache.org/r/9276/ -- Swarnim
