[PATCH 11035] Patch review request
Hi, I am Basant. I work in web tier group of Sun Microsystems Inc. Can some of the committers kindly review the patch for bug 11035 please? Subject : Apache adds double entries to headers generated by CGI URI : http://issues.apache.org/bugzilla/show_bug.cgi?id=11035 Thanks and Regards, Basant.
question about mod_dbd.c / apr_dbd.c
Hi all, I was just trying to get the mod_dbd /apr_dbd stuff working for NetWare, and would like to make a suggestion regarding the DSO extension: in apr_dbd.c we have this: #ifdef WIN32 sprintf(path, "apr_dbd_%s.dll", name); #else apr_snprintf(path, sizeof path, APU_DSO_LIBDIR "/apr_dbd_%s.so", name); #endif there I'm asking me why for Win32 we have '.dll' extension although the modules are named '.so' as on Unix? Anyway, for NetWare we need '.nlm' since our compiler is too stupid to deal properly with '.so'. Then I see in mod_dbd.c this: return apr_psprintf(cmd->pool, "DBD: Can't load driver file apr_dbd_%s.so", cfg->name); so here we print out '.so' extension conditionless. Therefore I want to suggest to introduce a new define for apr.h, f.e. #define APR_DSO_EXT "so" and for NetWare we can then use: #define APR_DSO_EXT "nlm" for Win32 I'd suggest that we constantly use "so" too since the modules have this ending already please let me know if you agree with that or not so that I can prepare the proper patches. thanks, Guenter.
Re: [PATCH] add experimental modules makefiles for NetWare
Hi, > Already done in trunk. I still need to add them to 2.2 branch thanks! Guenter.
Re: apreqXXXXXX temp files remain after processing uploads greater than 256kb. Further large upload fails
On Sat, 10 Mar 2007, Vinay Y S wrote: On 3/9/07, Joe Schaefer <[EMAIL PROTECTED]> wrote: flag = APR_CREATE | APR_READ | APR_WRITE | APR_EXCL | APR_BINARY; /* Win32 needs the following to remove temp files. * XXX: figure out why the APR_SHARELOCK flag works; * a grep through the httpd sources seems to indicate * it's only used in sdbm files?? */ #ifdef WIN32 flag |= APR_FILE_NOCLEANUP | APR_SHARELOCK; #endif rc = apr_file_mktemp(fp, tmpl, flag, pool); Randy, do you know why we use the APR_FILE_NOCLEANUP flag? Maybe we should just remove that and see if it fixes the problem Vinay is seeing. Yes, removing APR_FILE_NOCLEANUP does exactly the same thing as my patch. Rather, we can remove the whole #ifdef WIN32 as APR_SHARELOCK isn't used for anything in file_io on win32 today. I'll have to look at this - there's a discussion at http://marc.theaimsgroup.com/?t=11533762941&r=1&w=2 of why this was introduced. I remember that this was a frustrating issue, as something that worked on one system in removing temp files didn't work on another (at least between Steve and myself). What was committed seemed to work "most" of the time for "most" systems, at least at that time. -- best regards, Randy
Re: apreqXXXXXX temp files remain after processing uploads greater than 256kb. Further large upload fails
On 3/9/07, Joe Schaefer <[EMAIL PROTECTED]> wrote: flag = APR_CREATE | APR_READ | APR_WRITE | APR_EXCL | APR_BINARY; /* Win32 needs the following to remove temp files. * XXX: figure out why the APR_SHARELOCK flag works; * a grep through the httpd sources seems to indicate * it's only used in sdbm files?? */ #ifdef WIN32 flag |= APR_FILE_NOCLEANUP | APR_SHARELOCK; #endif rc = apr_file_mktemp(fp, tmpl, flag, pool); Randy, do you know why we use the APR_FILE_NOCLEANUP flag? Maybe we should just remove that and see if it fixes the problem Vinay is seeing. Yes, removing APR_FILE_NOCLEANUP does exactly the same thing as my patch. Rather, we can remove the whole #ifdef WIN32 as APR_SHARELOCK isn't used for anything in file_io on win32 today. -- Vinay Y S
Re: [PATCH] add experimental modules makefiles for NetWare
>>> On 3/9/2007 at 11:22 AM, in message <[EMAIL PROTECTED]>, Guenter Knauf <[EMAIL PROTECTED]> wrote: > Hi Brad, > can you please commit the attached makefiles to the 'experimental' modules > folder, > and patch the existing NWGNUmakefile in order to pick up the new ones? > Since its no code change probably also for the 2.2.x line? > > thanks, Guenter Already done in trunk. I still need to add them to 2.2 branch Brad
Re: cleaned up dist/httpd/binaries
Joshua Slive wrote: > I just deleted all our binary releases from before 2005 that were > sitting in our "recommended" releases directory. They are, of course, > all still available from archive.apache.org. +1 - I offered up that we aught to purge all majorly insecure versions a while back - thank you for the followup!
cleaned up dist/httpd/binaries
I just deleted all our binary releases from before 2005 that were sitting in our "recommended" releases directory. They are, of course, all still available from archive.apache.org. With the exception of a few platforms, we just aren't in the business of providing binaries anymore. I don't think that is a particular problem. But it is a problem to leave a bunch of outdated releases in a place that implies that they should be used. Joshua.
[PATCH] add experimental modules makefiles for NetWare
Hi Brad, can you please commit the attached makefiles to the 'experimental' modules folder, and patch the existing NWGNUmakefile in order to pick up the new ones? Since its no code change probably also for the 2.2.x line? thanks, Guenter. NWGNUmakefile.diff Description: Binary data NWGNUcase_flt_in Description: Binary data NWGNUcase_flt Description: Binary data
Re: apreqXXXXXX temp files remain after processing uploads greater than 256kb. Further large upload fails
"Vinay Y S" <[EMAIL PROTECTED]> writes: > There is a problem with apreq temp file cleanup on win32. For each > POST request with POST body greater than 256KB, TWO temp files of > exact same size get created in temp directory and they are not deleted > even after the request is handled. They get deleted when apache server > is stopped. Thanks for the detailed report and patch! What version of apr are you using? The reason I ask is because whenever you open a file, normally a pool cleanup hook is registered to close it. apreq_file_mktemp() expects the pool cleanup implicit in the apr_file_mktemp() call to close the file, so I'm wondering why that's not happening in your situation. -- Joe Schaefer
Re: apreqXXXXXX temp files remain after processing uploads greater than 256kb. Further large upload fails
Joe Schaefer <[EMAIL PROTECTED]> writes: > "Vinay Y S" <[EMAIL PROTECTED]> writes: > >> There is a problem with apreq temp file cleanup on win32. For each >> POST request with POST body greater than 256KB, TWO temp files of >> exact same size get created in temp directory and they are not deleted >> even after the request is handled. They get deleted when apache server >> is stopped. > > Thanks for the detailed report and patch! > What version of apr are you using? The reason I ask is > because whenever you open a file, normally a pool cleanup hook is > registered to close it. Ah, I see now. I should have looked at the source before opening my mouth ;-): flag = APR_CREATE | APR_READ | APR_WRITE | APR_EXCL | APR_BINARY; /* Win32 needs the following to remove temp files. * XXX: figure out why the APR_SHARELOCK flag works; * a grep through the httpd sources seems to indicate * it's only used in sdbm files?? */ #ifdef WIN32 flag |= APR_FILE_NOCLEANUP | APR_SHARELOCK; #endif rc = apr_file_mktemp(fp, tmpl, flag, pool); Randy, do you know why we use the APR_FILE_NOCLEANUP flag? Maybe we should just remove that and see if it fixes the problem Vinay is seeing. -- Joe Schaefer
