Re: [VOTE] Release httpd-2.4.46
Le 01/08/2020 à 16:13, Daniel Ruggeri a écrit : Hi, all; Third time is a charm! Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball as 2.4.46: [X] +1: It's not just good, it's good enough! [ ] +0: Let's have a talk. [ ] -1: There's trouble in paradise. Here's what's wrong. The computed digests of the tarball up for vote are: sha1: 15adb7eb3dc97e89c8a4237901a9d6887056ab98 *httpd-2.4.46.tar.gz sha256: 44b759ce932dc090c0e75c0210b4485ebf6983466fb8ca1b446c8168e1a1aec2 *httpd-2.4.46.tar.gz sha512: 5801c1dd0365f706a5e2365e58599b5adac674f3c66b0f39249909841e6cdf16bfdfe001fbd668f323bf7b6d14b116b5e7af49867d456336fad5e685ba020b15 *httpd-2.4.46.tar.gz The SVN tag is '2.4.46' at r1880505. +1 Tested on Ubuntu 20.04 Gcc 9.3.0 maintainer-mode APR latest 1.7.x branch (i.e 1.7.0+) APR-UTIL latest 1.6.x branch (i.e 1.6.1+) Tested with event, prefork, worker Thx for RMing. CJ
First impressions from OpenSSL 3.0.0 and httpd 2.4.45
Hi there, during release testing for 2.4.45 I also built and tested using OpenSSL 3.0.0alpha5 on the server. Overall first results are pretty good: - a few deprecation warnings during compilation: modules/ssl/ssl_engine_config.c:610:5: warning: 'ENGINE_by_id' is deprecated [-Wdeprecated-declarations] modules/ssl/ssl_engine_config.c:612:9: warning: 'ENGINE_free' is deprecated [-Wdeprecated-declarations] modules/ssl/ssl_engine_config.c:617:9: warning: 'ENGINE_get_first' is deprecated [-Wdeprecated-declarations] modules/ssl/ssl_engine_config.c:619:13: warning: 'ENGINE_get_id' is deprecated [-Wdeprecated-declarations] modules/ssl/ssl_engine_config.c:620:42: warning: 'ENGINE_get_name' is deprecated [-Wdeprecated-declarations] modules/ssl/ssl_engine_config.c:623:13: warning: 'ENGINE_get_next' is deprecated [-Wdeprecated-declarations] modules/ssl/ssl_engine_init.c:457:9: warning: 'ENGINE_by_id' is deprecated [-Wdeprecated-declarations] modules/ssl/ssl_engine_init.c:467:13: warning: 'ENGINE_ctrl' is deprecated [-Wdeprecated-declarations] modules/ssl/ssl_engine_init.c:471:9: warning: 'ENGINE_set_default' is deprecated [-Wdeprecated-declarations] modules/ssl/ssl_engine_init.c:482:9: warning: 'ENGINE_free' is deprecated [-Wdeprecated-declarations] modules/ssl/ssl_engine_kernel.c:2611:9: warning: 'HMAC_Init_ex' is deprecated [-Wdeprecated-declarations] modules/ssl/ssl_engine_kernel.c:2632:9: warning: 'HMAC_Init_ex' is deprecated [-Wdeprecated-declarations] modules/ssl/ssl_engine_log.c:90:5: warning: 'ERR_peek_error_line_data' is deprecated [-Wdeprecated-declarations] modules/ssl/ssl_engine_pphrase.c:856:5: warning: 'ENGINE_by_id' is deprecated [-Wdeprecated-declarations] modules/ssl/ssl_engine_pphrase.c:864:5: warning: 'ENGINE_init' is deprecated [-Wdeprecated-declarations] modules/ssl/ssl_engine_pphrase.c:877:9: warning: 'ENGINE_ctrl_cmd_string' is deprecated [-Wdeprecated-declarations] modules/ssl/ssl_engine_pphrase.c:886:9: warning: 'ENGINE_ctrl_cmd' is deprecated [-Wdeprecated-declarations] modules/ssl/ssl_engine_pphrase.c:896:5: warning: 'ENGINE_load_private_key' is deprecated [-Wdeprecated-declarations] modules/ssl/ssl_engine_pphrase.c:904:5: warning: 'ENGINE_finish' is deprecated [-Wdeprecated-declarations] modules/ssl/ssl_engine_pphrase.c:905:5: warning: 'ENGINE_free' is deprecated [-Wdeprecated-declarations] - a few const warnings modules/ssl/ssl_engine_kernel.c:608:55: warning: passing argument 2 of 'sk_SSL_CIPHER_find' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] modules/ssl/ssl_engine_kernel.c:627:61: warning: passing argument 2 of 'sk_SSL_CIPHER_find' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] modules/ssl/ssl_engine_kernel.c:638:57: warning: passing argument 2 of 'sk_SSL_CIPHER_find' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] modules/ssl/ssl_engine_kernel.c:1039:49: warning: passing argument 2 of 'sk_SSL_CIPHER_find' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] and unit tests show two problems, one will be fixed in OpenSSL itself: - during unit test preparation, our test script create a PKCS12 store with default encoding params. That's known to be broken in alpha5. So the "-configure" step of "t/TEST" should be run before the actual testing with a stable version of OpenSSL. https://github.com/openssl/openssl/pull/12540 https://github.com/openssl/openssl/issues/11672 - independent of OpenSSL 3.0.0: to work around the previous observation I tried using the env var "APACHE_TEST_OPENSSL_CMD". Unfortunately this is slightly broken, because it tests for the existence using the "which" function in TestConfig.pm and that function is broken when used for a command containing a path component. I temporarily fixed it using: @@ -1782,6 +1782,11 @@ return undef unless $program; +# No need to search PATH components +# if $program already contains a path +return $program if !OSX and !WINFU and +$program =~ /\// and -f $program and -x $program; + my @dirs = File::Spec->path(); require Config; - when testing with client >= OpenSSL 1.1.0 against 3.0.0alpha5, only t/ssl/proxy.t shows failures, especially in eat_post but already during TLS handshake: [ssl:info] [pid 9162:tid 140326149928720] [client 127.0.0.1:56312] AH01964: Connection to child 82 established (server localhost:8532) [ssl:info] [pid 9162:tid 140326166714128] [remote 127.0.0.1:8532] AH02276: Certificate Verification: Error (3): unable to get certificate CRL [subject: emailAddress=test-...@httpd.apache.org,CN=localhost,OU=httpd-test/rsa-test,O=ASF,L=San Francisco,ST=California,C=US / issuer: emailAddress=test-...@httpd.apache.org,CN=ca,OU=httpd-test,O=ASF,L=San Francisco,ST=California,C=US / serial: 0C / notbefore: Jul 30 23:29:05 2020 GMT / notafter: Jul 30 23:29:05 2021 GMT] [ssl:info] [pid 9162:tid 140326149928720] [client
Passed: apache/httpd#1041 (2.4.46 - 8064ccc)
Build Update for apache/httpd - Build: #1041 Status: Passed Duration: 13 mins and 39 secs Commit: 8064ccc (2.4.46) Author: Daniel Ruggeri Message: Tag HEAD of 2.4.x as 2.4.46 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/tags/2.4.46@1880504 13f79535-47bb-0310-9956-ffa450edef68 View the changeset: https://github.com/apache/httpd/commit/8064ccc50bff View the full build log and details: https://travis-ci.org/github/apache/httpd/builds/713993495?utm_medium=notification_source=email -- You can unsubscribe from build emails from the apache/httpd repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=69847_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.
Re: [VOTE] Release httpd-2.4.46
Date in announcement is still : September 21, 2018 > Op 1 aug. 2020 om 16:13 heeft Daniel Ruggeri het > volgende geschreven: > > Hi, all; >Third time is a charm! Please find below the proposed release tarball > and signatures: > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release this > candidate tarball as 2.4.46: > [ ] +1: It's not just good, it's good enough! > [ ] +0: Let's have a talk. > [ ] -1: There's trouble in paradise. Here's what's wrong. > > The computed digests of the tarball up for vote are: > sha1: 15adb7eb3dc97e89c8a4237901a9d6887056ab98 *httpd-2.4.46.tar.gz > sha256: 44b759ce932dc090c0e75c0210b4485ebf6983466fb8ca1b446c8168e1a1aec2 > *httpd-2.4.46.tar.gz > sha512: > 5801c1dd0365f706a5e2365e58599b5adac674f3c66b0f39249909841e6cdf16bfdfe001fbd668f323bf7b6d14b116b5e7af49867d456336fad5e685ba020b15 > *httpd-2.4.46.tar.gz > > The SVN tag is '2.4.46' at r1880505. > > -- > Daniel Ruggeri > >
Re: svn commit: r1880502 - /httpd/httpd/branches/2.4.x/CHANGES
Sure - I'll commit the following: *) mod_proxy_fcgi: Fix missing APLOGNO macro argument Straight forward enough. Thanks for the correction. -- Daniel Ruggeri On 8/1/2020 9:14 AM, Steffen wrote: > Not agree. Fixes APLOGNO it for all platforms. Only I reported warnings on > Windows. Maybe on other platforms it is suppressed. > > No credit for me, used to it. > > See also my comment on an other post @dev : > > Below said : *) mod_proxy_fcgi: Fix build on Windows > > Not agree, just say what really happened. > > Better : *) mod_proxy_fcgi: Fix missing macro argument > > No, not a fix for build on windows only, was/is building fine. APLOGNO is > used on all platforms, only a list of warnings from my Windows build was > showing a APLOGNO warning. > > >> Op 1 aug. 2020 om 16:06 heeft drugg...@apache.org het volgende geschreven: >> >> Author: druggeri >> Date: Sat Aug 1 14:06:07 2020 >> New Revision: 1880502 >> >> URL: http://svn.apache.org/viewvc?rev=1880502=rev >> Log: >> Note the one change with 2.4.46 before reroll >> >> Modified: >>httpd/httpd/branches/2.4.x/CHANGES >> >> Modified: httpd/httpd/branches/2.4.x/CHANGES >> URL: >> http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/CHANGES?rev=1880502=1880501=1880502=diff >> == >> --- httpd/httpd/branches/2.4.x/CHANGES [utf-8] (original) >> +++ httpd/httpd/branches/2.4.x/CHANGES [utf-8] Sat Aug 1 14:06:07 2020 >> @@ -1,5 +1,7 @@ >> -*- coding: utf-8 >> -*- >> Changes with Apache 2.4.46 >> + *) mod_proxy_fcgi: Fix build warnings for Windows platform >> + [Eric Covener, Christophe Jaillet] >> >> Changes with Apache 2.4.45 >> >> >>
Re: svn commit: r1880502 - /httpd/httpd/branches/2.4.x/CHANGES
Not agree. Fixes APLOGNO it for all platforms. Only I reported warnings on Windows. Maybe on other platforms it is suppressed. No credit for me, used to it. See also my comment on an other post @dev : Below said : *) mod_proxy_fcgi: Fix build on Windows Not agree, just say what really happened. Better : *) mod_proxy_fcgi: Fix missing macro argument No, not a fix for build on windows only, was/is building fine. APLOGNO is used on all platforms, only a list of warnings from my Windows build was showing a APLOGNO warning. > Op 1 aug. 2020 om 16:06 heeft drugg...@apache.org het volgende geschreven: > > Author: druggeri > Date: Sat Aug 1 14:06:07 2020 > New Revision: 1880502 > > URL: http://svn.apache.org/viewvc?rev=1880502=rev > Log: > Note the one change with 2.4.46 before reroll > > Modified: >httpd/httpd/branches/2.4.x/CHANGES > > Modified: httpd/httpd/branches/2.4.x/CHANGES > URL: > http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/CHANGES?rev=1880502=1880501=1880502=diff > == > --- httpd/httpd/branches/2.4.x/CHANGES [utf-8] (original) > +++ httpd/httpd/branches/2.4.x/CHANGES [utf-8] Sat Aug 1 14:06:07 2020 > @@ -1,5 +1,7 @@ > -*- coding: utf-8 -*- > Changes with Apache 2.4.46 > + *) mod_proxy_fcgi: Fix build warnings for Windows platform > + [Eric Covener, Christophe Jaillet] > > Changes with Apache 2.4.45 > > >
[VOTE] Release httpd-2.4.46
Hi, all; Third time is a charm! Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball as 2.4.46: [ ] +1: It's not just good, it's good enough! [ ] +0: Let's have a talk. [ ] -1: There's trouble in paradise. Here's what's wrong. The computed digests of the tarball up for vote are: sha1: 15adb7eb3dc97e89c8a4237901a9d6887056ab98 *httpd-2.4.46.tar.gz sha256: 44b759ce932dc090c0e75c0210b4485ebf6983466fb8ca1b446c8168e1a1aec2 *httpd-2.4.46.tar.gz sha512: 5801c1dd0365f706a5e2365e58599b5adac674f3c66b0f39249909841e6cdf16bfdfe001fbd668f323bf7b6d14b116b5e7af49867d456336fad5e685ba020b15 *httpd-2.4.46.tar.gz The SVN tag is '2.4.46' at r1880505. -- Daniel Ruggeri
Re: Pending fixes or reroll? Was: [RESULT] [VOTE] Release httpd-2.4.45
Agreed - thank you (everyone) for the quick rally to fix this and for confirming we don't have other work needing to be done. I apologize for taking almost 24 hours to ACK and get us moving again. I've updated CHANGES and will send a VOTE shortly -- Daniel Ruggeri On 7/31/2020 1:28 PM, Rainer Jung wrote: > Since here were lots of "good-to-go, let's roll" one note though: the > current CHANGES does not yet a section for 2.4.46, cause normally > APLOGNO doesn't get noted on CHANGES. In this case it might be > something like > > *) mod_proxy_fcgi: Fix build on Windows. > > and credits for Eric (who fixed it on trunk) oand/or Christophe, who > backported it. > > Best regards, > > Rainer > > Am 31.07.2020 um 15:36 schrieb Rainer Jung: >> Since there wasn't yet any reaction to Daniel's question: Is anybody >> right now working on more warnings fixes for Windows? >> >> The most prominent one (missing APLOGNo number = missing macro >> argument) IMHO was already fixed by Christophe in r1880438. Anything >> else worth waiting for or are we (is Daniel) good to go for 2.4.46? >> >> Concerning lua I'd say the fix(es) for 5.4.0 need a bit more testing. >> >> Regards, >> >> Rainer >> >> Am 30.07.2020 um 22:26 schrieb Daniel Ruggeri: >>> Hi, all; >>> I thank everyone for their testing and quick feedback. While we had >>> enough votes and positive feedback, we have some easily fixable >>> warnings >>> which have precedence for holding up a release. >>> >>> To that end, I will close this vote and declare 2.4.45 dead on >>> the vine. >>> >>> I will roll 2.4.46 when we are all buttoned up with the warnings.
Passed: apache/httpd#1038 (trunk - 5e55dea)
Build Update for apache/httpd - Build: #1038 Status: Passed Duration: 19 mins and 6 secs Commit: 5e55dea (trunk) Author: Christophe Jaillet Message: Merge 2 loops in order to save a few cycles. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1880501 13f79535-47bb-0310-9956-ffa450edef68 View the changeset: https://github.com/apache/httpd/compare/bafd7197724e...5e55dea8eaab View the full build log and details: https://travis-ci.org/github/apache/httpd/builds/713965545?utm_medium=notification_source=email -- You can unsubscribe from build emails from the apache/httpd repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=69847_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.
Errored: apache/httpd#1037 (trunk - bafd719)
Build Update for apache/httpd - Build: #1037 Status: Errored Duration: 11 mins and 31 secs Commit: bafd719 (trunk) Author: Christophe Jaillet Message: Simplify and speed-up ssl_io_data_dump(). Instead of using a temp buffer for each byte or char written, and calling strlen over and over again to find the place where to copy this buffer, write directly at the correct place in the final buffer, and take advantage of 'apr_snprintf' returning the number of bytes copied. This looks like a hot path when running the test framework (because of TRACE7), so it could be slighly useful in this use case :) git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1880500 13f79535-47bb-0310-9956-ffa450edef68 View the changeset: https://github.com/apache/httpd/compare/7fafffc8aa18...bafd7197724e View the full build log and details: https://travis-ci.org/github/apache/httpd/builds/713958208?utm_medium=notification_source=email -- You can unsubscribe from build emails from the apache/httpd repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=69847_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.
