Re: [VOTE] Release httpd-2.4.48
[X] +1: It's not just good, it's good enough! All good on my Debian(s). Thanks a bunch again Christophe !
Re: [VOTE] Release httpd-2.4.48
Hello All, +1: It's not just good, it's good enough! CentOS6, CentOS7, and CentOS8 builds and passes test suite for us. Thanks, Cory McIntire PO – cPanel Security Team Release Manager – EasyApache cPanel, L.L.C. From: Christophe JAILLET Date: Monday, May 17, 2021 at 4:37 PM To: dev@httpd.apache.org Subject: [VOTE] Release httpd-2.4.48 Hi, all; Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball as 2.4.48: [ ] +1: It's not just good, it's good enough! [ ] +0: Let's have a talk. [ ] -1: There's trouble in paradise. Here's what's wrong. The computed digests of the tarball up for vote are: sha1: b581bcfdd939fe77c3821f7ad3863c7307374919 *httpd-2.4.48.tar.gz sha256: 315c0bc50206b866fb17c2cdc28c1973765a8d59ca168b80286e8cb077d0510e *httpd-2.4.48.tar.gz sha512: 91980f757fc0dede8c6cbf54ed973f82a63098aa50d0fce15fe3537687b4ffbb48ed50cdb4ae14eb4a8703450f032daf73f4f3d5e2dd0f75721948e12a9c6dfb *httpd-2.4.48.tar.gz The SVN tag is '2.4.48' at r1889975. -- Christophe JAILLET
Re: svn commit: r1889978 - /httpd/httpd/branches/2.4.x/STATUS
Le 18/05/2021 à 09:59, Ruediger Pluem a écrit :
On 5/17/21 11:39 PM, jaillet...@apache.org wrote:
Author: jailletc36
Date: Mon May 17 21:39:50 2021
New Revision: 1889978
URL: http://svn.apache.org/viewvc?rev=1889978&view=rev
Log:
Fix French vs English date format.
Modified:
httpd/httpd/branches/2.4.x/STATUS
Modified: httpd/httpd/branches/2.4.x/STATUS
URL:
http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1889978&r1=1889977&r2=1889978&view=diff
==
--- httpd/httpd/branches/2.4.x/STATUS (original)
+++ httpd/httpd/branches/2.4.x/STATUS Mon May 17 21:39:50 2021
@@ -30,7 +30,7 @@ Release history:
while x.{even}.z versions are Stable/GA releases.]
2.4.49 : In development
-2.4.48 : Tagged on mai 17, 2021
+2.4.48 : Tagged on May 17, 2021
Should we put an
export LANG=C
or
export LANG=en_US.UTF-8
at the beginning of announce.sh / tag.sh to avoid this?
Regards
Rüdiger
I'll give it a try, but it is likely the way to go.
There is also a similar issue about the revision given at the end of the
[VOTE] mail. It parses the output of 'svn info' and doesn't work well
when the output is in French.
CJ
Re: log config and variables
Done in r1890003. > Am 17.05.2021 um 21:25 schrieb Ruediger Pluem : > > > > On 5/17/21 4:44 PM, Yann Ylavic wrote: >> On Mon, May 17, 2021 at 3:17 PM Eric Covener wrote: >>> >>> On Mon, May 17, 2021 at 8:47 AM Stefan Eissing >>> wrote: With possibly multiple SSL modules active in our server, I am looking what to do about the logging configuration. The current situation: mod_ssl registers log handler for tags "x" and "c". Those do - "x" does a lookup of the SSL_* variable name - "c" does a shorthand translation of 6 variables names to the ones available via "x". In addition it gives "-" as value for "errcode" and the client verification error for "errstr". The problem is that there can only be one(!) handler registered for a tag. Now "x" can be easily done in mod_log_config itself now what we have ap_ssl_var_lookup() in the core server. This means we can move that code from mod_ssl to mod_log_config. >>> >>> +1 >> +1 >> >>> To make the "c" handler work in core, we can also move the code from mod_ssl to mod_log_config. But we need to define a variable name for the "errstr", for example as "SSL_CLIENT_VERIFY_ERRSTR" which mod_ssl needs to supply then. >>> >>> If you mean ssl_var_lookup would handle "SSL_CLIENT_VERIFY_ERRSTR" +1 >> +1 >> > > +1 to both above. > > Regards > > Rüdiger
Re: [VOTE] Release httpd-2.4.48
On 5/18/21 1:53 PM, Joe Orton wrote: > On Tue, May 18, 2021 at 01:30:25PM +0200, Ruediger Pluem wrote: >> >> >> On 5/18/21 11:52 AM, Giovanni Bechis wrote: >>> On 5/17/21 11:36 PM, Christophe JAILLET wrote: Hi, all; Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball as 2.4.48: [ ] +1: It's not just good, it's good enough! [ ] +0: Let's have a talk. [ ] -1: There's trouble in paradise. Here's what's wrong. The computed digests of the tarball up for vote are: sha1: b581bcfdd939fe77c3821f7ad3863c7307374919 *httpd-2.4.48.tar.gz sha256: 315c0bc50206b866fb17c2cdc28c1973765a8d59ca168b80286e8cb077d0510e *httpd-2.4.48.tar.gz sha512: 91980f757fc0dede8c6cbf54ed973f82a63098aa50d0fce15fe3537687b4ffbb48ed50cdb4ae14eb4a8703450f032daf73f4f3d5e2dd0f75721948e12a9c6dfb *httpd-2.4.48.tar.gz The SVN tag is '2.4.48' at r1889975. >>> -1 for me. >>> new mod_md doesn't build with LibreSSL because nor EVP_PKEY_X25519 nor >>> EVP_PKEY_X448 are defined. >>> I have asked LibreSSL guys if they will add EVP_PKEY_* constants to evp.h. >> >> Did 2.4.46 build with LibreSSL? > 2.4.46 and 2.4.47 builds. > Looks like this is new in 2.4.48 but both LibreSSL users can work around > this or not build mod_md, it doesn't seem like a showstopper. > no real showstopper for me, please remove my "-1" vote. > Giovanni, if you care about keeping Libre support alive can you work out > how to get it building in Travis? It's daft if we are only hitting > these compat issues in post-roll testing. > I agree and I will take a look at it. > Regards, Joe > OpenPGP_signature Description: OpenPGP digital signature
Re: [VOTE] Release httpd-2.4.48
On Tue, May 18, 2021 at 01:30:25PM +0200, Ruediger Pluem wrote: > > > On 5/18/21 11:52 AM, Giovanni Bechis wrote: > > On 5/17/21 11:36 PM, Christophe JAILLET wrote: > >> Hi, all; > >> Please find below the proposed release tarball and signatures: > >> https://dist.apache.org/repos/dist/dev/httpd/ > >> > >> I would like to call a VOTE over the next few days to release this > >> candidate tarball as 2.4.48: > >> [ ] +1: It's not just good, it's good enough! > >> [ ] +0: Let's have a talk. > >> [ ] -1: There's trouble in paradise. Here's what's wrong. > >> > >> The computed digests of the tarball up for vote are: > >> sha1: b581bcfdd939fe77c3821f7ad3863c7307374919 *httpd-2.4.48.tar.gz > >> sha256: 315c0bc50206b866fb17c2cdc28c1973765a8d59ca168b80286e8cb077d0510e > >> *httpd-2.4.48.tar.gz > >> sha512: > >> 91980f757fc0dede8c6cbf54ed973f82a63098aa50d0fce15fe3537687b4ffbb48ed50cdb4ae14eb4a8703450f032daf73f4f3d5e2dd0f75721948e12a9c6dfb > >> *httpd-2.4.48.tar.gz > >> > >> The SVN tag is '2.4.48' at r1889975. > >> > > -1 for me. > > new mod_md doesn't build with LibreSSL because nor EVP_PKEY_X25519 nor > > EVP_PKEY_X448 are defined. > > I have asked LibreSSL guys if they will add EVP_PKEY_* constants to evp.h. > > Did 2.4.46 build with LibreSSL? Looks like this is new in 2.4.48 but both LibreSSL users can work around this or not build mod_md, it doesn't seem like a showstopper. Giovanni, if you care about keeping Libre support alive can you work out how to get it building in Travis? It's daft if we are only hitting these compat issues in post-roll testing. Regards, Joe
Re: [VOTE] Release httpd-2.4.48
On Mon, May 17, 2021 at 11:36:29PM +0200, Christophe JAILLET wrote: > Hi, all; >Please find below the proposed release tarball and signatures: > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release this candidate > tarball as 2.4.48: > [X] +1: It's not just good, it's good enough! > [ ] +0: Let's have a talk. > [ ] -1: There's trouble in paradise. Here's what's wrong. > > The computed digests of the tarball up for vote are: > sha1: b581bcfdd939fe77c3821f7ad3863c7307374919 *httpd-2.4.48.tar.gz > sha256: 315c0bc50206b866fb17c2cdc28c1973765a8d59ca168b80286e8cb077d0510e > *httpd-2.4.48.tar.gz > sha512: > 91980f757fc0dede8c6cbf54ed973f82a63098aa50d0fce15fe3537687b4ffbb48ed50cdb4ae14eb4a8703450f032daf73f4f3d5e2dd0f75721948e12a9c6dfb > *httpd-2.4.48.tar.gz +1 for release, builds and passes test suite on RHEL8. Thanks for RMing again. Regards, Joe
Re: [VOTE] Release httpd-2.4.48
On 5/18/21 11:52 AM, Giovanni Bechis wrote: > On 5/17/21 11:36 PM, Christophe JAILLET wrote: >> Hi, all; >> Please find below the proposed release tarball and signatures: >> https://dist.apache.org/repos/dist/dev/httpd/ >> >> I would like to call a VOTE over the next few days to release this candidate >> tarball as 2.4.48: >> [ ] +1: It's not just good, it's good enough! >> [ ] +0: Let's have a talk. >> [ ] -1: There's trouble in paradise. Here's what's wrong. >> >> The computed digests of the tarball up for vote are: >> sha1: b581bcfdd939fe77c3821f7ad3863c7307374919 *httpd-2.4.48.tar.gz >> sha256: 315c0bc50206b866fb17c2cdc28c1973765a8d59ca168b80286e8cb077d0510e >> *httpd-2.4.48.tar.gz >> sha512: >> 91980f757fc0dede8c6cbf54ed973f82a63098aa50d0fce15fe3537687b4ffbb48ed50cdb4ae14eb4a8703450f032daf73f4f3d5e2dd0f75721948e12a9c6dfb >> *httpd-2.4.48.tar.gz >> >> The SVN tag is '2.4.48' at r1889975. >> > -1 for me. > new mod_md doesn't build with LibreSSL because nor EVP_PKEY_X25519 nor > EVP_PKEY_X448 are defined. > I have asked LibreSSL guys if they will add EVP_PKEY_* constants to evp.h. Did 2.4.46 build with LibreSSL? Regards Rüdiger
Re: [VOTE] Release httpd-2.4.48
> Am 18.05.2021 um 11:52 schrieb Giovanni Bechis :
>
> On 5/17/21 11:36 PM, Christophe JAILLET wrote:
>> Hi, all;
>>Please find below the proposed release tarball and signatures:
>> https://dist.apache.org/repos/dist/dev/httpd/
>>
>> I would like to call a VOTE over the next few days to release this candidate
>> tarball as 2.4.48:
>> [ ] +1: It's not just good, it's good enough!
>> [ ] +0: Let's have a talk.
>> [ ] -1: There's trouble in paradise. Here's what's wrong.
>>
>> The computed digests of the tarball up for vote are:
>> sha1: b581bcfdd939fe77c3821f7ad3863c7307374919 *httpd-2.4.48.tar.gz
>> sha256: 315c0bc50206b866fb17c2cdc28c1973765a8d59ca168b80286e8cb077d0510e
>> *httpd-2.4.48.tar.gz
>> sha512:
>> 91980f757fc0dede8c6cbf54ed973f82a63098aa50d0fce15fe3537687b4ffbb48ed50cdb4ae14eb4a8703450f032daf73f4f3d5e2dd0f75721948e12a9c6dfb
>> *httpd-2.4.48.tar.gz
>>
>> The SVN tag is '2.4.48' at r1889975.
>>
> -1 for me.
> new mod_md doesn't build with LibreSSL because nor EVP_PKEY_X25519 nor
> EVP_PKEY_X448 are defined.
> I have asked LibreSSL guys if they will add EVP_PKEY_* constants to evp.h.
Meh, this ballsy libressl version definition, how many people have slits their
wrists on that already?
Thanks for the patch. I will bring that in to trunk and 2.4.x and github.
Stefan
> Giovanni
>
> The following patch is a workaround:
>
> Index: modules/md/md_crypt.c
> --- modules/md/md_crypt.c.orig
> +++ modules/md/md_crypt.c
> @@ -71,6 +71,11 @@
> #include
> #endif
>
> +#if defined(LIBRESSL_VERSION_NUMBER)
> +#define EVP_PKEY_X25519 NID_X25519
> +#define EVP_PKEY_X448 NID_X448
> +#endif
> +
> static int initialized;
>
> struct md_pkey_t {
Re: [VOTE] Release httpd-2.4.48
On 5/17/21 11:36 PM, Christophe JAILLET wrote:
> Hi, all;
> Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
>
> I would like to call a VOTE over the next few days to release this candidate
> tarball as 2.4.48:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
>
> The computed digests of the tarball up for vote are:
> sha1: b581bcfdd939fe77c3821f7ad3863c7307374919 *httpd-2.4.48.tar.gz
> sha256: 315c0bc50206b866fb17c2cdc28c1973765a8d59ca168b80286e8cb077d0510e
> *httpd-2.4.48.tar.gz
> sha512:
> 91980f757fc0dede8c6cbf54ed973f82a63098aa50d0fce15fe3537687b4ffbb48ed50cdb4ae14eb4a8703450f032daf73f4f3d5e2dd0f75721948e12a9c6dfb
> *httpd-2.4.48.tar.gz
>
> The SVN tag is '2.4.48' at r1889975.
>
-1 for me.
new mod_md doesn't build with LibreSSL because nor EVP_PKEY_X25519 nor
EVP_PKEY_X448 are defined.
I have asked LibreSSL guys if they will add EVP_PKEY_* constants to evp.h.
Giovanni
The following patch is a workaround:
Index: modules/md/md_crypt.c
--- modules/md/md_crypt.c.orig
+++ modules/md/md_crypt.c
@@ -71,6 +71,11 @@
#include
#endif
+#if defined(LIBRESSL_VERSION_NUMBER)
+#define EVP_PKEY_X25519 NID_X25519
+#define EVP_PKEY_X448 NID_X448
+#endif
+
static int initialized;
struct md_pkey_t {
OpenPGP_signature
Description: OpenPGP digital signature
Re: svn commit: r1889978 - /httpd/httpd/branches/2.4.x/STATUS
On 5/17/21 11:39 PM, jaillet...@apache.org wrote:
> Author: jailletc36
> Date: Mon May 17 21:39:50 2021
> New Revision: 1889978
>
> URL: http://svn.apache.org/viewvc?rev=1889978&view=rev
> Log:
> Fix French vs English date format.
>
> Modified:
> httpd/httpd/branches/2.4.x/STATUS
>
> Modified: httpd/httpd/branches/2.4.x/STATUS
> URL:
> http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1889978&r1=1889977&r2=1889978&view=diff
> ==
> --- httpd/httpd/branches/2.4.x/STATUS (original)
> +++ httpd/httpd/branches/2.4.x/STATUS Mon May 17 21:39:50 2021
> @@ -30,7 +30,7 @@ Release history:
>while x.{even}.z versions are Stable/GA releases.]
>
> 2.4.49 : In development
> -2.4.48 : Tagged on mai 17, 2021
> +2.4.48 : Tagged on May 17, 2021
Should we put an
export LANG=C
or
export LANG=en_US.UTF-8
at the beginning of announce.sh / tag.sh to avoid this?
Regards
Rüdiger
