Re: Apache janitor ?
On Thursday 09 June 2011, Igor Galić wrote: > I've watched this talk three or four times by now, and every time > motivates me to look into our bug tracker. The overwhelming number > of (currently) 1133 open issues, however soon dampens my > enthusiasm. > > http://s.apache.org/a2open > http://s.apache.org/a2patchavail (184 right now) The more relevant numbers are those without FixedInTrunk and maybe those not NEEDINFNO. Excluding these two, the total is 905, which is still a lot. BTW, I think the weekly bug list would be more useful if it excluded FixedInTrunk PRs.
Re: Apache janitor ?
On Thursday 09 June 2011, Igor Galić wrote: > - Original Message - > > > On June 8, 2011 20:11 , Igor =?utf-8?Q?Gali=C4=87?= > > > > wrote: > > > One of the many good suggestions they propose is to have a > > > "Patch Manager" - someone who makes sure that patches > > > submitted via Bugzilla or directly to the list don't get lost > > > in the noise and that people get some feedback, even if it's > > > just a one liner like "Thanks, we're looking into this", > > > "Nope, that's really not in our scope", etc... > > > > Committers, is there anything that list/community members could > > do to pitch in and help? What, if anything, would be useful and > > accepted? For example, is there a list of things you'd like to > > be done before you > > commit a patch, and are there parts of that list that could be > > delegated > > to one or more non-committer janitors? I'd be willing to try and > > help > > (for example), if such help would be useful. > > As I already pointed out: One of the things that - IMO - needs > touching is Bugzilla. We have far to many bugs which are open. I > suspect a great number to already be either fixed or duplicates of > other bugs. > > So the simplest thing you really can do is to take a look at bugs > that bug you and see if there's other, related -- or equal bugs. Some more ideas: - I guess a lot of very old bugs that are in the NEEDINFO state can be closed because they cannot be reproduced. Maybe someone could collect a list of candidates. - If a patch is "obviously right" (because it only fixes a typo, etc.), draw attention to it on httpd-dev. - If a patch has been vetoed or critisized as wrong by a commiter, remove the PatchAvailable keyword. - If a patch for a part of HTTPD that is not UNIX-only is obviously written in a UNIX-ish way (i.e. not using apr functions), remove the PatchAvailable keyword and ask for a portable version. - If a patch looks more or less ok, it may be useful to run the test- framework with it and report success or any failures. However not all code parts are covered by the test-framework. I don't know how easy it is for a non-committer to guess if a test run would make sense or would be a waste of time. - If a bug report is about a segfault but does not have a backtrace, ask for the backtrace (pointing to the relevant part of the docs). - If a report is about a crash, hang, or loop, verify that the following information is there: Which OS, which MPM, which version of HTTPD, which openssl version (for ssl related PRs), which ldap libraries (for mod_ldap related PRs). Ask the submitter if not.
Re: Apache janitor ?
- Original Message - > On June 8, 2011 20:11 , Igor =?utf-8?Q?Gali=C4=87?= > wrote: > > One of the many good suggestions they propose is to have a > > "Patch Manager" - someone who makes sure that patches > > submitted via Bugzilla or directly to the list don't get lost > > in the noise and that people get some feedback, even if it's > > just a one liner like "Thanks, we're looking into this", > > "Nope, that's really not in our scope", etc... > > Committers, is there anything that list/community members could do to > pitch in and help? What, if anything, would be useful and accepted? > For example, is there a list of things you'd like to be done before > you > commit a patch, and are there parts of that list that could be > delegated > to one or more non-committer janitors? I'd be willing to try and > help > (for example), if such help would be useful. As I already pointed out: One of the things that - IMO - needs touching is Bugzilla. We have far to many bugs which are open. I suspect a great number to already be either fixed or duplicates of other bugs. So the simplest thing you really can do is to take a look at bugs that bug you and see if there's other, related -- or equal bugs. > Big thanks to Igor for his message, his suggestions, and recommending > the "Open Source Projects and Poisonous People" talk. What Igor says > has been bothering me for a while, too. > > -- >Mark Montague >m...@catseye.org i -- Igor Galić Tel: +43 (0) 664 886 22 883 Mail: i.ga...@brainsware.org URL: http://brainsware.org/
Re: Apache janitor ?
On June 8, 2011 20:11 , Igor =?utf-8?Q?Gali=C4=87?= wrote: One of the many good suggestions they propose is to have a "Patch Manager" - someone who makes sure that patches submitted via Bugzilla or directly to the list don't get lost in the noise and that people get some feedback, even if it's just a one liner like "Thanks, we're looking into this", "Nope, that's really not in our scope", etc... Committers, is there anything that list/community members could do to pitch in and help? What, if anything, would be useful and accepted? For example, is there a list of things you'd like to be done before you commit a patch, and are there parts of that list that could be delegated to one or more non-committer janitors? I'd be willing to try and help (for example), if such help would be useful. Big thanks to Igor for his message, his suggestions, and recommending the "Open Source Projects and Poisonous People" talk. What Igor says has been bothering me for a while, too. -- Mark Montague m...@catseye.org
Re: Apache janitor ?
Christophe's mail reminds me a bit of Brian Fitzpatrick and Ben Collins-Sussman's talk "Open Source Projects and Poisonous People" http://www.youtube.com/watch?v=-F-3E8pyjFo One of the many good suggestions they propose is to have a "Patch Manager" - someone who makes sure that patches submitted via Bugzilla or directly to the list don't get lost in the noise and that people get some feedback, even if it's just a one liner like "Thanks, we're looking into this", "Nope, that's really not in our scope", etc... I've watched this talk three or four times by now, and every time motivates me to look into our bug tracker. The overwhelming number of (currently) 1133 open issues, however soon dampens my enthusiasm. http://s.apache.org/a2open http://s.apache.org/a2patchavail (184 right now) I've been thinking for some time now that we really need a hackathlon or bug-squashing event to drastically reduce those. Or at least clean out the invalid ones. The ones which have already been (accidentally) fixed, etc.. i -- Igor Galić Tel: +43 (0) 664 886 22 883 Mail: i.ga...@brainsware.org URL: http://brainsware.org/
Re: Apache janitor ?
- Original Message -
> Hi,
>
> from time to time I prepare small patches to improve apache code
> source
> quality.
> These patches can be small speed up, removal of duplicated code,
> clean-up,
> formatting... But no functionnal change as I'm not an apache guru
> yet.
> This is more or less like what is done by the kernel janitors for
> linux.
>
> Once I'd been told to use the apache bugzilla database to submit
> these
> patches, but, I'm not sure that this is the best place.
>
> Patches like the following one are, IMO, a good thing. It improves
> readability of the source code, reduce number of lines, reduce
> potential
> mistakes... But bugzilla is not dedicated for this kind of patch.
I'd create it as 'enhancement'. Attach the patch, label it as PatchAvailable
and then bug people here to commit it. Preferably with a subject:
[PATCH]
>
> Index: modules/filters/mod_include.c
> ===
> --- modules/filters/mod_include.c (revision 1132846)
> +++ modules/filters/mod_include.c (working copy)
> @@ -3230,10 +3217,7 @@
> char *sp = intern->current_arg->name;
>
> /* normalize the name */
> -while (*sp) {
> -*sp = apr_tolower(*sp);
> -++sp;
> -}
> +ap_str_tolower(sp);
> }
>
> intern->state = PARSE_ARG_EQ;
>
>
>
> So I was wondering if 'comp.apache.devel' could be the right place ?
> Or maybe a new dedicated forum could be created, for example
> 'comp.apache.janitor' ?
I don't think that creating yet another forum makes sense.
> Or maybe patches could be sent directly to main developpers of apache
> for
> approval or refusal ?
This forum (dev@httpd.apache.org) is where main Apache httpd developers
hang out and discuss.
> On the other side, do you think that this kind of patch are usefull
> and
> worse submitting ?
That's not the question here. The question is if you think it's worth.
> Thanks for your comments.
>
> CJ
i
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.ga...@brainsware.org
URL: http://brainsware.org/
Apache janitor ?
Hi,
from time to time I prepare small patches to improve apache code source
quality.
These patches can be small speed up, removal of duplicated code, clean-up,
formatting... But no functionnal change as I'm not an apache guru yet.
This is more or less like what is done by the kernel janitors for linux.
Once I'd been told to use the apache bugzilla database to submit these
patches, but, I'm not sure that this is the best place.
Patches like the following one are, IMO, a good thing. It improves
readability of the source code, reduce number of lines, reduce potential
mistakes... But bugzilla is not dedicated for this kind of patch.
Index: modules/filters/mod_include.c
===
--- modules/filters/mod_include.c (revision 1132846)
+++ modules/filters/mod_include.c (working copy)
@@ -3230,10 +3217,7 @@
char *sp = intern->current_arg->name;
/* normalize the name */
-while (*sp) {
-*sp = apr_tolower(*sp);
-++sp;
-}
+ap_str_tolower(sp);
}
intern->state = PARSE_ARG_EQ;
So I was wondering if 'comp.apache.devel' could be the right place ?
Or maybe a new dedicated forum could be created, for example
'comp.apache.janitor' ?
Or maybe patches could be sent directly to main developpers of apache for
approval or refusal ?
On the other side, do you think that this kind of patch are usefull and
worse submitting ?
Thanks for your comments.
CJ
