Re: [RESULT] (Was: Re: [VOTE] Release Apache httpd 2.4.25 as GA)

[William A Rowe Jr]

On Mon, Dec 19, 2016 at 12:32 PM, Jim Jagielski  wrote:

> With 72 hours up, and sufficient +1 (binding) votes, I call
> this vote CLOSED with the result of PASS.
>
> I have gone ahead and moved the release artifacts over the
> the required place for the mirrors to sync up.
>

Thanks for RM'ing!


> I will be away (In Tyson's Corner, VA) later today and
> all day tomorrow, and the 1st half of Weds), so if someone
> wants to take on the announcing part, that would be great.
> I'll have limited cycles and external net access.
>

I'm on it.

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Rainer Jung]

Am 16.12.2016 um 19:29 schrieb Jim Jagielski:

At long, long last, the pre-release test tarballs for Apache httpd
version 2.4.25 can be found at the usual place:

http://httpd.apache.org/dev/dist/

I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.

[ ] +1: Good to go
[ ] +0: meh
[ ] -1: Danger Will Robinson. And why.

Vote will last the normal 72 hrs.

NOTE: The *-deps are only there for convenience.


+1 to release and thanks a bunch for RMing and to all who contributed to 
the release.


In short: No regressions found.

Detailed report:

- Sigs and hashes OK
- contents of tarballs identical
- contents of tag and tarballs identical
  except for expected deltas
  (we could cleanup some m4 files in apr-util/xml/expat/conftools
   at the end of buildconf, no regression)

Built on

- Solaris 8+10 Sparc as 32 Bit Binaries
- SLES 10+11 (64 Bits)
- RHEL 6 (64 Bits)

For all platforms built

- with default (shared), shared and static modules
- with module sets none, few, most, all, reallyall and default
  (always mod_privileges disabled)
- using --enable-load-all-modules
- against "included" APR/APU from deps tarball,
  plus external APR/APU 1.5.2/1.5.4 plus external apr 1.6.x head and 
apu 1.5.x head.


- using external libraries
  - expat 2.2.0
  - pcre 8.39
  - openssl 1.0.2j plus patches
  - lua 5.3.3 plus LUA_COMPAT_5_1 define
  - distcache 1.5.1
  - libxml2 2.9.4
  - libnghttp2 1.7.0

- Tool chain:
- platform gcc except for Solaris
  (gcc 4.1.2 for Solaris 8 and 4.9.2 for Solaris 10 and apr/u 
1.5.2/1.5.4 and gcc 6.2.0 for Solaris with apr/u bundeled and heads)

- CFLAGS: -O2 -g -Wall -fno-strict-aliasing
  (and -mpcu=v9 -D_XOPEN_SOURCE -D_XOPEN_SOURCE_EXTENDED=1 
-D__EXTENSIONS__ on Solaris plus -D_XPG6 when using gcc 6.2.0)


208 build succeeded, 2 builds both on SLES 11 didn't succeed due to 
segmentation faults in ksh during configure run. Not a regression.


  - compiler warnings:

modules/core/mod_watchdog.c:437: warning: 'rv' may be used uninitialized 
in this function
modules/proxy/mod_proxy_express.c:111: warning: 'backend' may be used 
uninitialized in this function
modules/ssl/ssl_util_stapling.c:686: warning: 'ok' may be used 
uninitialized in this function
srclib/apr-util/xlate/xlate.c:120:38: warning: passing argument 2 of 
'iconv' from incompatible pointer type (only Solaris 10)



Tested for

- Solaris 10 (32), SLES 11 (64), RHEL 6 (64)
- MPMs prefork, worker, event
- default, shared and static modules
- log levels info, debug and trace8
- module set reallyall (124 modules plus MPMs)
- module sets few, default, most and all ongoing

The following test failures were seen:

a Test 5 in t/modules/dav.t:
  Happens for 11 out of about 750 runs (4 on SLES 11,
  6 on RHEL6, 1 on Solaris 10).
  Creation, modified and now times not in the correct order.
  This seems to be a system issue, all tests done on NFS,
  many tested on virtualized guests.
  Not a regression.

b Various tests in t/apache/expr_string.t: (3, 6, 11, 14, 17, 20 ,23)
  Happens for 58 out of about 750 runs (2 on SLES 11,
  53 on RHEL6, 3 on Solaris10).
  The failure is always on line 68, where the error_log contents
  are checked.
  Not a regression.

c Test 59 of t/modules/include.t only and always on
  Solaris.
  This is due to a bug in the test, which uses strftime()
  with a "%s" pattern that is not supported on Solaris.
  Until recently the server and the test client both returned
  verbatim "%s" and the test succeeded. After updating some
  Perl modules for the http2 tests, the perl client even
  on Solaris now supports "%s" in strftime and the test starts
  to fail. It seems we have to fix the test.
  Not a regression

d Test 163, 68 or 171 in t/ssl/proxy.t
  Sporadic (3) failures only for Solaris and only on event.
  We always get back about 40-60KB of data instead of the expected
  Proxy Error 502. The error message always refers to
  .../Apache-Test/lib/Apache/TestCommonPost.pm at line 131
  Regression, but maybe a test framework problem?

e Test25 and 30 in t/http11/chunked.t
  Fails only once on SLES 11 with event and "few" module set
  statically linked.
  # testing : number of requests
  # expected: 5
  # received: 1
  not ok 25
  # testing : number of requests
  # expected: 6
  # received: 2
  not ok 30
  Regression but extremely rare

f Failure of tests 5-24 in t/modules/ext_filter.t
  Roughly 2/3 of all test runs fail those tests,
  didn't look for details, because it seems to be
  an open issue (BZ) and not a regression.

g Few failures of test 1 in t/modules/ext_filter.t
  Only on Solaris while using "sed", did not appear later
  when the test was using the "perl" replacement I checked
  in in the meantime

h Tests 1, 5-6, 10-11, 13-16, 20-21, 23-26, 28-31 in t/module/session.t
  Fail always for static builds with "all" and "most" module sets.
  I haven't yet checked but hopefully just a missed dependency thing.

i Tests 72-75, 77 in t/apache/http_strict.t
  Fail 

[RESULT] (Was: Re: [VOTE] Release Apache httpd 2.4.25 as GA)

[Jim Jagielski]

With 72 hours up, and sufficient +1 (binding) votes, I call
this vote CLOSED with the result of PASS.

I have gone ahead and moved the release artifacts over the
the required place for the mirrors to sync up.

I will be away (In Tyson's Corner, VA) later today and
all day tomorrow, and the 1st half of Weds), so if someone
wants to take on the announcing part, that would be great.
I'll have limited cycles and external net access.

> On Dec 16, 2016, at 1:29 PM, Jim Jagielski  wrote:
> 
> At long, long last, the pre-release test tarballs for Apache httpd
> version 2.4.25 can be found at the usual place:
> 
>   http://httpd.apache.org/dev/dist/
> 
> I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.
> 
> [ ] +1: Good to go
> [ ] +0: meh
> [ ] -1: Danger Will Robinson. And why.
> 
> Vote will last the normal 72 hrs.
> 
> NOTE: The *-deps are only there for convenience.
> 
> Thx!

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[William A Rowe Jr]

On Fri, Dec 16, 2016 at 12:29 PM, Jim Jagielski  wrote:

> At long, long last, the pre-release test tarballs for Apache httpd
> version 2.4.25 can be found at the usual place:
>
> http://httpd.apache.org/dev/dist/
>
> I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.
>

Regressions noted; Build fails at mod_socache_memcache.mak
on Windows command line 'nmake' invocation, fixed in 2.4.x branch
with r1774650. GUI build of Windows works; cmake-provisioned build
works, in light of security fixes, decided this won't-fix defect, is not
a showstopper.

+1 for httpd-2.4.25.tar.gz release.

httpd-2.4.25/srclib/apr-util/xml/expat contains Expat 1.95.7. For
reference, 2.0 derived from 1.95.8 final, which was not a security
release. 2.1.0, 2.1.1 and 2.2.0 have resolved a significant number
of security defects, noted here; http://expat.sourceforge.net/

Note apr-util-1.6.x branch (and apr-trunk) no longer bundles any
expat sources.

-1 to distribute httpd-2.4.25-deps.tar.gz from httpd.

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Steffen]

All fine here on Windows. 

Steffen 

> Op 16 dec. 2016 om 19:29 heeft Jim Jagielski  het volgende 
> geschreven:
> 
> At long, long last, the pre-release test tarballs for Apache httpd
> version 2.4.25 can be found at the usual place:
> 
>http://httpd.apache.org/dev/dist/
> 
> I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.
> 
> [ ] +1: Good to go
> [ ] +0: meh
> [ ] -1: Danger Will Robinson. And why.
> 
> Vote will last the normal 72 hrs.
> 
> NOTE: The *-deps are only there for convenience.
> 
> Thx!

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Stefan Eissing]

> Am 16.12.2016 um 19:29 schrieb Jim Jagielski :
> 
> I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.
> 
> [x] +1: Good to go

macOS 10.12, x64 - event, worker
Ubuntu 14.04 x64 - event, worker

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Jacob Champion]

On Fri, Dec 16, 2016 at 10:29 AM, Jim Jagielski  wrote:
> I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.
>
> [x] +1: Good to go

Ubuntu 16.04 x64, both the httpd (minus ext_filter) and mod_websocket
test suites.
Windows 7 x64, mod_websocket test suite (still can't, for the life of
me, get the httpd test suite running correctly on Windows...).

--Jacob

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Yann Ylavic]

On Fri, Dec 16, 2016 at 7:29 PM, Jim Jagielski  wrote:
>
> I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.

[X] +1: Good to go

Tested on Debian stretch/sid, jessie, wheezy (amd64).

enable-mods-shared=reallyall
All tests passed (but mod_session's TODOs and known ext_filter case).
PGP/SHA1/MD5 match.

Thanks for RMing Jim!

PS: somehow mod_session_cookie is loaded (uncommented) by default in
httpd.conf, but not its dependency mod_session (which makes the tests
suite fail by default..).

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[William A Rowe Jr]

It isn't based on the modules/*.so contents, but based on the draft
conf/httpd.conf indicated by apxs.

I had the converse problem, with --enable-modules-all I accidentally loaded
both cgi and cgid.

On Dec 18, 2016 02:43, "Nick Kew"  wrote:

On Sat, 2016-12-17 at 20:32 -0500, Eric Covener wrote:
> I think your t/conf/extra.conf is out of date and has the +ExecCGI
> masked out by . So you are getting the perl script
> instead of its output setting nasty headers.

[pre-breakfast post: not yet at the desktop where I ran the tests]

For what it's worth, this was a pristine trunk repo of the test suite
as of date about 12 hours ago.  As ever, built/run in a directory
newly created by lndir so as never to pollute the repo.

However, there's a message earlier in the tests: CGI tests skipped
because neither mod_cgi nor mod_cgid were found (nonsense: mod_cgid.so
is in its expected place in /modules/ ).  Looks like some gremlin
in the test suite, plus running those tests when CGI tests had been
skipped.

--
Nick Kew

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Nick Kew]

On Sat, 2016-12-17 at 20:32 -0500, Eric Covener wrote:
> I think your t/conf/extra.conf is out of date and has the +ExecCGI
> masked out by . So you are getting the perl script
> instead of its output setting nasty headers.

[pre-breakfast post: not yet at the desktop where I ran the tests]

For what it's worth, this was a pristine trunk repo of the test suite
as of date about 12 hours ago.  As ever, built/run in a directory
newly created by lndir so as never to pollute the repo.

However, there's a message earlier in the tests: CGI tests skipped
because neither mod_cgi nor mod_cgid were found (nonsense: mod_cgid.so
is in its expected place in /modules/ ).  Looks like some gremlin
in the test suite, plus running those tests when CGI tests had been
skipped.

-- 
Nick Kew

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[William A Rowe Jr]

t/TEST -clean might help


On Dec 17, 2016 19:32, "Eric Covener"  wrote:

> I think your t/conf/extra.conf is out of date and has the +ExecCGI
> masked out by . So you are getting the perl script
> instead of its output setting nasty headers.
>
> On Sat, Dec 17, 2016 at 8:27 PM, Nick Kew  wrote:
> > On Sat, 17 Dec 2016 18:35:22 -0600
> > William A Rowe Jr  wrote:
> >
> >> On Dec 17, 2016 17:22, "Nick Kew"  wrote:
> >>
> >>
> >> Got some test errors with the new stuff.  Investigating.
> >>
> >> Test Summary Report
> >> ---
> >> t/apache/http_strict.t(Wstat: 0 Tests: 78 Failed: 5)
> >>   Failed tests:  72-75, 77
> >>
> >>
> >> Really should not occur and I haven't seen this. Shoot me the -v
> >> (erbose) output from your t/apache/http_strict.t please?
> >
> > Cut here.  Bedtime now (coming up for 01:30), but if I
> > find time tomorrow I may play with the testcases under gdb.
> >
> > They're all cases where the server returns 200 when the
> > testcase expects an error.
> >
> > 72:
> > # SENDING:
> > # GET /apache/http_strict/send_hdr.pl?OiBiYXI= HTTP/1.0\r\n\r\n
> > # DECODED: : bar
> > # RESPONSE:
> > # HTTP/1.1 200 OK\r\n
> > # Date: Sun, 18 Dec 2016 01:17:34 GMT\r\n
> > # Server: Apache/2.4.25 (Unix)\r\n
> > # Last-Modified: Sun, 18 Dec 2016 00:13:28 GMT\r\n
> > # ETag: "226-543e3ac24b8ae"\r\n
> > # Accept-Ranges: bytes\r\n
> > # Content-Length: 550\r\n
> > # DMMATCH1: 1\r\n
> > # Connection: close\r\n
> > # \r\n
> > # #!/usr/bin/perl\n
> > # # WARNING: this file is generated, do not edit\n
> > # # generated on Sun Dec 18 00:13:28 2016\n
> > # # 01: Apache-Test/lib/Apache/TestConfig.pm:961\n
> > # # 02: Apache-Test/lib/Apache/TestConfig.pm:1051\n
> > # # 03: Apache-Test/lib/Apache/TestMM.pm:142\n
> > # # 04: Makefile.PL:26\n
> > # \n
> > # BEGIN { eval { require blib && blib->import; } }\n
> > # use MIME::Base64;\n
> > # use strict;\n
> > # use warnings;\n
> > # \n
> > # print "Content-type: text/plain\\r\\n
> > # ";\n
> > # print decode_base64($ENV{QUERY_STRING}), "\\r\\n
> > # ";\n
> > # print "\\r\\n
> > # ";\n
> > # print "Hi!\\n
> > # ";\n
> > # print "SERVERNAME=$ENV{SERVER_NAME}\\n
> > # ";\n
> > # print "HTTP_HOST=$ENV{HTTP_HOST}\\n
> > # ";\n
> > #
> > # expecting 500, got 200
> >
> > 73:
> > # SENDING:
> > # GET /apache/http_strict/send_hdr.pl?RgBvbzogYmFy HTTP/1.0\r\n\r\n
> > # DECODED: F\x00oo: bar
> > # RESPONSE:
> > # HTTP/1.1 200 OK\r\n
> > # Date: Sun, 18 Dec 2016 01:17:34 GMT\r\n
> > # Server: Apache/2.4.25 (Unix)\r\n
> > # Last-Modified: Sun, 18 Dec 2016 00:13:28 GMT\r\n
> > # ETag: "226-543e3ac24b8ae"\r\n
> > # Accept-Ranges: bytes\r\n
> > # Content-Length: 550\r\n
> > # DMMATCH1: 1\r\n
> > # Connection: close\r\n
> > # \r\n
> >
> > 74:
> > # SENDING:
> > # GET /apache/http_strict/send_hdr.pl?RgFvbzogYmFy HTTP/1.0\r\n\r\n
> > # DECODED: F\x01oo: bar
> > # RESPONSE:
> > # HTTP/1.1 200 OK\r\n
> > # Date: Sun, 18 Dec 2016 01:17:34 GMT\r\n
> > # Server: Apache/2.4.25 (Unix)\r\n
> > # Last-Modified: Sun, 18 Dec 2016 00:13:28 GMT\r\n
> > # ETag: "226-543e3ac24b8ae"\r\n
> > # Accept-Ranges: bytes\r\n
> > # Content-Length: 550\r\n
> > # DMMATCH1: 1\r\n
> > # Connection: close\r\n
> > # \r\n
> >
> > 75:
> > # SENDING:
> > # GET /apache/http_strict/send_hdr.pl?RgpvbzogYmFy HTTP/1.0\r\n\r\n
> > # DECODED: F\noo: bar
> > # RESPONSE:
> > # HTTP/1.1 200 OK\r\n
> > # Date: Sun, 18 Dec 2016 01:17:34 GMT\r\n
> > # Server: Apache/2.4.25 (Unix)\r\n
> > # Last-Modified: Sun, 18 Dec 2016 00:13:28 GMT\r\n
> > # ETag: "226-543e3ac24b8ae"\r\n
> > # Accept-Ranges: bytes\r\n
> > # Content-Length: 550\r\n
> > # DMMATCH1: 1\r\n
> > # Connection: close\r\n
> > # \r\n
> >
> >
> > 77:
> > # SENDING:
> > # GET /apache/http_strict/send_hdr.pl?Rm9vOiBiAWFy HTTP/1.0\r\n\r\n
> > # DECODED: Foo: b\x01ar
> > # RESPONSE:
> > # HTTP/1.1 200 OK\r\n
> > # Date: Sun, 18 Dec 2016 01:12:21 GMT\r\n
> > # Server: Apache/2.4.25 (Unix)\r\n
> > # Last-Modified: Sun, 18 Dec 2016 00:13:28 GMT\r\n
> > # ETag: "226-543e3ac24b8ae"\r\n
> > # Accept-Ranges: bytes\r\n
> > # Content-Length: 550\r\n
> > # DMMATCH1: 1\r\n
> > # Connection: close\r\n
> > # \r\n
>
>
>
> --
> Eric Covener
> cove...@gmail.com
>

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Eric Covener]

I think your t/conf/extra.conf is out of date and has the +ExecCGI
masked out by . So you are getting the perl script
instead of its output setting nasty headers.

On Sat, Dec 17, 2016 at 8:27 PM, Nick Kew  wrote:
> On Sat, 17 Dec 2016 18:35:22 -0600
> William A Rowe Jr  wrote:
>
>> On Dec 17, 2016 17:22, "Nick Kew"  wrote:
>>
>>
>> Got some test errors with the new stuff.  Investigating.
>>
>> Test Summary Report
>> ---
>> t/apache/http_strict.t(Wstat: 0 Tests: 78 Failed: 5)
>>   Failed tests:  72-75, 77
>>
>>
>> Really should not occur and I haven't seen this. Shoot me the -v
>> (erbose) output from your t/apache/http_strict.t please?
>
> Cut here.  Bedtime now (coming up for 01:30), but if I
> find time tomorrow I may play with the testcases under gdb.
>
> They're all cases where the server returns 200 when the
> testcase expects an error.
>
> 72:
> # SENDING:
> # GET /apache/http_strict/send_hdr.pl?OiBiYXI= HTTP/1.0\r\n\r\n
> # DECODED: : bar
> # RESPONSE:
> # HTTP/1.1 200 OK\r\n
> # Date: Sun, 18 Dec 2016 01:17:34 GMT\r\n
> # Server: Apache/2.4.25 (Unix)\r\n
> # Last-Modified: Sun, 18 Dec 2016 00:13:28 GMT\r\n
> # ETag: "226-543e3ac24b8ae"\r\n
> # Accept-Ranges: bytes\r\n
> # Content-Length: 550\r\n
> # DMMATCH1: 1\r\n
> # Connection: close\r\n
> # \r\n
> # #!/usr/bin/perl\n
> # # WARNING: this file is generated, do not edit\n
> # # generated on Sun Dec 18 00:13:28 2016\n
> # # 01: Apache-Test/lib/Apache/TestConfig.pm:961\n
> # # 02: Apache-Test/lib/Apache/TestConfig.pm:1051\n
> # # 03: Apache-Test/lib/Apache/TestMM.pm:142\n
> # # 04: Makefile.PL:26\n
> # \n
> # BEGIN { eval { require blib && blib->import; } }\n
> # use MIME::Base64;\n
> # use strict;\n
> # use warnings;\n
> # \n
> # print "Content-type: text/plain\\r\\n
> # ";\n
> # print decode_base64($ENV{QUERY_STRING}), "\\r\\n
> # ";\n
> # print "\\r\\n
> # ";\n
> # print "Hi!\\n
> # ";\n
> # print "SERVERNAME=$ENV{SERVER_NAME}\\n
> # ";\n
> # print "HTTP_HOST=$ENV{HTTP_HOST}\\n
> # ";\n
> #
> # expecting 500, got 200
>
> 73:
> # SENDING:
> # GET /apache/http_strict/send_hdr.pl?RgBvbzogYmFy HTTP/1.0\r\n\r\n
> # DECODED: F\x00oo: bar
> # RESPONSE:
> # HTTP/1.1 200 OK\r\n
> # Date: Sun, 18 Dec 2016 01:17:34 GMT\r\n
> # Server: Apache/2.4.25 (Unix)\r\n
> # Last-Modified: Sun, 18 Dec 2016 00:13:28 GMT\r\n
> # ETag: "226-543e3ac24b8ae"\r\n
> # Accept-Ranges: bytes\r\n
> # Content-Length: 550\r\n
> # DMMATCH1: 1\r\n
> # Connection: close\r\n
> # \r\n
>
> 74:
> # SENDING:
> # GET /apache/http_strict/send_hdr.pl?RgFvbzogYmFy HTTP/1.0\r\n\r\n
> # DECODED: F\x01oo: bar
> # RESPONSE:
> # HTTP/1.1 200 OK\r\n
> # Date: Sun, 18 Dec 2016 01:17:34 GMT\r\n
> # Server: Apache/2.4.25 (Unix)\r\n
> # Last-Modified: Sun, 18 Dec 2016 00:13:28 GMT\r\n
> # ETag: "226-543e3ac24b8ae"\r\n
> # Accept-Ranges: bytes\r\n
> # Content-Length: 550\r\n
> # DMMATCH1: 1\r\n
> # Connection: close\r\n
> # \r\n
>
> 75:
> # SENDING:
> # GET /apache/http_strict/send_hdr.pl?RgpvbzogYmFy HTTP/1.0\r\n\r\n
> # DECODED: F\noo: bar
> # RESPONSE:
> # HTTP/1.1 200 OK\r\n
> # Date: Sun, 18 Dec 2016 01:17:34 GMT\r\n
> # Server: Apache/2.4.25 (Unix)\r\n
> # Last-Modified: Sun, 18 Dec 2016 00:13:28 GMT\r\n
> # ETag: "226-543e3ac24b8ae"\r\n
> # Accept-Ranges: bytes\r\n
> # Content-Length: 550\r\n
> # DMMATCH1: 1\r\n
> # Connection: close\r\n
> # \r\n
>
>
> 77:
> # SENDING:
> # GET /apache/http_strict/send_hdr.pl?Rm9vOiBiAWFy HTTP/1.0\r\n\r\n
> # DECODED: Foo: b\x01ar
> # RESPONSE:
> # HTTP/1.1 200 OK\r\n
> # Date: Sun, 18 Dec 2016 01:12:21 GMT\r\n
> # Server: Apache/2.4.25 (Unix)\r\n
> # Last-Modified: Sun, 18 Dec 2016 00:13:28 GMT\r\n
> # ETag: "226-543e3ac24b8ae"\r\n
> # Accept-Ranges: bytes\r\n
> # Content-Length: 550\r\n
> # DMMATCH1: 1\r\n
> # Connection: close\r\n
> # \r\n



-- 
Eric Covener
cove...@gmail.com

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Nick Kew]

On Sat, 17 Dec 2016 18:35:22 -0600
William A Rowe Jr  wrote:

> On Dec 17, 2016 17:22, "Nick Kew"  wrote:
> 
> 
> Got some test errors with the new stuff.  Investigating.
> 
> Test Summary Report
> ---
> t/apache/http_strict.t(Wstat: 0 Tests: 78 Failed: 5)
>   Failed tests:  72-75, 77
> 
> 
> Really should not occur and I haven't seen this. Shoot me the -v
> (erbose) output from your t/apache/http_strict.t please?

Cut here.  Bedtime now (coming up for 01:30), but if I
find time tomorrow I may play with the testcases under gdb.

They're all cases where the server returns 200 when the
testcase expects an error.

72:
# SENDING:
# GET /apache/http_strict/send_hdr.pl?OiBiYXI= HTTP/1.0\r\n\r\n
# DECODED: : bar
# RESPONSE:
# HTTP/1.1 200 OK\r\n
# Date: Sun, 18 Dec 2016 01:17:34 GMT\r\n
# Server: Apache/2.4.25 (Unix)\r\n
# Last-Modified: Sun, 18 Dec 2016 00:13:28 GMT\r\n
# ETag: "226-543e3ac24b8ae"\r\n
# Accept-Ranges: bytes\r\n
# Content-Length: 550\r\n
# DMMATCH1: 1\r\n
# Connection: close\r\n
# \r\n
# #!/usr/bin/perl\n
# # WARNING: this file is generated, do not edit\n
# # generated on Sun Dec 18 00:13:28 2016\n
# # 01: Apache-Test/lib/Apache/TestConfig.pm:961\n
# # 02: Apache-Test/lib/Apache/TestConfig.pm:1051\n
# # 03: Apache-Test/lib/Apache/TestMM.pm:142\n
# # 04: Makefile.PL:26\n
# \n
# BEGIN { eval { require blib && blib->import; } }\n
# use MIME::Base64;\n
# use strict;\n
# use warnings;\n
# \n
# print "Content-type: text/plain\\r\\n
# ";\n
# print decode_base64($ENV{QUERY_STRING}), "\\r\\n
# ";\n
# print "\\r\\n
# ";\n
# print "Hi!\\n
# ";\n
# print "SERVERNAME=$ENV{SERVER_NAME}\\n
# ";\n
# print "HTTP_HOST=$ENV{HTTP_HOST}\\n
# ";\n
#
# expecting 500, got 200

73:
# SENDING:
# GET /apache/http_strict/send_hdr.pl?RgBvbzogYmFy HTTP/1.0\r\n\r\n
# DECODED: F\x00oo: bar
# RESPONSE:
# HTTP/1.1 200 OK\r\n
# Date: Sun, 18 Dec 2016 01:17:34 GMT\r\n
# Server: Apache/2.4.25 (Unix)\r\n
# Last-Modified: Sun, 18 Dec 2016 00:13:28 GMT\r\n
# ETag: "226-543e3ac24b8ae"\r\n
# Accept-Ranges: bytes\r\n
# Content-Length: 550\r\n
# DMMATCH1: 1\r\n
# Connection: close\r\n
# \r\n

74:
# SENDING:
# GET /apache/http_strict/send_hdr.pl?RgFvbzogYmFy HTTP/1.0\r\n\r\n
# DECODED: F\x01oo: bar
# RESPONSE:
# HTTP/1.1 200 OK\r\n
# Date: Sun, 18 Dec 2016 01:17:34 GMT\r\n
# Server: Apache/2.4.25 (Unix)\r\n
# Last-Modified: Sun, 18 Dec 2016 00:13:28 GMT\r\n
# ETag: "226-543e3ac24b8ae"\r\n
# Accept-Ranges: bytes\r\n
# Content-Length: 550\r\n
# DMMATCH1: 1\r\n
# Connection: close\r\n
# \r\n

75:
# SENDING:
# GET /apache/http_strict/send_hdr.pl?RgpvbzogYmFy HTTP/1.0\r\n\r\n
# DECODED: F\noo: bar
# RESPONSE:
# HTTP/1.1 200 OK\r\n
# Date: Sun, 18 Dec 2016 01:17:34 GMT\r\n
# Server: Apache/2.4.25 (Unix)\r\n
# Last-Modified: Sun, 18 Dec 2016 00:13:28 GMT\r\n
# ETag: "226-543e3ac24b8ae"\r\n
# Accept-Ranges: bytes\r\n
# Content-Length: 550\r\n
# DMMATCH1: 1\r\n
# Connection: close\r\n
# \r\n


77:
# SENDING:
# GET /apache/http_strict/send_hdr.pl?Rm9vOiBiAWFy HTTP/1.0\r\n\r\n
# DECODED: Foo: b\x01ar
# RESPONSE:
# HTTP/1.1 200 OK\r\n
# Date: Sun, 18 Dec 2016 01:12:21 GMT\r\n
# Server: Apache/2.4.25 (Unix)\r\n
# Last-Modified: Sun, 18 Dec 2016 00:13:28 GMT\r\n
# ETag: "226-543e3ac24b8ae"\r\n
# Accept-Ranges: bytes\r\n
# Content-Length: 550\r\n
# DMMATCH1: 1\r\n
# Connection: close\r\n
# \r\n

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[William A Rowe Jr]

On Dec 17, 2016 17:22, "Nick Kew"  wrote:


Got some test errors with the new stuff.  Investigating.

Test Summary Report
---
t/apache/http_strict.t(Wstat: 0 Tests: 78 Failed: 5)
  Failed tests:  72-75, 77


Really should not occur and I haven't seen this. Shoot me the -v (erbose)
output from your t/apache/http_strict.t please?

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Nick Kew]

On Sat, 17 Dec 2016 23:21:09 +
Nick Kew  wrote:

> Got some test errors with the new stuff.  Investigating.
> 
> Test Summary Report
> ---
> t/apache/http_strict.t(Wstat: 0 Tests: 78 Failed: 5)
>   Failed tests:  72-75, 77

The fails are:

[ "R" . ": bar" => 500 ],
[ "R" . "F\0oo: bar"=> 500 ],
[ "R" . "F\x01oo: bar"  => 500 ],
[ "R" . "F\noo: bar"=> 500 ],
[ "R" . "Foo: b\x01ar"  => 500 ],

Sorry, haven't followed strict implementation closely enough
to know if these are known cases.

> t/modules/http2.t (Wstat: 512 Tests: 0 Failed: 0)

A visit to CPAN fixed that.  Sorry for the noise.

-- 
Nick Kew

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Nick Kew]

On Fri, 16 Dec 2016 13:29:04 -0500
Jim Jagielski  wrote:

> At long, long last, the pre-release test tarballs for Apache httpd
> version 2.4.25 can be found at the usual place:
> 
>   http://httpd.apache.org/dev/dist/
> 
> I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.

Debian GNU/Linux here.

The administrivia checks out OK, though I wonder if we really
need so many variants in this day and age?  I.e. do we need both
.gz and .bz2, and do the non-PGP checksums really serve a
useful purpose?

Builds cleanly, but the tests don't run: had to hack it to load
mod_session for ap_hook_session_save.  That's obviously a gremlin
in the test framework, but perhaps mod_session should ideally
use optional symbols for dependencies?


Got some test errors with the new stuff.  Investigating.

Test Summary Report
---
t/apache/http_strict.t(Wstat: 0 Tests: 78 Failed: 5)
  Failed tests:  72-75, 77
t/modules/http2.t (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
Files=103, Tests=2623, 123 wallclock secs ( 3.24 usr  0.39 sys + 88.52
cusr 20.56 csys = 112.71 CPU) Result: FAIL
Failed 2/103 test programs. 5/2623 subtests failed.
[warning] server localhost:8529 shutdown
[  error] error running tests (please examine t/logs/error_log)


-- 
Nick Kew

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Eric Covener]

On Fri, Dec 16, 2016 at 1:29 PM, Jim Jagielski  wrote:
> [ ] +1: Good to go


+1. Tested on aix/xlc/ppc64.  No regressions (modulo new 413 ext_filter tests)

-- 
Eric Covener
cove...@gmail.com

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[William A Rowe Jr]

Bonus reminder; if you are working from an existing checkout, top level
Makefile.PL plus make must be rerun to provision all new tests correctly.


On Dec 17, 2016 7:13 AM, "Jim Jagielski"  wrote:

> As a reminder, when Joe added those tests a few days ago,
> it was for:
>
> URL: http://svn.apache.org/viewvc?rev=1774010=rev
> Log:
> Add basic test case for mod_ext_filter & specific test for PR 60375.
>
>
>
> > On Dec 17, 2016, at 7:35 AM, Rainer Jung 
> wrote:
> >
> > Am 17.12.2016 um 10:46 schrieb Marion & Christophe JAILLET:
> >> Proposed fix in r1774728.
> >>
> >> A solution, stating that the tests have been skipped because of sed
> >> location, would be better, though.
> >
> > I switched the test to using a simple perl script instead of sed, so
> that we have no platform dependencies any more. It was only using the
> search-and-replace feature of sed, which is trivial in perl too.
> >
> > I did not change the failing tests to TODO though, because I'm not sure
> about the original intention.
> >
> >> Le 16/12/2016 à 21:46, Jacob Champion a écrit :
> >>> On 12/16/2016 12:44 PM, William A Rowe Jr wrote:
>  I expect this is a bug in the 2.4.x branch. However, I found the same
>  exceptions in 2.4.23 tag, so this is not a regression, and Joe is
> still
>  researching what is happening here, so it doesn't seem to be something
>  we would want to hold up a release for.
> >>>
> >>> Yeah, in my case I think it's just that the tests don't exit after
> >>> skipping (i.e. 48 out of 24 tests are run...). Not a showstopper.
> >
> > Regards,
> >
> > Rainer
> >
>
>

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Reindl Harald]

Am 16.12.2016 um 19:29 schrieb Jim Jagielski:

At long, long last, the pre-release test tarballs for Apache httpd
version 2.4.25 can be found at the usual place:

http://httpd.apache.org/dev/dist/

I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.

[x] +1: Good to go
[ ] +0: meh
[ ] -1: Danger Will Robinson. And why


+1 on Fedora 24 x86_64 with PHP 7.0.14 / PHP 7.1.0

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Jim Jagielski]

As a reminder, when Joe added those tests a few days ago,
it was for:

URL: http://svn.apache.org/viewvc?rev=1774010=rev
Log:
Add basic test case for mod_ext_filter & specific test for PR 60375.



> On Dec 17, 2016, at 7:35 AM, Rainer Jung  wrote:
> 
> Am 17.12.2016 um 10:46 schrieb Marion & Christophe JAILLET:
>> Proposed fix in r1774728.
>> 
>> A solution, stating that the tests have been skipped because of sed
>> location, would be better, though.
> 
> I switched the test to using a simple perl script instead of sed, so that we 
> have no platform dependencies any more. It was only using the 
> search-and-replace feature of sed, which is trivial in perl too.
> 
> I did not change the failing tests to TODO though, because I'm not sure about 
> the original intention.
> 
>> Le 16/12/2016 à 21:46, Jacob Champion a écrit :
>>> On 12/16/2016 12:44 PM, William A Rowe Jr wrote:
 I expect this is a bug in the 2.4.x branch. However, I found the same
 exceptions in 2.4.23 tag, so this is not a regression, and Joe is still
 researching what is happening here, so it doesn't seem to be something
 we would want to hold up a release for.
>>> 
>>> Yeah, in my case I think it's just that the tests don't exit after
>>> skipping (i.e. 48 out of 24 tests are run...). Not a showstopper.
> 
> Regards,
> 
> Rainer
> 

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Jim Jagielski]

+1:

 o CentOS5, x64 - event, worker
 o CentOS6, x64 - event, worker
 o CentOS7, x64 - event
 o macOS 10.12, x64 - event, worker

No regressions (mod_ext_filter test failures aren't regressions)

> On Dec 16, 2016, at 1:29 PM, Jim Jagielski  wrote:
> 
> At long, long last, the pre-release test tarballs for Apache httpd
> version 2.4.25 can be found at the usual place:
> 
>   http://httpd.apache.org/dev/dist/
> 
> I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.
> 
> [ ] +1: Good to go
> [ ] +0: meh
> [ ] -1: Danger Will Robinson. And why.
> 
> Vote will last the normal 72 hrs.
> 
> NOTE: The *-deps are only there for convenience.
> 
> Thx!

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Jim Jagielski]

Those failures do not reflect a regression.

> On Dec 16, 2016, at 3:11 PM, Jacob Champion  wrote:
> 
> On 12/16/2016 10:29 AM, Jim Jagielski wrote:
>> I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.
> 
> mod_ext_filter tests are failing for me on Ubuntu 16.04 x64, but I *think* 
> this is due to a bug in the tests as opposed to a regression, related to the 
> conversation in [1]. Does anyone else see this?
> 
> --Jacob
> 
> [1] 
> https://lists.apache.org/thread.html/a11542ab3c06511e87bde4327dd1cfb72a027ac7bae895a18a772c5b@%3Ccvs.httpd.apache.org%3E

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Rainer Jung]

Am 17.12.2016 um 10:46 schrieb Marion & Christophe JAILLET:

Proposed fix in r1774728.

A solution, stating that the tests have been skipped because of sed
location, would be better, though.


I switched the test to using a simple perl script instead of sed, so 
that we have no platform dependencies any more. It was only using the 
search-and-replace feature of sed, which is trivial in perl too.


I did not change the failing tests to TODO though, because I'm not sure 
about the original intention.



Le 16/12/2016 à 21:46, Jacob Champion a écrit :

On 12/16/2016 12:44 PM, William A Rowe Jr wrote:

I expect this is a bug in the 2.4.x branch. However, I found the same
exceptions in 2.4.23 tag, so this is not a regression, and Joe is still
researching what is happening here, so it doesn't seem to be something
we would want to hold up a release for.


Yeah, in my case I think it's just that the tests don't exit after
skipping (i.e. 48 out of 24 tests are run...). Not a showstopper.


Regards,

Rainer

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Marion & Christophe JAILLET]

Proposed fix in r1774728.

A solution, stating that the tests have been skipped because of sed 
location, would be better, though.


CJ

Le 16/12/2016 à 21:46, Jacob Champion a écrit :

On 12/16/2016 12:44 PM, William A Rowe Jr wrote:

I expect this is a bug in the 2.4.x branch. However, I found the same
exceptions in 2.4.23 tag, so this is not a regression, and Joe is still
researching what is happening here, so it doesn't seem to be something
we would want to hold up a release for.


Yeah, in my case I think it's just that the tests don't exit after 
skipping (i.e. 48 out of 24 tests are run...). Not a showstopper.


--Jacob

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[William A Rowe Jr]

On Sat, Dec 17, 2016 at 12:51 AM, William A Rowe Jr 
wrote:

> Color me confused, is this w/w-o the hack for APR_HAVE_TIME_T?
>

Nevermind, that issues is entirely resolved. Thanks for confirmation!



> On Sat, Dec 17, 2016 at 12:09 AM, Jan Ehrhardt  wrote:
>
>> Jim Jagielski in gmane.comp.apache.devel (Fri, 16 Dec 2016 13:29:04
>> -0500):
>> >[x] +1: Good to go
>>
>> Running without problems on my dev server now.
>> Windows 2008 R2, VC9 x86 and VC11, x64
>> --
>> Jan
>>
>>
>

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[William A Rowe Jr]

Color me confused, is this w/w-o the hack for APR_HAVE_TIME_T?

On Sat, Dec 17, 2016 at 12:09 AM, Jan Ehrhardt  wrote:

> Jim Jagielski in gmane.comp.apache.devel (Fri, 16 Dec 2016 13:29:04
> -0500):
> >[x] +1: Good to go
>
> Running without problems on my dev server now.
> Windows 2008 R2, VC9 x86 and VC11, x64
> --
> Jan
>
>

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Jan Ehrhardt]

Jim Jagielski in gmane.comp.apache.devel (Fri, 16 Dec 2016 13:29:04
-0500):
>[x] +1: Good to go

Running without problems on my dev server now.
Windows 2008 R2, VC9 x86 and VC11, x64
-- 
Jan

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[William A Rowe Jr]

On Fri, Dec 16, 2016 at 3:01 PM, Rainer Jung 
wrote:

> Am 16.12.2016 um 21:11 schrieb Jacob Champion:
>
>> On 12/16/2016 10:29 AM, Jim Jagielski wrote:
>>
>>> I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.
>>>
>>
>> mod_ext_filter tests are failing for me on Ubuntu 16.04 x64, but I
>> *think* this is due to a bug in the tests as opposed to a regression,
>> related to the conversation in [1]. Does anyone else see this?
>>
>
> Tests 5-24 fail for me as well, status 200 instead of 413. But I thought
> it might be due to
>
> https://bz.apache.org/bugzilla/show_bug.cgi?id=60375
>
> not yet being fixed. The attached patch was not yet applied, not even for
> trunk. So probably the tests should be marked as TODO?
>

+1 on TODO for tests 5-24 under 2.4.x.

These tests already pass on trunk, which is odd if the proposed bugfix
isn't there yet :)

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Rainer Jung]

Am 16.12.2016 um 21:11 schrieb Jacob Champion:

On 12/16/2016 10:29 AM, Jim Jagielski wrote:

I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.


mod_ext_filter tests are failing for me on Ubuntu 16.04 x64, but I
*think* this is due to a bug in the tests as opposed to a regression,
related to the conversation in [1]. Does anyone else see this?


Tests 5-24 fail for me as well, status 200 instead of 413. But I thought 
it might be due to


https://bz.apache.org/bugzilla/show_bug.cgi?id=60375

not yet being fixed. The attached patch was not yet applied, not even 
for trunk. So probably the tests should be marked as TODO?



[1]
https://lists.apache.org/thread.html/a11542ab3c06511e87bde4327dd1cfb72a027ac7bae895a18a772c5b@%3Ccvs.httpd.apache.org%3E


svn log says it is a test for BZ60375, but it seems that BZ is still open.

Regards,

Rainer

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Jacob Champion]

On 12/16/2016 12:44 PM, William A Rowe Jr wrote:

I expect this is a bug in the 2.4.x branch. However, I found the same
exceptions in 2.4.23 tag, so this is not a regression, and Joe is still
researching what is happening here, so it doesn't seem to be something
we would want to hold up a release for.


Yeah, in my case I think it's just that the tests don't exit after 
skipping (i.e. 48 out of 24 tests are run...). Not a showstopper.


--Jacob

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[William A Rowe Jr]

On Fri, Dec 16, 2016 at 2:11 PM, Jacob Champion 
wrote:

> On 12/16/2016 10:29 AM, Jim Jagielski wrote:
>
>> I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.
>>
>
> mod_ext_filter tests are failing for me on Ubuntu 16.04 x64, but I *think*
> this is due to a bug in the tests as opposed to a regression, related to
> the conversation in [1]. Does anyone else see this?
>
> --Jacob
>
> [1] https://lists.apache.org/thread.html/a11542ab3c06511e87bde43
> 27dd1cfb72a027ac7bae895a18a772c5b@%3Ccvs.httpd.apache.org%3E
>

I expect this is a bug in the 2.4.x branch. However, I found the same
exceptions in 2.4.23 tag, so this is not a regression, and Joe is still
researching what is happening here, so it doesn't seem to be something
we would want to hold up a release for.

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Jacob Champion]

On 12/16/2016 10:29 AM, Jim Jagielski wrote:

I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.


mod_ext_filter tests are failing for me on Ubuntu 16.04 x64, but I 
*think* this is due to a bug in the tests as opposed to a regression, 
related to the conversation in [1]. Does anyone else see this?


--Jacob

[1] 
https://lists.apache.org/thread.html/a11542ab3c06511e87bde4327dd1cfb72a027ac7bae895a18a772c5b@%3Ccvs.httpd.apache.org%3E