RE: cvs commit: httpd-2.0/os/win32 ap_regkey.c util_win32.c

[Sander Striker]

> From: Bill Stoddard [mailto:[EMAIL PROTECTED]]
> Sent: Wednesday, January 08, 2003 8:33 PM

> Sander,

> This patch is needed in 2.0.44 to fix a compile break. I have already committed
> it to 2.0 and 2.1

Duly noted.  Thanks,

Sander

Re: cvs commit: httpd-2.0/os/win32 ap_regkey.c

[Cliff Woolley]

On Mon, 24 Jun 2002, Justin Erenkrantz wrote:

> As I don't believe that ap_regkey.h can be implemented on anything other
> than Win32, I think the ap_regkey.h file belongs in os/win32/ not in
> include/.

Having just looked at it, I was just about to report the same conclusion.
But I see you beat me to it.  :)  Yeah, that definitely looks like what
should be done AFAICT.

--Cliff

Re: cvs commit: httpd-2.0/os/win32 ap_regkey.c

[Justin Erenkrantz]

On Mon, Jun 24, 2002 at 01:38:53AM -0500, [EMAIL PROTECTED] wrote:
> [EMAIL PROTECTED] writes:
> 
> > wrowe   2002/06/23 21:50:41
> > 
> >   Added:   include  ap_regkey.h
> >os/win32 ap_regkey.c
> >   Log:
> > Introduce win32 registry handling through a very apr-ish interface.
> > Deals with apr utf-8 encoding of filesystem values, so we preserve
> > strings in any locality or nationalized flavor of WinNT, and avoid
> > the gunk for Win9x.
> >   
> >   Revision  ChangesPath
> >   1.1  httpd-2.0/include/ap_regkey.h
> 
> Quick question here.  I just updated to HEAD of httpd-2.0, and
> attempted to build (under Linux), only to find that exports.c is
> making references to these new functions.  

As I don't believe that ap_regkey.h can be implemented on anything
other than Win32, I think the ap_regkey.h file belongs in
os/win32/ not in include/.  

Since I don't know what OtherBill's plans are (other than all of
us installing the Microsoft OS flavor-of-the-month on all of our
machines), I won't touch it, but I think if you moved it in your
local repos, you'd be okay for now.  -- justin

Re: cvs commit: httpd-2.0/os/win32 ap_regkey.c

[cmpilato]

[EMAIL PROTECTED] writes:

> wrowe   2002/06/23 21:50:41
> 
>   Added:   include  ap_regkey.h
>os/win32 ap_regkey.c
>   Log:
> Introduce win32 registry handling through a very apr-ish interface.
> Deals with apr utf-8 encoding of filesystem values, so we preserve
> strings in any locality or nationalized flavor of WinNT, and avoid
> the gunk for Win9x.
>   
>   Revision  ChangesPath
>   1.1  httpd-2.0/include/ap_regkey.h

Quick question here.  I just updated to HEAD of httpd-2.0, and
attempted to build (under Linux), only to find that exports.c is
making references to these new functions.  

   
server/.libs/libmain.al(exports.lo)(.data+0x14):/home/cmpilato/projects/httpd-2.0/server/exports.c:
 undefined reference to `ap_regkey_const'
   
server/.libs/libmain.al(exports.lo)(.data+0x18):/home/cmpilato/projects/httpd-2.0/server/exports.c:
 undefined reference to `ap_regkey_open'
   
server/.libs/libmain.al(exports.lo)(.data+0x1c):/home/cmpilato/projects/httpd-2.0/server/exports.c:
 undefined reference to `ap_regkey_close'
   
server/.libs/libmain.al(exports.lo)(.data+0x20):/home/cmpilato/projects/httpd-2.0/server/exports.c:
 undefined reference to `ap_regkey_remove'
   
server/.libs/libmain.al(exports.lo)(.data+0x24):/home/cmpilato/projects/httpd-2.0/server/exports.c:
 undefined reference to `ap_regkey_value_get'
   collect2: ld returned 1 exit status

Are they only implemented for Win32, and if so, what magic must I work
to keep make_exports.awk from noticing ap_regkey.h (which is what I
*think* is going on ... not claiming to fully understand the Apache
build process here)?