Re: svn commit: r1187986 - in /httpd/httpd/trunk/docs/manual: custom-error.xml mod/core.xml

2011-10-24 Thread Stefan Fritsch
On Monday 24 October 2011, Roy T. Fielding wrote:
 On Oct 23, 2011, at 3:09 PM, s...@apache.org wrote:
  --- httpd/httpd/trunk/docs/manual/mod/core.xml (original)
  +++ httpd/httpd/trunk/docs/manual/mod/core.xml Sun Oct 23
  22:09:34 2011 @@ -1165,6 +1165,7 @@ in case of an
  error/description
  
   ErrorDocument 404 /cgi-bin/bad_urls.plbr /
   ErrorDocument 401 /subscription_info.htmlbr /
   ErrorDocument 403 Sorry can't allow you access today
  
  +  ErrorDocument 403 Forbidden!
  
 /example
 
 pAdditionally, the special value codedefault/code can be
 used
 
 I don't think that change was intended, right?  Looks like an error
 test.

No, this example is intendended to demonstrate that the double quotes 
are not significant. But a line break was missing.


Re: svn commit: r1187986 - in /httpd/httpd/trunk/docs/manual: custom-error.xml mod/core.xml

2011-10-24 Thread William A. Rowe Jr.
On 10/24/2011 6:25 AM, Stefan Fritsch wrote:
 On Monday 24 October 2011, Roy T. Fielding wrote:
 On Oct 23, 2011, at 3:09 PM, s...@apache.org wrote:
 --- httpd/httpd/trunk/docs/manual/mod/core.xml (original)
 +++ httpd/httpd/trunk/docs/manual/mod/core.xml Sun Oct 23
 22:09:34 2011 @@ -1165,6 +1165,7 @@ in case of an
 error/description

  ErrorDocument 404 /cgi-bin/bad_urls.plbr /
  ErrorDocument 401 /subscription_info.htmlbr /
  ErrorDocument 403 Sorry can't allow you access today

 +  ErrorDocument 403 Forbidden!

/example

pAdditionally, the special value codedefault/code can be
used

 I don't think that change was intended, right?  Looks like an error
 test.
 
 No, this example is intendended to demonstrate that the double quotes 
 are not significant. But a line break was missing.

Actually that shouldn't be supported.  If it was an undocumented feature
it aught to stay undocumented.  How do we know this isn't a typo of
URI /Forbidden! ?

Trip on the way-back machine to early 1.3, the leading quote was required
(and trailing quote wasn't allowed, weird).  I had intended that they
would have leading and trailing quotes when I patched that oddity.





Re: svn commit: r1187986 - in /httpd/httpd/trunk/docs/manual: custom-error.xml mod/core.xml

2011-10-24 Thread Stefan Fritsch
On Monday 24 October 2011, William A. Rowe Jr. wrote:
 On 10/24/2011 6:25 AM, Stefan Fritsch wrote:
  On Monday 24 October 2011, Roy T. Fielding wrote:
  On Oct 23, 2011, at 3:09 PM, s...@apache.org wrote:
  --- httpd/httpd/trunk/docs/manual/mod/core.xml (original)
  +++ httpd/httpd/trunk/docs/manual/mod/core.xml Sun Oct 23
  22:09:34 2011 @@ -1165,6 +1165,7 @@ in case of an
  error/description
  
   ErrorDocument 404 /cgi-bin/bad_urls.plbr /
   ErrorDocument 401 /subscription_info.htmlbr /
   ErrorDocument 403 Sorry can't allow you access today
  
  +  ErrorDocument 403 Forbidden!
  
 /example
 
 pAdditionally, the special value codedefault/code can
 be used
  
  I don't think that change was intended, right?  Looks like an
  error test.
  
  No, this example is intendended to demonstrate that the double
  quotes are not significant. But a line break was missing.
 
 Actually that shouldn't be supported.  If it was an undocumented
 feature it aught to stay undocumented.  How do we know this isn't
 a typo of URI /Forbidden! ?

We don't. We just look at the leading slash. I have merely documented 
what is the current behaviour since 2.0.

 Trip on the way-back machine to early 1.3, the leading quote was
 required (and trailing quote wasn't allowed, weird).  I had
 intended that they would have leading and trailing quotes when I
 patched that oddity.

The quotes are eaten by ap_getword_conf in AP_INIT_TAKE2. One would 
have to use AP_INIT_RAW_ARGS to see them. But IMO the current behavior 
is ok, no need to change it.


Re: svn commit: r1187986 - in /httpd/httpd/trunk/docs/manual: custom-error.xml mod/core.xml

2011-10-23 Thread Roy T . Fielding
On Oct 23, 2011, at 3:09 PM, s...@apache.org wrote:

 --- httpd/httpd/trunk/docs/manual/mod/core.xml (original)
 +++ httpd/httpd/trunk/docs/manual/mod/core.xml Sun Oct 23 22:09:34 2011
 @@ -1165,6 +1165,7 @@ in case of an error/description
  ErrorDocument 404 /cgi-bin/bad_urls.plbr /
  ErrorDocument 401 /subscription_info.htmlbr /
  ErrorDocument 403 Sorry can't allow you access today
 +  ErrorDocument 403 Forbidden!
/example
 
pAdditionally, the special value codedefault/code can be used

I don't think that change was intended, right?  Looks like an error test.

Roy