Re: Small cleanup in "/modules/mappers/mod_negotiation.c", in function get_body
On Sunday 20 November 2005 11:03, Jeff Trawick wrote: > I think it is a good idea for people who show up with patches out of > the blue to see a recognition of their contribution, even if > relatively small. Many people off the dev list don't realize that a > lot of fixes come from random people. It can only help to do what we > can to promote that perception. In the case of a tiny fix (which a compiler will probably optimise out anyway), the appropriate level of acknowledgement is IMHO the commit message. That's on record, and could be anything from a one-off to a first step towards full committership. Save CHANGES for things that'll affect people in real life. And of course, acknowledge contributors there. OTTOMH I've credited Brian France and Chris Darroch in my recent commits - when they had made (significant) contributions. -- Nick Kew
Re: Small cleanup in "/modules/mappers/mod_negotiation.c", in function get_body
On 11/20/05, Ruediger Pluem <[EMAIL PROTECTED]> wrote: > > > On 11/20/2005 11:00 AM, Ruediger Pluem wrote: > > > [..cut..] > > > > > If there is consensus that such trivial CHANGES should not be added (which > > I would > > also tend to with the reasons you mentioned), then I will happily remove > > the CHANGE > > log entry. So another comment please! > > Ok, forget about the removal part. Paul backported it to 2.2.x and taged > 2.1.10 afterwards. > So I cannot remove it for this case. Anyway since I was uncertain about the > 'right' thing > to do here and since it seemed to be handled differently by different people > I still like > to have further comments on this issue :-). I think it is a good idea for people who show up with patches out of the blue to see a recognition of their contribution, even if relatively small. Many people off the dev list don't realize that a lot of fixes come from random people. It can only help to do what we can to promote that perception.
Re: Small cleanup in "/modules/mappers/mod_negotiation.c", in function get_body
On 11/20/2005 11:00 AM, Ruediger Pluem wrote: [..cut..] > > If there is consensus that such trivial CHANGES should not be added (which I > would > also tend to with the reasons you mentioned), then I will happily remove the > CHANGE > log entry. So another comment please! Ok, forget about the removal part. Paul backported it to 2.2.x and taged 2.1.10 afterwards. So I cannot remove it for this case. Anyway since I was uncertain about the 'right' thing to do here and since it seemed to be handled differently by different people I still like to have further comments on this issue :-). Regards Rüdiger
Re: Small cleanup in "/modules/mappers/mod_negotiation.c", in function get_body
On 11/19/2005 10:20 PM, Nick Kew wrote: > On Saturday 19 November 2005 21:03, Ruediger Pluem wrote: > >>Thanks. Committed to trunk as r345686 >>(http://svn.apache.org/viewcvs.cgi?rev=345686&view=rev). > > > Fine. But do such trivial changes - or indeed anything that has no effect > on functionality - really belong in CHANGES? The repository documents > all changes, but the CHANGES file itself is going to get totally unreadable > if we put that kind of thing in. > I was also in daubt of putting it in the CHANGES. But I found the following entry which seemed to be similar trivial: *) Fix typo in ProxyStatus syntax error message. [Christophe Jaillet ] If there is consensus that such trivial CHANGES should not be added (which I would also tend to with the reasons you mentioned), then I will happily remove the CHANGE log entry. So another comment please! Regards Rüdiger
Re: Small cleanup in "/modules/mappers/mod_negotiation.c", in function get_body
On Saturday 19 November 2005 21:03, Ruediger Pluem wrote: > Thanks. Committed to trunk as r345686 > (http://svn.apache.org/viewcvs.cgi?rev=345686&view=rev). Fine. But do such trivial changes - or indeed anything that has no effect on functionality - really belong in CHANGES? The repository documents all changes, but the CHANGES file itself is going to get totally unreadable if we put that kind of thing in. -- Nick Kew
Re: Small cleanup in "/modules/mappers/mod_negotiation.c", in function get_body
Thanks. Committed to trunk as r345686 (http://svn.apache.org/viewcvs.cgi?rev=345686&view=rev). Regards Rüdiger On 11/16/2005 11:56 PM, Christophe Jaillet wrote: > In "/modules/mappers/mod_negotiation.c", in function get_body, arround line > 857, we have : > endbody += strlen(tag); > > This could be replaced by : > endbody += taglen; > > because strlen(tag) has already been computed around line 835 > taglen = strlen(tag); > > CJ > > > > >
Small cleanup in "/modules/mappers/mod_negotiation.c", in function get_body
In "/modules/mappers/mod_negotiation.c", in function get_body, arround line 857, we have : endbody += strlen(tag); This could be replaced by : endbody += taglen; because strlen(tag) has already been computed around line 835 taglen = strlen(tag); CJ
