Re: svn commit: r769020 - in /httpd/httpd/trunk/modules/proxy: balancers/mod_lbmethod_bybusyness.c balancers/mod_lbmethod_byrequests.c balancers/mod_lbmethod_bytraffic.c balancers/mod_lbmethod_heartbe
On May 1, 2009, at 4:50 AM, jean-frederic clere wrote: Jim Jagielski wrote: On Apr 30, 2009, at 4:04 AM, jean-frederic clere wrote: j...@apache.org wrote: Author: jim Date: Mon Apr 27 15:02:40 2009 New Revision: 769020 URL: http://svn.apache.org/viewvc?rev=769020view=rev Log: Fold in initial template for methods to be able to reset (initialize) and age their data, useful when adding new workers, or when workers come back into the fold Logic and code to come in a bit :) In fact the reset() allow to create the worker but we will still create it in the mod_proxy_balancer, correct? Yes... plus, reset means different things to each balancer, since they use different vars for tracking So the reset is going to be call in the add_member() just after ap_proxy_add_worker_to_balancer() correct? +++ runtime-id = proxy_lb_workers; proxy_lb_workers++; +++ In fact prevents that reset() to be able to generate id for worker. In mod_cluster for example I have a saved configuration of worker and I am restoring on cold restart I would like the id to be the slotmem id, does it make sense to move the id generation to the reset()? +1... makes sense.
Re: svn commit: r769020 - in /httpd/httpd/trunk/modules/proxy: balancers/mod_lbmethod_bybusyness.c balancers/mod_lbmethod_byrequests.c balancers/mod_lbmethod_bytraffic.c balancers/mod_lbmethod_heartbe
Jim Jagielski wrote: On Apr 30, 2009, at 4:04 AM, jean-frederic clere wrote: j...@apache.org wrote: Author: jim Date: Mon Apr 27 15:02:40 2009 New Revision: 769020 URL: http://svn.apache.org/viewvc?rev=769020view=rev Log: Fold in initial template for methods to be able to reset (initialize) and age their data, useful when adding new workers, or when workers come back into the fold Logic and code to come in a bit :) In fact the reset() allow to create the worker but we will still create it in the mod_proxy_balancer, correct? Yes... plus, reset means different things to each balancer, since they use different vars for tracking So the reset is going to be call in the add_member() just after ap_proxy_add_worker_to_balancer() correct? +++ runtime-id = proxy_lb_workers; proxy_lb_workers++; +++ In fact prevents that reset() to be able to generate id for worker. In mod_cluster for example I have a saved configuration of worker and I am restoring on cold restart I would like the id to be the slotmem id, does it make sense to move the id generation to the reset()? Cheers Jean-Frederic
Re: svn commit: r769020 - in /httpd/httpd/trunk/modules/proxy: balancers/mod_lbmethod_bybusyness.c balancers/mod_lbmethod_byrequests.c balancers/mod_lbmethod_bytraffic.c balancers/mod_lbmethod_heartbe
j...@apache.org wrote: Author: jim Date: Mon Apr 27 15:02:40 2009 New Revision: 769020 URL: http://svn.apache.org/viewvc?rev=769020view=rev Log: Fold in initial template for methods to be able to reset (initialize) and age their data, useful when adding new workers, or when workers come back into the fold Logic and code to come in a bit :) In fact the reset() allow to create the worker but we will still create it in the mod_proxy_balancer, correct? Cheers Jean-Frederic
Re: svn commit: r769020 - in /httpd/httpd/trunk/modules/proxy: balancers/mod_lbmethod_bybusyness.c balancers/mod_lbmethod_byrequests.c balancers/mod_lbmethod_bytraffic.c balancers/mod_lbmethod_heartbe
On Apr 30, 2009, at 4:04 AM, jean-frederic clere wrote: j...@apache.org wrote: Author: jim Date: Mon Apr 27 15:02:40 2009 New Revision: 769020 URL: http://svn.apache.org/viewvc?rev=769020view=rev Log: Fold in initial template for methods to be able to reset (initialize) and age their data, useful when adding new workers, or when workers come back into the fold Logic and code to come in a bit :) In fact the reset() allow to create the worker but we will still create it in the mod_proxy_balancer, correct? Yes... plus, reset means different things to each balancer, since they use different vars for tracking
Re: svn commit: r769020 - in /httpd/httpd/trunk/modules/proxy: balancers/mod_lbmethod_bybusyness.c balancers/mod_lbmethod_byrequests.c balancers/mod_lbmethod_bytraffic.c balancers/mod_lbmethod_heartbe
On 04/27/2009 05:02 PM, j...@apache.org wrote:
Author: jim
Date: Mon Apr 27 15:02:40 2009
New Revision: 769020
URL: http://svn.apache.org/viewvc?rev=769020view=rev
Log:
Fold in initial template for methods to be able to
reset (initialize) and age their data, useful when
adding new workers, or when workers come back into
the fold
Logic and code to come in a bit :)
Modified:
httpd/httpd/trunk/modules/proxy/balancers/mod_lbmethod_bybusyness.c
httpd/httpd/trunk/modules/proxy/balancers/mod_lbmethod_byrequests.c
httpd/httpd/trunk/modules/proxy/balancers/mod_lbmethod_bytraffic.c
httpd/httpd/trunk/modules/proxy/balancers/mod_lbmethod_heartbeat.c
httpd/httpd/trunk/modules/proxy/mod_proxy.h
httpd/httpd/trunk/modules/proxy/proxy_util.c
Modified: httpd/httpd/trunk/modules/proxy/proxy_util.c
URL:
http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/proxy_util.c?rev=769020r1=769019r2=769020view=diff
==
--- httpd/httpd/trunk/modules/proxy/proxy_util.c (original)
+++ httpd/httpd/trunk/modules/proxy/proxy_util.c Mon Apr 27 15:02:40 2009
@@ -2346,6 +2346,8 @@
worker-hostname);
}
else {
+if (worker-s-retries) {
+}
What will be the purpose of this?
Regards
Rüdiger
