[GitHub] ignite pull request #1242: Ignite 4239

[tledkov-gridgain]

GitHub user tledkov-gridgain opened a pull request:

https://github.com/apache/ignite/pull/1242

Ignite 4239



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-4239

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1242.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1242


commit 7290d88e14a15a3d030b7381dbd0a3f14cb65a12
Author: Pavel Tupitsyn 
Date:   2016-10-18T14:17:17Z

IGNITE-4030 Streamline PlatformTarget operation methods

This closes #1167

commit 66c76d1f30f024b58db8cab07ba9e7d429f596f8
Author: tledkov-gridgain 
Date:   2016-10-18T15:45:06Z

IGNITE-2355 Fixed the test HadoopClientProtocolMultipleServersSelfTest. 
Clear connection poll after the test, cosmetic.

commit f37fbcab1ae2c7553696e96b7a9c3194a570d7af
Author: isapego 
Date:   2016-10-19T10:06:42Z

IGNITE-3705: Fixed compiliation warnings. This closes #1169.

commit 7ed2bb7e341701d052220a36a2b2f8f0a46fd644
Author: AMRepo 
Date:   2016-10-19T15:33:59Z

IGNITE-3448 Support SQL queries with distinct aggregates added. This closes 
#3448.

commit 551a4dfae6169a07a5e28f9b266f90311f3216b7
Author: tledkov-gridgain 
Date:   2016-10-21T10:25:57Z

IGNITE-2355 Fixed the test HadoopClientProtocolMultipleServersSelfTest. 
Clear connection poll before and after  the test

commit ec12a9db2265180f96be72e2217e60ced856164e
Author: vozerov-gridgain 
Date:   2016-10-24T14:52:36Z

Minor fix for flags passed to GridCacheMapEntry.initialValue from data 
streamer isolated updater.

commit 44740465677c39068dc813dabd464e60f09e5f49
Author: tledkov-gridgain 
Date:   2016-10-26T13:00:11Z

IGNITE-4062: fix BinaryObject.equals: compare only bytes containing the 
fields' data (without header and footer). This closes  #1182.

commit 9ddb8be1243df8e489f7ebc716d315415775439a
Author: Dmitriy Govorukhin 
Date:   2016-10-27T14:52:22Z

IGNITE-2079 GridCacheIoManager eats exception trail if it falls into the 
directed case
merger from ignite-2079-2

# Conflicts:
#   
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryMetricsAdapter.java

commit 6f160728c544d252f77bdb85c0ff2857559707a3
Author: Valentin Kulichenko 
Date:   2016-10-28T23:18:14Z

IGNITE-4110 - Fixed BUFFER_UNDERFLOW and BUFFER_OVERFLOW handling in 
BlockingSslHandler

commit 6b78ad0cbbcf286cb083136c49cebd5dd85de58c
Author: sboikov 
Date:   2016-10-31T07:35:44Z

TcoDiscovery: reduced amount of debug logging (heartbeat/connection check 
messages are logged trace level).

commit 175da6b7e394dd76c27d5155ff98a5b2ef03bb9d
Author: tledkov-gridgain 
Date:   2016-11-07T06:16:58Z

IGNITE-3432:  check data/meta cache names are different for different IGFS 
instances. This closes #1201

commit 218b699be0585c16a086bbeb6767d7c7a19e9ba0
Author: tledkov-gridgain 
Date:   2016-11-17T05:34:52Z

IGNITE-4239: add GridInternal annotaion for tasks instead of jobs.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (IGNITE-4239) Public thread pool starvation is cause of deadlock when user's jobs calls cache.size()

[Taras Ledkov (JIRA)]

Taras Ledkov created IGNITE-4239:


 Summary: Public thread pool starvation is cause of deadlock when 
user's jobs calls cache.size()
 Key: IGNITE-4239
 URL: https://issues.apache.org/jira/browse/IGNITE-4239
 Project: Ignite
  Issue Type: Bug
  Components: cache, compute
Affects Versions: 1.6
Reporter: Taras Ledkov
Assignee: Taras Ledkov
Priority: Critical
 Fix For: 1.9


The users job are hang when a lot of jobs that calculates cache size are 
submitted.

The log contains message:
{code}
WARNING: Possible thread pool starvation detected (no task completed in last 
3ms, is executorService pool size large enough?)
{code}

After a while all the thread of a public threadpool are locked on waiting the 
SizeTask future. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Geospatial queries example fails in master

[Denis Magda]

Igniters,

I’ve just added the documentation about our geospatial queries [1] and wanted 
to contribute an example [2].

However, the example no longer works in the master branch producing the error 
you can see in the ticket [2].
The same example works perfectly fine in version 1.7 and earliest. You can 
download this project [3] and check that it’s true. 

Sergi, please have a look at the issue reported in [1]. We’re approaching 1.8 
release and looks like we overlooked some new bug introduced recently.

[1] http://apacheignite.gridgain.org/v1.7/docs/geospatial-queries 

[2] https://issues.apache.org/jira/browse/IGNITE-4238 

[3] https://github.com/dmagda/geospatial 

—
Denis

[GitHub] ignite pull request #1241: Added geospatial example

[dmagda]

GitHub user dmagda opened a pull request:

https://github.com/apache/ignite/pull/1241

Added geospatial example



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/ignite ignite-4238

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1241.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1241


commit 54e754bd8706dea22bed1803b57b632fcee9bc74
Author: Denis Magda 
Date:   2016-11-17T01:11:30Z

Added geospatial example




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Apache Ignite 1.8 Release

[Denis Magda]

Roman,

That versions will be created after 1.8 gets released. Recently there was a 
discussion on the dev list [1] regarding the difficulties related to 
documentation maintenance when several documentation versions co-exist at the 
same time.

It was decided that rather then create a new version for the documentation once 
a new feature added to Ignite it’s better to create a hidden page under the 
current documentation version and make it visible once the next version is 
created after the release.

The bottom line is that, please create a hidden page with a suffix 
“page_name-1.8” and once 1.8 gets released Prachi will create readme.io 
 1.8 and make your doc visible.

[1] 
http://apache-ignite-developers.2346864.n4.nabble.com/Maintaining-documentation-consistency-on-readme-io-td10868.html
 


—
Denis

> On Nov 16, 2016, at 5:00 PM, Roman Shtykh  wrote:
> 
> Denis,
> Any plans to add 1.8.0 in readme.io for new features?
> -Roman
>On Wednesday, November 16, 2016 6:08 AM, Denis Magda  
> wrote:
> 
> 
> Igor,
> 
> It makes sense to wait for me while everything gets merged into 1.8 then. 
> Please let me know over this discussion when the overall merge happens.
> 
> —
> Denis
> 
>> On Nov 15, 2016, at 1:45 AM, Igor Sapego  wrote:
>> 
>> Denis,
>> 
>> I can merge PDO-related changes into 1.8 but without DML they will break 
>> tests
>> and even compilation so I don't see any sense in doing that before DML is 
>> merged.
>> 
>> After DML is ready and merged I'll need some time to merge my changes and 
>> check
>> that everything works as intended. The code itself, tests and examples are 
>> ready.
>> 
>> 
>> Best Regards,
>> Igor
>> 
>> On Tue, Nov 15, 2016 at 11:31 AM, Pavel Tupitsyn > > wrote:
>> Denis, [1] depends on [2], and [2](.NET: CacheEntryProcessor binary mode)
>> is not a simple thing. We won't be able to do that for 1.8.
>> Other than that, I'll try to fit as many of them as I can. But I can't
>> answer your question since I don't see any date yet.
>> 
>> By the way, you were going to help with the reviews.
>> 
>> [1] https://issues.apache.org/jira/browse/IGNITE-4128 
>> 
>> [2] https://issues.apache.org/jira/browse/IGNITE-3825 
>> 
>> 
>> On Tue, Nov 15, 2016 at 4:03 AM, Denis Magda > > wrote:
>> 
>>> *Alexander P., Igor S.,*
>>> 
>>> When will your merge all DML and ODBC (PDO) related changes into 1.8
>>> branch? I’m looking forward to go through PDO [1] documentation and be sure
>>> that everything works as described on my side.
>>> 
>>> *Pavel,*
>>> 
>>> Do you think it will be possible to complete all the .NET usability
>>> tickets [2] under 1.8 and roll them out to the Apache Ignite users?
>>> 
>>> [1] https://issues.apache.org/jira/browse/IGNITE-3921 
>>> 
>>> [2] https://issues.apache.org/jira/browse/IGNITE-4114 
>>> 
>>> 
>>> —
>>> Denis
>>> 
>>> On Nov 9, 2016, at 6:55 AM, Denis Magda >> > wrote:
>>> 
>>> Do we have a branch for ignite-1.8? Is there anyone who can take over the
>>> release process of 1.8?
>>> 
>>> —
>>> Denis
>>> 
>>> On Nov 8, 2016, at 9:01 PM, Alexander Paschenko <
>>> alexander.a.pasche...@gmail.com > 
>>> wrote:
>>> 
>>> Current status on DML:
>>> 
>>> - Basic data streamer support implemented (basicness is mostly about
>>> configuration - say, currently there's no way to specify streamer's
>>> batch size via JDBC driver, but this can be improved easily).
>>> 
>>> - Fixed all minor stuff agreed with Vladimir.
>>> 
>>> - There are some tests that started failing after binary hash codes
>>> generation rework made by Vladimir in ignite-4011-1 branch, I will ask
>>> him to look into it and fix those. Failing tests live in
>>> GridCacheBinaryObjectsAbstractSelfTest, and are as follows:
>>> - testPutWithFieldsHashing
>>> - testCrossFormatObjectsIdentity
>>> - testPutWithCustomHashing
>>> I added them personally during working on first version of auto
>>> hashing few weeks ago, and what they do is test these very hashing
>>> features. Again, prior to Vlad's rework those tests passed. So could
>>> you please take a look?
>>> 
>>> - Working on Sergey V.'s comments about current code.
>>> 
>>> - Alex
>>> 
>>> 
>>> 
>>> 
>> 
> 
> 

Re: Apache Ignite 1.8 Release

[Roman Shtykh]

Denis,
Any plans to add 1.8.0 in readme.io for new features?
-Roman
On Wednesday, November 16, 2016 6:08 AM, Denis Magda  
wrote:
 

 Igor,

It makes sense to wait for me while everything gets merged into 1.8 then. 
Please let me know over this discussion when the overall merge happens.

—
Denis

> On Nov 15, 2016, at 1:45 AM, Igor Sapego  wrote:
> 
> Denis,
> 
> I can merge PDO-related changes into 1.8 but without DML they will break tests
> and even compilation so I don't see any sense in doing that before DML is 
> merged.
> 
> After DML is ready and merged I'll need some time to merge my changes and 
> check
> that everything works as intended. The code itself, tests and examples are 
> ready.
> 
> 
> Best Regards,
> Igor
> 
> On Tue, Nov 15, 2016 at 11:31 AM, Pavel Tupitsyn  > wrote:
> Denis, [1] depends on [2], and [2](.NET: CacheEntryProcessor binary mode)
> is not a simple thing. We won't be able to do that for 1.8.
> Other than that, I'll try to fit as many of them as I can. But I can't
> answer your question since I don't see any date yet.
> 
> By the way, you were going to help with the reviews.
> 
> [1] https://issues.apache.org/jira/browse/IGNITE-4128 
> 
> [2] https://issues.apache.org/jira/browse/IGNITE-3825 
> 
> 
> On Tue, Nov 15, 2016 at 4:03 AM, Denis Magda  > wrote:
> 
> > *Alexander P., Igor S.,*
> >
> > When will your merge all DML and ODBC (PDO) related changes into 1.8
> > branch? I’m looking forward to go through PDO [1] documentation and be sure
> > that everything works as described on my side.
> >
> > *Pavel,*
> >
> > Do you think it will be possible to complete all the .NET usability
> > tickets [2] under 1.8 and roll them out to the Apache Ignite users?
> >
> > [1] https://issues.apache.org/jira/browse/IGNITE-3921 
> > 
> > [2] https://issues.apache.org/jira/browse/IGNITE-4114 
> > 
> >
> > —
> > Denis
> >
> > On Nov 9, 2016, at 6:55 AM, Denis Magda  > > wrote:
> >
> > Do we have a branch for ignite-1.8? Is there anyone who can take over the
> > release process of 1.8?
> >
> > —
> > Denis
> >
> > On Nov 8, 2016, at 9:01 PM, Alexander Paschenko <
> > alexander.a.pasche...@gmail.com > 
> > wrote:
> >
> > Current status on DML:
> >
> > - Basic data streamer support implemented (basicness is mostly about
> > configuration - say, currently there's no way to specify streamer's
> > batch size via JDBC driver, but this can be improved easily).
> >
> > - Fixed all minor stuff agreed with Vladimir.
> >
> > - There are some tests that started failing after binary hash codes
> > generation rework made by Vladimir in ignite-4011-1 branch, I will ask
> > him to look into it and fix those. Failing tests live in
> > GridCacheBinaryObjectsAbstractSelfTest, and are as follows:
> >    - testPutWithFieldsHashing
> >    - testCrossFormatObjectsIdentity
> >    - testPutWithCustomHashing
> > I added them personally during working on first version of auto
> > hashing few weeks ago, and what they do is test these very hashing
> > features. Again, prior to Vlad's rework those tests passed. So could
> > you please take a look?
> >
> > - Working on Sergey V.'s comments about current code.
> >
> > - Alex
> >
> >
> >
> >
> 


   

[jira] [Created] (IGNITE-4238) Example for spatial queries

[Denis Magda (JIRA)]

Denis Magda created IGNITE-4238:
---

 Summary: Example for spatial queries
 Key: IGNITE-4238
 URL: https://issues.apache.org/jira/browse/IGNITE-4238
 Project: Ignite
  Issue Type: Task
Reporter: Denis Magda
Assignee: Denis Magda
 Fix For: 1.8


The geospatial example is missing in Apache examples. It makes sense to add it.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

[Roman Shtykh]

Andrey, thank you!
Dmitriy, I will when we have 1.8.0 version on readme.io.
-Roman
 

On Wednesday, November 16, 2016 8:38 PM, Dmitriy Setrakyan 
 wrote:
 

 Roman, do you mind contributing the documentation for this feature?

On Wed, Nov 16, 2016 at 12:27 PM, Andrey Novikov 
wrote:

> Dmitriy,
>
> At this moment supported command can be found in ticket description:
> https://issues.apache.org/jira/browse/IGNITE-3066
> I think we shout add section for REDIS support on apacheignite.readme.io
> like for memcache
> Create ticket for documentation:
> https://issues.apache.org/jira/browse/IGNITE-4233


>
>
> On Wed, Nov 16, 2016 at 6:12 PM, Dmitriy Setrakyan 
> wrote:
>
> > Roman, thanks for the contribution! Is there a documentation where I can
> > read about the supported Redis commands?
> >
> > On Wed, Nov 16, 2016 at 12:09 PM, Andrey Novikov 
> > wrote:
> >
> > > Roman,
> > >
> > > I reviewed your PR. Changed it a little and merged to master.
> > > Thanks for your contribution!
> > >
> > > On Wed, Nov 16, 2016 at 9:39 AM, Roman Shtykh
>  > >
> > > wrote:
> > >
> > > > Andrey,
> > > > Sure, but I couldn't sign up -- "Cannot complete request due to
> license
> > > > limitations."Let's use github for now.
> > > > Thank you for your review!
> > > > -Roman
> > > >
> > > >
> > > >    On Tuesday, November 15, 2016 6:12 PM, Andrey Novikov <
> > > > anovi...@apache.org> wrote:
> > > >
> > > >
> > > >  Roman,
> > > >
> > > > I reviewed your code and added comments in JIRA.
> > > >
> > > > May we will try to use Upsource (http://reviews.ignite.apache.org/)
> > for
> > > > code
> > > > review?
> > > >
> > > >
> > > > On Tue, Nov 15, 2016 at 1:22 PM, Roman Shtykh
> >  > > >
> > > > wrote:
> > > >
> > > > > Alexey,
> > > > > Thank you for your thorough reviews! I fixed the issues.
> > > > > -Roman
> > > > >
> > > > >
> > > > >    On Tuesday, November 15, 2016 12:32 PM, Alexey Kuznetsov <
> > > > > akuznet...@apache.org> wrote:
> > > > >
> > > > >
> > > > >  Roman,
> > > > >
> > > > > I reviewed your code and now it looks good for me.
> > > > > But I added two minor comments in JIRA.
> > > > >
> > > > > Also I think Andrey Novikov should take a look, as he has some
> > > experience
> > > > > in ignite-rest module.
> > > > >
> > > > > Andrey, take a look:
> > > > >
> > > > > Issue: https://issues.apache.org/jira/browse/IGNITE-3066
> > > > > PR:  https://github.com/apache/ignite/pull/1212
> > > > >
> > > > >
> > > > > On Tue, Nov 15, 2016 at 9:27 AM, Roman Shtykh
> > >  > > > >
> > > > > wrote:
> > > > >
> > > > > > Alexey,
> > > > > > Thank you!I answered and pushed the changes.
> > > > > > -Roman
> > > > > >
> > > > > >
> > > > > >    On Tuesday, November 15, 2016 12:14 AM, Alexey Kuznetsov <
> > > > > > akuznet...@apache.org> wrote:
> > > > > >
> > > > > >
> > > > > >  Roman,
> > > > > >
> > > > > > I made one more review,  see my comments in JIRA issue.
> > > > > >
> > > > > > On Mon, Nov 7, 2016 at 1:30 PM, Alexey Kuznetsov <
> > > > akuznet...@apache.org>
> > > > > > wrote:
> > > > > >
> > > > > > > I will take a look on PR today.
> > > > > > >
> > > > > > > On Mon, Nov 7, 2016 at 11:35 AM, Roman Shtykh
> > > > >  > > > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > >>  Denis,
> > > > > > >> It is https://github.com/apache/ignite/pull/1212
> > > > > > >>
> > > > > > >> Thank you,
> > > > > > >> Roman
> > > > > > >>
> > > > > > >>
> > > > > > >>    On Saturday, November 5, 2016 4:56 AM, Denis Magda <
> > > > > > >> dma...@gridgain.com> wrote:
> > > > > > >>
> > > > > > >>
> > > > > > >>  Roman,
> > > > > > >>
> > > > > > >> Would you mind making a pull-request? It’s not clear and easy
> to
> > > > > review
> > > > > > >> using the branch you provided
> > > > > > >> https://github.com/apache/ignite/tree/ignite-2788 <
> > > > > > >> https://github.com/apache/ignite/tree/ignite-2788>
> > > > > > >>
> > > > > > >> This link provides details how to achieve this
> > > > > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > > > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request <
> > > > > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > > > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request>
> > > > > > >>
> > > > > > >> Let us know if you have any issue preparing the pull-request.
> > > > > > >>
> > > > > > >> —
> > > > > > >> Denis
> > > > > > >>
> > > > > > >> > On Nov 3, 2016, at 6:24 PM, Roman Shtykh
> > > >  > > > > >
> > > > > > >> wrote:
> > > > > > >> >
> > > > > > >> > Igniters,
> > > > > > >> > Please review the issue.https://issues.apache.or
> > > > > > >> g/jira/browse/IGNITE-3066
> > > > > > >> >
> > > > > > >> > Thank you,Roman
> > > > > > >>
> > > > > > >>
> > > > > > >>
> > > > > > >>
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Alexey Kuznetsov
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Alexey Kuznetsov
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
>

Re: IgniteCache.loadCache improvement proposal

[Valentin Kulichenko]

Alexandr,

'local' prefix in Ignite APIs means that the method is invoked only on the
current node, while its regular sibling is invoked in distributed fashion.
localLoadCache doesn't imply that only local partitions are loaded. it
turns out to work this way right now, but it doesn't mean that this can't
be change (and I don't suggest to change default behavior, BTW).

Method overhead is decreased with my approach, if used properly. You can
call localLoadCache with the data streamer based closure, and the database
will be queried only from local node, and the local node will then
distribute the data across other nodes. All I did is abstracted this logic
of moving an entry from store to cache, because currently user doesn't have
an option to override it.

If you still believe this doesn't work, can you please elaborate what
exactly you propose? What code should we add and/or change in Ignite and
how user will use it API wise?

-Val

On Wed, Nov 16, 2016 at 5:40 AM, Dmitriy Setrakyan 
wrote:

> On Wed, Nov 16, 2016 at 1:54 PM, Yakov Zhdanov 
> wrote:
>
> > > On Wed, Nov 16, 2016 at 11:22 AM, Yakov Zhdanov 
> > wrote:
> >
> > > > > Yakov, I agree that such scenario should be avoided. I also think
> > that
> >
> > > > > loadCache(...) method, as it is right now, provides a way to avoid
> > it.
> >
> > > >
> >
> > > > No, it does not.
> >
> > > >
> > > Yes it does :)
> >
> > No it doesn't. Load cache should either send a query to DB that filters
> all
> > the data on server side which, in turn, may result to full-scan of 2 Tb
> > data set dozens of times (equal to node count) or send a query that
> brings
> > the whole dataset to each node which is unacceptable as well.
> >
>
> Why not store the partition ID in the database and query only local
> partitions? Whatever approach we design with a DataStreamer will be slower
> than this.
>

Re: [VOTE] Use Upsource for Code Review

[Nikolai Tikhonov]

+1

On Wed, Nov 16, 2016 at 8:50 PM, Vladisav Jelisavcic 
wrote:

> +1 (non-binding)
>
> On Wed, Nov 16, 2016 at 6:15 PM, Denis Magda  wrote:
>
> > +1
> >
> > —
> > Denis
> >
> > > On Nov 16, 2016, at 2:08 AM, Pavel Tupitsyn 
> > wrote:
> > >
> > > Following the discussion on Upsource [1],
> > > I would like to call a vote on accepting it as our official code review
> > > tool.
> > >
> > > [ ] +1  approve
> > > [ ] +0  no opinion
> > > [ ] -1  disapprove (and reason why)
> > >
> > > This vote will go on for 5 days.
> > >
> > > [1] http://apache-ignite-developers.2346864.n4.nabble.
> > > com/Code-Review-Tool-Proposal-Upsource-td12195.html
> >
> >
>

[GitHub] ignite pull request #1240: ignite-3958

[ntikhonov]

GitHub user ntikhonov opened a pull request:

https://github.com/apache/ignite/pull/1240

ignite-3958



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-3958

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1240.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1240


commit 7290d88e14a15a3d030b7381dbd0a3f14cb65a12
Author: Pavel Tupitsyn 
Date:   2016-10-18T14:17:17Z

IGNITE-4030 Streamline PlatformTarget operation methods

This closes #1167

commit 66c76d1f30f024b58db8cab07ba9e7d429f596f8
Author: tledkov-gridgain 
Date:   2016-10-18T15:45:06Z

IGNITE-2355 Fixed the test HadoopClientProtocolMultipleServersSelfTest. 
Clear connection poll after the test, cosmetic.

commit f37fbcab1ae2c7553696e96b7a9c3194a570d7af
Author: isapego 
Date:   2016-10-19T10:06:42Z

IGNITE-3705: Fixed compiliation warnings. This closes #1169.

commit 7ed2bb7e341701d052220a36a2b2f8f0a46fd644
Author: AMRepo 
Date:   2016-10-19T15:33:59Z

IGNITE-3448 Support SQL queries with distinct aggregates added. This closes 
#3448.

commit 551a4dfae6169a07a5e28f9b266f90311f3216b7
Author: tledkov-gridgain 
Date:   2016-10-21T10:25:57Z

IGNITE-2355 Fixed the test HadoopClientProtocolMultipleServersSelfTest. 
Clear connection poll before and after  the test

commit ec12a9db2265180f96be72e2217e60ced856164e
Author: vozerov-gridgain 
Date:   2016-10-24T14:52:36Z

Minor fix for flags passed to GridCacheMapEntry.initialValue from data 
streamer isolated updater.

commit 44740465677c39068dc813dabd464e60f09e5f49
Author: tledkov-gridgain 
Date:   2016-10-26T13:00:11Z

IGNITE-4062: fix BinaryObject.equals: compare only bytes containing the 
fields' data (without header and footer). This closes  #1182.

commit 9ddb8be1243df8e489f7ebc716d315415775439a
Author: Dmitriy Govorukhin 
Date:   2016-10-27T14:52:22Z

IGNITE-2079 GridCacheIoManager eats exception trail if it falls into the 
directed case
merger from ignite-2079-2

# Conflicts:
#   
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryMetricsAdapter.java

commit 6f160728c544d252f77bdb85c0ff2857559707a3
Author: Valentin Kulichenko 
Date:   2016-10-28T23:18:14Z

IGNITE-4110 - Fixed BUFFER_UNDERFLOW and BUFFER_OVERFLOW handling in 
BlockingSslHandler

commit 6b78ad0cbbcf286cb083136c49cebd5dd85de58c
Author: sboikov 
Date:   2016-10-31T07:35:44Z

TcoDiscovery: reduced amount of debug logging (heartbeat/connection check 
messages are logged trace level).

commit 175da6b7e394dd76c27d5155ff98a5b2ef03bb9d
Author: tledkov-gridgain 
Date:   2016-11-07T06:16:58Z

IGNITE-3432:  check data/meta cache names are different for different IGFS 
instances. This closes #1201

commit 40ef2f5ae42826fe8fd077e3013e8f55c8512bdd
Author: Dmitriy Govorukhin 
Date:   2016-11-07T09:09:41Z

ignite-4178 support permission builder

commit fc7ce5a4d72145f2e8a86debeda264ef0a5b37e3
Author: isapego 
Date:   2016-11-07T10:26:05Z

IGNITE-4090: Added flags so stdint and limits can be used in C++.

commit a98804a249496ba9bafbc96daa7aaf25b3d36724
Author: Igor Sapego 
Date:   2016-11-07T11:00:00Z

IGNITE-4113: Added tests. Added Statement::Set/GetAttribute.

commit 950bad474ef29f9b808e74034c49a69d57eb2740
Author: dkarachentsev 
Date:   2016-11-08T11:03:34Z

GG-11655 - Restore service compatibility with releases before 1.5.30.

commit 3d19bfc2b66574e3945ce17c7a4dfe77d0070b8d
Author: dkarachentsev 
Date:   2016-11-08T11:04:36Z

Merge remote-tracking branch 'origin/ignite-1.6.11' into ignite-1.6.11

commit e821dc0083003bc81058b1cb223d8a8a2ee44daf
Author: Dmitriy Govorukhin 
Date:   2016-11-08T12:09:21Z

IGNITE-2079 (revert commit) GridCacheIoManager eats exception trail if it 
falls into the directed case

commit c2c82ca44befe4570325dd6cf2ba885e0d90596c
Author: Dmitriy Govorukhin 
Date:   2016-11-08T12:10:10Z

Merge remote-tracking branch 'professional/ignite-1.6.11' into ignite-1.6.11

commit 865bbcf0f41a0c4944e0928f1758d43a0eae82c5
Author: Dmitriy Govorukhin 
Date:   2016-11-08T12:18:29Z

Revert "Merge remote-tracking branch 'professional/ignite-1.6.11' into 
ignite-1.6.11"

This reverts commit c2c82ca44befe4570325dd6cf2ba885e0d90596c, reversing
changes made to e821dc0083003bc81058b1cb223d8a8a2ee44daf.

commit 9726421ff9efb2b19813b2fd6ad27a3728b5ab1a
Author: Dmitriy Govorukhin 
Date:   2016-11-08T12:59:00Z

  Revert  Revert  Merge remote-tracking branch 'professional/ignite-1.6.11'

commit 5a3a1960fff1dcf32961c45c0ba5149d6748d2fc
Author: Igor Sapego 
Date:   2016-11-08T14:36:35Z

Added license header.

commit d88f422aeb02738d676d86ce416551b805ad154e
Author: Andrey Novikov 
Date:   2016-11-09T07:25:38Z

GG-11028 Fixed resolving 

Re: [VOTE] Use Upsource for Code Review

[Vladisav Jelisavcic]

+1 (non-binding)

On Wed, Nov 16, 2016 at 6:15 PM, Denis Magda  wrote:

> +1
>
> —
> Denis
>
> > On Nov 16, 2016, at 2:08 AM, Pavel Tupitsyn 
> wrote:
> >
> > Following the discussion on Upsource [1],
> > I would like to call a vote on accepting it as our official code review
> > tool.
> >
> > [ ] +1  approve
> > [ ] +0  no opinion
> > [ ] -1  disapprove (and reason why)
> >
> > This vote will go on for 5 days.
> >
> > [1] http://apache-ignite-developers.2346864.n4.nabble.
> > com/Code-Review-Tool-Proposal-Upsource-td12195.html
>
>

Re: [VOTE] Use Upsource for Code Review

[Denis Magda]

+1

—
Denis

> On Nov 16, 2016, at 2:08 AM, Pavel Tupitsyn  wrote:
> 
> Following the discussion on Upsource [1],
> I would like to call a vote on accepting it as our official code review
> tool.
> 
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
> 
> This vote will go on for 5 days.
> 
> [1] http://apache-ignite-developers.2346864.n4.nabble.
> com/Code-Review-Tool-Proposal-Upsource-td12195.html

Re: [VOTE] Use Upsource for Code Review

[Sergi Vladykin]

+1

Ok, this makes sense.

Sergi

2016-11-16 14:33 GMT+03:00 Dmitriy Setrakyan :

> +1
>
> I think we should allow this tool, unless it proves counter productive. If
> it does, then we will drop it.
>
> On Wed, Nov 16, 2016 at 11:44 AM, Pavel Tupitsyn 
> wrote:
>
> > Sergi,
> >
> > I don't think we should enforce it.
> > "Official" means that it will be allowed, linked and described in wiki.
> >
> > It is up to contributor and reviewer to use it.
> > For example, if the changes are small/trivial, creating a review in
> > Upsource is not necessary.
> > If the changes are complex and contributor has not created a review,
> > reviewer may ask to do so.
> > Etc etc.
> >
> > Thoughts?
> >
> > On Wed, Nov 16, 2016 at 1:31 PM, Sergi Vladykin <
> sergi.vlady...@gmail.com>
> > wrote:
> >
> > > Pavel,
> > >
> > > I'm not sure I understand the term "official code review tool", can you
> > > please elaborate it? We will enforce everyone to register in Upsource
> and
> > > use it or what?
> > >
> > > Sergi
> > >
> > > 2016-11-16 13:22 GMT+03:00 Pavel Tupitsyn :
> > >
> > > > Proper link to the discussion:
> > > > http://apache-ignite-developers.2346864.n4.nabble.com/
> > > > Code-Review-Tool-Proposal-Upsource-td12195.html
> > > >
> > > > On Wed, Nov 16, 2016 at 1:16 PM, Anton Vinogradov 
> > wrote:
> > > >
> > > > > +1
> > > > >
> > > > > On Wed, Nov 16, 2016 at 1:08 PM, Pavel Tupitsyn <
> > ptupit...@apache.org>
> > > > > wrote:
> > > > >
> > > > > > Following the discussion on Upsource [1],
> > > > > > I would like to call a vote on accepting it as our official code
> > > review
> > > > > > tool.
> > > > > >
> > > > > > [ ] +1  approve
> > > > > > [ ] +0  no opinion
> > > > > > [ ] -1  disapprove (and reason why)
> > > > > >
> > > > > > This vote will go on for 5 days.
> > > > > >
> > > > > > [1] http://apache-ignite-developers.2346864.n4.nabble.
> > > > > > com/Code-Review-Tool-Proposal-Upsource-td12195.html
> > > > > >
> > > > >
> > > >
> > >
> >
>

[GitHub] ignite pull request #1239: IGNITE-4234 .NET: Propagate missing CacheMetrics ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/1239


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] ignite pull request #1239: IGNITE-4234 .NET: Propagate missing CacheMetrics ...

[ptupitsyn]

GitHub user ptupitsyn opened a pull request:

https://github.com/apache/ignite/pull/1239

IGNITE-4234 .NET: Propagate missing CacheMetrics properties



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ptupitsyn/ignite ignite-4234

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1239.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1239


commit 74cc4590a0443fc8b9db076df9221b966bf9d4e9
Author: Pavel Tupitsyn 
Date:   2016-11-16T13:12:28Z

IGNITE-4234 .NET: Propagate missing CacheMetrics properties - update 
interface

commit cc914c56f65d18679ba2756d550c17b7d8d58701
Author: Pavel Tupitsyn 
Date:   2016-11-16T13:21:50Z

Update class

commit 3f7b2797afc6b11fe27d26722f6169c49662383a
Author: Pavel Tupitsyn 
Date:   2016-11-16T13:27:19Z

wip

commit 976d000cc3595b8cce0bad2a45cbcbbf62daac2f
Author: Pavel Tupitsyn 
Date:   2016-11-16T13:27:34Z

wip

commit 94d831664a5c78c424afee0383da4d55961f30da
Author: Pavel Tupitsyn 
Date:   2016-11-16T13:56:34Z

Update writer

commit a1ef83c649237da4530b1a6b7cd4a0847b025496
Author: Pavel Tupitsyn 
Date:   2016-11-16T13:57:35Z

wip

commit d01c6ee10bf8b10c14826729f7e0b953c822c41b
Author: Pavel Tupitsyn 
Date:   2016-11-16T14:04:13Z

Update tests

commit 3fe906080b3d21cd2a8c8822b2f3d0d299cab0c6
Author: Pavel Tupitsyn 
Date:   2016-11-16T14:14:06Z

Add metrics test task

commit 9be706162c9c194a27027de493402393bb6df815
Author: Pavel Tupitsyn 
Date:   2016-11-16T14:16:32Z

Adding test

commit f578f775d95c469aa381a5fe8e423eb3a3144aab
Author: Pavel Tupitsyn 
Date:   2016-11-16T14:31:41Z

wip

commit 6b469620702a9deff481f07c0bce17d7667b48ca
Author: Pavel Tupitsyn 
Date:   2016-11-16T14:39:15Z

test done




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: IgniteCache.loadCache improvement proposal

[Dmitriy Setrakyan]

On Wed, Nov 16, 2016 at 1:54 PM, Yakov Zhdanov  wrote:

> > On Wed, Nov 16, 2016 at 11:22 AM, Yakov Zhdanov 
> wrote:
>
> > > > Yakov, I agree that such scenario should be avoided. I also think
> that
>
> > > > loadCache(...) method, as it is right now, provides a way to avoid
> it.
>
> > >
>
> > > No, it does not.
>
> > >
> > Yes it does :)
>
> No it doesn't. Load cache should either send a query to DB that filters all
> the data on server side which, in turn, may result to full-scan of 2 Tb
> data set dozens of times (equal to node count) or send a query that brings
> the whole dataset to each node which is unacceptable as well.
>

Why not store the partition ID in the database and query only local
partitions? Whatever approach we design with a DataStreamer will be slower
than this.

[jira] [Created] (IGNITE-4237) Implement interface to local Ignite instance over IPC

[Vladimir Ozerov (JIRA)]

Vladimir Ozerov created IGNITE-4237:
---

 Summary: Implement interface to local Ignite instance over IPC
 Key: IGNITE-4237
 URL: https://issues.apache.org/jira/browse/IGNITE-4237
 Project: Ignite
  Issue Type: Task
  Components: general
Affects Versions: 1.8
Reporter: Vladimir Ozerov
 Fix For: 2.0


This way we can cover some important cases:
1) User has short-lived processes which require access to Ignite.
2) User do not want or cannot have JVM in the same process.

No failover is needed here at all.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: IgniteCache.loadCache improvement proposal

[Yakov Zhdanov]

> On Wed, Nov 16, 2016 at 11:22 AM, Yakov Zhdanov 
wrote:

> > > Yakov, I agree that such scenario should be avoided. I also think that

> > > loadCache(...) method, as it is right now, provides a way to avoid it.

> >

> > No, it does not.

> >
> Yes it does :)

No it doesn't. Load cache should either send a query to DB that filters all
the data on server side which, in turn, may result to full-scan of 2 Tb
data set dozens of times (equal to node count) or send a query that brings
the whole dataset to each node which is unacceptable as well.

--Yakov

[jira] [Created] (IGNITE-4236) .NET: ICache.LocalMetrics and overloads

[Pavel Tupitsyn (JIRA)]

Pavel Tupitsyn created IGNITE-4236:
--

 Summary: .NET: ICache.LocalMetrics and overloads
 Key: IGNITE-4236
 URL: https://issues.apache.org/jira/browse/IGNITE-4236
 Project: Ignite
  Issue Type: Improvement
  Components: platforms
Reporter: Pavel Tupitsyn
 Fix For: 1.8


Ignite in Java has three cache metrics methods:
{code}
CacheMetrics metrics();
CacheMetrics metrics(ClusterGroup grp);
CacheMetrics localMetrics();
{code}

Ignite.NET should provide these too. See how IGNITE-1071 changed the meaning of 
methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (IGNITE-4235) Can't get user exception if was on remote service

[Dmitriy Govorukhin (JIRA)]

Dmitriy Govorukhin created IGNITE-4235:
--

 Summary: Can't get user exception if was on remote service
 Key: IGNITE-4235
 URL: https://issues.apache.org/jira/browse/IGNITE-4235
 Project: Ignite
  Issue Type: Bug
  Components: general
Affects Versions: 1.7
Reporter: Dmitriy Govorukhin
 Fix For: 2.0


Can get user exception if was on remote node. Reproducer in attached file .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] ignite pull request #1238: Ignite 4231 Fix hangs on compute result serializa...

[dkarachentsev]

GitHub user dkarachentsev opened a pull request:

https://github.com/apache/ignite/pull/1238

Ignite 4231 Fix hangs on compute result serialization error



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-4231

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1238.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1238


commit 37f22893e4aaf7f398928b95575a64b6280ab635
Author: tledkov-gridgain 
Date:   2016-08-10T09:21:13Z

Merge remote-tracking branch 'remotes/community/ignite-1.7.2'

commit a519c22cff94c8dfda23f8aa52ae0452f6eee260
Author: dkarachentsev 
Date:   2016-08-25T10:38:53Z

Merge branch 'master' of https://github.com/gridgain/apache-ignite

commit ca1381facd9a83b723fbeaed85a76672b05e5d25
Author: EdShangGG 
Date:   2016-08-30T11:53:46Z

Merge remote-tracking branch 'ignite-gg/ignite-1.7.2' into gg-master

commit ce94df568d278105f9132ab1a02b666ffcddacf5
Author: dkarachentsev 
Date:   2016-08-31T12:57:45Z

Merge branch 'master' of https://github.com/gridgain/apache-ignite

commit 1c8ac3161cf4474086ce6b66e0b0ac296f7a0ae4
Author: dkarachentsev 
Date:   2016-09-09T13:18:28Z

Merge branch 'master' of https://github.com/gridgain/apache-ignite

commit dd5db4669ecba81e1f4d9592e264175cb5f3616a
Author: dkarachentsev 
Date:   2016-09-12T07:54:20Z

Merge branch 'ignite-1.7.2'

commit c115bfefc1bc9294c8e61b7ee7932d92ec0661d8
Author: dkarachentsev 
Date:   2016-09-14T12:01:54Z

Merge branch 'master' of https://github.com/gridgain/apache-ignite

commit 7d50cd6f166c2d2ee77b7de150f1b2547f6efb63
Author: dkarachentsev 
Date:   2016-09-23T07:45:36Z

Merge branch 'master' of https://github.com/gridgain/apache-ignite

commit 720cf4a5d3fedc8c849e3a5c531f6a6f3d3d
Author: dkarachentsev 
Date:   2016-11-14T14:23:57Z

Merge branch 'master' of https://github.com/gridgain/apache-ignite

commit 26307551cc5412a4d6b82e11dee64a1f23192c71
Author: dkarachentsev 
Date:   2016-11-16T12:08:20Z

IGNITE-4231 - Hangs on compute result serialization error




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (IGNITE-4234) .NET: Propagate missing CacheMetrics properties

[Pavel Tupitsyn (JIRA)]

Pavel Tupitsyn created IGNITE-4234:
--

 Summary: .NET: Propagate missing CacheMetrics properties
 Key: IGNITE-4234
 URL: https://issues.apache.org/jira/browse/IGNITE-4234
 Project: Ignite
  Issue Type: Improvement
  Components: platforms
Reporter: Pavel Tupitsyn
Assignee: Pavel Tupitsyn
 Fix For: 1.8


CacheMetrics in Java has a lot more properties than ICacheMetrics in .NET



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: IgniteCache.loadCache improvement proposal

[Dmitriy Setrakyan]

On Wed, Nov 16, 2016 at 11:22 AM, Yakov Zhdanov  wrote:

> > Yakov, I agree that such scenario should be avoided. I also think that
> > loadCache(...) method, as it is right now, provides a way to avoid it.
>
> No, it does not.
>

Yes it does :)

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

[Dmitriy Setrakyan]

Roman, do you mind contributing the documentation for this feature?

On Wed, Nov 16, 2016 at 12:27 PM, Andrey Novikov 
wrote:

> Dmitriy,
>
> At this moment supported command can be found in ticket description:
> https://issues.apache.org/jira/browse/IGNITE-3066
> I think we shout add section for REDIS support on apacheignite.readme.io
> like for memcache
> Create ticket for documentation:
> https://issues.apache.org/jira/browse/IGNITE-4233


>
>
> On Wed, Nov 16, 2016 at 6:12 PM, Dmitriy Setrakyan 
> wrote:
>
> > Roman, thanks for the contribution! Is there a documentation where I can
> > read about the supported Redis commands?
> >
> > On Wed, Nov 16, 2016 at 12:09 PM, Andrey Novikov 
> > wrote:
> >
> > > Roman,
> > >
> > > I reviewed your PR. Changed it a little and merged to master.
> > > Thanks for your contribution!
> > >
> > > On Wed, Nov 16, 2016 at 9:39 AM, Roman Shtykh
>  > >
> > > wrote:
> > >
> > > > Andrey,
> > > > Sure, but I couldn't sign up -- "Cannot complete request due to
> license
> > > > limitations."Let's use github for now.
> > > > Thank you for your review!
> > > > -Roman
> > > >
> > > >
> > > > On Tuesday, November 15, 2016 6:12 PM, Andrey Novikov <
> > > > anovi...@apache.org> wrote:
> > > >
> > > >
> > > >  Roman,
> > > >
> > > > I reviewed your code and added comments in JIRA.
> > > >
> > > > May we will try to use Upsource (http://reviews.ignite.apache.org/)
> > for
> > > > code
> > > > review?
> > > >
> > > >
> > > > On Tue, Nov 15, 2016 at 1:22 PM, Roman Shtykh
> >  > > >
> > > > wrote:
> > > >
> > > > > Alexey,
> > > > > Thank you for your thorough reviews! I fixed the issues.
> > > > > -Roman
> > > > >
> > > > >
> > > > >On Tuesday, November 15, 2016 12:32 PM, Alexey Kuznetsov <
> > > > > akuznet...@apache.org> wrote:
> > > > >
> > > > >
> > > > >  Roman,
> > > > >
> > > > > I reviewed your code and now it looks good for me.
> > > > > But I added two minor comments in JIRA.
> > > > >
> > > > > Also I think Andrey Novikov should take a look, as he has some
> > > experience
> > > > > in ignite-rest module.
> > > > >
> > > > > Andrey, take a look:
> > > > >
> > > > > Issue: https://issues.apache.org/jira/browse/IGNITE-3066
> > > > > PR:  https://github.com/apache/ignite/pull/1212
> > > > >
> > > > >
> > > > > On Tue, Nov 15, 2016 at 9:27 AM, Roman Shtykh
> > >  > > > >
> > > > > wrote:
> > > > >
> > > > > > Alexey,
> > > > > > Thank you!I answered and pushed the changes.
> > > > > > -Roman
> > > > > >
> > > > > >
> > > > > >On Tuesday, November 15, 2016 12:14 AM, Alexey Kuznetsov <
> > > > > > akuznet...@apache.org> wrote:
> > > > > >
> > > > > >
> > > > > >  Roman,
> > > > > >
> > > > > > I made one more review,  see my comments in JIRA issue.
> > > > > >
> > > > > > On Mon, Nov 7, 2016 at 1:30 PM, Alexey Kuznetsov <
> > > > akuznet...@apache.org>
> > > > > > wrote:
> > > > > >
> > > > > > > I will take a look on PR today.
> > > > > > >
> > > > > > > On Mon, Nov 7, 2016 at 11:35 AM, Roman Shtykh
> > > > >  > > > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > >>  Denis,
> > > > > > >> It is https://github.com/apache/ignite/pull/1212
> > > > > > >>
> > > > > > >> Thank you,
> > > > > > >> Roman
> > > > > > >>
> > > > > > >>
> > > > > > >>On Saturday, November 5, 2016 4:56 AM, Denis Magda <
> > > > > > >> dma...@gridgain.com> wrote:
> > > > > > >>
> > > > > > >>
> > > > > > >>  Roman,
> > > > > > >>
> > > > > > >> Would you mind making a pull-request? It’s not clear and easy
> to
> > > > > review
> > > > > > >> using the branch you provided
> > > > > > >> https://github.com/apache/ignite/tree/ignite-2788 <
> > > > > > >> https://github.com/apache/ignite/tree/ignite-2788>
> > > > > > >>
> > > > > > >> This link provides details how to achieve this
> > > > > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > > > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request <
> > > > > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > > > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request>
> > > > > > >>
> > > > > > >> Let us know if you have any issue preparing the pull-request.
> > > > > > >>
> > > > > > >> —
> > > > > > >> Denis
> > > > > > >>
> > > > > > >> > On Nov 3, 2016, at 6:24 PM, Roman Shtykh
> > > >  > > > > >
> > > > > > >> wrote:
> > > > > > >> >
> > > > > > >> > Igniters,
> > > > > > >> > Please review the issue.https://issues.apache.or
> > > > > > >> g/jira/browse/IGNITE-3066
> > > > > > >> >
> > > > > > >> > Thank you,Roman
> > > > > > >>
> > > > > > >>
> > > > > > >>
> > > > > > >>
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Alexey Kuznetsov
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Alexey Kuznetsov
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Alexey Kuznetsov
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > >
> >
>

Re: [VOTE] Use Upsource for Code Review

[Dmitriy Setrakyan]

+1

I think we should allow this tool, unless it proves counter productive. If
it does, then we will drop it.

On Wed, Nov 16, 2016 at 11:44 AM, Pavel Tupitsyn 
wrote:

> Sergi,
>
> I don't think we should enforce it.
> "Official" means that it will be allowed, linked and described in wiki.
>
> It is up to contributor and reviewer to use it.
> For example, if the changes are small/trivial, creating a review in
> Upsource is not necessary.
> If the changes are complex and contributor has not created a review,
> reviewer may ask to do so.
> Etc etc.
>
> Thoughts?
>
> On Wed, Nov 16, 2016 at 1:31 PM, Sergi Vladykin 
> wrote:
>
> > Pavel,
> >
> > I'm not sure I understand the term "official code review tool", can you
> > please elaborate it? We will enforce everyone to register in Upsource and
> > use it or what?
> >
> > Sergi
> >
> > 2016-11-16 13:22 GMT+03:00 Pavel Tupitsyn :
> >
> > > Proper link to the discussion:
> > > http://apache-ignite-developers.2346864.n4.nabble.com/
> > > Code-Review-Tool-Proposal-Upsource-td12195.html
> > >
> > > On Wed, Nov 16, 2016 at 1:16 PM, Anton Vinogradov 
> wrote:
> > >
> > > > +1
> > > >
> > > > On Wed, Nov 16, 2016 at 1:08 PM, Pavel Tupitsyn <
> ptupit...@apache.org>
> > > > wrote:
> > > >
> > > > > Following the discussion on Upsource [1],
> > > > > I would like to call a vote on accepting it as our official code
> > review
> > > > > tool.
> > > > >
> > > > > [ ] +1  approve
> > > > > [ ] +0  no opinion
> > > > > [ ] -1  disapprove (and reason why)
> > > > >
> > > > > This vote will go on for 5 days.
> > > > >
> > > > > [1] http://apache-ignite-developers.2346864.n4.nabble.
> > > > > com/Code-Review-Tool-Proposal-Upsource-td12195.html
> > > > >
> > > >
> > >
> >
>

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

[Andrey Novikov]

Dmitriy,

At this moment supported command can be found in ticket description:
https://issues.apache.org/jira/browse/IGNITE-3066
I think we shout add section for REDIS support on apacheignite.readme.io
like for memcache
Create ticket for documentation:
https://issues.apache.org/jira/browse/IGNITE-4233


On Wed, Nov 16, 2016 at 6:12 PM, Dmitriy Setrakyan 
wrote:

> Roman, thanks for the contribution! Is there a documentation where I can
> read about the supported Redis commands?
>
> On Wed, Nov 16, 2016 at 12:09 PM, Andrey Novikov 
> wrote:
>
> > Roman,
> >
> > I reviewed your PR. Changed it a little and merged to master.
> > Thanks for your contribution!
> >
> > On Wed, Nov 16, 2016 at 9:39 AM, Roman Shtykh  >
> > wrote:
> >
> > > Andrey,
> > > Sure, but I couldn't sign up -- "Cannot complete request due to license
> > > limitations."Let's use github for now.
> > > Thank you for your review!
> > > -Roman
> > >
> > >
> > > On Tuesday, November 15, 2016 6:12 PM, Andrey Novikov <
> > > anovi...@apache.org> wrote:
> > >
> > >
> > >  Roman,
> > >
> > > I reviewed your code and added comments in JIRA.
> > >
> > > May we will try to use Upsource (http://reviews.ignite.apache.org/)
> for
> > > code
> > > review?
> > >
> > >
> > > On Tue, Nov 15, 2016 at 1:22 PM, Roman Shtykh
>  > >
> > > wrote:
> > >
> > > > Alexey,
> > > > Thank you for your thorough reviews! I fixed the issues.
> > > > -Roman
> > > >
> > > >
> > > >On Tuesday, November 15, 2016 12:32 PM, Alexey Kuznetsov <
> > > > akuznet...@apache.org> wrote:
> > > >
> > > >
> > > >  Roman,
> > > >
> > > > I reviewed your code and now it looks good for me.
> > > > But I added two minor comments in JIRA.
> > > >
> > > > Also I think Andrey Novikov should take a look, as he has some
> > experience
> > > > in ignite-rest module.
> > > >
> > > > Andrey, take a look:
> > > >
> > > > Issue: https://issues.apache.org/jira/browse/IGNITE-3066
> > > > PR:  https://github.com/apache/ignite/pull/1212
> > > >
> > > >
> > > > On Tue, Nov 15, 2016 at 9:27 AM, Roman Shtykh
> >  > > >
> > > > wrote:
> > > >
> > > > > Alexey,
> > > > > Thank you!I answered and pushed the changes.
> > > > > -Roman
> > > > >
> > > > >
> > > > >On Tuesday, November 15, 2016 12:14 AM, Alexey Kuznetsov <
> > > > > akuznet...@apache.org> wrote:
> > > > >
> > > > >
> > > > >  Roman,
> > > > >
> > > > > I made one more review,  see my comments in JIRA issue.
> > > > >
> > > > > On Mon, Nov 7, 2016 at 1:30 PM, Alexey Kuznetsov <
> > > akuznet...@apache.org>
> > > > > wrote:
> > > > >
> > > > > > I will take a look on PR today.
> > > > > >
> > > > > > On Mon, Nov 7, 2016 at 11:35 AM, Roman Shtykh
> > > >  > > > > >
> > > > > > wrote:
> > > > > >
> > > > > >>  Denis,
> > > > > >> It is https://github.com/apache/ignite/pull/1212
> > > > > >>
> > > > > >> Thank you,
> > > > > >> Roman
> > > > > >>
> > > > > >>
> > > > > >>On Saturday, November 5, 2016 4:56 AM, Denis Magda <
> > > > > >> dma...@gridgain.com> wrote:
> > > > > >>
> > > > > >>
> > > > > >>  Roman,
> > > > > >>
> > > > > >> Would you mind making a pull-request? It’s not clear and easy to
> > > > review
> > > > > >> using the branch you provided
> > > > > >> https://github.com/apache/ignite/tree/ignite-2788 <
> > > > > >> https://github.com/apache/ignite/tree/ignite-2788>
> > > > > >>
> > > > > >> This link provides details how to achieve this
> > > > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request <
> > > > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request>
> > > > > >>
> > > > > >> Let us know if you have any issue preparing the pull-request.
> > > > > >>
> > > > > >> —
> > > > > >> Denis
> > > > > >>
> > > > > >> > On Nov 3, 2016, at 6:24 PM, Roman Shtykh
> > >  > > > >
> > > > > >> wrote:
> > > > > >> >
> > > > > >> > Igniters,
> > > > > >> > Please review the issue.https://issues.apache.or
> > > > > >> g/jira/browse/IGNITE-3066
> > > > > >> >
> > > > > >> > Thank you,Roman
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Alexey Kuznetsov
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Alexey Kuznetsov
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Alexey Kuznetsov
> > > >
> > > >
> > > >
> > >
> > >
> > >
> >
>

[jira] [Created] (IGNITE-4233) Add documentation for REDIS support

[Andrey Novikov (JIRA)]

Andrey Novikov created IGNITE-4233:
--

 Summary: Add documentation for REDIS support
 Key: IGNITE-4233
 URL: https://issues.apache.org/jira/browse/IGNITE-4233
 Project: Ignite
  Issue Type: Sub-task
Affects Versions: 1.8
Reporter: Andrey Novikov
 Fix For: 1.8






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [VOTE] Use Upsource for Code Review

[Vladimir Ozerov]

+1

Way to go!

On Wed, Nov 16, 2016 at 2:19 PM, Andrey Gura  wrote:

> +1
>
>
>
> On Wed, Nov 16, 2016 at 1:44 PM, Pavel Tupitsyn 
> wrote:
>
> > Sergi,
> >
> > I don't think we should enforce it.
> > "Official" means that it will be allowed, linked and described in wiki.
> >
> > It is up to contributor and reviewer to use it.
> > For example, if the changes are small/trivial, creating a review in
> > Upsource is not necessary.
> > If the changes are complex and contributor has not created a review,
> > reviewer may ask to do so.
> > Etc etc.
> >
> > Thoughts?
> >
> > On Wed, Nov 16, 2016 at 1:31 PM, Sergi Vladykin <
> sergi.vlady...@gmail.com>
> > wrote:
> >
> > > Pavel,
> > >
> > > I'm not sure I understand the term "official code review tool", can you
> > > please elaborate it? We will enforce everyone to register in Upsource
> and
> > > use it or what?
> > >
> > > Sergi
> > >
> > > 2016-11-16 13:22 GMT+03:00 Pavel Tupitsyn :
> > >
> > > > Proper link to the discussion:
> > > > http://apache-ignite-developers.2346864.n4.nabble.com/
> > > > Code-Review-Tool-Proposal-Upsource-td12195.html
> > > >
> > > > On Wed, Nov 16, 2016 at 1:16 PM, Anton Vinogradov 
> > wrote:
> > > >
> > > > > +1
> > > > >
> > > > > On Wed, Nov 16, 2016 at 1:08 PM, Pavel Tupitsyn <
> > ptupit...@apache.org>
> > > > > wrote:
> > > > >
> > > > > > Following the discussion on Upsource [1],
> > > > > > I would like to call a vote on accepting it as our official code
> > > review
> > > > > > tool.
> > > > > >
> > > > > > [ ] +1  approve
> > > > > > [ ] +0  no opinion
> > > > > > [ ] -1  disapprove (and reason why)
> > > > > >
> > > > > > This vote will go on for 5 days.
> > > > > >
> > > > > > [1] http://apache-ignite-developers.2346864.n4.nabble.
> > > > > > com/Code-Review-Tool-Proposal-Upsource-td12195.html
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: [VOTE] Use Upsource for Code Review

[Andrey Gura]

+1



On Wed, Nov 16, 2016 at 1:44 PM, Pavel Tupitsyn 
wrote:

> Sergi,
>
> I don't think we should enforce it.
> "Official" means that it will be allowed, linked and described in wiki.
>
> It is up to contributor and reviewer to use it.
> For example, if the changes are small/trivial, creating a review in
> Upsource is not necessary.
> If the changes are complex and contributor has not created a review,
> reviewer may ask to do so.
> Etc etc.
>
> Thoughts?
>
> On Wed, Nov 16, 2016 at 1:31 PM, Sergi Vladykin 
> wrote:
>
> > Pavel,
> >
> > I'm not sure I understand the term "official code review tool", can you
> > please elaborate it? We will enforce everyone to register in Upsource and
> > use it or what?
> >
> > Sergi
> >
> > 2016-11-16 13:22 GMT+03:00 Pavel Tupitsyn :
> >
> > > Proper link to the discussion:
> > > http://apache-ignite-developers.2346864.n4.nabble.com/
> > > Code-Review-Tool-Proposal-Upsource-td12195.html
> > >
> > > On Wed, Nov 16, 2016 at 1:16 PM, Anton Vinogradov 
> wrote:
> > >
> > > > +1
> > > >
> > > > On Wed, Nov 16, 2016 at 1:08 PM, Pavel Tupitsyn <
> ptupit...@apache.org>
> > > > wrote:
> > > >
> > > > > Following the discussion on Upsource [1],
> > > > > I would like to call a vote on accepting it as our official code
> > review
> > > > > tool.
> > > > >
> > > > > [ ] +1  approve
> > > > > [ ] +0  no opinion
> > > > > [ ] -1  disapprove (and reason why)
> > > > >
> > > > > This vote will go on for 5 days.
> > > > >
> > > > > [1] http://apache-ignite-developers.2346864.n4.nabble.
> > > > > com/Code-Review-Tool-Proposal-Upsource-td12195.html
> > > > >
> > > >
> > >
> >
>

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

[Dmitriy Setrakyan]

Roman, thanks for the contribution! Is there a documentation where I can
read about the supported Redis commands?

On Wed, Nov 16, 2016 at 12:09 PM, Andrey Novikov 
wrote:

> Roman,
>
> I reviewed your PR. Changed it a little and merged to master.
> Thanks for your contribution!
>
> On Wed, Nov 16, 2016 at 9:39 AM, Roman Shtykh 
> wrote:
>
> > Andrey,
> > Sure, but I couldn't sign up -- "Cannot complete request due to license
> > limitations."Let's use github for now.
> > Thank you for your review!
> > -Roman
> >
> >
> > On Tuesday, November 15, 2016 6:12 PM, Andrey Novikov <
> > anovi...@apache.org> wrote:
> >
> >
> >  Roman,
> >
> > I reviewed your code and added comments in JIRA.
> >
> > May we will try to use Upsource (http://reviews.ignite.apache.org/) for
> > code
> > review?
> >
> >
> > On Tue, Nov 15, 2016 at 1:22 PM, Roman Shtykh  >
> > wrote:
> >
> > > Alexey,
> > > Thank you for your thorough reviews! I fixed the issues.
> > > -Roman
> > >
> > >
> > >On Tuesday, November 15, 2016 12:32 PM, Alexey Kuznetsov <
> > > akuznet...@apache.org> wrote:
> > >
> > >
> > >  Roman,
> > >
> > > I reviewed your code and now it looks good for me.
> > > But I added two minor comments in JIRA.
> > >
> > > Also I think Andrey Novikov should take a look, as he has some
> experience
> > > in ignite-rest module.
> > >
> > > Andrey, take a look:
> > >
> > > Issue: https://issues.apache.org/jira/browse/IGNITE-3066
> > > PR:  https://github.com/apache/ignite/pull/1212
> > >
> > >
> > > On Tue, Nov 15, 2016 at 9:27 AM, Roman Shtykh
>  > >
> > > wrote:
> > >
> > > > Alexey,
> > > > Thank you!I answered and pushed the changes.
> > > > -Roman
> > > >
> > > >
> > > >On Tuesday, November 15, 2016 12:14 AM, Alexey Kuznetsov <
> > > > akuznet...@apache.org> wrote:
> > > >
> > > >
> > > >  Roman,
> > > >
> > > > I made one more review,  see my comments in JIRA issue.
> > > >
> > > > On Mon, Nov 7, 2016 at 1:30 PM, Alexey Kuznetsov <
> > akuznet...@apache.org>
> > > > wrote:
> > > >
> > > > > I will take a look on PR today.
> > > > >
> > > > > On Mon, Nov 7, 2016 at 11:35 AM, Roman Shtykh
> > >  > > > >
> > > > > wrote:
> > > > >
> > > > >>  Denis,
> > > > >> It is https://github.com/apache/ignite/pull/1212
> > > > >>
> > > > >> Thank you,
> > > > >> Roman
> > > > >>
> > > > >>
> > > > >>On Saturday, November 5, 2016 4:56 AM, Denis Magda <
> > > > >> dma...@gridgain.com> wrote:
> > > > >>
> > > > >>
> > > > >>  Roman,
> > > > >>
> > > > >> Would you mind making a pull-request? It’s not clear and easy to
> > > review
> > > > >> using the branch you provided
> > > > >> https://github.com/apache/ignite/tree/ignite-2788 <
> > > > >> https://github.com/apache/ignite/tree/ignite-2788>
> > > > >>
> > > > >> This link provides details how to achieve this
> > > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request <
> > > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request>
> > > > >>
> > > > >> Let us know if you have any issue preparing the pull-request.
> > > > >>
> > > > >> —
> > > > >> Denis
> > > > >>
> > > > >> > On Nov 3, 2016, at 6:24 PM, Roman Shtykh
> >  > > >
> > > > >> wrote:
> > > > >> >
> > > > >> > Igniters,
> > > > >> > Please review the issue.https://issues.apache.or
> > > > >> g/jira/browse/IGNITE-3066
> > > > >> >
> > > > >> > Thank you,Roman
> > > > >>
> > > > >>
> > > > >>
> > > > >>
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Alexey Kuznetsov
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Alexey Kuznetsov
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Alexey Kuznetsov
> > >
> > >
> > >
> >
> >
> >
>

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

[Andrey Novikov]

Roman,

I reviewed your PR. Changed it a little and merged to master.
Thanks for your contribution!

On Wed, Nov 16, 2016 at 9:39 AM, Roman Shtykh 
wrote:

> Andrey,
> Sure, but I couldn't sign up -- "Cannot complete request due to license
> limitations."Let's use github for now.
> Thank you for your review!
> -Roman
>
>
> On Tuesday, November 15, 2016 6:12 PM, Andrey Novikov <
> anovi...@apache.org> wrote:
>
>
>  Roman,
>
> I reviewed your code and added comments in JIRA.
>
> May we will try to use Upsource (http://reviews.ignite.apache.org/) for
> code
> review?
>
>
> On Tue, Nov 15, 2016 at 1:22 PM, Roman Shtykh 
> wrote:
>
> > Alexey,
> > Thank you for your thorough reviews! I fixed the issues.
> > -Roman
> >
> >
> >On Tuesday, November 15, 2016 12:32 PM, Alexey Kuznetsov <
> > akuznet...@apache.org> wrote:
> >
> >
> >  Roman,
> >
> > I reviewed your code and now it looks good for me.
> > But I added two minor comments in JIRA.
> >
> > Also I think Andrey Novikov should take a look, as he has some experience
> > in ignite-rest module.
> >
> > Andrey, take a look:
> >
> > Issue: https://issues.apache.org/jira/browse/IGNITE-3066
> > PR:  https://github.com/apache/ignite/pull/1212
> >
> >
> > On Tue, Nov 15, 2016 at 9:27 AM, Roman Shtykh  >
> > wrote:
> >
> > > Alexey,
> > > Thank you!I answered and pushed the changes.
> > > -Roman
> > >
> > >
> > >On Tuesday, November 15, 2016 12:14 AM, Alexey Kuznetsov <
> > > akuznet...@apache.org> wrote:
> > >
> > >
> > >  Roman,
> > >
> > > I made one more review,  see my comments in JIRA issue.
> > >
> > > On Mon, Nov 7, 2016 at 1:30 PM, Alexey Kuznetsov <
> akuznet...@apache.org>
> > > wrote:
> > >
> > > > I will take a look on PR today.
> > > >
> > > > On Mon, Nov 7, 2016 at 11:35 AM, Roman Shtykh
> >  > > >
> > > > wrote:
> > > >
> > > >>  Denis,
> > > >> It is https://github.com/apache/ignite/pull/1212
> > > >>
> > > >> Thank you,
> > > >> Roman
> > > >>
> > > >>
> > > >>On Saturday, November 5, 2016 4:56 AM, Denis Magda <
> > > >> dma...@gridgain.com> wrote:
> > > >>
> > > >>
> > > >>  Roman,
> > > >>
> > > >> Would you mind making a pull-request? It’s not clear and easy to
> > review
> > > >> using the branch you provided
> > > >> https://github.com/apache/ignite/tree/ignite-2788 <
> > > >> https://github.com/apache/ignite/tree/ignite-2788>
> > > >>
> > > >> This link provides details how to achieve this
> > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request <
> > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request>
> > > >>
> > > >> Let us know if you have any issue preparing the pull-request.
> > > >>
> > > >> —
> > > >> Denis
> > > >>
> > > >> > On Nov 3, 2016, at 6:24 PM, Roman Shtykh
>  > >
> > > >> wrote:
> > > >> >
> > > >> > Igniters,
> > > >> > Please review the issue.https://issues.apache.or
> > > >> g/jira/browse/IGNITE-3066
> > > >> >
> > > >> > Thank you,Roman
> > > >>
> > > >>
> > > >>
> > > >>
> > > >
> > > >
> > > >
> > > > --
> > > > Alexey Kuznetsov
> > > >
> > >
> > >
> > >
> > > --
> > > Alexey Kuznetsov
> > >
> > >
> > >
> >
> >
> >
> > --
> > Alexey Kuznetsov
> >
> >
> >
>
>
>

[GitHub] ignite pull request #1212: IGNITE-3066: Set of Redis commands that can be ea...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/1212


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Use Upsource for Code Review

[Pavel Tupitsyn]

Sergi,

I don't think we should enforce it.
"Official" means that it will be allowed, linked and described in wiki.

It is up to contributor and reviewer to use it.
For example, if the changes are small/trivial, creating a review in
Upsource is not necessary.
If the changes are complex and contributor has not created a review,
reviewer may ask to do so.
Etc etc.

Thoughts?

On Wed, Nov 16, 2016 at 1:31 PM, Sergi Vladykin 
wrote:

> Pavel,
>
> I'm not sure I understand the term "official code review tool", can you
> please elaborate it? We will enforce everyone to register in Upsource and
> use it or what?
>
> Sergi
>
> 2016-11-16 13:22 GMT+03:00 Pavel Tupitsyn :
>
> > Proper link to the discussion:
> > http://apache-ignite-developers.2346864.n4.nabble.com/
> > Code-Review-Tool-Proposal-Upsource-td12195.html
> >
> > On Wed, Nov 16, 2016 at 1:16 PM, Anton Vinogradov  wrote:
> >
> > > +1
> > >
> > > On Wed, Nov 16, 2016 at 1:08 PM, Pavel Tupitsyn 
> > > wrote:
> > >
> > > > Following the discussion on Upsource [1],
> > > > I would like to call a vote on accepting it as our official code
> review
> > > > tool.
> > > >
> > > > [ ] +1  approve
> > > > [ ] +0  no opinion
> > > > [ ] -1  disapprove (and reason why)
> > > >
> > > > This vote will go on for 5 days.
> > > >
> > > > [1] http://apache-ignite-developers.2346864.n4.nabble.
> > > > com/Code-Review-Tool-Proposal-Upsource-td12195.html
> > > >
> > >
> >
>

[jira] [Created] (IGNITE-4232) "IllegalArgumentException: Cache is not configured: ignite-marshaller-sys-cache" while starting grid

[Ksenia Rybakova (JIRA)]

Ksenia Rybakova created IGNITE-4232:
---

 Summary: "IllegalArgumentException: Cache is not configured: 
ignite-marshaller-sys-cache" while starting grid
 Key: IGNITE-4232
 URL: https://issues.apache.org/jira/browse/IGNITE-4232
 Project: Ignite
  Issue Type: Bug
Affects Versions: 1.6
Reporter: Ksenia Rybakova


While starting a grid with 20 servers and 5 clients the follwing errors occur 
at some drivers:
{noformat}
[12:16:55,985][INFO ][main][IgniteKernal] Language runtime: Java Platform API 
Specification ver. 1.7
[12:16:55,985][INFO ][main][IgniteKernal] VM information: Java(TM) SE Runtime 
Environment 1.7.0_79-b15 Oracle Corporation Java HotSpot(TM) 64-Bit Server VM 
24.79-b02
[12:16:55,986][INFO ][main][IgniteKernal] VM total memory: 4.0GB
[12:16:55,986][INFO ][main][IgniteKernal] Remote Management [restart: off, 
REST: on, JMX (remote: off)]
[12:16:55,986][INFO ][main][IgniteKernal] 
IGNITE_HOME=/home/krybakova/opts-set-w-300-d-3600-m-client-rev-6e36a795-date-1611-121630/yardstick
[12:16:55,986][INFO ][main][IgniteKernal] VM arguments: [-Xms2g, -Xmx2g, 
-Djava.net.preferIPv4Stack=true, -DIGNITE_QUIET=false, -XX:+UseTLAB, 
-XX:NewSize=512m, -XX:MaxNewSize=512m, -XX:SurvivorRatio=6, 
-XX:+AlwaysPreTouch, -XX:+UseG1GC,
[12:16:55,986][INFO ][main][IgniteKernal] Configured caches 
['ignite-marshaller-sys-cache', 'ignite-sys-cache', 'ignite-atomics-sys-cache', 
'atomic']
[12:16:55,990][INFO ][main][IgniteKernal] 3-rd party licenses can be found at: 
/home/krybakova/opts-set-w-300-d-3600-m-client-rev-6e36a795-date-1611-121630/yardstick/libs/licenses
[12:16:56,061][INFO ][main][IgnitePluginProcessor] Configured plugins:
[12:16:56,061][INFO ][main][IgnitePluginProcessor]   ^-- None
[12:16:56,062][INFO ][main][IgnitePluginProcessor]
[12:16:56,108][INFO ][main][TcpCommunicationSpi] Successfully bound to TCP port 
[port=47104, locHost=0.0.0.0/0.0.0.0]
[12:16:56,124][WARN ][main][NoopCheckpointSpi] Checkpoints are disabled (to 
enable configure any GridCheckpointSpi implementation)
[12:16:56,152][WARN ][main][GridCollisionManager] Collision resolution is 
disabled (all jobs will be activated upon arrival).
[12:16:56,155][WARN ][main][NoopSwapSpaceSpi] Swap space is disabled. To enable 
use FileSwapSpaceSpi.
[12:16:56,157][INFO ][main][IgniteKernal] Security status [authentication=off, 
tls/ssl=off]
[12:16:56,408][INFO ][main][GridTcpRestProtocol] Command protocol successfully 
started [name=TCP binary, host=0.0.0.0/0.0.0.0, port=11215]
[12:16:56,449][INFO ][main][IgniteKernal] Non-loopback local IPs: 172.25.1.34
[12:16:56,449][INFO ][main][IgniteKernal] Enabled local MACs: 001B21D4F1B8
Exception in thread "sys-#34%null%" java.lang.IllegalArgumentException: Cache 
is not configured: ignite-marshaller-sys-cache
at 
org.apache.ignite.internal.processors.cache.GridCacheProcessor.jcache(GridCacheProcessor.java:3320)
at 
org.apache.ignite.internal.processors.cache.query.continuous.CacheContinuousQueryHandler.handleEvent(CacheContinuousQueryHandler.java:711)
at 
org.apache.ignite.internal.processors.cache.query.continuous.CacheContinuousQueryHandler.notifyCallback0(CacheContinuousQueryHandler.java:683)
at 
org.apache.ignite.internal.processors.cache.query.continuous.CacheContinuousQueryHandler.notifyCallback(CacheContinuousQueryHandler.java:642)
at 
org.apache.ignite.internal.processors.continuous.GridContinuousProcessor.processNotification(GridContinuousProcessor.java:1086)
at 
org.apache.ignite.internal.processors.continuous.GridContinuousProcessor.access$2000(GridContinuousProcessor.java:97)
at 
org.apache.ignite.internal.processors.continuous.GridContinuousProcessor$8.onMessage(GridContinuousProcessor.java:741)
at 
org.apache.ignite.internal.managers.communication.GridIoManager.invokeListener(GridIoManager.java:1080)
at 
org.apache.ignite.internal.managers.communication.GridIoManager.access$1600(GridIoManager.java:101)
at 
org.apache.ignite.internal.managers.communication.GridIoManager$GridCommunicationMessageSet.unwind(GridIoManager.java:2317)
at 
org.apache.ignite.internal.managers.communication.GridIoManager.unwindMessageSet(GridIoManager.java:1040)
at 
org.apache.ignite.internal.managers.communication.GridIoManager.access$1900(GridIoManager.java:101)
at 
org.apache.ignite.internal.managers.communication.GridIoManager$6.run(GridIoManager.java:1009)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
Exception in thread "sys-#36%null%" java.lang.IllegalArgumentException: Cache 
is not configured: ignite-marshaller-sys-cache
at 
org.apache.ignite.internal.processors.cache.GridCacheProcessor.jcache(GridCacheProcess

Re: [VOTE] Use Upsource for Code Review

[Sergi Vladykin]

Pavel,

I'm not sure I understand the term "official code review tool", can you
please elaborate it? We will enforce everyone to register in Upsource and
use it or what?

Sergi

2016-11-16 13:22 GMT+03:00 Pavel Tupitsyn :

> Proper link to the discussion:
> http://apache-ignite-developers.2346864.n4.nabble.com/
> Code-Review-Tool-Proposal-Upsource-td12195.html
>
> On Wed, Nov 16, 2016 at 1:16 PM, Anton Vinogradov  wrote:
>
> > +1
> >
> > On Wed, Nov 16, 2016 at 1:08 PM, Pavel Tupitsyn 
> > wrote:
> >
> > > Following the discussion on Upsource [1],
> > > I would like to call a vote on accepting it as our official code review
> > > tool.
> > >
> > > [ ] +1  approve
> > > [ ] +0  no opinion
> > > [ ] -1  disapprove (and reason why)
> > >
> > > This vote will go on for 5 days.
> > >
> > > [1] http://apache-ignite-developers.2346864.n4.nabble.
> > > com/Code-Review-Tool-Proposal-Upsource-td12195.html
> > >
> >
>

Re: [VOTE] Use Upsource for Code Review

[Pavel Tupitsyn]

Proper link to the discussion:
http://apache-ignite-developers.2346864.n4.nabble.com/
Code-Review-Tool-Proposal-Upsource-td12195.html

On Wed, Nov 16, 2016 at 1:16 PM, Anton Vinogradov  wrote:

> +1
>
> On Wed, Nov 16, 2016 at 1:08 PM, Pavel Tupitsyn 
> wrote:
>
> > Following the discussion on Upsource [1],
> > I would like to call a vote on accepting it as our official code review
> > tool.
> >
> > [ ] +1  approve
> > [ ] +0  no opinion
> > [ ] -1  disapprove (and reason why)
> >
> > This vote will go on for 5 days.
> >
> > [1] http://apache-ignite-developers.2346864.n4.nabble.
> > com/Code-Review-Tool-Proposal-Upsource-td12195.html
> >
>

Re: IgniteCache.loadCache improvement proposal

[Yakov Zhdanov]

> Yakov, I agree that such scenario should be avoided. I also think that
> loadCache(...) method, as it is right now, provides a way to avoid it.

No, it does not.

--Yakov

Re: Code Review Tool Proposal: Upsource

[Pavel Tupitsyn]

I've started the vote.

Meanwhile, we have reached the user limit in the evaluation version.
Some people report that they can't register; we will request proper
open-source license as soon as the vote succeeds.

On Wed, Nov 16, 2016 at 12:18 AM, Denis Magda  wrote:

> Pavel,
>
> Makes sense to me. Let’s start the voting process then adding the link to
> this discussion to the voting thread.
> I would wait no less than 5 days giving a chance to everyone to share
> his/her opinion.
>
> —
> Denis
>
> > On Nov 14, 2016, at 11:16 AM, Pavel Tupitsyn 
> wrote:
> >
> > Denis,
> >
> > Contributors will have to start a review on branch or pull request
> manually
> > (a couple of clicks really), then attach an URL to the JIRA ticket.
> > Example: https://issues.apache.org/jira/browse/IGNITE-4116
> >
> >> are there any examples of Apache projects that used some 3rd party tool
> > for review process
> > Some projects use Crucible: https://fisheye6.atlassian.com/
> > Apache Hive used Phabricator in the past.
> >
> >
> > Mike,
> >
> >> Why not / what is wrong with GitHub?
> > Nothing is wrong with GitHub, I think it is the second best option.
> > Still, Upsource is much nicer, so I'd like to explore this possibility.
> >
> >> commercial tool I have to pay for
> > They provide open source license. We license TeamCity this way.
> >
> > On Mon, Nov 14, 2016 at 8:32 PM, Michael André Pearce <
> > michael.andre.pea...@me.com> wrote:
> >
> >> Why not / what is wrong with GitHub?
> >>
> >> Code is there anyhow...
> >>
> >> I've found this seems to be the way a lot of projects have gone.
> >>
> >> It allows me to review the code without checkout
> >>
> >> I can comment inline with a pr or code commit
> >>
> >> I can fork a project to my own space and create a pr back to the main
> repo
> >>
> >> It updates when I make a commit
> >>
> >> Supports multiple reviewers.
> >>
> >> Eco system of bots
> >>
> >> It doesn't tie me into a commercial ide tool (I love IntelliJ like the
> >> next person, but appreciate it is a commercial tool I have to pay for
> for
> >> all the bells and whistles)
> >>
> >> Rgds
> >> Mike
> >>
> >>> On 14 Nov 2016, at 17:03, Denis Magda  wrote:
> >>>
> >>> Pavel,
> >>>
> >>> How will the contribution process be affected if the community switches
> >> to Upsource? Will Upsource introduce additional steps for those who
> want to
> >> ask someone to review a branch or the tool simply intercepts all the
> >> pull-requests automatically?
> >>>
> >>> Cos, Raul, Others,
> >>>
> >>> How this intention is aligned with Apache at all? In you experience,
> are
> >> there any examples of Apache projects that used some 3rd party tool for
> >> review process?
> >>>
> >>> —
> >>> Denis
> >>>
>  On Nov 14, 2016, at 4:08 AM, Pavel Tupitsyn 
> >> wrote:
> 
>  Igniters,
> 
>  We have set up Upsource code review tool at
>  http://reviews.ignite.apache.org/
> 
>  I propose to evaluate it and see if it works for us.
> 
> 
>  * Why?
>  Current JIRA-based process is not very efficient. Anyone who have
> used a
>  review tool will probably agree:
> 
>  - No need to switch branches locally and interrupt your current work.
> >> You
>  can see the code in one click.
>  - All current reviews are easily accessible
>  - Multiple reviewers
>  - Much better discussions: comments are right in the code; each point
> >> can
>  be discussed and accepted separately
>  - Integrates with IDEA - open the diff in IDEA in one click, or see
> the
>  reviews there without opening the browser at all
> 
> 
>  * Why Upsource?
>  I've evaluated a bunch of tools (CodeCollaborator, ReviewBoard,
>  Phabricator, Crucible),
>  and Upsource looks like the best fit for us:
>  - PR-based code reviews. This is a major advantage: review for a PR
> can
> >> be
>  created in one click, and it updates automatically when you push more
>  commits (fix review issues)
>  - Good Java support and IDEA integration
>  - Good performance (our code base is big, and tools like Crucible
> really
>  struggle with it)
> 
> 
>  Thoughts and suggestions are welcome.
> 
>  Thanks,
> 
>  Pavel
> >>>
> >>
>
>

Re: [VOTE] Use Upsource for Code Review

[Anton Vinogradov]

+1

On Wed, Nov 16, 2016 at 1:08 PM, Pavel Tupitsyn 
wrote:

> Following the discussion on Upsource [1],
> I would like to call a vote on accepting it as our official code review
> tool.
>
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
>
> This vote will go on for 5 days.
>
> [1] http://apache-ignite-developers.2346864.n4.nabble.
> com/Code-Review-Tool-Proposal-Upsource-td12195.html
>

[VOTE] Use Upsource for Code Review

[Pavel Tupitsyn]

Following the discussion on Upsource [1],
I would like to call a vote on accepting it as our official code review
tool.

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

This vote will go on for 5 days.

[1] http://apache-ignite-developers.2346864.n4.nabble.
com/Code-Review-Tool-Proposal-Upsource-td12195.html

Re: IgniteCache.loadCache improvement proposal

[Alexandr Kuramshin]

Hi all,

Denis, thank you for the explanation, your understanding of the question is
the most closest to mine.

The extension of the method IgniteCache.loadCache by adding an
IgniteClosure is a handy feature which may be useful in some cases, but not
addresses the problem of extensive network utilization.

Actually I vote against that extension - uses of that method will have the
same overhead on the network.

IgniteCache.localLoadCache, as its name tells, should only load entities
for the local cache partitions, and the such filtering should be done
before invoking the predicate, to minimize the unnecessary analyzing of the
entities will not be stored in the cache. So extension of the method
with IgniteClosure
does not resolve the problem, because the IgniteClosure should be called
after the IgnitePredicate has done its filtering.

The last argument, is that any extension of the API does not affect last
usages of the non-optimized method IgniteCache.loadCache. And my wish and
my will are to re-implement the IgniteCache.loadCache.

After the re-implementation has been done, we can extend the API by adding
additional arguments like IgniteClosure to make cache store operations
customizable.

2016-11-16 3:51 GMT+03:00 Denis Magda :

> Val,
>
> Then I would create a blog post on how to use the new API proposed by you
> to accomplish the scenario described by Alexandr. Are you willing to write
> the post once the API is implemented?
>
> Alexandr, do you think the API proposed by Val will resolve your case when
> it’s used as listed below? If it’s so are you interested to take over the
> implementation and contribute to Apache Ignite?
>
> —
> Denis
>
> > On Nov 15, 2016, at 2:30 PM, Valentin Kulichenko <
> valentin.kuliche...@gmail.com> wrote:
> >
> > Denis,
> >
> > The loading will be most likely initiated by the application anyway, even
> > if you call localLoadCache on one of the server nodes. I.e. the flow is
> the
> > following:
> >
> >   1. Client sends a closure to a server node (e.g. oldest or random).
> >   2. The closure calls localLoadCache method.
> >   3. If this server node fails (or if the loading process fails), client
> >   gets an exception and retries if needed.
> >
> > I would not complicate the API and implementation even more. We have
> > compute grid API that already allows to handle things you're describing.
> > It's very flexible and easy to use.
> >
> > -Val
> >
> > On Tue, Nov 15, 2016 at 2:20 PM, Denis Magda  wrote:
> >
> >> Well, that’s clear. However, with localLoadCache the user still has to
> >> care about the fault-tolerance if the node that loads the data goes
> down.
> >> What if we provide an overloaded version of loadCache that will accept a
> >> number of nodes where the closure has to be executed? If the number
> >> decreases then the engine will re-execute the closure on a node that is
> >> alive.
> >>
> >> —
> >> Denis
> >>
> >>
> >>> On Nov 15, 2016, at 2:06 PM, Valentin Kulichenko <
> >> valentin.kuliche...@gmail.com> wrote:
> >>>
> >>> You can use localLoadCache method for this (it should be overloaded as
> >> well
> >>> of course). Basically, if you provide closure based on
> IgniteDataStreamer
> >>> and call localLoadCache on one of the nodes (client or server), it's
> the
> >>> same approach as described in [1], but with the possibility to reuse
> >>> existing persistence code. Makes sense?
> >>>
> >>> [1] https://apacheignite.readme.io/docs/data-loading#
> ignitedatastreamer
> >>>
> >>> -Val
> >>>
> >>> On Tue, Nov 15, 2016 at 1:15 PM, Denis Magda 
> wrote:
> >>>
>  How would your proposal resolve the main point Aleksandr is trying to
>  convey that is extensive network utilization?
> 
>  As I see the loadCache method still will be triggered on every and as
>  before all the nodes will pre-load all the data set from a database.
> >> That
>  was Aleksandr’s reasonable concern.
> 
>  If we make up a way how to call the loadCache on a specific node only
> >> and
>  implement some falt-tolerant mechanism then your suggestion should
> work
>  perfectly fine.
> 
>  —
>  Denis
> 
> > On Nov 15, 2016, at 12:05 PM, Valentin Kulichenko <
>  valentin.kuliche...@gmail.com> wrote:
> >
> > It sounds like Aleksandr is basically proposing to support automatic
> > persistence [1] for loading through data streamer and we really don't
>  have
> > this. However, I think I have more generic solution in mind.
> >
> > What if we add one more IgniteCache.loadCache overload like this:
> >
> > loadCache(@Nullable IgniteBiPredicate p, IgniteBiInClosure V>
> > clo, @Nullable
> > Object... args)
> >
> > It's the same as the existing one, but with the key-value closure
>  provided
> > as a parameter. This closure will be passed to the
> CacheStore.loadCache
> > along with the arguments and will allow to override the logic that
>  actually
> > saves the loaded e

[jira] [Created] (IGNITE-4231) Hangs on compute result serialization error

[Dmitry Karachentsev (JIRA)]

Dmitry Karachentsev created IGNITE-4231:
---

 Summary: Hangs on compute result serialization error
 Key: IGNITE-4231
 URL: https://issues.apache.org/jira/browse/IGNITE-4231
 Project: Ignite
  Issue Type: Bug
Affects Versions: 1.7
Reporter: Dmitry Karachentsev
Assignee: Dmitry Karachentsev
 Fix For: 1.8


Compute task may hang if was thrown exception on result serialization. This 
should be properly handled and responded to client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Service proxy API changes

[Dmitriy Karachentsev]

Valentin,

I understand your point and it makes sense to me. To summarize discussion
I'll do the following. Leave timeout, use LT for spammed stack traces and
file separate ticket for serialization issue in calculations as suggested
Semyon.

On Wed, Nov 16, 2016 at 1:11 AM, Valentin Kulichenko <
valentin.kuliche...@gmail.com> wrote:

> Dmitry,
>
> I absolutely agree with this and I'm not saying that timeout solves any of
> these problems. However, it provides a bit of safety for such cases (client
> continues working instead of hanging forever) and also allows not too wait
> for the service too long which can be also useful sometimes (e.g. service
> is redeployed and initialization takes a lot of time for some reason). It
> makes perfect sense to have it and should not be difficult to add. Am I
> missing something?
>
> -Val
>
> On Tue, Nov 15, 2016 at 1:12 PM, Dmitry Karachentsev <
> dkarachent...@gridgain.com> wrote:
>
> > Valentin, as I understand, this situation is abnormal, and if user thread
> > hangs on getting service proxy, it's worth to check logs for failure
> > instead of making workaround.
> >
> >
> > On 15.11.2016 19:47, Valentin Kulichenko wrote:
> >
> >> I would still add a timeout there. In my view, it makes sense to have
> such
> >> option. Currently user thread can block indefinitely or loop in
> >> while(true)
> >> forever.
> >>
> >> -Val
> >>
> >> On Tue, Nov 15, 2016 at 7:10 AM, Dmitriy Karachentsev <
> >> dkarachent...@gridgain.com> wrote:
> >>
> >> Perfect, thanks!
> >>>
> >>> On Tue, Nov 15, 2016 at 5:56 PM, Vladimir Ozerov  >
> >>> wrote:
> >>>
> >>> To avoid log pollution we usually use LT class (alias for
> 
> >>> GridLogThrottle).
> >>>
>  Please check if it can help you.
> 
>  On Tue, Nov 15, 2016 at 5:48 PM, Dmitriy Karachentsev <
>  dkarachent...@gridgain.com> wrote:
> 
>  Vladimir, thanks for your reply!
> >
> > What you suggest definitely makes sense and it looks more reasonable
> > solution.
> > But there remains other thing. The second issue, that this solution
> >
>  solves,
> 
> > is prevent log pollution with GridServiceNotFoundException. The
> reason
> >
>  why
> 
> > it happens is because GridServiceProxy#invokeMethod() designed to
> >
>  catch
> >>>
>  it
> 
> > and ClusterTopologyCheckedException and retry over and over again
> >
>  unless
> >>>
>  service is become available, but on the same time there are tons of
> >
>  stack
> >>>
>  traces printed on remote node.
> >
> > If we want to avoid changing API, probably we need to add option to
> >
>  mute
> >>>
>  that exceptions in GridJobWorker.
> >
> > What do you think?
> >
> > On Tue, Nov 15, 2016 at 5:10 PM, Vladimir Ozerov <
> voze...@gridgain.com
> > wrote:
> >
> > Also we implemented the same thing for platforms some time ago. In
> >>
> > short,
> 
> > job result processing was implemented as follows (pseudocode):
> >>
> >> // Execute.
> >> Object res;
> >>
> >> try {
> >>  res = job.run();
> >> }
> >> catch (Exception e) {
> >>  res = e
> >> }
> >>
> >> // Serialize result.
> >> try {
> >>  SERIALIZE(res);
> >> }
> >> catch (Exception e) {
> >>  try{
> >>  // Serialize serialization error.
> >>  SERIALIZE(new IgniteException("Failed to serialize
> result.",
> >>
> > e));
> 
> >  }
> >>  catch (Exception e) {
> >>  // Cannot serialize serialization error, so pass only
> string
> >>
> > to
> >>>
>  exception.
> >>  SERIALIZE(new IgniteException("Failed to serialize result:
> "
> >>
> > +
> >>>
>  e.getMessage());
> >>  }
> >> }
> >>
> >> On Tue, Nov 15, 2016 at 5:05 PM, Vladimir Ozerov <
> >>
> > voze...@gridgain.com
> >>>
>  wrote:
> >>
> >> Dmitriy,
> >>>
> >>> Shouldn't we report serialization problem properly instead? We
> >>>
> >> already
> 
> > had
> >>
> >>> a problem when node hanged during job execution in case it was
> >>>
> >> impossible
> >
> >> to deserialize the job on receiver side. It was resolved properly -
> >>>
> >> we
> 
> > caught exception on receiver side and reported it back sender side.
> >>>
> >>> I believe we must do the same for services. Otherwise we may end up
> >>>
> >> in
> 
> > messy API which doesn't resolve original problem.
> >>>
> >>> Vladimir.
> >>>
> >>> On Tue, Nov 15, 2016 at 4:38 PM, Dmitriy Karachentsev <
> >>> dkarachent...@gridgain.com> wrote:
> >>>
> >>> Hi Igniters!
> 
>  I'd like to modify our public API and add
> 
> >>> IgniteServices.serviceProxy()
> >
> >> method with timeout argument as part of the task
> >>>