[jira] [Created] (IGNITE-9939) [TC Bot] Handle situation within BuildObserver when build status is "UNKNOWN"
PetrovMikhail created IGNITE-9939: - Summary: [TC Bot] Handle situation within BuildObserver when build status is "UNKNOWN" Key: IGNITE-9939 URL: https://issues.apache.org/jira/browse/IGNITE-9939 Project: Ignite Issue Type: Task Reporter: PetrovMikhail Assignee: PetrovMikhail -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-9940) [TC Bot ] TC Bot Needed Contributions
PetrovMikhail created IGNITE-9940: - Summary: [TC Bot ] TC Bot Needed Contributions Key: IGNITE-9940 URL: https://issues.apache.org/jira/browse/IGNITE-9940 Project: Ignite Issue Type: Task Reporter: PetrovMikhail -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ignite pull request #5032: IGNITE-9935 Test fix.
GitHub user xtern opened a pull request: https://github.com/apache/ignite/pull/5032 IGNITE-9935 Test fix. You can merge this pull request into a Git repository by running: $ git pull https://github.com/xtern/ignite IGNITE-9935 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5032.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5032 commit bff90beb6d7dd594118473dbcad1a2379402fdd8 Author: pereslegin-pa Date: 2018-10-19T08:59:23Z IGNITE-9935 Test fix. ---
[GitHub] ignite pull request #5033: 8227 interrupt
GitHub user SomeFire opened a pull request: https://github.com/apache/ignite/pull/5033 8227 interrupt You can merge this pull request into a Git repository by running: $ git pull https://github.com/SomeFire/ignite IGNITE-8227-interrupt Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5033.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5033 commit d4bc2199d6ebd72be328386ecadd0f900ad3b0a0 Author: Dmitrii Ryabov Date: 2018-10-12T09:58:13Z IGNITE-8227 test failure handler commit c6048bc88e6bbdf776d80cffa81d332ad26793ed Author: Dmitrii Ryabov Date: 2018-10-12T14:13:46Z override toString() commit 2afa558db7503b8e42da117e15486090f505eb18 Author: Dmitrii Ryabov Date: 2018-10-17T13:32:41Z set NoOpFailureHandler for tests with topology changes commit 0d9bfd4061d2440c6ef75637a34f40e05b433a69 Author: Dmitrii Ryabov Date: 2018-10-18T12:07:28Z set NoOpFailureHandler for failover tests commit c41db3167fa72867e9b3a548db21f4a599e859bc Author: Dmitrii Ryabov Date: 2018-10-19T08:58:49Z interrupt ---
[GitHub] ignite pull request #4953: IGNITE-9776 FsyncModeFileWriteAheadLogManager can...
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4953 ---
[jira] [Created] (IGNITE-9941) Web Console: Add option to disable self-registration on Web Console
Alexey Kuznetsov created IGNITE-9941: Summary: Web Console: Add option to disable self-registration on Web Console Key: IGNITE-9941 URL: https://issues.apache.org/jira/browse/IGNITE-9941 Project: Ignite Issue Type: Bug Components: wizards Reporter: Alexey Kuznetsov Assignee: Alexey Kuznetsov It will be useful to have ability to disable self registration on Web Console. We can add a special option on backend and also add a button "Send invite" on "Admin panel" screen. If "self registration" disabled on backend and user trying to register he should receive error like "You need to ask for invite your Web Console administrator" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-9942) We need ability in WebConsole to disable selfregistration feature.
Pavel Voronkin created IGNITE-9942: -- Summary: We need ability in WebConsole to disable selfregistration feature. Key: IGNITE-9942 URL: https://issues.apache.org/jira/browse/IGNITE-9942 Project: Ignite Issue Type: Improvement Reporter: Pavel Voronkin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [DISCUSS] Dropping hadoop-accelerator download
Can you file an issue then, please? > On 19 Oct 2018, at 04:04, Denis Magda wrote: > > I would do this if it doesn't impact the release time. > > -- > Denis > > On Thu, Oct 18, 2018 at 2:34 AM Petr Ivanov wrote: > >> Can we drop Hadoop binaries from delivery this release (2.7) or should it >> be moved to next? >> >> >>> On 18 Oct 2018, at 04:38, Denis Magda wrote: >>> >>> No objections from my side. >>> >>> -- >>> Denis >>> >>> >>> On Tue, Oct 16, 2018 at 4:45 PM Dmitriy Setrakyan >> >>> wrote: >>> Igniters, I would like to suggest dropping the hadoop accelerator distribution of Apache Ignite. Note, that it does not mean dropping any features. We are still going to support IGFS, in-memory map reduce, spark integration, >> etc. However, the hadoop-accelerator downloadable is putting extra pressure >> on the community to test and document, which can be avoided. All the >> features will still be supported through regular Ignite distribution. Any objections? D. >> >>
[GitHub] ignite pull request #4924: IGNITE-9784 Automatically adjust max WAL history ...
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4924 ---
[jira] [Created] (IGNITE-9943) Update documentation for default WAL archive size (added auto-adjust)
Alexey Goncharuk created IGNITE-9943: Summary: Update documentation for default WAL archive size (added auto-adjust) Key: IGNITE-9943 URL: https://issues.apache.org/jira/browse/IGNITE-9943 Project: Ignite Issue Type: Bug Reporter: Alexey Goncharuk -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-9944) MVCC TX: GridDhtTxAbstractEnlistFuture near nodes update race.
Roman Kondakov created IGNITE-9944: -- Summary: MVCC TX: GridDhtTxAbstractEnlistFuture near nodes update race. Key: IGNITE-9944 URL: https://issues.apache.org/jira/browse/IGNITE-9944 Project: Ignite Issue Type: Bug Components: mvcc Reporter: Roman Kondakov Fix For: 2.7 When {{GridDhtTxAbstractEnlistFuture#skipNearNodeUpdates}} is set to true it can cause failure on backup node during rebalancing. Possible scenario: # First entry is enlisted before rabalance was started and therefore it's backup node is added to {{GridDhtTxLocalAdapter#addLockTransactionNode}} in {{GridDhtTxAbstractEnlistFuture#addToBatch}} method. Note: in this case remote tx is not started on remote note. # Next entry could be processed when rebalance is already started and therefore this optimization will be skipped. In this case updated entry will be sent to backup node as usual in DhtEnlistRequest. # But instead of sending {{GridDhtTxQueryFirstEnlistRequest}}, the {{GridDhtTxQueryEnlistRequest}} will be sent because near node has already been added to tx lock nodes list. # When this request arrives in {{GridDhtTransactionalCacheAdapter#processDhtTxQueryEnlistRequest}}, the "Can not find a transaction" exception will be thrown. Possible solution: we need to send {{GridDhtTxQueryFirstEnlistRequest}} in these cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zzzadruga opened a new pull request #38: IGNITE-9869 Remove invalid builds from the selection
zzzadruga opened a new pull request #38: IGNITE-9869 Remove invalid builds from the selection URL: https://github.com/apache/ignite-teamcity-bot/pull/38 1. Mark build on all graphs; 2.Median red line; 3.Remove build from selection and return it back. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ignite pull request #5025: GG-14044: Fix entry start version.
Github user AMashenkov closed the pull request at: https://github.com/apache/ignite/pull/5025 ---
[jira] [Created] (IGNITE-9945) Entry start version omits datecenter id.
Andrew Mashenkov created IGNITE-9945: Summary: Entry start version omits datecenter id. Key: IGNITE-9945 URL: https://issues.apache.org/jira/browse/IGNITE-9945 Project: Ignite Issue Type: Bug Components: cache Reporter: Andrew Mashenkov Now, entry start version has datacenterID=0 and such entry can be treated as recieved from foreign DC. This may cause false positive DR conflict and force user to make non-trivial additional check. This was broken in IGNITE-8503. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ignite pull request #5034: IGNITE-9945: Entry start version omits datecenter...
GitHub user AMashenkov opened a pull request: https://github.com/apache/ignite/pull/5034 IGNITE-9945: Entry start version omits datecenter id. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite GG-14044 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5034.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5034 commit 3a148aeb55339514fbd3f337edfd6625b4c6cae1 Author: Andrey V. Mashenkov Date: 2018-10-18T12:47:44Z GG-14044: Fix entry start version. Fixed false positive conflicts. commit 882ef897d50d2fddd9210bbc71e9abccf9fca99e Author: Andrey V. Mashenkov Date: 2018-10-18T15:17:52Z GG-14177: Styles. ---
[jira] [Created] (IGNITE-9946) Fix priority for field validations
Vasiliy Sisko created IGNITE-9946: - Summary: Fix priority for field validations Key: IGNITE-9946 URL: https://issues.apache.org/jira/browse/IGNITE-9946 Project: Ignite Issue Type: Bug Reporter: Vasiliy Sisko Assignee: Vasiliy Sisko Empty field should has bigger priority then unique. F.e.: # Open Queries and indexing section of cache. # Add 2 empty rows in SQL functions field. First value is marked as empty but second value is marked as duplicate. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Apache Ignite 2.7. Last Mile
Hello, Igniters. We have 6 tickets for 2.7 Roman Kondakov - IGNITE-9892, IGNITE-9663, IGNITE-9928 Igor Seliverstov - IGNITE-9911 Ivan Pavlukhin - IGNITE-5935, IGNITE-9944 В Чт, 18/10/2018 в 15:40 +0300, Andrey Kuznetsov пишет: > I have got one more potential 2.7 blocker [1] with straightforward fix. I > beleive it will not break any production use case, but it leads to test > suite hang, thus affecting other urgent issues. > > [1] https://issues.apache.org/jira/browse/IGNITE-9932 > > чт, 18 окт. 2018 г. в 14:59, Ivan Daschinsky : > > > Hi! Is it possible to merge IGNITE-9854? Fix is pretty simple, but quite > > important. > > > > ср, 17 окт. 2018 г. в 17:49, Andrey Gura : > > > > > JFYI > > > > > > IGNITE-9737 and IGNITE-9710 are merged to release branch. > > > On Wed, Oct 17, 2018 at 5:41 PM Pavel Tupitsyn > > > wrote: > > > > > > > > Thank you. Fix has been merged to master and cherry-picked to > > > > ignite-2.7. > > > > > > > > On Wed, Oct 17, 2018 at 1:26 PM Nikolay Izhikov > > > > > > wrote: > > > > > > > > > Pavel. > > > > > > > > > > Ok, I agree to include this ticket into 2.7 > > > > > Let's do it. > > > > > > > > > > В Ср, 17/10/2018 в 13:20 +0300, Pavel Tupitsyn пишет: > > > > > > Nikolay, > > > > > > > > > > > > It completely breaks a major feature under certain conditions. I > > > > > > would > > > > > > consider it a blocker. > > > > > > > > > > > > On Wed, Oct 17, 2018 at 1:00 PM Nikolay Izhikov < > > > > nizhi...@apache.org > > > > > > > > > wrote: > > > > > > > > > > > > > Hello, Pavel. > > > > > > > > > > > > > > Is it a blocker? > > > > > > > > > > > > > > В Ср, 17/10/2018 в 12:58 +0300, Pavel Tupitsyn пишет: > > > > > > > > Hi Igniters, > > > > > > > > > > > > > > > > I'd like to include IGNITE-9877 in 2.7, can we do that? > > > > > > > > The fix is ready, I'm waiting for TC run. > > > > > > > > > > > > > > > > Pavel > > > > > > > > > > > > > > > > On Wed, Oct 17, 2018 at 11:45 AM Павлухин Иван < > > > > > > vololo...@gmail.com> > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Hi NIkolay, > > > > > > > > > > > > > > > > > > Thank you for keeping everybody focused! Regarding to my > > > > ticket > > > > > > > > > IGNITE-5935. > > > > > > > > > It is in final stage now. Tests look good. I believe that it > > > > > > will > > > > > be > > > > > > > > > > > > > > merged > > > > > > > > > in couple of days (at most). > > > > > > > > > > > > > > > > > > ср, 17 окт. 2018 г. в 11:39, Nikolay Izhikov < > > > > > > nizhi...@apache.org > > > > > > : > > > > > > > > > > > > > > > > > > > Hello, Igniters. > > > > > > > > > > > > > > > > > > > > 9 tickets to go! > > > > > > > > > > > > > > > > > > > > Alexey Goncharuk - IGNITE-9784 > > > > > > > > > > Dmitriy Govorukhin - IGNITE-9898 > > > > > > > > > > Andrey Kuznetsov - IGNITE-9737, IGNITE-9710 > > > > > > > > > > Taras Ledkov - IGNITE-9882 > > > > > > > > > > Petr Ivanov - IGNITE-9852 > > > > > > > > > > Ivan Pavlukhin - IGNITE-5935 > > > > > > > > > > Roman Kondakov - IGNITE-9663 > > > > > > > > > > Alexey Stelmak - IGNITE-9776 > > > > > > > > > > > > > > > > > > > > В Вт, 16/10/2018 в 16:20 +0300, Andrey Gura пишет: > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > > > > > I've found that IGNITE-9723 was resolved but didn't > > > > cherry > > > > > picked > > > > > > > > > > > > > > to > > > > > > > > > > > ignite-2.7 branch. So I'll do it. > > > > > > > > > > > On Tue, Oct 16, 2018 at 2:30 PM Nikolay Izhikov < > > > > > > > > > > > > > > nizhi...@apache.org> > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > Hello, Igniters. > > > > > > > > > > > > > > > > > > > > > > > > We have 13 tickets mapped to 2.7. > > > > > > > > > > > > All tickets assigned to some contributor. > > > > > > > > > > > > > > > > > > > > > > > > Alexey Gonchruk - IGNITE-9784, IGNITE-9895 > > > > > > > > > > > > Vladimir Ozerov - IGNITE-9887 > > > > > > > > > > > > Dmitriy Govorukhin - IGNITE-9898 > > > > > > > > > > > > Andrey Kuznetsov - IGNITE-9737, IGNITE-9710 > > > > > > > > > > > > Petr Ivanov - IGNITE-9852 > > > > > > > > > > > > Ivan Pavlukhin - IGNITE-5935 > > > > > > > > > > > > Alexey Stelmak - IGNITE-9776 > > > > > > > > > > > > Roman Kondakov - IGNITE-9663 > > > > > > > > > > > > Taras Ledkov - IGNITE-9864 > > > > > > > > > > > > Igor Seliverstov - IGNITE-9292 > > > > > > > > > > > > > > > > > > > > > > > > В Пн, 15/10/2018 в 17:49 +0300, Andrey Gura пишет: > > > > > > > > > > > > > Nikolay, > > > > > > > > > > > > > > > > > > > > > > > > > > I'm looking at IGNITE-9737 and IGNITE-9710 which are > > > > > > > > > > critical > > > > > > > > > > > > > > > > > > issues > > > > > > > > > > > > > from my point of view. > > > > > > > > > > > > > I need some time for review, possible fixes and > > > > merge. > > > > > > > > > > > > > I will keep you informed. > > > > > > > > > > > > > On Mon, Oct 15, 2018 at 1:46 PM Ig
[GitHub] ololo3000 opened a new pull request #39: IGNITE-9901 Persistent queue for visas added
ololo3000 opened a new pull request #39: IGNITE-9901 Persistent queue for visas added URL: https://github.com/apache/ignite-teamcity-bot/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection
SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection URL: https://github.com/apache/ignite-teamcity-bot/pull/38#discussion_r226610891 ## File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/build/GetBuildTestFailures.java ## @@ -185,25 +233,33 @@ public TestFailuresSummary getBuildTestFails( List buildsStatistics = new ArrayList<>(); -for (int i = 0; i < finishedBuilds.length; i++) { -int buildId = finishedBuilds[i]; +String username = prov.getPrincipalId(); -FullQueryParams param = new FullQueryParams(); -param.setBuildId(buildId); -param.setBranch(branchName); -param.setServerId(srvId); +Set buildIds = teamcity.getBuildConditions(username).stream() +.mapToInt(v -> v.buildId).boxed().collect(Collectors.toSet()); -BuildStatisticsSummary buildsStatistic = updater.get( -BUILDS_STATISTICS_SUMMARY_CACHE_NAME, prov, param, -(k) -> getBuildStatisticsSummaryNoCache(srvId, buildId), false); +System.out.println(buildIds); Review comment: Use logger or remove sout. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection
SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection URL: https://github.com/apache/ignite-teamcity-bot/pull/38#discussion_r226620120 ## File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IAnalyticsEnabledTeamcity.java ## @@ -17,9 +17,24 @@ package org.apache.ignite.ci; +import java.util.Set; +import org.apache.ignite.ci.analysis.BuildCondition; + /** * Combination of REST data and persisted statistics. */ public interface IAnalyticsEnabledTeamcity extends ITeamcity, ITcAnalytics { public void init(ITeamcity conn); + +/** + * Set condition "valid" or "invalid" for build. Review comment: ```suggestion * Set condition "valid" or "invalid" for build. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection
SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection URL: https://github.com/apache/ignite-teamcity-bot/pull/38#discussion_r226609918 ## File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/build/GetBuildTestFailures.java ## @@ -158,6 +164,50 @@ public TestFailuresSummary getBuildTestFails( return res; } +/** + * Mark builds as "valid" or "invalid" for a specific user. + * + * @param buildId Build id. + * @param isValid Is valid. + * @param field Field. + * @param srv Server. + */ +@GET +@Path("condition") +public SimpleResult setBuildCondition( +@QueryParam("buildId") Integer buildId, +@QueryParam("isValid") Boolean isValid, +@QueryParam("field") String field, +@QueryParam("serverId") String srv) { +String srvId = isNullOrEmpty(srv) ? "apache" : srv; + +if (buildId == null || isValid == null) +return new SimpleResult("" + (buildId == null ? +("BuildId" + (isValid == null ? "and condition are" : "is")) : "Build condition is") + " null!"); + +final ITcHelper tcHelper = CtxListener.getTcHelper(ctx); + Review comment: ```suggestion ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection
SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection URL: https://github.com/apache/ignite-teamcity-bot/pull/38#discussion_r226609586 ## File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/build/GetBuildTestFailures.java ## @@ -158,6 +164,50 @@ public TestFailuresSummary getBuildTestFails( return res; } +/** + * Mark builds as "valid" or "invalid" for a specific user. + * + * @param buildId Build id. + * @param isValid Is valid. + * @param field Field. + * @param srv Server. + */ +@GET +@Path("condition") +public SimpleResult setBuildCondition( +@QueryParam("buildId") Integer buildId, +@QueryParam("isValid") Boolean isValid, +@QueryParam("field") String field, +@QueryParam("serverId") String srv) { +String srvId = isNullOrEmpty(srv) ? "apache" : srv; + +if (buildId == null || isValid == null) +return new SimpleResult("" + (buildId == null ? +("BuildId" + (isValid == null ? "and condition are" : "is")) : "Build condition is") + " null!"); + Review comment: ```suggestion } ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection
SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection URL: https://github.com/apache/ignite-teamcity-bot/pull/38#discussion_r226609558 ## File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/build/GetBuildTestFailures.java ## @@ -158,6 +164,50 @@ public TestFailuresSummary getBuildTestFails( return res; } +/** + * Mark builds as "valid" or "invalid" for a specific user. + * + * @param buildId Build id. + * @param isValid Is valid. + * @param field Field. + * @param srv Server. + */ +@GET +@Path("condition") +public SimpleResult setBuildCondition( +@QueryParam("buildId") Integer buildId, +@QueryParam("isValid") Boolean isValid, +@QueryParam("field") String field, +@QueryParam("serverId") String srv) { +String srvId = isNullOrEmpty(srv) ? "apache" : srv; + +if (buildId == null || isValid == null) Review comment: ```suggestion if (buildId == null || isValid == null) { ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection
SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection URL: https://github.com/apache/ignite-teamcity-bot/pull/38#discussion_r226607589 ## File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/analysis/BuildCondition.java ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.ci.analysis; + +import java.util.Date; +import java.util.Objects; + +/** + * Mark build as valid or invalid. + */ +public class BuildCondition { +/** Build id. */ +public int buildId; Review comment: Add empty lines between field declarations and make fields `final`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection
SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection URL: https://github.com/apache/ignite-teamcity-bot/pull/38#discussion_r226609952 ## File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/build/GetBuildTestFailures.java ## @@ -158,6 +164,50 @@ public TestFailuresSummary getBuildTestFails( return res; } +/** + * Mark builds as "valid" or "invalid" for a specific user. + * + * @param buildId Build id. + * @param isValid Is valid. + * @param field Field. + * @param srv Server. + */ +@GET +@Path("condition") +public SimpleResult setBuildCondition( +@QueryParam("buildId") Integer buildId, +@QueryParam("isValid") Boolean isValid, +@QueryParam("field") String field, +@QueryParam("serverId") String srv) { +String srvId = isNullOrEmpty(srv) ? "apache" : srv; + +if (buildId == null || isValid == null) +return new SimpleResult("" + (buildId == null ? +("BuildId" + (isValid == null ? "and condition are" : "is")) : "Build condition is") + " null!"); + +final ITcHelper tcHelper = CtxListener.getTcHelper(ctx); + +final ICredentialsProv prov = ICredentialsProv.get(req); + Review comment: ```suggestion if (!prov.hasAccess(serverId)) throw ServiceUnauthorizedException.noCreds(serverId); ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection
SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection URL: https://github.com/apache/ignite-teamcity-bot/pull/38#discussion_r226618991 ## File path: ignite-tc-helper-web/src/main/webapp/comparison.html ## @@ -285,7 +308,31 @@ fillCellWithStatistics(tOcc[i], num, statistics, dates, buildIds); } -$('#RunsCount' + num).html(map.length); +printRunsCount(); + +function printRunsCount(){ Review comment: Move function outside of function. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection
SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid builds from the selection URL: https://github.com/apache/ignite-teamcity-bot/pull/38#discussion_r226607074 ## File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java ## @@ -672,6 +683,32 @@ public static int getTriggerRelCacheValidSecs(int defaultSecs) { secondsUseCached == defaultSecs); } +/** {@inheritDoc} */ +public Set getBuildConditions(String username) { +final IgniteCache> cache = buildsConditionsCache(); + +return cache.containsKey(username) ? cache.get(username) : new HashSet<>(); +} + +/** {@inheritDoc} */ +public boolean setBuildCondition(BuildCondition buildCond) { + Review comment: ```suggestion ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ololo3000 opened a new pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added
ololo3000 opened a new pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added URL: https://github.com/apache/ignite-teamcity-bot/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ignite pull request #5035: IGNITE-9911
GitHub user gvvinblade opened a pull request: https://github.com/apache/ignite/pull/5035 IGNITE-9911 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9911 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5035.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5035 commit c7c4063a19e2179908a2d6862cd23e5ba0549644 Author: Igor Seliverstov Date: 2018-10-18T12:31:13Z IGNITE-9911 CacheMvccSelectForUpdateQueryAbstractTest#testSelectForUpdateAfterAbortedTx periodically hangs commit f86b82294ad469b97a5a69be4d5533d2383b3c31 Author: Igor Seliverstov Date: 2018-10-18T15:57:45Z IGNITE-9911 CacheMvccSelectForUpdateQueryAbstractTest#testSelectForUpdateAfterAbortedTx periodically hangs commit 86bbe1b062baf91eae9bf2b783a03c95e1e8e72e Author: Igor Seliverstov Date: 2018-10-18T16:04:13Z IGNITE-9911 CacheMvccSelectForUpdateQueryAbstractTest#testSelectForUpdateAfterAbortedTx periodically hangs commit b49d01094dded9a92007243c6b49149427a80a93 Author: Igor Seliverstov Date: 2018-10-19T12:05:30Z IGNITE-9911 CacheMvccSelectForUpdateQueryAbstractTest#testSelectForUpdateAfterAbortedTx periodically hangs commit 24fdde4c7d41c83f12e1322a6d4cc3d0b5e0fc00 Author: Igor Seliverstov Date: 2018-10-19T12:06:27Z Merge branch 'master' into ignite-9911 ---
[jira] [Created] (IGNITE-9947) JDBC thin: Batch update is not performed if streaming state changed before executeBatch()
Pavel Kuznetsov created IGNITE-9947: --- Summary: JDBC thin: Batch update is not performed if streaming state changed before executeBatch() Key: IGNITE-9947 URL: https://issues.apache.org/jira/browse/IGNITE-9947 Project: Ignite Issue Type: Bug Components: sql Affects Versions: 2.6 Reporter: Pavel Kuznetsov -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ignite pull request #5001: IGNITE-9884 Some tests are incorrectly muted
Github user oignatenko closed the pull request at: https://github.com/apache/ignite/pull/5001 ---
[MTCGA]: new failures in builds [1253160] needs to be handled
Hi Igniters, I've detected some new issue on TeamCity to be handled. You are more than welcomed to help. If your changes can lead to this failure(s): We're grateful that you were a volunteer to make the contribution to this project, but things change and you may no longer be able to finalize your contribution. Could you respond to this email and indicate if you wish to continue and fix test failures or step down and some committer may revert you commit. *Recently contributed test failed in master Compute.ComputeApiTestFullFooter https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=6698845531740092514&branch=%3Cdefault%3E&tab=testDetails No changes in the build - Here's a reminder of what contributors were agreed to do https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute - Should you have any questions please contact dev@ignite.apache.org Best Regards, Apache Ignite TeamCity Bot https://github.com/apache/ignite-teamcity-bot Notification generated at 15:48:42 19-10-2018
[GitHub] ignite pull request #5036: IGNITE-9884 Some tests are incorrectly muted
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/5036 IGNITE-9884 Some tests are incorrectly muted You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9884 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5036.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5036 commit 1eeca908a8076a8317947dac8a46845964d1d7ea Author: Oleg Ignatenko Date: 2018-08-23T13:13:28Z IGNITE-9348 ML examples improvements - wip (logging improved) -- verified with diffs overview, executing the examples and studying execution logs commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f Author: Oleg Ignatenko Date: 2018-08-23T14:45:57Z Revert "IGNITE-9348 ML examples improvements" This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea. commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674 Author: Oleg Ignatenko Date: 2018-08-23T14:57:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9642b233b5701bdad47ebea163079160227c582a Author: Oleg Ignatenko Date: 2018-08-28T14:01:11Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4 Author: Oleg Ignatenko Date: 2018-08-28T15:13:02Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit d2caba67b156674f051f50faebeafe0871bf0914 Author: Oleg Ignatenko Date: 2018-08-29T13:14:07Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 16775dff51d71ea68b4a3dea98be552130c493ed Author: Oleg Ignatenko Date: 2018-08-30T09:00:56Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aedb59929974fe205b949225c1a338c68c60cfc8 Author: Oleg Ignatenko Date: 2018-08-30T09:42:38Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 39c6482fcdca506aa33011ed21c98060b4a8c68b Author: Oleg Ignatenko Date: 2018-08-30T11:28:05Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 33b32a2760a6559c78283b927e3191180d8ed9e1 Author: Oleg Ignatenko Date: 2018-08-30T12:31:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0 Author: Oleg Ignatenko Date: 2018-08-30T14:06:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3 Author: Oleg Ignatenko Date: 2018-08-30T16:41:51Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aacac88db519187413b0fc5ff9d0e55b8f8cff22 Author: Oleg Ignatenko Date: 2018-08-31T10:12:32Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 897f920dde46022849b13f9fb86dba8e54119a56 Author: Oleg Ignatenko Date: 2018-08-31T13:57:14Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 114c79e54c1b316006ccc3ff22d20d902f9313df Author: Oleg Ignatenko Date: 2018-08-31T17:39:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fd6b659bb8be1992618ce4ce91f568a0988b3afa Author: Oleg Ignatenko Date: 2018-09-02T06:11:42Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944 Author: Oleg Ignatenko Date: 2018-09-03T10:27:35Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf Author: Oleg Ignatenko Date: 2018-09-04T09:49:44Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5 Author: Oleg Ignatenko Date: 2018-09-05T10:50:28Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2 Author: Oleg Ignatenko Date: 2018-09-05T11:45:58Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 480ed78869277d7e32f725ab71bec9621f1ac03a Author: Oleg Ignatenko Date: 2018-09-06T07:52:55Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit c99762498f617c0e98ea3062a43c0b30092166ef Author: Oleg Ignatenko Date: 2018-09-06T14:45:04Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 2e17175225c72f747d370b5fee96f8be69d6d2cb Author: Oleg Ignatenko Date: 2018-09-06T17:33:54Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9ebcd9a2fe5966b0bf42a95484395867c15d863f Author: Oleg Ignatenko Date: 2018-09-07T13:38:51Z Merge branch 'master' of https://github.com/apache/ignite
[jira] [Created] (IGNITE-9948) JettyRestProcessorAuthenticationWithTokenSelfTest.testGetOrCreateCache fails on TC
Amelchev Nikita created IGNITE-9948: --- Summary: JettyRestProcessorAuthenticationWithTokenSelfTest.testGetOrCreateCache fails on TC Key: IGNITE-9948 URL: https://issues.apache.org/jira/browse/IGNITE-9948 Project: Ignite Issue Type: Bug Reporter: Amelchev Nikita Assignee: Amelchev Nikita Fix For: 2.8 [Example of fail.|https://ci.ignite.apache.org/viewLog.html?buildId=2118632&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_JavaClient#testNameId-4416495803371140089] Log details: {noformat} [2018-10-19 06:59:53,063][ERROR][main][root] Test failed. java.lang.NullPointerException at org.apache.ignite.internal.processors.rest.JettyRestProcessorAbstractSelfTest.checkGetOrCreateAndDestroy(JettyRestProcessorAbstractSelfTest.java:593) at org.apache.ignite.internal.processors.rest.JettyRestProcessorAbstractSelfTest.testGetOrCreateCache(JettyRestProcessorAbstractSelfTest.java:619) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at junit.framework.TestCase.runTest(TestCase.java:176) at org.apache.ignite.testframework.junits.GridAbstractTest.runTestInternal(GridAbstractTest.java:2176) at org.apache.ignite.testframework.junits.GridAbstractTest.access$000(GridAbstractTest.java:142) at org.apache.ignite.testframework.junits.GridAbstractTest$5.run(GridAbstractTest.java:2091) at java.lang.Thread.run(Thread.java:748){noformat} The possible reason is the race between getting cache instance on different nodes: # Jetty query create cache successfully on one node. # PME doesn't have completed. # The test fails with NPE while getting the instance of cache on another node. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-9949) MVCC TX: Scan query can return wrong result on unstable topology
Roman Kondakov created IGNITE-9949: -- Summary: MVCC TX: Scan query can return wrong result on unstable topology Key: IGNITE-9949 URL: https://issues.apache.org/jira/browse/IGNITE-9949 Project: Ignite Issue Type: Bug Components: mvcc Reporter: Roman Kondakov Fix For: 2.8 Scan query map nodes do not take into account topology version when filtering primary partitions. See method {{GridCacheQueryManager#scanIterator}} - each node takes it's current topology version. This causes wrong partition filtering results. To fix this problem the single topology version should be taken on reduce node propagated to map nodes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ignite pull request #5037: IGNITE-9933: SQL: lazy mode for query reduce step
GitHub user tledkov-gridgain opened a pull request: https://github.com/apache/ignite/pull/5037 IGNITE-9933: SQL: lazy mode for query reduce step You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9933 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5037.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5037 commit d8f9ad0d47bb914f9b2d84bd98a20b437b41d28b Author: tledkov-gridgain Date: 2018-10-18T15:47:16Z IGNITE-9933: SQL: lazy mode for query reduce step ---
[GitHub] ignite pull request #5038: IGNITE-9948
GitHub user NSAmelchev opened a pull request: https://github.com/apache/ignite/pull/5038 IGNITE-9948 You can merge this pull request into a Git repository by running: $ git pull https://github.com/NSAmelchev/ignite ignite-9948 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5038.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5038 commit d2ba064477e45349d4988deb62a70fa8210a48ed Author: NSAmelchev Date: 2018-10-19T14:36:59Z For ignite-9948 ---
[GitHub] ignite pull request #4920: IGNITE-5935: WIP client origin transactions recov...
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4920 ---
[GitHub] ignite pull request #4852: IGNITE-5795 Binary metadata is registered during ...
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4852 ---
[jira] [Created] (IGNITE-9950) thin python: Decimal data type didn't match with others clients
Stepan Pilschikov created IGNITE-9950: - Summary: thin python: Decimal data type didn't match with others clients Key: IGNITE-9950 URL: https://issues.apache.org/jira/browse/IGNITE-9950 Project: Ignite Issue Type: Bug Components: thin client Environment: Ignite 2.7 latest sources default cache configuration Python 3.7 nodejs 10+ PHP 7.2+ Ubuntu 17 Reporter: Stepan Pilschikov Trying to put Decimal value from JS or PHP client and get with Python, but exception throwing JS code: {code} IgniteClient = require('apache-ignite-client'); IgniteClientConfiguration = IgniteClient.IgniteClientConfiguration; const Decimal = IgniteClient.Decimal; const ObjectType = IgniteClient.ObjectType; ENDPOINT = '127.0.0.1:10800'; igniteClient = new IgniteClient(); async function start() { await igniteClient.connect(new IgniteClientConfiguration(ENDPOINT)); try { cache = (await igniteClient.getOrCreateCache("JS_DECIMAL")) .setKeyType(ObjectType.PRIMITIVE_TYPE.INTEGER) .setValueType(ObjectType.PRIMITIVE_TYPE.DECIMAL); await cache.put(1, new Decimal('7.7')); } finally { igniteClient.disconnect(); } } start(); {code} Python get code {code} from pyignite import Client from pyignite.datatypes import * client = Client() client.connect('127.0.0.1', 10800) cache = client.get_or_create_cache("JS_DECIMAL") print(str(cache.get(1, key_hint=IntObject))) {code} exception in python {code} Traceback (most recent call last): File get_value_JS_DECIMAL.py", line 7, in print(str(cache.get(1, key_hint=IntObject))) File "[ignite_src]/platforms/python/pyignite/utils.py", line 163, in ste_wrapper result = fn(*args, **kwargs) File "[ignite_src]/platforms/python/pyignite/cache.py", line 200, in get result = cache_get(self._client, self._cache_id, key, key_hint=key_hint) File "[ignite_src]/platforms/python/pyignite/api/key_value.py", line 107, in cache_get ('value', AnyDataObject), File "[ignite_src]/platforms/python/pyignite/queries/__init__.py", line 291, in perform result.value = response_struct.to_python(response) File "[ignite_src]/platforms/python/pyignite/queries/__init__.py", line 96, in to_python *args, **kwargs File "[ignite_src]/platforms/python/pyignite/datatypes/internal.py", line 288, in to_python return data_class.to_python(ctype_object) File "[ignite_src]/platforms/python/pyignite/datatypes/standard.py", line 183, in to_python result = decimal.Decimal(data.decode(PROTOCOL_STRING_ENCODING)) decimal.InvalidOperation: [] {code} When trying with PHP have same exception Also when use Decimal from Python others clients return different value: Python decimal put code {code} from pyignite import Client from pyignite.datatypes import * from decimal import Decimal client = Client() client.connect('127.0.0.1', 10800) cache = client.get_or_create_cache("PY_DECIMAL") cache.put(1, Decimal('7.7'), key_hint=IntObject, value_hint=DecimalObject) {code} JS get {code} IgniteClient = require('apache-ignite-client'); IgniteClientConfiguration = IgniteClient.IgniteClientConfiguration; const ObjectType = IgniteClient.ObjectType; ENDPOINT = '127.0.0.1:10800'; igniteClient = new IgniteClient(); async function start() { await igniteClient.connect(new IgniteClientConfiguration(ENDPOINT)); try { cache = (await igniteClient.getOrCreateCache("PY_DECIMAL")) .setKeyType(ObjectType.PRIMITIVE_TYPE.INTEGER); console.log(await cache.get(1)); } finally { igniteClient.disconnect(); } } start(); {code} JS return '141350' value PHP have same behavior as JS -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ignite pull request #5039: IGNITE-9904: Added atomic part of Cache API for C...
GitHub user isapego opened a pull request: https://github.com/apache/ignite/pull/5039 IGNITE-9904: Added atomic part of Cache API for C++ thin client You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9904 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5039.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5039 commit 69697990789bdc63088e9139b7458f2b16f737f4 Author: Igor Sapego Date: 2018-10-16T16:30:07Z IGNITE-9904: Added test for GetAndPut() commit 6d9c3d46378af80f28f1488257e4bf27238b8075 Author: Igor Sapego Date: 2018-10-17T14:11:44Z IGNITE-9904: Implemented GetAndPut() commit 653bb8c108363ac3c257139e194bea969d58353a Author: Igor Sapego Date: 2018-10-18T14:10:05Z IGNITE-9904: Added test for GetAndRemove() commit 9292954be43966ed708099268c06f056415d3f19 Author: Igor Sapego Date: 2018-10-18T14:21:47Z IGNITE-9904: Implemented GetAndRemove() commit df821158bd599a40ee2627bd61986a2b87b4cfd9 Author: Igor Sapego Date: 2018-10-18T14:34:46Z IGNITE-9904: Added test for GetAndReplace() commit 67a4cdf41413a1a7dfdfac9849b4fb5316ea701e Author: Igor Sapego Date: 2018-10-18T14:50:04Z IGNITE-9904: Implemented GetAndReplace() commit 12588f9886ddb2f325c7fec21ad311c1bb8ef155 Author: Igor Sapego Date: 2018-10-18T15:21:00Z IGNITE-9904: Added test for PutIfAbsent() commit 5d7c21be54f72dd6b12c78077cc5bf6f9e993c80 Author: Igor Sapego Date: 2018-10-18T15:22:03Z IGNITE-9904: Implemented PutIfAbsent() commit 6e959cdb7e17286ca1b3fffc7b59420842f5e3c9 Author: Igor Sapego Date: 2018-10-18T15:34:01Z IGNITE-9904: Added tests for GetAndPutIfAbsent commit 830335efd981877db2d54b5abbe5c2a62e89cf32 Author: Igor Sapego Date: 2018-10-18T15:44:48Z IGNITE-9904: Implemented GetAndPutIfAbsent() commit 5ca31f4a0bf0e0a95e9e3164154b6adb163c687f Author: Igor Sapego Date: 2018-10-18T15:58:12Z IGNITE-9904: Added tests for Replace() (if equals) commit c2595b37c582357535e03505f5c1334d94daed41 Author: Igor Sapego Date: 2018-10-19T14:34:41Z IGNITE-9904: Implemented ReplaceIfEquals() commit 2503431ebd543e0a04b6d2e07ee6ea95b72b78ad Author: Igor Sapego Date: 2018-10-19T15:07:56Z IGNITE-9904: Added tests for RemoveIfEquals() commit 641829c400853b1dcd391265b8ac5a674a85d90f Author: Igor Sapego Date: 2018-10-19T15:28:43Z IGNITE-9904: Implemented RemoveIfEquals() ---
[GitHub] ignite pull request #5040: IGNITE-9944: GridDhtTxAbstractEnlistFuture near n...
GitHub user pavlukhin opened a pull request: https://github.com/apache/ignite/pull/5040 IGNITE-9944: GridDhtTxAbstractEnlistFuture near nodes update race You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9944 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5040.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5040 commit 72be72b18b8ab9c791ef06ad811e16cfd15cd55e Author: ipavlukhin Date: 2018-10-19T15:42:14Z fix problem when first enlist request is not sent to near node with MOVING backup partition ---
[jira] [Created] (IGNITE-9951) thin php: Date data type cut nanos
Stepan Pilschikov created IGNITE-9951: - Summary: thin php: Date data type cut nanos Key: IGNITE-9951 URL: https://issues.apache.org/jira/browse/IGNITE-9951 Project: Ignite Issue Type: Bug Components: thin client Affects Versions: 2.7 Environment: Ignite 2.7 latest sources default cache configuration Python 3.7 nodejs 10+ PHP 7.2+ Ubuntu 17 Reporter: Stepan Pilschikov When using PHP data types TIMESTAMP or DATE have problem with getting data with others clients, main reason that is nano seconds was cutted from php client side PHP code {code} connect(new ClientConfiguration($ENDPOINT)); $cache = $client->getOrCreateCache("PH_DATE") ->setKeyType(ObjectType::INTEGER) ->setValueType(ObjectType::DATE); $cache->put(1,Date::fromDateTime(DateTime::createFromFormat('Y-m-d H:i:s.u', '2018-10-19 18:31:13.029726'))); {code} JS output {code} "2018-10-19T15:31:13.000Z" {code} Py code {code} from pyignite import Client from pyignite.datatypes import * client = Client() client.connect('127.0.0.1', 10800) cache = client.get_or_create_cache("PH_DATE") print(str(cache.get(1, key_hint=IntObject))) {code} Py output {code} 2018-10-19 18:31:13 {code} When im using JS or Python for put looks like Py {code} 2018-10-19 18:31:13.029000 {code} JS {code} "2018-10-19T15:31:13.029Z" {code} Same story with Timestamp when PHP put {code} connect(new ClientConfiguration($ENDPOINT)); try { $cache = $client->getOrCreateCache("PH_TIMESTAMP")->setKeyType(ObjectType::INTEGER)->setValueType(ObjectType::TIMESTAMP); $cache->put(1,(new Timestamp((DateTime::createFromFormat('Y-m-d H:i:s.u', '2018-10-19 18:31:13.029734'))->getTimestamp() * 1000, 29734))); } finally { $client->disconnect(); } {code} Py output {code} (datetime.datetime(2018, 10, 19, 18, 31, 13), 29734) {code} should look like {code} (datetime.datetime(2018, 10, 19, 18, 31, 13, 29000), 29734) {code} Or JS {code} "2018-10-19T15:31:13.000Z" {code} should look like {code} "2018-10-19T15:31:13.029Z" {code} Also wanna to admit that PHP Method Timestamp::fromDateTime(Data) didn't take nano seconds from date time (thats why in timestamp initialization i am doing what i do) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Python thin client
Dmitry, One more thing Discover that Decimal data type can't be getting by others clients Make ticket with description: https://issues.apache.org/jira/browse/IGNITE-9950 Please, can you help to investigate this problem? ср, 17 окт. 2018 г. в 23:14, Stepan Pilschikov : > Dmitry, > > Great, now client works properly on all OS > Thanks > > I hope PR will be merged soon > > Igor, can please help with that? > > ср, 17 окт. 2018 г. в 20:48, Dmitry Melnichuk < > dmitry.melnic...@nobitlost.com>: > >> Stepan, >> >> Sadly, it was a C `long` data type size mismatch between Windows and >> other OSes. I investigated this issue and offered a pull request. >> >> https://github.com/apache/ignite/pull/5017 >> >> On 10/17/18 6:29 PM, Stepan Pilschikov wrote: >> > Dmitry, >> > >> > I've trying to use python thin client with Ignite 2.7 it dosn't work >> > Please help to investigate >> > Problem reproduced on several others machines >> > >> > Issue: >> > https://issues.apache.org/jira/browse/IGNITE-9908 >> > >> >
Re: PHP thin client
Alexey, Hi I'm trying to use PHP client for some times and discover one problem with DATA and TIMESTAMP data types I'ts appear when you trying to use DATA or TIMESTAMP as cache key All description in ticket: https://issues.apache.org/jira/browse/IGNITE-9951 Can you help with that, please? чт, 11 окт. 2018 г. в 16:02, Igor Sapego : > Alexey, > > Since PHP thin client is now in master, can you please add it to our > "Thin clients features" wiki page, so we can track the feature parity > of our clients? > > [1] - > https://cwiki.apache.org/confluence/display/IGNITE/Thin+clients+features > > Best Regards, > Igor > > > On Wed, Oct 10, 2018 at 2:56 PM Vladimir Ozerov > wrote: > > > I am not sure there is an answer. This is just how we handled it before. > > IMO both approaches works fine. BTW, I already merged Vyacheslav's PR > > several hours ago. > > > > On Wed, Oct 10, 2018 at 1:24 PM Igor Sapego wrote: > > > >> Vyacheslav, > >> > >> In this case, we should do the same with all existing doxygen > >> files, not only this one (see files with .dxg extension) > >> > >> Vova, Pavel, > >> > >> Were there historically any reasons to exclude doxygen files > >> from check instead of adding a license header? > >> > >> Best Regards, > >> Igor > >> > >> > >> On Tue, Oct 9, 2018 at 11:49 PM Vyacheslav Daradur > > >> wrote: > >> > >>> Great work guys, thanks! > >>> > >>> I've noticed TC fails in the build plan "Licenses Headers" which Igor > >>> have fixed already by excluding Doxyfile from checking. > >>> > >>> I've filled a ticket [1] and I'd suggest fixing the test in another > >>> way by adding the license header to Doxyfile. > >>> > >>> Igor, please, have a look at prepared PR [2] (tests passed [3]). > >>> > >>> [1] https://issues.apache.org/jira/browse/IGNITE-9832 > >>> [2] https://github.com/apache/ignite/pull/4938/files > >>> [3] https://ci.ignite.apache.org/viewLog.html?buildId=2046206 > >>> On Tue, Oct 9, 2018 at 6:31 PM Igor Sapego wrote: > >>> > > >>> > As the seem to be everything OK with the code and tests and > >>> > no one had any comment for quite some time, I've merged the > >>> > PHP to Ignite's master. > >>> > > >>> > Great job, guys! > >>> > > >>> > > >>> > Best Regards, > >>> > Igor > >>> > > >>> > > >>> > On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg > >>> wrote: > >>> > > >>> > > Hi Stephan, Alexey > >>> > > > >>> > > That's exactly what readme.io contains - installation > instructions, > >>> > > configuration, and examples for key-value, sql, etc. for thin > >>> clients. For > >>> > > example, see these documentation pages for Node.js (currently > hidden > >>> in the > >>> > > latest version of the doc) : > >>> > > > >>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client > >>> > > > >>> > > > >>> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration > >>> > > > >>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value > >>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql > >>> > > > >>> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types > >>> > > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security > >>> > > > >>> > > This how Python and PHP thin clients will also be documented on > >>> readme.io > >>> > > > >>> > > -Prachi > >>> > > > >>> > > > >>> > > > >>> > > > >>> > > On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov < > >>> > > pilshchikov@gmail.com> wrote: > >>> > > > >>> > > > > You know, I'm confused with all this documentation stuff... > >>> > > > > For nodejs client all docs were moved from the repo to > readme.io > >>> but > >>> > > > the > >>> > > > > readme.md keeps the installation instructions (duplicated with > >>> > > > > readme.io). Probably, that's ok. > >>> > > > > Will add similar short readme.md to the PHP PR. > >>> > > > > >>> > > > Its good > >>> > > > > >>> > > > What i think (and how it partially now): > >>> > > > All user documentation should be on readme.io (how to install, > >>> use it, > >>> > > > configurate, description for examples) > >>> > > > All developers documentation (how to release, how to start > develop) > >>> > > and(!) > >>> > > > basic description should be in repository > >>> > > > > >>> > > > > >>> > > > > >>> > > > > >>> > > > -- > >>> > > > Sent from: > http://apache-ignite-developers.2346864.n4.nabble.com/ > >>> > > > > >>> > > > >>> > >>> > >>> > >>> -- > >>> Best Regards, Vyacheslav D. > >>> > >> >
[jira] [Created] (IGNITE-9952) Failed to process write update request in FULL_ASYNC mode
Artem Zinnatullin created IGNITE-9952: - Summary: Failed to process write update request in FULL_ASYNC mode Key: IGNITE-9952 URL: https://issues.apache.org/jira/browse/IGNITE-9952 Project: Ignite Issue Type: Bug Affects Versions: 2.6 Environment: * Kubernetes * Official Ignite 2.6.0 Docker image Reporter: Artem Zinnatullin Cluster of 12 Ignite server nodes, 4 client nodes. Following cache configuration: {code:java} {code} Ignite is only used as key/value cache. Periodically these exceptions can be found in Ignite server nodes logs: {code:java} [23:17:23,586][INFO][grid-timeout-worker-#23][IgniteKernal] FreeList [name=null, buckets=256, dataPages=32070, reusePages=1435] [23:17:28,586][INFO][grid-timeout-worker-#23][IgniteKernal] Metrics for local node (to disable set 'metricsLogFrequency' to 0) ^-- Node [id=37ea392d, uptime=51:52:58.760] ^-- H/N/C [hosts=16, nodes=16, CPUs=128] ^-- CPU [cur=0.4%, avg=0.44%, GC=0%] ^-- PageMemory [pages=2827437] ^-- Heap [used=1866MB, free=63.54%, comm=5120MB] ^-- Non heap [used=94MB, free=-1%, comm=95MB] ^-- Outbound messages queue [size=0] ^-- Public thread pool [active=0, idle=2, qSize=0] ^-- System thread pool [active=0, idle=8, qSize=0] [23:17:28,586][INFO][grid-timeout-worker-#23][IgniteKernal] FreeList [name=null, buckets=256, dataPages=31943, reusePages=1435] [23:17:30,506][SEVERE][sys-stripe-5-#6][GridDhtAtomicCache] Unexpected exception during cache update java.lang.NullPointerException [23:17:30,506][SEVERE][sys-stripe-5-#6][GridDhtAtomicCache] Failed to process write update request in FULL_ASYNC mode for keys: [KeyCacheObjectImpl [part=637, val=b/cb65d27d2837d6864edb03cce62aa9c29c540669, hasValBytes=true]] class org.apache.ignite.IgniteCheckedException: Failed to update keys on primary node. at org.apache.ignite.internal.processors.cache.distributed.dht.atomic.UpdateErrors.addFailedKeys(UpdateErrors.java:124) at org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateResponse.addFailedKeys(GridNearAtomicUpdateResponse.java:342) at org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache.updateAllAsyncInternal0(GridDhtAtomicCache.java:1785) at org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache.updateAllAsyncInternal(GridDhtAtomicCache.java:1628) at org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache.processNearAtomicUpdateRequest(GridDhtAtomicCache.java:3056) at org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache.access$400(GridDhtAtomicCache.java:130) at org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache$5.apply(GridDhtAtomicCache.java:266) at org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache$5.apply(GridDhtAtomicCache.java:261) at org.apache.ignite.internal.processors.cache.GridCacheIoManager.processMessage(GridCacheIoManager.java:1054) at org.apache.ignite.internal.processors.cache.GridCacheIoManager.onMessage0(GridCacheIoManager.java:579) at org.apache.ignite.internal.processors.cache.GridCacheIoManager.handleMessage(GridCacheIoManager.java:378) at org.apache.ignite.internal.processors.cache.GridCacheIoManager.handleMessage(GridCacheIoManager.java:304) at org.apache.ignite.internal.processors.cache.GridCacheIoManager.access$100(GridCacheIoManager.java:99) at org.apache.ignite.internal.processors.cache.GridCacheIoManager$1.onMessage(GridCacheIoManager.java:293) at org.apache.ignite.internal.managers.communication.GridIoManager.invokeListener(GridIoManager.java:1556) at org.apache.ignite.internal.managers.communication.GridIoManager.processRegularMessage0(GridIoManager.java:1184) at org.apache.ignite.internal.managers.communication.GridIoManager.access$4200(GridIoManager.java:125) at org.apache.ignite.internal.managers.communication.GridIoManager$9.run(GridIoManager.java:1091) at org.apache.ignite.internal.util.StripedExecutor$Stripe.run(StripedExecutor.java:511) at java.lang.Thread.run(Thread.java:748) Suppressed: java.lang.NullPointerException [23:17:33,588][INFO][grid-timeout-worker-#23][IgniteKernal] Metrics for local node (to disable set 'metricsLogFrequency' to 0) ^-- Node [id=37ea392d, uptime=51:53:03.763] ^-- H/N/C [hosts=16, nodes=16, CPUs=128] ^-- CPU [cur=1.67%, avg=0.44%, GC=0%] ^-- PageMemory [pages=2827437] ^-- Heap [used=2123MB, free=58.52%, comm=5120MB] ^-- Non heap [used=94MB, free=-1%, comm=95MB] ^-- Outbound messages queue [size=0] ^-- Public thread pool [active=0,
[jira] [Created] (IGNITE-9953) Dropping hadoop accelerator downloads
Denis Magda created IGNITE-9953: --- Summary: Dropping hadoop accelerator downloads Key: IGNITE-9953 URL: https://issues.apache.org/jira/browse/IGNITE-9953 Project: Ignite Issue Type: Task Components: hadoop Reporter: Denis Magda Assignee: Peter Ivanov Fix For: 2.7 The community agreed to drop the Hadoop distributions of Apache Ignite. Note, that it does not mean dropping any features. We are still going to support IGFS, in-memory map reduce, spark integration, etc. However, the hadoop-accelerator downloadable is putting extra pressure on the community to test and document, which can be avoided. All the features will still be supported through regular Ignite distribution. Discussion: http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-Dropping-hadoop-accelerator-download-td36617.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [DISCUSS] Dropping hadoop-accelerator download
Here it is: https://issues.apache.org/jira/browse/IGNITE-9953 -- Denis On Fri, Oct 19, 2018 at 2:34 AM Petr Ivanov wrote: > Can you file an issue then, please? > > > > On 19 Oct 2018, at 04:04, Denis Magda wrote: > > > > I would do this if it doesn't impact the release time. > > > > -- > > Denis > > > > On Thu, Oct 18, 2018 at 2:34 AM Petr Ivanov wrote: > > > >> Can we drop Hadoop binaries from delivery this release (2.7) or should > it > >> be moved to next? > >> > >> > >>> On 18 Oct 2018, at 04:38, Denis Magda wrote: > >>> > >>> No objections from my side. > >>> > >>> -- > >>> Denis > >>> > >>> > >>> On Tue, Oct 16, 2018 at 4:45 PM Dmitriy Setrakyan < > dsetrak...@apache.org > >>> > >>> wrote: > >>> > Igniters, > > I would like to suggest dropping the hadoop accelerator distribution > of > Apache Ignite. Note, that it does not mean dropping any features. We > are > still going to support IGFS, in-memory map reduce, spark integration, > >> etc. > However, the hadoop-accelerator downloadable is putting extra pressure > >> on > the community to test and document, which can be avoided. All the > >> features > will still be supported through regular Ignite distribution. > > Any objections? > > D. > > >> > >> > >
Re: Apache Ignite 2.7. Last Mile
Guys, as a side observer of the current release, this all looks like a never ending story :) When are we sending a release candidate for vote? -- Denis On Fri, Oct 19, 2018 at 4:39 AM Nikolay Izhikov wrote: > Hello, Igniters. > > We have 6 tickets for 2.7 > > Roman Kondakov - IGNITE-9892, IGNITE-9663, IGNITE-9928 > Igor Seliverstov - IGNITE-9911 > Ivan Pavlukhin - IGNITE-5935, IGNITE-9944 > > В Чт, 18/10/2018 в 15:40 +0300, Andrey Kuznetsov пишет: > > I have got one more potential 2.7 blocker [1] with straightforward fix. I > > beleive it will not break any production use case, but it leads to test > > suite hang, thus affecting other urgent issues. > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9932 > > > > чт, 18 окт. 2018 г. в 14:59, Ivan Daschinsky : > > > > > Hi! Is it possible to merge IGNITE-9854? Fix is pretty simple, but > quite > > > important. > > > > > > ср, 17 окт. 2018 г. в 17:49, Andrey Gura : > > > > > > > JFYI > > > > > > > > IGNITE-9737 and IGNITE-9710 are merged to release branch. > > > > On Wed, Oct 17, 2018 at 5:41 PM Pavel Tupitsyn > > > > > wrote: > > > > > > > > > > Thank you. Fix has been merged to master and cherry-picked to > > > > > > ignite-2.7. > > > > > > > > > > On Wed, Oct 17, 2018 at 1:26 PM Nikolay Izhikov < > nizhi...@apache.org> > > > > > > > > wrote: > > > > > > > > > > > Pavel. > > > > > > > > > > > > Ok, I agree to include this ticket into 2.7 > > > > > > Let's do it. > > > > > > > > > > > > В Ср, 17/10/2018 в 13:20 +0300, Pavel Tupitsyn пишет: > > > > > > > Nikolay, > > > > > > > > > > > > > > It completely breaks a major feature under certain conditions. > I > > > > > > > > would > > > > > > > consider it a blocker. > > > > > > > > > > > > > > On Wed, Oct 17, 2018 at 1:00 PM Nikolay Izhikov < > > > > > > nizhi...@apache.org > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > Hello, Pavel. > > > > > > > > > > > > > > > > Is it a blocker? > > > > > > > > > > > > > > > > В Ср, 17/10/2018 в 12:58 +0300, Pavel Tupitsyn пишет: > > > > > > > > > Hi Igniters, > > > > > > > > > > > > > > > > > > I'd like to include IGNITE-9877 in 2.7, can we do that? > > > > > > > > > The fix is ready, I'm waiting for TC run. > > > > > > > > > > > > > > > > > > Pavel > > > > > > > > > > > > > > > > > > On Wed, Oct 17, 2018 at 11:45 AM Павлухин Иван < > > > > > > > > vololo...@gmail.com> > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > Hi NIkolay, > > > > > > > > > > > > > > > > > > > > Thank you for keeping everybody focused! Regarding to my > > > > > > ticket > > > > > > > > > > IGNITE-5935. > > > > > > > > > > It is in final stage now. Tests look good. I believe > that it > > > > > > > > will > > > > > > be > > > > > > > > > > > > > > > > merged > > > > > > > > > > in couple of days (at most). > > > > > > > > > > > > > > > > > > > > ср, 17 окт. 2018 г. в 11:39, Nikolay Izhikov < > > > > > > > > nizhi...@apache.org > > > > > > > : > > > > > > > > > > > > > > > > > > > > > Hello, Igniters. > > > > > > > > > > > > > > > > > > > > > > 9 tickets to go! > > > > > > > > > > > > > > > > > > > > > > Alexey Goncharuk - IGNITE-9784 > > > > > > > > > > > Dmitriy Govorukhin - IGNITE-9898 > > > > > > > > > > > Andrey Kuznetsov - IGNITE-9737, IGNITE-9710 > > > > > > > > > > > Taras Ledkov - IGNITE-9882 > > > > > > > > > > > Petr Ivanov - IGNITE-9852 > > > > > > > > > > > Ivan Pavlukhin - IGNITE-5935 > > > > > > > > > > > Roman Kondakov - IGNITE-9663 > > > > > > > > > > > Alexey Stelmak - IGNITE-9776 > > > > > > > > > > > > > > > > > > > > > > В Вт, 16/10/2018 в 16:20 +0300, Andrey Gura пишет: > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > > > > > > > I've found that IGNITE-9723 was resolved but didn't > > > > > > cherry > > > > > > picked > > > > > > > > > > > > > > > > to > > > > > > > > > > > > ignite-2.7 branch. So I'll do it. > > > > > > > > > > > > On Tue, Oct 16, 2018 at 2:30 PM Nikolay Izhikov < > > > > > > > > > > > > > > > > nizhi...@apache.org> > > > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > Hello, Igniters. > > > > > > > > > > > > > > > > > > > > > > > > > > We have 13 tickets mapped to 2.7. > > > > > > > > > > > > > All tickets assigned to some contributor. > > > > > > > > > > > > > > > > > > > > > > > > > > Alexey Gonchruk - IGNITE-9784, IGNITE-9895 > > > > > > > > > > > > > Vladimir Ozerov - IGNITE-9887 > > > > > > > > > > > > > Dmitriy Govorukhin - IGNITE-9898 > > > > > > > > > > > > > Andrey Kuznetsov - IGNITE-9737, IGNITE-9710 > > > > > > > > > > > > > Petr Ivanov - IGNITE-9852 > > > > > > > > > > > > > Ivan Pavlukhin - IGNITE-5935 > > > > > > > > > > > > > Alexey Stelmak - IGNITE-9776 > > > > > > > > > > > > > Roman Kondakov - IGNITE-9663 > > > > > > > > > > > > > Taras Ledkov - IGNITE-9864 > > > > > > > > > > > > > Igor Seliverstov - IGNITE-9292 > > > > > > > > > > > > > > > > > > > > > > > > > > В Пн, 15/10/2018 в 17:49 +0300, Andrey Gura пи
[GitHub] ignite pull request #5041: IGNITE-9950
GitHub user dmelnichuk opened a pull request: https://github.com/apache/ignite/pull/5041 IGNITE-9950 Fix decimal format. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nobitlost/ignite ignite-9950 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5041.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5041 commit 4b444dff62c04b97bc2cdb0676ad52880374 Author: ekaterina-nbl Date: 2018-03-20T21:12:21Z initial implementation commit d1e8014c80f698028d23e09cafd7ea190ac3e929 Author: ekaterina-nbl Date: 2018-03-20T21:32:52Z initial implementation commit f79229e233ffa7bff1e7c22f04749924af6d712a Author: ekaterina-nbl Date: 2018-03-22T09:39:32Z initial implementation commit 658d60b58840080b664e02815f4ba6aac76e5804 Author: ekaterina-nbl Date: 2018-03-22T16:52:18Z minor update commit 617cef12ad72791c7e7e67179e1b0c3f7f3ae6bb Author: ekaterina-nbl Date: 2018-03-25T13:33:27Z api spec commit d9729585f5a901977e2a2e40e86a2b715fab79fa Author: alexey-nbl Date: 2018-03-25T21:27:11Z link to api_spec added commit ea847eba62e556fa81cbf9838ffe17af60f464e4 Author: ekaterina-nbl Date: 2018-03-31T22:07:50Z error types modified commit c2ad53fe625cc3a05155eeef318421538830 Author: ekaterina-nbl Date: 2018-03-31T23:41:56Z client states commit 6d2233864b4d891361d38a7143846570bd6c0ef6 Author: ekaterina-nbl Date: 2018-04-01T13:11:27Z object types improvement commit 52fbc5f87143da068596141cb59b17b684fd2c1f Author: ekaterina-nbl Date: 2018-04-02T16:59:52Z complex objects commit cae5a28e7e0d610434debcc140738e2f48d061cf Author: ekaterina-nbl Date: 2018-04-02T20:13:00Z object types improvement commit 3165405d4eae09519dc9b5f40f162eb74a9b3c5d Author: ekaterina-nbl Date: 2018-04-02T21:21:26Z client states commit fdbb8f86b32fe4c038d38620a80921be3038f31f Author: alexey-nbl Date: 2018-04-03T08:26:04Z Ignite client states described commit 04b946885db0ea2f6fe56a75e28302641dad5f61 Author: alexey-nbl Date: 2018-04-03T09:35:49Z minor update commit f4aaf1c3f23c82ba7974b4c571a9984748e5e82e Author: alexey-nbl Date: 2018-04-03T12:47:54Z Update ObjectType.js commit e4c8279f4e83b3ed13383420ab3d1417b090a3fa Author: ekaterina-nbl Date: 2018-04-03T13:46:19Z minor updates + api spec commit ed2e4ee830ca40a28dc31958665f52fab6a0bcdd Author: alexey-nbl Date: 2018-04-04T14:34:52Z Update ObjectType.js commit 7e1666eb5df82b622a028c0ea949fa21c79e66c2 Author: alexey-nbl Date: 2018-04-04T15:14:00Z Update ObjectType.js commit 7b0270d65b597dc1b0d164e78f07c3a21c37ca67 Author: ekaterina-nbl Date: 2018-04-08T17:16:43Z sql queries, key value ops commit fe90f53fd08f77add17fbf06d014f9a9b0a11c65 Author: alexey-nbl Date: 2018-04-08T18:31:47Z Update IgniteClient.js commit 04137bf5ec3b7077e194edd0100a01bb43f7933a Author: alexey-nbl Date: 2018-04-08T18:37:04Z Update CacheConfiguration.js commit b63ad5980718da1b0c44fa4ca138c6e85e47aef3 Author: alexey-nbl Date: 2018-04-08T19:11:11Z Update ObjectType.js commit 756b908c9dc38ae497e4d7d740f836dabed93e48 Author: alexey-nbl Date: 2018-04-08T22:41:54Z Update CacheClient.js commit e96ffee17298dd25d26a7029738132478271cf92 Author: ekaterina-nbl Date: 2018-04-08T23:23:33Z object array, minor updates commit c050e671f74232c4efc41f51c2018d08b152cbbc Author: alexey-nbl Date: 2018-04-09T21:04:35Z Update CacheClient.js commit 25052a4e93d6fcc0b0c4789fdd5a1eb85413b5a2 Author: alexey-nbl Date: 2018-04-09T22:43:50Z Update ObjectType.js commit c516b4147c10398d4f34d78a8830dd0fcb5f28f4 Author: alexey-nbl Date: 2018-04-10T11:50:13Z Update CacheClient.js commit 0e9924a0df8a1d41718fb929698b8e4416f2efa2 Author: ekaterina-nbl Date: 2018-04-10T13:21:16Z cache key value operations tests commit e09ee0e7969bffd6f4cfd11579f6d0ff9b486c99 Author: ekaterina-nbl Date: 2018-04-10T13:21:50Z Merge branch 'master' of https://github.com/nobitlost/ignite commit 15d2abce41b4f1c9d4d5fecd44a99a5393177482 Author: alexey-nbl Date: 2018-04-10T14:38:57Z Update Query.js ---
Re: Python thin client
Stepan, My bad. I got the Decimal part of Ignite thin client protocol specification totally wrong. Just submitted a patch tested against Java thin client. Please evaluate. On 10/20/18 2:00 AM, Stepan Pilschikov wrote: Dmitry, One more thing Discover that Decimal data type can't be getting by others clients Make ticket with description: https://issues.apache.org/jira/browse/IGNITE-9950 Please, can you help to investigate this problem? ср, 17 окт. 2018 г. в 23:14, Stepan Pilschikov : Dmitry, Great, now client works properly on all OS Thanks I hope PR will be merged soon Igor, can please help with that? ср, 17 окт. 2018 г. в 20:48, Dmitry Melnichuk < dmitry.melnic...@nobitlost.com>: Stepan, Sadly, it was a C `long` data type size mismatch between Windows and other OSes. I investigated this issue and offered a pull request. https://github.com/apache/ignite/pull/5017 On 10/17/18 6:29 PM, Stepan Pilschikov wrote: Dmitry, I've trying to use python thin client with Ignite 2.7 it dosn't work Please help to investigate Problem reproduced on several others machines Issue: https://issues.apache.org/jira/browse/IGNITE-9908
New TC builds adding process
Hi Igniters, On Friday I felt a real inconvenience (pain in ass) with running builds for a ticked I worked on [1]. There were two the most frustrating moments: 1. Estimated build completion time was 11 hours after the start. 2. There are newly added suites which are failing constantly in recent runs. I compared builds count in RunAll chain for mentioned ticked. On Oct 6 there were 105 builds, and on Oct 19 where were 113. Then I compared differences and found suspicious items. First of all there were 2 Windows suites PlatformNetCoverage [2] and PlatformCWindowsX86 [3]. Former seems to be something added recently and latter as I know was decided to be excluded from RunAll some time ago but strangely reappeared. I suspect that these 2 suites could increase build run time because they are quite lengthy and require Windows slaves which are in limited amount. Also there were 2 rather problematic builds InspectionsAop [4] and InspectionsCore [5] which seems to fail constantly. Presence of such builds brings a noise into analyzing build results. TC Bot treats them as possible blockers. So, here are my suggestions: 1. A contributor should add new build to RunAll after estimating build running time impact carefully. If impact is noticeable such builds should be announced and discussed on dev list. It sounds good idea to test drive new heavy build running it on a scheduled basis first before adding to RunAll. 2. We should not have constantly failing builds like mentioned Inspections. What are your thoughts? [1] https://issues.apache.org/jira/browse/IGNITE-5935 [2] https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_PlatformNetCoverage [3] https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_PlatformCWindowsX86 [4] https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_InspectionsAop [5] https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_InspectionsCore -- Best regards, Ivan Pavlukhin