[GitHub] SomeFire commented on a change in pull request #90: IGNITE-10203 Fix TC Bot visa on Jira
SomeFire commented on a change in pull request #90: IGNITE-10203 Fix TC Bot
visa on Jira
URL: https://github.com/apache/ignite-teamcity-bot/pull/90#discussion_r239363970
##
File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
##
@@ -499,7 +497,7 @@ function jiraTicketNumber(ticket) {
return regExpr.exec(ticket)[2];
}
-function commentJira(serverId, suiteId, branchName, ticketId) {
+function commentJira(serverId, branchName, suiteId, ticketId) {
Review comment:
`suiteId` to `parentSuiteId` (as in `triggerBuilds`).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #90: IGNITE-10203 Fix TC Bot visa on Jira
SomeFire commented on a change in pull request #90: IGNITE-10203 Fix TC Bot
visa on Jira
URL: https://github.com/apache/ignite-teamcity-bot/pull/90#discussion_r239358055
##
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/visa/TcBotTriggerAndSignOffService.java
##
@@ -394,8 +398,18 @@ String branchForTcB(String prId) {
ITeamcityIgnited teamcity = teamcityIgnitedProvider.server(srvId,
prov);
+StringBuilder buildTypeId = new StringBuilder();
+
+HelperConfig.getTrackedBranches().get(DEFAULT_TRACKED_BRANCH_NAME)
Review comment:
```suggestion
HelperConfig.getTrackedBranches().getBranchMandatory(DEFAULT_TRACKED_BRANCH_NAME)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #90: IGNITE-10203 Fix TC Bot visa on Jira
SomeFire commented on a change in pull request #90: IGNITE-10203 Fix TC Bot
visa on Jira
URL: https://github.com/apache/ignite-teamcity-bot/pull/90#discussion_r239362340
##
File path: ignite-tc-helper-web/src/main/webapp/js/common-1.6.js
##
@@ -5,17 +5,32 @@ function isDefinedAndFilled(val) {
return typeof val !== 'undefined' && val != null
}
-function findGetParameter(parameterName) {
-var result = null,
-tmp = [];
-location.search
-.substr(1)
-.split("&")
-.forEach(function(item) {
-tmp = item.split("=");
-if (tmp[0] === parameterName) result = decodeURIComponent(tmp[1]);
-});
-return result;
+/**
+ * Function return URL parameter from webUrl (if is defined and filled) or
from current location of the document.
+ *
+ * @returns {string | null} Search parameter or null.
+ * @param {String} parameterName - Search parameter name.
+ * @param {String | null} webUrl - URL.
+ */
+function findGetParameter(parameterName, webUrl) {
+if (isDefinedAndFilled(webUrl)) {
+let url = new URL(webUrl);
+
+return url.searchParams.get(parameterName);
+} else {
Review comment:
Redundant `else` statement.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #90: IGNITE-10203 Fix TC Bot visa on Jira
SomeFire commented on a change in pull request #90: IGNITE-10203 Fix TC Bot
visa on Jira
URL: https://github.com/apache/ignite-teamcity-bot/pull/90#discussion_r239358963
##
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/visa/TcBotTriggerAndSignOffService.java
##
@@ -394,8 +398,18 @@ String branchForTcB(String prId) {
ITeamcityIgnited teamcity = teamcityIgnitedProvider.server(srvId,
prov);
+StringBuilder buildTypeId = new StringBuilder();
+
+HelperConfig.getTrackedBranches().get(DEFAULT_TRACKED_BRANCH_NAME)
+.ifPresent(b -> b.getChainsStream().filter(c ->
c.branchForRest.equals(ITeamcity.DEFAULT))
+.findFirst().ifPresent(ch -> buildTypeId.append(ch.suiteId)));
+
+BuildTypeCompacted suite =
teamcity.getBuildType(buildTypeId.toString());
Review comment:
Rename `suite` to `buildType`, `compositeBuildTypes` to
`compositeBuildTypeIds`, `buildType` to `btId`. Don't forget to check string
lengths.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #90: IGNITE-10203 Fix TC Bot visa on Jira
SomeFire commented on a change in pull request #90: IGNITE-10203 Fix TC Bot
visa on Jira
URL: https://github.com/apache/ignite-teamcity-bot/pull/90#discussion_r239358055
##
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/visa/TcBotTriggerAndSignOffService.java
##
@@ -394,8 +398,18 @@ String branchForTcB(String prId) {
ITeamcityIgnited teamcity = teamcityIgnitedProvider.server(srvId,
prov);
+StringBuilder buildTypeId = new StringBuilder();
+
+HelperConfig.getTrackedBranches().get(DEFAULT_TRACKED_BRANCH_NAME)
Review comment:
```suggestion
HelperConfig.getTrackedBranches().getBranchMandatory(DEFAULT_TRACKED_BRANCH_NAME)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (IGNITE-10566) SQL: Map query should operate on it's own list of partitions
Vladimir Ozerov created IGNITE-10566:
Summary: SQL: Map query should operate on it's own list of
partitions
Key: IGNITE-10566
URL: https://issues.apache.org/jira/browse/IGNITE-10566
Project: Ignite
Issue Type: Task
Components: sql
Reporter: Vladimir Ozerov
Currently we merge extracted partitions from multiple map queries using {{OR}}
semantics. The this list is used for execution of all queries. That is,
consider that user's query was split into two map queries {{A}} and {{B}} with
target partitions {{1}} and {{2}} respectively. Instead of executing {{A -> 1}}
and {{B- > 2}} we will execute {{A -> 1, 2}} and {{B -> 1, 2}}, what leads to
waste of resources.
See {{GridH2QueryRequest#qryParts}} as a starting point.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (IGNITE-10567) SQL: Explicit and extracted partitions should be merged through AND semantics
Vladimir Ozerov created IGNITE-10567:
Summary: SQL: Explicit and extracted partitions should be merged
through AND semantics
Key: IGNITE-10567
URL: https://issues.apache.org/jira/browse/IGNITE-10567
Project: Ignite
Issue Type: Task
Components: sql
Reporter: Vladimir Ozerov
See {{IgniteH2Indexing.doRunDistributedQuery}}. Currently we process explicit
and extracted partitions as follows:
# If explicit partitions are set, then use them
# Otherwise use extracted partitions if available
Now consider that explicit partitions are set to {{A, B}} and extracted
partitions are {{B, C}}. Currently we will execute query over {{A, B}}, while
in reality it seems that we can execute it only on {{B}} (intersection).
In extreme case intersection will be an empty set, so query execution might be
skipped altogether.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: Default failure handler was changed for tests
Nikolay, I meant "not expensive" by "cheap". And I meant that it is good that it cheap =). And I said it to contrast with "expensive" ~100 tests investigation. And if we agree (mostly I would like an opinion from Dmitriy Ryabov as an original author) on a way how to improve the patch then let's do it. чт, 6 дек. 2018 г. в 10:41, Nikolay Izhikov : > > Dmitriy Ryabov, Dmitriy Pavlov, sorry. > > Of course it should be "NOT to blame author". > > Sorry, one more time. > > чт, 6 дек. 2018 г., 10:40 Dmitriy Pavlov dpav...@apache.org: > > > I hope you've misprinted here > > > I'm here to blame the author. > > > > We can blame code but never coders. > > > > Please see https://discourse.pi-hole.net/faq - has absolutely nothing in > > common with Apache Guides, but says the same things. It is a practical > > necessity to maintain a friendly atmosphere. > > > > чт, 6 дек. 2018 г. в 10:31, Nikolay Izhikov : > > > > > Ivan. > > > > > > > 1. Accept the patch and bring an improvement to Ignite (and create a> > > > ticket for further investigation). > > > > > > I support this idea. > > > Do we create the tickets already? > > > > > > > Nikolay's patch [1] suggests a slightly different approach how to the > > > > same thing. And implementing that idea looks like a cheap refactoring. > > > > > > I don't agree with your term "cheap". > > > Do you think reducing copy paste code not worth it? > > > > > > I see a hundreds issues that bring copypasted code in the product(Ignite > > > and others). > > > I insist, that we shouldn't accept patches with it. > > > > > > I'm here to blame the author. > > > I want to improve this patch and make it easier to find all places with > > > NoOp handler to do the further investigation. > > > > > > В Чт, 06/12/2018 в 10:19 +0300, Павлухин Иван пишет: > > > > Guys, > > > > > > > > I asked what harm will applying the patch bring I have not got a > > > > direct answer. But I think I got some pain points: > > > > 1. Anton does not like that reasons why ~100 tests require noop > > > > handler are not clear. And might be several problems are covered > > > > there. > > > > 2. Nikolay suggests some code improvements. > > > > > > > > Nikolay's patch [1] suggests a slightly different approach how to the > > > > same thing. And implementing that idea looks like a cheap refactoring. > > > > But the idea of course could be discussed. Straight away I can suggest > > > > another slightly different trick [2]. > > > > > > > > Investigating why ~100 tests require noop handler could be costly. So, > > > > in that direction I see following options which can happen for sure: > > > > 1. Accept the patch and bring an improvement to Ignite (and create a > > > > ticket for further investigation). > > > > 2. Revert the patch and loose an improvement. > > > > > > > > One might say that there is an option "Revert the patch and then do it > > > > better" but I does not see anything (anyone) what can guarantee it. > > > > So, I personally prefer an option 1 against 2 because I believe that > > > > it is good if the system "can make a progress". > > > > > > > > [1] https://github.com/apache/ignite/pull/5584/files > > > > [2] https://github.com/apache/ignite/pull/5586/files > > > > ср, 5 дек. 2018 г. в 21:22, Nikolay Izhikov : > > > > > > > > > > Dmitriy. > > > > > > > > > > > The closest analog to Noop handler is mute of test failure. > > > > > > By this commit, we had unmuted (possible) failures in > > > ~5-~100=~49900 > > > > > > > > > > tests, and we’re still concerned about style or minor details if > > no-op > > > was > > > > > copy-pasted, aren’t we? > > > > > > > > > > Can you explain this idea a bit more? > > > > > I don't understand what is unmuted by discussed commit. > > > > > > > > > > ср, 5 дек. 2018 г. в 20:40, Nikolay Izhikov : > > > > > > > > > > > > Thanks, as an improvement to the code, this may be better. > > > > > > > > > > > > I can prepare a full patch for NoOp handler. > > > > > > What do you think? > > > > > > > > > > > > Anton Vinogradov, do you agree with this approach? > > > > > > > > > > > > > > > > > > > > > > > > ср, 5 дек. 2018 г. в 20:33, Dmitriy Pavlov : > > > > > > > > > > > > > Thanks, as an improvement to the code, this may be better. But > > > still, it > > > > > > > is > > > > > > > not a reason to revert. And Anton mentioned something with better > > > > > > > exception > > > > > > > handling/logging. Probably we will see an implementation as well. > > > > > > > > > > > > > > This case here is a big thing related to The Apache Way, - and > > I'll > > > > > > > explain > > > > > > > why it makes me switched into fight-mode - until we stop this > > > nonsense. If > > > > > > > PMCs (at least) are aware of patterns and anti-patterns in the > > > community, > > > > > > > we will succeed as a project much more as with (only) perfect > > code. > > > > > > > > > > > > > > The closest analog to Noop handler is mute of test failure. By > > this > > > > > > > commit, > > > > > > > we had unmu
[GitHub] ignite pull request #5454: IGNITE-10356 JDBC thin driver returns wrong data ...
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/5454 ---
Re: Default failure handler was changed for tests
Ivan, Got it. Thanks for the explanation. > mostly I would like an opinion from Dmitriy Ryabov as an original author Dmitriy, can you answer? I can do this improvement by myself, by if you want to do it - go ahead. чт, 6 дек. 2018 г. в 12:11, Павлухин Иван : > Nikolay, > > I meant "not expensive" by "cheap". And I meant that it is good that > it cheap =). And I said it to contrast with "expensive" ~100 tests > investigation. And if we agree (mostly I would like an opinion from > Dmitriy Ryabov as an original author) on a way how to improve the > patch then let's do it. > чт, 6 дек. 2018 г. в 10:41, Nikolay Izhikov : > > > > Dmitriy Ryabov, Dmitriy Pavlov, sorry. > > > > Of course it should be "NOT to blame author". > > > > Sorry, one more time. > > > > чт, 6 дек. 2018 г., 10:40 Dmitriy Pavlov dpav...@apache.org: > > > > > I hope you've misprinted here > > > > I'm here to blame the author. > > > > > > We can blame code but never coders. > > > > > > Please see https://discourse.pi-hole.net/faq - has absolutely nothing > in > > > common with Apache Guides, but says the same things. It is a practical > > > necessity to maintain a friendly atmosphere. > > > > > > чт, 6 дек. 2018 г. в 10:31, Nikolay Izhikov : > > > > > > > Ivan. > > > > > > > > > 1. Accept the patch and bring an improvement to Ignite (and create > a> > > > > ticket for further investigation). > > > > > > > > I support this idea. > > > > Do we create the tickets already? > > > > > > > > > Nikolay's patch [1] suggests a slightly different approach how to > the > > > > > same thing. And implementing that idea looks like a cheap > refactoring. > > > > > > > > I don't agree with your term "cheap". > > > > Do you think reducing copy paste code not worth it? > > > > > > > > I see a hundreds issues that bring copypasted code in the > product(Ignite > > > > and others). > > > > I insist, that we shouldn't accept patches with it. > > > > > > > > I'm here to blame the author. > > > > I want to improve this patch and make it easier to find all places > with > > > > NoOp handler to do the further investigation. > > > > > > > > В Чт, 06/12/2018 в 10:19 +0300, Павлухин Иван пишет: > > > > > Guys, > > > > > > > > > > I asked what harm will applying the patch bring I have not got a > > > > > direct answer. But I think I got some pain points: > > > > > 1. Anton does not like that reasons why ~100 tests require noop > > > > > handler are not clear. And might be several problems are covered > > > > > there. > > > > > 2. Nikolay suggests some code improvements. > > > > > > > > > > Nikolay's patch [1] suggests a slightly different approach how to > the > > > > > same thing. And implementing that idea looks like a cheap > refactoring. > > > > > But the idea of course could be discussed. Straight away I can > suggest > > > > > another slightly different trick [2]. > > > > > > > > > > Investigating why ~100 tests require noop handler could be costly. > So, > > > > > in that direction I see following options which can happen for > sure: > > > > > 1. Accept the patch and bring an improvement to Ignite (and create > a > > > > > ticket for further investigation). > > > > > 2. Revert the patch and loose an improvement. > > > > > > > > > > One might say that there is an option "Revert the patch and then > do it > > > > > better" but I does not see anything (anyone) what can guarantee it. > > > > > So, I personally prefer an option 1 against 2 because I believe > that > > > > > it is good if the system "can make a progress". > > > > > > > > > > [1] https://github.com/apache/ignite/pull/5584/files > > > > > [2] https://github.com/apache/ignite/pull/5586/files > > > > > ср, 5 дек. 2018 г. в 21:22, Nikolay Izhikov : > > > > > > > > > > > > Dmitriy. > > > > > > > > > > > > > The closest analog to Noop handler is mute of test failure. > > > > > > > By this commit, we had unmuted (possible) failures in > > > > ~5-~100=~49900 > > > > > > > > > > > > tests, and we’re still concerned about style or minor details if > > > no-op > > > > was > > > > > > copy-pasted, aren’t we? > > > > > > > > > > > > Can you explain this idea a bit more? > > > > > > I don't understand what is unmuted by discussed commit. > > > > > > > > > > > > ср, 5 дек. 2018 г. в 20:40, Nikolay Izhikov >: > > > > > > > > > > > > > > Thanks, as an improvement to the code, this may be better. > > > > > > > > > > > > > > I can prepare a full patch for NoOp handler. > > > > > > > What do you think? > > > > > > > > > > > > > > Anton Vinogradov, do you agree with this approach? > > > > > > > > > > > > > > > > > > > > > > > > > > > > ср, 5 дек. 2018 г. в 20:33, Dmitriy Pavlov >: > > > > > > > > > > > > > > > Thanks, as an improvement to the code, this may be better. > But > > > > still, it > > > > > > > > is > > > > > > > > not a reason to revert. And Anton mentioned something with > better > > > > > > > > exception > > > > > > > > handling/logging. Probably we will see an implementation as > well. > > > > > > > >
Re: Default failure handler was changed for tests
Folks, thank's everyone for solution research. I'm ok with Nikolay approach in case that's not a final step. On Thu, Dec 6, 2018 at 12:11 PM Павлухин Иван wrote: > Nikolay, > > I meant "not expensive" by "cheap". And I meant that it is good that > it cheap =). And I said it to contrast with "expensive" ~100 tests > investigation. And if we agree (mostly I would like an opinion from > Dmitriy Ryabov as an original author) on a way how to improve the > patch then let's do it. > чт, 6 дек. 2018 г. в 10:41, Nikolay Izhikov : > > > > Dmitriy Ryabov, Dmitriy Pavlov, sorry. > > > > Of course it should be "NOT to blame author". > > > > Sorry, one more time. > > > > чт, 6 дек. 2018 г., 10:40 Dmitriy Pavlov dpav...@apache.org: > > > > > I hope you've misprinted here > > > > I'm here to blame the author. > > > > > > We can blame code but never coders. > > > > > > Please see https://discourse.pi-hole.net/faq - has absolutely nothing > in > > > common with Apache Guides, but says the same things. It is a practical > > > necessity to maintain a friendly atmosphere. > > > > > > чт, 6 дек. 2018 г. в 10:31, Nikolay Izhikov : > > > > > > > Ivan. > > > > > > > > > 1. Accept the patch and bring an improvement to Ignite (and create > a> > > > > ticket for further investigation). > > > > > > > > I support this idea. > > > > Do we create the tickets already? > > > > > > > > > Nikolay's patch [1] suggests a slightly different approach how to > the > > > > > same thing. And implementing that idea looks like a cheap > refactoring. > > > > > > > > I don't agree with your term "cheap". > > > > Do you think reducing copy paste code not worth it? > > > > > > > > I see a hundreds issues that bring copypasted code in the > product(Ignite > > > > and others). > > > > I insist, that we shouldn't accept patches with it. > > > > > > > > I'm here to blame the author. > > > > I want to improve this patch and make it easier to find all places > with > > > > NoOp handler to do the further investigation. > > > > > > > > В Чт, 06/12/2018 в 10:19 +0300, Павлухин Иван пишет: > > > > > Guys, > > > > > > > > > > I asked what harm will applying the patch bring I have not got a > > > > > direct answer. But I think I got some pain points: > > > > > 1. Anton does not like that reasons why ~100 tests require noop > > > > > handler are not clear. And might be several problems are covered > > > > > there. > > > > > 2. Nikolay suggests some code improvements. > > > > > > > > > > Nikolay's patch [1] suggests a slightly different approach how to > the > > > > > same thing. And implementing that idea looks like a cheap > refactoring. > > > > > But the idea of course could be discussed. Straight away I can > suggest > > > > > another slightly different trick [2]. > > > > > > > > > > Investigating why ~100 tests require noop handler could be costly. > So, > > > > > in that direction I see following options which can happen for > sure: > > > > > 1. Accept the patch and bring an improvement to Ignite (and create > a > > > > > ticket for further investigation). > > > > > 2. Revert the patch and loose an improvement. > > > > > > > > > > One might say that there is an option "Revert the patch and then > do it > > > > > better" but I does not see anything (anyone) what can guarantee it. > > > > > So, I personally prefer an option 1 against 2 because I believe > that > > > > > it is good if the system "can make a progress". > > > > > > > > > > [1] https://github.com/apache/ignite/pull/5584/files > > > > > [2] https://github.com/apache/ignite/pull/5586/files > > > > > ср, 5 дек. 2018 г. в 21:22, Nikolay Izhikov : > > > > > > > > > > > > Dmitriy. > > > > > > > > > > > > > The closest analog to Noop handler is mute of test failure. > > > > > > > By this commit, we had unmuted (possible) failures in > > > > ~5-~100=~49900 > > > > > > > > > > > > tests, and we’re still concerned about style or minor details if > > > no-op > > > > was > > > > > > copy-pasted, aren’t we? > > > > > > > > > > > > Can you explain this idea a bit more? > > > > > > I don't understand what is unmuted by discussed commit. > > > > > > > > > > > > ср, 5 дек. 2018 г. в 20:40, Nikolay Izhikov >: > > > > > > > > > > > > > > Thanks, as an improvement to the code, this may be better. > > > > > > > > > > > > > > I can prepare a full patch for NoOp handler. > > > > > > > What do you think? > > > > > > > > > > > > > > Anton Vinogradov, do you agree with this approach? > > > > > > > > > > > > > > > > > > > > > > > > > > > > ср, 5 дек. 2018 г. в 20:33, Dmitriy Pavlov >: > > > > > > > > > > > > > > > Thanks, as an improvement to the code, this may be better. > But > > > > still, it > > > > > > > > is > > > > > > > > not a reason to revert. And Anton mentioned something with > better > > > > > > > > exception > > > > > > > > handling/logging. Probably we will see an implementation as > well. > > > > > > > > > > > > > > > > This case here is a big thing related to The Apache Way, - > and > > > I'll > > > >
[jira] [Created] (IGNITE-10568) [TC Bot] Replace type for test id from long by String
Ryabov Dmitrii created IGNITE-10568: --- Summary: [TC Bot] Replace type for test id from long by String Key: IGNITE-10568 URL: https://issues.apache.org/jira/browse/IGNITE-10568 Project: Ignite Issue Type: Task Reporter: Ryabov Dmitrii Assignee: Ryabov Dmitrii JS long type have less bits for long numbers, so we loose last digits of the number. We should use string instead of long for requests, but keep long for cached objects. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] SomeFire opened a new pull request #91: IGNITE-10568 Replace type for test id from long to String
SomeFire opened a new pull request #91: IGNITE-10568 Replace type for test id from long to String URL: https://github.com/apache/ignite-teamcity-bot/pull/91 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Default failure handler was changed for tests
Ivan, I think `Workarounds` class isn't good idea, because it looks like we create stable workarounds, which will never be fixed. I agree with Nikolay's solution. If no one minds, I'll create ticket for appropriate changes and recheck issues. чт, 6 дек. 2018 г., 12:17 Anton Vinogradov a...@apache.org: > Folks, thank's everyone for solution research. > I'm ok with Nikolay approach in case that's not a final step. > > On Thu, Dec 6, 2018 at 12:11 PM Павлухин Иван wrote: > > > Nikolay, > > > > I meant "not expensive" by "cheap". And I meant that it is good that > > it cheap =). And I said it to contrast with "expensive" ~100 tests > > investigation. And if we agree (mostly I would like an opinion from > > Dmitriy Ryabov as an original author) on a way how to improve the > > patch then let's do it. > > чт, 6 дек. 2018 г. в 10:41, Nikolay Izhikov : > > > > > > Dmitriy Ryabov, Dmitriy Pavlov, sorry. > > > > > > Of course it should be "NOT to blame author". > > > > > > Sorry, one more time. > > > > > > чт, 6 дек. 2018 г., 10:40 Dmitriy Pavlov dpav...@apache.org: > > > > > > > I hope you've misprinted here > > > > > I'm here to blame the author. > > > > > > > > We can blame code but never coders. > > > > > > > > Please see https://discourse.pi-hole.net/faq - has absolutely > nothing > > in > > > > common with Apache Guides, but says the same things. It is a > practical > > > > necessity to maintain a friendly atmosphere. > > > > > > > > чт, 6 дек. 2018 г. в 10:31, Nikolay Izhikov : > > > > > > > > > Ivan. > > > > > > > > > > > 1. Accept the patch and bring an improvement to Ignite (and > create > > a> > > > > > ticket for further investigation). > > > > > > > > > > I support this idea. > > > > > Do we create the tickets already? > > > > > > > > > > > Nikolay's patch [1] suggests a slightly different approach how to > > the > > > > > > same thing. And implementing that idea looks like a cheap > > refactoring. > > > > > > > > > > I don't agree with your term "cheap". > > > > > Do you think reducing copy paste code not worth it? > > > > > > > > > > I see a hundreds issues that bring copypasted code in the > > product(Ignite > > > > > and others). > > > > > I insist, that we shouldn't accept patches with it. > > > > > > > > > > I'm here to blame the author. > > > > > I want to improve this patch and make it easier to find all places > > with > > > > > NoOp handler to do the further investigation. > > > > > > > > > > В Чт, 06/12/2018 в 10:19 +0300, Павлухин Иван пишет: > > > > > > Guys, > > > > > > > > > > > > I asked what harm will applying the patch bring I have not got a > > > > > > direct answer. But I think I got some pain points: > > > > > > 1. Anton does not like that reasons why ~100 tests require noop > > > > > > handler are not clear. And might be several problems are covered > > > > > > there. > > > > > > 2. Nikolay suggests some code improvements. > > > > > > > > > > > > Nikolay's patch [1] suggests a slightly different approach how to > > the > > > > > > same thing. And implementing that idea looks like a cheap > > refactoring. > > > > > > But the idea of course could be discussed. Straight away I can > > suggest > > > > > > another slightly different trick [2]. > > > > > > > > > > > > Investigating why ~100 tests require noop handler could be > costly. > > So, > > > > > > in that direction I see following options which can happen for > > sure: > > > > > > 1. Accept the patch and bring an improvement to Ignite (and > create > > a > > > > > > ticket for further investigation). > > > > > > 2. Revert the patch and loose an improvement. > > > > > > > > > > > > One might say that there is an option "Revert the patch and then > > do it > > > > > > better" but I does not see anything (anyone) what can guarantee > it. > > > > > > So, I personally prefer an option 1 against 2 because I believe > > that > > > > > > it is good if the system "can make a progress". > > > > > > > > > > > > [1] https://github.com/apache/ignite/pull/5584/files > > > > > > [2] https://github.com/apache/ignite/pull/5586/files > > > > > > ср, 5 дек. 2018 г. в 21:22, Nikolay Izhikov >: > > > > > > > > > > > > > > Dmitriy. > > > > > > > > > > > > > > > The closest analog to Noop handler is mute of test failure. > > > > > > > > By this commit, we had unmuted (possible) failures in > > > > > ~5-~100=~49900 > > > > > > > > > > > > > > tests, and we’re still concerned about style or minor details > if > > > > no-op > > > > > was > > > > > > > copy-pasted, aren’t we? > > > > > > > > > > > > > > Can you explain this idea a bit more? > > > > > > > I don't understand what is unmuted by discussed commit. > > > > > > > > > > > > > > ср, 5 дек. 2018 г. в 20:40, Nikolay Izhikov < > nizhi...@apache.org > > >: > > > > > > > > > > > > > > > > Thanks, as an improvement to the code, this may be better. > > > > > > > > > > > > > > > > I can prepare a full patch for NoOp handler. > > > > > > > > What do you think? > > > > > > > > > > > > > > > > Anton V
[jira] [Created] (IGNITE-10569) Null meta information when getting meta for a customized schema cache through JDBC driver
Ray created IGNITE-10569: Summary: Null meta information when getting meta for a customized schema cache through JDBC driver Key: IGNITE-10569 URL: https://issues.apache.org/jira/browse/IGNITE-10569 Project: Ignite Issue Type: Bug Components: jdbc Reporter: Ray Assignee: Ray Fix For: 2.8 When I create a cache with customized schema(not PUBLIC), then query the column meta information through thin JDBC driver it will return null. Analysis: The cases of schema name is different in GridQueryTypeDescriptor and CacaheConfiguration. So the schema validation if (!matches(table.schemaName(), req.schemaName())) in method JdbcRequestHandler.getColumnsMeta will not pass. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ignite pull request #5587: Ignite-10569 Null meta information when getting m...
GitHub user ldzhjn opened a pull request: https://github.com/apache/ignite/pull/5587 Ignite-10569 Null meta information when getting meta for a customized schema cache through JDBC driver You can merge this pull request into a Git repository by running: $ git pull https://github.com/ldzhjn/ignite IGNITE-10569 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5587.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5587 commit bcdb69747f9a90fa0f2f9204708c576b72f1de94 Author: rayliu Date: 2018-11-22T06:44:01Z Fix bug commit 8dcc21800a8eb7d1e731c362b4a53860274e85bd Author: rayliu Date: 2018-11-26T06:39:27Z Add tests commit 1d58fdf068b14ac9847a825dca3464148f9b7596 Author: rayliu Date: 2018-11-26T06:53:16Z Optimize imports commit 336a291dd5a330b5e1e824e807187ef1960bb843 Author: rayliu Date: 2018-11-26T07:01:47Z Merge remote-tracking branch 'upstream/master' into IGNITE-10314 commit 304695781ac356ec3f81325c5ce3b244b9f01c8b Author: rayliu Date: 2018-12-06T09:46:28Z Merge remote-tracking branch 'upstream/master' into IGNITE-10314 commit 4741b9c96c108a5ff705a98d4a81165497eaa5aa Author: rayliu Date: 2018-12-06T10:11:16Z Fix bug ---
[jira] [Created] (IGNITE-10570) Implement shortcut for cluste state in AgentManger
Alexander Kalinin created IGNITE-10570: -- Summary: Implement shortcut for cluste state in AgentManger Key: IGNITE-10570 URL: https://issues.apache.org/jira/browse/IGNITE-10570 Project: Ignite Issue Type: Improvement Components: wizards Reporter: Alexander Kalinin Assignee: Alexander Kalinin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ignite pull request #5587: Ignite-10569 Null meta information when getting m...
Github user ldzhjn closed the pull request at: https://github.com/apache/ignite/pull/5587 ---
[jira] [Created] (IGNITE-10571) Crash in exchange worker during memory recovery on rebalance
Max Shonichev created IGNITE-10571:
--
Summary: Crash in exchange worker during memory recovery on
rebalance
Key: IGNITE-10571
URL: https://issues.apache.org/jira/browse/IGNITE-10571
Project: Ignite
Issue Type: Bug
Affects Versions: 2.4
Reporter: Max Shonichev
1. start grid (2 nodes), preload data, start 1 client node
2. kill 1 server node
3. wait 10 sec
4. restart server node
upon 2-3 iteration, node crashes JVM during memory recovery
{noformat}
Stack: [0x7fdcbb2f5000,0x7fdcbb3f6000], sp=0x7fdcbb3f4160, free
space=1020k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
v ~StubRoutines::jshort_disjoint_arraycopy
J 3894 C2
org.apache.ignite.internal.processors.cache.persistence.tree.io.BPlusLeafIO.copyItems(JJIIIZ)V
(55 bytes) @ 0x7fdeadba2949 [0x7fdeadba28e0+0x69]
J 3893 C2
org.apache.ignite.internal.processors.cache.persistence.tree.io.BPlusIO.insert(JILjava/lang/Object;[BJZ)[B
(44 bytes) @ 0x7fdeadba2514 [0x7fdeadba24a0+0x74]
J 3887 C2
org.apache.ignite.internal.pagemem.wal.record.delta.InsertRecord.applyDelta(Lorg/apache/ignite/internal/pagemem/PageMemory;J)V
(24 bytes) @ 0x7fdeadbab0c8 [0x7fdeadbab060+0x68]
J 3895% C2
org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager.restoreMemory(Lorg/apache/ignite/internal/processors/cache/persistence/GridCacheDatabaseSharedManager$CheckpointStatus;ZLorg/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryEx;)Lorg/apache/ignite/internal/pagemem/wal/WALPointer;
(1298 bytes) @ 0x7fdeadb3eb00 [0x7fdeadb3d3a0+0x1760]
j
org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager.restoreMemory(Lorg/apache/ignite/internal/processors/cache/persistence/GridCacheDatabaseSharedManager$CheckpointStatus;)Lorg/apache/ignite/internal/pagemem/wal/WALPointer;+13
j
org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager.readCheckpointAndRestoreMemory(Ljava/util/List;)V+173
j
org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture.initCachesOnLocalJoin()V+147
j
org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture.init(Z)V+794
j
org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager$ExchangeWorker.body()V+547
j org.apache.ignite.internal.util.worker.GridWorker.run()V+82
j java.lang.Thread.run()V+11
v ~StubRoutines::call_stub
V [libjvm.so+0x697a76]
[error occurred during error reporting (printing native stack), id 0xb]
{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] ignite pull request #5588: IGNITE-10569 Null meta information when getting m...
GitHub user ldzhjn opened a pull request: https://github.com/apache/ignite/pull/5588 IGNITE-10569 Null meta information when getting meta for a customized schema cache through JDBC driver You can merge this pull request into a Git repository by running: $ git pull https://github.com/ldzhjn/ignite IGNITE-10569 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5588.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5588 commit bf1cfda30da82a17dd279271f8415b5c14412016 Author: rayliu Date: 2018-12-06T10:14:28Z Fix bug ---
[GitHub] ignite pull request #5577: IGNITE-10549: LogisticRegressionSGDTrainerTest fa...
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/5577 ---
Re: Default failure handler was changed for tests
Dmitrii Ryabov, Your comments sounds reasonable to me. Marker base class approach looks good to me so far. P.S. I had even worse name in mind 'StopGaps' =) чт, 6 дек. 2018 г. в 13:08, Dmitrii Ryabov : > > Ivan, I think `Workarounds` class isn't good idea, because it looks like we > create stable workarounds, which will never be fixed. > > I agree with Nikolay's solution. If no one minds, I'll create ticket for > appropriate changes and recheck issues. > > чт, 6 дек. 2018 г., 12:17 Anton Vinogradov a...@apache.org: > > > Folks, thank's everyone for solution research. > > I'm ok with Nikolay approach in case that's not a final step. > > > > On Thu, Dec 6, 2018 at 12:11 PM Павлухин Иван wrote: > > > > > Nikolay, > > > > > > I meant "not expensive" by "cheap". And I meant that it is good that > > > it cheap =). And I said it to contrast with "expensive" ~100 tests > > > investigation. And if we agree (mostly I would like an opinion from > > > Dmitriy Ryabov as an original author) on a way how to improve the > > > patch then let's do it. > > > чт, 6 дек. 2018 г. в 10:41, Nikolay Izhikov : > > > > > > > > Dmitriy Ryabov, Dmitriy Pavlov, sorry. > > > > > > > > Of course it should be "NOT to blame author". > > > > > > > > Sorry, one more time. > > > > > > > > чт, 6 дек. 2018 г., 10:40 Dmitriy Pavlov dpav...@apache.org: > > > > > > > > > I hope you've misprinted here > > > > > > I'm here to blame the author. > > > > > > > > > > We can blame code but never coders. > > > > > > > > > > Please see https://discourse.pi-hole.net/faq - has absolutely > > nothing > > > in > > > > > common with Apache Guides, but says the same things. It is a > > practical > > > > > necessity to maintain a friendly atmosphere. > > > > > > > > > > чт, 6 дек. 2018 г. в 10:31, Nikolay Izhikov : > > > > > > > > > > > Ivan. > > > > > > > > > > > > > 1. Accept the patch and bring an improvement to Ignite (and > > create > > > a> > > > > > > ticket for further investigation). > > > > > > > > > > > > I support this idea. > > > > > > Do we create the tickets already? > > > > > > > > > > > > > Nikolay's patch [1] suggests a slightly different approach how to > > > the > > > > > > > same thing. And implementing that idea looks like a cheap > > > refactoring. > > > > > > > > > > > > I don't agree with your term "cheap". > > > > > > Do you think reducing copy paste code not worth it? > > > > > > > > > > > > I see a hundreds issues that bring copypasted code in the > > > product(Ignite > > > > > > and others). > > > > > > I insist, that we shouldn't accept patches with it. > > > > > > > > > > > > I'm here to blame the author. > > > > > > I want to improve this patch and make it easier to find all places > > > with > > > > > > NoOp handler to do the further investigation. > > > > > > > > > > > > В Чт, 06/12/2018 в 10:19 +0300, Павлухин Иван пишет: > > > > > > > Guys, > > > > > > > > > > > > > > I asked what harm will applying the patch bring I have not got a > > > > > > > direct answer. But I think I got some pain points: > > > > > > > 1. Anton does not like that reasons why ~100 tests require noop > > > > > > > handler are not clear. And might be several problems are covered > > > > > > > there. > > > > > > > 2. Nikolay suggests some code improvements. > > > > > > > > > > > > > > Nikolay's patch [1] suggests a slightly different approach how to > > > the > > > > > > > same thing. And implementing that idea looks like a cheap > > > refactoring. > > > > > > > But the idea of course could be discussed. Straight away I can > > > suggest > > > > > > > another slightly different trick [2]. > > > > > > > > > > > > > > Investigating why ~100 tests require noop handler could be > > costly. > > > So, > > > > > > > in that direction I see following options which can happen for > > > sure: > > > > > > > 1. Accept the patch and bring an improvement to Ignite (and > > create > > > a > > > > > > > ticket for further investigation). > > > > > > > 2. Revert the patch and loose an improvement. > > > > > > > > > > > > > > One might say that there is an option "Revert the patch and then > > > do it > > > > > > > better" but I does not see anything (anyone) what can guarantee > > it. > > > > > > > So, I personally prefer an option 1 against 2 because I believe > > > that > > > > > > > it is good if the system "can make a progress". > > > > > > > > > > > > > > [1] https://github.com/apache/ignite/pull/5584/files > > > > > > > [2] https://github.com/apache/ignite/pull/5586/files > > > > > > > ср, 5 дек. 2018 г. в 21:22, Nikolay Izhikov > >: > > > > > > > > > > > > > > > > Dmitriy. > > > > > > > > > > > > > > > > > The closest analog to Noop handler is mute of test failure. > > > > > > > > > By this commit, we had unmuted (possible) failures in > > > > > > ~5-~100=~49900 > > > > > > > > > > > > > > > > tests, and we’re still concerned about style or minor details > > if > > > > > no-op > > > > > > was > > > > > > > > copy-pasted, aren’t we? > > > > > > > > > > > > > > >
Re: Service grid redesign
Hi, Vyacheslav! I'm thinking about to use Services API to implement Web Agent as a cluster singleton service. It will improve Web Console UX, because it will not needed to start separate java program. Just start cluster with Web agent enabled on cluster configuration. But in order to do this, I need that services should: 1) Work when cluster NOT ACTIVE. 2) Auto restart with cluster (when cluster was restarted). Could we support mentioned features on "Service Grid redesign - phase 2" ? Please let me know. -- Alexey Kuznetsov
Re: Default failure handler was changed for tests
Dmitrii, >> I agree with Nikolay's solution. If no one minds, I'll create ticket for >> appropriate changes and recheck issues. Do you mean 'copy-paste reduce' ticket or check/fix of all tests with no-op to have a proper handler? Just want to make sure that copy-paste minimization is not the final step. On Thu, Dec 6, 2018 at 1:24 PM Павлухин Иван wrote: > Dmitrii Ryabov, > > Your comments sounds reasonable to me. Marker base class approach > looks good to me so far. > > P.S. I had even worse name in mind 'StopGaps' =) > чт, 6 дек. 2018 г. в 13:08, Dmitrii Ryabov : > > > > Ivan, I think `Workarounds` class isn't good idea, because it looks like > we > > create stable workarounds, which will never be fixed. > > > > I agree with Nikolay's solution. If no one minds, I'll create ticket for > > appropriate changes and recheck issues. > > > > чт, 6 дек. 2018 г., 12:17 Anton Vinogradov a...@apache.org: > > > > > Folks, thank's everyone for solution research. > > > I'm ok with Nikolay approach in case that's not a final step. > > > > > > On Thu, Dec 6, 2018 at 12:11 PM Павлухин Иван > wrote: > > > > > > > Nikolay, > > > > > > > > I meant "not expensive" by "cheap". And I meant that it is good that > > > > it cheap =). And I said it to contrast with "expensive" ~100 tests > > > > investigation. And if we agree (mostly I would like an opinion from > > > > Dmitriy Ryabov as an original author) on a way how to improve the > > > > patch then let's do it. > > > > чт, 6 дек. 2018 г. в 10:41, Nikolay Izhikov : > > > > > > > > > > Dmitriy Ryabov, Dmitriy Pavlov, sorry. > > > > > > > > > > Of course it should be "NOT to blame author". > > > > > > > > > > Sorry, one more time. > > > > > > > > > > чт, 6 дек. 2018 г., 10:40 Dmitriy Pavlov dpav...@apache.org: > > > > > > > > > > > I hope you've misprinted here > > > > > > > I'm here to blame the author. > > > > > > > > > > > > We can blame code but never coders. > > > > > > > > > > > > Please see https://discourse.pi-hole.net/faq - has absolutely > > > nothing > > > > in > > > > > > common with Apache Guides, but says the same things. It is a > > > practical > > > > > > necessity to maintain a friendly atmosphere. > > > > > > > > > > > > чт, 6 дек. 2018 г. в 10:31, Nikolay Izhikov >: > > > > > > > > > > > > > Ivan. > > > > > > > > > > > > > > > 1. Accept the patch and bring an improvement to Ignite (and > > > create > > > > a> > > > > > > > ticket for further investigation). > > > > > > > > > > > > > > I support this idea. > > > > > > > Do we create the tickets already? > > > > > > > > > > > > > > > Nikolay's patch [1] suggests a slightly different approach > how to > > > > the > > > > > > > > same thing. And implementing that idea looks like a cheap > > > > refactoring. > > > > > > > > > > > > > > I don't agree with your term "cheap". > > > > > > > Do you think reducing copy paste code not worth it? > > > > > > > > > > > > > > I see a hundreds issues that bring copypasted code in the > > > > product(Ignite > > > > > > > and others). > > > > > > > I insist, that we shouldn't accept patches with it. > > > > > > > > > > > > > > I'm here to blame the author. > > > > > > > I want to improve this patch and make it easier to find all > places > > > > with > > > > > > > NoOp handler to do the further investigation. > > > > > > > > > > > > > > В Чт, 06/12/2018 в 10:19 +0300, Павлухин Иван пишет: > > > > > > > > Guys, > > > > > > > > > > > > > > > > I asked what harm will applying the patch bring I have not > got a > > > > > > > > direct answer. But I think I got some pain points: > > > > > > > > 1. Anton does not like that reasons why ~100 tests require > noop > > > > > > > > handler are not clear. And might be several problems are > covered > > > > > > > > there. > > > > > > > > 2. Nikolay suggests some code improvements. > > > > > > > > > > > > > > > > Nikolay's patch [1] suggests a slightly different approach > how to > > > > the > > > > > > > > same thing. And implementing that idea looks like a cheap > > > > refactoring. > > > > > > > > But the idea of course could be discussed. Straight away I > can > > > > suggest > > > > > > > > another slightly different trick [2]. > > > > > > > > > > > > > > > > Investigating why ~100 tests require noop handler could be > > > costly. > > > > So, > > > > > > > > in that direction I see following options which can happen > for > > > > sure: > > > > > > > > 1. Accept the patch and bring an improvement to Ignite (and > > > create > > > > a > > > > > > > > ticket for further investigation). > > > > > > > > 2. Revert the patch and loose an improvement. > > > > > > > > > > > > > > > > One might say that there is an option "Revert the patch and > then > > > > do it > > > > > > > > better" but I does not see anything (anyone) what can > guarantee > > > it. > > > > > > > > So, I personally prefer an option 1 against 2 because I > believe > > > > that > > > > > > > > it is good if the system "can make a progress". > > > > > > > > > > > > > > > >
Re: Default failure handler was changed for tests
BTW, No-Op or StopNode-FailTest in case of a deep investigation will always require to understand what test does and what it tests. So we can get a positive outcome from this research if we agree to add - a small description to each test about the reason for existing of this test, - what is the expected behavior of the product in the test, and how it is checked? - failure handler influence, etc. I still hope Anton will do the first bunch of tests research to demonstrate the idea. чт, 6 дек. 2018 г. в 13:39, Anton Vinogradov : > Dmitrii, > > >> I agree with Nikolay's solution. If no one minds, I'll create ticket for > >> appropriate changes and recheck issues. > Do you mean 'copy-paste reduce' ticket or check/fix of all tests with no-op > to have a proper handler? > > Just want to make sure that copy-paste minimization is not the final step. > > On Thu, Dec 6, 2018 at 1:24 PM Павлухин Иван wrote: > > > Dmitrii Ryabov, > > > > Your comments sounds reasonable to me. Marker base class approach > > looks good to me so far. > > > > P.S. I had even worse name in mind 'StopGaps' =) > > чт, 6 дек. 2018 г. в 13:08, Dmitrii Ryabov : > > > > > > Ivan, I think `Workarounds` class isn't good idea, because it looks > like > > we > > > create stable workarounds, which will never be fixed. > > > > > > I agree with Nikolay's solution. If no one minds, I'll create ticket > for > > > appropriate changes and recheck issues. > > > > > > чт, 6 дек. 2018 г., 12:17 Anton Vinogradov a...@apache.org: > > > > > > > Folks, thank's everyone for solution research. > > > > I'm ok with Nikolay approach in case that's not a final step. > > > > > > > > On Thu, Dec 6, 2018 at 12:11 PM Павлухин Иван > > wrote: > > > > > > > > > Nikolay, > > > > > > > > > > I meant "not expensive" by "cheap". And I meant that it is good > that > > > > > it cheap =). And I said it to contrast with "expensive" ~100 tests > > > > > investigation. And if we agree (mostly I would like an opinion from > > > > > Dmitriy Ryabov as an original author) on a way how to improve the > > > > > patch then let's do it. > > > > > чт, 6 дек. 2018 г. в 10:41, Nikolay Izhikov : > > > > > > > > > > > > Dmitriy Ryabov, Dmitriy Pavlov, sorry. > > > > > > > > > > > > Of course it should be "NOT to blame author". > > > > > > > > > > > > Sorry, one more time. > > > > > > > > > > > > чт, 6 дек. 2018 г., 10:40 Dmitriy Pavlov dpav...@apache.org: > > > > > > > > > > > > > I hope you've misprinted here > > > > > > > > I'm here to blame the author. > > > > > > > > > > > > > > We can blame code but never coders. > > > > > > > > > > > > > > Please see https://discourse.pi-hole.net/faq - has absolutely > > > > nothing > > > > > in > > > > > > > common with Apache Guides, but says the same things. It is a > > > > practical > > > > > > > necessity to maintain a friendly atmosphere. > > > > > > > > > > > > > > чт, 6 дек. 2018 г. в 10:31, Nikolay Izhikov < > nizhi...@apache.org > > >: > > > > > > > > > > > > > > > Ivan. > > > > > > > > > > > > > > > > > 1. Accept the patch and bring an improvement to Ignite (and > > > > create > > > > > a> > > > > > > > > ticket for further investigation). > > > > > > > > > > > > > > > > I support this idea. > > > > > > > > Do we create the tickets already? > > > > > > > > > > > > > > > > > Nikolay's patch [1] suggests a slightly different approach > > how to > > > > > the > > > > > > > > > same thing. And implementing that idea looks like a cheap > > > > > refactoring. > > > > > > > > > > > > > > > > I don't agree with your term "cheap". > > > > > > > > Do you think reducing copy paste code not worth it? > > > > > > > > > > > > > > > > I see a hundreds issues that bring copypasted code in the > > > > > product(Ignite > > > > > > > > and others). > > > > > > > > I insist, that we shouldn't accept patches with it. > > > > > > > > > > > > > > > > I'm here to blame the author. > > > > > > > > I want to improve this patch and make it easier to find all > > places > > > > > with > > > > > > > > NoOp handler to do the further investigation. > > > > > > > > > > > > > > > > В Чт, 06/12/2018 в 10:19 +0300, Павлухин Иван пишет: > > > > > > > > > Guys, > > > > > > > > > > > > > > > > > > I asked what harm will applying the patch bring I have not > > got a > > > > > > > > > direct answer. But I think I got some pain points: > > > > > > > > > 1. Anton does not like that reasons why ~100 tests require > > noop > > > > > > > > > handler are not clear. And might be several problems are > > covered > > > > > > > > > there. > > > > > > > > > 2. Nikolay suggests some code improvements. > > > > > > > > > > > > > > > > > > Nikolay's patch [1] suggests a slightly different approach > > how to > > > > > the > > > > > > > > > same thing. And implementing that idea looks like a cheap > > > > > refactoring. > > > > > > > > > But the idea of course could be discussed. Straight away I > > can > > > > > suggest > > > > > > > > > another slightly different trick [2]. > > > > > > > > > > >
[GitHub] ignite pull request #5589: IGNITE-10382: Move datasets from example to ml mo...
GitHub user zaleslaw opened a pull request: https://github.com/apache/ignite/pull/5589 IGNITE-10382: Move datasets from example to ml module You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10382 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5589.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5589 commit e35863c91171b2db879e58927a7c58f32c27c7e8 Author: Zinoviev Alexey Date: 2018-12-06T10:37:36Z IGNITE-10382: Move classes to ml module commit de9718fd6eb58b0475f3ad8eb94b21da4e741891 Author: Zinoviev Alexey Date: 2018-12-06T10:46:47Z IGNITE-10382: Move datasets commit c124f6f7bf0275fa01c4a8c6ef68c6c2d5f92230 Author: Zinoviev Alexey Date: 2018-12-06T10:54:10Z IGNITE-10382: Make datasets accessible ---
Re: Default failure handler was changed for tests
Nikolay, Answering your questions a couple of emails ago. Only one valid reason to avoid NoOp it the risk - we don't correctly understand test meaning by class name, we don't catch it's expected flow and - there is some test which uses NoOp now, but should not. Any failure in such test included to set of NoOp handlers test can be hidden and the test will pass for whatever reason, e.g. poor validation of expected behavior. So suggested analog to this is muted failures, which runs on TC but don't signal us that something is wrong. Sincerely, Dmitriy Pavlov чт, 6 дек. 2018 г. в 13:53, Dmitriy Pavlov : > BTW, No-Op or StopNode-FailTest in case of a deep investigation will > always require to understand what test does and what it tests. > > So we can get a positive outcome from this research if we agree to add > - a small description to each test about the reason for existing of this > test, > - what is the expected behavior of the product in the test, and how it is > checked? > - failure handler influence, etc. > > I still hope Anton will do the first bunch of tests research to > demonstrate the idea. > > чт, 6 дек. 2018 г. в 13:39, Anton Vinogradov : > >> Dmitrii, >> >> >> I agree with Nikolay's solution. If no one minds, I'll create ticket >> for >> >> appropriate changes and recheck issues. >> Do you mean 'copy-paste reduce' ticket or check/fix of all tests with >> no-op >> to have a proper handler? >> >> Just want to make sure that copy-paste minimization is not the final step. >> >> On Thu, Dec 6, 2018 at 1:24 PM Павлухин Иван wrote: >> >> > Dmitrii Ryabov, >> > >> > Your comments sounds reasonable to me. Marker base class approach >> > looks good to me so far. >> > >> > P.S. I had even worse name in mind 'StopGaps' =) >> > чт, 6 дек. 2018 г. в 13:08, Dmitrii Ryabov : >> > > >> > > Ivan, I think `Workarounds` class isn't good idea, because it looks >> like >> > we >> > > create stable workarounds, which will never be fixed. >> > > >> > > I agree with Nikolay's solution. If no one minds, I'll create ticket >> for >> > > appropriate changes and recheck issues. >> > > >> > > чт, 6 дек. 2018 г., 12:17 Anton Vinogradov a...@apache.org: >> > > >> > > > Folks, thank's everyone for solution research. >> > > > I'm ok with Nikolay approach in case that's not a final step. >> > > > >> > > > On Thu, Dec 6, 2018 at 12:11 PM Павлухин Иван >> > wrote: >> > > > >> > > > > Nikolay, >> > > > > >> > > > > I meant "not expensive" by "cheap". And I meant that it is good >> that >> > > > > it cheap =). And I said it to contrast with "expensive" ~100 tests >> > > > > investigation. And if we agree (mostly I would like an opinion >> from >> > > > > Dmitriy Ryabov as an original author) on a way how to improve the >> > > > > patch then let's do it. >> > > > > чт, 6 дек. 2018 г. в 10:41, Nikolay Izhikov > >: >> > > > > > >> > > > > > Dmitriy Ryabov, Dmitriy Pavlov, sorry. >> > > > > > >> > > > > > Of course it should be "NOT to blame author". >> > > > > > >> > > > > > Sorry, one more time. >> > > > > > >> > > > > > чт, 6 дек. 2018 г., 10:40 Dmitriy Pavlov dpav...@apache.org: >> > > > > > >> > > > > > > I hope you've misprinted here >> > > > > > > > I'm here to blame the author. >> > > > > > > >> > > > > > > We can blame code but never coders. >> > > > > > > >> > > > > > > Please see https://discourse.pi-hole.net/faq - has absolutely >> > > > nothing >> > > > > in >> > > > > > > common with Apache Guides, but says the same things. It is a >> > > > practical >> > > > > > > necessity to maintain a friendly atmosphere. >> > > > > > > >> > > > > > > чт, 6 дек. 2018 г. в 10:31, Nikolay Izhikov < >> nizhi...@apache.org >> > >: >> > > > > > > >> > > > > > > > Ivan. >> > > > > > > > >> > > > > > > > > 1. Accept the patch and bring an improvement to Ignite >> (and >> > > > create >> > > > > a> >> > > > > > > > ticket for further investigation). >> > > > > > > > >> > > > > > > > I support this idea. >> > > > > > > > Do we create the tickets already? >> > > > > > > > >> > > > > > > > > Nikolay's patch [1] suggests a slightly different approach >> > how to >> > > > > the >> > > > > > > > > same thing. And implementing that idea looks like a cheap >> > > > > refactoring. >> > > > > > > > >> > > > > > > > I don't agree with your term "cheap". >> > > > > > > > Do you think reducing copy paste code not worth it? >> > > > > > > > >> > > > > > > > I see a hundreds issues that bring copypasted code in the >> > > > > product(Ignite >> > > > > > > > and others). >> > > > > > > > I insist, that we shouldn't accept patches with it. >> > > > > > > > >> > > > > > > > I'm here to blame the author. >> > > > > > > > I want to improve this patch and make it easier to find all >> > places >> > > > > with >> > > > > > > > NoOp handler to do the further investigation. >> > > > > > > > >> > > > > > > > В Чт, 06/12/2018 в 10:19 +0300, Павлухин Иван пишет: >> > > > > > > > > Guys, >> > > > > > > > > >> > > > > > > > > I asked what harm will applying the patc
Re: [ANNOUNCE] Apache Ignite 2.7.0 Released
Nikolay, thank you for your efforts! Should we announce a release in a special Apache-wide channel? чт, 6 дек. 2018 г. в 10:36, Nikolay Izhikov : > The Apache Ignite Community is pleased to announce the release of > Apache Ignite 2.7.0. > > Apache Ignite [1] is a memory-centric distributed database, caching, > and processing platform for transactional, analytical, and streaming > workloads delivering in-memory speeds at petabyte scale. > > This release introduce several major features and fixes some critical > issues > https://ignite.apache.org/releases/2.7.0/release_notes.html > > Download the latest Ignite version from here: > https://ignite.apache.org/download.cgi > > Please let us know [2] if you encounter any problems. > > Regards, > Nikolay Izhikov on behalf of Apache Ignite community > > [1] https://ignite.apache.org > [2] https://ignite.apache.org/community/resources.html#ask >
Re: Default failure handler was changed for tests
Anton, I mean `copy-paste reduce` ticket. I'll try to describe reasons for no-op in tests. Then, we can create tickets to fix this cases if needed. чт, 6 дек. 2018 г., 13:53 Dmitriy Pavlov dpav...@apache.org: > BTW, No-Op or StopNode-FailTest in case of a deep investigation will always > require to understand what test does and what it tests. > > So we can get a positive outcome from this research if we agree to add > - a small description to each test about the reason for existing of this > test, > - what is the expected behavior of the product in the test, and how it is > checked? > - failure handler influence, etc. > > I still hope Anton will do the first bunch of tests research to demonstrate > the idea. > > чт, 6 дек. 2018 г. в 13:39, Anton Vinogradov : > > > Dmitrii, > > > > >> I agree with Nikolay's solution. If no one minds, I'll create ticket > for > > >> appropriate changes and recheck issues. > > Do you mean 'copy-paste reduce' ticket or check/fix of all tests with > no-op > > to have a proper handler? > > > > Just want to make sure that copy-paste minimization is not the final > step. > > > > On Thu, Dec 6, 2018 at 1:24 PM Павлухин Иван > wrote: > > > > > Dmitrii Ryabov, > > > > > > Your comments sounds reasonable to me. Marker base class approach > > > looks good to me so far. > > > > > > P.S. I had even worse name in mind 'StopGaps' =) > > > чт, 6 дек. 2018 г. в 13:08, Dmitrii Ryabov : > > > > > > > > Ivan, I think `Workarounds` class isn't good idea, because it looks > > like > > > we > > > > create stable workarounds, which will never be fixed. > > > > > > > > I agree with Nikolay's solution. If no one minds, I'll create ticket > > for > > > > appropriate changes and recheck issues. > > > > > > > > чт, 6 дек. 2018 г., 12:17 Anton Vinogradov a...@apache.org: > > > > > > > > > Folks, thank's everyone for solution research. > > > > > I'm ok with Nikolay approach in case that's not a final step. > > > > > > > > > > On Thu, Dec 6, 2018 at 12:11 PM Павлухин Иван > > > > wrote: > > > > > > > > > > > Nikolay, > > > > > > > > > > > > I meant "not expensive" by "cheap". And I meant that it is good > > that > > > > > > it cheap =). And I said it to contrast with "expensive" ~100 > tests > > > > > > investigation. And if we agree (mostly I would like an opinion > from > > > > > > Dmitriy Ryabov as an original author) on a way how to improve the > > > > > > patch then let's do it. > > > > > > чт, 6 дек. 2018 г. в 10:41, Nikolay Izhikov >: > > > > > > > > > > > > > > Dmitriy Ryabov, Dmitriy Pavlov, sorry. > > > > > > > > > > > > > > Of course it should be "NOT to blame author". > > > > > > > > > > > > > > Sorry, one more time. > > > > > > > > > > > > > > чт, 6 дек. 2018 г., 10:40 Dmitriy Pavlov dpav...@apache.org: > > > > > > > > > > > > > > > I hope you've misprinted here > > > > > > > > > I'm here to blame the author. > > > > > > > > > > > > > > > > We can blame code but never coders. > > > > > > > > > > > > > > > > Please see https://discourse.pi-hole.net/faq - has > absolutely > > > > > nothing > > > > > > in > > > > > > > > common with Apache Guides, but says the same things. It is a > > > > > practical > > > > > > > > necessity to maintain a friendly atmosphere. > > > > > > > > > > > > > > > > чт, 6 дек. 2018 г. в 10:31, Nikolay Izhikov < > > nizhi...@apache.org > > > >: > > > > > > > > > > > > > > > > > Ivan. > > > > > > > > > > > > > > > > > > > 1. Accept the patch and bring an improvement to Ignite > (and > > > > > create > > > > > > a> > > > > > > > > > ticket for further investigation). > > > > > > > > > > > > > > > > > > I support this idea. > > > > > > > > > Do we create the tickets already? > > > > > > > > > > > > > > > > > > > Nikolay's patch [1] suggests a slightly different > approach > > > how to > > > > > > the > > > > > > > > > > same thing. And implementing that idea looks like a cheap > > > > > > refactoring. > > > > > > > > > > > > > > > > > > I don't agree with your term "cheap". > > > > > > > > > Do you think reducing copy paste code not worth it? > > > > > > > > > > > > > > > > > > I see a hundreds issues that bring copypasted code in the > > > > > > product(Ignite > > > > > > > > > and others). > > > > > > > > > I insist, that we shouldn't accept patches with it. > > > > > > > > > > > > > > > > > > I'm here to blame the author. > > > > > > > > > I want to improve this patch and make it easier to find all > > > places > > > > > > with > > > > > > > > > NoOp handler to do the further investigation. > > > > > > > > > > > > > > > > > > В Чт, 06/12/2018 в 10:19 +0300, Павлухин Иван пишет: > > > > > > > > > > Guys, > > > > > > > > > > > > > > > > > > > > I asked what harm will applying the patch bring I have > not > > > got a > > > > > > > > > > direct answer. But I think I got some pain points: > > > > > > > > > > 1. Anton does not like that reasons why ~100 tests > require > > > noop > > > > > > > > > > handler are not clear. And might be several problems are > > > covered > >
[GitHub] dspavlov opened a new pull request #92: IGNITE-10562: new fat build version to check ID consistency
dspavlov opened a new pull request #92: IGNITE-10562: new fat build version to check ID consistency URL: https://github.com/apache/ignite-teamcity-bot/pull/92 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit closed pull request #91: IGNITE-10568 Replace type for test id from long to String
asfgit closed pull request #91: IGNITE-10568 Replace type for test id from long
to String
URL: https://github.com/apache/ignite-teamcity-bot/pull/91
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcmodel/result/tests/TestRef.java
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcmodel/result/tests/TestRef.java
index 76f6a134..97529633 100644
---
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcmodel/result/tests/TestRef.java
+++
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcmodel/result/tests/TestRef.java
@@ -26,6 +26,6 @@
*/
@XmlRootElement(name = "test")
public class TestRef extends AbstractRef {
-@XmlAttribute public Long id;
+@XmlAttribute public String id;
@XmlAttribute public String name;
}
diff --git
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/fatbuild/TestCompacted.java
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/fatbuild/TestCompacted.java
index d7b1a993..d03f9f15 100644
---
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/fatbuild/TestCompacted.java
+++
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/fatbuild/TestCompacted.java
@@ -111,7 +111,7 @@ public TestCompacted(IStringCompactor compactor,
TestOccurrenceFull testOccurren
actualBuildId = testOccurrence.build.getId();
if (testOccurrence.test != null && testOccurrence.test.id != null)
-testId = testOccurrence.test.id;
+testId = Long.valueOf(testOccurrence.test.id);
setDetails(testOccurrence.details);
}
@@ -166,7 +166,7 @@ public TestOccurrenceFull toTestOccurrence(IStringCompactor
compactor, int build
if (testId != 0) {
TestRef test = new TestRef();
-test.id = testId;
+test.id = String.valueOf(testId);
occurrence.test = test;
}
diff --git
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java
index 97489111..cf24ebe9 100644
---
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java
+++
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java
@@ -174,11 +174,13 @@ public void checkAndFillByPrefix(String details, String
issueLinkPrefix) {
}
}
-private static String buildWebLink(ITeamcityIgnited tcIgn, Long id,
+private static String buildWebLink(ITeamcityIgnited tcIgn, String id,
@Nullable String projectId, @Nullable String branchName) {
if (projectId == null)
return null;
+
final String branch = branchForLink(branchName);
+
return tcIgn.host() + "project.html"
+ "?projectId=" + projectId
+ "&testNameId=" + id
diff --git
a/ignite-tc-helper-web/src/test/java/org/apache/ignite/ci/tcbot/chain/PrChainsProcessorTest.java
b/ignite-tc-helper-web/src/test/java/org/apache/ignite/ci/tcbot/chain/PrChainsProcessorTest.java
index 453f88f7..6b99340d 100644
---
a/ignite-tc-helper-web/src/test/java/org/apache/ignite/ci/tcbot/chain/PrChainsProcessorTest.java
+++
b/ignite-tc-helper-web/src/test/java/org/apache/ignite/ci/tcbot/chain/PrChainsProcessorTest.java
@@ -295,7 +295,7 @@ private TestOccurrenceFull createPassingTest(long id,
String name) {
tf.test = new TestRef();
-tf.test.id = id;
+tf.test.id = String.valueOf(id);
tf.name = name;
tf.status = passed ? TestOccurrence.STATUS_SUCCESS :
TestOccurrence.STATUS_FAILURE;
return tf;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
Re: [ANNOUNCE] Apache Ignite 2.7.0 Released
Dmitriy. Yes, we should. Please, tell me mail of this channel. чт, 6 дек. 2018 г., 14:13 Dmitriy Pavlov dpav...@apache.org: > Nikolay, thank you for your efforts! > > Should we announce a release in a special Apache-wide channel? > > чт, 6 дек. 2018 г. в 10:36, Nikolay Izhikov : > > > The Apache Ignite Community is pleased to announce the release of > > Apache Ignite 2.7.0. > > > > Apache Ignite [1] is a memory-centric distributed database, caching, > > and processing platform for transactional, analytical, and streaming > > workloads delivering in-memory speeds at petabyte scale. > > > > This release introduce several major features and fixes some critical > > issues > > https://ignite.apache.org/releases/2.7.0/release_notes.html > > > > Download the latest Ignite version from here: > > https://ignite.apache.org/download.cgi > > > > Please let us know [2] if you encounter any problems. > > > > Regards, > > Nikolay Izhikov on behalf of Apache Ignite community > > > > [1] https://ignite.apache.org > > [2] https://ignite.apache.org/community/resources.html#ask > > >
Re: [ANNOUNCE] Apache Ignite 2.7.0 Released
According to previous https://lists.apache.org/thread.html/4dd772a607ba89b3aaa2084a1ebcd2f4e6a9790decad4d167b2dbd73@%3Cdev.ignite.apache.org%3E it seems to be To: annou...@apache.org, dev , u...@ignite.apache.org чт, 6 дек. 2018 г. в 14:30, Nikolay Izhikov : > Dmitriy. > > Yes, we should. Please, tell me mail of this channel. > > чт, 6 дек. 2018 г., 14:13 Dmitriy Pavlov dpav...@apache.org: > > > Nikolay, thank you for your efforts! > > > > Should we announce a release in a special Apache-wide channel? > > > > чт, 6 дек. 2018 г. в 10:36, Nikolay Izhikov : > > > > > The Apache Ignite Community is pleased to announce the release of > > > Apache Ignite 2.7.0. > > > > > > Apache Ignite [1] is a memory-centric distributed database, caching, > > > and processing platform for transactional, analytical, and streaming > > > workloads delivering in-memory speeds at petabyte scale. > > > > > > This release introduce several major features and fixes some critical > > > issues > > > https://ignite.apache.org/releases/2.7.0/release_notes.html > > > > > > Download the latest Ignite version from here: > > > https://ignite.apache.org/download.cgi > > > > > > Please let us know [2] if you encounter any problems. > > > > > > Regards, > > > Nikolay Izhikov on behalf of Apache Ignite community > > > > > > [1] https://ignite.apache.org > > > [2] https://ignite.apache.org/community/resources.html#ask > > > > > >
[GitHub] asfgit closed pull request #92: IGNITE-10562: new fat build version to check ID consistency
asfgit closed pull request #92: IGNITE-10562: new fat build version to check ID consistency URL: https://github.com/apache/ignite-teamcity-bot/pull/92 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Default failure handler was changed for tests
>> I still hope Anton will do the first bunch of tests research to demonstrate >> the idea. Dmitriy, Just want to remind you that we already spend time here because of unacceptable code merge situation. Such merges should NEVER happen again. Please, next time make sure that code you merge has no massive duplication and fixes without proper reason investigation. Committer always MUST be ready to explain each symbol inside code he merged. The situation when you have no clue why it written this way unacceptable. Feel free to start a discussion at private in case you have some objections. But, hope you agree and will help us to solve the issue instead. Dmitrii, >> Anton, I mean `copy-paste reduce` ticket. I'll try to describe the reasons for >> no-op in tests. Then, we can create tickets to fix this cases if needed. In case no-one will be ready to start a proper fix (investigate why every no-op required and create tickets for each problem) before Friday evening, the code will be rolled back. Simple no-op is better that same but overcomplicated. On Thu, Dec 6, 2018 at 2:14 PM Dmitrii Ryabov wrote: > Anton, I mean `copy-paste reduce` ticket. I'll try to describe reasons for > no-op in tests. Then, we can create tickets to fix this cases if needed. > > чт, 6 дек. 2018 г., 13:53 Dmitriy Pavlov dpav...@apache.org: > > > BTW, No-Op or StopNode-FailTest in case of a deep investigation will > always > > require to understand what test does and what it tests. > > > > So we can get a positive outcome from this research if we agree to add > > - a small description to each test about the reason for existing of this > > test, > > - what is the expected behavior of the product in the test, and how it is > > checked? > > - failure handler influence, etc. > > > > I still hope Anton will do the first bunch of tests research to > demonstrate > > the idea. > > > > чт, 6 дек. 2018 г. в 13:39, Anton Vinogradov : > > > > > Dmitrii, > > > > > > >> I agree with Nikolay's solution. If no one minds, I'll create ticket > > for > > > >> appropriate changes and recheck issues. > > > Do you mean 'copy-paste reduce' ticket or check/fix of all tests with > > no-op > > > to have a proper handler? > > > > > > Just want to make sure that copy-paste minimization is not the final > > step. > > > > > > On Thu, Dec 6, 2018 at 1:24 PM Павлухин Иван > > wrote: > > > > > > > Dmitrii Ryabov, > > > > > > > > Your comments sounds reasonable to me. Marker base class approach > > > > looks good to me so far. > > > > > > > > P.S. I had even worse name in mind 'StopGaps' =) > > > > чт, 6 дек. 2018 г. в 13:08, Dmitrii Ryabov : > > > > > > > > > > Ivan, I think `Workarounds` class isn't good idea, because it looks > > > like > > > > we > > > > > create stable workarounds, which will never be fixed. > > > > > > > > > > I agree with Nikolay's solution. If no one minds, I'll create > ticket > > > for > > > > > appropriate changes and recheck issues. > > > > > > > > > > чт, 6 дек. 2018 г., 12:17 Anton Vinogradov a...@apache.org: > > > > > > > > > > > Folks, thank's everyone for solution research. > > > > > > I'm ok with Nikolay approach in case that's not a final step. > > > > > > > > > > > > On Thu, Dec 6, 2018 at 12:11 PM Павлухин Иван < > vololo...@gmail.com > > > > > > > wrote: > > > > > > > > > > > > > Nikolay, > > > > > > > > > > > > > > I meant "not expensive" by "cheap". And I meant that it is good > > > that > > > > > > > it cheap =). And I said it to contrast with "expensive" ~100 > > tests > > > > > > > investigation. And if we agree (mostly I would like an opinion > > from > > > > > > > Dmitriy Ryabov as an original author) on a way how to improve > the > > > > > > > patch then let's do it. > > > > > > > чт, 6 дек. 2018 г. в 10:41, Nikolay Izhikov < > nizhi...@apache.org > > >: > > > > > > > > > > > > > > > > Dmitriy Ryabov, Dmitriy Pavlov, sorry. > > > > > > > > > > > > > > > > Of course it should be "NOT to blame author". > > > > > > > > > > > > > > > > Sorry, one more time. > > > > > > > > > > > > > > > > чт, 6 дек. 2018 г., 10:40 Dmitriy Pavlov dpav...@apache.org: > > > > > > > > > > > > > > > > > I hope you've misprinted here > > > > > > > > > > I'm here to blame the author. > > > > > > > > > > > > > > > > > > We can blame code but never coders. > > > > > > > > > > > > > > > > > > Please see https://discourse.pi-hole.net/faq - has > > absolutely > > > > > > nothing > > > > > > > in > > > > > > > > > common with Apache Guides, but says the same things. It is > a > > > > > > practical > > > > > > > > > necessity to maintain a friendly atmosphere. > > > > > > > > > > > > > > > > > > чт, 6 дек. 2018 г. в 10:31, Nikolay Izhikov < > > > nizhi...@apache.org > > > > >: > > > > > > > > > > > > > > > > > > > Ivan. > > > > > > > > > > > > > > > > > > > > > 1. Accept the patch and bring an improvement to Ignite > > (and > > > > > > create > > > > > > > a> > > > > > > > > > > ticket for further investigation). > > > > > > > > > > > > > > > > > > > > I
Re: [ANNOUNCE] Apache Ignite 2.7.0 Released
Done. чт, 6 дек. 2018 г. в 14:41, Dmitriy Pavlov : > According to previous > > https://lists.apache.org/thread.html/4dd772a607ba89b3aaa2084a1ebcd2f4e6a9790decad4d167b2dbd73@%3Cdev.ignite.apache.org%3E > it > seems to be To: annou...@apache.org, dev , > u...@ignite.apache.org > > чт, 6 дек. 2018 г. в 14:30, Nikolay Izhikov : > > > Dmitriy. > > > > Yes, we should. Please, tell me mail of this channel. > > > > чт, 6 дек. 2018 г., 14:13 Dmitriy Pavlov dpav...@apache.org: > > > > > Nikolay, thank you for your efforts! > > > > > > Should we announce a release in a special Apache-wide channel? > > > > > > чт, 6 дек. 2018 г. в 10:36, Nikolay Izhikov : > > > > > > > The Apache Ignite Community is pleased to announce the release of > > > > Apache Ignite 2.7.0. > > > > > > > > Apache Ignite [1] is a memory-centric distributed database, caching, > > > > and processing platform for transactional, analytical, and streaming > > > > workloads delivering in-memory speeds at petabyte scale. > > > > > > > > This release introduce several major features and fixes some critical > > > > issues > > > > https://ignite.apache.org/releases/2.7.0/release_notes.html > > > > > > > > Download the latest Ignite version from here: > > > > https://ignite.apache.org/download.cgi > > > > > > > > Please let us know [2] if you encounter any problems. > > > > > > > > Regards, > > > > Nikolay Izhikov on behalf of Apache Ignite community > > > > > > > > [1] https://ignite.apache.org > > > > [2] https://ignite.apache.org/community/resources.html#ask > > > > > > > > > >
[jira] [Created] (IGNITE-10572) MVCC TX: Possible race on invokeAll operations
Igor Seliverstov created IGNITE-10572:
-
Summary: MVCC TX: Possible race on invokeAll operations
Key: IGNITE-10572
URL: https://issues.apache.org/jira/browse/IGNITE-10572
Project: Ignite
Issue Type: Bug
Components: mvcc
Reporter: Igor Seliverstov
Assignee: Andrew Mashenkov
see {{GridNearTxEnlistFuture#checkResponse}} method.
1) race on result creation - two threads may see {{this.res == null}} and just
set their values, result is partially lost
2) race on success flag set - just set false flag may be overwritten by
concurrent successful response checking operation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: Service grid redesign
Alexey, I don't see any problem in letting services work on a deactivated cluster. All services need is discovery messages and compute tasks. Both of these features are available at all times. But it should be configurable. Services may need caches for their work, so it's better to undeploy such services on cluster deactivation. We may introduce a new property in ServiceConfiguration. I think, this topic deserves a separate discussion. Could you start another thread? Denis чт, 6 дек. 2018 г. в 13:27, Alexey Kuznetsov : > Hi, Vyacheslav! > > I'm thinking about to use Services API to implement Web Agent as a cluster > singleton service. > It will improve Web Console UX, because it will not needed to start > separate java program. > Just start cluster with Web agent enabled on cluster configuration. > > But in order to do this, I need that services should: > 1) Work when cluster NOT ACTIVE. > 2) Auto restart with cluster (when cluster was restarted). > > Could we support mentioned features on "Service Grid redesign - phase 2" ? > > Please let me know. > > -- > Alexey Kuznetsov >
Re: Default failure handler was changed for tests
Anton, I have another proposal. We stop, for now, then you will chill a little bit, then you will have an absolutely fantastic weekend, and then on Monday, Dec 10 we will continue this discussion in a positive and constructive manner. Trying to win in a match "my revert is bigger than yours/my code is better than yours" will not help to anyone. чт, 6 дек. 2018 г. в 15:02, Anton Vinogradov : > >> I still hope Anton will do the first bunch of tests research to > demonstrate > >> the idea. > > Dmitriy, > Just want to remind you that we already spend time here because of > unacceptable code merge situation. > Such merges should NEVER happen again. > Please, next time make sure that code you merge has no massive duplication > and fixes without proper reason investigation. > Committer always MUST be ready to explain each symbol inside code he > merged. > The situation when you have no clue why it written this way unacceptable. > > Feel free to start a discussion at private in case you have some > objections. > But, hope you agree and will help us to solve the issue instead. > > Dmitrii, > >> Anton, I mean `copy-paste reduce` ticket. I'll try to describe the > reasons for > >> no-op in tests. Then, we can create tickets to fix this cases if needed. > > In case no-one will be ready to start a proper fix (investigate why every > no-op required and create tickets for each problem) before Friday evening, > the code will be rolled back. > Simple no-op is better that same but overcomplicated. > > On Thu, Dec 6, 2018 at 2:14 PM Dmitrii Ryabov > wrote: > > > Anton, I mean `copy-paste reduce` ticket. I'll try to describe reasons > for > > no-op in tests. Then, we can create tickets to fix this cases if needed. > > > > чт, 6 дек. 2018 г., 13:53 Dmitriy Pavlov dpav...@apache.org: > > > > > BTW, No-Op or StopNode-FailTest in case of a deep investigation will > > always > > > require to understand what test does and what it tests. > > > > > > So we can get a positive outcome from this research if we agree to add > > > - a small description to each test about the reason for existing of > this > > > test, > > > - what is the expected behavior of the product in the test, and how it > is > > > checked? > > > - failure handler influence, etc. > > > > > > I still hope Anton will do the first bunch of tests research to > > demonstrate > > > the idea. > > > > > > чт, 6 дек. 2018 г. в 13:39, Anton Vinogradov : > > > > > > > Dmitrii, > > > > > > > > >> I agree with Nikolay's solution. If no one minds, I'll create > ticket > > > for > > > > >> appropriate changes and recheck issues. > > > > Do you mean 'copy-paste reduce' ticket or check/fix of all tests with > > > no-op > > > > to have a proper handler? > > > > > > > > Just want to make sure that copy-paste minimization is not the final > > > step. > > > > > > > > On Thu, Dec 6, 2018 at 1:24 PM Павлухин Иван > > > wrote: > > > > > > > > > Dmitrii Ryabov, > > > > > > > > > > Your comments sounds reasonable to me. Marker base class approach > > > > > looks good to me so far. > > > > > > > > > > P.S. I had even worse name in mind 'StopGaps' =) > > > > > чт, 6 дек. 2018 г. в 13:08, Dmitrii Ryabov >: > > > > > > > > > > > > Ivan, I think `Workarounds` class isn't good idea, because it > looks > > > > like > > > > > we > > > > > > create stable workarounds, which will never be fixed. > > > > > > > > > > > > I agree with Nikolay's solution. If no one minds, I'll create > > ticket > > > > for > > > > > > appropriate changes and recheck issues. > > > > > > > > > > > > чт, 6 дек. 2018 г., 12:17 Anton Vinogradov a...@apache.org: > > > > > > > > > > > > > Folks, thank's everyone for solution research. > > > > > > > I'm ok with Nikolay approach in case that's not a final step. > > > > > > > > > > > > > > On Thu, Dec 6, 2018 at 12:11 PM Павлухин Иван < > > vololo...@gmail.com > > > > > > > > > wrote: > > > > > > > > > > > > > > > Nikolay, > > > > > > > > > > > > > > > > I meant "not expensive" by "cheap". And I meant that it is > good > > > > that > > > > > > > > it cheap =). And I said it to contrast with "expensive" ~100 > > > tests > > > > > > > > investigation. And if we agree (mostly I would like an > opinion > > > from > > > > > > > > Dmitriy Ryabov as an original author) on a way how to improve > > the > > > > > > > > patch then let's do it. > > > > > > > > чт, 6 дек. 2018 г. в 10:41, Nikolay Izhikov < > > nizhi...@apache.org > > > >: > > > > > > > > > > > > > > > > > > Dmitriy Ryabov, Dmitriy Pavlov, sorry. > > > > > > > > > > > > > > > > > > Of course it should be "NOT to blame author". > > > > > > > > > > > > > > > > > > Sorry, one more time. > > > > > > > > > > > > > > > > > > чт, 6 дек. 2018 г., 10:40 Dmitriy Pavlov > dpav...@apache.org: > > > > > > > > > > > > > > > > > > > I hope you've misprinted here > > > > > > > > > > > I'm here to blame the author. > > > > > > > > > > > > > > > > > > > > We can blame code but never coders. > > > > > > > > > > > > > > > > > > > > Please see h
Re: Default failure handler was changed for tests
Anton. I discussed this fix privately with Dmitriy Pavlov. 1. We had NoOpHandler for ALL tests before this merge. 2. Dmitry Ryabov will remove all copypasted code soon. So, this fix make things better. I think we shouldn't revert it. I think we should continue work to turn off NoOpHandler in all tests. Dmitriy Pavlov, can you do it, as a committer of this patch? On 12/6/18 3:02 PM, Anton Vinogradov wrote: >>> I still hope Anton will do the first bunch of tests research to > demonstrate >>> the idea. > > Dmitriy, > Just want to remind you that we already spend time here because of > unacceptable code merge situation. > Such merges should NEVER happen again. > Please, next time make sure that code you merge has no massive duplication > and fixes without proper reason investigation. > Committer always MUST be ready to explain each symbol inside code he merged. > The situation when you have no clue why it written this way unacceptable. > > Feel free to start a discussion at private in case you have some objections. > But, hope you agree and will help us to solve the issue instead. > > Dmitrii, >>> Anton, I mean `copy-paste reduce` ticket. I'll try to describe the > reasons for >>> no-op in tests. Then, we can create tickets to fix this cases if needed. > > In case no-one will be ready to start a proper fix (investigate why every > no-op required and create tickets for each problem) before Friday evening, > the code will be rolled back. > Simple no-op is better that same but overcomplicated. > > On Thu, Dec 6, 2018 at 2:14 PM Dmitrii Ryabov wrote: > >> Anton, I mean `copy-paste reduce` ticket. I'll try to describe reasons for >> no-op in tests. Then, we can create tickets to fix this cases if needed. >> >> чт, 6 дек. 2018 г., 13:53 Dmitriy Pavlov dpav...@apache.org: >> >>> BTW, No-Op or StopNode-FailTest in case of a deep investigation will >> always >>> require to understand what test does and what it tests. >>> >>> So we can get a positive outcome from this research if we agree to add >>> - a small description to each test about the reason for existing of this >>> test, >>> - what is the expected behavior of the product in the test, and how it is >>> checked? >>> - failure handler influence, etc. >>> >>> I still hope Anton will do the first bunch of tests research to >> demonstrate >>> the idea. >>> >>> чт, 6 дек. 2018 г. в 13:39, Anton Vinogradov : >>> Dmitrii, >> I agree with Nikolay's solution. If no one minds, I'll create ticket >>> for >> appropriate changes and recheck issues. Do you mean 'copy-paste reduce' ticket or check/fix of all tests with >>> no-op to have a proper handler? Just want to make sure that copy-paste minimization is not the final >>> step. On Thu, Dec 6, 2018 at 1:24 PM Павлухин Иван >>> wrote: > Dmitrii Ryabov, > > Your comments sounds reasonable to me. Marker base class approach > looks good to me so far. > > P.S. I had even worse name in mind 'StopGaps' =) > чт, 6 дек. 2018 г. в 13:08, Dmitrii Ryabov : >> >> Ivan, I think `Workarounds` class isn't good idea, because it looks like > we >> create stable workarounds, which will never be fixed. >> >> I agree with Nikolay's solution. If no one minds, I'll create >> ticket for >> appropriate changes and recheck issues. >> >> чт, 6 дек. 2018 г., 12:17 Anton Vinogradov a...@apache.org: >> >>> Folks, thank's everyone for solution research. >>> I'm ok with Nikolay approach in case that's not a final step. >>> >>> On Thu, Dec 6, 2018 at 12:11 PM Павлухин Иван < >> vololo...@gmail.com > wrote: >>> Nikolay, I meant "not expensive" by "cheap". And I meant that it is good that it cheap =). And I said it to contrast with "expensive" ~100 >>> tests investigation. And if we agree (mostly I would like an opinion >>> from Dmitriy Ryabov as an original author) on a way how to improve >> the patch then let's do it. чт, 6 дек. 2018 г. в 10:41, Nikolay Izhikov < >> nizhi...@apache.org : > > Dmitriy Ryabov, Dmitriy Pavlov, sorry. > > Of course it should be "NOT to blame author". > > Sorry, one more time. > > чт, 6 дек. 2018 г., 10:40 Dmitriy Pavlov dpav...@apache.org: > >> I hope you've misprinted here >>> I'm here to blame the author. >> >> We can blame code but never coders. >> >> Please see https://discourse.pi-hole.net/faq - has >>> absolutely >>> nothing in >> common with Apache Guides, but says the same things. It is >> a >>> practical >> necessity to maintain a friendly atmosphere. >> >> чт, 6 дек. 2018 г. в 10:31, Nikolay Izhikov < nizhi...@apache.org >> : >> >>> Ivan. >>> 1. Accept the patc
[GitHub] ignite pull request #5590: IGNITE-8626: ODBC and C++ thin now support OpenSS...
GitHub user isapego opened a pull request: https://github.com/apache/ignite/pull/5590 IGNITE-8626: ODBC and C++ thin now support OpenSSL 1.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8626 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5590.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5590 commit b920442b2e3a68376bf48de4bcc98c98183ae2f5 Author: Igor Sapego Date: 2018-12-04T17:25:34Z IGNITE-8626: Added OpenSSL 1.1 support for Windows commit 985c3261ed9c9554100014fbfaf5ad855edae7b5 Author: Igor Sapego Date: 2018-12-04T18:52:38Z IGNITE-8626: Implemented for ODBC commit 872cfa855e1adfd2b44162d9be8ae63837301742 Author: Igor Sapego Date: 2018-12-05T11:28:01Z IGNITE-8626: Fix for OpenSSL 1.0 commit 609cc826cfcb433ef6f59d3508dceccefa36e096 Author: Igor Sapego Date: 2018-12-05T15:45:54Z IGNITE-8626: Fixes for Linux build system ---
Re: Default failure handler was changed for tests
>> We stop, for now, then you will chill a >> little bit, then you will have an absolutely fantastic weekend, and then on >> Monday, Dec 10 we will continue this discussion in a positive and >> constructive manner. Agree On Thu, Dec 6, 2018 at 3:55 PM Nikolay Izhikov wrote: > Anton. > > I discussed this fix privately with Dmitriy Pavlov. > > 1. We had NoOpHandler for ALL tests before this merge. > 2. Dmitry Ryabov will remove all copypasted code soon. > > So, this fix make things better. > > I think we shouldn't revert it. > > I think we should continue work to turn off NoOpHandler in all tests. > > Dmitriy Pavlov, can you do it, as a committer of this patch? > > On 12/6/18 3:02 PM, Anton Vinogradov wrote: > >>> I still hope Anton will do the first bunch of tests research to > > demonstrate > >>> the idea. > > > > Dmitriy, > > Just want to remind you that we already spend time here because of > > unacceptable code merge situation. > > Such merges should NEVER happen again. > > Please, next time make sure that code you merge has no massive > duplication > > and fixes without proper reason investigation. > > Committer always MUST be ready to explain each symbol inside code he > merged. > > The situation when you have no clue why it written this way unacceptable. > > > > Feel free to start a discussion at private in case you have some > objections. > > But, hope you agree and will help us to solve the issue instead. > > > > Dmitrii, > >>> Anton, I mean `copy-paste reduce` ticket. I'll try to describe the > > reasons for > >>> no-op in tests. Then, we can create tickets to fix this cases if > needed. > > > > In case no-one will be ready to start a proper fix (investigate why every > > no-op required and create tickets for each problem) before Friday > evening, > > the code will be rolled back. > > Simple no-op is better that same but overcomplicated. > > > > On Thu, Dec 6, 2018 at 2:14 PM Dmitrii Ryabov > wrote: > > > >> Anton, I mean `copy-paste reduce` ticket. I'll try to describe reasons > for > >> no-op in tests. Then, we can create tickets to fix this cases if needed. > >> > >> чт, 6 дек. 2018 г., 13:53 Dmitriy Pavlov dpav...@apache.org: > >> > >>> BTW, No-Op or StopNode-FailTest in case of a deep investigation will > >> always > >>> require to understand what test does and what it tests. > >>> > >>> So we can get a positive outcome from this research if we agree to add > >>> - a small description to each test about the reason for existing of > this > >>> test, > >>> - what is the expected behavior of the product in the test, and how it > is > >>> checked? > >>> - failure handler influence, etc. > >>> > >>> I still hope Anton will do the first bunch of tests research to > >> demonstrate > >>> the idea. > >>> > >>> чт, 6 дек. 2018 г. в 13:39, Anton Vinogradov : > >>> > Dmitrii, > > >> I agree with Nikolay's solution. If no one minds, I'll create ticket > >>> for > >> appropriate changes and recheck issues. > Do you mean 'copy-paste reduce' ticket or check/fix of all tests with > >>> no-op > to have a proper handler? > > Just want to make sure that copy-paste minimization is not the final > >>> step. > > On Thu, Dec 6, 2018 at 1:24 PM Павлухин Иван > >>> wrote: > > > Dmitrii Ryabov, > > > > Your comments sounds reasonable to me. Marker base class approach > > looks good to me so far. > > > > P.S. I had even worse name in mind 'StopGaps' =) > > чт, 6 дек. 2018 г. в 13:08, Dmitrii Ryabov : > >> > >> Ivan, I think `Workarounds` class isn't good idea, because it looks > like > > we > >> create stable workarounds, which will never be fixed. > >> > >> I agree with Nikolay's solution. If no one minds, I'll create > >> ticket > for > >> appropriate changes and recheck issues. > >> > >> чт, 6 дек. 2018 г., 12:17 Anton Vinogradov a...@apache.org: > >> > >>> Folks, thank's everyone for solution research. > >>> I'm ok with Nikolay approach in case that's not a final step. > >>> > >>> On Thu, Dec 6, 2018 at 12:11 PM Павлухин Иван < > >> vololo...@gmail.com > > > wrote: > >>> > Nikolay, > > I meant "not expensive" by "cheap". And I meant that it is good > that > it cheap =). And I said it to contrast with "expensive" ~100 > >>> tests > investigation. And if we agree (mostly I would like an opinion > >>> from > Dmitriy Ryabov as an original author) on a way how to improve > >> the > patch then let's do it. > чт, 6 дек. 2018 г. в 10:41, Nikolay Izhikov < > >> nizhi...@apache.org > : > > > > Dmitriy Ryabov, Dmitriy Pavlov, sorry. > > > > Of course it should be "NOT to blame author". > > > > Sorry, one more time. > > > > чт, 6 дек. 2018 г., 10:40 Dmitriy Pavlov dpav...@apache.org: > > > >> I hope you've
[jira] [Created] (IGNITE-10575) [ML] Add examples and update tutorial for ensemble training
Yury Babak created IGNITE-10575: --- Summary: [ML] Add examples and update tutorial for ensemble training Key: IGNITE-10575 URL: https://issues.apache.org/jira/browse/IGNITE-10575 Project: Ignite Issue Type: Improvement Components: ml Reporter: Yury Babak -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ololo3000 opened a new pull request #93: IGNITE-10519 JavaDocs added
ololo3000 opened a new pull request #93: IGNITE-10519 JavaDocs added URL: https://github.com/apache/ignite-teamcity-bot/pull/93 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (IGNITE-10573) [ML] Consistent API for Ensemble training
Yury Babak created IGNITE-10573: --- Summary: [ML] Consistent API for Ensemble training Key: IGNITE-10573 URL: https://issues.apache.org/jira/browse/IGNITE-10573 Project: Ignite Issue Type: Improvement Components: ml Reporter: Yury Babak -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-10574) [ML] Design API for Ensemble Training
Yury Babak created IGNITE-10574: --- Summary: [ML] Design API for Ensemble Training Key: IGNITE-10574 URL: https://issues.apache.org/jira/browse/IGNITE-10574 Project: Ignite Issue Type: Sub-task Components: ml Reporter: Yury Babak Currently, we have bagging and boosting. And for boosting we have the separate trainer(GDBTrainer), but for bagging, we have the static method inside TrainerTransformers class. We should choose what approach is better for us. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-10576) MVCC TX: Rework UpdateSourceIterator to mix operation types
Igor Seliverstov created IGNITE-10576: - Summary: MVCC TX: Rework UpdateSourceIterator to mix operation types Key: IGNITE-10576 URL: https://issues.apache.org/jira/browse/IGNITE-10576 Project: Ignite Issue Type: Bug Components: mvcc Reporter: Igor Seliverstov Assignee: Andrew Mashenkov Current the UpdateSourceIterator implementation doesn't suit Cache API needs. It should be able to mix operation types per key. For example we may execute putAll operation with a half of keys are having values and a half aren't, this way we should mix DELETE operation for null-value keys and PUT operation for others. Another use case is a transform operation which should turn into a number of PUT/UPDATE/DELETE operations on a backup node. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-10577) ignite-kubernetes is missing jackson-annotations dependency
Stephen Darlington created IGNITE-10577:
---
Summary: ignite-kubernetes is missing jackson-annotations
dependency
Key: IGNITE-10577
URL: https://issues.apache.org/jira/browse/IGNITE-10577
Project: Ignite
Issue Type: Bug
Components: build
Affects Versions: 2.7
Reporter: Stephen Darlington
Assignee: Stephen Darlington
When starting 2.7 with the ignite-kubernetes option I get the following
exception on startup:
{{[13:44:34,605][SEVERE][main][IgniteKernal] Got exception while starting (will
rollback startup routine).}}{{java.lang.NoClassDefFoundError:
com/fasterxml/jackson/annotation/JsonView}}{{ at
com.fasterxml.jackson.databind.introspect.JacksonAnnotationIntrospector.(JacksonAnnotationIntrospector.java:37)}}{{
at
com.fasterxml.jackson.databind.ObjectMapper.(ObjectMapper.java:291)}}{{
at
org.apache.ignite.spi.discovery.tcp.ipfinder.kubernetes.TcpDiscoveryKubernetesIpFinder.getRegisteredAddresses(TcpDiscoveryKubernetesIpFinder.java:151)}}{{
at
org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi.registeredAddresses(TcpDiscoverySpi.java:1900)}}{{
at
org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi.resolvedAddresses(TcpDiscoverySpi.java:1848)}}{{
at
org.apache.ignite.spi.discovery.tcp.ServerImpl.sendJoinRequestMessage(ServerImpl.java:1049)}}{{
at
org.apache.ignite.spi.discovery.tcp.ServerImpl.joinTopology(ServerImpl.java:910)}}
It's clearly missing a dependency.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] ignite pull request #5575: IGNITE-10535
Github user devozerov closed the pull request at: https://github.com/apache/ignite/pull/5575 ---
[jira] [Created] (IGNITE-10578) SQL: extract schema operations from IgniteH2Indexing into a separate class
Vladimir Ozerov created IGNITE-10578:
Summary: SQL: extract schema operations from IgniteH2Indexing into
a separate class
Key: IGNITE-10578
URL: https://issues.apache.org/jira/browse/IGNITE-10578
Project: Ignite
Issue Type: Task
Components: sql
Reporter: Vladimir Ozerov
Assignee: Vladimir Ozerov
Fix For: 2.8
Same reasoning as with other indexing refactoring tickets (e.g. IGNITE-10535):
decouple unrelated components to simplify further development. At this point
{{IgniteH2Indexing}} is critically overwhelmed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] ignite pull request #5453: IGNITE-10355 Tx rollback failure on put operation...
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/5453 ---
[jira] [Created] (IGNITE-10579) IgniteCacheContinuousQueryReconnectTest.testReconnectServer is flaky in master.
Amelchev Nikita created IGNITE-10579:
Summary:
IgniteCacheContinuousQueryReconnectTest.testReconnectServer is flaky in master.
Key: IGNITE-10579
URL: https://issues.apache.org/jira/browse/IGNITE-10579
Project: Ignite
Issue Type: Bug
Reporter: Amelchev Nikita
Assignee: Amelchev Nikita
Next tests are flaky in master:
IgniteCacheContinuousQueryReconnectTest.testReconnectServer
IgniteCacheContinuousQueryReconnectTest.testReconnectClient
Test exception:
{noformat}
junit.framework.AssertionFailedError: expected:<2> but was:<1>
at
org.apache.ignite.internal.processors.cache.query.continuous.IgniteCacheContinuousQueryReconnectTest.putAndCheck(IgniteCacheContinuousQueryReconnectTest.java:111)
at
org.apache.ignite.internal.processors.cache.query.continuous.IgniteCacheContinuousQueryReconnectTest.testReconnect(IgniteCacheContinuousQueryReconnectTest.java:179)
at
org.apache.ignite.internal.processors.cache.query.continuous.IgniteCacheContinuousQueryReconnectTest.testReconnectServer(IgniteCacheContinuousQueryReconnectTest.java:93)
{noformat}
[Test
history.|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=-4837559557126450615&branch=%3Cdefault%3E&tab=testDetails]
By logs I found that possible reason is that started node doesn't see cluster:
{noformat}
startGrid(0);
Topology snapshot [ver=1, locNode=0b292f90, servers=1, clients=0
startGrid(1); //client
Topology snapshot [ver=2, locNode=0b292f90, servers=1, clients=1
Topology snapshot [ver=2, locNode=693848f6, servers=1, clients=1
startGrid(2);
Topology snapshot [ver=3, locNode=0b292f90, servers=2, clients=1
Topology snapshot [ver=3, locNode=693848f6, servers=2, clients=1
Topology snapshot [ver=3, locNode=99a406a5, servers=2, clients=1
stopGrid(0);
Topology snapshot [ver=4, locNode=99a406a5, servers=1, clients=1
Topology snapshot [ver=4, locNode=693848f6, servers=1, clients=1
startGrid(3);
Topology snapshot [ver=1, locNode=8d9ef192, servers=1, clients=0
{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] ignite pull request #5591: IGNITE-10579 IgniteCacheContinuousQueryReconnectT...
GitHub user NSAmelchev opened a pull request: https://github.com/apache/ignite/pull/5591 IGNITE-10579 IgniteCacheContinuousQueryReconnectTest.testReconnectServer is flaky in master. PR for TC mass runs You can merge this pull request into a Git repository by running: $ git pull https://github.com/NSAmelchev/ignite ignite-10579 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5591.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5591 commit e6be7501a5e9582c8de533ed0cd9e14e438b51fa Author: NSAmelchev Date: 2018-12-06T15:03:53Z Test mass runs ---
Re: [ANNOUNCE] Apache Ignite 2.7.0 Released
Nikolay, Could you confirm that all of the "Post-release steps" have been completed and you don't need help with any? For instance, there is a WebConsole related bullet point. https://cwiki.apache.org/confluence/display/IGNITE/Release+Process Prachi, please release the new website pages. Dmitriy P, there were some security related changes. Please go ahead and uncover them. -- Denis On Thu, Dec 6, 2018 at 4:02 AM Nikolay Izhikov wrote: > Done. > > чт, 6 дек. 2018 г. в 14:41, Dmitriy Pavlov : > > > According to previous > > > > > https://lists.apache.org/thread.html/4dd772a607ba89b3aaa2084a1ebcd2f4e6a9790decad4d167b2dbd73@%3Cdev.ignite.apache.org%3E > > it > > seems to be To: annou...@apache.org, dev , > > u...@ignite.apache.org > > > > чт, 6 дек. 2018 г. в 14:30, Nikolay Izhikov : > > > > > Dmitriy. > > > > > > Yes, we should. Please, tell me mail of this channel. > > > > > > чт, 6 дек. 2018 г., 14:13 Dmitriy Pavlov dpav...@apache.org: > > > > > > > Nikolay, thank you for your efforts! > > > > > > > > Should we announce a release in a special Apache-wide channel? > > > > > > > > чт, 6 дек. 2018 г. в 10:36, Nikolay Izhikov : > > > > > > > > > The Apache Ignite Community is pleased to announce the release of > > > > > Apache Ignite 2.7.0. > > > > > > > > > > Apache Ignite [1] is a memory-centric distributed database, > caching, > > > > > and processing platform for transactional, analytical, and > streaming > > > > > workloads delivering in-memory speeds at petabyte scale. > > > > > > > > > > This release introduce several major features and fixes some > critical > > > > > issues > > > > > https://ignite.apache.org/releases/2.7.0/release_notes.html > > > > > > > > > > Download the latest Ignite version from here: > > > > > https://ignite.apache.org/download.cgi > > > > > > > > > > Please let us know [2] if you encounter any problems. > > > > > > > > > > Regards, > > > > > Nikolay Izhikov on behalf of Apache Ignite community > > > > > > > > > > [1] https://ignite.apache.org > > > > > [2] https://ignite.apache.org/community/resources.html#ask > > > > > > > > > > > > > > >
[GitHub] ignite pull request #5592: IGNITE-10580 H2 connection and statements are reu...
GitHub user tledkov-gridgain opened a pull request: https://github.com/apache/ignite/pull/5592 IGNITE-10580 H2 connection and statements are reused invalid for local sql queries You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10580 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5592.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5592 commit 1ebdf5ae5b59a8780003db8a6deac0e2d259bab9 Author: tledkov Date: 2018-12-06T15:41:50Z IGNITE-10580: add test to reproduce commit 614d1b194bdb97d83e87893aa3a5462c970bb2c4 Author: tledkov Date: 2018-12-06T15:43:27Z IGNITE-10580: test cleanup ---
[GitHub] ignite pull request #5496: IGNITE-9980 Modify ./control.sh --cache idle_veri...
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/5496 ---
[jira] [Created] (IGNITE-10580) H2 connection and statements are reused invalid for local sql queries
Taras Ledkov created IGNITE-10580:
-
Summary: H2 connection and statements are reused invalid for local
sql queries
Key: IGNITE-10580
URL: https://issues.apache.org/jira/browse/IGNITE-10580
Project: Ignite
Issue Type: Bug
Components: sql
Affects Versions: 2.7
Reporter: Taras Ledkov
Assignee: Taras Ledkov
Fix For: 2.8
The threadlocal connection & statement cache is used invalid for local queries.
Steps to reproduce:
# Open iterator for Query0
# In the same thread open one more iterator for Query1 (SQl statement must be
equals to Query0 and doesn't contains query parameters)
# Fetch from the first iterator.
The exception {{The object is already closed [90007-197]}} will be thrown.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (IGNITE-10581) Document new flag to filter cache types in control.sh
Alexey Goncharuk created IGNITE-10581: - Summary: Document new flag to filter cache types in control.sh Key: IGNITE-10581 URL: https://issues.apache.org/jira/browse/IGNITE-10581 Project: Ignite Issue Type: Task Components: documentation Reporter: Alexey Goncharuk -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ignite pull request #5593: IGNITE-10578
GitHub user devozerov opened a pull request: https://github.com/apache/ignite/pull/5593 IGNITE-10578 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10578 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5593.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5593 commit 495d94aaa1d0c3c603028bf20d34515f7cf5e31d Author: devozerov Date: 2018-12-06T14:15:05Z Minors. commit ff0b7dc7a154ec81a4ff3202081ada811b71ae46 Author: devozerov Date: 2018-12-06T14:50:29Z Merge branch 'master' into ignite-10578 commit 2959e4caff38f995ba479c771b0d51fad2c381ed Author: devozerov Date: 2018-12-06T15:24:32Z WIP. commit 7ad2e5aa3c986e1e0a0ac000fafb924405227339 Author: devozerov Date: 2018-12-06T15:28:56Z WIP (dangerous). commit 7055071aa5310a6916c79505bb622aed2b926880 Author: devozerov Date: 2018-12-06T15:30:33Z WIP. commit a2d1eea2a9bbe7d628ded00d5d293692e5f2ae43 Author: devozerov Date: 2018-12-06T15:42:22Z Extracted "createTable". commit 165f693bd250e6f3e66483bfd134ae908084ebf8 Author: devozerov Date: 2018-12-06T15:52:25Z Moved DDL commands. commit 9a988c9d271150ec50004497d9cfdc9f273ad5e6 Author: devozerov Date: 2018-12-06T15:55:45Z Minors. commit 1c265cb2fdce2c35077aec1671951a38c7f2bf03 Author: devozerov Date: 2018-12-06T15:57:24Z Minors. ---
[jira] [Created] (IGNITE-10582) MVCC: Error on txLog initialization.
Roman Kondakov created IGNITE-10582:
---
Summary: MVCC: Error on txLog initialization.
Key: IGNITE-10582
URL: https://issues.apache.org/jira/browse/IGNITE-10582
Project: Ignite
Issue Type: Bug
Components: mvcc
Reporter: Roman Kondakov
A sporadic error occurs during txLog initialization. Reproducer:
{{IgnitePdsCacheAssignmentNodeRestartsTest#testAssignmentAfterRestarts.}}
Stacktrace:
{noformat}
javax.cache.CacheException: class org.apache.ignite.IgniteCheckedException:
Failed to complete exchange process.
at
org.apache.ignite.internal.processors.cache.GridCacheUtils.convertToCacheException(GridCacheUtils.java:1337)
at
org.apache.ignite.internal.IgniteKernal.getOrCreateCaches(IgniteKernal.java:3068)
at
org.apache.ignite.internal.processors.cache.persistence.IgnitePdsCacheAssignmentNodeRestartsTest.testAssignmentAfterRestarts(IgnitePdsCacheAssignmentNodeRestartsTest.java:148)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at junit.framework.TestCase.runTest(TestCase.java:176)
at
org.apache.ignite.testframework.junits.GridAbstractTest.access$001(GridAbstractTest.java:149)
at
org.apache.ignite.testframework.junits.GridAbstractTest$6.evaluate(GridAbstractTest.java:2106)
at
org.apache.ignite.testframework.junits.GridAbstractTest$7.run(GridAbstractTest.java:2123)
at java.lang.Thread.run(Thread.java:748)
Caused by: class org.apache.ignite.IgniteCheckedException: Failed to complete
exchange process.
at
org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture.createExchangeException(GridDhtPartitionsExchangeFuture.java:3041)
at
org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture.sendExchangeFailureMessage(GridDhtPartitionsExchangeFuture.java:3069)
at
org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture.finishExchangeOnCoordinator(GridDhtPartitionsExchangeFuture.java:3151)
at
org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture.onAllReceived(GridDhtPartitionsExchangeFuture.java:3135)
at
org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture.processSingleMessage(GridDhtPartitionsExchangeFuture.java:2748)
at
org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture.access$100(GridDhtPartitionsExchangeFuture.java:138)
at
org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture$2.apply(GridDhtPartitionsExchangeFuture.java:2556)
at
org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture$2.apply(GridDhtPartitionsExchangeFuture.java:2544)
at
org.apache.ignite.internal.util.future.GridFutureAdapter.notifyListener(GridFutureAdapter.java:395)
at
org.apache.ignite.internal.util.future.GridFutureAdapter.listen(GridFutureAdapter.java:355)
at
org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture.onReceiveSingleMessage(GridDhtPartitionsExchangeFuture.java:2544)
at
org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager.processSinglePartitionUpdate(GridCachePartitionExchangeManager.java:1807)
at
org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager.access$1200(GridCachePartitionExchangeManager.java:145)
at
org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager$2.onMessage(GridCachePartitionExchangeManager.java:382)
at
org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager$2.onMessage(GridCachePartitionExchangeManager.java:340)
at
org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager$MessageHandler.apply(GridCachePartitionExchangeManager.java:3294)
at
org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager$MessageHandler.apply(GridCachePartitionExchangeManager.java:3273)
at
org.apache.ignite.internal.processors.cache.GridCacheIoManager.processMessage(GridCacheIoManager.java:1059)
at
org.apache.ignite.internal.processors.cache.GridCacheIoManager.onMessage0(GridCacheIoManager.java:584)
at
org.apache.ignite.internal.processors.cache.GridCacheIoManager.handleMessage(GridCacheIoManager.java:383)
at
org.apache.ignite.internal.processors
Re: [jira] [Created] (IGNITE-10577) ignite-kubernetes is missing jackson-annotations dependency
Not sure what the etiquette on this is, but this is a regression in 2.7. I
added a simple patch to the ticket.
Regards,
Stephen
> On 6 Dec 2018, at 14:42, Stephen Darlington (JIRA) wrote:
>
> Stephen Darlington created IGNITE-10577:
> ---
>
> Summary: ignite-kubernetes is missing jackson-annotations
> dependency
> Key: IGNITE-10577
> URL: https://issues.apache.org/jira/browse/IGNITE-10577
> Project: Ignite
> Issue Type: Bug
> Components: build
>Affects Versions: 2.7
>Reporter: Stephen Darlington
>Assignee: Stephen Darlington
>
>
> When starting 2.7 with the ignite-kubernetes option I get the following
> exception on startup:
>
> {{[13:44:34,605][SEVERE][main][IgniteKernal] Got exception while starting
> (will rollback startup routine).}}{{java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/annotation/JsonView}}{{ at
> com.fasterxml.jackson.databind.introspect.JacksonAnnotationIntrospector.(JacksonAnnotationIntrospector.java:37)}}{{
> at
> com.fasterxml.jackson.databind.ObjectMapper.(ObjectMapper.java:291)}}{{
> at
> org.apache.ignite.spi.discovery.tcp.ipfinder.kubernetes.TcpDiscoveryKubernetesIpFinder.getRegisteredAddresses(TcpDiscoveryKubernetesIpFinder.java:151)}}{{
> at
> org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi.registeredAddresses(TcpDiscoverySpi.java:1900)}}{{
> at
> org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi.resolvedAddresses(TcpDiscoverySpi.java:1848)}}{{
> at
> org.apache.ignite.spi.discovery.tcp.ServerImpl.sendJoinRequestMessage(ServerImpl.java:1049)}}{{
> at
> org.apache.ignite.spi.discovery.tcp.ServerImpl.joinTopology(ServerImpl.java:910)}}
>
> It's clearly missing a dependency.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
[GitHub] asfgit closed pull request #93: IGNITE-10519 JavaDocs added
asfgit closed pull request #93: IGNITE-10519 JavaDocs added
URL: https://github.com/apache/ignite-teamcity-bot/pull/93
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/jira/IJiraIntegration.java
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/jira/IJiraIntegration.java
index f7f34e1f..d952b2fd 100644
---
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/jira/IJiraIntegration.java
+++
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/jira/IJiraIntegration.java
@@ -21,19 +21,23 @@
import org.apache.ignite.ci.user.ICredentialsProv;
/**
- *
+ * Reperesents methods to provide interaction with Jira servers.
*/
public interface IJiraIntegration {
/** Message to show user when JIRA ticket was successfully commented by
the Bot. */
public static String JIRA_COMMENTED = "JIRA commented.";
/**
+ * Produce visa message(see {@link Visa}) based on passed
+ * parameters and publish it as a comment for specified ticket
+ * on Jira server.
+ *
* @param srvId TC Server ID to take information about token from.
* @param prov Credentials.
* @param buildTypeId Suite name.
* @param branchForTc Branch for TeamCity.
* @param ticket JIRA ticket full name. E.g. IGNITE-
- * @return {@code True} if JIRA was notified.
+ * @return {@link Visa} instance.
*/
public Visa notifyJira(String srvId, ICredentialsProv prov, String
buildTypeId, String branchForTc,
String ticket);
@@ -44,9 +48,17 @@ public Visa notifyJira(String srvId, ICredentialsProv prov,
String buildTypeId,
/** */
public void init(String srvId);
-/** */
+/**
+ * @param ticketFullName Ticket full name (e.g IGNITE-8331)
+ *
+ * @return URL which is used as link to Jira ticket with specified name.
+ */
public String generateTicketUrl(String ticketFullName);
-/** */
+/**
+ * @param ticketFullName Ticket full name (e.g IGNITE-8331)
+ *
+ * @return URL which is used as link to Jira comment with specified id.
+ */
public String generateCommentUrl(String ticketFullName, int commentId);
}
diff --git
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/jira/JiraIntegrationProvider.java
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/jira/JiraIntegrationProvider.java
index b841df34..62a66185 100644
---
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/jira/JiraIntegrationProvider.java
+++
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/jira/JiraIntegrationProvider.java
@@ -27,7 +27,9 @@
import org.apache.ignite.ci.util.ExceptionUtil;
/**
- *
+ * Class for providing {@link IJiraIntegration} instance for specified Jira
+ * server. Instance for each server is cached with defining instance
+ * expiration time.
*/
public class JiraIntegrationProvider implements IJiraIntegrationProvider {
/** */
diff --git
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/jira/package-info.java
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/jira/package-info.java
new file mode 100644
index ..6b4e5b78
--- /dev/null
+++
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/jira/package-info.java
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/**
+ * This package is inteneded for interracting with Jira servers. It contains
+ * classes which is needed for injection Jira integration service instance
+ * via Guice. And interfaces and classes which provide specified functionality.
+ */
+package org.apache.ignite.ci.jira;
diff --git
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildObserver.java
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildObserver.java
index 98287d2e..4918c32d 100644
---
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildObserver.java
+++
b/ignite-tc-helper-web/src/main/j
[jira] [Created] (IGNITE-10583) MVCC: Assertion in txLog state update when recovering from WAL.
Roman Kondakov created IGNITE-10583:
---
Summary: MVCC: Assertion in txLog state update when recovering
from WAL.
Key: IGNITE-10583
URL: https://issues.apache.org/jira/browse/IGNITE-10583
Project: Ignite
Issue Type: Bug
Components: mvcc
Reporter: Roman Kondakov
Assertion in txLog state update occurs sporadically during recovery from WAL.
Reproducer:
{{IgnitePdsContinuousRestartTest#testRebalancingDuringLoad_10_10_1_1}} with
enabled MVCC.
Stacktrace:
{noformat}
class
org.apache.ignite.internal.processors.cache.persistence.tree.CorruptedTreeException:
Runtime failure on search row: TxKey [major=1544121790766, minor=10468]
at
org.apache.ignite.internal.processors.cache.persistence.tree.BPlusTree.invoke(BPlusTree.java:1812)
at
org.apache.ignite.internal.processors.cache.mvcc.txlog.TxLog.put(TxLog.java:245)
at
org.apache.ignite.internal.processors.cache.mvcc.MvccProcessorImpl.updateState(MvccProcessorImpl.java:609)
at
org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager.applyLogicalUpdates(GridCacheDatabaseSharedManager.java:2456)
at
org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager.startMemoryRestore(GridCacheDatabaseSharedManager.java:1934)
at org.apache.ignite.internal.IgniteKernal.start(IgniteKernal.java:1050)
at
org.apache.ignite.internal.IgnitionEx$IgniteNamedInstance.start0(IgnitionEx.java:2040)
at
org.apache.ignite.internal.IgnitionEx$IgniteNamedInstance.start(IgnitionEx.java:1732)
at org.apache.ignite.internal.IgnitionEx.start0(IgnitionEx.java:1158)
at org.apache.ignite.internal.IgnitionEx.start(IgnitionEx.java:656)
at
org.apache.ignite.testframework.junits.GridAbstractTest.startGrid(GridAbstractTest.java:961)
at
org.apache.ignite.testframework.junits.GridAbstractTest.startGrid(GridAbstractTest.java:902)
at
org.apache.ignite.testframework.junits.GridAbstractTest.startGrid(GridAbstractTest.java:890)
at
org.apache.ignite.testframework.junits.GridAbstractTest.startGrid(GridAbstractTest.java:856)
at
org.apache.ignite.internal.processors.cache.persistence.IgnitePdsContinuousRestartTest.checkRebalancingDuringLoad(IgnitePdsContinuousRestartTest.java:302)
at
org.apache.ignite.internal.processors.cache.persistence.IgnitePdsContinuousRestartTest.testRebalancingDuringLoad_10_10_1_1(IgnitePdsContinuousRestartTest.java:221)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at junit.framework.TestCase.runTest(TestCase.java:176)
at
org.apache.ignite.testframework.junits.GridAbstractTest.access$001(GridAbstractTest.java:149)
at
org.apache.ignite.testframework.junits.GridAbstractTest$6.evaluate(GridAbstractTest.java:2106)
at
org.apache.ignite.testframework.junits.GridAbstractTest$7.run(GridAbstractTest.java:2123)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.IllegalStateException: Unexpected new transaction state.
[currState=2, newState=3, cntr=10468]
at
org.apache.ignite.internal.processors.cache.mvcc.txlog.TxLog$TxLogUpdateClosure.invalid(TxLog.java:581)
at
org.apache.ignite.internal.processors.cache.mvcc.txlog.TxLog$TxLogUpdateClosure.checkAborted(TxLog.java:562)
at
org.apache.ignite.internal.processors.cache.mvcc.txlog.TxLog$TxLogUpdateClosure.call(TxLog.java:451)
at
org.apache.ignite.internal.processors.cache.mvcc.txlog.TxLog$TxLogUpdateClosure.call(TxLog.java:393)
at
org.apache.ignite.internal.processors.cache.persistence.tree.BPlusTree$Invoke.invokeClosure(BPlusTree.java:3755)
at
org.apache.ignite.internal.processors.cache.persistence.tree.BPlusTree$Invoke.access$5900(BPlusTree.java:3649)
at
org.apache.ignite.internal.processors.cache.persistence.tree.BPlusTree.invokeDown(BPlusTree.java:1901)
at
org.apache.ignite.internal.processors.cache.persistence.tree.BPlusTree.invoke(BPlusTree.java:1779)
... 24 more
{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [ANNOUNCE] Apache Ignite 2.7.0 Released
Nikolay, Nice job on the release! :) When do you expect Nuget packages to be available for the C# client? Thanks, Raymond. On Fri, Dec 7, 2018 at 4:30 AM Denis Magda wrote: > Nikolay, > > Could you confirm that all of the "Post-release steps" have been completed > and you don't need help with any? For instance, there is a WebConsole > related bullet point. > https://cwiki.apache.org/confluence/display/IGNITE/Release+Process > > Prachi, please release the new website pages. > > Dmitriy P, there were some security related changes. Please go ahead and > uncover them. > > -- > Denis > > On Thu, Dec 6, 2018 at 4:02 AM Nikolay Izhikov > wrote: > > > Done. > > > > чт, 6 дек. 2018 г. в 14:41, Dmitriy Pavlov : > > > > > According to previous > > > > > > > > > https://lists.apache.org/thread.html/4dd772a607ba89b3aaa2084a1ebcd2f4e6a9790decad4d167b2dbd73@%3Cdev.ignite.apache.org%3E > > > it > > > seems to be To: annou...@apache.org, dev , > > > u...@ignite.apache.org > > > > > > чт, 6 дек. 2018 г. в 14:30, Nikolay Izhikov : > > > > > > > Dmitriy. > > > > > > > > Yes, we should. Please, tell me mail of this channel. > > > > > > > > чт, 6 дек. 2018 г., 14:13 Dmitriy Pavlov dpav...@apache.org: > > > > > > > > > Nikolay, thank you for your efforts! > > > > > > > > > > Should we announce a release in a special Apache-wide channel? > > > > > > > > > > чт, 6 дек. 2018 г. в 10:36, Nikolay Izhikov : > > > > > > > > > > > The Apache Ignite Community is pleased to announce the release of > > > > > > Apache Ignite 2.7.0. > > > > > > > > > > > > Apache Ignite [1] is a memory-centric distributed database, > > caching, > > > > > > and processing platform for transactional, analytical, and > > streaming > > > > > > workloads delivering in-memory speeds at petabyte scale. > > > > > > > > > > > > This release introduce several major features and fixes some > > critical > > > > > > issues > > > > > > https://ignite.apache.org/releases/2.7.0/release_notes.html > > > > > > > > > > > > Download the latest Ignite version from here: > > > > > > https://ignite.apache.org/download.cgi > > > > > > > > > > > > Please let us know [2] if you encounter any problems. > > > > > > > > > > > > Regards, > > > > > > Nikolay Izhikov on behalf of Apache Ignite community > > > > > > > > > > > > [1] https://ignite.apache.org > > > > > > [2] https://ignite.apache.org/community/resources.html#ask > > > > > > > > > > > > > > > > > > > > >
[GitHub] ignite pull request #5595: IGNITE-10463: MVCC: Create "PDS 3" test suite for...
GitHub user rkondakov opened a pull request: https://github.com/apache/ignite/pull/5595 IGNITE-10463: MVCC: Create "PDS 3" test suite for MVCC mode. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10463 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5595.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5595 commit 58facc0b923cde9569989067def88cae79655b09 Author: rkondakov Date: 2018-12-06T17:02:48Z IGNITE-10463: MVCC: Create "PDS 3" test suite for MVCC mode. ---
[jira] [Created] (IGNITE-10584) MVCC: Wal delta record consistency test failed.
Andrew Mashenkov created IGNITE-10584: - Summary: MVCC: Wal delta record consistency test failed. Key: IGNITE-10584 URL: https://issues.apache.org/jira/browse/IGNITE-10584 Project: Ignite Issue Type: Bug Components: mvcc, persistence Reporter: Andrew Mashenkov -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ignite pull request #4235: IGNITE-7993 Striped pool can't be disabled
Github user gromtech closed the pull request at: https://github.com/apache/ignite/pull/4235 ---
[GitHub] ignite pull request #5596: IGNITE-7993 Striped pool cannot be disabled (upda...
GitHub user gromtech opened a pull request: https://github.com/apache/ignite/pull/5596 IGNITE-7993 Striped pool cannot be disabled (updated javadoc) You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-7993-javadoc-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5596.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5596 commit ffa52dd5003fc8826a2aac1b4fe42dfba50732d7 Author: Roman Guseinov Date: 2018-12-07T01:51:57Z IGNITE-7993 Striped pool cannot be disabled (updated javadoc) ---
[jira] [Created] (IGNITE-10585) JDBC driver returns Double in column metadata for Float type
Ray created IGNITE-10585:
Summary: JDBC driver returns Double in column metadata for Float
type
Key: IGNITE-10585
URL: https://issues.apache.org/jira/browse/IGNITE-10585
Project: Ignite
Issue Type: Bug
Components: jdbc
Reporter: Ray
Assignee: Ray
Fix For: 2.8
When I create a table using
create table c(a varchar, b float, primary key(a));
The meta information for column b is wrong when I use !desc c to check.
0: jdbc:ignite:thin://127.0.0.1/> !desc c
TABLE_CAT
TABLE_SCHEM PUBLIC
TABLE_NAME C
COLUMN_NAME A
DATA_TYPE 12
TYPE_NAME VARCHAR
COLUMN_SIZE null
BUFFER_LENGTH null
DECIMAL_DIGITS null
NUM_PREC_RADIX 10
NULLABLE 1
REMARKS
COLUMN_DEF
SQL_DATA_TYPE 12
SQL_DATETIME_SUB null
CHAR_OCTET_LENGTH 2147483647
ORDINAL_POSITION 1
IS_NULLABLE YES
SCOPE_CATLOG
SCOPE_SCHEMA
SCOPE_TABLE
SOURCE_DATA_TYPE null
IS_AUTOINCREMENT NO
IS_GENERATEDCOLUMN NO
TABLE_CAT
TABLE_SCHEM PUBLIC
TABLE_NAME C
COLUMN_NAME B
DATA_TYPE 8
{color:#d04437}TYPE_NAME DOUBLE{color}
COLUMN_SIZE null
BUFFER_LENGTH null
DECIMAL_DIGITS null
NUM_PREC_RADIX 10
NULLABLE 1
REMARKS
COLUMN_DEF
SQL_DATA_TYPE 8
SQL_DATETIME_SUB null
CHAR_OCTET_LENGTH 2147483647
ORDINAL_POSITION 2
IS_NULLABLE YES
SCOPE_CATLOG
SCOPE_SCHEMA
SCOPE_TABLE
SOURCE_DATA_TYPE null
IS_AUTOINCREMENT NO
IS_GENERATEDCOLUMN NO
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (IGNITE-10586) Ignite OSGI issues
XuQingping created IGNITE-10586:
---
Summary: Ignite OSGI issues
Key: IGNITE-10586
URL: https://issues.apache.org/jira/browse/IGNITE-10586
Project: Ignite
Issue Type: Bug
Components: osgi
Affects Versions: 2.7, 2.6
Reporter: XuQingping
When using the Ignite OSGI feature in Eclipse RCP, there are a lot of Issues:
1.Ignite-core
1) The cache-api-1.0.0.jar package that is included is not fully exported
(for example, no export: javax.cache.configuration), it should be replaced
with: org.apache.servicemix.bundles.javax-cache-api-1.1.0_1 .jar
2) References to unpublished packages such as com.sun.management, which
need to be added at runtime
-Dorg.osgi.framework.system.packages.extra=com.sun.management,sun.misc,sun.nio.ch
2.ignite-spring
1) The spring-x-4.3.16.RELEASE.jar series that comes with it is not
an OSGI packaged version and should be replaced with the corresponding
org.apache.servicemix.bundles version ([http://repo1.maven.org/maven2/org/]
Apache/servicemix/bundles/ Download version 4.3.16)
2) Even if replaced with the org.apache.servicemix.bundles version, since
the org.apache.servicemix.bundles does not reference the ignite-core plugin,
it cannot be dynamically created IgniteConfiguration when loading the Ignite
configuration from the file(OSGI Bundles can only use Java classes exported
by other OSGIBundles that they depend on (or import) (and these
servicemix.bundles obviously have neither dependencies nor import any Ignite
related types)).
Error message :
{code:java}
class org.apache.ignite.IgniteException: Failed to create Ignite component
(consider adding ignite-spring module to classpath) [component=SPRING,
cls=org.apache.ignite.internal.util.spring.IgniteSpringHelperImpl]
at
org.apache.ignite.internal.util.IgniteUtils.convertException(IgniteUtils.java:1025)
at org.apache.ignite.Ignition.start(Ignition.java:401)
at ignite.examp.IgniteExampBase.startStdClient(IgniteExampBase.java:72)
at
ignite.examp.cluster.IgniteComputeExamp.main(IgniteComputeExamp.java:50)
at
ignite.examp.eclipse.IgniteExamp_Application.start(IgniteExamp_Application.java:23)
at
org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:653)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:590)
at org.eclipse.equinox.launcher.Main.run(Main.java:1499)
at org.eclipse.equinox.launcher.Main.main(Main.java:1472)
Caused by: class org.apache.ignite.IgniteCheckedException: Failed to create
Ignite component (consider adding ignite-spring module to classpath)
[component=SPRING,
cls=org.apache.ignite.internal.util.spring.IgniteSpringHelperImpl]
at
org.apache.ignite.internal.IgniteComponentType.componentException(IgniteComponentType.java:320)
at
org.apache.ignite.internal.IgniteComponentType.create0(IgniteComponentType.java:296)
at
org.apache.ignite.internal.IgniteComponentType.create(IgniteComponentType.java:207)
at
org.apache.ignite.internal.IgnitionEx.loadConfigurations(IgnitionEx.java:769)
at org.apache.ignite.internal.IgnitionEx.start(IgnitionEx.java:1032)
at org.apache.ignite.internal.IgnitionEx.start(IgnitionEx.java:982)
at org.apache.ignite.Ignition.start(Ignition.java:398)
... 16 more
Caused by: java.lang.ClassNotFoundException:
org.apache.ignite.internal.util.spring.IgniteSpringHelperImpl cannot be found
by com.cimstech.xlibs.ignite_1.0.0
at
org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:484)
at
org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:395)
at
org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:387)
at
org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:150)
at java.lang.ClassLoader.loadClass(Unknown Source)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Unknown Source)
at
org.apache.ignite.internal.IgniteComponentType.create0(Igni
[GitHub] ignite pull request #4576: Ignite 2.4.5 p3
Github user gromtech closed the pull request at: https://github.com/apache/ignite/pull/4576 ---
[GitHub] ignite pull request #4638: Ignite 2.4.8 p3
Github user gromtech closed the pull request at: https://github.com/apache/ignite/pull/4638 ---
[GitHub] ignite pull request #5597: IGNITE-10585 JDBC driver returns FLOAT in column ...
GitHub user ldzhjn opened a pull request: https://github.com/apache/ignite/pull/5597 IGNITE-10585 JDBC driver returns FLOAT in column metadata for REAL SQL type You can merge this pull request into a Git repository by running: $ git pull https://github.com/ldzhjn/ignite IGNITE-10585 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5597.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5597 commit 3f226a3870c77a9070b368e65a29d99416c7606f Author: rayliu Date: 2018-12-07T02:15:02Z Fix bug commit 24347646acde056b26134a5d9440509566fec686 Author: rayliu Date: 2018-12-07T03:52:14Z Add test ---
[GitHub] ignite pull request #5598: IGNITE-10314 Spark dataframe will get wrong schem...
GitHub user ldzhjn opened a pull request: https://github.com/apache/ignite/pull/5598 IGNITE-10314 Spark dataframe will get wrong schema if user executes add/drop column DDL You can merge this pull request into a Git repository by running: $ git pull https://github.com/ldzhjn/ignite IGNITE-10314 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5598.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5598 commit bcdb69747f9a90fa0f2f9204708c576b72f1de94 Author: rayliu Date: 2018-11-22T06:44:01Z Fix bug commit 8dcc21800a8eb7d1e731c362b4a53860274e85bd Author: rayliu Date: 2018-11-26T06:39:27Z Add tests commit 1d58fdf068b14ac9847a825dca3464148f9b7596 Author: rayliu Date: 2018-11-26T06:53:16Z Optimize imports commit 336a291dd5a330b5e1e824e807187ef1960bb843 Author: rayliu Date: 2018-11-26T07:01:47Z Merge remote-tracking branch 'upstream/master' into IGNITE-10314 commit 304695781ac356ec3f81325c5ce3b244b9f01c8b Author: rayliu Date: 2018-12-06T09:46:28Z Merge remote-tracking branch 'upstream/master' into IGNITE-10314 ---
Hello!
Hello, Igniters! I want to contribute Apache Ignite. My JIRA username is `kanosaki`. Sincerely, Masaki Nakano
[jira] [Created] (IGNITE-10587) Ignite chart history doesnt change
Alexander Kalinin created IGNITE-10587: -- Summary: Ignite chart history doesnt change Key: IGNITE-10587 URL: https://issues.apache.org/jira/browse/IGNITE-10587 Project: Ignite Issue Type: Improvement Reporter: Alexander Kalinin Assignee: Alexander Kalinin Reproducer 1) Wait a bit for data to accumulate 2) Change source of history for chart (f.e. change cluster) 3) Change range Actual: Data from old history is shown merged with current history. Expected: Data is reset for all ranges. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ignite pull request #5581: IGNITE-10552 Web Agent: Improve logging when clus...
Github user akuznetsov-gridgain closed the pull request at: https://github.com/apache/ignite/pull/5581 ---
Re: Hello!
Hello, Masaki Nakano! Welcome to the Apache Software Foundation and to the Apache Ignite Community. I've added your account to the list of contributors. Now you should be able to assign an issue to yourself. Should you have any questions please do not hesitate to ask here. Looking forward to your contributions. Sincerely, Dmitriy Pavlov P.S. Additional references that should boost your onboarding. Please subscribe to both dev@ and user@ lists, optionally you may subscribe to notifications@: https://ignite.apache.org/community/resources.html#mail-lists Get familiar with Apache Ignite development process described here: https://cwiki.apache.org/confluence/display/IGNITE/Development+Process Instructions on how to contribute can be found here: https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute Project setup in Intellij IDEA: https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup Once you got familiar and were able to run a few examples These are the easy tickets to start with: https://issues.apache.org/jira/issues/?jql=project%20%3D%20IGNITE%20AND%20labels%20in%20(newbie)%20and%20status%20%3D%20OPEN пт, 7 дек. 2018 г. в 07:42, Masaki Nakano : > Hello, Igniters! > > I want to contribute Apache Ignite. > My JIRA username is `kanosaki`. > > Sincerely, > Masaki Nakano >
