Re: TX code cleanup (MVCC removal)
Hi, all tickets are closed. Thanks, S. ср, 23 авг. 2023 г. в 19:05, Anton Vinogradov : > MVCC test/suites removal PR was merged. > > Slava, > > I think it would be nice to close (with "will not fix" status) all open > > tickets related to MVCC > > Great idea. > Could I ask you to do this? > > On Wed, Aug 23, 2023 at 6:16 PM Вячеслав Коптилин < > slava.kopti...@gmail.com> > wrote: > > > Hi Anton, > > > > +1 for removal MVCC > > > > I think it would be nice to close (with "will not fix" status) all open > > tickets related to MVCC: > > > > > https://issues.apache.org/jira/browse/IGNITE-12118?jql=project%20%3D%20IGNITE%20AND%20resolution%20%3D%20Unresolved%20%20and%20summary%20~%20%22MVCC%22%20ORDER%20BY%20%20priority%20DESC%2C%20updated%20DESC > > > > WDYT? > > > > Thanks, > > Slava. > > > > вт, 22 авг. 2023 г. в 22:03, Anton Vinogradov : > > > > > Going to merge on green visa obtaining if there are no objections. > > > > > > On Tue, Aug 22, 2023 at 6:47 PM Anton Vinogradov > wrote: > > > > > > > MVCC test/suites removal PR [1] is almost ready, fixing final > failures. > > > > > > > > Does anybody ready to review the PR? > > > > > > > > I've rechecked each modified line before pushing the commit button, > is > > > > this enough? > > > > > > > > [1] https://github.com/apache/ignite/pull/10900 > > > > > > > > On Thu, Aug 17, 2023 at 1:18 PM Anton Vinogradov > > wrote: > > > > > > > >> Great, starting the removal. > > > >> > > > >> On Wed, Aug 16, 2023 at 5:35 PM Ivan Daschinsky < > ivanda...@gmail.com> > > > >> wrote: > > > >> > > > >>> The plan looks good to me. Some of the tests are in the ODBC test > > > suite, > > > >>> so > > > >>> i can help if needed. > > > >>> > > > >>> ср, 16 авг. 2023 г. в 16:32, Anton Vinogradov : > > > >>> > > > >>> > Igniters, > > > >>> > > > > >>> > I started the TX code cleanup [1] last month and almost finished > > with > > > >>> the > > > >>> > obvious garbage. > > > >>> > Now, started the code deduplication, I was faced with code > > > >>> overcomplexity > > > >>> > because of unfinished MVCC. > > > >>> > > > > >>> > The community agreed to remove MVCC, but the initial attempt [2] > > was > > > >>> not > > > >>> > successful because of the impossibility to get rid of 20k+ lines > of > > > the > > > >>> > code at once. > > > >>> > So, my proposal is to remove it step by step. > > > >>> > > > > >>> > 1) MVCC tests should be removed from the project > > > >>> > 2) MVCC-related code should be removed from the project by > > reasonably > > > >>> sized > > > >>> > commits, checking it does not affect the existing tests. > > > >>> > > > > >>> > I'm ready to perform the removal. > > > >>> > > > > >>> > Any objections/tips? > > > >>> > > > > >>> > [1] https://issues.apache.org/jira/browse/IGNITE-19844 > > > >>> > [2] https://issues.apache.org/jira/browse/IGNITE-13871 > > > >>> > > > > >>> > > > >>> > > > >>> -- > > > >>> Sincerely yours, Ivan Daschinskiy > > > >>> > > > >> > > > > > >
Re: Removal of ignite ml module (or moving it to extensions)
+1 for moving to extensions This module is good as an extension: - does not depend on the internal Ignite API, - the released module will be compatible with any required version of Ignite using the provided dependency scope. Ivan, I have reviewed your patch, LGTM. чт, 17 авг. 2023 г. в 17:06, Dmitry Pavlov : > > +1 for Apache Way in decision making (it states there should not be time > pressure for the decision making). > > 0 for removal > 0 for moving to extensions > > but since Aleksei is an expert here, it makes sense to me to wait for him. > > Sincerely, > Dmitriy Pavlov > > On 2023/08/16 17:32:55 Aleksei Zinovev wrote: > > Hi, I have objection for fast merging, (not for moving) as a module > > maintainer. > > > > I never used ignite extension, need a time to be familiar with it and test > > the pr. > > > > Please postpone it till 10 september. > > > > I don't understand reasons to do it so fast. I suppose it's ok to wait > > 15-20 days with PR > > > > Thanks for collaboration and doing this work. > > -- Best wishes, Amelchev Nikita
Re: TX code cleanup (MVCC removal)
Folks, I'm on vacation in the next few weeks, will continue in September. On Thu, Aug 24, 2023 at 10:41 PM Вячеслав Коптилин wrote: > Hello Anton, > > Hmm, I am a bit confused, to be honest. > IMHO, this simple JIRA cleanup could be done under > https://issues.apache.org/jira/browse/IGNITE-13871 which is assigned to > you. Is it required to delegate? > > Best regards, > S. > > ср, 23 авг. 2023 г. в 19:05, Anton Vinogradov : > > > MVCC test/suites removal PR was merged. > > > > Slava, > > > I think it would be nice to close (with "will not fix" status) all open > > > tickets related to MVCC > > > > Great idea. > > Could I ask you to do this? > > > > On Wed, Aug 23, 2023 at 6:16 PM Вячеслав Коптилин < > > slava.kopti...@gmail.com> > > wrote: > > > > > Hi Anton, > > > > > > +1 for removal MVCC > > > > > > I think it would be nice to close (with "will not fix" status) all open > > > tickets related to MVCC: > > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-12118?jql=project%20%3D%20IGNITE%20AND%20resolution%20%3D%20Unresolved%20%20and%20summary%20~%20%22MVCC%22%20ORDER%20BY%20%20priority%20DESC%2C%20updated%20DESC > > > > > > WDYT? > > > > > > Thanks, > > > Slava. > > > > > > вт, 22 авг. 2023 г. в 22:03, Anton Vinogradov : > > > > > > > Going to merge on green visa obtaining if there are no objections. > > > > > > > > On Tue, Aug 22, 2023 at 6:47 PM Anton Vinogradov > > wrote: > > > > > > > > > MVCC test/suites removal PR [1] is almost ready, fixing final > > failures. > > > > > > > > > > Does anybody ready to review the PR? > > > > > > > > > > I've rechecked each modified line before pushing the commit button, > > is > > > > > this enough? > > > > > > > > > > [1] https://github.com/apache/ignite/pull/10900 > > > > > > > > > > On Thu, Aug 17, 2023 at 1:18 PM Anton Vinogradov > > > wrote: > > > > > > > > > >> Great, starting the removal. > > > > >> > > > > >> On Wed, Aug 16, 2023 at 5:35 PM Ivan Daschinsky < > > ivanda...@gmail.com> > > > > >> wrote: > > > > >> > > > > >>> The plan looks good to me. Some of the tests are in the ODBC test > > > > suite, > > > > >>> so > > > > >>> i can help if needed. > > > > >>> > > > > >>> ср, 16 авг. 2023 г. в 16:32, Anton Vinogradov : > > > > >>> > > > > >>> > Igniters, > > > > >>> > > > > > >>> > I started the TX code cleanup [1] last month and almost > finished > > > with > > > > >>> the > > > > >>> > obvious garbage. > > > > >>> > Now, started the code deduplication, I was faced with code > > > > >>> overcomplexity > > > > >>> > because of unfinished MVCC. > > > > >>> > > > > > >>> > The community agreed to remove MVCC, but the initial attempt > [2] > > > was > > > > >>> not > > > > >>> > successful because of the impossibility to get rid of 20k+ > lines > > of > > > > the > > > > >>> > code at once. > > > > >>> > So, my proposal is to remove it step by step. > > > > >>> > > > > > >>> > 1) MVCC tests should be removed from the project > > > > >>> > 2) MVCC-related code should be removed from the project by > > > reasonably > > > > >>> sized > > > > >>> > commits, checking it does not affect the existing tests. > > > > >>> > > > > > >>> > I'm ready to perform the removal. > > > > >>> > > > > > >>> > Any objections/tips? > > > > >>> > > > > > >>> > [1] https://issues.apache.org/jira/browse/IGNITE-19844 > > > > >>> > [2] https://issues.apache.org/jira/browse/IGNITE-13871 > > > > >>> > > > > > >>> > > > > >>> > > > > >>> -- > > > > >>> Sincerely yours, Ivan Daschinskiy > > > > >>> > > > > >> > > > > > > > > > >
Re: [PROPOSAL] Move Ignite 2.x to JDK11 compilation
+1. It's time to do it at last. пт, 25 авг. 2023 г. в 12:06, Peter Ivanov : > Mostly, yes. > > In other words - proposal is about starting shipping Apache Ignite releases > with JDK11 compiled binaries thus dropping JDK8-10 runtime support. > > пт, 25 авг. 2023 г. в 12:03, Anton Vinogradov : > > > I looks like you're proposing not migration to 2.11 (because it is > already > > supported), but Java 8-9 support dropping. > > > > On Fri, Aug 25, 2023 at 11:54 AM Peter Ivanov > wrote: > > > > > Hi, Igniters! > > > > > > > > > I would like to propose the next, if you don't mind me saying, > > > revolutionary step forward in our project: moving Ignite 2.x > compilation > > to > > > JDK11 minimum version. > > > I'd rather not make arguments, pros and cons other that currently exist > > in > > > Java world - you know them better than me. Let's just say that it seems > > > that time has come - consider at least that JDK11 as the LTS version is > > > already about 4 and a half years on the go, and Ignite 3.x started from > > > JDK11 right away. > > > > > > This change may possibly require from us additional efforts on > supporting > > > the last version with JDK8 in terms of releasing additional patches and > > > hotfixes a bit longer than usual. However, this is up to the community > to > > > decide. > > > > > > Currently, Apache Ignite 2.x (with Extensions as well) is already > > prepared > > > for being compiled with JDK11 and almost all tests are passing. If we > > come > > > to an agreement about this proposal and designate the next version that > > > will become the first to provide JDK11 compiled binaries - I am ready > to > > > start the process of updating the TeamCity building project > accordingly. > > > > > > > > > Please, share your thoughts. > > > > > > -- Sincerely yours, Ivan Daschinskiy
Re: [PROPOSAL] Move Ignite 2.x to JDK11 compilation
Mostly, yes. In other words - proposal is about starting shipping Apache Ignite releases with JDK11 compiled binaries thus dropping JDK8-10 runtime support. пт, 25 авг. 2023 г. в 12:03, Anton Vinogradov : > I looks like you're proposing not migration to 2.11 (because it is already > supported), but Java 8-9 support dropping. > > On Fri, Aug 25, 2023 at 11:54 AM Peter Ivanov wrote: > > > Hi, Igniters! > > > > > > I would like to propose the next, if you don't mind me saying, > > revolutionary step forward in our project: moving Ignite 2.x compilation > to > > JDK11 minimum version. > > I'd rather not make arguments, pros and cons other that currently exist > in > > Java world - you know them better than me. Let's just say that it seems > > that time has come - consider at least that JDK11 as the LTS version is > > already about 4 and a half years on the go, and Ignite 3.x started from > > JDK11 right away. > > > > This change may possibly require from us additional efforts on supporting > > the last version with JDK8 in terms of releasing additional patches and > > hotfixes a bit longer than usual. However, this is up to the community to > > decide. > > > > Currently, Apache Ignite 2.x (with Extensions as well) is already > prepared > > for being compiled with JDK11 and almost all tests are passing. If we > come > > to an agreement about this proposal and designate the next version that > > will become the first to provide JDK11 compiled binaries - I am ready to > > start the process of updating the TeamCity building project accordingly. > > > > > > Please, share your thoughts. > > >
Re: [ANNOUNCE] Welcome Aleksandr Polovtsev as a new committer
Congratulations, keep it going! пн, 21 авг. 2023 г. в 12:39, Aleksandr Polovtsev : > Thank you, dear Igniters! > > On Mon, Aug 21, 2023 at 10:04 AM Вячеслав Коптилин < > slava.kopti...@gmail.com> > wrote: > > > Congratulations, Alexander! Keep it up! > > > > Thanks, > > S. > > > > пн, 21 авг. 2023 г. в 09:14, Roman Puchkovskiy < > > roman.puchkovs...@gmail.com > > >: > > > > > Congratulations! > > > > > > пн, 21 авг. 2023 г. в 09:29, Pavel Tupitsyn : > > > > > > > > Congratulations, Aleksandr! Well deserved! > > > > > > > > On Mon, Aug 21, 2023 at 8:01 AM Kseniya Romanova < > > ksroman...@apache.org> > > > > wrote: > > > > > > > > > Igniters! > > > > > > > > > > The Project Management Committee (PMC) for Apache Ignite has > invited > > > > > Aleksandr > > > > > Polovtsev to become a committer and we are pleased to announce that > > he > > > has > > > > > accepted. > > > > > > > > > > Alexandr makes valuable contributions to the Apache Ignite code > > > (including > > > > > Node Join Protocol and Initialization[1] for the Ignite 3), > > > participates in > > > > > important dev discussions and contributes as well to the Project > > > awareness > > > > > by presenting twice at the Ignite Summit[2] > > > > > > > > > > Please join me in welcoming Alexandr, and congratulating him on the > > new > > > > > role in the Apache Ignite Community! > > > > > > > > > > > > > > > Kseniya Romanova > > > > > > > > > > on behalf of Apache Ignite PMC > > > > > > > > > > [1] > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-77%3A+Node+Join+Protocol+and+Initialization+for+Ignite+3 > > > > > > > > > > > > > > > [2] https://ignite-summit.org/2023-june/sessions/484805 > > > > > https://ignite-summit.org/2022-june/sessions/337234 > > > > > > > > > > > > > -- > With regards, > Aleksandr Polovtsev >
Re: [PROPOSAL] Move Ignite 2.x to JDK11 compilation
I looks like you're proposing not migration to 2.11 (because it is already supported), but Java 8-9 support dropping. On Fri, Aug 25, 2023 at 11:54 AM Peter Ivanov wrote: > Hi, Igniters! > > > I would like to propose the next, if you don't mind me saying, > revolutionary step forward in our project: moving Ignite 2.x compilation to > JDK11 minimum version. > I'd rather not make arguments, pros and cons other that currently exist in > Java world - you know them better than me. Let's just say that it seems > that time has come - consider at least that JDK11 as the LTS version is > already about 4 and a half years on the go, and Ignite 3.x started from > JDK11 right away. > > This change may possibly require from us additional efforts on supporting > the last version with JDK8 in terms of releasing additional patches and > hotfixes a bit longer than usual. However, this is up to the community to > decide. > > Currently, Apache Ignite 2.x (with Extensions as well) is already prepared > for being compiled with JDK11 and almost all tests are passing. If we come > to an agreement about this proposal and designate the next version that > will become the first to provide JDK11 compiled binaries - I am ready to > start the process of updating the TeamCity building project accordingly. > > > Please, share your thoughts. >
[PROPOSAL] Move Ignite 2.x to JDK11 compilation
Hi, Igniters! I would like to propose the next, if you don't mind me saying, revolutionary step forward in our project: moving Ignite 2.x compilation to JDK11 minimum version. I'd rather not make arguments, pros and cons other that currently exist in Java world - you know them better than me. Let's just say that it seems that time has come - consider at least that JDK11 as the LTS version is already about 4 and a half years on the go, and Ignite 3.x started from JDK11 right away. This change may possibly require from us additional efforts on supporting the last version with JDK8 in terms of releasing additional patches and hotfixes a bit longer than usual. However, this is up to the community to decide. Currently, Apache Ignite 2.x (with Extensions as well) is already prepared for being compiled with JDK11 and almost all tests are passing. If we come to an agreement about this proposal and designate the next version that will become the first to provide JDK11 compiled binaries - I am ready to start the process of updating the TeamCity building project accordingly. Please, share your thoughts.
