clang-tidy
clang-tidy is a nice tool for catching likely bugs and definitely poor
syntax. You can use it on your latest patch with:
git diff asf-gerrit/master |
"${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/share/clang/clang-tidy-diff.py"
-clang-tidy-binary
"${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/bin/clang-tidy" -p 1
You can check the whole repo with:
bin/run_clang_tidy.sh
The latter produces a lot of output and takes 10-15 minutes. Warnings
are lines that end in ']'.
Time permitting, I will expand the checks we use and try to integrate
this into tests or code review tools. I added it to the wiki:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65868536
Re: clang-tidy
Thank you Jim for working on this!
On Fri, Nov 4, 2016 at 5:38 PM, Jim Apple wrote:
> clang-tidy is a nice tool for catching likely bugs and definitely poor
> syntax. You can use it on your latest patch with:
>
> git diff asf-gerrit/master |
> "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/share/
> clang/clang-tidy-diff.py"
> -clang-tidy-binary
> "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/bin/clang-tidy" -p 1
>
> You can check the whole repo with:
>
> bin/run_clang_tidy.sh
>
> The latter produces a lot of output and takes 10-15 minutes. Warnings
> are lines that end in ']'.
>
> Time permitting, I will expand the checks we use and try to integrate
> this into tests or code review tools. I added it to the wiki:
>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65868536
>
clang-tidy: sweeping linter changes?
Should we make large (but mostly cosmetic) changes to our source code to help new contributors write clean C++? We now have a .clang-format file to help new contributors write code with correct whitespace formatting. Many other parts of our C++ style can be enforced by clang-tidy, a stronger tool included in our toolchain that understands much more than whitespace. There is a cost, however -- clang-tidy is not nearly as good at targeting its warnings at newly-written code. To use it well(*), we will need to fix a lot of warnings about our existing code. Should we fix the existing code to make clang-tidy accept it? This would be a big change from what we did with clang-format, in which we ask that new code be clang-formatted, but we allow old code to remain unformatted unless it is touched again. Some randomly-selected examples of the kind of things clang-tidy can enforce (**): * TypeNamesAreCamelCase * "if (b == true)" should be written "if (b)" * Function prototypes should have the same parameter names as function definitions * Single-argument constructors should be "explicit" We can configure clang-tidy, just like clang-format, to be more or less strict for any given check. (*) without building up a lot of ad-hoc tooling to suppress warnings about existing code (**) partial list here: http://clang.llvm.org/extra/clang-tidy/checks/list.html. This list does not include some diagnostics that are part of clang proper and that clang-tidy can warn about, though we can also acquire a list of those and tune them for our needs.
Disabling all clang-tidy checks
Has anyone found a way to disable all clang-tidy checks for a directory?
I've tried a directory-specific .clang-tidy file with
---
Checks: "-*"
but that causes clang-tidy to exit with an error (because I didn't
configure any checks). So I tried adding one check that I thought would
never fire. But that silently re-enables a bunch of clang-diagnostic*
checks that I don't want.
This happens when running:
git diff HEAD~1 |
"${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/share/clang/clang-tidy-diff.py"
-clang-tidy-binary
"${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/bin/clang-tidy" -p 1
per
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65868536
Any ideas? Am I running clang-tidy wrong?
Re: clang-tidy: sweeping linter changes?
Check out clang-tidy-diff which can limit warnings based on a patch. You can control the amount of context given to it so that people get warnings about surrounding code or really just strictly the changed lines. We are using this in kudu and it's moderately helpful. Todd On Oct 8, 2016 12:13 PM, "Jim Apple" wrote: > Should we make large (but mostly cosmetic) changes to our source code to > help new contributors write clean C++? > > We now have a .clang-format file to help new contributors write code with > correct whitespace formatting. Many other parts of our C++ style can be > enforced by clang-tidy, a stronger tool included in our toolchain that > understands much more than whitespace. > > There is a cost, however -- clang-tidy is not nearly as good at targeting > its warnings at newly-written code. To use it well(*), we will need to fix > a lot of warnings about our existing code. > > Should we fix the existing code to make clang-tidy accept it? This would be > a big change from what we did with clang-format, in which we ask that new > code be clang-formatted, but we allow old code to remain unformatted unless > it is touched again. > > Some randomly-selected examples of the kind of things clang-tidy can > enforce (**): > > * TypeNamesAreCamelCase > * "if (b == true)" should be written "if (b)" > * Function prototypes should have the same parameter names as function > definitions > * Single-argument constructors should be "explicit" > > We can configure clang-tidy, just like clang-format, to be more or less > strict for any given check. > > (*) without building up a lot of ad-hoc tooling to suppress warnings about > existing code > > (**) partial list here: > http://clang.llvm.org/extra/clang-tidy/checks/list.html. This list does > not > include some diagnostics that are part of clang proper and that clang-tidy > can warn about, though we can also acquire a list of those and tune them > for our needs. >
Re: clang-tidy: sweeping linter changes?
Thanks - this is working for me! I'm going to try and curate some config settings. I'll update dev@ if and when I have something useful. On Sat, Oct 8, 2016 at 1:03 PM, Todd Lipcon wrote: > Check out clang-tidy-diff which can limit warnings based on a patch. You > can control the amount of context given to it so that people get warnings > about surrounding code or really just strictly the changed lines. > > We are using this in kudu and it's moderately helpful. > > Todd > > On Oct 8, 2016 12:13 PM, "Jim Apple" wrote: > >> Should we make large (but mostly cosmetic) changes to our source code to >> help new contributors write clean C++? >> >> We now have a .clang-format file to help new contributors write code with >> correct whitespace formatting. Many other parts of our C++ style can be >> enforced by clang-tidy, a stronger tool included in our toolchain that >> understands much more than whitespace. >> >> There is a cost, however -- clang-tidy is not nearly as good at targeting >> its warnings at newly-written code. To use it well(*), we will need to fix >> a lot of warnings about our existing code. >> >> Should we fix the existing code to make clang-tidy accept it? This would be >> a big change from what we did with clang-format, in which we ask that new >> code be clang-formatted, but we allow old code to remain unformatted unless >> it is touched again. >> >> Some randomly-selected examples of the kind of things clang-tidy can >> enforce (**): >> >> * TypeNamesAreCamelCase >> * "if (b == true)" should be written "if (b)" >> * Function prototypes should have the same parameter names as function >> definitions >> * Single-argument constructors should be "explicit" >> >> We can configure clang-tidy, just like clang-format, to be more or less >> strict for any given check. >> >> (*) without building up a lot of ad-hoc tooling to suppress warnings about >> existing code >> >> (**) partial list here: >> http://clang.llvm.org/extra/clang-tidy/checks/list.html. This list does >> not >> include some diagnostics that are part of clang proper and that clang-tidy >> can warn about, though we can also acquire a list of those and tune them >> for our needs. >>
Re: Disabling all clang-tidy checks
What about "diagnostic-henry-thinks-will-never-fire,-*,-clang-diagnostic-*"?
On Wed, Jul 12, 2017 at 5:01 PM, Henry Robinson wrote:
> Has anyone found a way to disable all clang-tidy checks for a directory?
>
> I've tried a directory-specific .clang-tidy file with
>
> ---
> Checks: "-*"
>
> but that causes clang-tidy to exit with an error (because I didn't
> configure any checks). So I tried adding one check that I thought would
> never fire. But that silently re-enables a bunch of clang-diagnostic*
> checks that I don't want.
>
> This happens when running:
>
> git diff HEAD~1 |
> "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/share/clan
> g/clang-tidy-diff.py"
> -clang-tidy-binary
> "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/bin/clang-tidy" -p 1
>
> per
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65868536
>
> Any ideas? Am I running clang-tidy wrong?
>
Re: Disabling all clang-tidy checks
That does not, for whatever reason, actually disable clang-diagnostic-*. I
don't know why either :/
On 12 July 2017 at 17:15, Jim Apple wrote:
> What about "diagnostic-henry-thinks-will-never-fire,-*,-clang-diagnosti
> c-*"?
>
>
>
> On Wed, Jul 12, 2017 at 5:01 PM, Henry Robinson wrote:
>
> > Has anyone found a way to disable all clang-tidy checks for a directory?
> >
> > I've tried a directory-specific .clang-tidy file with
> >
> > ---
> > Checks: "-*"
> >
> > but that causes clang-tidy to exit with an error (because I didn't
> > configure any checks). So I tried adding one check that I thought would
> > never fire. But that silently re-enables a bunch of clang-diagnostic*
> > checks that I don't want.
> >
> > This happens when running:
> >
> > git diff HEAD~1 |
> > "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/share/clan
> > g/clang-tidy-diff.py"
> > -clang-tidy-binary
> > "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/bin/clang-tidy" -p 1
> >
> > per
> > https://cwiki.apache.org/confluence/pages/viewpage.action?
> pageId=65868536
> >
> > Any ideas? Am I running clang-tidy wrong?
> >
>
Re: Disabling all clang-tidy checks
The clang-diagnostics are, IIRC, also enabled by the -W flags. You could
try turning all warnings off via compiler flags.
There is also a tool that auto-fixes clang-tidy warnings, but only some of
them, and I never got even that much to work :-/
On Wed, Jul 12, 2017 at 5:24 PM, Henry Robinson wrote:
> That does not, for whatever reason, actually disable clang-diagnostic-*. I
> don't know why either :/
>
> On 12 July 2017 at 17:15, Jim Apple wrote:
>
> > What about "diagnostic-henry-thinks-will-never-fire,-*,-clang-diagnosti
> > c-*"?
> >
> >
> >
> > On Wed, Jul 12, 2017 at 5:01 PM, Henry Robinson
> wrote:
> >
> > > Has anyone found a way to disable all clang-tidy checks for a
> directory?
> > >
> > > I've tried a directory-specific .clang-tidy file with
> > >
> > > ---
> > > Checks: "-*"
> > >
> > > but that causes clang-tidy to exit with an error (because I didn't
> > > configure any checks). So I tried adding one check that I thought would
> > > never fire. But that silently re-enables a bunch of clang-diagnostic*
> > > checks that I don't want.
> > >
> > > This happens when running:
> > >
> > > git diff HEAD~1 |
> > > "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/share/clan
> > > g/clang-tidy-diff.py"
> > > -clang-tidy-binary
> > > "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/bin/clang-tidy" -p 1
> > >
> > > per
> > > https://cwiki.apache.org/confluence/pages/viewpage.action?
> > pageId=65868536
> > >
> > > Any ideas? Am I running clang-tidy wrong?
> > >
> >
>
Re: Disabling all clang-tidy checks
To close this loop - I took the blunt instrument approach and removed the
directory (which is the imported kudu code) from tidying consideration the
same way we do gutil in run_clang_tidy.sh. Nothing else seemed to work as
one might think it should.
On 12 July 2017 at 17:46, Jim Apple wrote:
> The clang-diagnostics are, IIRC, also enabled by the -W flags. You could
> try turning all warnings off via compiler flags.
>
> There is also a tool that auto-fixes clang-tidy warnings, but only some of
> them, and I never got even that much to work :-/
>
> On Wed, Jul 12, 2017 at 5:24 PM, Henry Robinson wrote:
>
> > That does not, for whatever reason, actually disable clang-diagnostic-*.
> I
> > don't know why either :/
> >
> > On 12 July 2017 at 17:15, Jim Apple wrote:
> >
> > > What about "diagnostic-henry-thinks-will-
> never-fire,-*,-clang-diagnosti
> > > c-*"?
> > >
> > >
> > >
> > > On Wed, Jul 12, 2017 at 5:01 PM, Henry Robinson
> > wrote:
> > >
> > > > Has anyone found a way to disable all clang-tidy checks for a
> > directory?
> > > >
> > > > I've tried a directory-specific .clang-tidy file with
> > > >
> > > > ---
> > > > Checks: "-*"
> > > >
> > > > but that causes clang-tidy to exit with an error (because I didn't
> > > > configure any checks). So I tried adding one check that I thought
> would
> > > > never fire. But that silently re-enables a bunch of clang-diagnostic*
> > > > checks that I don't want.
> > > >
> > > > This happens when running:
> > > >
> > > > git diff HEAD~1 |
> > > > "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/share/clan
> > > > g/clang-tidy-diff.py"
> > > > -clang-tidy-binary
> > > > "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/bin/clang-tidy" -p
> 1
> > > >
> > > > per
> > > > https://cwiki.apache.org/confluence/pages/viewpage.action?
> > > pageId=65868536
> > > >
> > > > Any ideas? Am I running clang-tidy wrong?
> > > >
> > >
> >
>
--
Henry Robinson
Software Engineer
Cloudera
415-994-6679
Re: Disabling all clang-tidy checks
FYI I have a patch up against clang-tidy to add this feature:
https://reviews.llvm.org/D34654
Hoping it will be reviewed/committed soon.
-Todd
On Thu, Jul 13, 2017 at 10:58 AM, Henry Robinson wrote:
> To close this loop - I took the blunt instrument approach and removed the
> directory (which is the imported kudu code) from tidying consideration the
> same way we do gutil in run_clang_tidy.sh. Nothing else seemed to work as
> one might think it should.
>
> On 12 July 2017 at 17:46, Jim Apple wrote:
>
> > The clang-diagnostics are, IIRC, also enabled by the -W flags. You could
> > try turning all warnings off via compiler flags.
> >
> > There is also a tool that auto-fixes clang-tidy warnings, but only some
> of
> > them, and I never got even that much to work :-/
> >
> > On Wed, Jul 12, 2017 at 5:24 PM, Henry Robinson
> wrote:
> >
> > > That does not, for whatever reason, actually disable
> clang-diagnostic-*.
> > I
> > > don't know why either :/
> > >
> > > On 12 July 2017 at 17:15, Jim Apple wrote:
> > >
> > > > What about "diagnostic-henry-thinks-will-
> > never-fire,-*,-clang-diagnosti
> > > > c-*"?
> > > >
> > > >
> > > >
> > > > On Wed, Jul 12, 2017 at 5:01 PM, Henry Robinson
> > > wrote:
> > > >
> > > > > Has anyone found a way to disable all clang-tidy checks for a
> > > directory?
> > > > >
> > > > > I've tried a directory-specific .clang-tidy file with
> > > > >
> > > > > ---
> > > > > Checks: "-*"
> > > > >
> > > > > but that causes clang-tidy to exit with an error (because I didn't
> > > > > configure any checks). So I tried adding one check that I thought
> > would
> > > > > never fire. But that silently re-enables a bunch of
> clang-diagnostic*
> > > > > checks that I don't want.
> > > > >
> > > > > This happens when running:
> > > > >
> > > > > git diff HEAD~1 |
> > > > > "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/share/clan
> > > > > g/clang-tidy-diff.py"
> > > > > -clang-tidy-binary
> > > > > "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/bin/clang-tidy"
> -p
> > 1
> > > > >
> > > > > per
> > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?
> > > > pageId=65868536
> > > > >
> > > > > Any ideas? Am I running clang-tidy wrong?
> > > > >
> > > >
> > >
> >
>
>
>
> --
> Henry Robinson
> Software Engineer
> Cloudera
> 415-994-6679
>
--
Todd Lipcon
Software Engineer, Cloudera
Re: Disabling all clang-tidy checks
Does this exclude source files? The issue I have is that I want to exclude
a whole directory of .cc files.
On 18 July 2017 at 17:09, Todd Lipcon wrote:
> FYI I have a patch up against clang-tidy to add this feature:
> https://reviews.llvm.org/D34654
> Hoping it will be reviewed/committed soon.
>
> -Todd
>
> On Thu, Jul 13, 2017 at 10:58 AM, Henry Robinson
> wrote:
>
> > To close this loop - I took the blunt instrument approach and removed the
> > directory (which is the imported kudu code) from tidying consideration
> the
> > same way we do gutil in run_clang_tidy.sh. Nothing else seemed to work as
> > one might think it should.
> >
> > On 12 July 2017 at 17:46, Jim Apple wrote:
> >
> > > The clang-diagnostics are, IIRC, also enabled by the -W flags. You
> could
> > > try turning all warnings off via compiler flags.
> > >
> > > There is also a tool that auto-fixes clang-tidy warnings, but only some
> > of
> > > them, and I never got even that much to work :-/
> > >
> > > On Wed, Jul 12, 2017 at 5:24 PM, Henry Robinson
> > wrote:
> > >
> > > > That does not, for whatever reason, actually disable
> > clang-diagnostic-*.
> > > I
> > > > don't know why either :/
> > > >
> > > > On 12 July 2017 at 17:15, Jim Apple wrote:
> > > >
> > > > > What about "diagnostic-henry-thinks-will-
> > > never-fire,-*,-clang-diagnosti
> > > > > c-*"?
> > > > >
> > > > >
> > > > >
> > > > > On Wed, Jul 12, 2017 at 5:01 PM, Henry Robinson
> > > > wrote:
> > > > >
> > > > > > Has anyone found a way to disable all clang-tidy checks for a
> > > > directory?
> > > > > >
> > > > > > I've tried a directory-specific .clang-tidy file with
> > > > > >
> > > > > > ---
> > > > > > Checks: "-*"
> > > > > >
> > > > > > but that causes clang-tidy to exit with an error (because I
> didn't
> > > > > > configure any checks). So I tried adding one check that I thought
> > > would
> > > > > > never fire. But that silently re-enables a bunch of
> > clang-diagnostic*
> > > > > > checks that I don't want.
> > > > > >
> > > > > > This happens when running:
> > > > > >
> > > > > > git diff HEAD~1 |
> > > > > > "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/share/clan
> > > > > > g/clang-tidy-diff.py"
> > > > > > -clang-tidy-binary
> > > > > > "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/bin/clang-tidy"
> > -p
> > > 1
> > > > > >
> > > > > > per
> > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?
> > > > > pageId=65868536
> > > > > >
> > > > > > Any ideas? Am I running clang-tidy wrong?
> > > > > >
> > > > >
> > > >
> > >
> >
> >
> >
> > --
> > Henry Robinson
> > Software Engineer
> > Cloudera
> > 415-994-6679
> >
>
>
>
> --
> Todd Lipcon
> Software Engineer, Cloudera
>
Re: Disabling all clang-tidy checks
Oh, I see. In that case yea, I think just "don't run clang-tidy on those
.cc files" is a good bet. But you'd still probably want to run tidy on
other .cc files that include headers in that dir, and that's where the
regex comes in handy.
On Tue, Jul 18, 2017 at 7:59 PM, Henry Robinson wrote:
> Does this exclude source files? The issue I have is that I want to exclude
> a whole directory of .cc files.
>
> On 18 July 2017 at 17:09, Todd Lipcon wrote:
>
> > FYI I have a patch up against clang-tidy to add this feature:
> > https://reviews.llvm.org/D34654
> > Hoping it will be reviewed/committed soon.
> >
> > -Todd
> >
> > On Thu, Jul 13, 2017 at 10:58 AM, Henry Robinson
> > wrote:
> >
> > > To close this loop - I took the blunt instrument approach and removed
> the
> > > directory (which is the imported kudu code) from tidying consideration
> > the
> > > same way we do gutil in run_clang_tidy.sh. Nothing else seemed to work
> as
> > > one might think it should.
> > >
> > > On 12 July 2017 at 17:46, Jim Apple wrote:
> > >
> > > > The clang-diagnostics are, IIRC, also enabled by the -W flags. You
> > could
> > > > try turning all warnings off via compiler flags.
> > > >
> > > > There is also a tool that auto-fixes clang-tidy warnings, but only
> some
> > > of
> > > > them, and I never got even that much to work :-/
> > > >
> > > > On Wed, Jul 12, 2017 at 5:24 PM, Henry Robinson
> > > wrote:
> > > >
> > > > > That does not, for whatever reason, actually disable
> > > clang-diagnostic-*.
> > > > I
> > > > > don't know why either :/
> > > > >
> > > > > On 12 July 2017 at 17:15, Jim Apple wrote:
> > > > >
> > > > > > What about "diagnostic-henry-thinks-will-
> > > > never-fire,-*,-clang-diagnosti
> > > > > > c-*"?
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Wed, Jul 12, 2017 at 5:01 PM, Henry Robinson <
> he...@apache.org>
> > > > > wrote:
> > > > > >
> > > > > > > Has anyone found a way to disable all clang-tidy checks for a
> > > > > directory?
> > > > > > >
> > > > > > > I've tried a directory-specific .clang-tidy file with
> > > > > > >
> > > > > > > ---
> > > > > > > Checks: "-*"
> > > > > > >
> > > > > > > but that causes clang-tidy to exit with an error (because I
> > didn't
> > > > > > > configure any checks). So I tried adding one check that I
> thought
> > > > would
> > > > > > > never fire. But that silently re-enables a bunch of
> > > clang-diagnostic*
> > > > > > > checks that I don't want.
> > > > > > >
> > > > > > > This happens when running:
> > > > > > >
> > > > > > > git diff HEAD~1 |
> > > > > > > "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/share/clan
> > > > > > > g/clang-tidy-diff.py"
> > > > > > > -clang-tidy-binary
> > > > > > > "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/bin/
> clang-tidy"
> > > -p
> > > > 1
> > > > > > >
> > > > > > > per
> > > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?
> > > > > > pageId=65868536
> > > > > > >
> > > > > > > Any ideas? Am I running clang-tidy wrong?
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Henry Robinson
> > > Software Engineer
> > > Cloudera
> > > 415-994-6679
> > >
> >
> >
> >
> > --
> > Todd Lipcon
> > Software Engineer, Cloudera
> >
>
--
Todd Lipcon
Software Engineer, Cloudera
Unknown clang-tidy failure in GVO
Does anyone know the cause for this failure in the clang-tidy run in GVO? It's something to do with hadoop-lzo. https://jenkins.impala.io/job/clang-tidy-ub1604/78/consoleFull *15:52:44* [javadoc] Generating /home/ubuntu/hadoop-lzo/build/docs/api/help-doc.html...*15:52:44* [javadoc] 1 error*15:52:44* [javadoc] 1 warning*15:52:44* [javadoc] javadoc: error - Error while reading file /home/ubuntu/hadoop-lzo/src/java/overview.html*15:52:44* *15:52:44* package:*15:52:44* [mkdir] Created dir: /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15*15:52:44* [mkdir] Created dir: /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib*15:52:44* [mkdir] Created dir: /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/docs*15:52:44* [mkdir] Created dir: /home/ubuntu/hadoop-lzo/lib*15:52:44* [copy] Copying 56 files to /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib*15:52:44* [copy] Copying 1 file to /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15*15:52:44* [exec] Created /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/docs*15:52:44* [exec] Copying libraries in /docs to /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/docs/*15:52:44* [exec] Created /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/hadoop-lzo-0.4.15.jar*15:52:44* [exec] Copying libraries in /hadoop-lzo-0.4.15.jar to /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/hadoop-lzo-0.4.15.jar/*15:52:44* [exec] Created /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/lib*15:52:44* [exec] Copying libraries in /lib to /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/lib/*15:52:44* [exec] Created /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/Linux-amd64-64*15:52:44* [exec] Copying libraries in /home/ubuntu/hadoop-lzo/build/native/Linux-amd64-64/lib to /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/Linux-amd64-64/*15:52:44* [exec] /home/ubuntu/hadoop-lzo/src/native/packageNativeHadoop.sh: 44: cd: can't cd to /docs/*15:52:44* [exec] tar: *gplcompression*: Cannot stat: No such file or directory*15:52:44* [exec] tar: Exiting with failure status due to previous errors*15:52:44* [exec] /home/ubuntu/hadoop-lzo/src/native/packageNativeHadoop.sh: 44: cd: can't cd to /hadoop-lzo-0.4.15.jar/*15:52:44* [exec] tar: *gplcompression*: Cannot stat: No such file or directory*15:52:44* [exec] tar: Exiting with failure status due to previous errors*15:52:44* [exec] tar: *gplcompression*: Cannot stat: No such file or directory*15:52:44* [exec] tar: Exiting with failure status due to previous errors*15:52:44* [copy] Copying 77 files to /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/docs*15:52:44* [copy] Copying 1 file to /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15*15:52:44* [copy] Copying 4 files to /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/ivy*15:52:44* [copy] Copying 1 file to /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15*15:52:44* [copy] Copying 64 files to /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/src*15:52:44* [copy] Copying 1 file to /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15
Re: Unknown clang-tidy failure in GVO
At the bottom of https://jenkins.impala.io/job/clang-tidy-ub1604/78/consoleFull I see: *16:05:31* + bin/run_clang_tidy.sh*16:13:18* + grep ']' /home/ubuntu/tidylog.txt*16:13:18* /home/ubuntu/Impala/be/src/rpc/thrift-server-test.cc:105:26: warning: extra ';' after member function definition [clang-diagnostic-extra-semi]*16:13:18* /home/ubuntu/Impala/be/src/rpc/thrift-server-test.cc:106:29: warning: extra ';' after member function definition [clang-diagnostic-extra-semi]*16:13:18* /home/ubuntu/Impala/be/src/rpc/thrift-server-test.cc:149:7: warning: ignoring return value of function declared with 'nodiscard' attribute [clang-diagnostic-unused-result] On Thu, Oct 26, 2017 at 12:57 PM, Sailesh Mukil wrote: > Does anyone know the cause for this failure in the clang-tidy run in GVO? > It's something to do with hadoop-lzo. > > https://jenkins.impala.io/job/clang-tidy-ub1604/78/consoleFull > > > *15:52:44* [javadoc] Generating > /home/ubuntu/hadoop-lzo/build/docs/api/help-doc.html...*15:52:44* > [javadoc] 1 error*15:52:44* [javadoc] 1 warning*15:52:44* > [javadoc] javadoc: error - Error while reading file > /home/ubuntu/hadoop-lzo/src/java/overview.html*15:52:44* *15:52:44* > package:*15:52:44* [mkdir] Created dir: > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15*15:52:44* [mkdir] > Created dir: /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib*15:52:44* > [mkdir] Created dir: > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/docs*15:52:44* > [mkdir] Created dir: /home/ubuntu/hadoop-lzo/lib*15:52:44* [copy] > Copying 56 files to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib*15:52:44* > [copy] Copying 1 file to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15*15:52:44* [exec] > Created /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/ > docs*15:52:44* > [exec] Copying libraries in /docs to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/docs/*15:52:44* > [exec] Created > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/ > hadoop-lzo-0.4.15.jar*15:52:44* > [exec] Copying libraries in /hadoop-lzo-0.4.15.jar to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/ > hadoop-lzo-0.4.15.jar/*15:52:44* > [exec] Created > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/lib*15:52:44* > [exec] Copying libraries in /lib to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/lib/*15:52:44* > [exec] Created > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/ > Linux-amd64-64*15:52:44* > [exec] Copying libraries in > /home/ubuntu/hadoop-lzo/build/native/Linux-amd64-64/lib to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/ > Linux-amd64-64/*15:52:44* > [exec] /home/ubuntu/hadoop-lzo/src/native/packageNativeHadoop.sh: > 44: cd: can't cd to /docs/*15:52:44* [exec] tar: > *gplcompression*: Cannot stat: No such file or directory*15:52:44* > [exec] tar: Exiting with failure status due to previous > errors*15:52:44* [exec] > /home/ubuntu/hadoop-lzo/src/native/packageNativeHadoop.sh: 44: cd: > can't cd to /hadoop-lzo-0.4.15.jar/*15:52:44* [exec] tar: > *gplcompression*: Cannot stat: No such file or directory*15:52:44* > [exec] tar: Exiting with failure status due to previous > errors*15:52:44* [exec] tar: *gplcompression*: Cannot stat: No > such file or directory*15:52:44* [exec] tar: Exiting with failure > status due to previous errors*15:52:44* [copy] Copying 77 files > to /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/docs*15:52:44* > [copy] Copying 1 file to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15*15:52:44* [copy] > Copying 4 files to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/ivy*15:52:44* > [copy] Copying 1 file to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15*15:52:44* [copy] > Copying 64 files to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/src*15:52:44* > [copy] Copying 1 file to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15 >
Re: Unknown clang-tidy failure in GVO
I think the actual failure was this: *16:13:18* + grep ']' /home/ubuntu/tidylog.txt*16:13:18* /home/ubuntu/Impala/be/src/rpc/thrift-server-test.cc:105:26: warning: extra ';' after member function definition [clang-diagnostic-extra-semi]*16:13:18* /home/ubuntu/Impala/be/src/rpc/thrift-server-test.cc:106:29: warning: extra ';' after member function definition [clang-diagnostic-extra-semi]*16:13:18* /home/ubuntu/Impala/be/src/rpc/thrift-server-test.cc:149:7: warning: ignoring return value of function declared with 'nodiscard' attribute [clang-diagnostic-unused-result] I'm not sure if the hadoop-lzo build noise was related - Tim On Thu, Oct 26, 2017 at 12:57 PM, Sailesh Mukil wrote: > Does anyone know the cause for this failure in the clang-tidy run in GVO? > It's something to do with hadoop-lzo. > > https://jenkins.impala.io/job/clang-tidy-ub1604/78/consoleFull > > > *15:52:44* [javadoc] Generating > /home/ubuntu/hadoop-lzo/build/docs/api/help-doc.html...*15:52:44* > [javadoc] 1 error*15:52:44* [javadoc] 1 warning*15:52:44* > [javadoc] javadoc: error - Error while reading file > /home/ubuntu/hadoop-lzo/src/java/overview.html*15:52:44* *15:52:44* > package:*15:52:44* [mkdir] Created dir: > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15*15:52:44* [mkdir] > Created dir: /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib*15:52:44* > [mkdir] Created dir: > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/docs*15:52:44* > [mkdir] Created dir: /home/ubuntu/hadoop-lzo/lib*15:52:44* [copy] > Copying 56 files to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib*15:52:44* > [copy] Copying 1 file to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15*15:52:44* [exec] > Created /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/ > docs*15:52:44* > [exec] Copying libraries in /docs to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/docs/*15:52:44* > [exec] Created > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/ > hadoop-lzo-0.4.15.jar*15:52:44* > [exec] Copying libraries in /hadoop-lzo-0.4.15.jar to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/ > hadoop-lzo-0.4.15.jar/*15:52:44* > [exec] Created > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/lib*15:52:44* > [exec] Copying libraries in /lib to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/lib/*15:52:44* > [exec] Created > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/ > Linux-amd64-64*15:52:44* > [exec] Copying libraries in > /home/ubuntu/hadoop-lzo/build/native/Linux-amd64-64/lib to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/ > Linux-amd64-64/*15:52:44* > [exec] /home/ubuntu/hadoop-lzo/src/native/packageNativeHadoop.sh: > 44: cd: can't cd to /docs/*15:52:44* [exec] tar: > *gplcompression*: Cannot stat: No such file or directory*15:52:44* > [exec] tar: Exiting with failure status due to previous > errors*15:52:44* [exec] > /home/ubuntu/hadoop-lzo/src/native/packageNativeHadoop.sh: 44: cd: > can't cd to /hadoop-lzo-0.4.15.jar/*15:52:44* [exec] tar: > *gplcompression*: Cannot stat: No such file or directory*15:52:44* > [exec] tar: Exiting with failure status due to previous > errors*15:52:44* [exec] tar: *gplcompression*: Cannot stat: No > such file or directory*15:52:44* [exec] tar: Exiting with failure > status due to previous errors*15:52:44* [copy] Copying 77 files > to /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/docs*15:52:44* > [copy] Copying 1 file to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15*15:52:44* [copy] > Copying 4 files to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/ivy*15:52:44* > [copy] Copying 1 file to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15*15:52:44* [copy] > Copying 64 files to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/src*15:52:44* > [copy] Copying 1 file to > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15 >
Re: Unknown clang-tidy failure in GVO
Whoops. Didn't notice that. Thanks Michael and Tim! On Thu, Oct 26, 2017 at 1:02 PM, Tim Armstrong wrote: > I think the actual failure was this: > > *16:13:18* + grep ']' /home/ubuntu/tidylog.txt*16:13:18* > /home/ubuntu/Impala/be/src/rpc/thrift-server-test.cc:105:26: warning: > extra ';' after member function definition > [clang-diagnostic-extra-semi]*16:13:18* > /home/ubuntu/Impala/be/src/rpc/thrift-server-test.cc:106:29: warning: > extra ';' after member function definition > [clang-diagnostic-extra-semi]*16:13:18* > /home/ubuntu/Impala/be/src/rpc/thrift-server-test.cc:149:7: warning: > ignoring return value of function declared with 'nodiscard' attribute > [clang-diagnostic-unused-result] > > I'm not sure if the hadoop-lzo build noise was related > > - Tim > > On Thu, Oct 26, 2017 at 12:57 PM, Sailesh Mukil > wrote: > > > Does anyone know the cause for this failure in the clang-tidy run in GVO? > > It's something to do with hadoop-lzo. > > > > https://jenkins.impala.io/job/clang-tidy-ub1604/78/consoleFull > > > > > > *15:52:44* [javadoc] Generating > > /home/ubuntu/hadoop-lzo/build/docs/api/help-doc.html...*15:52:44* > > [javadoc] 1 error*15:52:44* [javadoc] 1 warning*15:52:44* > > [javadoc] javadoc: error - Error while reading file > > /home/ubuntu/hadoop-lzo/src/java/overview.html*15:52:44* *15:52:44* > > package:*15:52:44* [mkdir] Created dir: > > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15*15:52:44* [mkdir] > > Created dir: /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib*15:52: > 44* > > [mkdir] Created dir: > > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/docs*15:52:44* > > [mkdir] Created dir: /home/ubuntu/hadoop-lzo/lib*15:52:44* [copy] > > Copying 56 files to > > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib*15:52:44* > > [copy] Copying 1 file to > > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15*15:52:44* [exec] > > Created /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/ > > docs*15:52:44* > > [exec] Copying libraries in /docs to > > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/ > docs/*15:52:44* > > [exec] Created > > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/ > > hadoop-lzo-0.4.15.jar*15:52:44* > > [exec] Copying libraries in /hadoop-lzo-0.4.15.jar to > > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/ > > hadoop-lzo-0.4.15.jar/*15:52:44* > > [exec] Created > > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/lib*15:52:44* > > [exec] Copying libraries in /lib to > > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/ > lib/*15:52:44* > > [exec] Created > > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/ > > Linux-amd64-64*15:52:44* > > [exec] Copying libraries in > > /home/ubuntu/hadoop-lzo/build/native/Linux-amd64-64/lib to > > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/lib/native/ > > Linux-amd64-64/*15:52:44* > > [exec] /home/ubuntu/hadoop-lzo/src/native/packageNativeHadoop.sh: > > 44: cd: can't cd to /docs/*15:52:44* [exec] tar: > > *gplcompression*: Cannot stat: No such file or directory*15:52:44* > > [exec] tar: Exiting with failure status due to previous > > errors*15:52:44* [exec] > > /home/ubuntu/hadoop-lzo/src/native/packageNativeHadoop.sh: 44: cd: > > can't cd to /hadoop-lzo-0.4.15.jar/*15:52:44* [exec] tar: > > *gplcompression*: Cannot stat: No such file or directory*15:52:44* > > [exec] tar: Exiting with failure status due to previous > > errors*15:52:44* [exec] tar: *gplcompression*: Cannot stat: No > > such file or directory*15:52:44* [exec] tar: Exiting with failure > > status due to previous errors*15:52:44* [copy] Copying 77 files > > to /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/docs*15:52:44* > > [copy] Copying 1 file to > > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15*15:52:44* [copy] > > Copying 4 files to > > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/ivy*15:52:44* > > [copy] Copying 1 file to > > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15*15:52:44* [copy] > > Copying 64 files to > > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15/src*15:52:44* > > [copy] Copying 1 file to > > /home/ubuntu/hadoop-lzo/build/hadoop-lzo-0.4.15 > > >
