[jira] [Created] (IOTDB-331) [0.9.0]A groupBy query bug when axisOrigin-startTimeOfWindow is an integral multiple of interval
Lei Rui created IOTDB-331:
-
Summary: [0.9.0]A groupBy query bug when
axisOrigin-startTimeOfWindow is an integral multiple of interval
Key: IOTDB-331
URL: https://issues.apache.org/jira/browse/IOTDB-331
Project: Apache IoTDB
Issue Type: Bug
Reporter: Lei Rui
{code:java}
SET STORAGE GROUP TO root.ln.wf01.wt01
CREATE TIMESERIES root.ln.wf01.wt01.status WITH DATATYPE=BOOLEAN, ENCODING=PLAIN
CREATE TIMESERIES root.ln.wf01.wt01.temperature WITH DATATYPE=DOUBLE,
ENCODING=PLAIN
CREATE TIMESERIES root.ln.wf01.wt01.hardware WITH DATATYPE=INT32, ENCODING=PLAIN
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) values(1,
1.1, false, 11)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) values(2,
2.2, true, 22)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) values(3,
3.3, false, 33)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) values(4,
4.4, false, 44)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) values(5,
5.5, false, 55)
flush
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(100, 100.1, false, 110)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(150, 200.2, true, 220)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(200, 300.3, false, 330)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(250, 400.4, false, 440)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(300, 500.5, false, 550)
flush
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(10, 10.1, false, 110)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(20, 20.2, true, 220)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(30, 30.3, false, 330)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(40, 40.4, false, 440)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(50, 50.5, false, 550)
flush
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(500, 100.1, false, 110)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(510, 200.2, true, 220)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(520, 300.3, false, 330)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(530, 400.4, false, 440)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(540, 500.5, false, 550)
flush
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(580, 100.1, false, 110)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(590, 200.2, true, 220)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(600, 300.3, false, 330)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(610, 400.4, false, 440)
INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(620, 500.5, false, 550)
select count(temperature), sum(temperature), avg(temperature) from
root.ln.wf01.wt01 where temperature > 3 GROUP BY (20ms, 25,[5,30], [35,37],
[50, 160], [310, 314])
{code}
Note that in the above groupBy query, 25-5=1*20.
The result of the above query is:
{code:java}
5,0,0.0,null // This is not right
5,3,35.8,11.932
25,1,30.3,30.3
50,1,50.5,50.5
65,0,0.0,null
85,1,100.1,100.1
105,0,0.0,null
125,0,0.0,null
145,1,200.2,200.2
310,0,0.0,null
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: question about Apache Jenkins and Sonar
Hi Xiangdong, The ASF SonarCube instance is no longer being run. The build has to be changed to SounarCloud. Have a look at the PLC4X build (Jenkinsfile). We did the change there some time ago. Chris Am 29.11.19, 17:24 schrieb "Xiangdong Huang" : Hi, I find Apache Jenkins build failed because "SonarQube installation defined in this job (ASF Sonar Analysis) does not match any configured installation. Number of installations that can be configured: 0." I checked recent commits, and find the most possible code modification is that `vulnerability-checks` is moved to `apache-release` profile. So, is this task who triggers Jenkins to submit a job to SonarQube? If so, you'd better revoke your modification on the pom file, @jialin Qiao. Best, -- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院
[BUILD-UNSTABLE]: Job 'IoTDB-Pipeline/master [master] [227]'
BUILD-UNSTABLE: Job 'IoTDB-Pipeline/master [master] [227]': Check console output at "https://builds.apache.org/job/IoTDB-Pipeline/job/master/227/";>IoTDB-Pipeline/master [master] [227]"
Podling Iotdb Report Reminder - December 2019
Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 18 December 2019, 10:30 am PDT. The report for your podling will form a part of the Incubator PMC report. The Incubator PMC requires your report to be submitted 2 weeks before the board meeting, to allow sufficient time for review and submission (Wed, December 04). Please submit your report with sufficient time to allow the Incubator PMC, and subsequently board members to review and digest. Again, the very latest you should submit your report is 2 weeks prior to the board meeting. Candidate names should not be made public before people are actually elected, so please do not include the names of potential committers or PPMC members in your report. Thanks, The Apache Incubator PMC Submitting your Report -- Your report should contain the following: * Your project name * A brief description of your project, which assumes no knowledge of the project or necessarily of its field * A list of the three most important issues to address in the move towards graduation. * Any issues that the Incubator PMC or ASF Board might wish/need to be aware of * How has the community developed since the last report * How has the project developed since the last report. * How does the podling rate their own maturity. This should be appended to the Incubator Wiki page at: https://cwiki.apache.org/confluence/display/INCUBATOR/December2019 Note: This is manually populated. You may need to wait a little before this page is created from a template. Note: The format of the report has changed to use markdown. Mentors --- Mentors should review reports for their project(s) and sign them off on the Incubator wiki page. Signing off reports shows that you are following the project - projects that are not signed may raise alarms for the Incubator PMC. Incubator PMC
Re: question about Apache Jenkins and Sonar
You need to some setup[1] to enable the Sonar Cloud Service for Apache project. [1]https://cwiki.apache.org/confluence/display/INFRA/SonarQube+Analysis Willem Jiang Twitter: willemjiang Weibo: 姜宁willem Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Sat, Nov 30, 2019 at 10:31 PM Christofer Dutz wrote: > > Hi Xiangdong, > > The ASF SonarCube instance is no longer being run. > The build has to be changed to SounarCloud. > > Have a look at the PLC4X build (Jenkinsfile). > We did the change there some time ago. > > Chris > > Am 29.11.19, 17:24 schrieb "Xiangdong Huang" : > > Hi, > > I find Apache Jenkins build failed because "SonarQube installation defined > in this job (ASF Sonar Analysis) does not match any configured > installation. Number of installations that can be configured: 0." > > I checked recent commits, and find the most possible code modification is > that `vulnerability-checks` is moved to `apache-release` profile. > > So, is this task who triggers Jenkins to submit a job to SonarQube? > > If so, you'd better revoke your modification on the pom file, @jialin > Qiao. > > Best, > -- > Xiangdong Huang > School of Software, Tsinghua University > > 黄向东 > 清华大学 软件学院 > >
Re: Pay attention to mentors' comments
Hi, Where is this report being worked on? It's best to work on the report in the open so others can contribute. Thanks, Justin
Re: Pay attention to mentors' comments
Hi, Also note a new question has is being asks, so done;t just copy and paste teh previous report or you might miss it :-) Thanks, Justin
Re: Podling Iotdb Report Reminder - December 2019
Hi, Please review the draft of the report of December2019. (Some questions like "How does the podling rate their own maturity" is quite subjective, so I use "from the reporter's view" or "the reporter thinks". Please comment your idea, and I will modify the draft.) # IoTDB # A brief description of your project, which assumes no knowledge of the project or necessarily of its field IoTDB is a data store for managing large amounts of time series data such as timestamped data from IoT sensors in industrial applications. IoTDB has been incubating since 2018-11-18. #A list of the three most important issues to address in the move towards graduation.: - Learn to discuss things on the mailing list, rather than just post an ISSUE created or closed message, or discuss on Github. - More committers should know how to release a version. And more PPMC should join to vote. - Write more documentation to help new contributors. # Any issues that the Incubator PMC or ASF Board might wish/need to be aware of? - No. # How has the community developed since the last report? - New contributors appears, e.g., HT Hou for PR527, liutaohua for PR578, yx-zhang for PR540, francisdu for ISSUE293, SilverNarcissus for PR327, nlosilva1 for PR298, Zesong Sun etc.. - According to github's records, there are 50 contributors now. - New committer Jack Tsai. - New PPMC: Julian Feinauer - Twitter account is created: Apacheiotdb - More than 137 mails are recorded on dev@ mailing list # How has the project developed since the last report? - IoTDB released two versions, v0.8.1 and 0.9.0 (will be finished tomorrow). - IoTDB v0.9.0 fixed 16 bugs, introduced 31 new features and 27 improvements. (According to the statistics of 0.9.0's RELEASE_NOTE) # How does the podling rate their own maturity. - The community is more diverse than before. As far as the reporter knows, the contributors come from more than 10 companies/organizers. - More users begin to report the bugs, which means that more and more users are using IoTDB. - According to the reporter's view, IoTDB is more stable and has better performance than before. If using the template of previous reports, the status of the community can be: Initial setup Working towards first release - Community building Nearing graduation If rate the maturity from 0 (initial steup) to 10 (can graduate), the reporter thinks it can be around 4.5. # Other: Date of last release: 2019-11-2 (need to check tomorrow) # When were the last committers or PPMC members elected? 2019-11-05 for new committer and 2019-11-07 for new PPMC # Have your mentors been helpful and responsive? Very helpful, especially for releasing versions. Signed-off-by: (iotdb) Justin Mclean Comments: (iotdb) Christofer Dutz Comments: (iotdb) Willem Ning Jiang Comments: (iotdb) Kevin A. McGrail Comments: IPMC/Shepherd notes: --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 于2019年11月26日周二 上午4:17写道： > Dear podling, > > This email was sent by an automated system on behalf of the Apache > Incubator PMC. It is an initial reminder to give you plenty of time to > prepare your quarterly board report. > > The board meeting is scheduled for Wed, 18 December 2019, 10:30 am PDT. > The report for your podling will form a part of the Incubator PMC > report. The Incubator PMC requires your report to be submitted 2 weeks > before the board meeting, to allow sufficient time for review and > submission (Wed, December 04). > > Please submit your report with sufficient time to allow the Incubator > PMC, and subsequently board members to review and digest. Again, the > very latest you should submit your report is 2 weeks prior to the board > meeting. > > Candidate names should not be made public before people are actually > elected, so please do not include the names of potential committers or > PPMC members in your report. > > Thanks, > > The Apache Incubator PMC > > Submitting your Report > > -- > > Your report should contain the following: > > * Your project name > * A brief description of your project, which assumes no knowledge of > the project or necessarily of its field > * A list of the three most important issues to address in the move > towards graduation. > * Any issues that the Incubator PMC or ASF Board might wish/need to be > aware of > * How has the community developed since the last report > * How has the project developed since the last report. > * How does the podling rate their own maturity. > > This should be appended to the Incubator Wiki page at: > > https://cwiki.apache.org/confluence/display/INCUBATOR/December2019 > > Note: This is manually populated. You may need to wait a little before > this page is created from a template. > > Note: The format of the report has changed to use markdown. > > Mentors > --- > > Mentors should review reports for their project(s) and sign them off on > the Incubator wiki page. Sign
Re: Podling Iotdb Report Reminder - December 2019
Looks like a good report to me. Let me know when you have put it into confluence so I can sign off. On 11/30/2019 9:06 PM, Xiangdong Huang wrote: > Hi, > > Please review the draft of the report of December2019. > > (Some questions like "How does the podling rate their own maturity" is > quite subjective, so I use "from the reporter's view" or "the reporter > thinks". Please comment your idea, and I will modify the draft.) > > # IoTDB > # A brief description of your project, which assumes no knowledge of the > project or necessarily of its field > IoTDB is a data store for managing large amounts of time series data such > as timestamped data from IoT sensors in industrial applications. > IoTDB has been incubating since 2018-11-18. > > #A list of the three most important issues to address in the move towards > graduation.: > - Learn to discuss things on the mailing list, rather than just post an > ISSUE created or closed message, or discuss on Github. > - More committers should know how to release a version. And more PPMC > should join to vote. > - Write more documentation to help new contributors. > > # Any issues that the Incubator PMC or ASF Board might wish/need to be > aware of? > - No. > > # How has the community developed since the last report? > - New contributors appears, e.g., HT Hou for PR527, liutaohua for PR578, > yx-zhang for PR540, francisdu for ISSUE293, SilverNarcissus for PR327, > nlosilva1 for PR298, Zesong Sun etc.. > - According to github's records, there are 50 contributors now. > - New committer Jack Tsai. > - New PPMC: Julian Feinauer > - Twitter account is created: Apacheiotdb > - More than 137 mails are recorded on dev@ mailing list > > # How has the project developed since the last report? > - IoTDB released two versions, v0.8.1 and 0.9.0 (will be finished > tomorrow). > - IoTDB v0.9.0 fixed 16 bugs, introduced 31 new features and 27 > improvements. (According to the statistics of 0.9.0's RELEASE_NOTE) > > > # How does the podling rate their own maturity. > - The community is more diverse than before. As far as the reporter knows, > the contributors come from more than 10 companies/organizers. > - More users begin to report the bugs, which means that more and more users > are using IoTDB. > - According to the reporter's view, IoTDB is more stable and has better > performance than before. > > If using the template of previous reports, the status of the community can > be: > > Initial setup > Working towards first release > - Community building > Nearing graduation > > If rate the maturity from 0 (initial steup) to 10 (can graduate), the > reporter thinks it can be around 4.5. > > # Other: > Date of last release: > 2019-11-2 (need to check tomorrow) > > # When were the last committers or PPMC members elected? > 2019-11-05 for new committer and 2019-11-07 for new PPMC > > # Have your mentors been helpful and responsive? > Very helpful, especially for releasing versions. > > Signed-off-by: > (iotdb) Justin Mclean > Comments: > (iotdb) Christofer Dutz > Comments: > (iotdb) Willem Ning Jiang > Comments: > (iotdb) Kevin A. McGrail > Comments: > IPMC/Shepherd notes: > --- > Xiangdong Huang > School of Software, Tsinghua University > > 黄向东 > 清华大学 软件学院 > > > 于2019年11月26日周二 上午4:17写道： > >> Dear podling, >> >> This email was sent by an automated system on behalf of the Apache >> Incubator PMC. It is an initial reminder to give you plenty of time to >> prepare your quarterly board report. >> >> The board meeting is scheduled for Wed, 18 December 2019, 10:30 am PDT. >> The report for your podling will form a part of the Incubator PMC >> report. The Incubator PMC requires your report to be submitted 2 weeks >> before the board meeting, to allow sufficient time for review and >> submission (Wed, December 04). >> >> Please submit your report with sufficient time to allow the Incubator >> PMC, and subsequently board members to review and digest. Again, the >> very latest you should submit your report is 2 weeks prior to the board >> meeting. >> >> Candidate names should not be made public before people are actually >> elected, so please do not include the names of potential committers or >> PPMC members in your report. >> >> Thanks, >> >> The Apache Incubator PMC >> >> Submitting your Report >> >> -- >> >> Your report should contain the following: >> >> * Your project name >> * A brief description of your project, which assumes no knowledge of >> the project or necessarily of its field >> * A list of the three most important issues to address in the move >> towards graduation. >> * Any issues that the Incubator PMC or ASF Board might wish/need to be >> aware of >> * How has the community developed since the last report >> * How has the project developed since the last report. >> * How does the podling rate their own maturity. >> >> This should be appended to the Incubator Wiki page at: >> >> https://cwiki.ap
Re: Podling Iotdb Report Reminder - December 2019
Hi, Good report. Given the number of contributions does the PMC think there’s anyone who could be offered committership? You missed a question about branding, this has been added recently. Please check the template in confluence [1] rather than copying the previous report. Thanks, Justin 1. https://cwiki.apache.org/confluence/display/incubator/December2018
Re: Podling Iotdb Report Reminder - December 2019
Hi, > Some questions like "How does the podling rate their own maturity" is > quite subjective, so I use "from the reporter's view" or "the reporter > thinks". Please comment your idea, and I will modify the draft. I would just answer for the whole PMC and if anyone disagrees they can raise it and discuss why and modify the report if needed. > If rate the maturity from 0 (initial steup) to 10 (can graduate), the > reporter thinks it can be around 4.5. I don’t think this podling is quite at that point yet, but good progress has been made. Thanks, Justin
Re: Podling Iotdb Report Reminder - December 2019
Hi, >> If rate the maturity from 0 (initial steup) to 10 (can graduate), the >> reporter thinks it can be around 4.5. > I don’t think this podling is quite at that point yet, but good progress has been made. I gives a high score for enhancing morale :D. We can remove it in the formal report. Indeed we need to try our best to make it come true. Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Justin Mclean 于2019年12月1日周日 下午12:36写道： > Hi, > > > Some questions like "How does the podling rate their own maturity" is > > quite subjective, so I use "from the reporter's view" or "the reporter > > thinks". Please comment your idea, and I will modify the draft. > > I would just answer for the whole PMC and if anyone disagrees they can > raise it and discuss why and modify the report if needed. > > > If rate the maturity from 0 (initial steup) to 10 (can graduate), the > > reporter thinks it can be around 4.5. > > I don’t think this podling is quite at that point yet, but good progress > has been made. > > Thanks, > Justin
Re: Podling Iotdb Report Reminder - December 2019
Hi, > I gives a high score for enhancing morale :D. :-) As long as you keep making progress all is good. > We can remove it in the formal report. Indeed we need to try our best to > make it come true. I’ve not issue if it leftest in, it is a report from where the podling things is is along the path. Thanks, Justin
Re: Podling Iotdb Report Reminder - December 2019
https://federalnewsnetwork.com/federal-report/2012/09/the-beatings-will-continue-until-morale-improves/ On 11/30/2019 11:57 PM, Justin Mclean wrote: >> I gives a high score for enhancing morale :D. -- Kevin A. McGrail kmcgr...@apache.org Member, Apache Software Foundation Chair Emeritus Apache SpamAssassin Project https://www.linkedin.com/in/kmcgrail - 703.798.0171
Avoid packing incorrect files into source-release.zip
Hi, Considering we packed some incorrect files in the last release (RC1 to RC4), I think writing an assembly.xml file for generating the source-release.zip is a good way to avoid that. What is more, it is very helpful when we switch different branches for releasing. for example, in v0.9.0, there is a module called session, which does not exist in 0.8.0. So, if I switch the branch from 0.9 to 0.8 (or rel/0.8) for a minor version releasing (e.g., 0.8.2), I have to remove the session folder manually. If I forgot that, a dirty source-release.zip is generated. But if we have an assembly.xml, it will avoid that. I have written the source-assembly.xml now in PR [1]. The assembly file looks ugly because we have to declare the files one by one. (I tried the tag, which is more convenient. But because our module.artifactId != module.folder name, there is some issues that I can not solve. Finally I gave up using tag). If the PR is accepted, then for all contributors please notice that: (1) If you add new source files into a src/ docs/ license folder, it is ok. (2) If you add a new module, create a new folder, or write a plain text file under the project's (or a module's) root directory, you have to maintain the source-assembly.xml file.. Otherwise the new added files will not be packed into source-release.zip. Hope in this way, we can no longer get dirty source-release.zip files. [1] Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院
Re: Avoid packing incorrect files into source-release.zip
Sorry the PR link is [1]. [1] https://github.com/apache/incubator-iotdb/pull/610 Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Xiangdong Huang 于2019年12月1日周日 下午1:45写道： > Hi, > > Considering we packed some incorrect files in the last release (RC1 to > RC4), I think writing an assembly.xml file for generating the > source-release.zip is a good way to avoid that. > > What is more, it is very helpful when we switch different branches for > releasing. for example, in v0.9.0, there is a module called session, which > does not exist in 0.8.0. So, if I switch the branch from 0.9 to 0.8 (or > rel/0.8) for a minor version releasing (e.g., 0.8.2), I have to remove the > session folder manually. If I forgot that, a dirty source-release.zip is > generated. But if we have an assembly.xml, it will avoid that. > > I have written the source-assembly.xml now in PR [1]. The assembly file > looks ugly because we have to declare the files one by one. (I tried the > tag, which is more convenient. But because our > module.artifactId != module.folder name, there is some issues that I can > not solve. Finally I gave up using tag). > > If the PR is accepted, then for all contributors please notice that: > > (1) If you add new source files into a src/ docs/ license folder, it is ok. > (2) If you add a new module, create a new folder, or write a plain text > file under the project's (or a module's) root directory, you have to > maintain the source-assembly.xml file.. Otherwise the new added files will > not be packed into source-release.zip. > > Hope in this way, we can no longer get dirty source-release.zip files. > > [1] > Best, > --- > Xiangdong Huang > School of Software, Tsinghua University > > 黄向东 > 清华大学 软件学院 >
Re: question about Apache Jenkins and Sonar
Hi, thanks Chris and Willem. I have created a jira ticket for applying creating a project on sonarcloud.io [1]. Before the application is complete, I disable the sonar analysis from jenkins temporary. [1] https://issues.apache.org/jira/browse/INFRA-19507 --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Willem Jiang 于2019年12月1日周日 上午9:39写道： > You need to some setup[1] to enable the Sonar Cloud Service for Apache > project. > > [1]https://cwiki.apache.org/confluence/display/INFRA/SonarQube+Analysis > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Sat, Nov 30, 2019 at 10:31 PM Christofer Dutz > wrote: > > > > Hi Xiangdong, > > > > The ASF SonarCube instance is no longer being run. > > The build has to be changed to SounarCloud. > > > > Have a look at the PLC4X build (Jenkinsfile). > > We did the change there some time ago. > > > > Chris > > > > Am 29.11.19, 17:24 schrieb "Xiangdong Huang" : > > > > Hi, > > > > I find Apache Jenkins build failed because "SonarQube installation > defined > > in this job (ASF Sonar Analysis) does not match any configured > > installation. Number of installations that can be configured: 0." > > > > I checked recent commits, and find the most possible code > modification is > > that `vulnerability-checks` is moved to `apache-release` profile. > > > > So, is this task who triggers Jenkins to submit a job to SonarQube? > > > > If so, you'd better revoke your modification on the pom file, > @jialin Qiao. > > > > Best, > > -- > > Xiangdong Huang > > School of Software, Tsinghua University > > > > 黄向东 > > 清华大学 软件学院 > > > > >
Question about a mix of Unix and windows new lines and extra blank spaces in ASF headers.
Hi, In our vote thread on general@, @Justin Mclean pointed out some issues: > I did notice a mix of unix and windows new lines, you might want to fix that. This is also a very minor slight inconsistency with the ASF headers (extra spaces in some). I have no idea about how to find them out.. Does anyone can give me some indication? Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院
Re: Question about a mix of Unix and windows new lines and extra blank spaces in ASF headers.
Hi,
>> I did notice a mix of unix and windows new lines, you might want to fix
> that. This is also a very minor slight inconsistency with the ASF headers
> (extra spaces in some).
Compare these lines:
regarding copyright ownership. The ASF licenses this file
* regarding copyright ownership. The ASF licenses this file
* copyright ownership. The ASF licenses this file to you under the Apache
License, Version 2.0
* regarding copyright ownership. The ASF licenses this file
* regarding copyright ownership. The ASF licenses this file
# regarding copyright ownership. The ASF licenses this file
// regarding copyright ownership. The ASF licenses this file
@REM regarding copyright ownership. The ASF licenses this file
regarding copyright ownership. The ASF licenses this file
This was put through a sort -u so each line is a variation on the other. There
may be other differences, I’ve not checked.
I found this by accident via:
search “copyright” | sort -u
Where search is:
function search() {
find . -type f -exec grep -i "$1" {} \; -print
}
Just a little tool I use to help find things in releases. My incubator talks
usually mention this.
Thanks,
Justin
Re: Question about a mix of Unix and windows new lines and extra blank spaces in ASF headers.
Hi Justin,
Many thanks!
> * copyright ownership. The ASF licenses this file to you under the
Apache License, Version 2.0
It is a obvious inconsistent format. I will fix it.
For others, they look different because they are from different file
formats, e.g., java file with /***/, bat file with @REM, antlr g file with
//, script file with #.
Best,
---
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Justin Mclean 于2019年12月1日周日 下午3:17写道：
> Hi,
>
> >> I did notice a mix of unix and windows new lines, you might want to fix
> > that. This is also a very minor slight inconsistency with the ASF headers
> > (extra spaces in some).
>
> Compare these lines:
> regarding copyright ownership. The ASF licenses this file
> * regarding copyright ownership. The ASF licenses this file
> * copyright ownership. The ASF licenses this file to you under the
> Apache License, Version 2.0
> * regarding copyright ownership. The ASF licenses this file
> * regarding copyright ownership. The ASF licenses this file
> # regarding copyright ownership. The ASF licenses this file
> // regarding copyright ownership. The ASF licenses this file
> @REM regarding copyright ownership. The ASF licenses this file
> regarding copyright ownership. The ASF licenses this file
>
> This was put through a sort -u so each line is a variation on the other.
> There may be other differences, I’ve not checked.
>
> I found this by accident via:
> search “copyright” | sort -u
>
> Where search is:
> function search() {
> find . -type f -exec grep -i "$1" {} \; -print
> }
>
> Just a little tool I use to help find things in releases. My incubator
> talks usually mention this.
>
> Thanks,
> Justin
>
>
>
>
Re: Question about a mix of Unix and windows new lines and extra blank spaces in ASF headers.
Hi, > For others, they look different because they are from different file > formats, e.g., java file with /***/, bat file with @REM, antlr g file with > //, script file with #. Look closer…. (+ some characters may of been translated in the email) Thanks, Justin
Re: Podling Iotdb Report Reminder - December 2019
Hi, I will move the report to confluence tomorrow after @JialinQiao finishing releasing 0.9.0. If Jialin can not finish the release tomorrow, I think I have to remove related content... @Kevin interesting slogan... Luckily we are not a military. :D Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Kevin A. McGrail 于2019年12月1日周日 下午1:09写道： > > https://federalnewsnetwork.com/federal-report/2012/09/the-beatings-will-continue-until-morale-improves/ > > On 11/30/2019 11:57 PM, Justin Mclean wrote: > >> I gives a high score for enhancing morale :D. > > -- > Kevin A. McGrail > kmcgr...@apache.org > > Member, Apache Software Foundation > Chair Emeritus Apache SpamAssassin Project > https://www.linkedin.com/in/kmcgrail - 703.798.0171 > >
