[jira] [Commented] (ISIS-457) New annotation @CssClass for class member, should render in the HTML markup for that member.
[
https://issues.apache.org/jira/browse/ISIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709670#comment-13709670
]
ASF subversion and git services commented on ISIS-457:
--
Commit 94ccda3a3f43665e42abb34368a513ff9dccb06f in branch refs/heads/master
from [~bibryam]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=94ccda3 ]
ISIS-457 - New annotation @CssClass for class member, should render in the HTML
markup for that member.
Signed-off-by: Dan Haywood danhayw...@apache.org
New annotation @CssClass for class member, should render in the HTML markup
for that member.
Key: ISIS-457
URL: https://issues.apache.org/jira/browse/ISIS-457
Project: Isis
Issue Type: New Feature
Components: Core, Viewer: Wicket
Affects Versions: viewer-wicket-1.2.0, core-1.2.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: viewer-wicket-1.3.0, core-1.3.0
Attachments: ISIS-457.patch, ISIS-457.patch
for example:
@CssClass(lock)
public void lock() { ... }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ISIS-457) New annotation @CssClass for class member, should render in the HTML markup for that member.
[
https://issues.apache.org/jira/browse/ISIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708457#comment-13708457
]
Dan Haywood commented on ISIS-457:
--
Hi Bilgin,
thanks for doing this, very decent effort!
I've applied the patch, all looks good, and pushed up to our repo.
I did notice just one place where the CSS class isn't rendered, namely for
actions that are placed alongside properties or collections. In the example
todo app, this would be the done and undo buttons by the completed
checkbox, and the add and remove buttons in the dependencies collection.
In terms of code, this is the AdditionalLinksPanel.
I've made some updates to the todo app, so if you'd be happy to finish off the
change, you could use that for test purposes. (todo app is in
examples/application/quickstart-w_r_j).
One last thing: I see you raised a separate ticket for some minor
formatting/spelling mistake fixes. I wouldn't have bothered myself with
raising a separate ticket ISIS-464 for that, would have done as part of this
ticket. Perhaps other ASF projects you've worked on are more pinnickity?
Thx again
Dan
New annotation @CssClass for class member, should render in the HTML markup
for that member.
Key: ISIS-457
URL: https://issues.apache.org/jira/browse/ISIS-457
Project: Isis
Issue Type: New Feature
Components: Core, Viewer: Wicket
Affects Versions: viewer-wicket-1.2.0, core-1.2.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: viewer-wicket-1.3.0, core-1.3.0
Attachments: ISIS-457.patch
for example:
@CssClass(lock)
public void lock() { ... }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ISIS-457) New annotation @CssClass for class member, should render in the HTML markup for that member.
[
https://issues.apache.org/jira/browse/ISIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708456#comment-13708456
]
ASF subversion and git services commented on ISIS-457:
--
Commit 5780784675ee5439b4d740e57073dca4a5d72bfa in branch refs/heads/master
from [~bibryam]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5780784 ]
ISIS-457 - New annotation @CssClass for class member, should render in the HTML
markup for that member.
Signed-off-by: Dan Haywood danhayw...@apache.org
New annotation @CssClass for class member, should render in the HTML markup
for that member.
Key: ISIS-457
URL: https://issues.apache.org/jira/browse/ISIS-457
Project: Isis
Issue Type: New Feature
Components: Core, Viewer: Wicket
Affects Versions: viewer-wicket-1.2.0, core-1.2.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: viewer-wicket-1.3.0, core-1.3.0
Attachments: ISIS-457.patch
for example:
@CssClass(lock)
public void lock() { ... }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ISIS-457) New annotation @CssClass for class member, should render in the HTML markup for that member.
[
https://issues.apache.org/jira/browse/ISIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13704721#comment-13704721
]
Dan Haywood commented on ISIS-457:
--
Good questions.
1. You are right that there aren't any overtly HTML-specific annotations, but
there are plenty of annotations that are hints to the UI: @MemberOrder,
@MemberGroup, @Render(EAGERLY), @Title, etc etc. I think that most people
coming to Isis will be wanting to use it as a webapp (the Wicket viewer), so
I'm not sure its worth coming up with our own more generic name for such a
well-known concept as CSS classes.
Happy to be swayed if the community thinks otherwise; that's my view.
2. I think this annotation could be applied to collections and properties and,
for that matter, to entity types themselves. Then, in the appropriate Wicket
UI component, we look for the facet on the ObjectSpecification (for entity
type) or ObjectMember (for property, collection or action) and add in using a
CssClassAppender to the relevant Wicket component.
There is some code that already appends the member name to an appropriate
widget; have a look for usages of CssClassAppender to get some ideas.
Cheers
Dan
New annotation @CssClass for class member, should render in the HTML markup
for that member.
Key: ISIS-457
URL: https://issues.apache.org/jira/browse/ISIS-457
Project: Isis
Issue Type: New Feature
Components: Core, Viewer: Wicket
Affects Versions: viewer-wicket-1.2.0, core-1.2.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: viewer-wicket-1.3.0, core-1.3.0
for example:
@CssClass(lock)
public void lock() { ... }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
