[jira] Assigned: (JCR-1185) building trunk fails

2007-11-01 Thread Dominique Pfister (JIRA)

 [ 
https://issues.apache.org/jira/browse/JCR-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominique Pfister reassigned JCR-1185:
--

Assignee: Dominique Pfister

> building trunk fails
> 
>
> Key: JCR-1185
> URL: https://issues.apache.org/jira/browse/JCR-1185
> Project: Jackrabbit
>  Issue Type: Bug
>  Components: jackrabbit-core
> Environment: JDK 1.5
> Mac OSX
>Reporter: Alan Cabrera
>Assignee: Dominique Pfister
> Attachments: build.log
>
>
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[23,38]
>  cannot find symbol
> symbol: class JCRSQLParserVisitor
> class DefaultParserVisitor implements JCRSQLParserVisitor {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[25,24]
>  cannot find symbol
> symbol  : class SimpleNode
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[29,24]
>  cannot find symbol
> symbol  : class ASTQuery
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[33,24]
>  cannot find symbol
> symbol  : class ASTSelectList
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[37,24]
>  cannot find symbol
> symbol  : class ASTFromClause
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[41,24]
>  cannot find symbol
> symbol  : class ASTWhereClause
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/ASTPredicate.java:[21,34]
>  cannot find symbol
> symbol: class SimpleNode
> public class ASTPredicate extends SimpleNode {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[49,24]
>  cannot find symbol
> symbol  : class ASTOrExpression
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[53,24]
>  cannot find symbol
> symbol  : class ASTAndExpression
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[57,24]
>  cannot find symbol
> symbol  : class ASTNotExpression
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[61,24]
>  cannot find symbol
> symbol  : class ASTBracketExpression
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/ASTLiteral.java:[19,32]
>  cannot find symbol
> symbol: class SimpleNode
> public class ASTLiteral extends SimpleNode {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/ASTIdentifier.java:[21,35]
>  cannot find symbol
> symbol: class SimpleNode
> public class ASTIdentifier extends SimpleNode {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[73,24]
>  cannot find symbol
> symbol  : class ASTOrderByClause
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/ASTContainsExpression.java:[21,43]
>  cannot find symbol
> symbol: class SimpleNode
> public class ASTContainsExpression extends SimpleNode {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[81,24]
>  cannot find symbol
> symbol  : class ASTOrderSpec
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[85,24]
>  cannot find symbol
> symbol  : class ASTAscendingOrderSpec
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/quer

[jira] Commented: (JCR-1154) Database Data Store

2007-11-01 Thread Thomas Mueller (JIRA)

[ 
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539341
 ] 

Thomas Mueller commented on JCR-1154:
-

Hi,

Thanks again for the patch! And sorry for the delay. I have a few remarks and 
questions:

- please use spaces, not tabs (Jackrabbit consistently uses spaces)
- please don't use import ...*
- byte b[] > byte[] b
- public is not required in interfaces
- return does not require (..)

To fix such problems, I use Checkstyle. If you like I can post the 
configuration I use.

Garbage collection: I like make garbage collection implementation independent; 
is it OK for you if I remove those cases? AbstractGarbageCollector and 
AbstractDataStore are not required then (anyway they are small).

It would be great if the database data store would automatically re-connect if 
the connection was lost (important for MySQL). To achieve this, 
org.apache.jackrabbit.core.persistence.bundle.util.ConnectionRecoveryManager 
can be used.

It's quite tricky that DatabaseRecord extends FilterInputStream... However I'm 
not sure if it is required, is it not possible to just wrap the database BLOB 
object?

I don't think that FileDataStoreConstants is required.

Those are just my view, and I'm open to discuss them of course.

If you have time to change it yourself please go ahead. Otherwise I will do it 
and post the patch here before I commit it - but it will take a few more days. 

Thanks for your help!
Thomas


> Database Data Store
> ---
>
> Key: JCR-1154
> URL: https://issues.apache.org/jira/browse/JCR-1154
> Project: Jackrabbit
>  Issue Type: New Feature
>  Components: jackrabbit-core
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Blocker
> Fix For: 1.4
>
> Attachments: jr-1.3.1-bea.zip
>
>
> We want to have a database backed data store implementation.
> An implementation using files is already available as part of JCR-926.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (JCR-1185) building trunk fails

2007-11-01 Thread Dominique Pfister (JIRA)

 [ 
https://issues.apache.org/jira/browse/JCR-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominique Pfister resolved JCR-1185.


Resolution: Fixed

I had the same problem when starting with an empty .m2 repository: apparently 
this error occurs with  javacc plugin 2.2 only. Added an explicit version 
number 2.1.

> building trunk fails
> 
>
> Key: JCR-1185
> URL: https://issues.apache.org/jira/browse/JCR-1185
> Project: Jackrabbit
>  Issue Type: Bug
>  Components: jackrabbit-core
> Environment: JDK 1.5
> Mac OSX
>Reporter: Alan Cabrera
>Assignee: Dominique Pfister
> Attachments: build.log
>
>
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[23,38]
>  cannot find symbol
> symbol: class JCRSQLParserVisitor
> class DefaultParserVisitor implements JCRSQLParserVisitor {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[25,24]
>  cannot find symbol
> symbol  : class SimpleNode
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[29,24]
>  cannot find symbol
> symbol  : class ASTQuery
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[33,24]
>  cannot find symbol
> symbol  : class ASTSelectList
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[37,24]
>  cannot find symbol
> symbol  : class ASTFromClause
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[41,24]
>  cannot find symbol
> symbol  : class ASTWhereClause
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/ASTPredicate.java:[21,34]
>  cannot find symbol
> symbol: class SimpleNode
> public class ASTPredicate extends SimpleNode {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[49,24]
>  cannot find symbol
> symbol  : class ASTOrExpression
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[53,24]
>  cannot find symbol
> symbol  : class ASTAndExpression
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[57,24]
>  cannot find symbol
> symbol  : class ASTNotExpression
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[61,24]
>  cannot find symbol
> symbol  : class ASTBracketExpression
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/ASTLiteral.java:[19,32]
>  cannot find symbol
> symbol: class SimpleNode
> public class ASTLiteral extends SimpleNode {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/ASTIdentifier.java:[21,35]
>  cannot find symbol
> symbol: class SimpleNode
> public class ASTIdentifier extends SimpleNode {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[73,24]
>  cannot find symbol
> symbol  : class ASTOrderByClause
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/ASTContainsExpression.java:[21,43]
>  cannot find symbol
> symbol: class SimpleNode
> public class ASTContainsExpression extends SimpleNode {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[81,24]
>  cannot find symbol
> symbol  : class ASTOrderSpec
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[85,24]
>  cannot find symbol
> symbol  : class ASTAscendingOrderSpec
> location: 

[jira] Updated: (JCR-1185) building trunk fails with javacc plugin version 2.2

2007-11-01 Thread Jukka Zitting (JIRA)

 [ 
https://issues.apache.org/jira/browse/JCR-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jukka Zitting updated JCR-1185:
---

Fix Version/s: 1.4
  Summary: building trunk  fails with javacc plugin version 2.2  (was: 
building trunk fails)

> building trunk  fails with javacc plugin version 2.2
> 
>
> Key: JCR-1185
> URL: https://issues.apache.org/jira/browse/JCR-1185
> Project: Jackrabbit
>  Issue Type: Bug
>  Components: jackrabbit-core
> Environment: JDK 1.5
> Mac OSX
>Reporter: Alan Cabrera
>Assignee: Dominique Pfister
> Fix For: 1.4
>
> Attachments: build.log
>
>
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[23,38]
>  cannot find symbol
> symbol: class JCRSQLParserVisitor
> class DefaultParserVisitor implements JCRSQLParserVisitor {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[25,24]
>  cannot find symbol
> symbol  : class SimpleNode
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[29,24]
>  cannot find symbol
> symbol  : class ASTQuery
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[33,24]
>  cannot find symbol
> symbol  : class ASTSelectList
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[37,24]
>  cannot find symbol
> symbol  : class ASTFromClause
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[41,24]
>  cannot find symbol
> symbol  : class ASTWhereClause
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/ASTPredicate.java:[21,34]
>  cannot find symbol
> symbol: class SimpleNode
> public class ASTPredicate extends SimpleNode {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[49,24]
>  cannot find symbol
> symbol  : class ASTOrExpression
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[53,24]
>  cannot find symbol
> symbol  : class ASTAndExpression
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[57,24]
>  cannot find symbol
> symbol  : class ASTNotExpression
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[61,24]
>  cannot find symbol
> symbol  : class ASTBracketExpression
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/ASTLiteral.java:[19,32]
>  cannot find symbol
> symbol: class SimpleNode
> public class ASTLiteral extends SimpleNode {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/ASTIdentifier.java:[21,35]
>  cannot find symbol
> symbol: class SimpleNode
> public class ASTIdentifier extends SimpleNode {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[73,24]
>  cannot find symbol
> symbol  : class ASTOrderByClause
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/ASTContainsExpression.java:[21,43]
>  cannot find symbol
> symbol: class SimpleNode
> public class ASTContainsExpression extends SimpleNode {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[81,24]
>  cannot find symbol
> symbol  : class ASTOrderSpec
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[85,24]
>  cannot find symbol
> symbol  : class ASTAscendingOrd

[jira] Resolved: (JCR-1191) mvn fails with javacc-maven-plugin 2.2 in jackrabbit-core

2007-11-01 Thread Jukka Zitting (JIRA)

 [ 
https://issues.apache.org/jira/browse/JCR-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jukka Zitting resolved JCR-1191.


Resolution: Duplicate
  Assignee: Jukka Zitting

Duplicate of JCR-1185.

> mvn fails with javacc-maven-plugin 2.2 in jackrabbit-core
> -
>
> Key: JCR-1191
> URL: https://issues.apache.org/jira/browse/JCR-1191
> Project: Jackrabbit
>  Issue Type: Bug
>  Components: maven
>Affects Versions: 1.4
>Reporter: Juan Jose Vazquez Delgado
>Assignee: Jukka Zitting
>Priority: Minor
>
> When you build jackrabbit-core with version 2.2 of javacc-maven-plugin you 
> get:
> [INFO] [javacc:jjtree {execution: fulltext-jjtree}]
> [INFO] 
> 
> [ERROR] FATAL ERROR
> [INFO] 
> 
> [INFO] basedir 
> C:\eclipse_33_workspaces\ASF\jackrabbit\jackrabbit-core\C:\eclipse_33_workspaces\ASF\jackrabbit\jackrabbit-core\src\main\javacc\fulltext
>  does not exist
> [INFO] 
> 
> [INFO] Trace
> java.lang.IllegalStateException: basedir 
> C:\eclipse_33_workspaces\ASF\jackrabbit\jackrabbit-core\C:\eclipse_33_workspaces\ASF\jackrabbit\jackrabbit-core\src\main\javacc\fulltext
>  does not exist
>   at 
> org.codehaus.plexus.util.DirectoryScanner.scan(DirectoryScanner.java:542)
>   at 
> org.codehaus.plexus.compiler.util.scan.AbstractSourceInclusionScanner.scanForSources(AbstractSourceInclusionScanner.java:78)
>   at 
> org.codehaus.plexus.compiler.util.scan.StaleSourceScanner.getIncludedSources(StaleSourceScanner.java:84)
>   at 
> org.codehaus.mojo.javacc.JJTreeMojo.computeStaleGrammars(JJTreeMojo.java:349)
>   at org.codehaus.mojo.javacc.JJTreeMojo.execute(JJTreeMojo.java:198)
>   at 
> org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:443)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:539)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:480)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:459)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:311)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:278)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:334)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:125)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:280)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>   at java.lang.reflect.Method.invoke(Method.java:585)
>   at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
>   at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
>   at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
>   at org.codehaus.classworlds.Launcher.main(Launcher.java:375)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (JCR-1192) Build break with latest version (2.2) of javacc-maven-plugin

2007-11-01 Thread Jukka Zitting (JIRA)

 [ 
https://issues.apache.org/jira/browse/JCR-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jukka Zitting resolved JCR-1192.


Resolution: Duplicate
  Assignee: Jukka Zitting

Thanks for the problem report and the fix! Fixed as suggested in the duplicate 
issue JCR-1185.

> Build break with latest version (2.2) of javacc-maven-plugin
> 
>
> Key: JCR-1192
> URL: https://issues.apache.org/jira/browse/JCR-1192
> Project: Jackrabbit
>  Issue Type: Bug
>Reporter: Davanum Srinivas
>Assignee: Jukka Zitting
>
> Problem:
> [INFO] 
> 
> [INFO] Building Jackrabbit Core
> [INFO]task-segment: [install]
> [INFO] 
> 
> [INFO] [javacc:jjtree {execution: fulltext-jjtree}]
> [INFO] 
> 
> [ERROR] FATAL ERROR
> [INFO] 
> 
> [INFO] basedir 
> C:\APACHE\jackrabbit\jackrabbit-core\C:\APACHE\jackrabbit\jackrabbit-core\src\main\javacc\fulltext
>  does not exist
> [INFO] 
> 
> [INFO] Trace
> java.lang.IllegalStateException: basedir 
> C:\APACHE\jackrabbit\jackrabbit-core\C:\APACHE\jackrabbit\jackrabbit-core\src\main\javacc\fulltext
>  does not exist
> at 
> org.codehaus.plexus.util.DirectoryScanner.scan(DirectoryScanner.java:542)
> at 
> org.codehaus.plexus.compiler.util.scan.AbstractSourceInclusionScanner.scanForSources(AbstractSourceInclusionScanner.java:78)
> at 
> org.codehaus.plexus.compiler.util.scan.StaleSourceScanner.getIncludedSources(StaleSourceScanner.java:84)
> at 
> org.codehaus.mojo.javacc.JJTreeMojo.computeStaleGrammars(JJTreeMojo.java:349)
> at org.codehaus.mojo.javacc.JJTreeMojo.execute(JJTreeMojo.java:198)
> at 
> org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:443)
> at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:539)
> at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:480)
> at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:459)
> at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:311)
> at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:278)
> at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:334)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:125)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:272)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
> at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
> at 
> org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
> at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
> [INFO] 
> 
> [INFO] Total time: 4 seconds
> Simple Fix: Use old version of the plugin
> Index: jackrabbit-core/pom.xml
> ===
> --- jackrabbit-core/pom.xml (revision 589393)
> +++ jackrabbit-core/pom.xml (working copy)
> @@ -101,6 +101,7 @@
>
>  org.codehaus.mojo
>  javacc-maven-plugin
> +2.1
>  
>
>  fulltext-jjtree

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (JCR-1185) building trunk fails with javacc plugin version 2.2

2007-11-01 Thread Jukka Zitting (JIRA)

[ 
https://issues.apache.org/jira/browse/JCR-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539369
 ] 

Jukka Zitting commented on JCR-1185:


For the record, this problem seems related to the 
http://jira.codehaus.org/browse/MJAVACC-29 issue introduced in the javacc 
plugin version 2.2

> building trunk  fails with javacc plugin version 2.2
> 
>
> Key: JCR-1185
> URL: https://issues.apache.org/jira/browse/JCR-1185
> Project: Jackrabbit
>  Issue Type: Bug
>  Components: jackrabbit-core
> Environment: JDK 1.5
> Mac OSX
>Reporter: Alan Cabrera
>Assignee: Dominique Pfister
> Fix For: 1.4
>
> Attachments: build.log
>
>
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[23,38]
>  cannot find symbol
> symbol: class JCRSQLParserVisitor
> class DefaultParserVisitor implements JCRSQLParserVisitor {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[25,24]
>  cannot find symbol
> symbol  : class SimpleNode
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[29,24]
>  cannot find symbol
> symbol  : class ASTQuery
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[33,24]
>  cannot find symbol
> symbol  : class ASTSelectList
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[37,24]
>  cannot find symbol
> symbol  : class ASTFromClause
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[41,24]
>  cannot find symbol
> symbol  : class ASTWhereClause
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/ASTPredicate.java:[21,34]
>  cannot find symbol
> symbol: class SimpleNode
> public class ASTPredicate extends SimpleNode {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[49,24]
>  cannot find symbol
> symbol  : class ASTOrExpression
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[53,24]
>  cannot find symbol
> symbol  : class ASTAndExpression
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[57,24]
>  cannot find symbol
> symbol  : class ASTNotExpression
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[61,24]
>  cannot find symbol
> symbol  : class ASTBracketExpression
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/ASTLiteral.java:[19,32]
>  cannot find symbol
> symbol: class SimpleNode
> public class ASTLiteral extends SimpleNode {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/ASTIdentifier.java:[21,35]
>  cannot find symbol
> symbol: class SimpleNode
> public class ASTIdentifier extends SimpleNode {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[73,24]
>  cannot find symbol
> symbol  : class ASTOrderByClause
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/ASTContainsExpression.java:[21,43]
>  cannot find symbol
> symbol: class SimpleNode
> public class ASTContainsExpression extends SimpleNode {
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[81,24]
>  cannot find symbol
> symbol  : class ASTOrderSpec
> location: class org.apache.jackrabbit.core.query.sql.DefaultParserVisitor
> /Users/adc/dev/jackrabbit/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql/DefaultParserVisitor.java:[85,24]
>  ca

[jira] Commented: (JCR-1180) DatabaseFileSystem and DatabasePersistenceManager don't allow choice of db schema

2007-11-01 Thread Thomas Mueller (JIRA)

[ 
https://issues.apache.org/jira/browse/JCR-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539388
 ] 

Thomas Mueller commented on JCR-1180:
-

Hi,

The error message when using the wrong 'schema' is now changed in revision 
591046.
Kev, I'm not sure if you read my comment about compatibility: What about: 
support a new setting 'schemaDDL' (or what about just 'ddl', or 'ddlResource'), 
and change all samples to use this property name. But still support 'schema' as 
well for backward compatibility. 

Thomas


> DatabaseFileSystem and DatabasePersistenceManager don't allow choice of db 
> schema
> -
>
> Key: JCR-1180
> URL: https://issues.apache.org/jira/browse/JCR-1180
> Project: Jackrabbit
>  Issue Type: Improvement
>  Components: jackrabbit-core
> Environment: All
>Reporter: Kev Jackson
>Priority: Minor
> Fix For: 1.4
>
> Attachments: jackrabbit-core.patch
>
>
> I have a need to store my repository objects under a different db schema than 
> the default for the rdbms (I'm using postgresql, so in my case the default is 
> 'public')
> The current implementation of the DatabasePersistenceManager and 
> DatabaseFileSystem do not support changing the schema.
> Problems:
> - schemaObjectPrefix allows the user to add a table prefix, but you cannot 
> use this to set a schema ie .table, as the . is stripped out and 
> replaced with an escaped version
> - schema param currently refers to a ddl resource, not what people would 
> naturally think is the param to set the schema for the repository
> Fix:
> - rename the current schema -> schemaDDL
> - add an optional schema param which allows the user to select which schema 
> they want to use
> - improve error messages so that when an incorrect schemaDDL is chosen the 
> user doesn't have to dig through nabble etc to find an answer

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



SPI observation: EventFilter lifecycle

2007-11-01 Thread Julian Reschke

Hi,

here are some thoughts about the current SPI EventFilter interface:

Proposal: document that getEvents only needs to accept EventFilter 
objects created by the same SPI implementation for the same SessionInfo 
(this reflects reality in JCR2SPI)


Proposal: remove special case in getEvents for EventFilter array being null.

These changes will allow the SPI implementation to early filter internal 
events, even before getEvents() gets called.


Question: do we expect many cases in which a client stops listening for 
events, but keeps the JCR session open? In this case it might be good if 
we could indicate that an EventFilter is not going to be used anymore, 
for instance using a dispose() method.


Best regards, Julian




[OCM] Dynamic Mixin Support

2007-11-01 Thread Padraic Hannon


I have been reviewing the implementation I submitted for mixin support  
in JCR-1100 and am struggling with how to proceed. On the one hand I  
think the implementation that was submitted is nice since it has some  
amount of type safety and gives the developer the ability to cast  
objects. On the other hand, how is a developer to know what to cast  
the objects to? I am starting to experiment with using the bean  
generator cglib code which will allow me to use regular javabeans. My  
idea is that the mapped node type would be used to instantiate the  
object and then for mixin properties I would create a new class  
dynamically which contains all the mixin's properties. I would modify  
the object converter to first create the object with its nodes mapped  
properties then I would take each mixin for its node and grab the  
attributes for the mixin based on the mixin definition mapped in xml  
(not sure how to handle this in JDK 1.5 where the mappings are done  
with annotations) and add these attributes to a new class which is a  
subclass of the node's defined class. This new class would have  
properties defined for each property in the mixin.


Has anyone else thought about how to handle this? Is this really a  
need, or should I just go back to using hashmaps (not something I  
really like, but)


-paddy




[jira] Commented: (JCR-1154) Database Data Store

2007-11-01 Thread Esteban Franqueiro (JIRA)

[ 
https://issues.apache.org/jira/browse/JCR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539451
 ] 

Esteban Franqueiro commented on JCR-1154:
-

See 
http://www.nabble.com/Re%3A--jira--Commented%3A-%28JCR-1154%29-Database-Data-Store-p13535861.html
 for response.

> Database Data Store
> ---
>
> Key: JCR-1154
> URL: https://issues.apache.org/jira/browse/JCR-1154
> Project: Jackrabbit
>  Issue Type: New Feature
>  Components: jackrabbit-core
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Blocker
> Fix For: 1.4
>
> Attachments: jr-1.3.1-bea.zip
>
>
> We want to have a database backed data store implementation.
> An implementation using files is already available as part of JCR-926.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: [jira] Commented: (JCR-1154) Database Data Store

2007-11-01 Thread Esteban Franqueiro
Hi Thomas.

> - please use spaces, not tabs (Jackrabbit consistently uses spaces)
> - please don't use import ...*
> - byte b[] > byte[] b
> - public is not required in interfaces
> - return does not require (..)
>
> To fix such problems, I use Checkstyle. If you like I can post the 
> configuration I use.

Sure, please do that.
How do you run checkstyle?

> Garbage collection: I like make garbage collection implementation 
> independent; is it OK for you if 
> I remove those cases?

Sorry, which cases?

> AbstractGarbageCollector and AbstractDataStore are not required then (anyway 
> they are small).

The AbstractDataStore class has members that are common to both data stores, 
and are implementation 
independent. It can be removed, but we'll en up with a lot of duplicated code 
in both subclasses.
On the other hand, the AbstractGarbageCollector is easier, the only difference 
is that 
FileGarbageCollector overrides touchBinaryProperty(), which is different. I 
guess you can merge both 
methods in one that calls back to the data store impl to update the record's 
time, but the way I see 
it now is probably more complicated. Maybe you can tell me your idea on how to 
do this, so I can 
understand better.

> It would be great if the database data store would automatically re-connect 
> if the connection was 
> lost (important for MySQL). To achieve this, 
> org.apache.jackrabbit.core.persistence.bundle.util.ConnectionRecoveryManager 
> can be used.

This is our point of most concern.
The problem is that if we follow in the data store the pattern used in the PMs 
(only one 
connection), it won't be possible to have multiple clients concurrently 
uploading binaries. That's 
why we did it that way.
Still, we don't think that adding reconnection is going to be a problem, but 
what concerns us is 
that doing so forces the one connection pattern.
In our app we subclass the DatabaseDataStore class and override the 
getConection(boolean) method to 
use a connection pool provided by the DataDirect JDBC drivers.

> It's quite tricky that DatabaseRecord extends FilterInputStream... However 
> I'm not sure if it is 
> required, is it not possible to just wrap the database BLOB object?

Yes, not only tricky but also very ugly. We had to it like that because the way 
our application 
handles the binaries. But alas, we fixed that already. I'll send the changes as 
soon as I figure out 
how to make a decent patch.

> I don't think that FileDataStoreConstants is required.

You're right, their just a leftover. Although I do think that the buffer size 
in FileDataStore 
should be added as a constant, and maybe increased to 16 or 64KB

> Those are just my view, and I'm open to discuss them of course.
> If you have time to change it yourself please go ahead. Otherwise I will do 
> it and post the patch 
> here before I commit it - but it will take a few more days.

Do you have a patch against trunk?
If you do, please upload it, so I can update it with our latest changes and 
test cases.
After that I'll have no problem in doing these.
Looking at the ConnectionRecoveryManager, I think that its private methods 
should be delcared as 
protected instead of private, because it should be possible to override them.

Regards,

Esteban Franqueiro
[EMAIL PROTECTED] 


Notice:  This email message, together with any attachments, may contain 
information  of  BEA Systems,  Inc.,  its subsidiaries  and  affiliated 
entities,  that may be confidential,  proprietary,  copyrighted  and/or legally 
privileged, and is intended solely for the use of the individual or entity 
named in this message. If you are not the intended recipient, and have received 
this message in error, please immediately return this by email and then delete 
it.


Re: SPI observation: EventFilter lifecycle

2007-11-01 Thread Jukka Zitting
Hi,

On 11/1/07, Julian Reschke <[EMAIL PROTECTED]> wrote:
> Proposal: document that getEvents only needs to accept EventFilter
> objects created by the same SPI implementation for the same SessionInfo
> (this reflects reality in JCR2SPI)

+1 There's no guarantee that a remote implementation can deserialize
foreign EventFilters.

> Proposal: remove special case in getEvents for EventFilter array being null.

+1 One can achieve the same result using a catchall EventFilter.

> These changes will allow the SPI implementation to early filter internal
> events, even before getEvents() gets called.

Nice.

> Question: do we expect many cases in which a client stops listening for
> events, but keeps the JCR session open? In this case it might be good if
> we could indicate that an EventFilter is not going to be used anymore,
> for instance using a dispose() method.

I guess that's a relatively rare use case, so I'd just ignore it for simplicity.

BR,

Jukka Zitting


[jira] Created: (JCR-1203) Reorganize core test suite

2007-11-01 Thread Jukka Zitting (JIRA)
Reorganize core test suite
--

 Key: JCR-1203
 URL: https://issues.apache.org/jira/browse/JCR-1203
 Project: Jackrabbit
  Issue Type: Improvement
  Components: jackrabbit-core
Reporter: Jukka Zitting
Assignee: Jukka Zitting


I'd like to better organize the test setup in jackrabbit-core. The current test 
repository is located in applications/test and managed with custom ant tasks 
and explicit do_init/do_test surefire configuration. It would be better to have 
the test repository located in target/repository (with template content coming 
from src/test/repository) and managed using the Maven 2 integration test 
lifecycle phases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.