[jira] [Commented] (JENA-1526) OPTIONAL clause filters out results when defined before inner SELECT

2018-04-25 Thread Kevin Smyth (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453120#comment-16453120
 ] 

Kevin Smyth commented on JENA-1526:
---

Thanks for the thorough explanation.

> OPTIONAL clause filters out results when defined before inner SELECT
> 
>
> Key: JENA-1526
> URL: https://issues.apache.org/jira/browse/JENA-1526
> Project: Apache Jena
>  Issue Type: Question
> Environment: apache-jena-fuseki-3.7.0
>Reporter: Kevin Smyth
>Assignee: Andy Seaborne
>Priority: Major
>
> Given this dataset
> {code:java}
> @prefix ns1:  .
> @prefix xsd:  .
> 
> a ns1:type_ ;
> ns1:sb  .
> 
> ns1:satisfies  ;
> ns1:run_id ns1:29 .
> ns1:29 a ns1:run ;
> ns1:time "2018-04-12T19:43:14.702"^^xsd:dateTime .
> ns1:799fdfc a ns1:run ;
> ns1:time "2018-04-13T16:55:47-05:00"^^xsd:dateTime .
> {code}
> This query:
> {code:java}
> PREFIX ns1: 
> SELECT ?s ?run ?id 
> WHERE {
> ?s a ns1:type_ .
> {
> SELECT ?id
> WHERE {
> values ?id { ns1:799fdfc }
> } LIMIT 1
> }
> OPTIONAL {
> ?s ns1:sb ?run .
> ?run ns1:run_id ?id .
> }
> }
> {code}
> produces 1 result, whereas switching the inner SELECT and OPTIONAL:
> {code:java}
> PREFIX ns1: 
> SELECT ?s ?run ?id 
> WHERE {
> ?s a ns1:type_ .
> OPTIONAL { ?s ns1:sb ?run . 
> ?run ns1:run_id ?id . }
> {
> SELECT ?id
> WHERE {
> values ?id { ns1:799fdfc }
> } LIMIT 1
> }
> }{code}
>  
> produces no results.
>  
> The spec specifies "In an optional match, either the optional graph pattern 
> matches a graph, thereby defining and adding bindings to one or more 
> solutions, or it leaves a solution unchanged without adding any additional 
> bindings." and "Due to the bottom-up nature of SPARQL query evaluation, the 
> subqueries are evaluated logically first, and the results are projected up to 
> the outer query.", so I don't see how this is the correct behavior.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JENA-1524) org.apache.jena.system is split by org.apache.jena.arq and org.apache.jena.core

2018-04-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453084#comment-16453084
 ] 

ASF GitHub Bot commented on JENA-1524:
--

Github user christopher-johnson commented on the issue:

https://github.com/apache/jena/pull/401
  
a quick note here about the prospect of further restructuring to support 
jpms.  I have learned today that if a module (e.g. `org.apache.jena.arq`) does 
not contain a single top level package this creates an "ambiguous module".  The 
expectation is that the module contains a hierarchy of packages and this does 
not exist in the primary jena library modules,  It is possible for the top 
package to not contain any classes, but the `module-info.java`  then must 
explictly export every subpackage it wants to make public.   With a new package 
hierarchy, it does not seem possible to maintain compatibility with existing 
implementations _and_ support modules with jena master.  One possibility might 
be to create a new branch and produce distinct artifacts that could be used 
downstream.  It could also be used for testing and making changes to support 
the new jdk methods without impacting LTS.  btw, I have noticed in running the 
tests that there are a few issues due to jdk changes (`java.nio.ByteBuffer`, 
for example).  This might be a question for the dev list.


> org.apache.jena.system is split by org.apache.jena.arq and 
> org.apache.jena.core
> ---
>
> Key: JENA-1524
> URL: https://issues.apache.org/jira/browse/JENA-1524
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.7.0
>Reporter: Christopher Johnson
>Assignee: Andy Seaborne
>Priority: Major
> Fix For: Jena 3.8.0
>
>
> a JPMS module cannot require both org.apache.jena.arq and 
> org.apache.jena.core since org.apache.jena.system can be read from both.  
> This cannot be resolved with --patch-module since arq and core provide 
> different implementations.  Suggestion is to make a distinction by renaming 
> system to sys in either one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-25 Thread christopher-johnson
Github user christopher-johnson commented on the issue:

https://github.com/apache/jena/pull/401
  
a quick note here about the prospect of further restructuring to support 
jpms.  I have learned today that if a module (e.g. `org.apache.jena.arq`) does 
not contain a single top level package this creates an "ambiguous module".  The 
expectation is that the module contains a hierarchy of packages and this does 
not exist in the primary jena library modules,  It is possible for the top 
package to not contain any classes, but the `module-info.java`  then must 
explictly export every subpackage it wants to make public.   With a new package 
hierarchy, it does not seem possible to maintain compatibility with existing 
implementations _and_ support modules with jena master.  One possibility might 
be to create a new branch and produce distinct artifacts that could be used 
downstream.  It could also be used for testing and making changes to support 
the new jdk methods without impacting LTS.  btw, I have noticed in running the 
tests that there are a few issues due to jdk changes (`java.nio.Byt
 eBuffer`, for example).  This might be a question for the dev list.


---


[jira] [Resolved] (JENA-1533) Update Googe Guava (shaded) to version 24.1-jre

2018-04-25 Thread Andy Seaborne (JIRA)

 [ 
https://issues.apache.org/jira/browse/JENA-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Seaborne resolved JENA-1533.
-
   Resolution: Fixed
Fix Version/s: Jena 3.8.0

> Update Googe Guava (shaded) to version 24.1-jre
> ---
>
> Key: JENA-1533
> URL: https://issues.apache.org/jira/browse/JENA-1533
> Project: Apache Jena
>  Issue Type: Task
>Affects Versions: Jena 3.7.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
> Fix For: Jena 3.8.0
>
>
> Update to the latest Google Guava release for the JRE.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JENA-1533) Update Googe Guava (shaded) to version 24.1-jre

2018-04-25 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453045#comment-16453045
 ] 

ASF subversion and git services commented on JENA-1533:
---

Commit e3a314a1117cf08edb9e5bbcce3f0c3bd6fd1a11 in jena's branch 
refs/heads/master from [~andy.seaborne]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=e3a314a ]

JENA-1533: Merge commit 'refs/pull/408/head' of https://github.com/apache/jena

This closes #408.


> Update Googe Guava (shaded) to version 24.1-jre
> ---
>
> Key: JENA-1533
> URL: https://issues.apache.org/jira/browse/JENA-1533
> Project: Apache Jena
>  Issue Type: Task
>Affects Versions: Jena 3.7.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
>
> Update to the latest Google Guava release for the JRE.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JENA-1533) Update Googe Guava (shaded) to version 24.1-jre

2018-04-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453047#comment-16453047
 ] 

ASF GitHub Bot commented on JENA-1533:
--

Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/408


> Update Googe Guava (shaded) to version 24.1-jre
> ---
>
> Key: JENA-1533
> URL: https://issues.apache.org/jira/browse/JENA-1533
> Project: Apache Jena
>  Issue Type: Task
>Affects Versions: Jena 3.7.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
>
> Update to the latest Google Guava release for the JRE.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JENA-1533) Update Googe Guava (shaded) to version 24.1-jre

2018-04-25 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453044#comment-16453044
 ] 

ASF subversion and git services commented on JENA-1533:
---

Commit de3d42bb3d5530cafd324372f1cab6982dc81fae in jena's branch 
refs/heads/master from [~andy.seaborne]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=de3d42b ]

JENA-1533: Update Google Guava to 24.1-jre


> Update Googe Guava (shaded) to version 24.1-jre
> ---
>
> Key: JENA-1533
> URL: https://issues.apache.org/jira/browse/JENA-1533
> Project: Apache Jena
>  Issue Type: Task
>Affects Versions: Jena 3.7.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
>
> Update to the latest Google Guava release for the JRE.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena pull request #408: JENA-1533: Update Google Guava to 24.1-jre

2018-04-25 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/408


---


Re: Trivial updates to Jena site

2018-04-25 Thread Andy Seaborne

Excellent - thank for this. I like the menu link changes especially.

Andy

On 21/04/18 23:05, Bruno P. Kinoshita wrote:

Hi all,

Sharing it here i) so others know what changed in case something breaks soon 
and ii) because even though
trivial updates, I found an old post-it in the middle of a pile of papers next 
to my desk, where I
left a note to myself.

When launching the new site for OpenNLP, I - shamelessly - copied many parts of 
the Jena website. However,
I noticed a small padding, 1 or 2 pixels, under the navigation menu. I spent 
quite some time chasing that
in the CSS schema, and found that the OpenNLP logo had no size defined, and it 
would be set to 52px due
to some inherited height. Instead, now it is set to 50px, as the other menu 
items... so when a menu item
is active, there is no more space (regardless of how small!) under it.

Another thing I noticed in Jena site, was that some items would be highlighted as 
"active", receiving a
distinct background colour, but others would not. Then I learned that in each 
markdown file you had to
call a piece of JS code to set the active link. I scratched my head for a 
while, looking for a lazy-er
solution, and found somewhere the following code snippet.


var link = $('a[href="' + this.location.pathname + '"]');
if (link != undefined)
link.parents('li,ul').addClass('active');


The first line locates an HTML  element, with HREF attribute set to our 
current location. If found,
that should be our link. Then it tries to locate all parents of that link which are 
 or 
(failing in case we have a simple link in a page) and then sets the class to 
active.

Finally, looks like NZ or perhaps some of my DNS are getting redirect error for 
JQuery 2.0.3
(https://code.jquery.com/jquery-2.0.3.min.js), with a message in the browser
"The page isn’t redirecting properly", but all other files were working. So 
I've updated
our JQuery to the latest 2.x version. Tested download/improve/menu links, and 
everything
seems to be working fine.

If interested, go have a look at

http://jena.staging.apache.org/index.html

Open some links under Getting involved, Learn, and the main menu should have a 
different colour now.

Sorry the long e-mail, just happy to throw away such an old post-it.

Cheers
Bruno



[jira] [Commented] (JENA-1488) SelectiveFoldingFilter for jena-text

2018-04-25 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452058#comment-16452058
 ] 

ASF subversion and git services commented on JENA-1488:
---

Commit f3c0abacee7a32057b9b977a0a3a7a443e869560 in jena's branch 
refs/heads/master from [~andy.seaborne]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=f3c0aba ]

JENA-1488: Remove warnigns, use try-resource


> SelectiveFoldingFilter for jena-text
> 
>
> Key: JENA-1488
> URL: https://issues.apache.org/jira/browse/JENA-1488
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Text
>Affects Versions: Jena 3.6.0
>Reporter: Osma Suominen
>Assignee: Bruno P. Kinoshita
>Priority: Major
> Fix For: Jena 3.8.0
>
>
> Currently there's some support for accent folding in jena-text, because 
> Lucene provides an ASCIIFoldingFilter. When this filter is enabled, a search 
> for "deja vu" will match the literal "déjà vu" in the data.
> But we can't use it here at the National Library of Finland (for Finto.fi / 
> Skosmos), because it folds too much! In the Finnish alphabet, in addition to 
> the Latin a-z (which are in ASCII) we use the letters åäö and these should 
> not be folded to ASCII. So we need a Lucene analyzer that can be configured 
> with an exclude list, something like 
>  
> new SelectiveFoldingFilter(String excludeChars) 
>  
> and that can be also be configured via the Jena assembler just like other 
> analyzers supported by jena-text. 
>  
> This was also briefly discussed on the skosmos-users mailing list: 
> [https://groups.google.com/d/msg/skosmos-users/x3zR_uRBQT0/Q90-O_iDAQAJ] 
> Apparently Norwegians have the same problem...
> I've discussed this with [~kinow] and he has some initial code to implement 
> this feature, so I think we can turn this into a PR fairly soon.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (JENA-1526) OPTIONAL clause filters out results when defined before inner SELECT

2018-04-25 Thread Andy Seaborne (JIRA)

 [ 
https://issues.apache.org/jira/browse/JENA-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Seaborne closed JENA-1526.
---
Resolution: Information Provided
  Assignee: Andy Seaborne

> OPTIONAL clause filters out results when defined before inner SELECT
> 
>
> Key: JENA-1526
> URL: https://issues.apache.org/jira/browse/JENA-1526
> Project: Apache Jena
>  Issue Type: Question
> Environment: apache-jena-fuseki-3.7.0
>Reporter: Kevin Smyth
>Assignee: Andy Seaborne
>Priority: Major
>
> Given this dataset
> {code:java}
> @prefix ns1:  .
> @prefix xsd:  .
> 
> a ns1:type_ ;
> ns1:sb  .
> 
> ns1:satisfies  ;
> ns1:run_id ns1:29 .
> ns1:29 a ns1:run ;
> ns1:time "2018-04-12T19:43:14.702"^^xsd:dateTime .
> ns1:799fdfc a ns1:run ;
> ns1:time "2018-04-13T16:55:47-05:00"^^xsd:dateTime .
> {code}
> This query:
> {code:java}
> PREFIX ns1: 
> SELECT ?s ?run ?id 
> WHERE {
> ?s a ns1:type_ .
> {
> SELECT ?id
> WHERE {
> values ?id { ns1:799fdfc }
> } LIMIT 1
> }
> OPTIONAL {
> ?s ns1:sb ?run .
> ?run ns1:run_id ?id .
> }
> }
> {code}
> produces 1 result, whereas switching the inner SELECT and OPTIONAL:
> {code:java}
> PREFIX ns1: 
> SELECT ?s ?run ?id 
> WHERE {
> ?s a ns1:type_ .
> OPTIONAL { ?s ns1:sb ?run . 
> ?run ns1:run_id ?id . }
> {
> SELECT ?id
> WHERE {
> values ?id { ns1:799fdfc }
> } LIMIT 1
> }
> }{code}
>  
> produces no results.
>  
> The spec specifies "In an optional match, either the optional graph pattern 
> matches a graph, thereby defining and adding bindings to one or more 
> solutions, or it leaves a solution unchanged without adding any additional 
> bindings." and "Due to the bottom-up nature of SPARQL query evaluation, the 
> subqueries are evaluated logically first, and the results are projected up to 
> the outer query.", so I don't see how this is the correct behavior.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (JENA-1533) Update Googe Guava (shaded) to version 24.1-jre

2018-04-25 Thread Andy Seaborne (JIRA)

 [ 
https://issues.apache.org/jira/browse/JENA-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Seaborne updated JENA-1533:

Summary: Update Googe Guava (shaded) to version 24.1-jre  (was: Update 
Googe Guava (shaed) to version 24.1-jre)

> Update Googe Guava (shaded) to version 24.1-jre
> ---
>
> Key: JENA-1533
> URL: https://issues.apache.org/jira/browse/JENA-1533
> Project: Apache Jena
>  Issue Type: Task
>Affects Versions: Jena 3.7.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
>
> Update to the latest Google Guava release for the JRE.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (JENA-1531) Fuseki does not print correct status code in NCSA request log

2018-04-25 Thread Andy Seaborne (JIRA)

 [ 
https://issues.apache.org/jira/browse/JENA-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Seaborne resolved JENA-1531.
-
Resolution: Fixed

> Fuseki does not print correct status code in NCSA request log
> -
>
> Key: JENA-1531
> URL: https://issues.apache.org/jira/browse/JENA-1531
> Project: Apache Jena
>  Issue Type: Task
>Affects Versions: Jena 3.7.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
> Fix For: Jena 3.8.0
>
>
> Fuseki does not print correct status code in NCSA request log because the 
> request log entry is printed out as any error code is passed up by exception 
> and before the response status is set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JENA-1524) org.apache.jena.system is split by org.apache.jena.arq and org.apache.jena.core

2018-04-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452033#comment-16452033
 ] 

ASF GitHub Bot commented on JENA-1524:
--

Github user afs commented on the issue:

https://github.com/apache/jena/pull/401
  
See PR #408 for updating the shaded Google guava.


> org.apache.jena.system is split by org.apache.jena.arq and 
> org.apache.jena.core
> ---
>
> Key: JENA-1524
> URL: https://issues.apache.org/jira/browse/JENA-1524
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.7.0
>Reporter: Christopher Johnson
>Priority: Major
> Fix For: Jena 3.8.0
>
>
> a JPMS module cannot require both org.apache.jena.arq and 
> org.apache.jena.core since org.apache.jena.system can be read from both.  
> This cannot be resolved with --patch-module since arq and core provide 
> different implementations.  Suggestion is to make a distinction by renaming 
> system to sys in either one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (JENA-1524) org.apache.jena.system is split by org.apache.jena.arq and org.apache.jena.core

2018-04-25 Thread Andy Seaborne (JIRA)

 [ 
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Seaborne resolved JENA-1524.
-
   Resolution: Fixed
 Assignee: Andy Seaborne
Fix Version/s: Jena 3.8.0

> org.apache.jena.system is split by org.apache.jena.arq and 
> org.apache.jena.core
> ---
>
> Key: JENA-1524
> URL: https://issues.apache.org/jira/browse/JENA-1524
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.7.0
>Reporter: Christopher Johnson
>Assignee: Andy Seaborne
>Priority: Major
> Fix For: Jena 3.8.0
>
>
> a JPMS module cannot require both org.apache.jena.arq and 
> org.apache.jena.core since org.apache.jena.system can be read from both.  
> This cannot be resolved with --patch-module since arq and core provide 
> different implementations.  Suggestion is to make a distinction by renaming 
> system to sys in either one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-25 Thread afs
Github user afs commented on the issue:

https://github.com/apache/jena/pull/401
  
See PR #408 for updating the shaded Google guava.


---


[jira] [Commented] (JENA-1533) Update Googe Guava (shaed) to version 24.1-jre

2018-04-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452032#comment-16452032
 ] 

ASF GitHub Bot commented on JENA-1533:
--

GitHub user afs opened a pull request:

https://github.com/apache/jena/pull/408

JENA-1533: Update Google Guava to 24.1-jre



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afs/jena guava-update

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/408.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #408


commit de3d42bb3d5530cafd324372f1cab6982dc81fae
Author: Andy Seaborne 
Date:   2018-04-25T10:30:41Z

JENA-1533: Update Google Guava to 24.1-jre




> Update Googe Guava (shaed) to version 24.1-jre
> --
>
> Key: JENA-1533
> URL: https://issues.apache.org/jira/browse/JENA-1533
> Project: Apache Jena
>  Issue Type: Task
>Affects Versions: Jena 3.7.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
>
> Update to the latest Google Guava release for the JRE.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (JENA-1533) Update Googe Guava (shaed) to version 24.1-jre

2018-04-25 Thread Andy Seaborne (JIRA)
Andy Seaborne created JENA-1533:
---

 Summary: Update Googe Guava (shaed) to version 24.1-jre
 Key: JENA-1533
 URL: https://issues.apache.org/jira/browse/JENA-1533
 Project: Apache Jena
  Issue Type: Task
Affects Versions: Jena 3.7.0
Reporter: Andy Seaborne
Assignee: Andy Seaborne


Update to the latest Google Guava release for the JRE.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena pull request #408: JENA-1533: Update Google Guava to 24.1-jre

2018-04-25 Thread afs
GitHub user afs opened a pull request:

https://github.com/apache/jena/pull/408

JENA-1533: Update Google Guava to 24.1-jre



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afs/jena guava-update

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/408.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #408


commit de3d42bb3d5530cafd324372f1cab6982dc81fae
Author: Andy Seaborne 
Date:   2018-04-25T10:30:41Z

JENA-1533: Update Google Guava to 24.1-jre




---


[jira] [Commented] (JENA-1482) Add testing when creating Bindings to catch null values earlier.

2018-04-25 Thread Andy Seaborne (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452005#comment-16452005
 ] 

Andy Seaborne commented on JENA-1482:
-

[Commit 3def363|https://git-wip-us.apache.org/repos/asf?p=jena.git;h=3def363] 
adds tests for this ticket.

> Add testing when creating Bindings to catch null values earlier.
> 
>
> Key: JENA-1482
> URL: https://issues.apache.org/jira/browse/JENA-1482
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: ARQ
>Affects Versions: Jena 3.6.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
> Fix For: Jena 3.7.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JENA-1428) NPE in Query Builder

2018-04-25 Thread Andy Seaborne (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452001#comment-16452001
 ] 

Andy Seaborne commented on JENA-1428:
-

Sorry - "1428" was a typo for "1482". The two comments above are not about this 
ticket.

> NPE in Query Builder
> 
>
> Key: JENA-1428
> URL: https://issues.apache.org/jira/browse/JENA-1428
> Project: Apache Jena
>  Issue Type: Bug
>  Components: QueryBuilder
>Affects Versions: Jena 3.4.0
>Reporter: Claude Warren
>Assignee: Claude Warren
>Priority: Major
> Fix For: Jena 3.6.0
>
>
> As reported by Chris Dollin on users mailing list:
> I was experimenting with the query builder and hit a problem
> when I was attempting to construct an Expr. This example:
> package com.epimorphics.scratch;
> import org.apache.jena.arq.querybuilder.ConstructBuilder;
> import org.apache.jena.sparql.expr.E_GreaterThan;
> import org.apache.jena.sparql.expr.Expr;
> import org.apache.jena.sparql.expr.ExprVar;
> import org.apache.jena.sparql.expr.nodevalue.NodeValueInteger;
> import org.junit.Test;
> public class Example {
> @Test public void tryBuilding() {
> ConstructBuilder cb = new ConstructBuilder();
> Expr x = new NodeValueInteger(1);
> Expr y = new ExprVar("y");
> Expr e = new E_GreaterThan(x, y);
> cb.addFilter(e);
> System.err.println(cb.buildString());
> }
> }
> when run fails with a null pointer exception:
> java.lang.NullPointerException
> at org.apache.jena.arq.querybuilder.rewriters.
> AbstractRewriter.changeNode(AbstractRewriter.java:126)
> at org.apache.jena.arq.querybuilder.rewriters.NodeValueRewriter.visit(
> NodeValueRewriter.java:64)
> at org.apache.jena.sparql.expr.nodevalue.NodeValueInteger.
> visit(NodeValueInteger.java:78)
> at org.apache.jena.arq.querybuilder.rewriters.ExprRewriter.visit(
> ExprRewriter.java:127)
> at org.apache.jena.sparql.expr.NodeValue.visit(NodeValue.java:1205)
> at org.apache.jena.arq.querybuilder.rewriters.ExprRewriter.visit(
> ExprRewriter.java:65)
> at org.apache.jena.sparql.expr.ExprFunction2.visit(
> ExprFunction2.java:109)
> at org.apache.jena.arq.querybuilder.rewriters.ElementRewriter.visit(
> ElementRewriter.java:70)
> at org.apache.jena.sparql.syntax.ElementFilter.visit(
> ElementFilter.java:35)
> at org.apache.jena.arq.querybuilder.rewriters.ElementRewriter.visit(
> ElementRewriter.java:141)
> at org.apache.jena.sparql.syntax.ElementGroup.visit(
> ElementGroup.java:120)
> at org.apache.jena.arq.querybuilder.handlers.WhereHandler.addAll(
> WhereHandler.java:81)
> at org.apache.jena.arq.querybuilder.handlers.HandlerBlock.addAll(
> HandlerBlock.java:218)
> at org.apache.jena.arq.querybuilder.handlers.HandlerBlock.addAll(
> HandlerBlock.java:245)
> at org.apache.jena.arq.querybuilder.AbstractQueryBuilder.build(
> AbstractQueryBuilder.java:555)
> at org.apache.jena.arq.querybuilder.AbstractQueryBuilder.buildString(
> AbstractQueryBuilder.java:522)
> at com.epimorphics.scratch.Example.tryBuilding(Example.java:20)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(
> NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(
> DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(
> FrameworkMethod.java:47)
> at org.junit.internal.runners.model.ReflectiveCallable.run(
> ReflectiveCallable.java:12)
> at org.junit.runners.model.FrameworkMethod.invokeExplosively(
> FrameworkMethod.java:44)
> at org.junit.internal.runners.statements.InvokeMethod.
> evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(
> BlockJUnit4ClassRunner.java:70)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(
> BlockJUnit4ClassRunner.java:50)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
> at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(
> JUnit4IdeaTestRunner.java:68)
> at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.
> startRunnerWithArgs(IdeaTestRunner.java:47)
> at com.intellij.rt.execution.junit.JU

[jira] [Commented] (JENA-1428) NPE in Query Builder

2018-04-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451997#comment-16451997
 ] 

ASF GitHub Bot commented on JENA-1428:
--

Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/407


> NPE in Query Builder
> 
>
> Key: JENA-1428
> URL: https://issues.apache.org/jira/browse/JENA-1428
> Project: Apache Jena
>  Issue Type: Bug
>  Components: QueryBuilder
>Affects Versions: Jena 3.4.0
>Reporter: Claude Warren
>Assignee: Claude Warren
>Priority: Major
> Fix For: Jena 3.6.0
>
>
> As reported by Chris Dollin on users mailing list:
> I was experimenting with the query builder and hit a problem
> when I was attempting to construct an Expr. This example:
> package com.epimorphics.scratch;
> import org.apache.jena.arq.querybuilder.ConstructBuilder;
> import org.apache.jena.sparql.expr.E_GreaterThan;
> import org.apache.jena.sparql.expr.Expr;
> import org.apache.jena.sparql.expr.ExprVar;
> import org.apache.jena.sparql.expr.nodevalue.NodeValueInteger;
> import org.junit.Test;
> public class Example {
> @Test public void tryBuilding() {
> ConstructBuilder cb = new ConstructBuilder();
> Expr x = new NodeValueInteger(1);
> Expr y = new ExprVar("y");
> Expr e = new E_GreaterThan(x, y);
> cb.addFilter(e);
> System.err.println(cb.buildString());
> }
> }
> when run fails with a null pointer exception:
> java.lang.NullPointerException
> at org.apache.jena.arq.querybuilder.rewriters.
> AbstractRewriter.changeNode(AbstractRewriter.java:126)
> at org.apache.jena.arq.querybuilder.rewriters.NodeValueRewriter.visit(
> NodeValueRewriter.java:64)
> at org.apache.jena.sparql.expr.nodevalue.NodeValueInteger.
> visit(NodeValueInteger.java:78)
> at org.apache.jena.arq.querybuilder.rewriters.ExprRewriter.visit(
> ExprRewriter.java:127)
> at org.apache.jena.sparql.expr.NodeValue.visit(NodeValue.java:1205)
> at org.apache.jena.arq.querybuilder.rewriters.ExprRewriter.visit(
> ExprRewriter.java:65)
> at org.apache.jena.sparql.expr.ExprFunction2.visit(
> ExprFunction2.java:109)
> at org.apache.jena.arq.querybuilder.rewriters.ElementRewriter.visit(
> ElementRewriter.java:70)
> at org.apache.jena.sparql.syntax.ElementFilter.visit(
> ElementFilter.java:35)
> at org.apache.jena.arq.querybuilder.rewriters.ElementRewriter.visit(
> ElementRewriter.java:141)
> at org.apache.jena.sparql.syntax.ElementGroup.visit(
> ElementGroup.java:120)
> at org.apache.jena.arq.querybuilder.handlers.WhereHandler.addAll(
> WhereHandler.java:81)
> at org.apache.jena.arq.querybuilder.handlers.HandlerBlock.addAll(
> HandlerBlock.java:218)
> at org.apache.jena.arq.querybuilder.handlers.HandlerBlock.addAll(
> HandlerBlock.java:245)
> at org.apache.jena.arq.querybuilder.AbstractQueryBuilder.build(
> AbstractQueryBuilder.java:555)
> at org.apache.jena.arq.querybuilder.AbstractQueryBuilder.buildString(
> AbstractQueryBuilder.java:522)
> at com.epimorphics.scratch.Example.tryBuilding(Example.java:20)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(
> NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(
> DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(
> FrameworkMethod.java:47)
> at org.junit.internal.runners.model.ReflectiveCallable.run(
> ReflectiveCallable.java:12)
> at org.junit.runners.model.FrameworkMethod.invokeExplosively(
> FrameworkMethod.java:44)
> at org.junit.internal.runners.statements.InvokeMethod.
> evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(
> BlockJUnit4ClassRunner.java:70)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(
> BlockJUnit4ClassRunner.java:50)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
> at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(
> JUnit4IdeaTestRunner.java:68)
> at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.
> startRunnerWithArgs(IdeaTestRunner.java:47)
> at com.intellij.rt.execution.ju

[jira] [Commented] (JENA-1428) NPE in Query Builder

2018-04-25 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451994#comment-16451994
 ] 

ASF subversion and git services commented on JENA-1428:
---

Commit 3def36360acc0fecb1ce1ff553279e0412c5bc73 in jena's branch 
refs/heads/master from [~andy.seaborne]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=3def363 ]

JENA-1428: Add tests


> NPE in Query Builder
> 
>
> Key: JENA-1428
> URL: https://issues.apache.org/jira/browse/JENA-1428
> Project: Apache Jena
>  Issue Type: Bug
>  Components: QueryBuilder
>Affects Versions: Jena 3.4.0
>Reporter: Claude Warren
>Assignee: Claude Warren
>Priority: Major
> Fix For: Jena 3.6.0
>
>
> As reported by Chris Dollin on users mailing list:
> I was experimenting with the query builder and hit a problem
> when I was attempting to construct an Expr. This example:
> package com.epimorphics.scratch;
> import org.apache.jena.arq.querybuilder.ConstructBuilder;
> import org.apache.jena.sparql.expr.E_GreaterThan;
> import org.apache.jena.sparql.expr.Expr;
> import org.apache.jena.sparql.expr.ExprVar;
> import org.apache.jena.sparql.expr.nodevalue.NodeValueInteger;
> import org.junit.Test;
> public class Example {
> @Test public void tryBuilding() {
> ConstructBuilder cb = new ConstructBuilder();
> Expr x = new NodeValueInteger(1);
> Expr y = new ExprVar("y");
> Expr e = new E_GreaterThan(x, y);
> cb.addFilter(e);
> System.err.println(cb.buildString());
> }
> }
> when run fails with a null pointer exception:
> java.lang.NullPointerException
> at org.apache.jena.arq.querybuilder.rewriters.
> AbstractRewriter.changeNode(AbstractRewriter.java:126)
> at org.apache.jena.arq.querybuilder.rewriters.NodeValueRewriter.visit(
> NodeValueRewriter.java:64)
> at org.apache.jena.sparql.expr.nodevalue.NodeValueInteger.
> visit(NodeValueInteger.java:78)
> at org.apache.jena.arq.querybuilder.rewriters.ExprRewriter.visit(
> ExprRewriter.java:127)
> at org.apache.jena.sparql.expr.NodeValue.visit(NodeValue.java:1205)
> at org.apache.jena.arq.querybuilder.rewriters.ExprRewriter.visit(
> ExprRewriter.java:65)
> at org.apache.jena.sparql.expr.ExprFunction2.visit(
> ExprFunction2.java:109)
> at org.apache.jena.arq.querybuilder.rewriters.ElementRewriter.visit(
> ElementRewriter.java:70)
> at org.apache.jena.sparql.syntax.ElementFilter.visit(
> ElementFilter.java:35)
> at org.apache.jena.arq.querybuilder.rewriters.ElementRewriter.visit(
> ElementRewriter.java:141)
> at org.apache.jena.sparql.syntax.ElementGroup.visit(
> ElementGroup.java:120)
> at org.apache.jena.arq.querybuilder.handlers.WhereHandler.addAll(
> WhereHandler.java:81)
> at org.apache.jena.arq.querybuilder.handlers.HandlerBlock.addAll(
> HandlerBlock.java:218)
> at org.apache.jena.arq.querybuilder.handlers.HandlerBlock.addAll(
> HandlerBlock.java:245)
> at org.apache.jena.arq.querybuilder.AbstractQueryBuilder.build(
> AbstractQueryBuilder.java:555)
> at org.apache.jena.arq.querybuilder.AbstractQueryBuilder.buildString(
> AbstractQueryBuilder.java:522)
> at com.epimorphics.scratch.Example.tryBuilding(Example.java:20)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(
> NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(
> DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(
> FrameworkMethod.java:47)
> at org.junit.internal.runners.model.ReflectiveCallable.run(
> ReflectiveCallable.java:12)
> at org.junit.runners.model.FrameworkMethod.invokeExplosively(
> FrameworkMethod.java:44)
> at org.junit.internal.runners.statements.InvokeMethod.
> evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(
> BlockJUnit4ClassRunner.java:70)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(
> BlockJUnit4ClassRunner.java:50)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
> at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(
> JUnit4IdeaTestRunner.java:68)
> at com.i

[GitHub] jena pull request #407: Cleanup

2018-04-25 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/407


---


[jira] [Commented] (JENA-1531) Fuseki does not print correct status code in NCSA request log

2018-04-25 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451995#comment-16451995
 ] 

ASF subversion and git services commented on JENA-1531:
---

Commit e931e19a76c7300c8fab34472215bcd19d2821ac in jena's branch 
refs/heads/master from [~andy.seaborne]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=e931e19 ]

JENA-1531: start/finish request as part of ActionBase.doCommon

> Fuseki does not print correct status code in NCSA request log
> -
>
> Key: JENA-1531
> URL: https://issues.apache.org/jira/browse/JENA-1531
> Project: Apache Jena
>  Issue Type: Task
>Affects Versions: Jena 3.7.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
> Fix For: Jena 3.8.0
>
>
> Fuseki does not print correct status code in NCSA request log because the 
> request log entry is printed out as any error code is passed up by exception 
> and before the response status is set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JENA-1524) org.apache.jena.system is split by org.apache.jena.arq and org.apache.jena.core

2018-04-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451988#comment-16451988
 ] 

ASF GitHub Bot commented on JENA-1524:
--

Github user afs commented on the issue:

https://github.com/apache/jena/pull/401
  
PR merged and email sent to dev@jena to let everyone know this has an 
impact on ServiceLoader files.


> org.apache.jena.system is split by org.apache.jena.arq and 
> org.apache.jena.core
> ---
>
> Key: JENA-1524
> URL: https://issues.apache.org/jira/browse/JENA-1524
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.7.0
>Reporter: Christopher Johnson
>Priority: Major
>
> a JPMS module cannot require both org.apache.jena.arq and 
> org.apache.jena.core since org.apache.jena.system can be read from both.  
> This cannot be resolved with --patch-module since arq and core provide 
> different implementations.  Suggestion is to make a distinction by renaming 
> system to sys in either one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-25 Thread afs
Github user afs commented on the issue:

https://github.com/apache/jena/pull/401
  
PR merged and email sent to dev@jena to let everyone know this has an 
impact on ServiceLoader files.


---


[jira] [Commented] (JENA-1524) org.apache.jena.system is split by org.apache.jena.arq and org.apache.jena.core

2018-04-25 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451982#comment-16451982
 ] 

ASF subversion and git services commented on JENA-1524:
---

Commit 66a8ff47e088225633a07cb224e667721323d7f9 in jena's branch 
refs/heads/master from [~andy.seaborne]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=66a8ff4 ]

JENA-1524: Rename services files for JenaSubsystemLifecycle


> org.apache.jena.system is split by org.apache.jena.arq and 
> org.apache.jena.core
> ---
>
> Key: JENA-1524
> URL: https://issues.apache.org/jira/browse/JENA-1524
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.7.0
>Reporter: Christopher Johnson
>Priority: Major
>
> a JPMS module cannot require both org.apache.jena.arq and 
> org.apache.jena.core since org.apache.jena.system can be read from both.  
> This cannot be resolved with --patch-module since arq and core provide 
> different implementations.  Suggestion is to make a distinction by renaming 
> system to sys in either one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JENA-1524) org.apache.jena.system is split by org.apache.jena.arq and org.apache.jena.core

2018-04-25 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451981#comment-16451981
 ] 

ASF subversion and git services commented on JENA-1524:
---

Commit 6a30cdca901ad9810f27c0b987e7d1c00d782d1a in jena's branch 
refs/heads/master from [~andy.seaborne]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=6a30cdc ]

JENA-1524: Merge commit 'refs/pull/401/head' of https://github.com/apache/jena

This closes #401.


> org.apache.jena.system is split by org.apache.jena.arq and 
> org.apache.jena.core
> ---
>
> Key: JENA-1524
> URL: https://issues.apache.org/jira/browse/JENA-1524
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.7.0
>Reporter: Christopher Johnson
>Priority: Major
>
> a JPMS module cannot require both org.apache.jena.arq and 
> org.apache.jena.core since org.apache.jena.system can be read from both.  
> This cannot be resolved with --patch-module since arq and core provide 
> different implementations.  Suggestion is to make a distinction by renaming 
> system to sys in either one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JENA-1524) org.apache.jena.system is split by org.apache.jena.arq and org.apache.jena.core

2018-04-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451984#comment-16451984
 ] 

ASF GitHub Bot commented on JENA-1524:
--

Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/401


> org.apache.jena.system is split by org.apache.jena.arq and 
> org.apache.jena.core
> ---
>
> Key: JENA-1524
> URL: https://issues.apache.org/jira/browse/JENA-1524
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.7.0
>Reporter: Christopher Johnson
>Priority: Major
>
> a JPMS module cannot require both org.apache.jena.arq and 
> org.apache.jena.core since org.apache.jena.system can be read from both.  
> This cannot be resolved with --patch-module since arq and core provide 
> different implementations.  Suggestion is to make a distinction by renaming 
> system to sys in either one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JENA-1524) org.apache.jena.system is split by org.apache.jena.arq and org.apache.jena.core

2018-04-25 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451980#comment-16451980
 ] 

ASF subversion and git services commented on JENA-1524:
---

Commit d82328d905b0f8ae40f60ffe800728824975 in jena's branch 
refs/heads/master from [~christopher-johnson]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=d82328d ]

 [JENA-1524] org.apache.jena.system is split by org.apache.jena.arq and 
org.apache.jena.core


> org.apache.jena.system is split by org.apache.jena.arq and 
> org.apache.jena.core
> ---
>
> Key: JENA-1524
> URL: https://issues.apache.org/jira/browse/JENA-1524
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.7.0
>Reporter: Christopher Johnson
>Priority: Major
>
> a JPMS module cannot require both org.apache.jena.arq and 
> org.apache.jena.core since org.apache.jena.system can be read from both.  
> This cannot be resolved with --patch-module since arq and core provide 
> different implementations.  Suggestion is to make a distinction by renaming 
> system to sys in either one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena pull request #401: [JENA-1524] org.apache.jena.system is split by org.a...

2018-04-25 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/401


---


[jira] [Commented] (JENA-1524) org.apache.jena.system is split by org.apache.jena.arq and org.apache.jena.core

2018-04-25 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451960#comment-16451960
 ] 

ASF subversion and git services commented on JENA-1524:
---

Commit 1830060 from [~andy.seaborne] in branch 'site/trunk'
[ https://svn.apache.org/r1830060 ]

JENA-1524: org.apache.jena.system -> org.apache.jena.sys

> org.apache.jena.system is split by org.apache.jena.arq and 
> org.apache.jena.core
> ---
>
> Key: JENA-1524
> URL: https://issues.apache.org/jira/browse/JENA-1524
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.7.0
>Reporter: Christopher Johnson
>Priority: Major
>
> a JPMS module cannot require both org.apache.jena.arq and 
> org.apache.jena.core since org.apache.jena.system can be read from both.  
> This cannot be resolved with --patch-module since arq and core provide 
> different implementations.  Suggestion is to make a distinction by renaming 
> system to sys in either one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Impact of init change / Java9

2018-04-25 Thread Andy Seaborne
JENA-1524, PR#401, from christopher-johnson who is working on TrellisLDP 
with Java9 modules.


It addresses a split package, org.apache.jena.system, between jena-arq 
and jena-core.  Java9 modules does not allow split packages.


I'm just finishing up this PR and merging it into the codebase; it has a 
wider impact so here is a heads-up on that.


To clear the package split, PR#401 renames the jena-core package 
org.apache.jena.sys, and puts an adapter class for the JenaSystem (used 
for .init()) into jena-arq/org.apache.jena.system.


This is less disruptive because Txn is in jena-arq/org.apache.jena.system.

It does however, have a knock on effect because the service loader 
initialization files are org.apache.jena.system.JenaSubsystemLifecycle.


Renaming these to org.apache.jena.sys.JenaSubsystemLifecycle will impact 
any Jena applications that hook into Jena initialization.  There are 
going to be less of these than using Txn so it seems less disruptive 
this way round.


I haven't thought of a way to smooth the transition. Adapters seem to 
end up duplicating the init process looking for both names which is 
instant technical debt.


Moving init into jena-arq and having jena-core be special carries a risk 
because the jena-core/jena-arq init is quite sensitive to the wonders of 
Java class initialization and ordering (that is, how to have undefined 
final statics!). It does work in the test suite but that is hardly 
representative because apps do first use Jena in weird and an unexpected 
ways.


The most exposed part of the service loader is repacking Jena jars. This 
will not be affected if following the instructions in jena-repack[1] 
which is necessary for any service loader files (there are others that 
Jena picks up).


Andy

[1] https://jena.apache.org/documentation/notes/jena-repack.html


[jira] [Resolved] (JENA-1488) SelectiveFoldingFilter for jena-text

2018-04-25 Thread Osma Suominen (JIRA)

 [ 
https://issues.apache.org/jira/browse/JENA-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Osma Suominen resolved JENA-1488.
-
Resolution: Fixed

Docs are good now, thanks [~kinow]! You're right [~andy.seaborne], this issue 
can now be resolved so I'm doing that. Phew!

> SelectiveFoldingFilter for jena-text
> 
>
> Key: JENA-1488
> URL: https://issues.apache.org/jira/browse/JENA-1488
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Text
>Affects Versions: Jena 3.6.0
>Reporter: Osma Suominen
>Assignee: Bruno P. Kinoshita
>Priority: Major
> Fix For: Jena 3.8.0
>
>
> Currently there's some support for accent folding in jena-text, because 
> Lucene provides an ASCIIFoldingFilter. When this filter is enabled, a search 
> for "deja vu" will match the literal "déjà vu" in the data.
> But we can't use it here at the National Library of Finland (for Finto.fi / 
> Skosmos), because it folds too much! In the Finnish alphabet, in addition to 
> the Latin a-z (which are in ASCII) we use the letters åäö and these should 
> not be folded to ASCII. So we need a Lucene analyzer that can be configured 
> with an exclude list, something like 
>  
> new SelectiveFoldingFilter(String excludeChars) 
>  
> and that can be also be configured via the Jena assembler just like other 
> analyzers supported by jena-text. 
>  
> This was also briefly discussed on the skosmos-users mailing list: 
> [https://groups.google.com/d/msg/skosmos-users/x3zR_uRBQT0/Q90-O_iDAQAJ] 
> Apparently Norwegians have the same problem...
> I've discussed this with [~kinow] and he has some initial code to implement 
> this feature, so I think we can turn this into a PR fairly soon.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JENA-632) Generate JSON from SPARQL directly.

2018-04-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451879#comment-16451879
 ] 

ASF GitHub Bot commented on JENA-632:
-

Github user kinow commented on the issue:

https://github.com/apache/jena/pull/114
  
@afs also removed the `Number()` clause as that was not being used any 
more. Ready for review again :+1: 

And big thanks for all the feedback (and patience!) so far.


> Generate JSON from SPARQL directly.
> ---
>
> Key: JENA-632
> URL: https://issues.apache.org/jira/browse/JENA-632
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: ARQ, Fuseki
>Reporter: Andy Seaborne
>Assignee: Bruno P. Kinoshita
>Priority: Minor
>  Labels: java, javacc
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The capability to generate JSON directly from a SPARQL (or extended SPARQL) 
> query would enable the creation of JSON data API over published linked data.
> This project would cover:
> # Design and publication of a design.
> # Refinement of design based on community feed
> # Implementation, including testing.
> # Refinement of implementation based on community feed
> Skills required: Java, some parser work, design and discussion with the user 
> community, basic understanding of HTTP and content negotiation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-04-25 Thread kinow
Github user kinow commented on the issue:

https://github.com/apache/jena/pull/114
  
@afs also removed the `Number()` clause as that was not being used any 
more. Ready for review again :+1: 

And big thanks for all the feedback (and patience!) so far.


---


[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-04-25 Thread kinow
Github user kinow commented on a diff in the pull request:

https://github.com/apache/jena/pull/114#discussion_r183974343
  
--- Diff: jena-arq/Grammar/master.jj ---
@@ -2176,6 +2251,19 @@ String String() : { Token t ; String lex ; }
 }
 }
 
+#ifdef ARQ
+Number Number() : { Token t ; Number number ; }
+{
+  (
+t = < INTEGER > { number = integerValue(t.image) ; }
+  | t = < DECIMAL > { number = doubleValue(t.image) ; }
--- End diff --

@afs nice catch in that observation. Reduced code duplication and avoids 
now possible "forgot to apply to the other part of the json clause" issues in 
the future :-)

Change applied. Rebased, ran all tests, tried three queries mentioned in 
this pull request (we have a few already! :smiley: ), got no issues.

Pushing the latest code, rebased onto the maste branch.


---


[jira] [Commented] (JENA-632) Generate JSON from SPARQL directly.

2018-04-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451848#comment-16451848
 ] 

ASF GitHub Bot commented on JENA-632:
-

Github user kinow commented on a diff in the pull request:

https://github.com/apache/jena/pull/114#discussion_r183974343
  
--- Diff: jena-arq/Grammar/master.jj ---
@@ -2176,6 +2251,19 @@ String String() : { Token t ; String lex ; }
 }
 }
 
+#ifdef ARQ
+Number Number() : { Token t ; Number number ; }
+{
+  (
+t = < INTEGER > { number = integerValue(t.image) ; }
+  | t = < DECIMAL > { number = doubleValue(t.image) ; }
--- End diff --

@afs nice catch in that observation. Reduced code duplication and avoids 
now possible "forgot to apply to the other part of the json clause" issues in 
the future :-)

Change applied. Rebased, ran all tests, tried three queries mentioned in 
this pull request (we have a few already! :smiley: ), got no issues.

Pushing the latest code, rebased onto the maste branch.


> Generate JSON from SPARQL directly.
> ---
>
> Key: JENA-632
> URL: https://issues.apache.org/jira/browse/JENA-632
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: ARQ, Fuseki
>Reporter: Andy Seaborne
>Assignee: Bruno P. Kinoshita
>Priority: Minor
>  Labels: java, javacc
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The capability to generate JSON directly from a SPARQL (or extended SPARQL) 
> query would enable the creation of JSON data API over published linked data.
> This project would cover:
> # Design and publication of a design.
> # Refinement of design based on community feed
> # Implementation, including testing.
> # Refinement of implementation based on community feed
> Skills required: Java, some parser work, design and discussion with the user 
> community, basic understanding of HTTP and content negotiation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)