[jira] [Commented] (JENA-1609) Jena master does not build under JDK10
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636347#comment-16636347 ] ASF GitHub Bot commented on JENA-1609: -- Github user lewismc commented on the issue: https://github.com/apache/jena/pull/474 I have not tried this build under JDK11 yet. > Jena master does not build under JDK10 > -- > > Key: JENA-1609 > URL: https://issues.apache.org/jira/browse/JENA-1609 > Project: Apache Jena > Issue Type: Improvement > Components: Build, Documentation > Environment: Apache Maven 3.5.4 > (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00) > Maven home: /usr/local/Cellar/maven/3.5.4/libexec > Java version: 10.0.2, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" >Reporter: Lewis John McGibbney >Priority: Major > Fix For: Jena 3.9.0 > > > When I attempt build under Oracle JDK 10 there are several issues which cause > the build to fail. The following PR addresses these issues and enables me to > build and run Jena master under JDK 10. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1609) Jena master does not build under JDK10
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636346#comment-16636346 ] ASF GitHub Bot commented on JENA-1609: -- Github user lewismc commented on the issue: https://github.com/apache/jena/pull/474 @afs how about we propose the change to ``` -html4 ``` This would produce JDK WARNING's under several environment's however would at least enable successful build under this environments. > Jena master does not build under JDK10 > -- > > Key: JENA-1609 > URL: https://issues.apache.org/jira/browse/JENA-1609 > Project: Apache Jena > Issue Type: Improvement > Components: Build, Documentation > Environment: Apache Maven 3.5.4 > (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00) > Maven home: /usr/local/Cellar/maven/3.5.4/libexec > Java version: 10.0.2, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" >Reporter: Lewis John McGibbney >Priority: Major > Fix For: Jena 3.9.0 > > > When I attempt build under Oracle JDK 10 there are several issues which cause > the build to fail. The following PR addresses these issues and enables me to > build and run Jena master under JDK 10. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user lewismc commented on the issue: https://github.com/apache/jena/pull/474 I have not tried this build under JDK11 yet. ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user lewismc commented on the issue: https://github.com/apache/jena/pull/474 @afs how about we propose the change to ``` -html4 ``` This would produce JDK WARNING's under several environment's however would at least enable successful build under this environments. ---
[jira] [Commented] (JENA-1609) Jena master does not build under JDK10
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636345#comment-16636345 ] ASF GitHub Bot commented on JENA-1609: -- Github user lewismc commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r222164323 --- Diff: jena-jdbc/jena-jdbc-core/pom.xml --- @@ -39,17 +39,28 @@ 3.10.0-SNAPSHOT - - - org.slf4j - slf4j-log4j12 - + + + org.slf4j + slf4j-log4j12 + + + + log4j + log4j + + + + org.apache.logging.log4j + log4j-api + + + + + org.apache.logging.log4j --- End diff -- OK so we agree on this however the code doesn't build due to the missing dependency. I wasn't able to build without the additions as proposed. > Jena master does not build under JDK10 > -- > > Key: JENA-1609 > URL: https://issues.apache.org/jira/browse/JENA-1609 > Project: Apache Jena > Issue Type: Improvement > Components: Build, Documentation > Environment: Apache Maven 3.5.4 > (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00) > Maven home: /usr/local/Cellar/maven/3.5.4/libexec > Java version: 10.0.2, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" >Reporter: Lewis John McGibbney >Priority: Major > Fix For: Jena 3.9.0 > > > When I attempt build under Oracle JDK 10 there are several issues which cause > the build to fail. The following PR addresses these issues and enables me to > build and run Jena master under JDK 10. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10
Github user lewismc commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r222164323 --- Diff: jena-jdbc/jena-jdbc-core/pom.xml --- @@ -39,17 +39,28 @@ 3.10.0-SNAPSHOT - - - org.slf4j - slf4j-log4j12 - + + + org.slf4j + slf4j-log4j12 + + + + log4j + log4j + + + + org.apache.logging.log4j + log4j-api + + + + + org.apache.logging.log4j --- End diff -- OK so we agree on this however the code doesn't build due to the missing dependency. I wasn't able to build without the additions as proposed. ---
[jira] [Commented] (JENA-1609) Jena master does not build under JDK10
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636343#comment-16636343 ] ASF GitHub Bot commented on JENA-1609: -- Github user lewismc commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r222164161 --- Diff: jena-jdbc/jena-jdbc-core/pom.xml --- @@ -39,17 +39,28 @@ 3.10.0-SNAPSHOT - - - org.slf4j - slf4j-log4j12 - + + + org.slf4j + slf4j-log4j12 + + + + log4j + log4j + + + --- End diff -- Ok thanks @rvesse. The logic seems clear from what you wrote, it doesn't however take away from the fact that the codebase will not build under JDK10 (and possibly JDK9) without the presence of the log4j library containing org.apache.log4j.PropertyConfigurator as currently used within jena/jena-jdbc/jena-jdbc-core/src/main/java/org/apache/jena/jdbc/JenaDriver.java. The issue here is to either refactor the logging or to add the dependency... I would think there is no other scenario under consideration. Is that a fair statement? > Jena master does not build under JDK10 > -- > > Key: JENA-1609 > URL: https://issues.apache.org/jira/browse/JENA-1609 > Project: Apache Jena > Issue Type: Improvement > Components: Build, Documentation > Environment: Apache Maven 3.5.4 > (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00) > Maven home: /usr/local/Cellar/maven/3.5.4/libexec > Java version: 10.0.2, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" >Reporter: Lewis John McGibbney >Priority: Major > Fix For: Jena 3.9.0 > > > When I attempt build under Oracle JDK 10 there are several issues which cause > the build to fail. The following PR addresses these issues and enables me to > build and run Jena master under JDK 10. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10
Github user lewismc commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r222164161 --- Diff: jena-jdbc/jena-jdbc-core/pom.xml --- @@ -39,17 +39,28 @@ 3.10.0-SNAPSHOT - - - org.slf4j - slf4j-log4j12 - + + + org.slf4j + slf4j-log4j12 + + + + log4j + log4j + + + --- End diff -- Ok thanks @rvesse. The logic seems clear from what you wrote, it doesn't however take away from the fact that the codebase will not build under JDK10 (and possibly JDK9) without the presence of the log4j library containing org.apache.log4j.PropertyConfigurator as currently used within jena/jena-jdbc/jena-jdbc-core/src/main/java/org/apache/jena/jdbc/JenaDriver.java. The issue here is to either refactor the logging or to add the dependency... I would think there is no other scenario under consideration. Is that a fair statement? ---
[jira] [Commented] (JENA-1609) Jena master does not build under JDK10
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635452#comment-16635452 ] ASF GitHub Bot commented on JENA-1609: -- Github user rvesse commented on the issue: https://github.com/apache/jena/pull/474 @afs For some projects where I have added JDK 9/10 support I have had to create separate profiles activated by JDK version for the Javadoc plugin because there are breaking changes between the plugin versions and supported flags for the underlying `javadoc` tool Also if you have updated the Javadoc plugin version to a 3.x release then you need to add an `` sub-element within `` rather than just specifying the options directly > Jena master does not build under JDK10 > -- > > Key: JENA-1609 > URL: https://issues.apache.org/jira/browse/JENA-1609 > Project: Apache Jena > Issue Type: Improvement > Components: Build, Documentation > Environment: Apache Maven 3.5.4 > (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00) > Maven home: /usr/local/Cellar/maven/3.5.4/libexec > Java version: 10.0.2, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" >Reporter: Lewis John McGibbney >Priority: Major > Fix For: Jena 3.9.0 > > > When I attempt build under Oracle JDK 10 there are several issues which cause > the build to fail. The following PR addresses these issues and enables me to > build and run Jena master under JDK 10. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/474 @afs For some projects where I have added JDK 9/10 support I have had to create separate profiles activated by JDK version for the Javadoc plugin because there are breaking changes between the plugin versions and supported flags for the underlying `javadoc` tool Also if you have updated the Javadoc plugin version to a 3.x release then you need to add an `` sub-element within `` rather than just specifying the options directly ---
[jira] [Commented] (JENA-1606) add OpenAnnotation and ActivityStream vocabulary
[ https://issues.apache.org/jira/browse/JENA-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635444#comment-16635444 ] ASF GitHub Bot commented on JENA-1606: -- GitHub user eroux opened a pull request: https://github.com/apache/jena/pull/475 add AS and OA vocabularies Related to [JENA-1606](https://issues.apache.org/jira/browse/JENA-1606) You can merge this pull request into a Git repository by running: $ git pull https://github.com/BuddhistDigitalResourceCenter/jena JENA-1606-AS-OA Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/475.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #475 commit c82711914bbb77dd43cd1748372118a356006a0c Author: Elie Roux Date: 2018-10-02T12:57:26Z add AS and OA vocabularies > add OpenAnnotation and ActivityStream vocabulary > > > Key: JENA-1606 > URL: https://issues.apache.org/jira/browse/JENA-1606 > Project: Apache Jena > Issue Type: Improvement > Components: Core >Reporter: Elie Roux >Priority: Minor > > I've created vocabulary classes for OA (Open Annotation) and AS (Activity > Stream) vocabulary, both are used in Web annotations. They're in > [https://github.com/BuddhistDigitalResourceCenter/lds-pdi/tree/master/src/main/java/io/bdrc/ldspdi/annotations] > I can open a pull request if desired. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] jena pull request #475: add AS and OA vocabularies
GitHub user eroux opened a pull request: https://github.com/apache/jena/pull/475 add AS and OA vocabularies Related to [JENA-1606](https://issues.apache.org/jira/browse/JENA-1606) You can merge this pull request into a Git repository by running: $ git pull https://github.com/BuddhistDigitalResourceCenter/jena JENA-1606-AS-OA Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/475.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #475 commit c82711914bbb77dd43cd1748372118a356006a0c Author: Elie Roux Date: 2018-10-02T12:57:26Z add AS and OA vocabularies ---
[jira] [Commented] (JENA-1609) Jena master does not build under JDK10
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635409#comment-16635409 ] ASF GitHub Bot commented on JENA-1609: -- Github user afs commented on the issue: https://github.com/apache/jena/pull/474 I'm trying to get a single build configuration for both java10 and java8. I can't get Jena to build with java8 if `-html5` is set. It is a problem in the full build because skipping javadoc isn't an option - the distributions include javadoc by dependency. With java 10.0.2 (Ubuntu latest with the placeholder java11 - still waiting for real java11): jena-elephas-common fails because: ``` [ERROR] Failed to execute goal on project jena-elephas-common: Could not resolve dependencies for project org.apache.jena:jena-elephas-common:jar:3.10.0-SNAPSHOT: Could not find artifact jdk.tools:jdk.tools:jar:1.6 at specified path /usr/lib/jvm/java-11-openjdk-amd64/../lib/tools.jar -> [Help 1] ``` (it also used MRUnit which is a retired project) A pure maven build will put the java11 runtime (no tools.jar) on the compile classpath. @lewismc - am I right in concluding it worked for you in the IDE because the java8 runtime was on the build path? > Jena master does not build under JDK10 > -- > > Key: JENA-1609 > URL: https://issues.apache.org/jira/browse/JENA-1609 > Project: Apache Jena > Issue Type: Improvement > Components: Build, Documentation > Environment: Apache Maven 3.5.4 > (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00) > Maven home: /usr/local/Cellar/maven/3.5.4/libexec > Java version: 10.0.2, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" >Reporter: Lewis John McGibbney >Priority: Major > Fix For: Jena 3.9.0 > > > When I attempt build under Oracle JDK 10 there are several issues which cause > the build to fail. The following PR addresses these issues and enables me to > build and run Jena master under JDK 10. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user afs commented on the issue: https://github.com/apache/jena/pull/474 I'm trying to get a single build configuration for both java10 and java8. I can't get Jena to build with java8 if `-html5` is set. It is a problem in the full build because skipping javadoc isn't an option - the distributions include javadoc by dependency. With java 10.0.2 (Ubuntu latest with the placeholder java11 - still waiting for real java11): jena-elephas-common fails because: ``` [ERROR] Failed to execute goal on project jena-elephas-common: Could not resolve dependencies for project org.apache.jena:jena-elephas-common:jar:3.10.0-SNAPSHOT: Could not find artifact jdk.tools:jdk.tools:jar:1.6 at specified path /usr/lib/jvm/java-11-openjdk-amd64/../lib/tools.jar -> [Help 1] ``` (it also used MRUnit which is a retired project) A pure maven build will put the java11 runtime (no tools.jar) on the compile classpath. @lewismc - am I right in concluding it worked for you in the IDE because the java8 runtime was on the build path? ---
[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r221928887 --- Diff: jena-jdbc/jena-jdbc-core/pom.xml --- @@ -39,17 +39,28 @@ 3.10.0-SNAPSHOT - - - org.slf4j - slf4j-log4j12 - + + + org.slf4j + slf4j-log4j12 + + + + log4j + log4j + + + + org.apache.logging.log4j + log4j-api + + + + + org.apache.logging.log4j --- End diff -- Agreed - I checked using the current master branch. Only log4j1 is used (log4j::log4j). What I am baffled by is that fact it builds with java8 and not with java10 and the failure is a dependency missing. log4j1 is a "optional" dependency in the parent. ---
[jira] [Commented] (JENA-1609) Jena master does not build under JDK10
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635392#comment-16635392 ] ASF GitHub Bot commented on JENA-1609: -- Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r221928887 --- Diff: jena-jdbc/jena-jdbc-core/pom.xml --- @@ -39,17 +39,28 @@ 3.10.0-SNAPSHOT - - - org.slf4j - slf4j-log4j12 - + + + org.slf4j + slf4j-log4j12 + + + + log4j + log4j + + + + org.apache.logging.log4j + log4j-api + + + + + org.apache.logging.log4j --- End diff -- Agreed - I checked using the current master branch. Only log4j1 is used (log4j::log4j). What I am baffled by is that fact it builds with java8 and not with java10 and the failure is a dependency missing. log4j1 is a "optional" dependency in the parent. > Jena master does not build under JDK10 > -- > > Key: JENA-1609 > URL: https://issues.apache.org/jira/browse/JENA-1609 > Project: Apache Jena > Issue Type: Improvement > Components: Build, Documentation > Environment: Apache Maven 3.5.4 > (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00) > Maven home: /usr/local/Cellar/maven/3.5.4/libexec > Java version: 10.0.2, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" >Reporter: Lewis John McGibbney >Priority: Major > Fix For: Jena 3.9.0 > > > When I attempt build under Oracle JDK 10 there are several issues which cause > the build to fail. The following PR addresses these issues and enables me to > build and run Jena master under JDK 10. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1609) Jena master does not build under JDK10
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635212#comment-16635212 ] ASF GitHub Bot commented on JENA-1609: -- Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r221885106 --- Diff: jena-jdbc/jena-jdbc-core/pom.xml --- @@ -39,17 +39,28 @@ 3.10.0-SNAPSHOT - - - org.slf4j - slf4j-log4j12 - + + + org.slf4j + slf4j-log4j12 + + + + log4j + log4j + + + + org.apache.logging.log4j + log4j-api + + + + + org.apache.logging.log4j --- End diff -- I think this is unnecessary, the only Log4j direct usage is to configure Log4j, the code itself always uses SLF4J for its logging > Jena master does not build under JDK10 > -- > > Key: JENA-1609 > URL: https://issues.apache.org/jira/browse/JENA-1609 > Project: Apache Jena > Issue Type: Improvement > Components: Build, Documentation > Environment: Apache Maven 3.5.4 > (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00) > Maven home: /usr/local/Cellar/maven/3.5.4/libexec > Java version: 10.0.2, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" >Reporter: Lewis John McGibbney >Priority: Major > Fix For: Jena 3.9.0 > > > When I attempt build under Oracle JDK 10 there are several issues which cause > the build to fail. The following PR addresses these issues and enables me to > build and run Jena master under JDK 10. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1609) Jena master does not build under JDK10
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635211#comment-16635211 ] ASF GitHub Bot commented on JENA-1609: -- Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r221884001 --- Diff: jena-jdbc/jena-jdbc-core/pom.xml --- @@ -39,17 +39,28 @@ 3.10.0-SNAPSHOT - - - org.slf4j - slf4j-log4j12 - + + + org.slf4j + slf4j-log4j12 + + + + log4j + log4j + + + --- End diff -- `JenaDriver` can optionally configure Log4j, this is because JDBC drivers can be used in contexts where the end user can't directly configure logging e.g. when dropped into other applications. In those contexts users can add `logging=` to have the driver configure logging for them. However the default behaviour is to not configure anything and all the code internally uses SLF4J so in environments where users can control logging configuration they are free to do that. So in environments where the user fully controls things they can configure logging as appropriate. > Jena master does not build under JDK10 > -- > > Key: JENA-1609 > URL: https://issues.apache.org/jira/browse/JENA-1609 > Project: Apache Jena > Issue Type: Improvement > Components: Build, Documentation > Environment: Apache Maven 3.5.4 > (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00) > Maven home: /usr/local/Cellar/maven/3.5.4/libexec > Java version: 10.0.2, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" >Reporter: Lewis John McGibbney >Priority: Major > Fix For: Jena 3.9.0 > > > When I attempt build under Oracle JDK 10 there are several issues which cause > the build to fail. The following PR addresses these issues and enables me to > build and run Jena master under JDK 10. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r221884001 --- Diff: jena-jdbc/jena-jdbc-core/pom.xml --- @@ -39,17 +39,28 @@ 3.10.0-SNAPSHOT - - - org.slf4j - slf4j-log4j12 - + + + org.slf4j + slf4j-log4j12 + + + + log4j + log4j + + + --- End diff -- `JenaDriver` can optionally configure Log4j, this is because JDBC drivers can be used in contexts where the end user can't directly configure logging e.g. when dropped into other applications. In those contexts users can add `logging=` to have the driver configure logging for them. However the default behaviour is to not configure anything and all the code internally uses SLF4J so in environments where users can control logging configuration they are free to do that. So in environments where the user fully controls things they can configure logging as appropriate. ---
[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r221885106 --- Diff: jena-jdbc/jena-jdbc-core/pom.xml --- @@ -39,17 +39,28 @@ 3.10.0-SNAPSHOT - - - org.slf4j - slf4j-log4j12 - + + + org.slf4j + slf4j-log4j12 + + + + log4j + log4j + + + + org.apache.logging.log4j + log4j-api + + + + + org.apache.logging.log4j --- End diff -- I think this is unnecessary, the only Log4j direct usage is to configure Log4j, the code itself always uses SLF4J for its logging ---
